Re: [PATCH] guix: python-build-system: Properly inform caller about test status.
On Thu, Jan 05, 2017 at 02:31:41PM +0100, Marius Bakke wrote: > Danny Milosavljevic writes: > > > * guix/build/python-build-system.scm (check): Properly inform caller about > > test status. > This is fixed with e46a043ecd9f9ef46d1d44393362bb7016454544 from the > 'python-tests' branch. Speaking of which, there are still some failing > packages in that branch listed at: > https://hydra.gnu.org/eval/109407?compare=master#tabs-now-fail > > I'll try to take care of the remaining failures in the next week so we > can merge this branch. Contributions are always welcome however ;-) +1 :) signature.asc Description: PGP signature
Re: [PATCH] guix: python-build-system: Properly inform caller about test status.
Danny Milosavljevic writes: > * guix/build/python-build-system.scm (check): Properly inform caller about > test status. > --- > guix/build/python-build-system.scm | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/guix/build/python-build-system.scm > b/guix/build/python-build-system.scm > index 3f280b0ac..d46739827 100644 > --- a/guix/build/python-build-system.scm > +++ b/guix/build/python-build-system.scm > @@ -136,12 +136,13 @@ >;; build/lib in some cases, e.g. if the source is in a sub-directory >;; (given with `package_dir`). This will by copied to the output, too, >;; so we need to remove. > - (let ((before (find-files "build" "\\.egg-info$" #:directories? #t))) > -(call-setuppy test-target '() use-setuptools?) > -(let* ((after (find-files "build" "\\.egg-info$" #:directories? #t)) > - (inter (lset-difference eqv? after before))) > - (for-each delete-file-recursively inter))) > -#t)) > + (let* ((before (find-files "build" "\\.egg-info$" #:directories? #t)) > + (status (call-setuppy test-target '() use-setuptools?)) > + (after (find-files "build" "\\.egg-info$" #:directories? #t)) > + (inter (lset-difference eqv? after before))) > +(for-each delete-file-recursively inter) > +status) > + #t)) This is fixed with e46a043ecd9f9ef46d1d44393362bb7016454544 from the 'python-tests' branch. Speaking of which, there are still some failing packages in that branch listed at: https://hydra.gnu.org/eval/109407?compare=master#tabs-now-fail I'll try to take care of the remaining failures in the next week so we can merge this branch. Contributions are always welcome however ;-) signature.asc Description: PGP signature
Re: [PATCH] guix: python-build-system: Properly inform caller about test status.
Am 05.01.2017 um 00:30 schrieb Danny Milosavljevic: >;; build/lib in some cases, e.g. if the source is in a sub-directory >;; (given with `package_dir`). This will by copied to the output, too, >;; so we need to remove. Maybe you could take the change updating my bad English comment :-) Otherwise LGTM. -- Regards Hartmut Goebel | Hartmut Goebel | h.goe...@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |
[PATCH] guix: python-build-system: Properly inform caller about test status.
* guix/build/python-build-system.scm (check): Properly inform caller about test status. --- guix/build/python-build-system.scm | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm index 3f280b0ac..d46739827 100644 --- a/guix/build/python-build-system.scm +++ b/guix/build/python-build-system.scm @@ -136,12 +136,13 @@ ;; build/lib in some cases, e.g. if the source is in a sub-directory ;; (given with `package_dir`). This will by copied to the output, too, ;; so we need to remove. - (let ((before (find-files "build" "\\.egg-info$" #:directories? #t))) -(call-setuppy test-target '() use-setuptools?) -(let* ((after (find-files "build" "\\.egg-info$" #:directories? #t)) - (inter (lset-difference eqv? after before))) - (for-each delete-file-recursively inter))) -#t)) + (let* ((before (find-files "build" "\\.egg-info$" #:directories? #t)) + (status (call-setuppy test-target '() use-setuptools?)) + (after (find-files "build" "\\.egg-info$" #:directories? #t)) + (inter (lset-difference eqv? after before))) +(for-each delete-file-recursively inter) +status) + #t)) (define (get-python-version python) (let* ((version (last (string-split python #\-)))