[jira] [Commented] (HDFS-17103) messy file system cleanup in TestNameEditsConfigs
[ https://issues.apache.org/jira/browse/HDFS-17103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829323#comment-17829323 ] ASF GitHub Bot commented on HDFS-17103: --- teamconfx commented on PR #6071: URL: https://github.com/apache/hadoop/pull/6071#issuecomment-2010748510 Hi @ayushtkn are we able to merge this? > messy file system cleanup in TestNameEditsConfigs > - > > Key: HDFS-17103 > URL: https://issues.apache.org/jira/browse/HDFS-17103 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: ConfX >Priority: Critical > Labels: pull-request-available > Attachments: reproduce.sh > > > h2. What happened: > Got a {{NullPointerException}} without message when running > {{{}TestNameEditsConfigs{}}}. > h2. Where's the bug: > In line 450 of {{{}TestNameEditsConfigs{}}}, the test attempts to cleanup the > file system: > > {noformat} > ... > fileSys = cluster.getFileSystem(); > ... > } finally { > fileSys.close(); > cluster.shutdown(); > }{noformat} > However, the cleanup would result in a {{NullPointerException}} that covers > up the actual exception if the initialization of {{fileSys}} fails or another > exception is thrown before the line that initializes {{{}fileSys{}}}. > h2. How to reproduce: > (1) Set {{dfs.namenode.maintenance.replication.min}} to {{-1155969698}} > (2) Run test: > {{org.apache.hadoop.hdfs.server.namenode.TestNameEditsConfigs#testNameEditsConfigsFailure}} > h2. Stacktrace: > {noformat} > java.lang.NullPointerException, > at > org.apache.hadoop.hdfs.server.namenode.TestNameEditsConfigs.testNameEditsConfigsFailure(TestNameEditsConfigs.java:450),{noformat} > For an easy reproduction, run the reproduce.sh in the attachment. > We are happy to provide a patch if this issue is confirmed. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17103) messy file system cleanup in TestNameEditsConfigs
[ https://issues.apache.org/jira/browse/HDFS-17103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765366#comment-17765366 ] ASF GitHub Bot commented on HDFS-17103: --- hadoop-yetus commented on PR #6071: URL: https://github.com/apache/hadoop/pull/6071#issuecomment-1720170527 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexec | 0m 27s | | Docker mode activated. | _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 1s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. | _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 32m 42s | | trunk passed | | +1 :green_heart: | compile | 0m 55s | | trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | compile | 0m 49s | | trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 | | +1 :green_heart: | checkstyle | 0m 44s | | trunk passed | | +1 :green_heart: | mvnsite | 0m 56s | | trunk passed | | +1 :green_heart: | javadoc | 0m 51s | | trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | javadoc | 1m 9s | | trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 | | +1 :green_heart: | spotbugs | 1m 56s | | trunk passed | | +1 :green_heart: | shadedclient | 21m 59s | | branch has no errors when building and testing our client artifacts. | _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 46s | | the patch passed | | +1 :green_heart: | compile | 0m 49s | | the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | javac | 0m 49s | | the patch passed | | +1 :green_heart: | compile | 0m 44s | | the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 | | +1 :green_heart: | javac | 0m 44s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 0m 33s | | the patch passed | | +1 :green_heart: | mvnsite | 0m 47s | | the patch passed | | +1 :green_heart: | javadoc | 0m 39s | | the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | javadoc | 1m 6s | | the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 | | +1 :green_heart: | spotbugs | 1m 53s | | the patch passed | | +1 :green_heart: | shadedclient | 22m 13s | | patch has no errors when building and testing our client artifacts. | _ Other Tests _ | | +1 :green_heart: | unit | 199m 57s | | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 0m 39s | | The patch does not generate ASF License warnings. | | | | 294m 2s | | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6071/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/6071 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets | | uname | Linux 717ea76a84f7 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / b7d14ee14400ad8eb60bf989cb81a014518f15f4 | | Default Java | Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6071/1/testReport/ | | Max. process+thread count | 3386 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6071/1/console | | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > messy file system cleanup in TestNameEditsConfigs >
[jira] [Commented] (HDFS-17103) messy file system cleanup in TestNameEditsConfigs
[ https://issues.apache.org/jira/browse/HDFS-17103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765257#comment-17765257 ] ASF GitHub Bot commented on HDFS-17103: --- teamconfx opened a new pull request, #6071: URL: https://github.com/apache/hadoop/pull/6071 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17103 This PR adds a null check for `fileSys` and `cluster` during test cleanup. ### How was this patch tested? (1) Set `dfs.namenode.maintenance.replication.min` to `-1155969698` (2) Run test: `org.apache.hadoop.hdfs.server.namenode.TestNameEditsConfigs#testNameEditsConfigsFailure` The test now shows the actual exception rather than the `NullPointerException`. ### For code changes: - [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? > messy file system cleanup in TestNameEditsConfigs > - > > Key: HDFS-17103 > URL: https://issues.apache.org/jira/browse/HDFS-17103 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: ConfX >Priority: Critical > Attachments: reproduce.sh > > > h2. What happened: > Got a {{NullPointerException}} without message when running > {{{}TestNameEditsConfigs{}}}. > h2. Where's the bug: > In line 450 of {{{}TestNameEditsConfigs{}}}, the test attempts to cleanup the > file system: > > {noformat} > ... > fileSys = cluster.getFileSystem(); > ... > } finally { > fileSys.close(); > cluster.shutdown(); > }{noformat} > However, the cleanup would result in a {{NullPointerException}} that covers > up the actual exception if the initialization of {{fileSys}} fails or another > exception is thrown before the line that initializes {{{}fileSys{}}}. > h2. How to reproduce: > (1) Set {{dfs.namenode.maintenance.replication.min}} to {{-1155969698}} > (2) Run test: > {{org.apache.hadoop.hdfs.server.namenode.TestNameEditsConfigs#testNameEditsConfigsFailure}} > h2. Stacktrace: > {noformat} > java.lang.NullPointerException, > at > org.apache.hadoop.hdfs.server.namenode.TestNameEditsConfigs.testNameEditsConfigsFailure(TestNameEditsConfigs.java:450),{noformat} > For an easy reproduction, run the reproduce.sh in the attachment. > We are happy to provide a patch if this issue is confirmed. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org