[jira] [Commented] (HDFS-2582) Scope dfs.ha.namenodes config by nameservice
[ https://issues.apache.org/jira/browse/HDFS-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158019#comment-13158019 ] Eli Collins commented on HDFS-2582: --- lgtm, +1 with the follow-on jiras. The code that uses the new map (Mapns id, Mapnn id, addr) is a little unwieldy since we don't have types for the ns and nn ids. Given that this is a tiny map the readability might be worth the overhead of a class (eg in the same vain of ConfiguredNNAddress). Don't feel strongly so feel free to punt if you disagree. Scope dfs.ha.namenodes config by nameservice Key: HDFS-2582 URL: https://issues.apache.org/jira/browse/HDFS-2582 Project: Hadoop HDFS Issue Type: Sub-task Components: data-node, name-node Affects Versions: HA branch (HDFS-1623) Reporter: Todd Lipcon Assignee: Todd Lipcon Fix For: HA branch (HDFS-1623) Attachments: hdfs-2582-v2.txt, hdfs-2582-v3.txt, hdfs-2582.txt HDFS-2231 started the process of adding configuration for HA, but one piece is missing. The current state of the configuration is, I believe: {{dfs.ha.namenodes}} - a list of identifiers for HA namenodes {{dfs.federation.nameservices}} - a list of federated nameservices {{dfs.namenode.rpc-address[.nameservice-id][.namenode-id]}} - some specific config for the given namenode. If HA or federation is disabled, the extra components can be elided for backwards compatibility. The issue here is that there is no easy way to discern which NN is paired with which other NN. Additionally, adding a new federated nameservice to a config will require changes to {{dfs.ha.namenodes}} which makes templating harder. It would be simpler to change {{dfs.ha.namenodes}} to be nameservice-scoped: {{dfs.ha.namenodes.nameservice-id}}. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2582) Scope dfs.ha.namenodes config by nameservice
[ https://issues.apache.org/jira/browse/HDFS-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158061#comment-13158061 ] Eli Collins commented on HDFS-2582: --- +1 to v4, the fix in the delta lgtm Scope dfs.ha.namenodes config by nameservice Key: HDFS-2582 URL: https://issues.apache.org/jira/browse/HDFS-2582 Project: Hadoop HDFS Issue Type: Sub-task Components: data-node, name-node Affects Versions: HA branch (HDFS-1623) Reporter: Todd Lipcon Assignee: Todd Lipcon Fix For: HA branch (HDFS-1623) Attachments: hdfs-2582-v2.txt, hdfs-2582-v3.txt, hdfs-2582-v4.txt, hdfs-2582.txt HDFS-2231 started the process of adding configuration for HA, but one piece is missing. The current state of the configuration is, I believe: {{dfs.ha.namenodes}} - a list of identifiers for HA namenodes {{dfs.federation.nameservices}} - a list of federated nameservices {{dfs.namenode.rpc-address[.nameservice-id][.namenode-id]}} - some specific config for the given namenode. If HA or federation is disabled, the extra components can be elided for backwards compatibility. The issue here is that there is no easy way to discern which NN is paired with which other NN. Additionally, adding a new federated nameservice to a config will require changes to {{dfs.ha.namenodes}} which makes templating harder. It would be simpler to change {{dfs.ha.namenodes}} to be nameservice-scoped: {{dfs.ha.namenodes.nameservice-id}}. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2582) Scope dfs.ha.namenodes config by nameservice
[ https://issues.apache.org/jira/browse/HDFS-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156260#comment-13156260 ] Eli Collins commented on HDFS-2582: --- You're proposed scheme makes sense to me. Perhaps the namespace was left in the config so each namespace could have its own web UI at some point? Scope dfs.ha.namenodes config by nameservice Key: HDFS-2582 URL: https://issues.apache.org/jira/browse/HDFS-2582 Project: Hadoop HDFS Issue Type: Sub-task Components: data-node, name-node Affects Versions: HA branch (HDFS-1623) Reporter: Todd Lipcon Assignee: Todd Lipcon Fix For: HA branch (HDFS-1623) HDFS-2231 started the process of adding configuration for HA, but one piece is missing. The current state of the configuration is, I believe: {{dfs.ha.namenodes}} - a list of identifiers for HA namenodes {{dfs.federation.nameservices}} - a list of federated nameservices {{dfs.namenode.rpc-address[.nameservice-id][.namenode-id]}} - some specific config for the given namenode. If HA or federation is disabled, the extra components can be elided for backwards compatibility. The issue here is that there is no easy way to discern which NN is paired with which other NN. Additionally, adding a new federated nameservice to a config will require changes to {{dfs.ha.namenodes}} which makes templating harder. It would be simpler to change {{dfs.ha.namenodes}} to be nameservice-scoped: {{dfs.ha.namenodes.nameservice-id}}. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira