[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200450#comment-13200450 ] Hudson commented on HDFS-2785: -- Integrated in Hadoop-Mapreduce-trunk #979 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/979/]) HDFS-2785. Update webhdfs and httpfs for host-based token support. Contributed by Robert Joseph Evans. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240460 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Fix For: 0.24.0, 0.23.1 > > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200427#comment-13200427 ] Hudson commented on HDFS-2785: -- Integrated in Hadoop-Mapreduce-0.23-Build #181 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/181/]) Merged r1240460 from trunk for HDFS-2785. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240461 Files : * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Fix For: 0.24.0, 0.23.1 > > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200407#comment-13200407 ] Hudson commented on HDFS-2785: -- Integrated in Hadoop-Hdfs-0.23-Build #159 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/159/]) Merged r1240460 from trunk for HDFS-2785. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240461 Files : * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Fix For: 0.24.0, 0.23.1 > > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200396#comment-13200396 ] Hudson commented on HDFS-2785: -- Integrated in Hadoop-Hdfs-trunk #946 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/946/]) HDFS-2785. Update webhdfs and httpfs for host-based token support. Contributed by Robert Joseph Evans. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240460 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Fix For: 0.24.0, 0.23.1 > > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200361#comment-13200361 ] Hudson commented on HDFS-2785: -- Integrated in Hadoop-Mapreduce-0.23-Commit #499 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/499/]) Merged r1240460 from trunk for HDFS-2785. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240461 Files : * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Fix For: 0.24.0, 0.23.1 > > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200360#comment-13200360 ] Hudson commented on HDFS-2785: -- Integrated in Hadoop-Mapreduce-trunk-Commit #1674 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1674/]) HDFS-2785. Update webhdfs and httpfs for host-based token support. Contributed by Robert Joseph Evans. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240460 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Fix For: 0.24.0, 0.23.1 > > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200357#comment-13200357 ] Hudson commented on HDFS-2785: -- Integrated in Hadoop-Common-0.23-Commit #486 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/486/]) Merged r1240460 from trunk for HDFS-2785. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240461 Files : * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Fix For: 0.24.0, 0.23.1 > > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200356#comment-13200356 ] Hudson commented on HDFS-2785: -- Integrated in Hadoop-Hdfs-0.23-Commit #476 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/476/]) Merged r1240460 from trunk for HDFS-2785. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240461 Files : * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Fix For: 0.24.0, 0.23.1 > > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200354#comment-13200354 ] Hudson commented on HDFS-2785: -- Integrated in Hadoop-Hdfs-trunk-Commit #1730 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1730/]) HDFS-2785. Update webhdfs and httpfs for host-based token support. Contributed by Robert Joseph Evans. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240460 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Fix For: 0.24.0, 0.23.1 > > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200353#comment-13200353 ] Hudson commented on HDFS-2785: -- Integrated in Hadoop-Common-trunk-Commit #1659 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1659/]) HDFS-2785. Update webhdfs and httpfs for host-based token support. Contributed by Robert Joseph Evans. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240460 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Fix For: 0.24.0, 0.23.1 > > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200121#comment-13200121 ] Robert Joseph Evans commented on HDFS-2785: --- Jitendra, could you please check this in, I am not an HDFS committer, I am only a committer from common and mapred. I am filing the other JIRA now. > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200075#comment-13200075 ] Jitendra Nath Pandey commented on HDFS-2785: I see, this means we should remove the method checkTGTAndReloginFromKeytab and only use reloginFromKeytab because it is redundant and confusing. No need to change the patch. Could you please file a jira to get rid of checkTGTAndReloginFromKeytab? +1 for the patch. > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[
https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199780#comment-13199780
]
Robert Joseph Evans commented on HDFS-2785:
---
I agree that checkTGTAndReloginFromKeytab is not really necessary, and I am
fine with switching it. However, If you look at UserGroupInformation.java on
trunk checkTGTAndReloginFromKeytab is the following
{code}
public synchronized void checkTGTAndReloginFromKeytab() throws IOException {
if (!isSecurityEnabled()
|| user.getAuthenticationMethod() != AuthenticationMethod.KERBEROS
|| !isKeytab)
return;
KerberosTicket tgt = getTGT();
if (tgt != null && System.currentTimeMillis() < getRefreshTime(tgt)) {
return;
}
reloginFromKeytab();
}
{code}
But a few lines down on line 697 inside reloginFromKeytab() we have the exact
same check.
{code}
KerberosTicket tgt = getTGT();
//Return if TGT is valid and is not going to expire soon.
if (tgt != null && now < getRefreshTime(tgt)) {
return;
}
{code}
and sorry if my explanation was confusing before about being consistent with
HFTP. I made the change to be consistent with the version of HFTP from
HDFS-2784, which was just merged to trunk. In that case getDelegationToken()
and renew() call reloginFromKeytab(), and cancel() calls
checkTGTAndReloginFromKeytab(). Which is what the attached patch causes WebHDFS
to do as well.
If you still want me to change it then please let me know so I can update the
patch and rerun my tests.
> Update webhdfs and httpfs for host-based token support
> --
>
> Key: HDFS-2785
> URL: https://issues.apache.org/jira/browse/HDFS-2785
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node, security
>Affects Versions: 0.24.0, 0.23.1
>Reporter: Daryn Sharp
>Assignee: Robert Joseph Evans
> Attachments: HDFS-2785.txt
>
>
> Need to port 205 tokens into these filesystems. Will mainly involve ensuring
> code duplicated from hftp is updated accordingly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199550#comment-13199550 ] Jitendra Nath Pandey commented on HDFS-2785: The last change in the patch i.e. changing from checkTGTAndReloginFromKeytab to reloginFromKeytab, doesn't seem necessary. The branch-1 code has checkTGTAndReloginFromKeytab and so does HftpFileSystem. I suppose WebHdfsFileSystem and HftpFileSystem should behave in the same way. I am sorry I should have raised this earlier and should have noticed the test results. Please ignore my previous comment. > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199239#comment-13199239 ] Robert Joseph Evans commented on HDFS-2785: --- I am a bit confused about updating the test results. The unit tests all passed with no changes to them at all. The test is very small and intended to be 100% backwards compatible. It made a few things consistent between WebHDFS and HFTP, and it change a small amount of URI processing changes where we now get data directly from the URI instead of getting it from INetSocetAddress. > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199113#comment-13199113 ] Jitendra Nath Pandey commented on HDFS-2785: Please update with test results so that we can commit. > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194305#comment-13194305 ] Jitendra Nath Pandey commented on HDFS-2785: +1 > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192483#comment-13192483 ] Robert Joseph Evans commented on HDFS-2785: --- I filed HDFS-2836 for the javadoc warnings > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[
https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192480#comment-13192480
]
Robert Joseph Evans commented on HDFS-2785:
---
The following are the warning that javadocs is exposing.
{noformat}
[WARNING]
org/apache/hadoop/fs/FileSystem.class(org/apache/hadoop/fs:FileSystem.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate': class file
for org.apache.hadoop.classification.InterfaceAudience not found
[WARNING]
org/apache/hadoop/fs/FileSystem.class(org/apache/hadoop/fs:FileSystem.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING]
org/apache/hadoop/fs/FileSystem.class(org/apache/hadoop/fs:FileSystem.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING]
org/apache/hadoop/security/Groups.class(org/apache/hadoop/security:Groups.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING]
org/apache/hadoop/security/UserGroupInformation.class(org/apache/hadoop/security:UserGroupInformation.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING]
org/apache/hadoop/security/UserGroupInformation.class(org/apache/hadoop/security:UserGroupInformation.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING]
org/apache/hadoop/security/UserGroupInformation.class(org/apache/hadoop/security:UserGroupInformation.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING]
org/apache/hadoop/fs/FSDataInputStream.class(org/apache/hadoop/fs:FSDataInputStream.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING]
org/apache/hadoop/fs/FSDataOutputStream.class(org/apache/hadoop/fs:FSDataOutputStream.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING] org/apache/hadoop/fs/Path.class(org/apache/hadoop/fs:Path.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING]
org/apache/hadoop/fs/UnresolvedLinkException.class(org/apache/hadoop/fs:UnresolvedLinkException.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING]
org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.class(org/apache/hadoop/fs:MD5MD5CRC32FileChecksum.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING]
org/apache/hadoop/fs/LocalDirAllocator.class(org/apache/hadoop/fs:LocalDirAllocator.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING]
org/apache/hadoop/fs/FileContext.class(org/apache/hadoop/fs:FileContext.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING]
org/apache/hadoop/fs/FileContext.class(org/apache/hadoop/fs:FileContext.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING]
org/apache/hadoop/fs/FSOutputSummer.class(org/apache/hadoop/fs:FSOutputSummer.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING]
org/apache/hadoop/fs/FSInputStream.class(org/apache/hadoop/fs:FSInputStream.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING]
org/apache/hadoop/fs/FSInputChecker.class(org/apache/hadoop/fs:FSInputChecker.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING] org/apache/hadoop/fs/DU.class(org/apache/hadoop/fs:DU.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING] org/apache/hadoop/fs/DF.class(org/apache/hadoop/fs:DF.class):
warning: Cannot find annotation method 'value()' in type
'org.apache.hadoop.classification.InterfaceAudience.LimitedPrivate'
[WARNING]
org/apache/hadoop/fs/AbstractFileSystem.class(org/apache/hadoop/fs:AbstractFileSyst
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192474#comment-13192474 ] Robert Joseph Evans commented on HDFS-2785: --- The find bugs issue is unrelated, but I filed HDFS-2835 to fix it. I am looking into the javadoc warnings, but as I changed no javadocs and no APIs I am fairly sure they are unrelated. I already explained why there are no new tests added. > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192425#comment-13192425 ] Hadoop QA commented on HDFS-2785: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12511699/HDFS-2785.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 21 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1804//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1804//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1804//console This message is automatically generated. > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > Attachments: HDFS-2785.txt > > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192261#comment-13192261 ] Robert Joseph Evans commented on HDFS-2785: --- I was wrong about that. Most of the code is fine, but there are a few small things that need to be changed. I am testing my patch now and will upload it shortly. > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2785) Update webhdfs and httpfs for host-based token support
[ https://issues.apache.org/jira/browse/HDFS-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185682#comment-13185682 ] Robert Joseph Evans commented on HDFS-2785: --- >From my first pass through the code there appear to be no changes needed. I >am going to do another more in-depth look to be sure. But this might just be >closed as "Not A Problem" > Update webhdfs and httpfs for host-based token support > -- > > Key: HDFS-2785 > URL: https://issues.apache.org/jira/browse/HDFS-2785 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node, security >Affects Versions: 0.24.0, 0.23.1 >Reporter: Daryn Sharp >Assignee: Robert Joseph Evans > > Need to port 205 tokens into these filesystems. Will mainly involve ensuring > code duplicated from hftp is updated accordingly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
