[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13489988#comment-13489988 ] Hudson commented on HDFS-3804: -- Integrated in Hadoop-Yarn-trunk #25 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/25/]) HDFS-3804. TestHftpFileSystem fails intermittently with JDK7 (Trevor Robinson via daryn) (Revision 1404985) Result = SUCCESS daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1404985 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpFileSystem.java TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Labels: java7 Fix For: 3.0.0, 2.0.3-alpha Attachments: HDFS-3804-2.patch, HDFS-3804-3.patch, HDFS-3804-3.patch, HDFS-3804.patch, HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490010#comment-13490010 ] Hudson commented on HDFS-3804: -- Integrated in Hadoop-Hdfs-trunk #1215 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1215/]) HDFS-3804. TestHftpFileSystem fails intermittently with JDK7 (Trevor Robinson via daryn) (Revision 1404985) Result = FAILURE daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1404985 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpFileSystem.java TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Labels: java7 Fix For: 3.0.0, 2.0.3-alpha Attachments: HDFS-3804-2.patch, HDFS-3804-3.patch, HDFS-3804-3.patch, HDFS-3804.patch, HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490018#comment-13490018 ] Hudson commented on HDFS-3804: -- Integrated in Hadoop-Mapreduce-trunk #1245 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1245/]) HDFS-3804. TestHftpFileSystem fails intermittently with JDK7 (Trevor Robinson via daryn) (Revision 1404985) Result = FAILURE daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1404985 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpFileSystem.java TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Labels: java7 Fix For: 3.0.0, 2.0.3-alpha Attachments: HDFS-3804-2.patch, HDFS-3804-3.patch, HDFS-3804-3.patch, HDFS-3804.patch, HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13489411#comment-13489411 ] Daryn Sharp commented on HDFS-3804: --- +1 Will commit shortly. TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Labels: java7 Attachments: HDFS-3804-2.patch, HDFS-3804-3.patch, HDFS-3804-3.patch, HDFS-3804.patch, HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13489663#comment-13489663 ] Hudson commented on HDFS-3804: -- Integrated in Hadoop-trunk-Commit #2950 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/2950/]) HDFS-3804. TestHftpFileSystem fails intermittently with JDK7 (Trevor Robinson via daryn) (Revision 1404985) Result = SUCCESS daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1404985 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpFileSystem.java TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Labels: java7 Fix For: 3.0.0, 2.0.3-alpha Attachments: HDFS-3804-2.patch, HDFS-3804-3.patch, HDFS-3804-3.patch, HDFS-3804.patch, HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13487767#comment-13487767 ] Daryn Sharp commented on HDFS-3804: --- +1 For consistency, do you think {{hftpFs}} should also be non-static? TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Labels: java7 Attachments: HDFS-3804-2.patch, HDFS-3804-3.patch, HDFS-3804.patch, HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13488075#comment-13488075 ] Hadoop QA commented on HDFS-3804: - {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12551578/HDFS-3804-3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3435//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3435//console This message is automatically generated. TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Labels: java7 Attachments: HDFS-3804-2.patch, HDFS-3804-3.patch, HDFS-3804-3.patch, HDFS-3804.patch, HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13487304#comment-13487304 ] Hadoop QA commented on HDFS-3804: - {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12551412/HDFS-3804-3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3430//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3430//console This message is automatically generated. TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Labels: java7 Attachments: HDFS-3804-2.patch, HDFS-3804-3.patch, HDFS-3804.patch, HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486417#comment-13486417 ] Trevor Robinson commented on HDFS-3804: --- How about this then: # Use my original approach of moving the {{testH\[s\]ftp}} methods to a new test case. They don't need or want any of the mini-cluster or filesystem setup. # Even though it's not a cause of failure currently, move just the filesystem setup to {{@Before}}, and if possible, expose and use {{cluster.getNamesystem().clear()}} to wipe the namenode. # In both test cases, use {{@After}} to perform {{FileSystem.closeAll()}}. TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Labels: java7 Attachments: HDFS-3804-2.patch, HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485109#comment-13485109 ] Trevor Robinson commented on HDFS-3804: --- Daryn (or someone else), would you please review the updated patch? I believe it addresses your comments. TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Labels: java7 Attachments: HDFS-3804-2.patch, HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485123#comment-13485123 ] Daryn Sharp commented on HDFS-3804: --- Unless the tests were conflicting, I'm a bit bothered about starting and stopping the mini-cluster for every test case when most of them don't even need the cluster running. I think you can probably leave the cluster startup/shutdown in @BeforeClass/@AfterClass. It's a shame that cluster.getNamesystem().clear() isn't exposed for testing... If you feel ambitious, you could tag it with @VisibleForTesting and then call it in a @Before to wipe out the namenode. If you try it, and it works, we should file another jira to change more tests since it might drastically cut the runtime of the test suite. TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Labels: java7 Attachments: HDFS-3804-2.patch, HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435234#comment-13435234 ] Trevor Robinson commented on HDFS-3804: --- Precommit test failure is unrelated; opened issue HDFS-3806 to track. TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Attachments: HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435539#comment-13435539 ] Daryn Sharp commented on HDFS-3804: --- A simpler approach is probably to instantiate the hftp fs in a @Before and closeAll in a @After. Then the 2nd half of the tests don't have to explicitly do the close. TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Labels: java7 Attachments: HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435600#comment-13435600 ] Trevor Robinson commented on HDFS-3804: --- Isn't the problem that the 2nd half tests (testH[s]ftp*) don't want the effects of setUp at all, since it interferes with them picking non-default ports? Given that, it seems like they should be in a separate test case that doesn't have any common setup. TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Labels: java7 Attachments: HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435622#comment-13435622 ] Daryn Sharp commented on HDFS-3804: --- The 2nd half of the tests need to ensure they get a new fs instance each time. Getting a new fs instance for all tests isn't a bad thing though. If one test changes the internal state of the fs (say changeWorkingDirectory, etc), it can contaminate the other tests. It frustrates the poor dev trying to figure out why their simple tests don't work -- hint: whose comment do you think that is? :) Something like this is what I think is needed. {code} @Before public void setupFs() { hdfs = ...; hftpFs = ...; } @After public void resetFsCache() { FileSystem.closeAll(); } {code} TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Labels: java7 Attachments: HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435626#comment-13435626 ] Trevor Robinson commented on HDFS-3804: --- I understand what you're suggesting, and wasn't concerned about a new FS instance for each test. I agree that @Before/After is a better choice than @BeforeClass/AfterClass, since saving a millisecond isn't worth the fragility. My point was just that, based on your code comment, it seemed like the filesystem created by setUp would interfere with the filesystems the 2nd half tests were creating. However, I went ahead and tried out the change, and it passed, so I guess that doesn't matter. TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Labels: java7 Attachments: HDFS-3804-2.patch, HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3804) TestHftpFileSystem fails intermittently with JDK7
[ https://issues.apache.org/jira/browse/HDFS-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435735#comment-13435735 ] Hadoop QA commented on HDFS-3804: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541155/HDFS-3804-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3018//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3018//console This message is automatically generated. TestHftpFileSystem fails intermittently with JDK7 - Key: HDFS-3804 URL: https://issues.apache.org/jira/browse/HDFS-3804 Project: Hadoop HDFS Issue Type: Bug Components: test Environment: Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.7.0_04, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.7.0_04/jre Default locale: en_US, platform encoding: ISO-8859-1 OS name: linux, version: 3.2.0-25-generic, arch: amd64, family: unix Reporter: Trevor Robinson Assignee: Trevor Robinson Labels: java7 Attachments: HDFS-3804-2.patch, HDFS-3804.patch For example: testFileNameEncoding(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed testDataNodeRedirect(org.apache.hadoop.hdfs.TestHftpFileSystem): Filesystem closed This test case sets up a filesystem that is used by the first half of the test methods (in declaration order), but the second half of the tests start by calling {{FileSystem.closeAll}}. With JDK7, test methods are run in an arbitrary order, so if any first half methods run after any second half methods, they fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira