[jira] [Commented] (HDFS-5533) Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report
[ https://issues.apache.org/jira/browse/HDFS-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832483#comment-13832483 ] Hudson commented on HDFS-5533: -- FAILURE: Integrated in Hadoop-Yarn-trunk #403 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/403/]) HDFS-5533. Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report. Contributed by Binglin Chang. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1545357) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/INodeDirectoryWithSnapshot.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotDiffReport.java Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report Key: HDFS-5533 URL: https://issues.apache.org/jira/browse/HDFS-5533 Project: Hadoop HDFS Issue Type: Bug Components: snapshots Reporter: Binglin Chang Assignee: Binglin Chang Priority: Minor Fix For: 2.3.0 Attachments: HDFS-5533.patch, HDFS-5533.v2.patch, HDFS-5533.v2.patch Currently the original code treat symlink delete/create as modify, but symlink is immutable, should be CREATE and DELETE -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-5533) Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report
[ https://issues.apache.org/jira/browse/HDFS-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832564#comment-13832564 ] Hudson commented on HDFS-5533: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1594 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1594/]) HDFS-5533. Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report. Contributed by Binglin Chang. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1545357) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/INodeDirectoryWithSnapshot.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotDiffReport.java Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report Key: HDFS-5533 URL: https://issues.apache.org/jira/browse/HDFS-5533 Project: Hadoop HDFS Issue Type: Bug Components: snapshots Reporter: Binglin Chang Assignee: Binglin Chang Priority: Minor Fix For: 2.3.0 Attachments: HDFS-5533.patch, HDFS-5533.v2.patch, HDFS-5533.v2.patch Currently the original code treat symlink delete/create as modify, but symlink is immutable, should be CREATE and DELETE -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-5533) Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report
[ https://issues.apache.org/jira/browse/HDFS-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832575#comment-13832575 ] Hudson commented on HDFS-5533: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1620 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1620/]) HDFS-5533. Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report. Contributed by Binglin Chang. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1545357) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/INodeDirectoryWithSnapshot.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotDiffReport.java Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report Key: HDFS-5533 URL: https://issues.apache.org/jira/browse/HDFS-5533 Project: Hadoop HDFS Issue Type: Bug Components: snapshots Reporter: Binglin Chang Assignee: Binglin Chang Priority: Minor Fix For: 2.3.0 Attachments: HDFS-5533.patch, HDFS-5533.v2.patch, HDFS-5533.v2.patch Currently the original code treat symlink delete/create as modify, but symlink is immutable, should be CREATE and DELETE -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-5533) Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report
[ https://issues.apache.org/jira/browse/HDFS-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831620#comment-13831620 ] Colin Patrick McCabe commented on HDFS-5533: +1. Thanks, Binglin. Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report Key: HDFS-5533 URL: https://issues.apache.org/jira/browse/HDFS-5533 Project: Hadoop HDFS Issue Type: Bug Reporter: Binglin Chang Assignee: Binglin Chang Priority: Minor Attachments: HDFS-5533.patch, HDFS-5533.v2.patch, HDFS-5533.v2.patch Currently the original code treat symlink delete/create as modify, but symlink is immutable, should be CREATE and DELETE -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-5533) Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report
[ https://issues.apache.org/jira/browse/HDFS-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831674#comment-13831674 ] Jing Zhao commented on HDFS-5533: - +1 as well. I will commit the patch shortly. Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report Key: HDFS-5533 URL: https://issues.apache.org/jira/browse/HDFS-5533 Project: Hadoop HDFS Issue Type: Bug Reporter: Binglin Chang Assignee: Binglin Chang Priority: Minor Attachments: HDFS-5533.patch, HDFS-5533.v2.patch, HDFS-5533.v2.patch Currently the original code treat symlink delete/create as modify, but symlink is immutable, should be CREATE and DELETE -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-5533) Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report
[ https://issues.apache.org/jira/browse/HDFS-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831687#comment-13831687 ] Hudson commented on HDFS-5533: -- SUCCESS: Integrated in Hadoop-trunk-Commit #4790 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4790/]) HDFS-5533. Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report. Contributed by Binglin Chang. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1545357) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/INodeDirectoryWithSnapshot.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotDiffReport.java Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report Key: HDFS-5533 URL: https://issues.apache.org/jira/browse/HDFS-5533 Project: Hadoop HDFS Issue Type: Bug Components: snapshots Reporter: Binglin Chang Assignee: Binglin Chang Priority: Minor Fix For: 2.3.0 Attachments: HDFS-5533.patch, HDFS-5533.v2.patch, HDFS-5533.v2.patch Currently the original code treat symlink delete/create as modify, but symlink is immutable, should be CREATE and DELETE -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-5533) Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report
[ https://issues.apache.org/jira/browse/HDFS-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827653#comment-13827653 ] Hadoop QA commented on HDFS-5533: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614871/HDFS-5533.v2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated -12 warning messages. {color:red}-1 eclipse:eclipse{color}. The patch failed to build with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:red}-1 release audit{color}. The applied patch generated 1 release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestSafeMode {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5501//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/5501//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5501//console This message is automatically generated. Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report Key: HDFS-5533 URL: https://issues.apache.org/jira/browse/HDFS-5533 Project: Hadoop HDFS Issue Type: Bug Reporter: Binglin Chang Assignee: Binglin Chang Priority: Minor Attachments: HDFS-5533.patch, HDFS-5533.v2.patch Currently the original code treat symlink delete/create as modify, but symlink is immutable, should be CREATE and DELETE -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-5533) Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report
[ https://issues.apache.org/jira/browse/HDFS-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827904#comment-13827904 ] Hadoop QA commented on HDFS-5533: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614907/HDFS-5533.v2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5504//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5504//console This message is automatically generated. Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report Key: HDFS-5533 URL: https://issues.apache.org/jira/browse/HDFS-5533 Project: Hadoop HDFS Issue Type: Bug Reporter: Binglin Chang Assignee: Binglin Chang Priority: Minor Attachments: HDFS-5533.patch, HDFS-5533.v2.patch, HDFS-5533.v2.patch Currently the original code treat symlink delete/create as modify, but symlink is immutable, should be CREATE and DELETE -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-5533) Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report
[ https://issues.apache.org/jira/browse/HDFS-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13828386#comment-13828386 ] Binglin Chang commented on HDFS-5533: - The failed test is not relevent, create HDFS-5540 for it Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report Key: HDFS-5533 URL: https://issues.apache.org/jira/browse/HDFS-5533 Project: Hadoop HDFS Issue Type: Bug Reporter: Binglin Chang Assignee: Binglin Chang Priority: Minor Attachments: HDFS-5533.patch, HDFS-5533.v2.patch, HDFS-5533.v2.patch Currently the original code treat symlink delete/create as modify, but symlink is immutable, should be CREATE and DELETE -- This message was sent by Atlassian JIRA (v6.1#6144)