[jira] [Updated] (HDFS-3888) BlockPlacementPolicyDefault code cleanup

2012-09-04 Thread Tsz Wo (Nicholas), SZE (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated HDFS-3888:
-

   Resolution: Fixed
Fix Version/s: 2.2.0-alpha
   Status: Resolved  (was: Patch Available)

I have committed this.  Thanks, Jing!

> BlockPlacementPolicyDefault code cleanup
> 
>
> Key: HDFS-3888
> URL: https://issues.apache.org/jira/browse/HDFS-3888
> Project: Hadoop HDFS
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Fix For: 2.2.0-alpha
>
> Attachments: HDFS-3888.patch, HDFS-3888.patch
>
>
> BlockPlacementPolicyDefault#LOG should be removed as it hides LOG from the 
> base class BlockPlacementPolicy. Also, in 
> BlockPlacementPolicyDefault#chooseTarget method, the logic computing the 
> maxTargetPerLoc can be made a separate method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HDFS-3888) BlockPlacementPolicyDefault code cleanup

2012-09-04 Thread Tsz Wo (Nicholas), SZE (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated HDFS-3888:
-

Status: Patch Available  (was: Open)

> BlockPlacementPolicyDefault code cleanup
> 
>
> Key: HDFS-3888
> URL: https://issues.apache.org/jira/browse/HDFS-3888
> Project: Hadoop HDFS
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-3888.patch, HDFS-3888.patch
>
>
> BlockPlacementPolicyDefault#LOG should be removed as it hides LOG from the 
> base class BlockPlacementPolicy. Also, in 
> BlockPlacementPolicyDefault#chooseTarget method, the logic computing the 
> maxTargetPerLoc can be made a separate method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HDFS-3888) BlockPlacementPolicyDefault code cleanup

2012-09-04 Thread Tsz Wo (Nicholas), SZE (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated HDFS-3888:
-

Hadoop Flags: Reviewed

+1 patch looks good.

> BlockPlacementPolicyDefault code cleanup
> 
>
> Key: HDFS-3888
> URL: https://issues.apache.org/jira/browse/HDFS-3888
> Project: Hadoop HDFS
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-3888.patch, HDFS-3888.patch
>
>
> BlockPlacementPolicyDefault#LOG should be removed as it hides LOG from the 
> base class BlockPlacementPolicy. Also, in 
> BlockPlacementPolicyDefault#chooseTarget method, the logic computing the 
> maxTargetPerLoc can be made a separate method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HDFS-3888) BlockPlacementPolicyDefault code cleanup

2012-09-04 Thread Jing Zhao (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jing Zhao updated HDFS-3888:


Attachment: HDFS-3888.patch

The code for computing the maxNodePerRack in chooseTarget() method is putting 
back because it may also change the value of numOfReplicas.

> BlockPlacementPolicyDefault code cleanup
> 
>
> Key: HDFS-3888
> URL: https://issues.apache.org/jira/browse/HDFS-3888
> Project: Hadoop HDFS
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-3888.patch, HDFS-3888.patch
>
>
> BlockPlacementPolicyDefault#LOG should be removed as it hides LOG from the 
> base class BlockPlacementPolicy. Also, in 
> BlockPlacementPolicyDefault#chooseTarget method, the logic computing the 
> maxTargetPerLoc can be made a separate method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HDFS-3888) BlockPlacementPolicyDefault code cleanup

2012-09-04 Thread Jing Zhao (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jing Zhao updated HDFS-3888:


Status: Open  (was: Patch Available)

> BlockPlacementPolicyDefault code cleanup
> 
>
> Key: HDFS-3888
> URL: https://issues.apache.org/jira/browse/HDFS-3888
> Project: Hadoop HDFS
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-3888.patch
>
>
> BlockPlacementPolicyDefault#LOG should be removed as it hides LOG from the 
> base class BlockPlacementPolicy. Also, in 
> BlockPlacementPolicyDefault#chooseTarget method, the logic computing the 
> maxTargetPerLoc can be made a separate method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HDFS-3888) BlockPlacementPolicyDefault code cleanup

2012-09-04 Thread Suresh Srinivas (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas updated HDFS-3888:
--

Summary: BlockPlacementPolicyDefault code cleanup  (was: 
BlockPlacementPolicyDefault#LOG should be removed)

> BlockPlacementPolicyDefault code cleanup
> 
>
> Key: HDFS-3888
> URL: https://issues.apache.org/jira/browse/HDFS-3888
> Project: Hadoop HDFS
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-3888.patch
>
>
> BlockPlacementPolicyDefault#LOG should be removed as it hides LOG from the 
> base class BlockPlacementPolicy. Also, in 
> BlockPlacementPolicyDefault#chooseTarget method, the logic computing the 
> maxTargetPerLoc can be made a separate method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira