[jira] [Commented] (HDFS-827) Additional unit tests for FSDataset
[ https://issues.apache.org/jira/browse/HDFS-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258785#comment-13258785 ] Uma Maheswara Rao G commented on HDFS-827: -- I think, we need to re-base this patch against to latest trunk! As we have re-factored the FsDataSet impls to separate package. Additional unit tests for FSDataset --- Key: HDFS-827 URL: https://issues.apache.org/jira/browse/HDFS-827 Project: Hadoop HDFS Issue Type: Test Components: data-node, test Affects Versions: 0.22.0 Reporter: Todd Lipcon Assignee: Todd Lipcon Attachments: hdfs-827.patch, hdfs-827.txt FSDataset doesn't currently have a unit-test that tests it in isolation of the DN or a cluster. A test specifically for this class will be helpful for developing HDFS-788 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-827) Additional unit tests for FSDataset
[ https://issues.apache.org/jira/browse/HDFS-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13021445#comment-13021445 ] Hadoop QA commented on HDFS-827: -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12475262/hdfs-827.patch against trunk revision 1094748. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/388//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/388//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/388//console This message is automatically generated. Additional unit tests for FSDataset --- Key: HDFS-827 URL: https://issues.apache.org/jira/browse/HDFS-827 Project: Hadoop HDFS Issue Type: Test Components: data-node, test Affects Versions: 0.22.0 Reporter: Todd Lipcon Assignee: Todd Lipcon Attachments: hdfs-827.patch, hdfs-827.txt FSDataset doesn't currently have a unit-test that tests it in isolation of the DN or a cluster. A test specifically for this class will be helpful for developing HDFS-788 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-827) Additional unit tests for FSDataset
[
https://issues.apache.org/jira/browse/HDFS-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13014861#comment-13014861
]
Konstantin Boudnik commented on HDFS-827:
-
Todd, the change in
{{src/java/org/apache/hadoop/hdfs/server/datanode/ReplicaInPipeline.java}}
{noformat}
+int bytesPerChunk = checksum.getBytesPerChecksum();
+int checksumSize = checksum.getChecksumSize();
{noformat}
causes NPE if DataChecksum.newDataChecksum
Additional unit tests for FSDataset
---
Key: HDFS-827
URL: https://issues.apache.org/jira/browse/HDFS-827
Project: Hadoop HDFS
Issue Type: Test
Components: data-node, test
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Attachments: hdfs-827.txt
FSDataset doesn't currently have a unit-test that tests it in isolation of
the DN or a cluster. A test specifically for this class will be helpful for
developing HDFS-788
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-827) Additional unit tests for FSDataset
[ https://issues.apache.org/jira/browse/HDFS-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12996846#comment-12996846 ] Hadoop QA commented on HDFS-827: -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12467234/hdfs-827.txt against trunk revision 1072023. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/202//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/202//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/202//console This message is automatically generated. Additional unit tests for FSDataset --- Key: HDFS-827 URL: https://issues.apache.org/jira/browse/HDFS-827 Project: Hadoop HDFS Issue Type: Test Components: data-node, test Affects Versions: 0.22.0 Reporter: Todd Lipcon Assignee: Todd Lipcon Attachments: hdfs-827.txt FSDataset doesn't currently have a unit-test that tests it in isolation of the DN or a cluster. A test specifically for this class will be helpful for developing HDFS-788 -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-827) Additional unit tests for FSDataset
[ https://issues.apache.org/jira/browse/HDFS-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982238#action_12982238 ] Konstantin Boudnik commented on HDFS-827: - The difference is timing mostly and a chance to finally organize test structure to be correct ;) Additional unit tests for FSDataset --- Key: HDFS-827 URL: https://issues.apache.org/jira/browse/HDFS-827 Project: Hadoop HDFS Issue Type: Test Components: data-node, test Affects Versions: 0.22.0 Reporter: Todd Lipcon Assignee: Todd Lipcon Attachments: hdfs-827.txt FSDataset doesn't currently have a unit-test that tests it in isolation of the DN or a cluster. A test specifically for this class will be helpful for developing HDFS-788 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-827) Additional unit tests for FSDataset
[ https://issues.apache.org/jira/browse/HDFS-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12977517#action_12977517 ] Todd Lipcon commented on HDFS-827: -- I suppose so - I never remember to look in src/test/unit, though. What's the purpose of the distinction there? We have some tests there that take much longer than a second (eg TestBlockRecovery), and many tests in src/test/hdfs that are near instant. To be clear, I understand the distinction between unit and functional test, but not how it actually makes a difference in our build :) Additional unit tests for FSDataset --- Key: HDFS-827 URL: https://issues.apache.org/jira/browse/HDFS-827 Project: Hadoop HDFS Issue Type: Test Components: data-node, test Affects Versions: 0.22.0 Reporter: Todd Lipcon Assignee: Todd Lipcon Attachments: hdfs-827.txt FSDataset doesn't currently have a unit-test that tests it in isolation of the DN or a cluster. A test specifically for this class will be helpful for developing HDFS-788 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-827) Additional unit tests for FSDataset
[ https://issues.apache.org/jira/browse/HDFS-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12976486#action_12976486 ] Konstantin Boudnik commented on HDFS-827: - If they so fast shall they be moved to src/test/unit instead? Additional unit tests for FSDataset --- Key: HDFS-827 URL: https://issues.apache.org/jira/browse/HDFS-827 Project: Hadoop HDFS Issue Type: Test Components: data-node, test Affects Versions: 0.22.0 Reporter: Todd Lipcon Assignee: Todd Lipcon Attachments: hdfs-827.txt FSDataset doesn't currently have a unit-test that tests it in isolation of the DN or a cluster. A test specifically for this class will be helpful for developing HDFS-788 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
