[jira] [Updated] (HDFS-1611) Some logical issues need to address.

2011-03-30 Thread Todd Lipcon (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Todd Lipcon updated HDFS-1611:
--

   Resolution: Fixed
Fix Version/s: 0.23.0
 Hadoop Flags: [Reviewed]
   Status: Resolved  (was: Patch Available)

Committed to trunk. Thanks Uma.

> Some logical issues need to address.
> 
>
> Key: HDFS-1611
> URL: https://issues.apache.org/jira/browse/HDFS-1611
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: hdfs client, name-node
>Affects Versions: 0.20.1, 0.20.2
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
>Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1611.1.patch, HDFS-1611.patch
>
>
> Title: Some code level logical issues.
> Description:
> 1. DFSClient:  
>   Consider the below case, if we enable only info, then below log will never 
> be logged.
>  if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
>   ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
> }
> 2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
>   
>   catch (NotCompliantMBeanException e) {
>   e.printStackTrace();
> }
>   We can avoid using stackTace(). Better to add log message.  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HDFS-1611) Some logical issues need to address.

2011-03-08 Thread Uma Maheswara Rao G (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uma Maheswara Rao G updated HDFS-1611:
--

Status: Patch Available  (was: Open)

Provide the patch.
Changed the log level to debug.
Thank you Todd Lipcon for your comments.

> Some logical issues need to address.
> 
>
> Key: HDFS-1611
> URL: https://issues.apache.org/jira/browse/HDFS-1611
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: hdfs client, name-node
>Affects Versions: 0.20.2, 0.20.1
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
>Priority: Minor
> Attachments: HDFS-1611.1.patch, HDFS-1611.patch
>
>
> Title: Some code level logical issues.
> Description:
> 1. DFSClient:  
>   Consider the below case, if we enable only info, then below log will never 
> be logged.
>  if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
>   ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
> }
> 2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
>   
>   catch (NotCompliantMBeanException e) {
>   e.printStackTrace();
> }
>   We can avoid using stackTace(). Better to add log message.  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HDFS-1611) Some logical issues need to address.

2011-03-08 Thread Uma Maheswara Rao G (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uma Maheswara Rao G updated HDFS-1611:
--

Attachment: HDFS-1611.1.patch

> Some logical issues need to address.
> 
>
> Key: HDFS-1611
> URL: https://issues.apache.org/jira/browse/HDFS-1611
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: hdfs client, name-node
>Affects Versions: 0.20.1, 0.20.2
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
>Priority: Minor
> Attachments: HDFS-1611.1.patch, HDFS-1611.patch
>
>
> Title: Some code level logical issues.
> Description:
> 1. DFSClient:  
>   Consider the below case, if we enable only info, then below log will never 
> be logged.
>  if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
>   ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
> }
> 2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
>   
>   catch (NotCompliantMBeanException e) {
>   e.printStackTrace();
> }
>   We can avoid using stackTace(). Better to add log message.  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HDFS-1611) Some logical issues need to address.

2011-03-06 Thread Todd Lipcon (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Todd Lipcon updated HDFS-1611:
--

Status: Open  (was: Patch Available)

> Some logical issues need to address.
> 
>
> Key: HDFS-1611
> URL: https://issues.apache.org/jira/browse/HDFS-1611
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: hdfs client, name-node
>Affects Versions: 0.20.2, 0.20.1
>Reporter: Uma Maheswara Rao G
>Priority: Minor
> Attachments: HDFS-1611.patch
>
>
> Title: Some code level logical issues.
> Description:
> 1. DFSClient:  
>   Consider the below case, if we enable only info, then below log will never 
> be logged.
>  if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
>   ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
> }
> 2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
>   
>   catch (NotCompliantMBeanException e) {
>   e.printStackTrace();
> }
>   We can avoid using stackTace(). Better to add log message.  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HDFS-1611) Some logical issues need to address.

2011-03-04 Thread Uma Maheswara Rao G (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uma Maheswara Rao G updated HDFS-1611:
--

Status: Patch Available  (was: Open)

> Some logical issues need to address.
> 
>
> Key: HDFS-1611
> URL: https://issues.apache.org/jira/browse/HDFS-1611
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: hdfs client, name-node
>Affects Versions: 0.20.2, 0.20.1
>Reporter: Uma Maheswara Rao G
>Priority: Minor
> Attachments: HDFS-1611.patch
>
>
> Title: Some code level logical issues.
> Description:
> 1. DFSClient:  
>   Consider the below case, if we enable only info, then below log will never 
> be logged.
>  if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
>   ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
> }
> 2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
>   
>   catch (NotCompliantMBeanException e) {
>   e.printStackTrace();
> }
>   We can avoid using stackTace(). Better to add log message.  

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HDFS-1611) Some logical issues need to address.

2011-03-04 Thread Uma Maheswara Rao G (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uma Maheswara Rao G updated HDFS-1611:
--

Attachment: HDFS-1611.patch

> Some logical issues need to address.
> 
>
> Key: HDFS-1611
> URL: https://issues.apache.org/jira/browse/HDFS-1611
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: hdfs client, name-node
>Affects Versions: 0.20.1, 0.20.2
>Reporter: Uma Maheswara Rao G
>Priority: Minor
> Attachments: HDFS-1611.patch
>
>
> Title: Some code level logical issues.
> Description:
> 1. DFSClient:  
>   Consider the below case, if we enable only info, then below log will never 
> be logged.
>  if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
>   ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
> }
> 2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
>   
>   catch (NotCompliantMBeanException e) {
>   e.printStackTrace();
> }
>   We can avoid using stackTace(). Better to add log message.  

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HDFS-1611) Some logical issues need to address.

2011-02-24 Thread Uma Maheswara Rao G (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uma Maheswara Rao G updated HDFS-1611:
--

Description: 
Title: Some code level logical issues.

Description:

1. DFSClient:  
  Consider the below case, if we enable only info, then below log will never be 
logged.
 if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
  ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
}

2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
  
  catch (NotCompliantMBeanException e) {
  e.printStackTrace();
}

  We can avoid using stackTace(). Better to add log message.  



  was:
Title: Some code level logical issues.

Description:

1. DFSClient:  
  Consider the below case, if we enable only info, then below log will never be 
logged.
 if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
  ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
}

2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
  
  catch (NotCompliantMBeanException e) {
  e.printStackTrace();
}

  We can avoid using stackTace(). Better to add log message.  

3. In  org.apache.hadoop.hdfs.server.namenode.FSImage
since SimpleDateFormat is not a thread safe, we can move that to local to 
the method.
private static final SimpleDateFormat DATE_FORM =
new SimpleDateFormat("-MM-dd HH:mm:ss");


> Some logical issues need to address.
> 
>
> Key: HDFS-1611
> URL: https://issues.apache.org/jira/browse/HDFS-1611
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: hdfs client, name-node
>Affects Versions: 0.20.1, 0.20.2
>Reporter: Uma Maheswara Rao G
>Priority: Minor
>
> Title: Some code level logical issues.
> Description:
> 1. DFSClient:  
>   Consider the below case, if we enable only info, then below log will never 
> be logged.
>  if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
>   ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
> }
> 2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
>   
>   catch (NotCompliantMBeanException e) {
>   e.printStackTrace();
> }
>   We can avoid using stackTace(). Better to add log message.  

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira