[jira] [Updated] (HDFS-11805) Ensure LevelDB DBIterator is closed

2017-05-14 Thread Xiaoyu Yao (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaoyu Yao updated HDFS-11805:
--
   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: HDFS-7240
   Status: Resolved  (was: Patch Available)

Thanks [~vagarychen] for the contribution. I've commit the patch to the feature 
branch.

> Ensure LevelDB DBIterator is closed
> ---
>
> Key: HDFS-11805
> URL: https://issues.apache.org/jira/browse/HDFS-11805
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Chen Liang
>Priority: Minor
> Fix For: HDFS-7240
>
> Attachments: HDFS-11805-HDFS-7240.001.patch, 
> HDFS-11805-HDFS-7240.002.patch
>
>
> DBIterator used in CblockManager/FilteredKeys/SQLCLI/OzoneMetadataManager 
> should be closed after done with the iteration to avoid resource leaking. 
> try-with-resource should fix that easily for most of the cases. FIlteredKeys 
> may be a special case that I have not fully checked yet. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDFS-11805) Ensure LevelDB DBIterator is closed

2017-05-12 Thread Chen Liang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen Liang updated HDFS-11805:
--
Attachment: HDFS-11805-HDFS-7240.002.patch

Thanks [~xyao] for the review! Post v002 patch to fix the checkstyle warning.

> Ensure LevelDB DBIterator is closed
> ---
>
> Key: HDFS-11805
> URL: https://issues.apache.org/jira/browse/HDFS-11805
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Chen Liang
>Priority: Minor
> Attachments: HDFS-11805-HDFS-7240.001.patch, 
> HDFS-11805-HDFS-7240.002.patch
>
>
> DBIterator used in CblockManager/FilteredKeys/SQLCLI/OzoneMetadataManager 
> should be closed after done with the iteration to avoid resource leaking. 
> try-with-resource should fix that easily for most of the cases. FIlteredKeys 
> may be a special case that I have not fully checked yet. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDFS-11805) Ensure LevelDB DBIterator is closed

2017-05-11 Thread Chen Liang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen Liang updated HDFS-11805:
--
Attachment: HDFS-11805-HDFS-7240.001.patch

Post v005 patch. {{SQLCLI}} is fixed in HDFS-11802. {{FilteredKeys}} has its 
close method where the DBIterator gets closed, so does not seem to require a 
fix.

> Ensure LevelDB DBIterator is closed
> ---
>
> Key: HDFS-11805
> URL: https://issues.apache.org/jira/browse/HDFS-11805
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Chen Liang
>Priority: Minor
> Attachments: HDFS-11805-HDFS-7240.001.patch
>
>
> DBIterator used in CblockManager/FilteredKeys/SQLCLI/OzoneMetadataManager 
> should be closed after done with the iteration to avoid resource leaking. 
> try-with-resource should fix that easily for most of the cases. FIlteredKeys 
> may be a special case that I have not fully checked yet. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDFS-11805) Ensure LevelDB DBIterator is closed

2017-05-11 Thread Chen Liang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen Liang updated HDFS-11805:
--
Status: Patch Available  (was: Open)

> Ensure LevelDB DBIterator is closed
> ---
>
> Key: HDFS-11805
> URL: https://issues.apache.org/jira/browse/HDFS-11805
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Chen Liang
>Priority: Minor
> Attachments: HDFS-11805-HDFS-7240.001.patch
>
>
> DBIterator used in CblockManager/FilteredKeys/SQLCLI/OzoneMetadataManager 
> should be closed after done with the iteration to avoid resource leaking. 
> try-with-resource should fix that easily for most of the cases. FIlteredKeys 
> may be a special case that I have not fully checked yet. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org