[jira] [Commented] (HDFS-2772) HA: On transition to active, standby should not swallow ELIE
[ https://issues.apache.org/jira/browse/HDFS-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187631#comment-13187631 ] Hudson commented on HDFS-2772: -- Integrated in Hadoop-Hdfs-HAbranch-build #50 (See [https://builds.apache.org/job/Hadoop-Hdfs-HAbranch-build/50/]) HDFS-2772. On transition to active, standby should not swallow ELIE. Contributed by Aaron T. Myers atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232197 Files : * /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt * /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java * /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java > HA: On transition to active, standby should not swallow ELIE > > > Key: HDFS-2772 > URL: https://issues.apache.org/jira/browse/HDFS-2772 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ha, name-node >Affects Versions: HA branch (HDFS-1623) >Reporter: Aaron T. Myers >Assignee: Aaron T. Myers > Fix For: HA branch (HDFS-1623) > > Attachments: HDFS-2772-HDFS-1623.patch > > > EditLogTailer#doTailEdits currently catches, logs, and swallows > EditLogInputException. This is fine in the case when the standby is sitting > idly behind tailing logs. However, when the standby is transitioning to > active, swallowing this exception is incorrect, since it could cause the > standby to silently fail to load all the edits before becoming active. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2772) HA: On transition to active, standby should not swallow ELIE
[ https://issues.apache.org/jira/browse/HDFS-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187246#comment-13187246 ] Todd Lipcon commented on HDFS-2772: --- +1, lgtm. > HA: On transition to active, standby should not swallow ELIE > > > Key: HDFS-2772 > URL: https://issues.apache.org/jira/browse/HDFS-2772 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ha, name-node >Affects Versions: HA branch (HDFS-1623) >Reporter: Aaron T. Myers >Assignee: Aaron T. Myers > Attachments: HDFS-2772-HDFS-1623.patch > > > EditLogTailer#doTailEdits currently catches, logs, and swallows > EditLogInputException. This is fine in the case when the standby is sitting > idly behind tailing logs. However, when the standby is transitioning to > active, swallowing this exception is incorrect, since it could cause the > standby to silently fail to load all the edits before becoming active. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2772) HA: On transition to active, standby should not swallow ELIE
[ https://issues.apache.org/jira/browse/HDFS-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183799#comment-13183799 ] Aaron T. Myers commented on HDFS-2772: -- I'm still working on writing a test case for it, but I can confirm that the present code will not in fact allow the standby to "silently fail to load all the edits before becoming active." That is, the current code does not presently have any correctness issue. Writing a test for this is a little annoying because of the way exceptions are propagated, but I'll post a patch for it shortly. > HA: On transition to active, standby should not swallow ELIE > > > Key: HDFS-2772 > URL: https://issues.apache.org/jira/browse/HDFS-2772 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ha, name-node >Affects Versions: HA branch (HDFS-1623) >Reporter: Aaron T. Myers >Assignee: Aaron T. Myers > > EditLogTailer#doTailEdits currently catches, logs, and swallows > EditLogInputException. This is fine in the case when the standby is sitting > idly behind tailing logs. However, when the standby is transitioning to > active, swallowing this exception is incorrect, since it could cause the > standby to silently fail to load all the edits before becoming active. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
