[HippoCMS-scm] [Git][cms-community/hippo-addon-channel-manager] Pushed new branch feature/visual-editing-psp1-CHANNELMGR-970
Tobias Jeger pushed new branch feature/visual-editing-psp1-CHANNELMGR-970 at cms-community / hippo-addon-channel-manager ___ Hippocms-svn mailing list Hippocms-svn@lists.onehippo.org https://lists.onehippo.org/mailman/listinfo/hippocms-svn
[HippoCMS-scm] [Git][cms-community/hippo-addon-channel-manager][feature/visual-editing-psp1-CHANNELMGR-970] CHANNELMGR-970 fix css based on DOM changes
Mark Lenser pushed to branch feature/visual-editing-psp1-CHANNELMGR-970 at cms-community / hippo-addon-channel-manager Commits: ede8910a by Mark at 2016-11-07T14:23:57+01:00 CHANNELMGR-970 fix css based on DOM changes - - - - - 1 changed file: - frontend-ng/src/styles/_forms.scss Changes: = frontend-ng/src/styles/_forms.scss = --- a/frontend-ng/src/styles/_forms.scss +++ b/frontend-ng/src/styles/_forms.scss @@ -40,7 +40,7 @@ form { &.form-field-compound { border-color: $blue-500; } - &> md-input-container { + &> div { &> h5 { color: $blue-500 !important; md-icon { View it on GitLab: https://code.onehippo.org/cms-community/hippo-addon-channel-manager/commit/ede8910a68fc0c90e44897b39a451a30cb95a58b ___ Hippocms-svn mailing list Hippocms-svn@lists.onehippo.org https://lists.onehippo.org/mailman/listinfo/hippocms-svn
[HippoCMS-scm] [Git][cms-community/hippo-repository][release/4.1] REPO-1496 add missing Node and Property decorations
Ate Douma pushed to branch release/4.1 at cms-community / hippo-repository Commits: 8f303531 by Ate Douma at 2016-11-07T14:38:01+01:00 REPO-1496 add missing Node and Property decorations Patch provided by Wolfgang Illmeyer. - - - - - 2 changed files: - connector/src/main/java/org/hippoecm/repository/decorating/NodeDecorator.java - connector/src/main/java/org/hippoecm/repository/decorating/PropertyDecorator.java Changes: = connector/src/main/java/org/hippoecm/repository/decorating/NodeDecorator.java = --- a/connector/src/main/java/org/hippoecm/repository/decorating/NodeDecorator.java +++ b/connector/src/main/java/org/hippoecm/repository/decorating/NodeDecorator.java @@ -1,5 +1,5 @@ /* - * Copyright 2008-2013 Hippo B.V. (http://www.onehippo.com) + * Copyright 2008-2016 Hippo B.V. (http://www.onehippo.com) * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -562,19 +562,19 @@ public abstract class NodeDecorator extends ItemDecorator implements HippoNode { public Property setProperty(String name, Binary value) throws ValueFormatException, VersionException, LockException, ConstraintViolationException, RepositoryException { -return node.setProperty(name, value); +return factory.getPropertyDecorator(session, node.setProperty(name, value)); } public Property setProperty(String name, BigDecimal value) throws ValueFormatException, VersionException, LockException, ConstraintViolationException, RepositoryException { -return node.setProperty(name, value); +return factory.getPropertyDecorator(session, node.setProperty(name, value)); } public NodeIterator getNodes(String[] nameGlobs) throws RepositoryException { -return node.getNodes(nameGlobs); +return new NodeIteratorDecorator(factory, session, node.getNodes(nameGlobs), this); } public PropertyIterator getProperties(String[] nameGlobs) throws RepositoryException { -return node.getProperties(nameGlobs); +return new PropertyIteratorDecorator(factory, session, node.getProperties(nameGlobs)); } public String getIdentifier() throws RepositoryException { @@ -582,15 +582,15 @@ public abstract class NodeDecorator extends ItemDecorator implements HippoNode { } public PropertyIterator getReferences(String name) throws RepositoryException { -return node.getReferences(name); +return new PropertyIteratorDecorator(factory, session, node.getReferences(name)); } public PropertyIterator getWeakReferences() throws RepositoryException { -return node.getWeakReferences(); +return new PropertyIteratorDecorator(factory, session, node.getWeakReferences()); } public PropertyIterator getWeakReferences(String name) throws RepositoryException { -return node.getWeakReferences(name); +return new PropertyIteratorDecorator(factory, session, node.getWeakReferences(name)); } public void setPrimaryType(String nodeTypeName) throws NoSuchNodeTypeException, VersionException, ConstraintViolationException, LockException, RepositoryException { @@ -598,7 +598,7 @@ public abstract class NodeDecorator extends ItemDecorator implements HippoNode { } public NodeIterator getSharedSet() throws RepositoryException { -return node.getSharedSet(); +return new NodeIteratorDecorator(factory, session, node.getSharedSet(), this); } public void removeSharedSet() throws VersionException, LockException, ConstraintViolationException, RepositoryException { = connector/src/main/java/org/hippoecm/repository/decorating/PropertyDecorator.java = --- a/connector/src/main/java/org/hippoecm/repository/decorating/PropertyDecorator.java +++ b/connector/src/main/java/org/hippoecm/repository/decorating/PropertyDecorator.java @@ -1,5 +1,5 @@ /* - * Copyright 2008-2013 Hippo B.V. (http://www.onehippo.com) + * Copyright 2008-2016 Hippo B.V. (http://www.onehippo.com) * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -231,7 +231,7 @@ public class PropertyDecorator extends ItemDecorator implements Property { } public Property getProperty() throws ItemNotFoundException, ValueFormatException, RepositoryException { -return property.getProperty(); +return factory.getPropertyDecorator(session, property.getProperty()); } public boolean isMultiple() throws RepositoryException { View it on GitLab: https://code.onehippo.org/cms-community/hippo-repository/commit/8f303531ea17c338c043ef8c6ceeb2dbd00a6146 ___ Hippocms-svn mailing list Hippocms-sv
[HippoCMS-scm] [Git][cms-community/hippo-repository][release/4.0] REPO-1598 [backport 11.0] add missing Node and Property decorations
Ate Douma pushed to branch release/4.0 at cms-community / hippo-repository Commits: 79ea171d by Ate Douma at 2016-11-07T14:42:06+01:00 REPO-1598 [backport 11.0] add missing Node and Property decorations Patch provided by Wolfgang Illmeyer. (cherry picked from commit 115b20920ee3ce3b896cabe78c8d461b2272b1ca) - - - - - 2 changed files: - connector/src/main/java/org/hippoecm/repository/decorating/NodeDecorator.java - connector/src/main/java/org/hippoecm/repository/decorating/PropertyDecorator.java Changes: = connector/src/main/java/org/hippoecm/repository/decorating/NodeDecorator.java = --- a/connector/src/main/java/org/hippoecm/repository/decorating/NodeDecorator.java +++ b/connector/src/main/java/org/hippoecm/repository/decorating/NodeDecorator.java @@ -1,5 +1,5 @@ /* - * Copyright 2008-2013 Hippo B.V. (http://www.onehippo.com) + * Copyright 2008-2016 Hippo B.V. (http://www.onehippo.com) * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -562,19 +562,19 @@ public abstract class NodeDecorator extends ItemDecorator implements HippoNode { public Property setProperty(String name, Binary value) throws ValueFormatException, VersionException, LockException, ConstraintViolationException, RepositoryException { -return node.setProperty(name, value); +return factory.getPropertyDecorator(session, node.setProperty(name, value)); } public Property setProperty(String name, BigDecimal value) throws ValueFormatException, VersionException, LockException, ConstraintViolationException, RepositoryException { -return node.setProperty(name, value); +return factory.getPropertyDecorator(session, node.setProperty(name, value)); } public NodeIterator getNodes(String[] nameGlobs) throws RepositoryException { -return node.getNodes(nameGlobs); +return new NodeIteratorDecorator(factory, session, node.getNodes(nameGlobs), this); } public PropertyIterator getProperties(String[] nameGlobs) throws RepositoryException { -return node.getProperties(nameGlobs); +return new PropertyIteratorDecorator(factory, session, node.getProperties(nameGlobs)); } public String getIdentifier() throws RepositoryException { @@ -582,15 +582,15 @@ public abstract class NodeDecorator extends ItemDecorator implements HippoNode { } public PropertyIterator getReferences(String name) throws RepositoryException { -return node.getReferences(name); +return new PropertyIteratorDecorator(factory, session, node.getReferences(name)); } public PropertyIterator getWeakReferences() throws RepositoryException { -return node.getWeakReferences(); +return new PropertyIteratorDecorator(factory, session, node.getWeakReferences()); } public PropertyIterator getWeakReferences(String name) throws RepositoryException { -return node.getWeakReferences(name); +return new PropertyIteratorDecorator(factory, session, node.getWeakReferences(name)); } public void setPrimaryType(String nodeTypeName) throws NoSuchNodeTypeException, VersionException, ConstraintViolationException, LockException, RepositoryException { @@ -598,7 +598,7 @@ public abstract class NodeDecorator extends ItemDecorator implements HippoNode { } public NodeIterator getSharedSet() throws RepositoryException { -return node.getSharedSet(); +return new NodeIteratorDecorator(factory, session, node.getSharedSet(), this); } public void removeSharedSet() throws VersionException, LockException, ConstraintViolationException, RepositoryException { = connector/src/main/java/org/hippoecm/repository/decorating/PropertyDecorator.java = --- a/connector/src/main/java/org/hippoecm/repository/decorating/PropertyDecorator.java +++ b/connector/src/main/java/org/hippoecm/repository/decorating/PropertyDecorator.java @@ -1,5 +1,5 @@ /* - * Copyright 2008-2013 Hippo B.V. (http://www.onehippo.com) + * Copyright 2008-2016 Hippo B.V. (http://www.onehippo.com) * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -231,7 +231,7 @@ public class PropertyDecorator extends ItemDecorator implements Property { } public Property getProperty() throws ItemNotFoundException, ValueFormatException, RepositoryException { -return property.getProperty(); +return factory.getPropertyDecorator(session, property.getProperty()); } public boolean isMultiple() throws RepositoryException { View it on GitLab: https://code.onehippo.org/cms-community/hippo-repository/commit/79ea171dcb577c860dc0de4bbbcc5a56dde31a3d
[HippoCMS-scm] [Git][cms-community/hippo-repository][release/3.2] REPO-1599 [backport 10.2] add missing Node and Property decorations
Ate Douma pushed to branch release/3.2 at cms-community / hippo-repository Commits: a5efd088 by Ate Douma at 2016-11-07T14:44:17+01:00 REPO-1599 [backport 10.2] add missing Node and Property decorations Patch provided by Wolfgang Illmeyer. (cherry picked from commit 115b20920ee3ce3b896cabe78c8d461b2272b1ca) - - - - - 2 changed files: - connector/src/main/java/org/hippoecm/repository/decorating/NodeDecorator.java - connector/src/main/java/org/hippoecm/repository/decorating/PropertyDecorator.java Changes: = connector/src/main/java/org/hippoecm/repository/decorating/NodeDecorator.java = --- a/connector/src/main/java/org/hippoecm/repository/decorating/NodeDecorator.java +++ b/connector/src/main/java/org/hippoecm/repository/decorating/NodeDecorator.java @@ -1,5 +1,5 @@ /* - * Copyright 2008-2013 Hippo B.V. (http://www.onehippo.com) + * Copyright 2008-2016 Hippo B.V. (http://www.onehippo.com) * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -562,19 +562,19 @@ public abstract class NodeDecorator extends ItemDecorator implements HippoNode { public Property setProperty(String name, Binary value) throws ValueFormatException, VersionException, LockException, ConstraintViolationException, RepositoryException { -return node.setProperty(name, value); +return factory.getPropertyDecorator(session, node.setProperty(name, value)); } public Property setProperty(String name, BigDecimal value) throws ValueFormatException, VersionException, LockException, ConstraintViolationException, RepositoryException { -return node.setProperty(name, value); +return factory.getPropertyDecorator(session, node.setProperty(name, value)); } public NodeIterator getNodes(String[] nameGlobs) throws RepositoryException { -return node.getNodes(nameGlobs); +return new NodeIteratorDecorator(factory, session, node.getNodes(nameGlobs), this); } public PropertyIterator getProperties(String[] nameGlobs) throws RepositoryException { -return node.getProperties(nameGlobs); +return new PropertyIteratorDecorator(factory, session, node.getProperties(nameGlobs)); } public String getIdentifier() throws RepositoryException { @@ -582,15 +582,15 @@ public abstract class NodeDecorator extends ItemDecorator implements HippoNode { } public PropertyIterator getReferences(String name) throws RepositoryException { -return node.getReferences(name); +return new PropertyIteratorDecorator(factory, session, node.getReferences(name)); } public PropertyIterator getWeakReferences() throws RepositoryException { -return node.getWeakReferences(); +return new PropertyIteratorDecorator(factory, session, node.getWeakReferences()); } public PropertyIterator getWeakReferences(String name) throws RepositoryException { -return node.getWeakReferences(name); +return new PropertyIteratorDecorator(factory, session, node.getWeakReferences(name)); } public void setPrimaryType(String nodeTypeName) throws NoSuchNodeTypeException, VersionException, ConstraintViolationException, LockException, RepositoryException { @@ -598,7 +598,7 @@ public abstract class NodeDecorator extends ItemDecorator implements HippoNode { } public NodeIterator getSharedSet() throws RepositoryException { -return node.getSharedSet(); +return new NodeIteratorDecorator(factory, session, node.getSharedSet(), this); } public void removeSharedSet() throws VersionException, LockException, ConstraintViolationException, RepositoryException { = connector/src/main/java/org/hippoecm/repository/decorating/PropertyDecorator.java = --- a/connector/src/main/java/org/hippoecm/repository/decorating/PropertyDecorator.java +++ b/connector/src/main/java/org/hippoecm/repository/decorating/PropertyDecorator.java @@ -1,5 +1,5 @@ /* - * Copyright 2008-2013 Hippo B.V. (http://www.onehippo.com) + * Copyright 2008-2016 Hippo B.V. (http://www.onehippo.com) * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -231,7 +231,7 @@ public class PropertyDecorator extends ItemDecorator implements Property { } public Property getProperty() throws ItemNotFoundException, ValueFormatException, RepositoryException { -return property.getProperty(); +return factory.getPropertyDecorator(session, property.getProperty()); } public boolean isMultiple() throws RepositoryException { View it on GitLab: https://code.onehippo.org/cms-community/hippo-repository/commit/a5efd088ad3e45a1bae3d58a6f830ece0bbb8290
[HippoCMS-scm] [Git][cms-community/hippo-addon-channel-manager][feature/visual-editing-psp1-CHANNELMGR-970] 2 commits: CHANNELMGR-970 fix styling based on Carolien feedback
Mark Lenser pushed to branch feature/visual-editing-psp1-CHANNELMGR-970 at cms-community / hippo-addon-channel-manager Commits: b6ff77f9 by Mark at 2016-11-07T14:49:58+01:00 CHANNELMGR-970 fix styling based on Carolien feedback - - - - - 52173b24 by Mark at 2016-11-07T14:52:13+01:00 CHANNELMGR-970 remove errors if values is empty - - - - - 4 changed files: - frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.component.js - frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.html - frontend-ng/src/styles/_forms.scss - frontend-ng/src/styles/_variables.scss Changes: = frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.component.js = --- a/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.component.js +++ b/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.component.js @@ -26,7 +26,7 @@ export class ChannelFieldsCtrl { } getFieldAsArray(fieldId) { -const field = this.fieldValues[fieldId]; +const field = this.fieldValues[fieldId] || []; return angular.isArray(field) ? field : [field]; } = frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.html = --- a/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.html +++ b/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.html @@ -13,7 +13,8 @@ See the License for the specific language governing permissions and limitations under the License. --> -https://code.onehippo.org/cms-community/hippo-addon-channel-manager/compare/ede8910a68fc0c90e44897b39a451a30cb95a58b...52173b2452aee28d4e9e0aeebea02fc36791e1cf ___ Hippocms-svn mailing list Hippocms-svn@lists.onehippo.org https://lists.onehippo.org/mailman/listinfo/hippocms-svn
[HippoCMS-scm] [Git][cms-community/hippo-addon-channel-manager][feature/visual-editing-psp1-CHANNELMGR-970] CHANNELMGR-970 move repeat to the top level to prevent extra fields at the end
Mark Lenser pushed to branch feature/visual-editing-psp1-CHANNELMGR-970 at cms-community / hippo-addon-channel-manager Commits: d27c4346 by Mark at 2016-11-07T15:01:38+01:00 CHANNELMGR-970 move repeat to the top level to prevent extra fields at the end - - - - - 1 changed file: - frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.html Changes: = frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.html = --- a/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.html +++ b/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.html @@ -29,13 +29,13 @@ - - + + keyboard_arrow_down {{ ::fieldType.displayName }} View it on GitLab: https://code.onehippo.org/cms-community/hippo-addon-channel-manager/commit/d27c4346a83b2e8b18a1e95287bdc820991aacbf ___ Hippocms-svn mailing list Hippocms-svn@lists.onehippo.org https://lists.onehippo.org/mailman/listinfo/hippocms-svn
[HippoCMS-scm] [Git][cms-community/hippo-addon-channel-manager][feature/visual-editing-psp1] 5 commits: CHANNELMGR-929 Only render .hst-cmseditlink when visible
Tobias Jeger pushed to branch feature/visual-editing-psp1 at cms-community / hippo-addon-channel-manager Commits: 4069866f by Arthur Bogaart at 2016-11-01T16:11:57+01:00 CHANNELMGR-929 Only render .hst-cmseditlink when visible An element is considered invisible if it or one of it's ancestors has the CSS style property visibility set to hidden, or it is not found with jQuery's :visible selector. The #isVisible check should only be applied to hst-cmseditlink elements (edit document/menu buttons) and these should be actively hidden when the iframeElement is not considered visible. - - - - - af35377a by Mathijs den Burger at 2016-11-03T10:42:28+01:00 CHANNELMGR-929 Improve performance of isVisible, remove fit'ed test Pass the jQuery element to avoid querying it again. First check is(':visible') since that is the more common use case. - - - - - 5176cf5b by Mathijs den Burger at 2016-11-03T10:42:51+01:00 CHANNELMGR-929 Reintegrate bugfix/CHANNELMGR-929 - - - - - d820e6ec by Tobias Jeger at 2016-11-07T16:00:06+01:00 CHANNELMGR-840 Merge branch 'master' into feature/visual-editing-psp1 - - - - - d9cddd34 by Tobias Jeger at 2016-11-07T16:00:28+01:00 CHANNELMGR-840 Merge branch 'master' into feature/visual-editing-psp1 - - - - - 4 changed files: - frontend-ng/src/angularjs/channel/hippoIframe/overlay/overlaySync.service.js - frontend-ng/src/angularjs/services/dom.service.fixture.html - frontend-ng/src/angularjs/services/dom.service.js - frontend-ng/src/angularjs/services/dom.service.spec.js Changes: = frontend-ng/src/angularjs/channel/hippoIframe/overlay/overlaySync.service.js = --- a/frontend-ng/src/angularjs/channel/hippoIframe/overlay/overlaySync.service.js +++ b/frontend-ng/src/angularjs/channel/hippoIframe/overlay/overlaySync.service.js @@ -187,8 +187,20 @@ class OverlaySyncService { const overlayJQueryElement = structureElement.getOverlayElement(); const iframeJQueryElement = structureElement.getBoxElement(); -const rect = iframeJQueryElement[0].getBoundingClientRect(); +if (iframeJQueryElement.hasClass('hst-cmseditlink')) { + if (this.DomService.isVisible(iframeJQueryElement)) { +overlayJQueryElement.show(); +this._drawElement(overlayJQueryElement, iframeJQueryElement); + } else { +overlayJQueryElement.hide(); + } +} else { + this._drawElement(overlayJQueryElement, iframeJQueryElement); +} + } + _drawElement(overlayJQueryElement, iframeJQueryElement) { +const rect = iframeJQueryElement[0].getBoundingClientRect(); overlayJQueryElement.css('top', `${rect.top}px`); overlayJQueryElement.css('left', `${rect.left}px`); overlayJQueryElement.css('height', `${rect.height}px`); = frontend-ng/src/angularjs/services/dom.service.fixture.html = --- a/frontend-ng/src/angularjs/services/dom.service.fixture.html +++ b/frontend-ng/src/angularjs/services/dom.service.fixture.html @@ -30,6 +30,36 @@ + + + + + + + + + + + + + + +Text + + + + + + + + +Text + + + + + + \ No newline at end of file = frontend-ng/src/angularjs/services/dom.service.js = --- a/frontend-ng/src/angularjs/services/dom.service.js +++ b/frontend-ng/src/angularjs/services/dom.service.js @@ -158,6 +158,15 @@ class DomService { return rectBottom + marginBottom; } + isVisible(jqueryElement) { +let isVisible = jqueryElement.is(':visible'); +if (isVisible) { + const style = window.getComputedStyle(jqueryElement[0]); + isVisible = style.visibility !== 'hidden'; +} +return isVisible; + } + getLowestElementBottom(document) { const allElements = document.querySelectorAll('body *'); const count = allElements.length; = frontend-ng/src/angularjs/services/dom.service.spec.js = --- a/frontend-ng/src/angularjs/services/dom.service.spec.js +++ b/frontend-ng/src/angularjs/services/dom.service.spec.js @@ -178,5 +178,21 @@ describe('DomService', () => { it('can calculate the bottom of the lowest element in a document', () => { expect(DomService.getLowestElementBottom(document)).toBe(1050); }); + + it('can check if an element is hidden on the page', () => { +$j('.shouldBeHidden').each((index, el) => { + expect(DomService.isVisible($j(el))).toBe(false); +}); + }); + + it('can check if an element is visible on the page', () => { +$j('.shouldBeVisible').each((index, el) => { + expect(DomService.isVisible($j(el))).toBe(true); +}); + }); + + it('can check whether the body is visible', () => { +expect(DomService.isVisible($j(document.body))).toBe(true); + }); }); Vi
[HippoCMS-scm] [Git][cms-community/hippo-addon-channel-manager][feature/visual-editing-psp1-CHANNELMGR-970] 4 commits: CHANNELMGR-970 add aria-label
Mark Lenser pushed to branch feature/visual-editing-psp1-CHANNELMGR-970 at cms-community / hippo-addon-channel-manager Commits: 76865e69 by Mark at 2016-11-07T16:15:37+01:00 CHANNELMGR-970 add aria-label - - - - - 62610190 by Mark at 2016-11-07T16:18:59+01:00 CHANNELMGR-970 aria-label - - - - - 02102678 by Mark at 2016-11-07T16:21:28+01:00 CHANNELMGR-970 move comment - - - - - f6918f63 by Mark at 2016-11-07T17:13:52+01:00 CHANNELMGR-970 return empty array if the value cannot be found - for cases like optional recursion - - - - - 2 changed files: - frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.component.js - frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.html Changes: = frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.component.js = --- a/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.component.js +++ b/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.component.js @@ -26,7 +26,10 @@ export class ChannelFieldsCtrl { } getFieldAsArray(fieldId) { -const field = this.fieldValues[fieldId] || []; +let field = this.fieldValues[fieldId]; +if (typeof field === 'undefined') { + field = []; +} return angular.isArray(field) ? field : [field]; } = frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.html = --- a/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.html +++ b/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.html @@ -45,8 +45,8 @@ + - @@ -81,6 +84,7 @@ ng-if="!fieldType.multiple" ng-model="$ctrl.fieldValues[fieldType.id]" placeholder="" +aria-label="{{::fieldType.displayName}}" md-no-resize ng-focus="$ctrl.onFieldFocus(fieldType)" ng-blur="$ctrl.onFieldBlur(fieldType)"> View it on GitLab: https://code.onehippo.org/cms-community/hippo-addon-channel-manager/compare/d27c4346a83b2e8b18a1e95287bdc820991aacbf...f6918f639dd320cda2c81c0b27726ecc4889742f ___ Hippocms-svn mailing list Hippocms-svn@lists.onehippo.org https://lists.onehippo.org/mailman/listinfo/hippocms-svn
[HippoCMS-scm] [Git][cms-community/hippo-addon-channel-manager] Pushed new branch bugfix/CHANNELMGR-979
Arthur Bogaart pushed new branch bugfix/CHANNELMGR-979 at cms-community / hippo-addon-channel-manager ___ Hippocms-svn mailing list Hippocms-svn@lists.onehippo.org https://lists.onehippo.org/mailman/listinfo/hippocms-svn