[jira] Commented: (HIVE-1607) Reinstate and deprecate IMetaStoreClient methods removed in HIVE-675
[
https://issues.apache.org/jira/browse/HIVE-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910732#action_12910732
]
John Sichi commented on HIVE-1607:
--
I think we can re-close this one now since it was squashed into the backport
for HIVE-675, right?
> Reinstate and deprecate IMetaStoreClient methods removed in HIVE-675
>
>
> Key: HIVE-1607
> URL: https://issues.apache.org/jira/browse/HIVE-1607
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Metastore
>Reporter: Carl Steinbach
>Assignee: Carl Steinbach
> Fix For: 0.6.0, 0.7.0
>
> Attachments: HIVE-1607.1.patch.txt, HIVE-1607.2.patch.txt
>
>
> Several methods were removed from the IMetaStoreClient interface as part of
> HIVE-675:
> {code}
> /**
>* Drop the table.
>*
>* @param tableName
>* The table to drop
>* @param deleteData
>* Should we delete the underlying data
>* @throws MetaException
>* Could not drop table properly.
>* @throws UnknownTableException
>* The table wasn't found.
>* @throws TException
>* A thrift communication error occurred
>* @throws NoSuchObjectException
>* The table wasn't found.
>*/
> public void dropTable(String tableName, boolean deleteData)
> throws MetaException, UnknownTableException, TException,
> NoSuchObjectException;
> /**
>* Get a table object.
>*
>* @param tableName
>* Name of the table to fetch.
>* @return An object representing the table.
>* @throws MetaException
>* Could not fetch the table
>* @throws TException
>* A thrift communication error occurred
>* @throws NoSuchObjectException
>* In case the table wasn't found.
>*/
> public Table getTable(String tableName) throws MetaException, TException,
> NoSuchObjectException;
> public boolean tableExists(String databaseName, String tableName) throws
> MetaException,
> TException, UnknownDBException;
> {code}
> These methods should be reinstated with a deprecation warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1607) Reinstate and deprecate IMetaStoreClient methods removed in HIVE-675
[
https://issues.apache.org/jira/browse/HIVE-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904512#action_12904512
]
Ning Zhang commented on HIVE-1607:
--
+1. Will commit if tests pass.
> Reinstate and deprecate IMetaStoreClient methods removed in HIVE-675
>
>
> Key: HIVE-1607
> URL: https://issues.apache.org/jira/browse/HIVE-1607
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Metastore
>Reporter: Carl Steinbach
>Assignee: Carl Steinbach
> Attachments: HIVE-1607.1.patch.txt, HIVE-1607.2.patch.txt
>
>
> Several methods were removed from the IMetaStoreClient interface as part of
> HIVE-675:
> {code}
> /**
>* Drop the table.
>*
>* @param tableName
>* The table to drop
>* @param deleteData
>* Should we delete the underlying data
>* @throws MetaException
>* Could not drop table properly.
>* @throws UnknownTableException
>* The table wasn't found.
>* @throws TException
>* A thrift communication error occurred
>* @throws NoSuchObjectException
>* The table wasn't found.
>*/
> public void dropTable(String tableName, boolean deleteData)
> throws MetaException, UnknownTableException, TException,
> NoSuchObjectException;
> /**
>* Get a table object.
>*
>* @param tableName
>* Name of the table to fetch.
>* @return An object representing the table.
>* @throws MetaException
>* Could not fetch the table
>* @throws TException
>* A thrift communication error occurred
>* @throws NoSuchObjectException
>* In case the table wasn't found.
>*/
> public Table getTable(String tableName) throws MetaException, TException,
> NoSuchObjectException;
> public boolean tableExists(String databaseName, String tableName) throws
> MetaException,
> TException, UnknownDBException;
> {code}
> These methods should be reinstated with a deprecation warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1607) Reinstate and deprecate IMetaStoreClient methods removed in HIVE-675
[
https://issues.apache.org/jira/browse/HIVE-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904502#action_12904502
]
Ning Zhang commented on HIVE-1607:
--
I'll take a look.
> Reinstate and deprecate IMetaStoreClient methods removed in HIVE-675
>
>
> Key: HIVE-1607
> URL: https://issues.apache.org/jira/browse/HIVE-1607
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Metastore
>Reporter: Carl Steinbach
>Assignee: Carl Steinbach
> Attachments: HIVE-1607.1.patch.txt, HIVE-1607.2.patch.txt
>
>
> Several methods were removed from the IMetaStoreClient interface as part of
> HIVE-675:
> {code}
> /**
>* Drop the table.
>*
>* @param tableName
>* The table to drop
>* @param deleteData
>* Should we delete the underlying data
>* @throws MetaException
>* Could not drop table properly.
>* @throws UnknownTableException
>* The table wasn't found.
>* @throws TException
>* A thrift communication error occurred
>* @throws NoSuchObjectException
>* The table wasn't found.
>*/
> public void dropTable(String tableName, boolean deleteData)
> throws MetaException, UnknownTableException, TException,
> NoSuchObjectException;
> /**
>* Get a table object.
>*
>* @param tableName
>* Name of the table to fetch.
>* @return An object representing the table.
>* @throws MetaException
>* Could not fetch the table
>* @throws TException
>* A thrift communication error occurred
>* @throws NoSuchObjectException
>* In case the table wasn't found.
>*/
> public Table getTable(String tableName) throws MetaException, TException,
> NoSuchObjectException;
> public boolean tableExists(String databaseName, String tableName) throws
> MetaException,
> TException, UnknownDBException;
> {code}
> These methods should be reinstated with a deprecation warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1607) Reinstate and deprecate IMetaStoreClient methods removed in HIVE-675
[
https://issues.apache.org/jira/browse/HIVE-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904496#action_12904496
]
HBase Review Board commented on HIVE-1607:
--
Message from: "Carl Steinbach"
---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/749/
---
(Updated 2010-08-30 18:45:24.915657)
Review request for Hive Developers.
Changes
---
dropTable(tableName, deleteData) should not mask UnknownTableExceptions.
Summary
---
Reinstated/deprecated the following methods that were removed in HIVE-675:
public void dropTable(String tableName, boolean deleteData);
public Table getTable(String tableName);
public boolean tableExists(String tableName);
Also added JavaDoc for several of the methods that were previously added in
HIVE-675.
This addresses bug HIVE-1607.
http://issues.apache.org/jira/browse/HIVE-1607
Diffs (updated)
-
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
7fd99d8
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
20deb21
Diff: http://review.cloudera.org/r/749/diff
Testing
---
Thanks,
Carl
> Reinstate and deprecate IMetaStoreClient methods removed in HIVE-675
>
>
> Key: HIVE-1607
> URL: https://issues.apache.org/jira/browse/HIVE-1607
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Metastore
>Reporter: Carl Steinbach
>Assignee: Carl Steinbach
> Attachments: HIVE-1607.1.patch.txt, HIVE-1607.2.patch.txt
>
>
> Several methods were removed from the IMetaStoreClient interface as part of
> HIVE-675:
> {code}
> /**
>* Drop the table.
>*
>* @param tableName
>* The table to drop
>* @param deleteData
>* Should we delete the underlying data
>* @throws MetaException
>* Could not drop table properly.
>* @throws UnknownTableException
>* The table wasn't found.
>* @throws TException
>* A thrift communication error occurred
>* @throws NoSuchObjectException
>* The table wasn't found.
>*/
> public void dropTable(String tableName, boolean deleteData)
> throws MetaException, UnknownTableException, TException,
> NoSuchObjectException;
> /**
>* Get a table object.
>*
>* @param tableName
>* Name of the table to fetch.
>* @return An object representing the table.
>* @throws MetaException
>* Could not fetch the table
>* @throws TException
>* A thrift communication error occurred
>* @throws NoSuchObjectException
>* In case the table wasn't found.
>*/
> public Table getTable(String tableName) throws MetaException, TException,
> NoSuchObjectException;
> public boolean tableExists(String databaseName, String tableName) throws
> MetaException,
> TException, UnknownDBException;
> {code}
> These methods should be reinstated with a deprecation warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1607) Reinstate and deprecate IMetaStoreClient methods removed in HIVE-675
[
https://issues.apache.org/jira/browse/HIVE-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904491#action_12904491
]
HBase Review Board commented on HIVE-1607:
--
Message from: "Carl Steinbach"
---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/749/
---
Review request for Hive Developers.
Summary
---
Reinstated/deprecated the following methods that were removed in HIVE-675:
public void dropTable(String tableName, boolean deleteData);
public Table getTable(String tableName);
public boolean tableExists(String tableName);
Also added JavaDoc for several of the methods that were previously added in
HIVE-675.
This addresses bug HIVE-1607.
http://issues.apache.org/jira/browse/HIVE-1607
Diffs
-
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
7fd99d8
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
20deb21
Diff: http://review.cloudera.org/r/749/diff
Testing
---
Thanks,
Carl
> Reinstate and deprecate IMetaStoreClient methods removed in HIVE-675
>
>
> Key: HIVE-1607
> URL: https://issues.apache.org/jira/browse/HIVE-1607
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Metastore
>Reporter: Carl Steinbach
>Assignee: Carl Steinbach
> Attachments: HIVE-1607.1.patch.txt
>
>
> Several methods were removed from the IMetaStoreClient interface as part of
> HIVE-675:
> {code}
> /**
>* Drop the table.
>*
>* @param tableName
>* The table to drop
>* @param deleteData
>* Should we delete the underlying data
>* @throws MetaException
>* Could not drop table properly.
>* @throws UnknownTableException
>* The table wasn't found.
>* @throws TException
>* A thrift communication error occurred
>* @throws NoSuchObjectException
>* The table wasn't found.
>*/
> public void dropTable(String tableName, boolean deleteData)
> throws MetaException, UnknownTableException, TException,
> NoSuchObjectException;
> /**
>* Get a table object.
>*
>* @param tableName
>* Name of the table to fetch.
>* @return An object representing the table.
>* @throws MetaException
>* Could not fetch the table
>* @throws TException
>* A thrift communication error occurred
>* @throws NoSuchObjectException
>* In case the table wasn't found.
>*/
> public Table getTable(String tableName) throws MetaException, TException,
> NoSuchObjectException;
> public boolean tableExists(String databaseName, String tableName) throws
> MetaException,
> TException, UnknownDBException;
> {code}
> These methods should be reinstated with a deprecation warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
