Re: [Intel-gfx] [Mesa-dev] [PATCH v1 00/13] Implement sw_sync test
On Tue, Aug 23, 2016 at 01:56:02PM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > This series implements the sw_sync test and the lib/sw_sync helper functions > for said test. > > Gustavo Padovans sw_sync series was just de-staged in > gregkh-staging/staging-next [1], and this test is targeted at verifying the > functionality implemented in that series. > > The sw_sync subtests range from very basic tests of the sw_sync functionality, > to stress testing and randomized tests. > > [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/ > > Robert Foss (13): > lib/sw_sync: Add helper functions for managing synchronization > primitives > tests/sw_sync: Add sw_sync test > tests/sw_sync: Add subtest test_alloc_fence > tests/sw_sync: Add subtest test_alloc_fence_invalid_timeline > tests/sw_sync: Add subtest test_alloc_merge_fence > tests/sw_sync: Add subtest test_sync_wait > tests/sw_sync: Add subtest test_sync_merge > tests/sw_sync: Add subtest test_sync_merge_same > tests/sw_sync: Add subtest test_sync_multi_consumer > tests/sw_sync: Add subtest test_sync_multi_consumer_producer > tests/sw_sync: Add subtest test_sync_random_merge > tests/sw_sync: Add subtest test_sync_multi_timeline_wait > tests/sw_sync: Add subtest test_sync_multi_producer_single_consumer > > lib/Makefile.sources | 2 + > lib/sw_sync.c | 237 + > lib/sw_sync.h | 49 > tests/Makefile.sources | 1 + > tests/sw_sync.c| 693 > + > 5 files changed, 982 insertions(+) > create mode 100644 lib/sw_sync.c > create mode 100644 lib/sw_sync.h > create mode 100644 tests/sw_sync.c > > -- > 2.7.4 Thanks for your work! I sent some specific comments directly to a few patches, but everything else looks good to me. With the issues raised in patches 1 & 2 fixed (and with or without my suggestions), the whole series is: Reviewed-by: Eric Engestrom Cheers, Eric ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [Mesa-dev] [PATCH v1 00/13] Implement sw_sync test
On 2016-08-23 06:56 PM, Eric Engestrom wrote: On Tue, Aug 23, 2016 at 01:56:02PM -0400, robert.f...@collabora.com wrote: From: Robert Foss This series implements the sw_sync test and the lib/sw_sync helper functions for said test. Gustavo Padovans sw_sync series was just de-staged in gregkh-staging/staging-next [1], and this test is targeted at verifying the functionality implemented in that series. The sw_sync subtests range from very basic tests of the sw_sync functionality, to stress testing and randomized tests. [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/ Robert Foss (13): lib/sw_sync: Add helper functions for managing synchronization primitives tests/sw_sync: Add sw_sync test tests/sw_sync: Add subtest test_alloc_fence tests/sw_sync: Add subtest test_alloc_fence_invalid_timeline tests/sw_sync: Add subtest test_alloc_merge_fence tests/sw_sync: Add subtest test_sync_wait tests/sw_sync: Add subtest test_sync_merge tests/sw_sync: Add subtest test_sync_merge_same tests/sw_sync: Add subtest test_sync_multi_consumer tests/sw_sync: Add subtest test_sync_multi_consumer_producer tests/sw_sync: Add subtest test_sync_random_merge tests/sw_sync: Add subtest test_sync_multi_timeline_wait tests/sw_sync: Add subtest test_sync_multi_producer_single_consumer lib/Makefile.sources | 2 + lib/sw_sync.c | 237 + lib/sw_sync.h | 49 tests/Makefile.sources | 1 + tests/sw_sync.c| 693 + 5 files changed, 982 insertions(+) create mode 100644 lib/sw_sync.c create mode 100644 lib/sw_sync.h create mode 100644 tests/sw_sync.c -- 2.7.4 Thanks for your work! I sent some specific comments directly to a few patches, but everything else looks good to me. With the issues raised in patches 1 & 2 fixed (and with or without my suggestions), the whole series is: Reviewed-by: Eric Engestrom Cheers, Eric Thanks for the quick feedback! All of the suggested changes have been fixed for v2, which is upcoming. Rob. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx