Re: [Intel-gfx] [PATCH] RFC drm/i915: Add a sunset clause to GPU hang logging
On ma, 2016-10-17 at 16:10 +0200, Daniel Vetter wrote: > On Mon, Oct 17, 2016 at 03:33:43PM +0300, Joonas Lahtinen wrote: > > Maybe we could even explicitly state that bugs should be reported to > > the distro bugzilla because of running an old kernel? > > Distro's already shut down our warnings "because too much noise", I don't > think that's valuable. Reviewed-by: Joonas Lahtinen Just needs a patch to DIM to bump the timestamp. Regards, Joonas > > > Acked-by: Daniel Vetter -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] RFC drm/i915: Add a sunset clause to GPU hang logging
On Mon, Oct 17, 2016 at 03:33:43PM +0300, Joonas Lahtinen wrote: > On pe, 2016-10-14 at 14:44 +0100, Chris Wilson wrote: > > If the kernel is old, more than a few releases old, chances are that the > > user is using an old kernel for a good reason, despite there being GPU > > hangs. After 180days since driver release stop suggesting that they > > should send those reports upstream. > > > > Signed-off-by: Chris Wilson > > Cc: Daniel Vetter > > Maybe we could even explicitly state that bugs should be reported to > the distro bugzilla because of running an old kernel? Distro's already shut down our warnings "because too much noise", I don't think that's valuable. Acked-by: Daniel Vetter -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] RFC drm/i915: Add a sunset clause to GPU hang logging
On pe, 2016-10-14 at 14:44 +0100, Chris Wilson wrote: > If the kernel is old, more than a few releases old, chances are that the > user is using an old kernel for a good reason, despite there being GPU > hangs. After 180days since driver release stop suggesting that they > should send those reports upstream. > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter Maybe we could even explicitly state that bugs should be reported to the distro bugzilla because of running an old kernel? Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] RFC drm/i915: Add a sunset clause to GPU hang logging
If the kernel is old, more than a few releases old, chances are that the user is using an old kernel for a good reason, despite there being GPU hangs. After 180days since driver release stop suggesting that they should send those reports upstream. Signed-off-by: Chris Wilson Cc: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gpu_error.c | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 0e82f04ac3d6..0719104ebdd5 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -73,6 +73,7 @@ #define DRIVER_NAME"i915" #define DRIVER_DESC"Intel Graphics" #define DRIVER_DATE"20161010" +#define DRIVER_TIMESTAMP 1476452087 #undef WARN_ON /* Many gcc seem to no see through this and fall over :( */ diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c index 2275a8d91539..e757783f935b 100644 --- a/drivers/gpu/drm/i915/i915_gpu_error.c +++ b/drivers/gpu/drm/i915/i915_gpu_error.c @@ -1551,6 +1551,8 @@ static int capture(void *data) return 0; } +#define DAY_AS_SECONDS(x) (24 * 60 * 60 * (x)) + /** * i915_capture_error_state - capture an error record for later analysis * @dev: drm device @@ -1603,7 +1605,8 @@ void i915_capture_error_state(struct drm_i915_private *dev_priv, return; } - if (!warned) { + if (!warned && + ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) { DRM_INFO("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n"); DRM_INFO("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n"); DRM_INFO("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n"); -- 2.9.3 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx