[Intel-gfx] [PATCH 4/4] drm/i915: Remove now useless comments about the translation values
We used to carry a default HDMI value in entry 9, but this entry got removed for both HSW and BDW. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_ddi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c index 80526ab..ab5f65f 100644 --- a/drivers/gpu/drm/i915/intel_ddi.c +++ b/drivers/gpu/drm/i915/intel_ddi.c @@ -33,7 +33,7 @@ * automatically adapt to HDMI connections as well */ static const u32 hsw_ddi_translations_dp[] = { - 0x00FF, 0x0006000E, /* DP parameters */ + 0x00FF, 0x0006000E, 0x00D75FFF, 0x0005000A, 0x00C30FFF, 0x00040006, 0x80AAAFFF, 0x000B, @@ -45,7 +45,7 @@ static const u32 hsw_ddi_translations_dp[] = { }; static const u32 hsw_ddi_translations_fdi[] = { - 0x00FF, 0x0007000E, /* FDI parameters */ + 0x00FF, 0x0007000E, 0x00D75FFF, 0x000F000A, 0x00C30FFF, 0x00060006, 0x00AAAFFF, 0x001E, @@ -73,7 +73,7 @@ static const u32 hsw_ddi_translations_hdmi[] = { }; static const u32 bdw_ddi_translations_edp[] = { - 0x00FF, 0x0012, /* eDP parameters */ + 0x00FF, 0x0012, 0x00EBAFFF, 0x00020011, 0x00C71FFF, 0x0006000F, 0x00AAAFFF, 0x000E000A, @@ -85,7 +85,7 @@ static const u32 bdw_ddi_translations_edp[] = { }; static const u32 bdw_ddi_translations_dp[] = { - 0x00FF, 0x0007000E, /* DP parameters */ + 0x00FF, 0x0007000E, 0x00D75FFF, 0x000E000A, 0x00BE, 0x00140006, 0x80B2CFFF, 0x001B0002, @@ -97,7 +97,7 @@ static const u32 bdw_ddi_translations_dp[] = { }; static const u32 bdw_ddi_translations_fdi[] = { - 0x00FF, 0x0001000E, /* FDI parameters */ + 0x00FF, 0x0001000E, 0x00D75FFF, 0x0004000A, 0x00C30FFF, 0x00070006, 0x00AAAFFF, 0x000C, -- 1.8.3.1 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 4/4] drm/i915: Remove now useless comments about the translation values
2014-08-01 7:07 GMT-03:00 Damien Lespiau : > We used to carry a default HDMI value in entry 9, but this entry got > removed for both HSW and BDW. > Reviewed-by: Paulo Zanoni > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/intel_ddi.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c > b/drivers/gpu/drm/i915/intel_ddi.c > index 80526ab..ab5f65f 100644 > --- a/drivers/gpu/drm/i915/intel_ddi.c > +++ b/drivers/gpu/drm/i915/intel_ddi.c > @@ -33,7 +33,7 @@ > * automatically adapt to HDMI connections as well > */ > static const u32 hsw_ddi_translations_dp[] = { > - 0x00FF, 0x0006000E, /* DP parameters */ > + 0x00FF, 0x0006000E, > 0x00D75FFF, 0x0005000A, > 0x00C30FFF, 0x00040006, > 0x80AAAFFF, 0x000B, > @@ -45,7 +45,7 @@ static const u32 hsw_ddi_translations_dp[] = { > }; > > static const u32 hsw_ddi_translations_fdi[] = { > - 0x00FF, 0x0007000E, /* FDI parameters */ > + 0x00FF, 0x0007000E, > 0x00D75FFF, 0x000F000A, > 0x00C30FFF, 0x00060006, > 0x00AAAFFF, 0x001E, > @@ -73,7 +73,7 @@ static const u32 hsw_ddi_translations_hdmi[] = { > }; > > static const u32 bdw_ddi_translations_edp[] = { > - 0x00FF, 0x0012, /* eDP parameters */ > + 0x00FF, 0x0012, > 0x00EBAFFF, 0x00020011, > 0x00C71FFF, 0x0006000F, > 0x00AAAFFF, 0x000E000A, > @@ -85,7 +85,7 @@ static const u32 bdw_ddi_translations_edp[] = { > }; > > static const u32 bdw_ddi_translations_dp[] = { > - 0x00FF, 0x0007000E, /* DP parameters */ > + 0x00FF, 0x0007000E, > 0x00D75FFF, 0x000E000A, > 0x00BE, 0x00140006, > 0x80B2CFFF, 0x001B0002, > @@ -97,7 +97,7 @@ static const u32 bdw_ddi_translations_dp[] = { > }; > > static const u32 bdw_ddi_translations_fdi[] = { > - 0x00FF, 0x0001000E, /* FDI parameters */ > + 0x00FF, 0x0001000E, > 0x00D75FFF, 0x0004000A, > 0x00C30FFF, 0x00070006, > 0x00AAAFFF, 0x000C, > -- > 1.8.3.1 > > ___ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Paulo Zanoni ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 4/4] drm/i915: Remove now useless comments about the translation values
On Fri, Aug 01, 2014 at 12:29:22PM -0300, Paulo Zanoni wrote: > 2014-08-01 7:07 GMT-03:00 Damien Lespiau : > > We used to carry a default HDMI value in entry 9, but this entry got > > removed for both HSW and BDW. > > > > Reviewed-by: Paulo Zanoni Pulled in entire series, thanks. I'll shuffle the first two for 3.17 when I split my queue. We can cc: stable if they are known to make an actual user happier ;-) -Daniel > > > Signed-off-by: Damien Lespiau > > --- > > drivers/gpu/drm/i915/intel_ddi.c | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c > > b/drivers/gpu/drm/i915/intel_ddi.c > > index 80526ab..ab5f65f 100644 > > --- a/drivers/gpu/drm/i915/intel_ddi.c > > +++ b/drivers/gpu/drm/i915/intel_ddi.c > > @@ -33,7 +33,7 @@ > > * automatically adapt to HDMI connections as well > > */ > > static const u32 hsw_ddi_translations_dp[] = { > > - 0x00FF, 0x0006000E, /* DP parameters */ > > + 0x00FF, 0x0006000E, > > 0x00D75FFF, 0x0005000A, > > 0x00C30FFF, 0x00040006, > > 0x80AAAFFF, 0x000B, > > @@ -45,7 +45,7 @@ static const u32 hsw_ddi_translations_dp[] = { > > }; > > > > static const u32 hsw_ddi_translations_fdi[] = { > > - 0x00FF, 0x0007000E, /* FDI parameters */ > > + 0x00FF, 0x0007000E, > > 0x00D75FFF, 0x000F000A, > > 0x00C30FFF, 0x00060006, > > 0x00AAAFFF, 0x001E, > > @@ -73,7 +73,7 @@ static const u32 hsw_ddi_translations_hdmi[] = { > > }; > > > > static const u32 bdw_ddi_translations_edp[] = { > > - 0x00FF, 0x0012, /* eDP parameters */ > > + 0x00FF, 0x0012, > > 0x00EBAFFF, 0x00020011, > > 0x00C71FFF, 0x0006000F, > > 0x00AAAFFF, 0x000E000A, > > @@ -85,7 +85,7 @@ static const u32 bdw_ddi_translations_edp[] = { > > }; > > > > static const u32 bdw_ddi_translations_dp[] = { > > - 0x00FF, 0x0007000E, /* DP parameters */ > > + 0x00FF, 0x0007000E, > > 0x00D75FFF, 0x000E000A, > > 0x00BE, 0x00140006, > > 0x80B2CFFF, 0x001B0002, > > @@ -97,7 +97,7 @@ static const u32 bdw_ddi_translations_dp[] = { > > }; > > > > static const u32 bdw_ddi_translations_fdi[] = { > > - 0x00FF, 0x0001000E, /* FDI parameters */ > > + 0x00FF, 0x0001000E, > > 0x00D75FFF, 0x0004000A, > > 0x00C30FFF, 0x00070006, > > 0x00AAAFFF, 0x000C, > > -- > > 1.8.3.1 > > > > ___ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > -- > Paulo Zanoni > ___ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx