Re: [Intel-gfx] [PATCH 09/11] drm/i915/guc: Fix GuC interrupts disabling with Logging
On 10/19/2017 3:54 PM, Tvrtko Ursulin wrote: On 18/10/2017 07:47, Sagar Arun Kamble wrote: With guc_log_unregister disabling runtime logging and interrupts there is no need to disable interrupts during uc_fini_hw hence it is removed. With GuC CT buffer mechanism, interrupt disabling can be added at a point where CT mechanism ceases. Signed-off-by: Sagar Arun Kamble Cc: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Tvrtko Ursulin Cc: Chris Wilson Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/intel_uc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c index d96c847..9715eda 100644 --- a/drivers/gpu/drm/i915/intel_uc.c +++ b/drivers/gpu/drm/i915/intel_uc.c @@ -287,9 +287,6 @@ void intel_uc_fini_hw(struct drm_i915_private *dev_priv) guc_disable_communication(&dev_priv->guc); - if (i915_modparams.guc_log_level >= 0) - intel_put_guc_interrupts(&dev_priv->guc, GUC_INTR_CLIENT_LOG); - And this hasn't became wrong in this series right? So normally I think you would remove the bug before refactoring patches, just so we don't have to read and review in a previous patch the lines which get removed in the next. Sure. Will remove this upfront. if (i915_modparams.enable_guc_submission) i915_guc_submission_fini(dev_priv); Regards, Tvrtko ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 09/11] drm/i915/guc: Fix GuC interrupts disabling with Logging
On 18/10/2017 07:47, Sagar Arun Kamble wrote: With guc_log_unregister disabling runtime logging and interrupts there is no need to disable interrupts during uc_fini_hw hence it is removed. With GuC CT buffer mechanism, interrupt disabling can be added at a point where CT mechanism ceases. Signed-off-by: Sagar Arun Kamble Cc: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Tvrtko Ursulin Cc: Chris Wilson Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/intel_uc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c index d96c847..9715eda 100644 --- a/drivers/gpu/drm/i915/intel_uc.c +++ b/drivers/gpu/drm/i915/intel_uc.c @@ -287,9 +287,6 @@ void intel_uc_fini_hw(struct drm_i915_private *dev_priv) guc_disable_communication(&dev_priv->guc); - if (i915_modparams.guc_log_level >= 0) - intel_put_guc_interrupts(&dev_priv->guc, GUC_INTR_CLIENT_LOG); - And this hasn't became wrong in this series right? So normally I think you would remove the bug before refactoring patches, just so we don't have to read and review in a previous patch the lines which get removed in the next. if (i915_modparams.enable_guc_submission) i915_guc_submission_fini(dev_priv); Regards, Tvrtko ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 09/11] drm/i915/guc: Fix GuC interrupts disabling with Logging
With guc_log_unregister disabling runtime logging and interrupts there is no need to disable interrupts during uc_fini_hw hence it is removed. With GuC CT buffer mechanism, interrupt disabling can be added at a point where CT mechanism ceases. Signed-off-by: Sagar Arun Kamble Cc: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Tvrtko Ursulin Cc: Chris Wilson Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/intel_uc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c index d96c847..9715eda 100644 --- a/drivers/gpu/drm/i915/intel_uc.c +++ b/drivers/gpu/drm/i915/intel_uc.c @@ -287,9 +287,6 @@ void intel_uc_fini_hw(struct drm_i915_private *dev_priv) guc_disable_communication(&dev_priv->guc); - if (i915_modparams.guc_log_level >= 0) - intel_put_guc_interrupts(&dev_priv->guc, GUC_INTR_CLIENT_LOG); - if (i915_modparams.enable_guc_submission) i915_guc_submission_fini(dev_priv); -- 1.9.1 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
