Re: [PATCH] iommu/ipmmu-vmsa: Return proper error if devm_request_irq fails

2014-11-04 Thread Joerg Roedel
On Sun, Nov 02, 2014 at 12:42:15AM +0200, Laurent Pinchart wrote:
> Hi Axel,
> 
> Thank you for the patch.
> 
> On Saturday 01 November 2014 11:45:32 Axel Lin wrote:
> > Signed-off-by: Axel Lin 
> 
> Acked-by: Laurent Pinchart 
> 
> Joerg, could you please pick this patch up ?

Applied to arm/renesas, thanks guys.

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu


[PATCH] iommu/ipmmu-vmsa: Return proper error if devm_request_irq fails

2014-11-02 Thread Axel Lin
Signed-off-by: Axel Lin 
---
 drivers/iommu/ipmmu-vmsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
index 7dab5cb..d25fa12 100644
--- a/drivers/iommu/ipmmu-vmsa.c
+++ b/drivers/iommu/ipmmu-vmsa.c
@@ -1184,7 +1184,7 @@ static int ipmmu_probe(struct platform_device *pdev)
   dev_name(&pdev->dev), mmu);
if (ret < 0) {
dev_err(&pdev->dev, "failed to request IRQ %d\n", irq);
-   return irq;
+   return ret;
}
 
ipmmu_device_reset(mmu);
-- 
1.9.1



___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu


Re: [PATCH] iommu/ipmmu-vmsa: Return proper error if devm_request_irq fails

2014-11-01 Thread Laurent Pinchart
Hi Axel,

Thank you for the patch.

On Saturday 01 November 2014 11:45:32 Axel Lin wrote:
> Signed-off-by: Axel Lin 

Acked-by: Laurent Pinchart 

Joerg, could you please pick this patch up ?

> ---
>  drivers/iommu/ipmmu-vmsa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
> index 7dab5cb..d25fa12 100644
> --- a/drivers/iommu/ipmmu-vmsa.c
> +++ b/drivers/iommu/ipmmu-vmsa.c
> @@ -1184,7 +1184,7 @@ static int ipmmu_probe(struct platform_device *pdev)
>  dev_name(&pdev->dev), mmu);
>   if (ret < 0) {
>   dev_err(&pdev->dev, "failed to request IRQ %d\n", irq);
> - return irq;
> + return ret;
>   }
> 
>   ipmmu_device_reset(mmu);

-- 
Regards,

Laurent Pinchart

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu