[jira] [Updated] (ARTEMIS-4301) Resource leakage / ignored configuration

2023-06-02 Thread Daniel Martin (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Martin updated ARTEMIS-4301:
---
Summary: Resource leakage / ignored configuration  (was: Resource leaking / 
ignored configuration)

> Resource leakage / ignored configuration
> 
>
> Key: ARTEMIS-4301
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4301
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Daniel Martin
>Priority: Critical
>
> I have an MQTT client connecting to the ActiveMQ Artemis broker. The client 
> connects with a {{sessionExpiryInterval}} of 60 seconds. Among my 
> {{}} in {{{}broker.xml{}}}, I have 
> {{{}true{}}}. When I restart the 
> MQTT client process, I can see in the broker's logs that the disconnect 
> message is received and, after 60 seconds, the "session state" is removed.
> However, every time I restart the client, the queue count in a few addresses 
> increases by one, and never decreases after that. Inspecting the queues, they 
> all have a message count of 0, and all but the one corresponding to the 
> currently-active client have a consumer count of 0. Furthermore, when 
> inspecting the queue's attributes, they are all marked as "Auto delete: 
> false", seemingly ignoring the setting in {{{}broker.xml{}}}.
> A secondary but still important issue: I had to manually turn queue 
> auto-deletion on, as it was explicitly disabled by default, contrary to what 
> is claimed in the documentation 
> ([https://activemq.apache.org/components/artemis/documentation/latest/address-settings.html]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.

2023-06-02 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=863409&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863409
 ]

ASF GitHub Bot logged work on ARTEMIS-3042:
---

Author: ASF GitHub Bot
Created on: 02/Jun/23 08:57
Start Date: 02/Jun/23 08:57
Worklog Time Spent: 10m 
  Work Description: amarkevich commented on code in PR #4307:
URL: https://github.com/apache/activemq-artemis/pull/4307#discussion_r1214111564


##
artemis-docker/prepare-docker.sh:
##
@@ -181,10 +163,9 @@ if [ ! -d "${ARTEMIS_DIST_DIR}/docker" ]; then
   mkdir "${ARTEMIS_DIST_DIR}/docker"
 fi
 
-cp ./Dockerfile-* "$ARTEMIS_DIST_DIR/docker"
 cp ./docker-run.sh "$ARTEMIS_DIST_DIR/docker"
 
 echo "Docker file support files at:"
 tree "$ARTEMIS_DIST_DIR/docker"

Review Comment:
   'tree' command in L188 will cause build error since not available in build 
stage. I propose to remove it like done in 
https://github.com/apache/activemq-artemis/pull/4453/files#diff-09d0fd7b380274547af0cdaf1cb41c22b3990dfed9848b560e9d9f77b97fb204L188
   or replace with 'ls -l'





Issue Time Tracking
---

Worklog Id: (was: 863409)
Time Spent: 10h 20m  (was: 10h 10m)

> Official Docker Multistage Build as well as an official Docker image.
> -
>
> Key: ARTEMIS-3042
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3042
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: John Behm
>Priority: Minor
>  Labels: docker,, dockerfile,, kubernetes
>  Time Spent: 10h 20m
>  Remaining Estimate: 0h
>
> It would be rather convenient to get people up and running with an easy to 
> build or to setup Docker image that automatically builds the project from 
> source, discards the build container and moves the necessary files over to 
> the final container that can simply be started.
> The current docker image build is not really user firendly or convenient at 
> all.
>  
> https://github.com/apache/activemq-artemis/tree/master/artemis-docker
> The whole setup process of artemis in a containerized environment is  very 
> far from even good.
> The hurdle of using this software is gigantic, as the configuration is so 
> complex, one will not be able to do this within one month without having gone 
> through the whole documentation multiple times.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (ARTEMIS-4302) NPE on JournalTransaction::forget

2023-06-02 Thread Clebert Suconic (Jira)
Clebert Suconic created ARTEMIS-4302:


 Summary: NPE on JournalTransaction::forget
 Key: ARTEMIS-4302
 URL: https://issues.apache.org/jira/browse/ARTEMIS-4302
 Project: ActiveMQ Artemis
  Issue Type: Bug
Affects Versions: 2.28.0
Reporter: Clebert Suconic
Assignee: Clebert Suconic
 Fix For: 2.29.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (ARTEMIS-4298) Journal Retention Duplicated files during replication

2023-06-02 Thread Clebert Suconic (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clebert Suconic closed ARTEMIS-4298.

Resolution: Fixed

> Journal Retention Duplicated files during replication
> -
>
> Key: ARTEMIS-4298
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4298
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.29.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> During a replication the server could move to a different file and create a 
> backup file.
> Before activation we check the .bkp files and move them. Replication is 
> causing a duplicate that could lead to the server not being activated.
> the commit from ARTEMIS-4215 Unveiled this issue. as BackupSyncJournalTest.
> The commit to fix the test from ARTEMIS-4215 itself represents a new issue 
> found.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work started] (ARTEMIS-4302) NPE on JournalTransaction::forget

2023-06-02 Thread Clebert Suconic (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on ARTEMIS-4302 started by Clebert Suconic.

> NPE on JournalTransaction::forget
> -
>
> Key: ARTEMIS-4302
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4302
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.29.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4302) NPE on JournalTransaction::forget

2023-06-02 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4302?focusedWorklogId=863525&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863525
 ]

ASF GitHub Bot logged work on ARTEMIS-4302:
---

Author: ASF GitHub Bot
Created on: 02/Jun/23 13:58
Start Date: 02/Jun/23 13:58
Worklog Time Spent: 10m 
  Work Description: clebertsuconic opened a new pull request, #4499:
URL: https://github.com/apache/activemq-artemis/pull/4499

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 863525)
Remaining Estimate: 0h
Time Spent: 10m

> NPE on JournalTransaction::forget
> -
>
> Key: ARTEMIS-4302
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4302
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.29.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ARTEMIS-4302) NPE on JournalTransaction::forget

2023-06-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728755#comment-17728755
 ] 

ASF subversion and git services commented on ARTEMIS-4302:
--

Commit 7c46b303b12fb140730eef5432d550685d21529a in activemq-artemis's branch 
refs/heads/main from Clebert Suconic
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=7c46b303b1 ]

ARTEMIS-4302 NPE on JournalTransaction::forget


> NPE on JournalTransaction::forget
> -
>
> Key: ARTEMIS-4302
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4302
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.29.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4302) NPE on JournalTransaction::forget

2023-06-02 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4302?focusedWorklogId=863531&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863531
 ]

ASF GitHub Bot logged work on ARTEMIS-4302:
---

Author: ASF GitHub Bot
Created on: 02/Jun/23 14:08
Start Date: 02/Jun/23 14:08
Worklog Time Spent: 10m 
  Work Description: clebertsuconic merged PR #4499:
URL: https://github.com/apache/activemq-artemis/pull/4499




Issue Time Tracking
---

Worklog Id: (was: 863531)
Time Spent: 20m  (was: 10m)

> NPE on JournalTransaction::forget
> -
>
> Key: ARTEMIS-4302
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4302
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.29.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (ARTEMIS-4302) NPE on JournalTransaction::forget

2023-06-02 Thread Clebert Suconic (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clebert Suconic closed ARTEMIS-4302.

Resolution: Fixed

> NPE on JournalTransaction::forget
> -
>
> Key: ARTEMIS-4302
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4302
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.29.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.

2023-06-02 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=863589&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863589
 ]

ASF GitHub Bot logged work on ARTEMIS-3042:
---

Author: ASF GitHub Bot
Created on: 02/Jun/23 20:59
Start Date: 02/Jun/23 20:59
Worklog Time Spent: 10m 
  Work Description: SamTV12345 commented on PR #4307:
URL: 
https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1574308811

   I removed the leftover tree command. I maybe can ditch all these sh files 
and build it with docker-compose. @ViliusS  I'll try that today. Maybe I find a 
clever way to build that with docker-compose




Issue Time Tracking
---

Worklog Id: (was: 863589)
Time Spent: 10.5h  (was: 10h 20m)

> Official Docker Multistage Build as well as an official Docker image.
> -
>
> Key: ARTEMIS-3042
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3042
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: John Behm
>Priority: Minor
>  Labels: docker,, dockerfile,, kubernetes
>  Time Spent: 10.5h
>  Remaining Estimate: 0h
>
> It would be rather convenient to get people up and running with an easy to 
> build or to setup Docker image that automatically builds the project from 
> source, discards the build container and moves the necessary files over to 
> the final container that can simply be started.
> The current docker image build is not really user firendly or convenient at 
> all.
>  
> https://github.com/apache/activemq-artemis/tree/master/artemis-docker
> The whole setup process of artemis in a containerized environment is  very 
> far from even good.
> The hurdle of using this software is gigantic, as the configuration is so 
> complex, one will not be able to do this within one month without having gone 
> through the whole documentation multiple times.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.

2023-06-02 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=863592&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863592
 ]

ASF GitHub Bot logged work on ARTEMIS-3042:
---

Author: ASF GitHub Bot
Created on: 02/Jun/23 22:29
Start Date: 02/Jun/23 22:29
Worklog Time Spent: 10m 
  Work Description: SamTV12345 commented on PR #4307:
URL: 
https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1574387883

   > > The question is how minimal is the produced image? Could you create a 
docker-compose with a few steps that would satisfy the requirement for 
different base images? If we talk about a docker-compose yaml you also need 
suitable tooling in form of a docker compose cli plugin or v1 docker-compose. 
If you could easily switch between base images and select them by a build arg 
that would indeed be interesting. I am unfortunately currently pretty involved 
in other FOSS projects so if you could please go through creating said yaml I 
should be able to adapt the scripts and add the alpine image which was one of 
the reasons this pr exists.
   > 
   > I didn't had much time lately, but I will try to come up with YAML file 
which does the same as this PR this week.
   > 
   > Produced image won't change because this doesn't depend on a tooling. 
Compose plugin is installed by default with Docker Desktop, so it's not a 
problem either.
   
   It's implemented. It is now save to review and hopefully merge. 




Issue Time Tracking
---

Worklog Id: (was: 863592)
Time Spent: 10h 40m  (was: 10.5h)

> Official Docker Multistage Build as well as an official Docker image.
> -
>
> Key: ARTEMIS-3042
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3042
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: John Behm
>Priority: Minor
>  Labels: docker,, dockerfile,, kubernetes
>  Time Spent: 10h 40m
>  Remaining Estimate: 0h
>
> It would be rather convenient to get people up and running with an easy to 
> build or to setup Docker image that automatically builds the project from 
> source, discards the build container and moves the necessary files over to 
> the final container that can simply be started.
> The current docker image build is not really user firendly or convenient at 
> all.
>  
> https://github.com/apache/activemq-artemis/tree/master/artemis-docker
> The whole setup process of artemis in a containerized environment is  very 
> far from even good.
> The hurdle of using this software is gigantic, as the configuration is so 
> complex, one will not be able to do this within one month without having gone 
> through the whole documentation multiple times.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)