[jira] [Work logged] (ARTEMIS-4553) Support partial word matches for address settings
[ https://issues.apache.org/jira/browse/ARTEMIS-4553?focusedWorklogId=898366&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898366 ] ASF GitHub Bot logged work on ARTEMIS-4553: --- Author: ASF GitHub Bot Created on: 08/Jan/24 08:02 Start Date: 08/Jan/24 08:02 Worklog Time Spent: 10m Work Description: brusdev commented on PR #4730: URL: https://github.com/apache/activemq-artemis/pull/4730#issuecomment-1880529377 > The design of the matching is to be hierarchical which is relatively easy to understand and configure with words separated by a delimiter and wildcards that represent one (i.e. * by default) or more (i.e. # by default) words. Partial words also would be hierarchical, I mean `*` would never match a delimiter. > Right now, `*` means **a single word**. If we start accepting "partial words" then what does `*` become? Is it a single word when used alone and then something else when used with a partial word? If the latter, is it any single _character_? Is it 0 or more of any character (e.g. as it might be in a regular expression)? My tentative was to implement the behavior similar to the `*` in the shells: matching zero or more characters but **not the delimiter** to respect the hierarchy. >Also, how do partial words compare to each other in a hierarchy where matches are ordered from general to specific? Would `ab*` be more specific than `a*` when matching `abc`? What about `a*c`? Is that even supported? Where do we draw the line? Good catch, I hadn't thought to this use case but if that would be supported then `a*c` would be more specific of `a*` > Furthermore, what do we do with `#`? Should we support partial matches with it? If so, what does that mean? If not, why not? Theoretically, `*` should be enough for any partial match use cases because `#` matches zero or more words. > The potential configurations start to expand very quickly and will no doubt add complication to the code, the test-suite, and the documentation. This is an important point from the development point of view, are you thinking to any specific cases? > If there's a bug here it's that undocumented behavior is allowed and somewhat functional leading folks to assume it's intentional. I'm not saying we should fix that necessarily, but we should at least consider it so we don't keep letting folks get confused. My tentative was to clarify this gray area without causing issues to users that are already using this **officially unsupported** behavior. Issue Time Tracking --- Worklog Id: (was: 898366) Time Spent: 40m (was: 0.5h) > Support partial word matches for address settings > - > > Key: ARTEMIS-4553 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4553 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Currently, though the documentation specifies that the "*" wildcard matcher > is only intended to match a complete word (delimited string using the > configured delimiter), it appears that it also works for partial word > matches, like " > Could this behavior be supported and documented going forward, as reverting > this behavior would break existing configurations? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4557) expose producer window size in clusterconnection JMX
Andy Taylor created ARTEMIS-4557: Summary: expose producer window size in clusterconnection JMX Key: ARTEMIS-4557 URL: https://issues.apache.org/jira/browse/ARTEMIS-4557 Project: ActiveMQ Artemis Issue Type: Improvement Reporter: Andy Taylor Assignee: Andy Taylor -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4436) Artemis is logging warnings during clean shutdown of server in cluster
[ https://issues.apache.org/jira/browse/ARTEMIS-4436?focusedWorklogId=898447&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898447 ] ASF GitHub Bot logged work on ARTEMIS-4436: --- Author: ASF GitHub Bot Created on: 08/Jan/24 12:44 Start Date: 08/Jan/24 12:44 Worklog Time Spent: 10m Work Description: gemmellr commented on PR #4628: URL: https://github.com/apache/activemq-artemis/pull/4628#issuecomment-1880939190 My last feedback was that I didnt know enough to say whether it was ok or not, and to ask for others to finish reviewing, so at this point I'll defer to those that do. Issue Time Tracking --- Worklog Id: (was: 898447) Time Spent: 2h 50m (was: 2h 40m) > Artemis is logging warnings during clean shutdown of server in cluster > -- > > Key: ARTEMIS-4436 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4436 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Clustering >Affects Versions: 2.30.0 >Reporter: Emmanuel Hugonnet >Priority: Major > Time Spent: 2h 50m > Remaining Estimate: 0h > > If a node from a cluster shutdowns cleanly this shouldn't create WARN > messages in the logs -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4557) expose producer window size in clusterconnection JMX
[ https://issues.apache.org/jira/browse/ARTEMIS-4557?focusedWorklogId=898448&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898448 ] ASF GitHub Bot logged work on ARTEMIS-4557: --- Author: ASF GitHub Bot Created on: 08/Jan/24 12:50 Start Date: 08/Jan/24 12:50 Worklog Time Spent: 10m Work Description: andytaylor opened a new pull request, #4732: URL: https://github.com/apache/activemq-artemis/pull/4732 https://issues.apache.org/jira/browse/ARTEMIS-4557 Issue Time Tracking --- Worklog Id: (was: 898448) Remaining Estimate: 0h Time Spent: 10m > expose producer window size in clusterconnection JMX > > > Key: ARTEMIS-4557 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4557 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-3427) Page size doesn't change when selecting new page size.
[ https://issues.apache.org/jira/browse/ARTEMIS-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804309#comment-17804309 ] Erwin Dondorp commented on ARTEMIS-3427: FYI: The behavior of the page-size-selector is the standard behavior of the PatternFly Pagination component. And btw, with the page reload all other context is also lost: page number, search filter, and (on other pages) sort order. > Page size doesn't change when selecting new page size. > --- > > Key: ARTEMIS-3427 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3427 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Web Console >Affects Versions: 2.17.0, 2.18.0, 2.19.0, 2.20.0, 2.21.0, 2.22.0, 2.23.0, > 2.24.0, 2.25.0, 2.26.0, 2.27.0, 2.28.0, 2.29.0, 2.30.0, 2.31.0, 2.31.1, 2.31.2 >Reporter: Max >Priority: Major > > When there are many messages in the queue and we try to browse them we can > change the page size to show more messages on one page. > How to reproduce: > # make sure there are many messages in the queue so we get multiple pages in > the queue browser > # select new page size in the drop down. (the page doesn't get reloaded). > # Click page navigation buttons to switch to next page. this triggers page > reload with new size. > # Click page navigation button to go back to page 1 to view desired result. > > After refresh the page size is back to default 10, which is way too low for > prod env. > this ping-pong clicking in order to get new page size disturbs in combination > with bug related to select all checkbox (ARTEMIS-3428) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (ARTEMIS-3427) Page size doesn't change when selecting new page size.
[ https://issues.apache.org/jira/browse/ARTEMIS-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804309#comment-17804309 ] Erwin Dondorp edited comment on ARTEMIS-3427 at 1/8/24 3:34 PM: -FYI: The behavior of the page-size-selector is the standard behavior of the PatternFly Pagination component-. And btw, with the page reload all other context is also lost: page number, search filter, and (on other pages) sort order. Ignore that... Artemis is not using the standard patternfly-pagination component, but a copy of that. let's investigate more... was (Author: erwindon): FYI: The behavior of the page-size-selector is the standard behavior of the PatternFly Pagination component. And btw, with the page reload all other context is also lost: page number, search filter, and (on other pages) sort order. > Page size doesn't change when selecting new page size. > --- > > Key: ARTEMIS-3427 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3427 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Web Console >Affects Versions: 2.17.0, 2.18.0, 2.19.0, 2.20.0, 2.21.0, 2.22.0, 2.23.0, > 2.24.0, 2.25.0, 2.26.0, 2.27.0, 2.28.0, 2.29.0, 2.30.0, 2.31.0, 2.31.1, 2.31.2 >Reporter: Max >Priority: Major > > When there are many messages in the queue and we try to browse them we can > change the page size to show more messages on one page. > How to reproduce: > # make sure there are many messages in the queue so we get multiple pages in > the queue browser > # select new page size in the drop down. (the page doesn't get reloaded). > # Click page navigation buttons to switch to next page. this triggers page > reload with new size. > # Click page navigation button to go back to page 1 to view desired result. > > After refresh the page size is back to default 10, which is way too low for > prod env. > this ping-pong clicking in order to get new page size disturbs in combination > with bug related to select all checkbox (ARTEMIS-3428) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4554) Upgrade to latest Java for Docker images
[ https://issues.apache.org/jira/browse/ARTEMIS-4554?focusedWorklogId=898472&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898472 ] ASF GitHub Bot logged work on ARTEMIS-4554: --- Author: ASF GitHub Bot Created on: 08/Jan/24 15:45 Start Date: 08/Jan/24 15:45 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4731: URL: https://github.com/apache/activemq-artemis/pull/4731#discussion_r1444864748 ## artemis-docker/Dockerfile-centos7-19: ## @@ -17,7 +17,7 @@ # ActiveMQ Artemis -FROM eclipse-temurin:11-centos7 +FROM eclipse-temurin:19-jdk-centos7 Review Comment: This change probably doesnt make sense. Java 19 isnt really supported anymore, so similarly the Temurin Java 19 based images [are not either](https://github.com/docker-library/docs/blob/master/eclipse-temurin/README.md#supported-tags-and-respective-dockerfile-links). I'd either leave it at 11 until centos7 itself soon isnt (EOL in June) or use the Java 17 image variant, since both those JDKs/images will already be more up to date in terms of Java security fixes than the Java 19 one ever will be. Issue Time Tracking --- Worklog Id: (was: 898472) Time Spent: 20m (was: 10m) > Upgrade to latest Java for Docker images > - > > Key: ARTEMIS-4554 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4554 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4553) Support partial word matches for address settings
[ https://issues.apache.org/jira/browse/ARTEMIS-4553?focusedWorklogId=898480&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898480 ] ASF GitHub Bot logged work on ARTEMIS-4553: --- Author: ASF GitHub Bot Created on: 08/Jan/24 16:18 Start Date: 08/Jan/24 16:18 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4730: URL: https://github.com/apache/activemq-artemis/pull/4730#discussion_r1444910607 ## artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/HierarchicalObjectRepository.java: ## @@ -477,50 +476,91 @@ default String modify(String input) { /** * Compares to matches to see which one is more specific. +* A match on the any-words delimiter (#) is considered less specific than a match without it, i.e. abc.def.# is less specific than abc.def and abc.def and abc.d* Review Comment: Either repetition or some other issue: "is less specific than abc.def and abc.def" ## docs/user-manual/wildcard-syntax.adoc: ## @@ -31,9 +31,9 @@ But `news.europe.#` would _not_ match: * `news.usa.sport` * `entertainment` -== Matching a Single Word +== Matching a Single or Partial Word -The character `*` means "match a single word". +The character `*` means "match a single or partial word". Review Comment: Its not clear whether the "single-word" configuration item (detailed lower down this documentation) which controls single word matches would also change this partial-word matching. ## docs/user-manual/wildcard-syntax.adoc: ## @@ -44,7 +44,16 @@ But `news.*` would _not_ match: * `news.europe.sport` * `news.usa.sport` -* `news.europe.politics.regional` + +The wildcard `news.eu*` would match: + +* `news.europe` + +But `news.*` would _not_ match: + +* `news.europe.sport` +* `news.usa` +* `news.usa.sport` Review Comment: Regardless of whether we should or shouldnt do partial matching (I've yet to think on that)...this bit of documentation seems incorrect. Guessing the noted address/other wildcard wasnt updated as intended. Issue Time Tracking --- Worklog Id: (was: 898480) Time Spent: 50m (was: 40m) > Support partial word matches for address settings > - > > Key: ARTEMIS-4553 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4553 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Currently, though the documentation specifies that the "*" wildcard matcher > is only intended to match a complete word (delimited string using the > configured delimiter), it appears that it also works for partial word > matches, like " > Could this behavior be supported and documented going forward, as reverting > this behavior would break existing configurations? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4533) Move the examples to their own repository
[ https://issues.apache.org/jira/browse/ARTEMIS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804367#comment-17804367 ] ASF subversion and git services commented on ARTEMIS-4533: -- Commit ff8f45de070c4a19655e56a0077278ca814a0d2b in activemq-artemis's branch refs/heads/main from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=ff8f45de07 ] ARTEMIS-4533: fix up variable name to reflect actual usage > Move the examples to their own repository > - > > Key: ARTEMIS-4533 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4533 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 2.32.0 > > Time Spent: 40m > Remaining Estimate: 0h > > As previously discussed > ([here|https://lists.apache.org/thread/jq783v0ywpgsnty6fw0n2nmxogjh935p]) the > examples will be moved to their own independent repository rather than being > part of the main Artemis repository and build. > The new examples repository will be: > [https://github.com/apache/activemq-artemis-examples/] > The examples repo _main_ branch will target the current Artemis release, with > changes toward/requiring the next release occurring on the _development_ > branch prior to the Artemis release happening. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4553) Support partial word matches for address settings
[ https://issues.apache.org/jira/browse/ARTEMIS-4553?focusedWorklogId=898502&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898502 ] ASF GitHub Bot logged work on ARTEMIS-4553: --- Author: ASF GitHub Bot Created on: 08/Jan/24 17:45 Start Date: 08/Jan/24 17:45 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4730: URL: https://github.com/apache/activemq-artemis/pull/4730#issuecomment-1881552171 > Good catch, I hadn't thought to this use case but if that would be supported then `a*c` would be more specific of `a*` What about multiple `*` characters? For example, would `a*c*` match `abcd` and `ac` and `abc`? > This is an important point from the development point of view, are you thinking to any specific cases? I'm not thinking about any specific case. I'm mainly thinking that the possible combinations that need to be tested will increase substantially with this change, especially if multiple `*` characters are supported. This change will mean that while `*` by itself still means **a single word** when `*` is combined with other characters it will completely change its meaning to **zero or more characters**. I think this will ultimately hurt usability. Issue Time Tracking --- Worklog Id: (was: 898502) Time Spent: 1h (was: 50m) > Support partial word matches for address settings > - > > Key: ARTEMIS-4553 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4553 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Currently, though the documentation specifies that the "*" wildcard matcher > is only intended to match a complete word (delimited string using the > configured delimiter), it appears that it also works for partial word > matches, like " > Could this behavior be supported and documented going forward, as reverting > this behavior would break existing configurations? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3474) Replace use of non-inclusive terms throughout source code, comments and documentation
[ https://issues.apache.org/jira/browse/ARTEMIS-3474?focusedWorklogId=898509&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898509 ] ASF GitHub Bot logged work on ARTEMIS-3474: --- Author: ASF GitHub Bot Created on: 08/Jan/24 17:57 Start Date: 08/Jan/24 17:57 Worklog Time Spent: 10m Work Description: jbertram commented on code in PR #4728: URL: https://github.com/apache/activemq-artemis/pull/4728#discussion_r1445082085 ## artemis-server/src/main/java/org/apache/activemq/artemis/core/config/HAPolicyConfiguration.java: ## @@ -21,14 +21,14 @@ public interface HAPolicyConfiguration extends Serializable { enum TYPE { - LIVE_ONLY("Live Only"), + PRIMARY_ONLY("Primary Only"), REPLICATED("Replicated"), REPLICA("Replica"), - SHARED_STORE_MASTER("Shared Store Master"), - SHARED_STORE_SLAVE("Shared Store Slave"), + SHARED_STORE_PRIMARY("Shared Store Primary"), + SHARED_STORE_BACKUP("Shared Store Backup"), COLOCATED("Colocated"), - PRIMARY("Primary"), - BACKUP("Backup"); + REPLICATION_PRIMARY("Replication Primary w/pluggable quorum voting"), + REPLICATION_BACKUP("Replication Backup w/pluggable quorum voting"); Review Comment: I agree. I'm working on a follow-up PR that deals more with HA naming issues like this in both the documentation and the code. At this point I think this PR should be merged as is. Issue Time Tracking --- Worklog Id: (was: 898509) Time Spent: 1h 50m (was: 1h 40m) > Replace use of non-inclusive terms throughout source code, comments and > documentation > - > > Key: ARTEMIS-3474 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3474 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Andy Taylor >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > this follows up on the ActiveMQ Jira at > https://issues.apache.org/jira/browse/AMQ-7514 but for Artemis . The > conversation is on this Jira and in the forum -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-3474) Replace use of non-inclusive terms throughout source code, comments and documentation
[ https://issues.apache.org/jira/browse/ARTEMIS-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804415#comment-17804415 ] ASF subversion and git services commented on ARTEMIS-3474: -- Commit 85b2f4b126ee4598cae345d3aef575bdb2cbb03e in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=85b2f4b126 ] ARTEMIS-3474 replace non-inclusive terms This commit does the following: - Replaces non-inclusive terms (e.g. master, slave, etc.) in the source, docs, & configuration. - Supports previous configuration elements, but logs when old elements are used. - Provides migration documentation. - Updates XSD with new config elements and simplifies by combining some overlapping complexTypes. - Removes ambiguous "live" language that's used with regard to high availability. - Standardizes use of "primary," "backup," "active," & "passive" as nomenclature to describe both configuration & runtime state for high availability. > Replace use of non-inclusive terms throughout source code, comments and > documentation > - > > Key: ARTEMIS-3474 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3474 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Andy Taylor >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > this follows up on the ActiveMQ Jira at > https://issues.apache.org/jira/browse/AMQ-7514 but for Artemis . The > conversation is on this Jira and in the forum -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3474) Replace use of non-inclusive terms throughout source code, comments and documentation
[ https://issues.apache.org/jira/browse/ARTEMIS-3474?focusedWorklogId=898514&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898514 ] ASF GitHub Bot logged work on ARTEMIS-3474: --- Author: ASF GitHub Bot Created on: 08/Jan/24 18:32 Start Date: 08/Jan/24 18:32 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4728: URL: https://github.com/apache/activemq-artemis/pull/4728 Issue Time Tracking --- Worklog Id: (was: 898514) Time Spent: 2h (was: 1h 50m) > Replace use of non-inclusive terms throughout source code, comments and > documentation > - > > Key: ARTEMIS-3474 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3474 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Andy Taylor >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > this follows up on the ActiveMQ Jira at > https://issues.apache.org/jira/browse/AMQ-7514 but for Artemis . The > conversation is on this Jira and in the forum -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4558) AMQP Mirror ACKS should be idempotent
Clebert Suconic created ARTEMIS-4558: Summary: AMQP Mirror ACKS should be idempotent Key: ARTEMIS-4558 URL: https://issues.apache.org/jira/browse/ARTEMIS-4558 Project: ActiveMQ Artemis Issue Type: Bug Reporter: Clebert Suconic Assignee: Clebert Suconic Fix For: 2.32.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4558) AMQP Mirror ACKS should be idempotent
[ https://issues.apache.org/jira/browse/ARTEMIS-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic updated ARTEMIS-4558: - Description: When I first developed Mirroring, I assumed sending the mirrored ACK on a aferACK and disconnected from any other transactions would be enough, with the caveat you could get a duplicate delivery on the target mirror in case of failures. I got some complains that this is not safe enough from some users, and I'm making this now idempotent. > AMQP Mirror ACKS should be idempotent > - > > Key: ARTEMIS-4558 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4558 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > > When I first developed Mirroring, I assumed sending the mirrored ACK on a > aferACK and disconnected from any other transactions would be enough, with > the caveat you could get a duplicate delivery on the target mirror in case of > failures. > I got some complains that this is not safe enough from some users, and I'm > making this now idempotent. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4558) AMQP Mirror ACKS should be idempotent
[ https://issues.apache.org/jira/browse/ARTEMIS-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic updated ARTEMIS-4558: - Description: When I first developed Mirroring, I assumed sending the mirrored ACK on a aferACK and disconnected from any other transactions would be enough, with the caveat you could get a duplicate delivery on the target mirror in case of failures. I got some complains that this is not safe enough from some users, and I'm making this now idempotent. I took an overal mirroring hardening approach and I'm improving test coverage for this improvement. was: When I first developed Mirroring, I assumed sending the mirrored ACK on a aferACK and disconnected from any other transactions would be enough, with the caveat you could get a duplicate delivery on the target mirror in case of failures. I got some complains that this is not safe enough from some users, and I'm making this now idempotent. > AMQP Mirror ACKS should be idempotent > - > > Key: ARTEMIS-4558 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4558 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > > When I first developed Mirroring, I assumed sending the mirrored ACK on a > aferACK and disconnected from any other transactions would be enough, with > the caveat you could get a duplicate delivery on the target mirror in case of > failures. > I got some complains that this is not safe enough from some users, and I'm > making this now idempotent. > I took an overal mirroring hardening approach and I'm improving test coverage > for this improvement. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4558) AMQP Mirror ACKS should be idempotent
[ https://issues.apache.org/jira/browse/ARTEMIS-4558?focusedWorklogId=898544&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898544 ] ASF GitHub Bot logged work on ARTEMIS-4558: --- Author: ASF GitHub Bot Created on: 08/Jan/24 23:29 Start Date: 08/Jan/24 23:29 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #4734: URL: https://github.com/apache/activemq-artemis/pull/4734 Mirror acks should be performed atomically with the storage of the source ACK. Both the send of the ack and the recording of the ack should be part of the same transaction (in case of transactional). We are also adding support on transactions for an afterWired callback for the proper plug of OperationContext sync. Issue Time Tracking --- Worklog Id: (was: 898544) Remaining Estimate: 0h Time Spent: 10m > AMQP Mirror ACKS should be idempotent > - > > Key: ARTEMIS-4558 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4558 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 10m > Remaining Estimate: 0h > > When I first developed Mirroring, I assumed sending the mirrored ACK on a > aferACK and disconnected from any other transactions would be enough, with > the caveat you could get a duplicate delivery on the target mirror in case of > failures. > I got some complains that this is not safe enough from some users, and I'm > making this now idempotent. > I took an overal mirroring hardening approach and I'm improving test coverage > for this improvement. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4559) Refactor HA docs
Justin Bertram created ARTEMIS-4559: --- Summary: Refactor HA docs Key: ARTEMIS-4559 URL: https://issues.apache.org/jira/browse/ARTEMIS-4559 Project: ActiveMQ Artemis Issue Type: Task Reporter: Justin Bertram Assignee: Justin Bertram Over the years the HA docs have gotten a bit confusing. They need to be refreshed and clarified in light of features, etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4558) AMQP Mirror ACKS should be idempotent
[ https://issues.apache.org/jira/browse/ARTEMIS-4558?focusedWorklogId=898552&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898552 ] ASF GitHub Bot logged work on ARTEMIS-4558: --- Author: ASF GitHub Bot Created on: 09/Jan/24 01:49 Start Date: 09/Jan/24 01:49 Worklog Time Spent: 10m Work Description: clebertsuconic commented on code in PR #4734: URL: https://github.com/apache/activemq-artemis/pull/4734#discussion_r1445545266 ## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java: ## @@ -498,7 +498,7 @@ private Queue installMirrorController(AMQPMirrorBrokerConnectionElement replicaC Queue mirrorControlQueue = server.locateQueue(getMirrorSNF(replicaConfig)); if (mirrorControlQueue == null) { - mirrorControlQueue = server.createQueue(new QueueConfiguration(getMirrorSNF(replicaConfig)).setAddress(getMirrorSNF(replicaConfig)).setRoutingType(RoutingType.ANYCAST).setDurable(replicaConfig.isDurable()).setInternal(true), true); + mirrorControlQueue = server.createQueue(new QueueConfiguration(getMirrorSNF(replicaConfig)).setAddress(getMirrorSNF(replicaConfig)).setRoutingType(RoutingType.ANYCAST).setDurable(replicaConfig.isDurable()).setInternal(false), true); Review Comment: I think it's better to remove the internal clause on this queue. as it allows management. Issue Time Tracking --- Worklog Id: (was: 898552) Time Spent: 20m (was: 10m) > AMQP Mirror ACKS should be idempotent > - > > Key: ARTEMIS-4558 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4558 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 20m > Remaining Estimate: 0h > > When I first developed Mirroring, I assumed sending the mirrored ACK on a > aferACK and disconnected from any other transactions would be enough, with > the caveat you could get a duplicate delivery on the target mirror in case of > failures. > I got some complains that this is not safe enough from some users, and I'm > making this now idempotent. > I took an overal mirroring hardening approach and I'm improving test coverage > for this improvement. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4560) Wrong default on BridgeConfiguration options when using broker properties
Clebert Suconic created ARTEMIS-4560: Summary: Wrong default on BridgeConfiguration options when using broker properties Key: ARTEMIS-4560 URL: https://issues.apache.org/jira/browse/ARTEMIS-4560 Project: ActiveMQ Artemis Issue Type: Bug Affects Versions: 2.31.2 Reporter: Clebert Suconic Assignee: Clebert Suconic Fix For: 2.32.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4559) Refactor HA docs
[ https://issues.apache.org/jira/browse/ARTEMIS-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-4559: Description: Over the years the HA docs have gotten a bit confusing. They need to be refreshed and clarified in light of new features, etc. (was: Over the years the HA docs have gotten a bit confusing. They need to be refreshed and clarified in light of features, etc.) > Refactor HA docs > > > Key: ARTEMIS-4559 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4559 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > > Over the years the HA docs have gotten a bit confusing. They need to be > refreshed and clarified in light of new features, etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4559) Refactor HA docs
[ https://issues.apache.org/jira/browse/ARTEMIS-4559?focusedWorklogId=898575&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898575 ] ASF GitHub Bot logged work on ARTEMIS-4559: --- Author: ASF GitHub Bot Created on: 09/Jan/24 05:22 Start Date: 09/Jan/24 05:22 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #4735: URL: https://github.com/apache/activemq-artemis/pull/4735 This commit does the following: - Updates HA docs including the chapter on network isolation (i.e. split brain). The network isolation chapter is now more about high-level explanation and the HA doc now has all the configuration parameters. - Changes references to "pluggable quorum voting" to "pluggable lock manager." The pluggable functionality really isn't about voting. Conceptually is much more like the functionality you'd get from a distributed lock so this naming is more clear. Both the docs and the code have been changed, but all changes are backwards compatible. - Reorganize lock manager modules as sub-modules. The API and RI modules are renamed, but that should be OK based on the "experimental" tag that's been on this feature up to this point. - Remove the "experimental" tag from the lock manager. Issue Time Tracking --- Worklog Id: (was: 898575) Remaining Estimate: 0h Time Spent: 10m > Refactor HA docs > > > Key: ARTEMIS-4559 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4559 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Over the years the HA docs have gotten a bit confusing. They need to be > refreshed and clarified in light of new features, etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)