[jira] [Commented] (ARTEMIS-2355) Message does not redistribute in cluster when using AMQP and Multicast
[ https://issues.apache.org/jira/browse/ARTEMIS-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851371#comment-16851371 ] ASF subversion and git services commented on ARTEMIS-2355: -- Commit 4fa2e75cdc5572e2e98d311fdcde0c2010726780 in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=4fa2e75 ] ARTEMIS-2361 Bridge should make a copy of messages and some improvements into ARTEMIS-2355 > Message does not redistribute in cluster when using AMQP and Multicast > -- > > Key: ARTEMIS-2355 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2355 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Luis Miguel De Bello >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > We are migrating from Artemis 2.6.3 to Artemis 2.7.0 and we hit and issue > regarding clustering and message redistribution. > Scenario: > Broker 0: > Create a Bridge to Broker 1 > Broker 1: > Create a Cluster with Broker 2 > Broker 2: > Create a Cluster with Broker 1 > > Consumer in Broker 2 in Multicast Address. > Producer Send Anycast Message to Broker 0, the message is Diver in Broker 0 > to Address for the Bridge. Message Arrive to Address in Broker 1, it is > Divert to Multicast Address + Setting Routing Type Multicast. > > It works in 2.6.3 and it does not work in 2.7.0. I am almost sure the issue > is while doing the redistribution and checking the isMatchRoutingType because > in 2.6.3 is ok but in 2.7.0 they do not match. If someone can point me out > some debugging class to see the message sent from Broker 1 to Broker for > redistribution I can try to debug it. > I will create a branch with the test > > Test Class: AmqpBridgeClusterRedistributionTest > Repo: [https://github.com/ldebello/activemq-artemis/tree/ARTEMIS-2355] > > After some debugging + going back in commits the issue start happening after > this commit > > [https://github.com/apache/activemq-artemis/commit/6a64f4e7a270f83c735200d6ef29561ef4927535#diff-4a5cefc3ba360bce9985ad42fc0c2231R698] > > I am assuming the redistribution is not "encoding" or updating the message to > multicast because the buffer is already valid and in previous version > reencode all the time so the message was ok. > > Removing the line fix this issue, anyway I think that is for performance so I > will try to track were some validation should be added to reencode the > message again, if someone has some idea where start looking that would be > great. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2355) Message does not redistribute in cluster when using AMQP and Multicast
[ https://issues.apache.org/jira/browse/ARTEMIS-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851369#comment-16851369 ] ASF subversion and git services commented on ARTEMIS-2355: -- Commit 1ccb688eec47b30d0524555dc6822b646726 in activemq-artemis's branch refs/heads/master from Luis De Bello [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=1ccb688 ] ARTEMIS-2355: Marking message as changed after setting routing type, because it is set after divert > Message does not redistribute in cluster when using AMQP and Multicast > -- > > Key: ARTEMIS-2355 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2355 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Luis Miguel De Bello >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > We are migrating from Artemis 2.6.3 to Artemis 2.7.0 and we hit and issue > regarding clustering and message redistribution. > Scenario: > Broker 0: > Create a Bridge to Broker 1 > Broker 1: > Create a Cluster with Broker 2 > Broker 2: > Create a Cluster with Broker 1 > > Consumer in Broker 2 in Multicast Address. > Producer Send Anycast Message to Broker 0, the message is Diver in Broker 0 > to Address for the Bridge. Message Arrive to Address in Broker 1, it is > Divert to Multicast Address + Setting Routing Type Multicast. > > It works in 2.6.3 and it does not work in 2.7.0. I am almost sure the issue > is while doing the redistribution and checking the isMatchRoutingType because > in 2.6.3 is ok but in 2.7.0 they do not match. If someone can point me out > some debugging class to see the message sent from Broker 1 to Broker for > redistribution I can try to debug it. > I will create a branch with the test > > Test Class: AmqpBridgeClusterRedistributionTest > Repo: [https://github.com/ldebello/activemq-artemis/tree/ARTEMIS-2355] > > After some debugging + going back in commits the issue start happening after > this commit > > [https://github.com/apache/activemq-artemis/commit/6a64f4e7a270f83c735200d6ef29561ef4927535#diff-4a5cefc3ba360bce9985ad42fc0c2231R698] > > I am assuming the redistribution is not "encoding" or updating the message to > multicast because the buffer is already valid and in previous version > reencode all the time so the message was ok. > > Removing the line fix this issue, anyway I think that is for performance so I > will try to track were some validation should be added to reencode the > message again, if someone has some idea where start looking that would be > great. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2355) Message does not redistribute in cluster when using AMQP and Multicast
[ https://issues.apache.org/jira/browse/ARTEMIS-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850071#comment-16850071 ] Luis Miguel De Bello commented on ARTEMIS-2355: --- I have just send a PR for this [https://github.com/apache/activemq-artemis/pull/2682] The issue is because the divert after applying the transformer changes the routing type but the message is not reencode, I have just added the message change flag in the set routing type an alternative is set the flag from outside and only mark as change if the routing was different. > Message does not redistribute in cluster when using AMQP and Multicast > -- > > Key: ARTEMIS-2355 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2355 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Luis Miguel De Bello >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > We are migrating from Artemis 2.6.3 to Artemis 2.7.0 and we hit and issue > regarding clustering and message redistribution. > Scenario: > Broker 0: > Create a Bridge to Broker 1 > Broker 1: > Create a Cluster with Broker 2 > Broker 2: > Create a Cluster with Broker 1 > > Consumer in Broker 2 in Multicast Address. > Producer Send Anycast Message to Broker 0, the message is Diver in Broker 0 > to Address for the Bridge. Message Arrive to Address in Broker 1, it is > Divert to Multicast Address + Setting Routing Type Multicast. > > It works in 2.6.3 and it does not work in 2.7.0. I am almost sure the issue > is while doing the redistribution and checking the isMatchRoutingType because > in 2.6.3 is ok but in 2.7.0 they do not match. If someone can point me out > some debugging class to see the message sent from Broker 1 to Broker for > redistribution I can try to debug it. > I will create a branch with the test > > Test Class: AmqpBridgeClusterRedistributionTest > Repo: [https://github.com/ldebello/activemq-artemis/tree/ARTEMIS-2355] > > After some debugging + going back in commits the issue start happening after > this commit > > [https://github.com/apache/activemq-artemis/commit/6a64f4e7a270f83c735200d6ef29561ef4927535#diff-4a5cefc3ba360bce9985ad42fc0c2231R698] > > I am assuming the redistribution is not "encoding" or updating the message to > multicast because the buffer is already valid and in previous version > reencode all the time so the message was ok. > > Removing the line fix this issue, anyway I think that is for performance so I > will try to track were some validation should be added to reencode the > message again, if someone has some idea where start looking that would be > great. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
