[jira] [Commented] (AVRO-3897) Disallow invalid namespace in fully qualified name for Rust SDK
[ https://issues.apache.org/jira/browse/AVRO-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781733#comment-17781733 ] Martin Tzvetanov Grigorov commented on AVRO-3897: - Please cite the specification where it says that the examples above are invalid. > Disallow invalid namespace in fully qualified name for Rust SDK > --- > > Key: AVRO-3897 > URL: https://issues.apache.org/jira/browse/AVRO-3897 > Project: Apache Avro > Issue Type: Bug > Components: rust >Reporter: Kousuke Saruta >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Currently, the Rust SDK allows the following fully qualified names with > Name::new. > {code} > Name::new("ns.0.record1") > Name::new("ns..record1") > {code} > But they should be disallowed according to the specification. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AVRO-3897) Disallow invalid namespace in fully qualified name for Rust SDK
[ https://issues.apache.org/jira/browse/AVRO-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782085#comment-17782085 ] ASF subversion and git services commented on AVRO-3897: --- Commit e8f48a98bcd3b2c3772a604847ce57eb9903a72c in avro's branch refs/heads/main from Kousuke Saruta [ https://gitbox.apache.org/repos/asf?p=avro.git;h=e8f48a98b ] AVRO-3897: [Rust] Disallow invalid namespace in fully qualified name for Rust SDK (#2570) * AVRO-3897: [Rust] Disallow invalid namespace in fully qualified name for Rust SDK * AVRO-3897: [Rust] Cleanup the test code Signed-off-by: Martin Tzvetanov Grigorov * AVRO-3897: [Rust] Add a test case showing that name[space]s could be only underscores Signed-off-by: Martin Tzvetanov Grigorov - Signed-off-by: Martin Tzvetanov Grigorov Co-authored-by: Martin Tzvetanov Grigorov > Disallow invalid namespace in fully qualified name for Rust SDK > --- > > Key: AVRO-3897 > URL: https://issues.apache.org/jira/browse/AVRO-3897 > Project: Apache Avro > Issue Type: Bug > Components: rust >Reporter: Kousuke Saruta >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Currently, the Rust SDK allows the following fully qualified names with > Name::new. > {code} > Name::new("ns.0.record1") > Name::new("ns..record1") > {code} > But they should be disallowed according to the specification. > https://avro.apache.org/docs/1.11.1/specification/#names > {code} > The name portion of the fullname of named types, record field names, and enum > symbols must: > start with [A-Za-z_] > subsequently contain only [A-Za-z0-9_] > {code} > {code} > The null namespace may not be used in a dot-separated sequence of names. So > the grammar for a namespace is: >| [()*] > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AVRO-3897) Disallow invalid namespace in fully qualified name for Rust SDK
[ https://issues.apache.org/jira/browse/AVRO-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782086#comment-17782086 ] ASF subversion and git services commented on AVRO-3897: --- Commit f9c5a2fb946e1bc867e60fbd9152d78dbfd235e4 in avro's branch refs/heads/branch-1.11 from Kousuke Saruta [ https://gitbox.apache.org/repos/asf?p=avro.git;h=f9c5a2fb9 ] AVRO-3897: [Rust] Disallow invalid namespace in fully qualified name for Rust SDK (#2570) * AVRO-3897: [Rust] Disallow invalid namespace in fully qualified name for Rust SDK * AVRO-3897: [Rust] Cleanup the test code Signed-off-by: Martin Tzvetanov Grigorov * AVRO-3897: [Rust] Add a test case showing that name[space]s could be only underscores Signed-off-by: Martin Tzvetanov Grigorov - Signed-off-by: Martin Tzvetanov Grigorov Co-authored-by: Martin Tzvetanov Grigorov (cherry picked from commit e8f48a98bcd3b2c3772a604847ce57eb9903a72c) > Disallow invalid namespace in fully qualified name for Rust SDK > --- > > Key: AVRO-3897 > URL: https://issues.apache.org/jira/browse/AVRO-3897 > Project: Apache Avro > Issue Type: Bug > Components: rust >Reporter: Kousuke Saruta >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Currently, the Rust SDK allows the following fully qualified names with > Name::new. > {code} > Name::new("ns.0.record1") > Name::new("ns..record1") > {code} > But they should be disallowed according to the specification. > https://avro.apache.org/docs/1.11.1/specification/#names > {code} > The name portion of the fullname of named types, record field names, and enum > symbols must: > start with [A-Za-z_] > subsequently contain only [A-Za-z0-9_] > {code} > {code} > The null namespace may not be used in a dot-separated sequence of names. So > the grammar for a namespace is: >| [()*] > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)