[jira] [Updated] (CALCITE-6376) Filtering CTE of at least 6 columns with QUALIFY operation results in exception
[ https://issues.apache.org/jira/browse/CALCITE-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-6376: Labels: pull-request-available (was: ) > Filtering CTE of at least 6 columns with QUALIFY operation results in > exception > --- > > Key: CALCITE-6376 > URL: https://issues.apache.org/jira/browse/CALCITE-6376 > Project: Calcite > Issue Type: Bug >Affects Versions: 1.36.0 >Reporter: Austin Richardson >Assignee: ShenDa >Priority: Major > Labels: pull-request-available > > Example query: > > {code:java} > WITH MyCTE AS ( > SELECT > column1, > column2, > column3, > column4, > column5, > column6 > FROM ( > VALUES > ('value1', 10, 5.0, 'data1', 'info1', 'test1'), > ('value2', 20, 4.0, 'data2', 'info2', 'test2'), > ('value3', 30, 3.0, 'data3', 'info3', 'test3'), > ('value4', 40, 2.0, 'data4', 'info4', 'test4'), > ('value5', 50, 1.0, 'data5', 'info5', 'test5') > ) AS t(column1, column2, column3, column4, column5, column6) > ) > SELECT * > FROM MyCTE > QUALIFY RANK() OVER (ORDER BY column3) = 1{code} > > And exception snippet: > > {code:java} > Caused by: java.lang.ClassCastException: class > org.apache.calcite.rex.RexInputRef cannot be cast to class > java.lang.Comparable (org.apache.calcite.rex.RexInputRef is in unnamed module > of loader org.springframework.boot.loader.LaunchedURLClassLoader @257f30f7; > java.lang.Comparable is in module java.base of loader 'bootstrap') > at > org.apache.calcite.runtime.FlatLists$ComparableListImpl.get(FlatLists.java:1319) > at > org.apache.calcite.runtime.FlatLists$ComparableListImpl.get(FlatLists.java:1309) > at > java.base/java.util.AbstractList$Itr.next(AbstractList.java:373){code} > > Either removing one of the columns or the QUALIFY filter results in a > successful query. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (CALCITE-6376) Filtering CTE of at least 6 columns with QUALIFY operation results in exception
[ https://issues.apache.org/jira/browse/CALCITE-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ShenDa reassigned CALCITE-6376: --- Assignee: ShenDa > Filtering CTE of at least 6 columns with QUALIFY operation results in > exception > --- > > Key: CALCITE-6376 > URL: https://issues.apache.org/jira/browse/CALCITE-6376 > Project: Calcite > Issue Type: Bug >Affects Versions: 1.36.0 >Reporter: Austin Richardson >Assignee: ShenDa >Priority: Major > > Example query: > > {code:java} > WITH MyCTE AS ( > SELECT > column1, > column2, > column3, > column4, > column5, > column6 > FROM ( > VALUES > ('value1', 10, 5.0, 'data1', 'info1', 'test1'), > ('value2', 20, 4.0, 'data2', 'info2', 'test2'), > ('value3', 30, 3.0, 'data3', 'info3', 'test3'), > ('value4', 40, 2.0, 'data4', 'info4', 'test4'), > ('value5', 50, 1.0, 'data5', 'info5', 'test5') > ) AS t(column1, column2, column3, column4, column5, column6) > ) > SELECT * > FROM MyCTE > QUALIFY RANK() OVER (ORDER BY column3) = 1{code} > > And exception snippet: > > {code:java} > Caused by: java.lang.ClassCastException: class > org.apache.calcite.rex.RexInputRef cannot be cast to class > java.lang.Comparable (org.apache.calcite.rex.RexInputRef is in unnamed module > of loader org.springframework.boot.loader.LaunchedURLClassLoader @257f30f7; > java.lang.Comparable is in module java.base of loader 'bootstrap') > at > org.apache.calcite.runtime.FlatLists$ComparableListImpl.get(FlatLists.java:1319) > at > org.apache.calcite.runtime.FlatLists$ComparableListImpl.get(FlatLists.java:1309) > at > java.base/java.util.AbstractList$Itr.next(AbstractList.java:373){code} > > Either removing one of the columns or the QUALIFY filter results in a > successful query. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (CALCITE-6369) Expanding "star" gives ArrayIndexOutOfBoundsException with redundant columns and USING
[ https://issues.apache.org/jira/browse/CALCITE-6369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842179#comment-17842179 ] James Duong edited comment on CALCITE-6369 at 4/29/24 10:41 PM: I've reproduced this problem. It's not clear why there's an ArrayIndexOutOfBoundsException while doing the permute call. What happens is that the select expansion is converting the r_regionkey column reference to a COALESCE(r0.r_regionky, r1.r_regionkey) and gives it the alias EMPNO – I'm guessing this is because NULL won't be matched when the column is joined. If I forcibly change permute to get past the AIOB (stopping permutation at the faulty index), I get an ambiguous column reference error, which seems like a reasonable result for this query. was (Author: jduong): I've reproduced this problem. It's not clear why there's an ArrayIndexOutOfBoundsException while doing the permute call. What happens is that the select expansion is converting the r_regionkey column reference to a COALESCE(r0.r_regionky, r1.r_regionkey) – I'm guessing this is because NULL won't be matched when the column is joined. If I forcibly change permute to get past the AIOB (stopping permutation at the faulty index), I get an ambiguous column reference error, which seems like a reasonable result for this query. > Expanding "star" gives ArrayIndexOutOfBoundsException with redundant columns > and USING > -- > > Key: CALCITE-6369 > URL: https://issues.apache.org/jira/browse/CALCITE-6369 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.36.0 >Reporter: Claude Brisson >Assignee: James Duong >Priority: Major > > The query > {code} > select r_regionkey, * from region r0 join region r1 using (r_regionkey) > {code} > produces > {code} > java.lang.ArrayIndexOutOfBoundsException: Index 14 out of bounds for length 14 > at org.apache.calcite.runtime.PairLists$ArrayImmutablePairList.get > (PairLists.java:573) > at org.apache.calcite.runtime.PairLists$ArrayImmutablePairList.get > (PairLists.java:550) > at org.apache.calcite.sql.validate.SqlValidatorImpl$Permute.permute > (SqlValidatorImpl.java:7443) > at org.apache.calcite.sql.validate.SqlValidatorImpl.expandStar > (SqlValidatorImpl.java:697) > at org.apache.calcite.sql.validate.SqlValidatorImpl.expandSelectItem > (SqlValidatorImpl.java:453) > at org.apache.calcite.sql.validate.SqlValidatorImpl.validateSelectList > (SqlValidatorImpl.java:4658) > at org.apache.calcite.sql.validate.SqlValidatorImpl.validateSelect > (SqlValidatorImpl.java:3840) > at org.apache.calcite.sql.validate.SelectNamespace.validateImpl > (SelectNamespace.java:61) > at org.apache.calcite.sql.validate.AbstractNamespace.validate > (AbstractNamespace.java:88) > at org.apache.calcite.sql.validate.SqlValidatorImpl.validateNamespace > (SqlValidatorImpl.java:1154) > at org.apache.calcite.sql.validate.SqlValidatorImpl.validateQuery > (SqlValidatorImpl.java:1125) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-6369) Expanding "star" gives ArrayIndexOutOfBoundsException with redundant columns and USING
[ https://issues.apache.org/jira/browse/CALCITE-6369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842179#comment-17842179 ] James Duong commented on CALCITE-6369: -- I've reproduced this problem. It's not clear why there's an ArrayIndexOutOfBoundsException while doing the permute call. What happens is that the select expansion is converting the r_regionkey column reference to a COALESCE(r0.r_regionky, r1.r_regionkey) – I'm guessing this is because NULL won't be matched when the column is joined. If I forcibly change permute to get past the AIOB (stopping permutation at the faulty index), I get an ambiguous column reference error, which seems like a reasonable result for this query. > Expanding "star" gives ArrayIndexOutOfBoundsException with redundant columns > and USING > -- > > Key: CALCITE-6369 > URL: https://issues.apache.org/jira/browse/CALCITE-6369 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.36.0 >Reporter: Claude Brisson >Assignee: James Duong >Priority: Major > > The query > {code} > select r_regionkey, * from region r0 join region r1 using (r_regionkey) > {code} > produces > {code} > java.lang.ArrayIndexOutOfBoundsException: Index 14 out of bounds for length 14 > at org.apache.calcite.runtime.PairLists$ArrayImmutablePairList.get > (PairLists.java:573) > at org.apache.calcite.runtime.PairLists$ArrayImmutablePairList.get > (PairLists.java:550) > at org.apache.calcite.sql.validate.SqlValidatorImpl$Permute.permute > (SqlValidatorImpl.java:7443) > at org.apache.calcite.sql.validate.SqlValidatorImpl.expandStar > (SqlValidatorImpl.java:697) > at org.apache.calcite.sql.validate.SqlValidatorImpl.expandSelectItem > (SqlValidatorImpl.java:453) > at org.apache.calcite.sql.validate.SqlValidatorImpl.validateSelectList > (SqlValidatorImpl.java:4658) > at org.apache.calcite.sql.validate.SqlValidatorImpl.validateSelect > (SqlValidatorImpl.java:3840) > at org.apache.calcite.sql.validate.SelectNamespace.validateImpl > (SelectNamespace.java:61) > at org.apache.calcite.sql.validate.AbstractNamespace.validate > (AbstractNamespace.java:88) > at org.apache.calcite.sql.validate.SqlValidatorImpl.validateNamespace > (SqlValidatorImpl.java:1154) > at org.apache.calcite.sql.validate.SqlValidatorImpl.validateQuery > (SqlValidatorImpl.java:1125) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6389) RexBuilder.removeCastFromLiteral does not preserve semantics for some types of literals
[ https://issues.apache.org/jira/browse/CALCITE-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mihai Budiu updated CALCITE-6389: - Summary: RexBuilder.removeCastFromLiteral does not preserve semantics for some types of literals (was: RexBuilder.removeCastFromLiteral does not preserve semantics for decimal literals) > RexBuilder.removeCastFromLiteral does not preserve semantics for some types > of literals > --- > > Key: CALCITE-6389 > URL: https://issues.apache.org/jira/browse/CALCITE-6389 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.36.0 >Reporter: Mihai Budiu >Priority: Minor > > This is a bug which I keep fixing as part of several pull requests (not yet > merged), so I have decided to make it into a separate issue. > The code in removeCastFromLiteral is supposed to remove casts which are > useless. > However, the code is too aggressive for decimal literals. In particular, this > fragment: > {code:java} > if (toType.getSqlTypeName() == SqlTypeName.DECIMAL) { > final BigDecimal decimalValue = (BigDecimal) value; > return SqlTypeUtil.isValidDecimalValue(decimalValue, toType); > } > {code} > There are at least two bugs here: > - this code removes casts from literals even if they represent types such as > interval > - this code does not check properly that the literal can be represented by > the type specified by the cast. In particular, the function > SqlTypeUtil.isValidDecimalValue does not correctly consider the scale of the > resulting type, and may return 'true' even when a number requires rescaling. > Removing casts in such a case changes the literal's value. I have submitted a > fix for this bug as part of [CALCITE-6322], but that PR hasn't been merged > yet. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6392) Support all PostgreSQL 14 date/time patterns for to_date/to_timestamp
Norman Jordan created CALCITE-6392: -- Summary: Support all PostgreSQL 14 date/time patterns for to_date/to_timestamp Key: CALCITE-6392 URL: https://issues.apache.org/jira/browse/CALCITE-6392 Project: Calcite Issue Type: Sub-task Reporter: Norman Jordan Assignee: Norman Jordan Many of the date/time format patterns supported by PostgreSQL 14 are not supported in Calcite. * HH * US * * S * AM * A.M. * am * a.m. * PM * P.M. * pm * p.m. * Y,YYY * YYY * Y * IYYY * IYY * IY * I * BC * B.C. * bc * b.c. * AD * A.D. * ad * a.d. * MONTH * month * MON * mon * DAY * day * Dy * dy * IDDD * ID * TZH * TZM * OF There are also template pattern modifiers that need to be supported. * FM (prefix) * TH (suffix) * th (suffix) * FX (prefix) * TM (prefix) Some format patterns in Calcite behave differently from PostgreSQL 14. * FF1 * FF2 * FF4 * FF5 * FF6 Also verify that the other existing format strings produce results that match PostgreSQL 14. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6358) Support all PostgreSQL 14 date/time patterns for to_char
[ https://issues.apache.org/jira/browse/CALCITE-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Jordan updated CALCITE-6358: --- Summary: Support all PostgreSQL 14 date/time patterns for to_char (was: Support all PostgreSQL 14 date/time patterns) > Support all PostgreSQL 14 date/time patterns for to_char > > > Key: CALCITE-6358 > URL: https://issues.apache.org/jira/browse/CALCITE-6358 > Project: Calcite > Issue Type: Sub-task >Reporter: Norman Jordan >Assignee: Norman Jordan >Priority: Minor > Labels: pull-request-available > > Many of the date/time format patterns supported by PostgreSQL 14 are not > supported in Calcite. > * HH > * US > * > * S > * AM > * A.M. > * am > * a.m. > * PM > * P.M. > * pm > * p.m. > * Y,YYY > * YYY > * Y > * IYYY > * IYY > * IY > * I > * BC > * B.C. > * bc > * b.c. > * AD > * A.D. > * ad > * a.d. > * MONTH > * month > * MON > * mon > * DAY > * day > * Dy > * dy > * IDDD > * ID > * TZH > * TZM > * OF > There are also template pattern modifiers that need to be supported. > * FM (prefix) > * TH (suffix) > * th (suffix) > * FX (prefix) > * TM (prefix) > Some format patterns in Calcite behave differently from PostgreSQL 14. > * FF1 > * FF2 > * FF4 > * FF5 > * FF6 > Also verify that the other existing format strings produce results that match > PostgreSQL 14. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (CALCITE-6358) Support all PostgreSQL 14 date/time patterns
[ https://issues.apache.org/jira/browse/CALCITE-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Jordan reassigned CALCITE-6358: -- Assignee: Norman Jordan > Support all PostgreSQL 14 date/time patterns > > > Key: CALCITE-6358 > URL: https://issues.apache.org/jira/browse/CALCITE-6358 > Project: Calcite > Issue Type: Sub-task >Reporter: Norman Jordan >Assignee: Norman Jordan >Priority: Minor > Labels: pull-request-available > > Many of the date/time format patterns supported by PostgreSQL 14 are not > supported in Calcite. > * HH > * US > * > * S > * AM > * A.M. > * am > * a.m. > * PM > * P.M. > * pm > * p.m. > * Y,YYY > * YYY > * Y > * IYYY > * IYY > * IY > * I > * BC > * B.C. > * bc > * b.c. > * AD > * A.D. > * ad > * a.d. > * MONTH > * month > * MON > * mon > * DAY > * day > * Dy > * dy > * IDDD > * ID > * TZH > * TZM > * OF > There are also template pattern modifiers that need to be supported. > * FM (prefix) > * TH (suffix) > * th (suffix) > * FX (prefix) > * TM (prefix) > Some format patterns in Calcite behave differently from PostgreSQL 14. > * FF1 > * FF2 > * FF4 > * FF5 > * FF6 > Also verify that the other existing format strings produce results that match > PostgreSQL 14. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6391) Apply mapping to RelCompositeTrait does not apply it to wrapped traits
James Duong created CALCITE-6391: Summary: Apply mapping to RelCompositeTrait does not apply it to wrapped traits Key: CALCITE-6391 URL: https://issues.apache.org/jira/browse/CALCITE-6391 Project: Calcite Issue Type: Bug Reporter: James Duong RelCompositeTrait wraps multiple traits. However it does not override RelTrait#apply(Mapping.TargetMapping). It uses the default implementation which makes the mapping have no effect. The correct behavior would be to propagate the apply() call to wrapped traits. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6390) ArrowAdapterTest fails on Windows
[ https://issues.apache.org/jira/browse/CALCITE-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved CALCITE-6390. -- Fix Version/s: 1.37.0 Resolution: Fixed > ArrowAdapterTest fails on Windows > - > > Key: CALCITE-6390 > URL: https://issues.apache.org/jira/browse/CALCITE-6390 > Project: Calcite > Issue Type: Sub-task >Reporter: Sergey Nuyanzin >Assignee: Stamatis Zampetakis >Priority: Major > Labels: pull-request-available > Fix For: 1.37.0 > > > -That's seems somehow highlights the difference between Windows Server and > non Server- > -we have tests against Windows Server on gha (windows-latest) and they are > green- > -At the same time local tests on Windows 11 show that {{ArrowAdapterTest}} > fails like- > Based on deeper analysis Arrow module was never tested on Windows since for > Windows conf on gha it is {{--exclude-task :arrow:build}} which makes it > skipping the tests for this module > https://github.com/apache/calcite/blob/aa8d81bf1ff39e3632aeb856fc4cc247ce9727e5/.github/workflows/main.yml#L110C60-L110C88 > Any attempt to test it leads to > {noformat} > FAILURE 0.0sec, org.apache.calcite.adapter.arrow.ArrowAdapterTest > > executionError > java.io.IOException: Failed to delete temp directory > D:\MyConfiguration\cancai.cai\AppData\Local\Temp\junit5105379620525559011. > The following paths could not be deleted (see suppressed exceptions for > details): , arrow > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:350) > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:251) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.lambda$closeAllStoredCloseableValues$3(ExtensionValuesStore.java:68) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) > at > java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) > at java.util.ArrayList.forEach(ArrayList.java:1259) > at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:390) > at java.util.stream.Sink$ChainedReference.end(Sink.java:258) > at > java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483) > at > java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) > at > java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) > at > java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) > at > java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.closeAllStoredCloseableValues(ExtensionValuesStore.java:68) > at > org.junit.jupiter.engine.descriptor.AbstractExtensionContext.close(AbstractExtensionContext.java:80) > at > org.junit.jupiter.engine.execution.JupiterEngineExecutionContext.close(JupiterEngineExecutionContext.java:53) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:222) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:57) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$cleanUp$10(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.cleanUp(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:98) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:129) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) > at > org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137) > at > org.junit.plat
[jira] [Commented] (CALCITE-6390) ArrowAdapterTest fails on Windows
[ https://issues.apache.org/jira/browse/CALCITE-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841991#comment-17841991 ] Sergey Nuyanzin commented on CALCITE-6390: -- Merged as [1506857f404037b63dfd8a11880393b767bd1544|https://github.com/apache/calcite/commit/1506857f404037b63dfd8a11880393b767bd1544] Thanks [~zabetak] for working on it Thanks [~rubenql] and [~asolimando] for the review > ArrowAdapterTest fails on Windows > - > > Key: CALCITE-6390 > URL: https://issues.apache.org/jira/browse/CALCITE-6390 > Project: Calcite > Issue Type: Sub-task >Reporter: Sergey Nuyanzin >Assignee: Stamatis Zampetakis >Priority: Major > Labels: pull-request-available > > -That's seems somehow highlights the difference between Windows Server and > non Server- > -we have tests against Windows Server on gha (windows-latest) and they are > green- > -At the same time local tests on Windows 11 show that {{ArrowAdapterTest}} > fails like- > Based on deeper analysis Arrow module was never tested on Windows since for > Windows conf on gha it is {{--exclude-task :arrow:build}} which makes it > skipping the tests for this module > https://github.com/apache/calcite/blob/aa8d81bf1ff39e3632aeb856fc4cc247ce9727e5/.github/workflows/main.yml#L110C60-L110C88 > Any attempt to test it leads to > {noformat} > FAILURE 0.0sec, org.apache.calcite.adapter.arrow.ArrowAdapterTest > > executionError > java.io.IOException: Failed to delete temp directory > D:\MyConfiguration\cancai.cai\AppData\Local\Temp\junit5105379620525559011. > The following paths could not be deleted (see suppressed exceptions for > details): , arrow > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:350) > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:251) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.lambda$closeAllStoredCloseableValues$3(ExtensionValuesStore.java:68) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) > at > java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) > at java.util.ArrayList.forEach(ArrayList.java:1259) > at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:390) > at java.util.stream.Sink$ChainedReference.end(Sink.java:258) > at > java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483) > at > java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) > at > java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) > at > java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) > at > java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.closeAllStoredCloseableValues(ExtensionValuesStore.java:68) > at > org.junit.jupiter.engine.descriptor.AbstractExtensionContext.close(AbstractExtensionContext.java:80) > at > org.junit.jupiter.engine.execution.JupiterEngineExecutionContext.close(JupiterEngineExecutionContext.java:53) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:222) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:57) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$cleanUp$10(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.cleanUp(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:98) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:129) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support
[jira] [Commented] (CALCITE-6390) ArrowAdapterTest fails on Windows
[ https://issues.apache.org/jira/browse/CALCITE-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841936#comment-17841936 ] Sergey Nuyanzin commented on CALCITE-6390: -- yep, I like the idea to skip tests on gradle level, also checked on the laptop with Windows where I have access May be it would make sense to add a note that in case of building on Windows users should keep in mind that Arrow module will be built however tests will be skipped? {quote} Would it make sense to cancel the vote for 1.37 RC3, merge the PR and create a new RC? {quote} yep, I m going to do this > ArrowAdapterTest fails on Windows > - > > Key: CALCITE-6390 > URL: https://issues.apache.org/jira/browse/CALCITE-6390 > Project: Calcite > Issue Type: Sub-task >Reporter: Sergey Nuyanzin >Assignee: Stamatis Zampetakis >Priority: Major > Labels: pull-request-available > > -That's seems somehow highlights the difference between Windows Server and > non Server- > -we have tests against Windows Server on gha (windows-latest) and they are > green- > -At the same time local tests on Windows 11 show that {{ArrowAdapterTest}} > fails like- > Based on deeper analysis Arrow module was never tested on Windows since for > Windows conf on gha it is {{--exclude-task :arrow:build}} which makes it > skipping the tests for this module > https://github.com/apache/calcite/blob/aa8d81bf1ff39e3632aeb856fc4cc247ce9727e5/.github/workflows/main.yml#L110C60-L110C88 > Any attempt to test it leads to > {noformat} > FAILURE 0.0sec, org.apache.calcite.adapter.arrow.ArrowAdapterTest > > executionError > java.io.IOException: Failed to delete temp directory > D:\MyConfiguration\cancai.cai\AppData\Local\Temp\junit5105379620525559011. > The following paths could not be deleted (see suppressed exceptions for > details): , arrow > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:350) > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:251) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.lambda$closeAllStoredCloseableValues$3(ExtensionValuesStore.java:68) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) > at > java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) > at java.util.ArrayList.forEach(ArrayList.java:1259) > at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:390) > at java.util.stream.Sink$ChainedReference.end(Sink.java:258) > at > java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483) > at > java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) > at > java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) > at > java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) > at > java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.closeAllStoredCloseableValues(ExtensionValuesStore.java:68) > at > org.junit.jupiter.engine.descriptor.AbstractExtensionContext.close(AbstractExtensionContext.java:80) > at > org.junit.jupiter.engine.execution.JupiterEngineExecutionContext.close(JupiterEngineExecutionContext.java:53) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:222) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:57) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$cleanUp$10(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.cleanUp(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:98) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:129) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(N
[jira] [Commented] (CALCITE-6390) ArrowAdapterTest fails on Windows
[ https://issues.apache.org/jira/browse/CALCITE-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841931#comment-17841931 ] Stamatis Zampetakis commented on CALCITE-6390: -- Skipping the entire project or build when running on Windows may have undesired side-effects. For instance, if the RM is running on Windows we may end up with a release that does not contain the Arrow adapter and it may even pass unnoticed. If the tests are the only problem then skipping only those makes sense. > ArrowAdapterTest fails on Windows > - > > Key: CALCITE-6390 > URL: https://issues.apache.org/jira/browse/CALCITE-6390 > Project: Calcite > Issue Type: Sub-task >Reporter: Sergey Nuyanzin >Assignee: Stamatis Zampetakis >Priority: Major > Labels: pull-request-available > > -That's seems somehow highlights the difference between Windows Server and > non Server- > -we have tests against Windows Server on gha (windows-latest) and they are > green- > -At the same time local tests on Windows 11 show that {{ArrowAdapterTest}} > fails like- > Based on deeper analysis Arrow module was never tested on Windows since for > Windows conf on gha it is {{--exclude-task :arrow:build}} which makes it > skipping the tests for this module > https://github.com/apache/calcite/blob/aa8d81bf1ff39e3632aeb856fc4cc247ce9727e5/.github/workflows/main.yml#L110C60-L110C88 > Any attempt to test it leads to > {noformat} > FAILURE 0.0sec, org.apache.calcite.adapter.arrow.ArrowAdapterTest > > executionError > java.io.IOException: Failed to delete temp directory > D:\MyConfiguration\cancai.cai\AppData\Local\Temp\junit5105379620525559011. > The following paths could not be deleted (see suppressed exceptions for > details): , arrow > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:350) > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:251) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.lambda$closeAllStoredCloseableValues$3(ExtensionValuesStore.java:68) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) > at > java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) > at java.util.ArrayList.forEach(ArrayList.java:1259) > at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:390) > at java.util.stream.Sink$ChainedReference.end(Sink.java:258) > at > java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483) > at > java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) > at > java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) > at > java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) > at > java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.closeAllStoredCloseableValues(ExtensionValuesStore.java:68) > at > org.junit.jupiter.engine.descriptor.AbstractExtensionContext.close(AbstractExtensionContext.java:80) > at > org.junit.jupiter.engine.execution.JupiterEngineExecutionContext.close(JupiterEngineExecutionContext.java:53) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:222) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:57) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$cleanUp$10(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.cleanUp(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:98) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:129) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) > at > org.junit.platform.engine.support.hierarchical.Thro
[jira] [Commented] (CALCITE-6390) ArrowAdapterTest fails on Windows
[ https://issues.apache.org/jira/browse/CALCITE-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841930#comment-17841930 ] Caican Cai commented on CALCITE-6390: - Do we need to document this > ArrowAdapterTest fails on Windows > - > > Key: CALCITE-6390 > URL: https://issues.apache.org/jira/browse/CALCITE-6390 > Project: Calcite > Issue Type: Sub-task >Reporter: Sergey Nuyanzin >Assignee: Stamatis Zampetakis >Priority: Major > Labels: pull-request-available > > -That's seems somehow highlights the difference between Windows Server and > non Server- > -we have tests against Windows Server on gha (windows-latest) and they are > green- > -At the same time local tests on Windows 11 show that {{ArrowAdapterTest}} > fails like- > Based on deeper analysis Arrow module was never tested on Windows since for > Windows conf on gha it is {{--exclude-task :arrow:build}} which makes it > skipping the tests for this module > https://github.com/apache/calcite/blob/aa8d81bf1ff39e3632aeb856fc4cc247ce9727e5/.github/workflows/main.yml#L110C60-L110C88 > Any attempt to test it leads to > {noformat} > FAILURE 0.0sec, org.apache.calcite.adapter.arrow.ArrowAdapterTest > > executionError > java.io.IOException: Failed to delete temp directory > D:\MyConfiguration\cancai.cai\AppData\Local\Temp\junit5105379620525559011. > The following paths could not be deleted (see suppressed exceptions for > details): , arrow > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:350) > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:251) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.lambda$closeAllStoredCloseableValues$3(ExtensionValuesStore.java:68) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) > at > java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) > at java.util.ArrayList.forEach(ArrayList.java:1259) > at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:390) > at java.util.stream.Sink$ChainedReference.end(Sink.java:258) > at > java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483) > at > java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) > at > java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) > at > java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) > at > java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.closeAllStoredCloseableValues(ExtensionValuesStore.java:68) > at > org.junit.jupiter.engine.descriptor.AbstractExtensionContext.close(AbstractExtensionContext.java:80) > at > org.junit.jupiter.engine.execution.JupiterEngineExecutionContext.close(JupiterEngineExecutionContext.java:53) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:222) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:57) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$cleanUp$10(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.cleanUp(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:98) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:129) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) > at > org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137) > at > org.junit.platform.engi
[jira] [Commented] (CALCITE-6390) ArrowAdapterTest fails on Windows
[ https://issues.apache.org/jira/browse/CALCITE-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841929#comment-17841929 ] Stamatis Zampetakis commented on CALCITE-6390: -- Actually Ruben's idea of just disabling the Arrow tests on Windows is less brutal so I updated the PR accordingly to see if everything else works as expected. > ArrowAdapterTest fails on Windows > - > > Key: CALCITE-6390 > URL: https://issues.apache.org/jira/browse/CALCITE-6390 > Project: Calcite > Issue Type: Sub-task >Reporter: Sergey Nuyanzin >Assignee: Stamatis Zampetakis >Priority: Major > Labels: pull-request-available > > -That's seems somehow highlights the difference between Windows Server and > non Server- > -we have tests against Windows Server on gha (windows-latest) and they are > green- > -At the same time local tests on Windows 11 show that {{ArrowAdapterTest}} > fails like- > Based on deeper analysis Arrow module was never tested on Windows since for > Windows conf on gha it is {{--exclude-task :arrow:build}} which makes it > skipping the tests for this module > https://github.com/apache/calcite/blob/aa8d81bf1ff39e3632aeb856fc4cc247ce9727e5/.github/workflows/main.yml#L110C60-L110C88 > Any attempt to test it leads to > {noformat} > FAILURE 0.0sec, org.apache.calcite.adapter.arrow.ArrowAdapterTest > > executionError > java.io.IOException: Failed to delete temp directory > D:\MyConfiguration\cancai.cai\AppData\Local\Temp\junit5105379620525559011. > The following paths could not be deleted (see suppressed exceptions for > details): , arrow > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:350) > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:251) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.lambda$closeAllStoredCloseableValues$3(ExtensionValuesStore.java:68) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) > at > java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) > at java.util.ArrayList.forEach(ArrayList.java:1259) > at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:390) > at java.util.stream.Sink$ChainedReference.end(Sink.java:258) > at > java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483) > at > java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) > at > java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) > at > java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) > at > java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.closeAllStoredCloseableValues(ExtensionValuesStore.java:68) > at > org.junit.jupiter.engine.descriptor.AbstractExtensionContext.close(AbstractExtensionContext.java:80) > at > org.junit.jupiter.engine.execution.JupiterEngineExecutionContext.close(JupiterEngineExecutionContext.java:53) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:222) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:57) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$cleanUp$10(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.cleanUp(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:98) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:129) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(N
[jira] [Commented] (CALCITE-6390) ArrowAdapterTest fails on Windows
[ https://issues.apache.org/jira/browse/CALCITE-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841925#comment-17841925 ] Ruben Q L commented on CALCITE-6390: +1 on [~zabetak]'s idea. Would it make sense to cancel the vote for 1.37 RC3, merge the PR and create a new RC? > ArrowAdapterTest fails on Windows > - > > Key: CALCITE-6390 > URL: https://issues.apache.org/jira/browse/CALCITE-6390 > Project: Calcite > Issue Type: Sub-task >Reporter: Sergey Nuyanzin >Assignee: Stamatis Zampetakis >Priority: Major > Labels: pull-request-available > > -That's seems somehow highlights the difference between Windows Server and > non Server- > -we have tests against Windows Server on gha (windows-latest) and they are > green- > -At the same time local tests on Windows 11 show that {{ArrowAdapterTest}} > fails like- > Based on deeper analysis Arrow module was never tested on Windows since for > Windows conf on gha it is {{--exclude-task :arrow:build}} which makes it > skipping the tests for this module > https://github.com/apache/calcite/blob/aa8d81bf1ff39e3632aeb856fc4cc247ce9727e5/.github/workflows/main.yml#L110C60-L110C88 > Any attempt to test it leads to > {noformat} > FAILURE 0.0sec, org.apache.calcite.adapter.arrow.ArrowAdapterTest > > executionError > java.io.IOException: Failed to delete temp directory > D:\MyConfiguration\cancai.cai\AppData\Local\Temp\junit5105379620525559011. > The following paths could not be deleted (see suppressed exceptions for > details): , arrow > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:350) > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:251) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.lambda$closeAllStoredCloseableValues$3(ExtensionValuesStore.java:68) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) > at > java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) > at java.util.ArrayList.forEach(ArrayList.java:1259) > at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:390) > at java.util.stream.Sink$ChainedReference.end(Sink.java:258) > at > java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483) > at > java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) > at > java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) > at > java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) > at > java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.closeAllStoredCloseableValues(ExtensionValuesStore.java:68) > at > org.junit.jupiter.engine.descriptor.AbstractExtensionContext.close(AbstractExtensionContext.java:80) > at > org.junit.jupiter.engine.execution.JupiterEngineExecutionContext.close(JupiterEngineExecutionContext.java:53) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:222) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:57) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$cleanUp$10(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.cleanUp(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:98) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:129) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) > at > org.junit.platform.engine.supp
[jira] [Commented] (CALCITE-6390) ArrowAdapterTest fails on Windows
[ https://issues.apache.org/jira/browse/CALCITE-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841922#comment-17841922 ] Stamatis Zampetakis commented on CALCITE-6390: -- Given that the Arrow build was never tested on Windows I would be inclined to skip the project automatically (and transparently for the end users) when running on Windows instead of adding OS specific instructions in the documentation. I raised a PR with this approach. WDYT? > ArrowAdapterTest fails on Windows > - > > Key: CALCITE-6390 > URL: https://issues.apache.org/jira/browse/CALCITE-6390 > Project: Calcite > Issue Type: Sub-task >Reporter: Sergey Nuyanzin >Assignee: Stamatis Zampetakis >Priority: Major > Labels: pull-request-available > > -That's seems somehow highlights the difference between Windows Server and > non Server- > -we have tests against Windows Server on gha (windows-latest) and they are > green- > -At the same time local tests on Windows 11 show that {{ArrowAdapterTest}} > fails like- > Based on deeper analysis Arrow module was never tested on Windows since for > Windows conf on gha it is {{--exclude-task :arrow:build}} which makes it > skipping the tests for this module > https://github.com/apache/calcite/blob/aa8d81bf1ff39e3632aeb856fc4cc247ce9727e5/.github/workflows/main.yml#L110C60-L110C88 > Any attempt to test it leads to > {noformat} > FAILURE 0.0sec, org.apache.calcite.adapter.arrow.ArrowAdapterTest > > executionError > java.io.IOException: Failed to delete temp directory > D:\MyConfiguration\cancai.cai\AppData\Local\Temp\junit5105379620525559011. > The following paths could not be deleted (see suppressed exceptions for > details): , arrow > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:350) > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:251) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.lambda$closeAllStoredCloseableValues$3(ExtensionValuesStore.java:68) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) > at > java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) > at java.util.ArrayList.forEach(ArrayList.java:1259) > at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:390) > at java.util.stream.Sink$ChainedReference.end(Sink.java:258) > at > java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483) > at > java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) > at > java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) > at > java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) > at > java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.closeAllStoredCloseableValues(ExtensionValuesStore.java:68) > at > org.junit.jupiter.engine.descriptor.AbstractExtensionContext.close(AbstractExtensionContext.java:80) > at > org.junit.jupiter.engine.execution.JupiterEngineExecutionContext.close(JupiterEngineExecutionContext.java:53) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:222) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:57) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$cleanUp$10(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.cleanUp(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:98) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:129) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollec
[jira] [Updated] (CALCITE-6390) ArrowAdapterTest fails on Windows
[ https://issues.apache.org/jira/browse/CALCITE-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-6390: Labels: pull-request-available (was: ) > ArrowAdapterTest fails on Windows > - > > Key: CALCITE-6390 > URL: https://issues.apache.org/jira/browse/CALCITE-6390 > Project: Calcite > Issue Type: Sub-task >Reporter: Sergey Nuyanzin >Assignee: Stamatis Zampetakis >Priority: Major > Labels: pull-request-available > > -That's seems somehow highlights the difference between Windows Server and > non Server- > -we have tests against Windows Server on gha (windows-latest) and they are > green- > -At the same time local tests on Windows 11 show that {{ArrowAdapterTest}} > fails like- > Based on deeper analysis Arrow module was never tested on Windows since for > Windows conf on gha it is {{--exclude-task :arrow:build}} which makes it > skipping the tests for this module > https://github.com/apache/calcite/blob/aa8d81bf1ff39e3632aeb856fc4cc247ce9727e5/.github/workflows/main.yml#L110C60-L110C88 > Any attempt to test it leads to > {noformat} > FAILURE 0.0sec, org.apache.calcite.adapter.arrow.ArrowAdapterTest > > executionError > java.io.IOException: Failed to delete temp directory > D:\MyConfiguration\cancai.cai\AppData\Local\Temp\junit5105379620525559011. > The following paths could not be deleted (see suppressed exceptions for > details): , arrow > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:350) > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:251) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.lambda$closeAllStoredCloseableValues$3(ExtensionValuesStore.java:68) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) > at > java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) > at java.util.ArrayList.forEach(ArrayList.java:1259) > at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:390) > at java.util.stream.Sink$ChainedReference.end(Sink.java:258) > at > java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483) > at > java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) > at > java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) > at > java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) > at > java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.closeAllStoredCloseableValues(ExtensionValuesStore.java:68) > at > org.junit.jupiter.engine.descriptor.AbstractExtensionContext.close(AbstractExtensionContext.java:80) > at > org.junit.jupiter.engine.execution.JupiterEngineExecutionContext.close(JupiterEngineExecutionContext.java:53) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:222) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:57) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$cleanUp$10(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.cleanUp(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:98) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:129) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) > at > org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137) > at > org.junit.platform.engine.support.hierarchical.NodeTestTa
[jira] [Assigned] (CALCITE-6390) ArrowAdapterTest fails on Windows
[ https://issues.apache.org/jira/browse/CALCITE-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stamatis Zampetakis reassigned CALCITE-6390: Assignee: Stamatis Zampetakis > ArrowAdapterTest fails on Windows > - > > Key: CALCITE-6390 > URL: https://issues.apache.org/jira/browse/CALCITE-6390 > Project: Calcite > Issue Type: Sub-task >Reporter: Sergey Nuyanzin >Assignee: Stamatis Zampetakis >Priority: Major > > -That's seems somehow highlights the difference between Windows Server and > non Server- > -we have tests against Windows Server on gha (windows-latest) and they are > green- > -At the same time local tests on Windows 11 show that {{ArrowAdapterTest}} > fails like- > Based on deeper analysis Arrow module was never tested on Windows since for > Windows conf on gha it is {{--exclude-task :arrow:build}} which makes it > skipping the tests for this module > https://github.com/apache/calcite/blob/aa8d81bf1ff39e3632aeb856fc4cc247ce9727e5/.github/workflows/main.yml#L110C60-L110C88 > Any attempt to test it leads to > {noformat} > FAILURE 0.0sec, org.apache.calcite.adapter.arrow.ArrowAdapterTest > > executionError > java.io.IOException: Failed to delete temp directory > D:\MyConfiguration\cancai.cai\AppData\Local\Temp\junit5105379620525559011. > The following paths could not be deleted (see suppressed exceptions for > details): , arrow > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:350) > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:251) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.lambda$closeAllStoredCloseableValues$3(ExtensionValuesStore.java:68) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) > at > java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) > at java.util.ArrayList.forEach(ArrayList.java:1259) > at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:390) > at java.util.stream.Sink$ChainedReference.end(Sink.java:258) > at > java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483) > at > java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) > at > java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) > at > java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) > at > java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.closeAllStoredCloseableValues(ExtensionValuesStore.java:68) > at > org.junit.jupiter.engine.descriptor.AbstractExtensionContext.close(AbstractExtensionContext.java:80) > at > org.junit.jupiter.engine.execution.JupiterEngineExecutionContext.close(JupiterEngineExecutionContext.java:53) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:222) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:57) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$cleanUp$10(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.cleanUp(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:98) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:129) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) > at > org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTest
[jira] [Commented] (CALCITE-6390) ArrowAdapterTest fails on Windows
[ https://issues.apache.org/jira/browse/CALCITE-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841912#comment-17841912 ] Ruben Q L commented on CALCITE-6390: [~Sergey Nuyanzin] thanks for investigating this. Wouldn't it be more precise to just exclude {{arrow:test}} ? > ArrowAdapterTest fails on Windows > - > > Key: CALCITE-6390 > URL: https://issues.apache.org/jira/browse/CALCITE-6390 > Project: Calcite > Issue Type: Sub-task >Reporter: Sergey Nuyanzin >Priority: Major > > -That's seems somehow highlights the difference between Windows Server and > non Server- > -we have tests against Windows Server on gha (windows-latest) and they are > green- > -At the same time local tests on Windows 11 show that {{ArrowAdapterTest}} > fails like- > Based on deeper analysis Arrow module was never tested on Windows since for > Windows conf on gha it is {{--exclude-task :arrow:build}} which makes it > skipping the tests for this module > https://github.com/apache/calcite/blob/aa8d81bf1ff39e3632aeb856fc4cc247ce9727e5/.github/workflows/main.yml#L110C60-L110C88 > Any attempt to test it leads to > {noformat} > FAILURE 0.0sec, org.apache.calcite.adapter.arrow.ArrowAdapterTest > > executionError > java.io.IOException: Failed to delete temp directory > D:\MyConfiguration\cancai.cai\AppData\Local\Temp\junit5105379620525559011. > The following paths could not be deleted (see suppressed exceptions for > details): , arrow > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:350) > at > org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:251) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.lambda$closeAllStoredCloseableValues$3(ExtensionValuesStore.java:68) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) > at > java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) > at java.util.ArrayList.forEach(ArrayList.java:1259) > at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:390) > at java.util.stream.Sink$ChainedReference.end(Sink.java:258) > at > java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483) > at > java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) > at > java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) > at > java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) > at > java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) > at > org.junit.jupiter.engine.execution.ExtensionValuesStore.closeAllStoredCloseableValues(ExtensionValuesStore.java:68) > at > org.junit.jupiter.engine.descriptor.AbstractExtensionContext.close(AbstractExtensionContext.java:80) > at > org.junit.jupiter.engine.execution.JupiterEngineExecutionContext.close(JupiterEngineExecutionContext.java:53) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:222) > at > org.junit.jupiter.engine.descriptor.JupiterTestDescriptor.cleanUp(JupiterTestDescriptor.java:57) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$cleanUp$10(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.cleanUp(NodeTestTask.java:167) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:98) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185) > at > org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:129) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) > at > org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) > at > org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) > at > org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137) > at > org.junit.platform.engine.sup