[jira] [Comment Edited] (CAMEL-10320) Provide a LeaderPolicy to ease the implementation of master/slave route/context
[ https://issues.apache.org/jira/browse/CAMEL-10320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028757#comment-16028757 ] Luca Burgazzoli edited comment on CAMEL-10320 at 5/30/17 7:01 AM: -- [~dhirajsb] I've started working on CAMEL-11362 as there is a wider need than for route policies only for leader elections stuffs so for this JIRA it would be nice to have the new re-factored master and its pluggable strategy which can the leverage CAMEL-11362. I'll take care of the DSL too as it is required as part of the CAMEL-11362 and it has impact on the Service Call EIP configuration. was (Author: lb): [~dhirajsb] I've started working on CAMEL-11362 as there is a wider need than for route policies only for leader elections stuffs so for this JIRA it would be nice to have the new re-factored master and its pluggable strategy which can the leverage CAMEL-11362. I'll take care of the DSL too as it is required as part of the CAMEL-11362. > Provide a LeaderPolicy to ease the implementation of master/slave > route/context > --- > > Key: CAMEL-10320 > URL: https://issues.apache.org/jira/browse/CAMEL-10320 > Project: Camel > Issue Type: New Feature > Components: camel-core >Reporter: Luca Burgazzoli >Assignee: Dhiraj Bokde > Fix For: 2.20.0 > > > I've been working on some master/slave RoutePolicy and I'm wondering > if we can have a proper LeaderPolicy with a standardized > implementation in Camel 3.0 so one has only to notify when a > leadership is taken > In addition it may be nice to have: > - a support for Leader election from the CmelContext so the routes are > started when the context become leader. > - an option to warm-up routes or to keep them stopped while not leader > Then we can also make it exposed in JMX so tooling are able to detect > which are current master and slaves, and whatnot. > Some possible DSL/EIP extensions: > {code:java} > from("...") > .routeId("myRoute") > .master() > .group("my-group") > .consulConfiguration("http://consul-node:8500";) > .end() > . to(...) > {code} > {code:java} > camelContext.setDefaultClusteredRouteConfiguration( > ClusteredRouteConfiguration.builder() > .withAction(ClusteredRouteAction.SUSPEND) > .withHealtCheck(...) > .consulConfiguration("http://consul-node:8500";) > .build() > ); > > // lookup the cluster configuration from the registry > from("clustered:file:/data") > .routeId("data-files") > .to(...) > // lookup the cluster configuration from the registry > from("master:file:/share") > .routeId("shared-files") > .master() > .configuration("...") > .end() > .to(...) > {code} > {code:xml} > > > > > > > > > > > > > > > > > > > > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (CAMEL-11360) Optimise - Disable Tracer and use BacklogTracer instead
[ https://issues.apache.org/jira/browse/CAMEL-11360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11360. - Resolution: Fixed We can later implemented a better tracer if you turn on tracing - intended for development purpose. The old stuff is deprecated. > Optimise - Disable Tracer and use BacklogTracer instead > --- > > Key: CAMEL-11360 > URL: https://issues.apache.org/jira/browse/CAMEL-11360 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen >Assignee: Claus Ibsen > Fix For: 2.20.0 > > Attachments: after.png, before.png > > > See CAMEL-11359 > We have the old tracer logic that is cruft. Its still capturing tracing > details during runtime, but that is obsolete with the message history we use > instead (eg the stuff that also dumps those route stacktrace errors). > So if users say camelContext.setTracing(true) we can then use BacklogTracer > instead to log similar trace events. > This allows us to not capture 2x trace details during routing as message > history will be used for both. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (CAMEL-11352) duplicated/missing logs when camel-paxlogging work with pax-logging-log4j2
[ https://issues.apache.org/jira/browse/CAMEL-11352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11352. - Resolution: Fixed Assignee: Claus Ibsen Fix Version/s: 2.20.0 2.19.1 Thanks for the PR > duplicated/missing logs when camel-paxlogging work with pax-logging-log4j2 > -- > > Key: CAMEL-11352 > URL: https://issues.apache.org/jira/browse/CAMEL-11352 > Project: Camel > Issue Type: Bug >Affects Versions: 2.17.6, 2.19.0 >Reporter: Xilai Dai >Assignee: Claus Ibsen > Fix For: 2.19.1, 2.20.0 > > > This problem is found after switch to the karaf 4.1.x, which using > pax-logging-log4j2 insteadof pax-logging-service. > I created a small test case project for reproduce this issue. > https://github.com/xldai/test/tree/master/test-paxlogging-camel > The findings from me is that, when PaxLoggingConsumer class [1] work together > with pax-logging-service (karaf 4.0.x), it creates new threads to process the > incoming PaxLoggingEvent and using MDC to filter the possible duplicated logs > from PaxAppenderProxy class [2]. > but when PaxLoggingConsumer class work together with pax-logging-log4j2, the > multi thread mechanism for processing the PaxLoggingEvent will lead to > duplicated/missing logs output to the camel Exchange. > Since the L63 from [3] fixed the possible duplicated logs come from > PaxAppenderProxy class, I found that the multi thread mechanism and MDC > checking can be removed from PaxLoggingConsumer class, then it works again as > expected from my test result. > [1] > https://github.com/apache/camel/blob/master/components/camel-paxlogging/src/main/java/org/apache/camel/component/paxlogging/PaxLoggingConsumer.java#L58 > [2] > https://github.com/ops4j/org.ops4j.pax.logging/blob/logging-1.9.1/pax-logging-service/src/main/java/org/ops4j/pax/logging/service/internal/PaxAppenderProxy.java#L63 > [3] > https://github.com/ops4j/org.ops4j.pax.logging/blob/logging-1.9.1/pax-logging-log4j2/src/main/java/org/ops4j/pax/logging/log4j2/internal/PaxAppenderProxy.java#L63 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (CAMEL-11364) Runtime endpoint registry - Do not use extended mode as default
Claus Ibsen created CAMEL-11364: --- Summary: Runtime endpoint registry - Do not use extended mode as default Key: CAMEL-11364 URL: https://issues.apache.org/jira/browse/CAMEL-11364 Project: Camel Issue Type: Improvement Components: camel-core Reporter: Claus Ibsen Priority: Minor Fix For: 2.20.0 We can turn this off as the extended mode may not bring as much value. In this mode it captures hit stats for each endpoint in use. There is plenty of other stats for that in the route / processor mbeans. http://camel.465427.n5.nabble.com/Runtime-endpoint-registry-is-in-extended-mode-tp5801306.html -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CAMEL-11363) Optimise - Use ArrayDeque instead of Stack
[ https://issues.apache.org/jira/browse/CAMEL-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028828#comment-16028828 ] John Poth commented on CAMEL-11363: --- I can take a look at this. > Optimise - Use ArrayDeque instead of Stack > -- > > Key: CAMEL-11363 > URL: https://issues.apache.org/jira/browse/CAMEL-11363 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.20.0 > > > There is some code that uses the very old java.util.Stack. We should use > ArrayDeque which is recommended. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (CAMEL-11365) camel-spring-boot - allowUseOriginalMessage should have same default as camel-core
Claus Ibsen created CAMEL-11365: --- Summary: camel-spring-boot - allowUseOriginalMessage should have same default as camel-core Key: CAMEL-11365 URL: https://issues.apache.org/jira/browse/CAMEL-11365 Project: Camel Issue Type: Improvement Components: camel-spring-boot Affects Versions: 2.19.0 Reporter: Claus Ibsen Assignee: Claus Ibsen Priority: Minor Fix For: 2.20.0 See CAMEL-9250 This default was not turned off in camel-spring-boot. Turning this off avoids defensive copy and yields a little better performance -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (CAMEL-11365) camel-spring-boot - allowUseOriginalMessage should have same default as camel-core
[ https://issues.apache.org/jira/browse/CAMEL-11365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-11365: Fix Version/s: 2.19.1 > camel-spring-boot - allowUseOriginalMessage should have same default as > camel-core > -- > > Key: CAMEL-11365 > URL: https://issues.apache.org/jira/browse/CAMEL-11365 > Project: Camel > Issue Type: Improvement > Components: camel-spring-boot >Affects Versions: 2.19.0 >Reporter: Claus Ibsen >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.19.1, 2.20.0 > > > See CAMEL-9250 > This default was not turned off in camel-spring-boot. > Turning this off avoids defensive copy and yields a little better performance -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (CAMEL-11365) camel-spring-boot - allowUseOriginalMessage should have same default as camel-core
[ https://issues.apache.org/jira/browse/CAMEL-11365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11365. - Resolution: Fixed > camel-spring-boot - allowUseOriginalMessage should have same default as > camel-core > -- > > Key: CAMEL-11365 > URL: https://issues.apache.org/jira/browse/CAMEL-11365 > Project: Camel > Issue Type: Improvement > Components: camel-spring-boot >Affects Versions: 2.19.0 >Reporter: Claus Ibsen >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.19.1, 2.20.0 > > > See CAMEL-9250 > This default was not turned off in camel-spring-boot. > Turning this off avoids defensive copy and yields a little better performance -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (CAMEL-11364) Runtime endpoint registry - Do not use extended mode as default
[ https://issues.apache.org/jira/browse/CAMEL-11364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen reassigned CAMEL-11364: --- Assignee: Claus Ibsen > Runtime endpoint registry - Do not use extended mode as default > --- > > Key: CAMEL-11364 > URL: https://issues.apache.org/jira/browse/CAMEL-11364 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.20.0 > > > We can turn this off as the extended mode may not bring as much value. In > this mode it captures hit stats for each endpoint in use. There is plenty of > other stats for that in the route / processor mbeans. > http://camel.465427.n5.nabble.com/Runtime-endpoint-registry-is-in-extended-mode-tp5801306.html -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CAMEL-11364) Runtime endpoint registry - Do not use extended mode as default
[ https://issues.apache.org/jira/browse/CAMEL-11364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029192#comment-16029192 ] Claus Ibsen commented on CAMEL-11364: - camel-spring-boot was not doing that as it has explicit set the mode to default > Runtime endpoint registry - Do not use extended mode as default > --- > > Key: CAMEL-11364 > URL: https://issues.apache.org/jira/browse/CAMEL-11364 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.20.0 > > > We can turn this off as the extended mode may not bring as much value. In > this mode it captures hit stats for each endpoint in use. There is plenty of > other stats for that in the route / processor mbeans. > http://camel.465427.n5.nabble.com/Runtime-endpoint-registry-is-in-extended-mode-tp5801306.html -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (CAMEL-11356) Camel-Kubernetes: refactoring tests by using Kubernetes-server-mock and Openshift-server-mock
[ https://issues.apache.org/jira/browse/CAMEL-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Cosentino resolved CAMEL-11356. -- Resolution: Fixed > Camel-Kubernetes: refactoring tests by using Kubernetes-server-mock and > Openshift-server-mock > - > > Key: CAMEL-11356 > URL: https://issues.apache.org/jira/browse/CAMEL-11356 > Project: Camel > Issue Type: Task > Components: camel-kubernetes >Reporter: Andrea Cosentino >Assignee: Andrea Cosentino > Fix For: 2.20.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (CAMEL-10054) Create camel-atomix component
[ https://issues.apache.org/jira/browse/CAMEL-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luca Burgazzoli updated CAMEL-10054: Fix Version/s: (was: Future) 2.20.0 > Create camel-atomix component > - > > Key: CAMEL-10054 > URL: https://issues.apache.org/jira/browse/CAMEL-10054 > Project: Camel > Issue Type: New Feature >Reporter: Luca Burgazzoli >Assignee: Luca Burgazzoli >Priority: Minor > Fix For: 2.20.0 > > > See http://atomix.io/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (CAMEL-10054) Create camel-atomix component
[ https://issues.apache.org/jira/browse/CAMEL-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luca Burgazzoli reassigned CAMEL-10054: --- Assignee: Luca Burgazzoli > Create camel-atomix component > - > > Key: CAMEL-10054 > URL: https://issues.apache.org/jira/browse/CAMEL-10054 > Project: Camel > Issue Type: New Feature >Reporter: Luca Burgazzoli >Assignee: Luca Burgazzoli >Priority: Minor > Fix For: 2.20.0 > > > See http://atomix.io/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (CAMEL-11364) Runtime endpoint registry - Do not use extended mode as default
[ https://issues.apache.org/jira/browse/CAMEL-11364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11364. - Resolution: Fixed > Runtime endpoint registry - Do not use extended mode as default > --- > > Key: CAMEL-11364 > URL: https://issues.apache.org/jira/browse/CAMEL-11364 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.20.0 > > > We can turn this off as the extended mode may not bring as much value. In > this mode it captures hit stats for each endpoint in use. There is plenty of > other stats for that in the route / processor mbeans. > http://camel.465427.n5.nabble.com/Runtime-endpoint-registry-is-in-extended-mode-tp5801306.html -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CAMEL-11363) Optimise - Use ArrayDeque instead of Stack
[ https://issues.apache.org/jira/browse/CAMEL-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029211#comment-16029211 ] ASF GitHub Bot commented on CAMEL-11363: GitHub user johnpoth opened a pull request: https://github.com/apache/camel/pull/1728 CAMEL-11363: Use ArrayDeque instead of Stack https://issues.apache.org/jira/browse/CAMEL-11363 Thanks! You can merge this pull request into a Git repository by running: $ git pull https://github.com/johnpoth/camel CAMEL-11363 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/1728.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1728 commit 04ad53fa9005daff45d279a8cd4cac4af5883633 Author: jpoth Date: 2017-05-30T09:26:07Z CAMEL-11363: Use ArrayDeque instead of Stack > Optimise - Use ArrayDeque instead of Stack > -- > > Key: CAMEL-11363 > URL: https://issues.apache.org/jira/browse/CAMEL-11363 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.20.0 > > > There is some code that uses the very old java.util.Stack. We should use > ArrayDeque which is recommended. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (CAMEL-11366) Optimise - bean component result - only need to propagate headers if really needed
Claus Ibsen created CAMEL-11366: --- Summary: Optimise - bean component result - only need to propagate headers if really needed Key: CAMEL-11366 URL: https://issues.apache.org/jira/browse/CAMEL-11366 Project: Camel Issue Type: Improvement Components: camel-core Reporter: Claus Ibsen Priority: Minor In the org.apache.camel.language.bean.BeanExpression.InvokeProcessor we propagate headers etc after the invoking the bean. However as most times the output is just for the message body, then any headers etc is not needed to be propagated. Only if the bean has bean parameter bindings that gives direct access to headers for manipulation then we would need to copy over these. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (CAMEL-11363) Optimise - Use ArrayDeque instead of Stack
[ https://issues.apache.org/jira/browse/CAMEL-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen reassigned CAMEL-11363: --- Assignee: John Poth > Optimise - Use ArrayDeque instead of Stack > -- > > Key: CAMEL-11363 > URL: https://issues.apache.org/jira/browse/CAMEL-11363 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen >Assignee: John Poth > Fix For: 2.20.0 > > > There is some code that uses the very old java.util.Stack. We should use > ArrayDeque which is recommended. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (CAMEL-11363) Optimise - Use ArrayDeque instead of Stack
[ https://issues.apache.org/jira/browse/CAMEL-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11363. - Resolution: Fixed > Optimise - Use ArrayDeque instead of Stack > -- > > Key: CAMEL-11363 > URL: https://issues.apache.org/jira/browse/CAMEL-11363 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen >Assignee: John Poth > Fix For: 2.20.0 > > > There is some code that uses the very old java.util.Stack. We should use > ArrayDeque which is recommended. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CAMEL-11363) Optimise - Use ArrayDeque instead of Stack
[ https://issues.apache.org/jira/browse/CAMEL-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029258#comment-16029258 ] Claus Ibsen commented on CAMEL-11363: - Oh there was one change that iterator was now in reverse order with dequeue, so I had to use descendingIterator to keep same behavior as before in the two places where it was in use > Optimise - Use ArrayDeque instead of Stack > -- > > Key: CAMEL-11363 > URL: https://issues.apache.org/jira/browse/CAMEL-11363 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen >Assignee: John Poth > Fix For: 2.20.0 > > > There is some code that uses the very old java.util.Stack. We should use > ArrayDeque which is recommended. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (CAMEL-11367) Provide equivalend support for XML REST DSL
Zoran Regvart created CAMEL-11367: - Summary: Provide equivalend support for XML REST DSL Key: CAMEL-11367 URL: https://issues.apache.org/jira/browse/CAMEL-11367 Project: Camel Issue Type: Sub-task Components: tooling Reporter: Zoran Regvart Assignee: Zoran Regvart Priority: Minor The general purpose {{swagger-rest-dsl-generator}} should be extended to support XML DSL generation, much in the same way the Java DSL is now supported. This will enable the graphical tooling to use it as well as the Maven users that prefer XML DSL over Java DSL. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (CAMEL-11261) Revise Camel context destruction in Spring (Boot) applications
[ https://issues.apache.org/jira/browse/CAMEL-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028279#comment-16028279 ] Zoran Regvart edited comment on CAMEL-11261 at 5/30/17 11:10 AM: - The issue in wildfly-camel was that the startup of {{SpringCamelContext}} was inhibited by the {{noStart}} flag. The reasoning is that Wildfly as an application server should control when a subsystem is started or stopped. I think we should have a discussion if we can eliminate the {{noStart}} thread local flagand instead of that use {{isAutoStartup}} flag or create a new flag that replaces {{noStart}} flag but at a per {{CamelContext}} level. was (Author: zregvart): The issue in wildfly-camel was that the startup of {{SpringCamelContext}} was inhibited by the {{noStart}} flag. The reasoning is that Wildfly as an application server should control when a subsystem is started or stopped. I think we should have a discussion if we can eliminate the {{noStart}} flag as it is global for all {{SpringCamelContext}}'s (in the same classloader) and instead of that use {{isAutoStartup}} flag or create a new flag that replaces {{noStart}} flag but at a per {{CamelContext}} level. > Revise Camel context destruction in Spring (Boot) applications > -- > > Key: CAMEL-11261 > URL: https://issues.apache.org/jira/browse/CAMEL-11261 > Project: Camel > Issue Type: Improvement > Components: camel-spring, camel-spring-boot >Reporter: Zoran Regvart >Assignee: Zoran Regvart >Priority: Critical > Fix For: 2.20.0 > > > There have been issues in the past where the user needs to control the > destruction order of CamelContext with regards to other dependencies. Notably > resources such as connection pools. AMQ-3988 notes one of those for JMS > connection pools. > Prompted by the > [discussion|http://camel.465427.n5.nabble.com/OnApplicationEvent-not-called-with-CamelAutoConfiguration-tp5798802.html] > on the user forum we should investigate if there is a way we can get > CamelContext priority on shutdown. > One idea is to use lifecycle beans as in > [PR#1685|https://github.com/apache/camel/pull/1685]. > We should evaluate if this change introduces other issues. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CAMEL-11363) Optimise - Use ArrayDeque instead of Stack
[ https://issues.apache.org/jira/browse/CAMEL-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029289#comment-16029289 ] ASF GitHub Bot commented on CAMEL-11363: Github user johnpoth closed the pull request at: https://github.com/apache/camel/pull/1728 > Optimise - Use ArrayDeque instead of Stack > -- > > Key: CAMEL-11363 > URL: https://issues.apache.org/jira/browse/CAMEL-11363 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen >Assignee: John Poth > Fix For: 2.20.0 > > > There is some code that uses the very old java.util.Stack. We should use > ArrayDeque which is recommended. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (CAMEL-10988) Improve performance of CaseInsensitiveMap
[ https://issues.apache.org/jira/browse/CAMEL-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen reassigned CAMEL-10988: --- Assignee: Claus Ibsen > Improve performance of CaseInsensitiveMap > - > > Key: CAMEL-10988 > URL: https://issues.apache.org/jira/browse/CAMEL-10988 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.18.2 >Reporter: Marcin Lachowicz >Assignee: Claus Ibsen > Fix For: 2.20.0 > > > Current CaseInsensitiveMap bases on TreeMap. > Basing on JMH, I found out that [the following implementation of > CaseInsensitiveMap|https://github.com/jdereg/java-util/blob/master/src/main/java/com/cedarsoftware/util/CaseInsensitiveMap.java] > results with even 50% performance boost, depending on use-case. > It uses HashMap with case-insensitive wrappers on String keys. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CAMEL-10988) Improve performance of CaseInsensitiveMap
[ https://issues.apache.org/jira/browse/CAMEL-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029310#comment-16029310 ] Claus Ibsen commented on CAMEL-10988: - There is a new camel-headersmap JAR which you just add to the classpath. And for spring-boot there is a camel-headersmap-starter JAR instead. > Improve performance of CaseInsensitiveMap > - > > Key: CAMEL-10988 > URL: https://issues.apache.org/jira/browse/CAMEL-10988 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.18.2 >Reporter: Marcin Lachowicz >Assignee: Claus Ibsen > Fix For: 2.20.0 > > > Current CaseInsensitiveMap bases on TreeMap. > Basing on JMH, I found out that [the following implementation of > CaseInsensitiveMap|https://github.com/jdereg/java-util/blob/master/src/main/java/com/cedarsoftware/util/CaseInsensitiveMap.java] > results with even 50% performance boost, depending on use-case. > It uses HashMap with case-insensitive wrappers on String keys. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CAMEL-11188) Use Files.newFileInputStream instead of new FileInputStream
[ https://issues.apache.org/jira/browse/CAMEL-11188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029382#comment-16029382 ] Andrea Cosentino commented on CAMEL-11188: -- I guess this is a good starting point for a novice, I'll leave it unassigned and eventually I'll reassign to me. > Use Files.newFileInputStream instead of new FileInputStream > --- > > Key: CAMEL-11188 > URL: https://issues.apache.org/jira/browse/CAMEL-11188 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen >Assignee: Andrea Cosentino > Fix For: 2.20.0 > > > See this blog > https://www.cloudbees.com/blog/fileinputstream-fileoutputstream-considered-harmful -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (CAMEL-11188) Use Files.newFileInputStream instead of new FileInputStream
[ https://issues.apache.org/jira/browse/CAMEL-11188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Cosentino reassigned CAMEL-11188: Assignee: (was: Andrea Cosentino) > Use Files.newFileInputStream instead of new FileInputStream > --- > > Key: CAMEL-11188 > URL: https://issues.apache.org/jira/browse/CAMEL-11188 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.20.0 > > > See this blog > https://www.cloudbees.com/blog/fileinputstream-fileoutputstream-considered-harmful -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (CAMEL-10988) Improve performance of CaseInsensitiveMap
[ https://issues.apache.org/jira/browse/CAMEL-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-10988. - Resolution: Fixed > Improve performance of CaseInsensitiveMap > - > > Key: CAMEL-10988 > URL: https://issues.apache.org/jira/browse/CAMEL-10988 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.18.2 >Reporter: Marcin Lachowicz >Assignee: Claus Ibsen > Fix For: 2.20.0 > > > Current CaseInsensitiveMap bases on TreeMap. > Basing on JMH, I found out that [the following implementation of > CaseInsensitiveMap|https://github.com/jdereg/java-util/blob/master/src/main/java/com/cedarsoftware/util/CaseInsensitiveMap.java] > results with even 50% performance boost, depending on use-case. > It uses HashMap with case-insensitive wrappers on String keys. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (CAMEL-11368) Optimise - Runtime endpoint registry - Turn off by default
[ https://issues.apache.org/jira/browse/CAMEL-11368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-11368: Summary: Optimise - Runtime endpoint registry - Turn off by default (was: Runtime endpoint register - Turn off by default) > Optimise - Runtime endpoint registry - Turn off by default > -- > > Key: CAMEL-11368 > URL: https://issues.apache.org/jira/browse/CAMEL-11368 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen >Assignee: Claus Ibsen > Fix For: 2.20.0 > > > We should turn off this by default as it brings not so much value out of the > box. > And if its off, then we can optimise some areas in camel as then there is no > event notifiers in normal use-cases which we can then optimise the hot spots > to know and take advantage off. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (CAMEL-11368) Runtime endpoint register - Turn off by default
Claus Ibsen created CAMEL-11368: --- Summary: Runtime endpoint register - Turn off by default Key: CAMEL-11368 URL: https://issues.apache.org/jira/browse/CAMEL-11368 Project: Camel Issue Type: Improvement Components: camel-core Reporter: Claus Ibsen Assignee: Claus Ibsen Fix For: 2.20.0 We should turn off this by default as it brings not so much value out of the box. And if its off, then we can optimise some areas in camel as then there is no event notifiers in normal use-cases which we can then optimise the hot spots to know and take advantage off. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CAMEL-10988) Improve performance of CaseInsensitiveMap
[ https://issues.apache.org/jira/browse/CAMEL-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029475#comment-16029475 ] Marcin Lachowicz commented on CAMEL-10988: -- Thank you very much! I really appreciate your help :) Best regards, Marcin Lachowicz > Improve performance of CaseInsensitiveMap > - > > Key: CAMEL-10988 > URL: https://issues.apache.org/jira/browse/CAMEL-10988 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.18.2 >Reporter: Marcin Lachowicz >Assignee: Claus Ibsen > Fix For: 2.20.0 > > > Current CaseInsensitiveMap bases on TreeMap. > Basing on JMH, I found out that [the following implementation of > CaseInsensitiveMap|https://github.com/jdereg/java-util/blob/master/src/main/java/com/cedarsoftware/util/CaseInsensitiveMap.java] > results with even 50% performance boost, depending on use-case. > It uses HashMap with case-insensitive wrappers on String keys. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CAMEL-11332) Create a new camel-thrift data format
[ https://issues.apache.org/jira/browse/CAMEL-11332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029592#comment-16029592 ] ASF GitHub Bot commented on CAMEL-11332: GitHub user dmvolod opened a pull request: https://github.com/apache/camel/pull/1729 CAMEL-11332: Create a new camel-thrift data format You can merge this pull request into a Git repository by running: $ git pull https://github.com/dmvolod/camel CAMEL-11332 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/1729.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1729 commit c9a9039cbf2ccf7687436865f514600423ca53b2 Author: Dmitry Volodin Date: 2017-05-29T08:42:37Z CAMEL-11332: Create a new camel-thrift data format > Create a new camel-thrift data format > - > > Key: CAMEL-11332 > URL: https://issues.apache.org/jira/browse/CAMEL-11332 > Project: Camel > Issue Type: Sub-task >Reporter: Dmitry Volodin >Assignee: Dmitry Volodin > Labels: thrift > Fix For: 2.20.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Work started] (CAMEL-11332) Create a new camel-thrift data format
[ https://issues.apache.org/jira/browse/CAMEL-11332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on CAMEL-11332 started by Dmitry Volodin. -- > Create a new camel-thrift data format > - > > Key: CAMEL-11332 > URL: https://issues.apache.org/jira/browse/CAMEL-11332 > Project: Camel > Issue Type: Sub-task >Reporter: Dmitry Volodin >Assignee: Dmitry Volodin > Labels: thrift > Fix For: 2.20.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Work started] (CAMEL-10054) Create camel-atomix component
[ https://issues.apache.org/jira/browse/CAMEL-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on CAMEL-10054 started by Luca Burgazzoli. --- > Create camel-atomix component > - > > Key: CAMEL-10054 > URL: https://issues.apache.org/jira/browse/CAMEL-10054 > Project: Camel > Issue Type: New Feature >Reporter: Luca Burgazzoli >Assignee: Luca Burgazzoli >Priority: Minor > Fix For: 2.20.0 > > > See http://atomix.io/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CAMEL-10988) Improve performance of CaseInsensitiveMap
[ https://issues.apache.org/jira/browse/CAMEL-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029595#comment-16029595 ] Claus Ibsen commented on CAMEL-10988: - btw there is also a HashMapHeadersMapFactory you can configure that uses a regular hash map, but then the keys are case sensitive. This does not work for all components, typically HTTP based. But it can be usable in some use-cases and should be faster than the other implementations > Improve performance of CaseInsensitiveMap > - > > Key: CAMEL-10988 > URL: https://issues.apache.org/jira/browse/CAMEL-10988 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.18.2 >Reporter: Marcin Lachowicz >Assignee: Claus Ibsen > Fix For: 2.20.0 > > > Current CaseInsensitiveMap bases on TreeMap. > Basing on JMH, I found out that [the following implementation of > CaseInsensitiveMap|https://github.com/jdereg/java-util/blob/master/src/main/java/com/cedarsoftware/util/CaseInsensitiveMap.java] > results with even 50% performance boost, depending on use-case. > It uses HashMap with case-insensitive wrappers on String keys. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (CAMEL-11369) camel-spring-boot-starter generator paste incorrect default value
Dmitry Volodin created CAMEL-11369: -- Summary: camel-spring-boot-starter generator paste incorrect default value Key: CAMEL-11369 URL: https://issues.apache.org/jira/browse/CAMEL-11369 Project: Camel Issue Type: Bug Components: camel-spring-boot-starters Affects Versions: 2.20.0 Reporter: Dmitry Volodin I've created a new data component and submit it via PR https://github.com/apache/camel/pull/1729 The spring-bootstarter *DataFormatConfiguration class contains incorrectly defined default value: private String contentTypeFormat = String.binary; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Reopened] (CAMEL-11363) Optimise - Use ArrayDeque instead of Stack
[ https://issues.apache.org/jira/browse/CAMEL-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen reopened CAMEL-11363: - Something weird is going on and I reverted. I think due the iterator is changed order then it causes troubles in other places. We should focus on only use the deque in the hot spots in the routing engine, and then leave it as-is for the rest > Optimise - Use ArrayDeque instead of Stack > -- > > Key: CAMEL-11363 > URL: https://issues.apache.org/jira/browse/CAMEL-11363 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen >Assignee: John Poth > Fix For: 2.20.0 > > > There is some code that uses the very old java.util.Stack. We should use > ArrayDeque which is recommended. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CAMEL-10988) Improve performance of CaseInsensitiveMap
[ https://issues.apache.org/jira/browse/CAMEL-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029907#comment-16029907 ] Marcin Lachowicz commented on CAMEL-10988: -- I see, this is significant performance improvement. Thanks a lot again :) > Improve performance of CaseInsensitiveMap > - > > Key: CAMEL-10988 > URL: https://issues.apache.org/jira/browse/CAMEL-10988 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.18.2 >Reporter: Marcin Lachowicz >Assignee: Claus Ibsen > Fix For: 2.20.0 > > > Current CaseInsensitiveMap bases on TreeMap. > Basing on JMH, I found out that [the following implementation of > CaseInsensitiveMap|https://github.com/jdereg/java-util/blob/master/src/main/java/com/cedarsoftware/util/CaseInsensitiveMap.java] > results with even 50% performance boost, depending on use-case. > It uses HashMap with case-insensitive wrappers on String keys. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CAMEL-11335) Create Actuator endpoint to expose route information
[ https://issues.apache.org/jira/browse/CAMEL-11335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030642#comment-16030642 ] ASF GitHub Bot commented on CAMEL-11335: GitHub user gzurowski opened a pull request: https://github.com/apache/camel/pull/1730 CAMEL-11335: Add route state details Add route state details as discussed in PR #1719. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/camel feautre/CAMEL-11335-add-route-state Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/1730.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1730 commit 394c00e56f724a83ca714a0f5ef1396327a39475 Author: Gregor Zurowski Date: 2017-05-31T05:10:06Z CAMEL-11335: Add route state details Signed-off-by: Gregor Zurowski > Create Actuator endpoint to expose route information > > > Key: CAMEL-11335 > URL: https://issues.apache.org/jira/browse/CAMEL-11335 > Project: Camel > Issue Type: New Feature > Components: camel-spring-boot >Affects Versions: 2.20.0 >Reporter: Gregor Zurowski >Assignee: Gregor Zurowski >Priority: Minor > Fix For: 2.20.0 > > > Create an Actuator endpoint that exposes some high-level route information of > the configured context. This will make it easy to quickly get an overview of > running routes via the Spring Boot Actuator mechanism. -- This message was sent by Atlassian JIRA (v6.3.15#6346)