[GitHub] carbondata pull request #2940: [CARBONDATA-3116] Support set carbon.query.di...
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2940 ---
[GitHub] carbondata pull request #2940: [CARBONDATA-3116] Support set carbon.query.di...
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2940#discussion_r238188148 --- Diff: integration/spark2/pom.xml --- @@ -105,6 +105,11 @@ + + org.apache.httpcomponents --- End diff -- Please handle it fastï¼no this dependency will affect the carbonThriftServer ---
[GitHub] carbondata pull request #2940: [CARBONDATA-3116] Support set carbon.query.di...
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2940#discussion_r238166894
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggCreateCommand.scala
---
@@ -463,6 +464,39 @@ class TestPreAggCreateCommand extends QueryTest with
BeforeAndAfterAll {
executorService.shutdown()
}
+ test("support set carbon.query.directQueryOnDataMap.enabled=true") {
+val rootPath = new File(this.getClass.getResource("/").getPath
+ + "../../../..").getCanonicalPath
+val testData =
s"$rootPath/integration/spark-common-test/src/test/resources/sample.csv"
+sql("drop table if exists mainTable")
+sql(
+ s"""
+ | CREATE TABLE mainTable
+ | (id Int,
+ | name String,
+ | city String,
+ | age Int)
+ | STORED BY 'org.apache.carbondata.format'
+ """.stripMargin);
+
+
+sql(
+ s"""
+ | LOAD DATA LOCAL INPATH '$testData'
+ | into table mainTable
+ """.stripMargin);
+
+sql(
+ s"""
+ | create datamap preagg_sum on table mainTable
+ | using 'preaggregate'
+ | as select id,sum(age) from mainTable group by id
+ """.stripMargin);
+
+sql("set carbon.query.directQueryOnDataMap.enabled=true");
--- End diff --
ok, optimized it. Why don't we use the default value for test?
---
[GitHub] carbondata pull request #2940: [CARBONDATA-3116] Support set carbon.query.di...
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2940#discussion_r238161863 --- Diff: integration/spark2/pom.xml --- @@ -105,6 +105,11 @@ + + org.apache.httpcomponents --- End diff -- @xubo245 This change is already there in #2925 . We can discuss on that PR on this. Please remove the changes from this PR. @jackylk Let us discuss whether this is actually required. Please refer the PR #2925 and give inputs ---
[GitHub] carbondata pull request #2940: [CARBONDATA-3116] Support set carbon.query.di...
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2940#discussion_r238156400
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggCreateCommand.scala
---
@@ -463,6 +464,39 @@ class TestPreAggCreateCommand extends QueryTest with
BeforeAndAfterAll {
executorService.shutdown()
}
+ test("support set carbon.query.directQueryOnDataMap.enabled=true") {
+val rootPath = new File(this.getClass.getResource("/").getPath
+ + "../../../..").getCanonicalPath
+val testData =
s"$rootPath/integration/spark-common-test/src/test/resources/sample.csv"
+sql("drop table if exists mainTable")
+sql(
+ s"""
+ | CREATE TABLE mainTable
+ | (id Int,
+ | name String,
+ | city String,
+ | age Int)
+ | STORED BY 'org.apache.carbondata.format'
+ """.stripMargin);
+
+
+sql(
+ s"""
+ | LOAD DATA LOCAL INPATH '$testData'
+ | into table mainTable
+ """.stripMargin);
--- End diff --
ok, removed
---
[GitHub] carbondata pull request #2940: [CARBONDATA-3116] Support set carbon.query.di...
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2940#discussion_r238152763
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggCreateCommand.scala
---
@@ -463,6 +464,39 @@ class TestPreAggCreateCommand extends QueryTest with
BeforeAndAfterAll {
executorService.shutdown()
}
+ test("support set carbon.query.directQueryOnDataMap.enabled=true") {
+val rootPath = new File(this.getClass.getResource("/").getPath
+ + "../../../..").getCanonicalPath
+val testData =
s"$rootPath/integration/spark-common-test/src/test/resources/sample.csv"
+sql("drop table if exists mainTable")
+sql(
+ s"""
+ | CREATE TABLE mainTable
+ | (id Int,
+ | name String,
+ | city String,
+ | age Int)
+ | STORED BY 'org.apache.carbondata.format'
+ """.stripMargin);
+
+
+sql(
+ s"""
+ | LOAD DATA LOCAL INPATH '$testData'
+ | into table mainTable
+ """.stripMargin);
--- End diff --
for scala code semi-colon `;` is not required
---
[GitHub] carbondata pull request #2940: [CARBONDATA-3116] Support set carbon.query.di...
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2940#discussion_r238142863
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggCreateCommand.scala
---
@@ -463,6 +464,39 @@ class TestPreAggCreateCommand extends QueryTest with
BeforeAndAfterAll {
executorService.shutdown()
}
+ test("support set carbon.query.directQueryOnDataMap.enabled=true") {
+val rootPath = new File(this.getClass.getResource("/").getPath
+ + "../../../..").getCanonicalPath
+val testData =
s"$rootPath/integration/spark-common-test/src/test/resources/sample.csv"
+sql("drop table if exists mainTable")
+sql(
+ s"""
+ | CREATE TABLE mainTable
+ | (id Int,
+ | name String,
+ | city String,
+ | age Int)
+ | STORED BY 'org.apache.carbondata.format'
+ """.stripMargin);
+
+
+sql(
+ s"""
+ | LOAD DATA LOCAL INPATH '$testData'
+ | into table mainTable
+ """.stripMargin);
+
+sql(
+ s"""
+ | create datamap preagg_sum on table mainTable
+ | using 'preaggregate'
+ | as select id,sum(age) from mainTable group by id
+ """.stripMargin);
+
+sql("set carbon.query.directQueryOnDataMap.enabled=true");
--- End diff --
Setting this property here would not be of use as this property is never
validated in tests.
Check
https://github.com/apache/carbondata/blob/master/integration/spark-common/src/main/scala/org/apache/spark/sql/test/util/QueryTest.scala#L45
for reference
---
[GitHub] carbondata pull request #2940: [CARBONDATA-3116] Support set carbon.query.di...
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2940#discussion_r235578689 --- Diff: integration/spark2/pom.xml --- @@ -105,6 +105,11 @@ + + org.apache.httpcomponents --- End diff -- I test this issue with CarbonThrfitServer and beeline in the local, it throw the exception, so I fix it in this PR too.small change. ---
[GitHub] carbondata pull request #2940: [CARBONDATA-3116] Support set carbon.query.di...
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2940#discussion_r235494866 --- Diff: integration/spark2/pom.xml --- @@ -105,6 +105,11 @@ + + org.apache.httpcomponents --- End diff -- Is this required in this PR? ---
[GitHub] carbondata pull request #2940: [CARBONDATA-3116] Support set carbon.query.di...
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/2940 [CARBONDATA-3116] Support set carbon.query.directQueryOnDataMap.enabled=true [CARBONDATA-3116] support set carbon.query.directQueryOnDataMap.enabled=true Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? No - [ ] Any backward compatibility impacted? No - [ ] Document update required? No - [ ] Testing done add - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. no You can merge this pull request into a Git repository by running: $ git pull https://github.com/xubo245/carbondata CARBONDATA-3116_queryOnDataMap Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2940.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2940 commit 951817802fda9df1720e0ba6341031b5183c619b Author: xubo245 Date: 2018-11-21T16:32:13Z [CARBONDATA-3116] set carbon.query.directQueryOnDataMap.enabled=true ---
