[GitHub] incubator-carbondata issue #368: [CARBONDATA-465] Spark streaming dataframe ...

[allwefantasy]

Github user allwefantasy commented on the issue:

https://github.com/apache/incubator-carbondata/pull/368
  
The commit log shows Changes allwefantasy and others added some commits 5 
days ago.  I guess there is no problem @ravipesala 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (CARBONDATA-493) Insertinto sql can not select from a empty table

[QiangCai (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

QiangCai updated CARBONDATA-493:

Description: 
example:
Insert into target_table select * from source_table

if source table is empty, data loading step will throw exception

> Insertinto sql can not select from a empty table
> 
>
> Key: CARBONDATA-493
> URL: https://issues.apache.org/jira/browse/CARBONDATA-493
> Project: CarbonData
>  Issue Type: Bug
>Affects Versions: 1.0.0-incubating
>Reporter: QiangCai
>Assignee: QiangCai
> Fix For: 1.0.0-incubating
>
>
> example:
> Insert into target_table select * from source_table
> if source table is empty, data loading step will throw exception



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CARBONDATA-493) Insertinto sql can not select from a empty table

[QiangCai (JIRA)]

QiangCai created CARBONDATA-493:
---

 Summary: Insertinto sql can not select from a empty table
 Key: CARBONDATA-493
 URL: https://issues.apache.org/jira/browse/CARBONDATA-493
 Project: CarbonData
  Issue Type: Bug
Affects Versions: 1.0.0-incubating
Reporter: QiangCai
Assignee: QiangCai
 Fix For: 1.0.0-incubating






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-carbondata issue #391: [CARBONDATA-374] support smallint

[chenliang613]

Github user chenliang613 commented on the issue:

https://github.com/apache/incubator-carbondata/pull/391
  
错误信息如下：
**Regression**
org.apache.carbondata.core.util.DataTypeUtilTest.testGetDataType

Failing for the past 1 build (Since Unstable#748 )
运行时间：3 毫秒
Error Message

expected: but was:
Stacktrace

junit.framework.AssertionFailedError: expected: but was:
at junit.framework.Assert.fail(Assert.java:57)
at junit.framework.Assert.failNotEquals(Assert.java:329)
at junit.framework.Assert.assertEquals(Assert.java:78)
at junit.framework.Assert.assertEquals(Assert.java:86)
at junit.framework.TestCase.assertEquals(TestCase.java:253)
at 
org.apache.carbondata.core.util.DataTypeUtilTest.testGetDataType(DataTypeUtilTest.java:82)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #368: [CARBONDATA-465] Spark streaming dataframe ...

[allwefantasy]

Github user allwefantasy commented on the issue:

https://github.com/apache/incubator-carbondata/pull/368
  
It's weird.  In my local branch, git log shows:

```
commit acdf78a8cba4f7c18cbaaf0fcc1a9e9dc3189068
Merge: 8a21cb7 5ca7218
Author: WilliamZhu 
Date:   Mon Dec 5 11:30:35 2016 +0800

Merge branch 'spark-streaming-dataframe-support2' of 
github.com:allwefantasy/incubator-carbondata into 
spark-streaming-dataframe-support2

commit 8a21cb715eac50c04b859530ab459ae9b6f226a3
Author: WilliamZhu 
Date:   Wed Nov 30 21:24:33 2016 +0800

remove comments on createTableFromThrift and rais jira later

commit 06bc4239a2762a6f27da99982b47e880d6a1be4c
Author: WilliamZhu 
Date:   Wed Nov 30 00:12:24 2016 +0800

reset maven-source-plugin

commit 0f042797f54143bd473296bc33650e84d071dd15
Author: WilliamZhu 
Date:   Tue Nov 29 23:46:42 2016 +0800

spark streaming dataframe support

commit 70ae82045e461c740cf2ae80c2058160bc9855a9
Merge: e7958b6 fc3f6b3
Author: ravipesala 
```

I will try to figure out


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #340: [Carbondata 434] Improved integration test ...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/incubator-carbondata/pull/340
  
Please rebase the code, don't let other commits come to this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #395: [CARBONDATA - 483] Added unit test c...

[geetikagupta16]

GitHub user geetikagupta16 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/395

[CARBONDATA - 483] Added unit test cases for core.carbon.metadata package




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/geetikagupta16/incubator-carbondata 
feature/CARBONDATA-483

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/395.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #395


commit 4687dac7dd2ba9991c6e33c782fba9968b0d08e4
Author: Geetika gupta 
Date:   2016-12-02T10:23:01Z

Closed CarbonData-483
Added testcases for core.carbon.metadata

commit cb697b65150a615359750121bbeee84ab45d3462
Author: Geetika gupta 
Date:   2016-12-05T05:16:34Z

Refactored code for ThriftWrapperSchemaConverterImplTest




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #368: [CARBONDATA-465] Spark streaming dataframe ...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/incubator-carbondata/pull/368
  
@allwefantasy  it seems there is a problem with merging/rebasing the PR, 
other commits has come here. Please fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (CARBONDATA-474) Implement unit test cases for core.datastorage package

[Anurag Srivastava (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anurag Srivastava updated CARBONDATA-474:
-
Summary: Implement unit test cases for core.datastorage package  (was: 
Implement unit test cases for core.datastorage.store.columnar package)

> Implement unit test cases for core.datastorage package
> --
>
> Key: CARBONDATA-474
> URL: https://issues.apache.org/jira/browse/CARBONDATA-474
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Anurag Srivastava
>Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-carbondata pull request #394: [CARBONDATA-482 ]AllDataTypeTestCase...

[rahulforallp]

GitHub user rahulforallp opened a pull request:

https://github.com/apache/incubator-carbondata/pull/394

[CARBONDATA-482 ]AllDataTypeTestCase6 improved



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rahulforallp/incubator-carbondata 
CARBONDATA-482

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/394.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #394


commit 0035746fb83f5bc69e4ec5def037fbe0b1fc2680
Author: rahulforallp 
Date:   2016-12-03T13:49:47Z

AllDataTypeTestCase6 improved




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #391: [CARBONDATA-374] support smallint

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/incubator-carbondata/pull/391
  
@cenyuhai There is one testcase failing, please fix it.
http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/748/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #393: [SPARK2] exclude dependency

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/393


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #393: [SPARK2] exclude dependency

[scwf]

Github user scwf commented on the issue:

https://github.com/apache/incubator-carbondata/pull/393
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #393: [SPARK2] exclude dependency

[jackylk]

GitHub user jackylk opened a pull request:

https://github.com/apache/incubator-carbondata/pull/393

[SPARK2] exclude dependency

correct pom dependency for spark2 integration

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jackylk/incubator-carbondata pom

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #393


commit e8fd8a2d150b27c9096523b96c75f9b376f8f856
Author: jackylk 
Date:   2016-12-05T03:02:24Z

exclude dependency




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #392: change snapshot version number due t...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/392


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #392: change snapshot version number due to new s...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/incubator-carbondata/pull/392
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #358: [CARBONDATA-467] Adding bucketing to carbon...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/incubator-carbondata/pull/358
  
@jackylk  Bucketing is integrated in spark 2.0 layer as well, it is working 
now. Please review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #387: [CARBONDATA-490] [SPARK2] Unify all RDD in ...

[jackylk]

Github user jackylk commented on the issue:

https://github.com/apache/incubator-carbondata/pull/387
  
CI passed
http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/745/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (CARBONDATA-491) do not use runnablecommand in spark2

[Jacky Li (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacky Li resolved CARBONDATA-491.
-
Resolution: Fixed
  Assignee: Fei Wang

> do not use runnablecommand in spark2
> 
>
> Key: CARBONDATA-491
> URL: https://issues.apache.org/jira/browse/CARBONDATA-491
> Project: CarbonData
>  Issue Type: Sub-task
>  Components: spark-integration
>Affects Versions: 0.3.0-incubating
>Reporter: Fei Wang
>Assignee: Fei Wang
> Fix For: 0.3.0-incubating
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> we should not use the runnablecommand in spark, that may leads to some 
> compatibility issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-carbondata issue #389: [CARBONDATA-491] spark2 integration: Do not...

[jackylk]

Github user jackylk commented on the issue:

https://github.com/apache/incubator-carbondata/pull/389
  
LGTM
CI passed
http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/743/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #389: [CARBONDATA-491] spark2 integration:...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/389#discussion_r90777384
  
--- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala ---
@@ -17,19 +17,20 @@
 
 package org.apache.spark.sql
 
-import org.apache.spark.SparkContext
-import org.apache.spark.internal.Logging
 import org.apache.spark.scheduler.cluster.CoarseGrainedSchedulerBackend
 import org.apache.spark.sql.hive.{CarbonMetastore, DistributionUtil}
 
+import org.apache.carbondata.common.logging.LogServiceFactory
 import org.apache.carbondata.core.constants.CarbonCommonConstants
 
 /**
  * Carbon Environment for unified context
  */
 case class CarbonEnv(carbonMetastore: CarbonMetastore)
 
-object CarbonEnv extends Logging {
+object CarbonEnv {
+
+  val Logger = LogServiceFactory.getLogService(this.getClass.getName)
--- End diff --

declare as private and change to `LOGGER`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #389: [CARBONDATA-491] spark2 integration: Do not...

[scwf]

Github user scwf commented on the issue:

https://github.com/apache/incubator-carbondata/pull/389
  
@jackylk i fix the test suite, plz review again


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #392: change snapshot version number due t...

[chenliang613]

GitHub user chenliang613 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/392

change snapshot version number due to new structure changes as per mailing 
proposal

A rich set of features are planned to be included into next release, and 
more importantly there will be external API changes introduced as will 
integrate with Spark 2.x, remove kettle etc. 

The next version number will use 1.0.0 for distinguishing major API 
changes, it would be much helpful to reduce maintenance cost through 
distinguishing the major different version due to major API changes.

Please find the detailed discussion on dev@mailing list : 
http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/CarbonData-propose-major-version-number-increment-for-next-version-to-1-0-0-td3131.html

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chenliang613/incubator-carbondata version1.0.0

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/392.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #392


commit 05afe2ab2025554279a5aa967885f7c799d81cb6
Author: chenliang613 
Date:   2016-12-04T12:30:39Z

change snapshot version number due to new structure changes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #391: [CARBONDATA-374] support smallint

[cenyuhai]

Github user cenyuhai commented on the issue:

https://github.com/apache/incubator-carbondata/pull/391
  
@jackylk @lion-x pls review the codes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #391: [CARBONDATA-374] support smallint

[cenyuhai]

GitHub user cenyuhai opened a pull request:

https://github.com/apache/incubator-carbondata/pull/391

[CARBONDATA-374] support smallint

**What changes were proposed in this pull request?**

support smallint type

**How to test？**
Test with TestCreateTable.scala

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cenyuhai/incubator-carbondata CARBON-374

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/391.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #391


commit 9e238a441576f93f2b7bc5e85a72c99c0b138130
Author: cenyuhai <261810...@qq.com>
Date:   2016-12-04T10:17:44Z

support smallint




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---