[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577589#comment-16577589 ] ASF subversion and git services commented on CLOUDSTACK-10223: -- Commit 35e008df6c551b2a0de3e7b175c738b4342eae31 in cloudstack's branch refs/heads/master from SowjanyaPatha [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=35e008d ] CLOUDSTACK-10223 Snapshots are not getting deleted when domain is deleted (#2399) > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577588#comment-16577588 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - rafaelweingartner closed pull request #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/engine/schema/src/main/java/com/cloud/storage/dao/VolumeDao.java b/engine/schema/src/main/java/com/cloud/storage/dao/VolumeDao.java index a05dc1f560d..0fc217c700b 100644 --- a/engine/schema/src/main/java/com/cloud/storage/dao/VolumeDao.java +++ b/engine/schema/src/main/java/com/cloud/storage/dao/VolumeDao.java @@ -34,6 +34,8 @@ List findByAccount(long accountId); +List findIncludingRemovedByAccount(long accountId); + Pair getCountAndTotalByPool(long poolId); Pair getNonDestroyedCountAndTotalByPool(long poolId); diff --git a/engine/schema/src/main/java/com/cloud/storage/dao/VolumeDaoImpl.java b/engine/schema/src/main/java/com/cloud/storage/dao/VolumeDaoImpl.java index f691e30c743..529e8e66b8b 100644 --- a/engine/schema/src/main/java/com/cloud/storage/dao/VolumeDaoImpl.java +++ b/engine/schema/src/main/java/com/cloud/storage/dao/VolumeDaoImpl.java @@ -99,6 +99,13 @@ return listBy(sc); } +@Override +public List findIncludingRemovedByAccount(long accountId) { +SearchCriteria sc = AllFieldsSearch.create(); +sc.setParameters("accountId", accountId); +return listIncludingRemovedBy(sc); +} + @Override public List findByInstance(long id) { SearchCriteria sc = AllFieldsSearch.create(); diff --git a/server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java b/server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java index bd49c05f43e..f1adf0ae271 100755 --- a/server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java +++ b/server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java @@ -715,7 +715,7 @@ public String getSecondaryStorageURL(SnapshotVO snapshot) { @Override public boolean deleteSnapshotDirsForAccount(long accountId) { -List volumes = _volsDao.findByAccount(accountId); +List volumes = _volsDao.findIncludingRemovedByAccount(accountId); // The above call will list only non-destroyed volumes. // So call this method before marking the volumes as destroyed. // i.e Call them before the VMs for those volumes are destroyed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462768#comment-16462768 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - blueorangutan commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-386362267 Trillian test result (tid-2571) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 116753 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2399-t2571-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 59 look OK, 8 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 374.87 | test_internal_lb.py test_01_add_primary_storage_disabled_host | `Error` | 2.20 | test_primary_storage.py test_01_primary_storage_nfs | `Error` | 0.13 | test_primary_storage.py ContextSuite context=TestStorageTags>:setup | `Error` | 0.23 | test_primary_storage.py test_02_list_snapshots_with_removed_data_store | `Error` | 1.16 | test_snapshots.py test_01_secured_vm_migration | `Error` | 40.56 | test_vm_life_cycle.py test_02_not_secured_vm_migration | `Error` | 40.57 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 40.55 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 40.56 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 18.91 | test_vm_life_cycle.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 945.20 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 605.22 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Failure` | 885.48 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 918.83 | test_vpc_redundant.py test_01_redundant_vpc_site2site_vpn | `Failure` | 661.64 | test_vpc_vpn.py test_01_vpc_site2site_vpn_multiple_options | `Error` | 603.56 | test_vpc_vpn.py test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 0.11 | test_host_maintenance.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 3.41 | test_host_maintenance.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.58 | test_hostha_kvm.py test_hostha_kvm_host_degraded | `Failure` | 1556.76 | test_hostha_kvm.py test_hostha_kvm_host_fencing | `Failure` | 628.08 | test_hostha_kvm.py test_hostha_kvm_host_recovering | `Failure` | 626.01 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460671#comment-16460671 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - blueorangutan commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385894554 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460667#comment-16460667 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - rhtyd commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385894307 LGTM, let me re-run again. @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460639#comment-16460639 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - DaanHoogland commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385891967 I don't see any error there that is related to domain or snapshot. @borisstoyanov @rhtyd agree? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459912#comment-16459912 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - blueorangutan commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385736004 Trillian test result (tid-2556) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 96100 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2399-t2556-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 62 look OK, 5 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_ssvm_internals | `Failure` | 3.48 | test_ssvm.py test_01_secured_vm_migration | `Error` | 37.46 | test_vm_life_cycle.py test_02_not_secured_vm_migration | `Error` | 37.45 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 35.39 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 1.10 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 5.30 | test_vm_life_cycle.py test_11_migrate_volume_and_change_offering | `Error` | 130.29 | test_volumes.py test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 0.13 | test_host_maintenance.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 895.41 | test_host_maintenance.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.62 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458627#comment-16458627 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - blueorangutan commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385414697 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458626#comment-16458626 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - DaanHoogland commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385414441 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457554#comment-16457554 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - rafaelweingartner commented on a change in pull request #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#discussion_r184850779 ## File path: server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java ## @@ -715,7 +715,7 @@ public String getSecondaryStorageURL(SnapshotVO snapshot) { @Override public boolean deleteSnapshotDirsForAccount(long accountId) { -List volumes = _volsDao.findByAccount(accountId); +List volumes = _volsDao.findIncludingRemovedByAccount(accountId); Review comment: I just checked, and indeed snapshots have an entry in the `volumes` table. On the other hand, I could not find entries for volumes, but this does not affect the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457530#comment-16457530 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - blueorangutan commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385165184 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457529#comment-16457529 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - DaanHoogland commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385165110 packaging failed :( git at fault. repeated manually @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457515#comment-16457515 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - blueorangutan commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385162479 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457514#comment-16457514 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - DaanHoogland commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385162431 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457494#comment-16457494 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - blueorangutan commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385159848 Packaging result: ✔centos6 ✖centos7 ✖debian. JID-1977 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457479#comment-16457479 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - blueorangutan commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385155851 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457477#comment-16457477 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - DaanHoogland commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385155756 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457475#comment-16457475 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - DaanHoogland commented on a change in pull request #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#discussion_r184846572 ## File path: server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java ## @@ -715,7 +715,7 @@ public String getSecondaryStorageURL(SnapshotVO snapshot) { @Override public boolean deleteSnapshotDirsForAccount(long accountId) { -List volumes = _volsDao.findByAccount(accountId); +List volumes = _volsDao.findIncludingRemovedByAccount(accountId); Review comment: have to check, you might just have found an old hidden bug , @rafaelweingartner . On the other hand I have seen stranger things, a template is a volume of sorts isn't it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454198#comment-16454198 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - rafaelweingartner commented on a change in pull request #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#discussion_r184390757 ## File path: server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java ## @@ -715,7 +715,7 @@ public String getSecondaryStorageURL(SnapshotVO snapshot) { @Override public boolean deleteSnapshotDirsForAccount(long accountId) { -List volumes = _volsDao.findByAccount(accountId); +List volumes = _volsDao.findIncludingRemovedByAccount(accountId); Review comment: Sorry my lack of knowledge here. Do snapshots have an entry in the `volumes` table? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355035#comment-16355035 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - SowjanyaPatha commented on issue #2399: CLOUDSTACK-10223 Snapshots are not getting deleted when domain is del… URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-363673058 tag:MergeReady This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355034#comment-16355034 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - jayakarteek commented on issue #2399: CLOUDSTACK-10223 Snapshots are not getting deleted when domain is del… URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-363673008 code LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355017#comment-16355017 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - jahnaviboddu commented on issue #2399: CLOUDSTACK-10223 Snapshots are not getting deleted when domain is del… URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-363670253 Test LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319951#comment-16319951 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - SowjanyaPatha opened a new pull request #2399: CLOUDSTACK-10223 Snapshots are not getting deleted when domain is del… URL: https://github.com/apache/cloudstack/pull/2399 …eted After domain deletion, snapshot taken by the domain remains undeleted. Steps to reproduce: --- 1. Create a test domain 2. Create test account with admin privileges. 3. Login as "test" acoount. 4. Create 3 instances - few having root disk and rest with root and data disks both. 5. For 2 instances take snapshots of root and data disks 6. Expunge above instances from ACP UI. 7. Make sure that those vm's should not be shown in ACP UI. 8. Login as root user again 9. Delete the test account 10. Delete the test domain Snapshots taken for root volume in step 5 are not deleted. Added the code to remove the snapshots when the domain is deleted. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v6.4.14#64029)