[GitHub] commons-lang issue #334: Code refactoring and cleaning
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/334 [![Coverage Status](https://coveralls.io/builds/17585970/badge)](https://coveralls.io/builds/17585970) Coverage increased (+0.01%) to 95.241% when pulling **e767af7e7eb8ff7724d5f72709ee4bb7a72d2284 on ingvarc:master** into **8e8b8e05e4eb9aa009444c2fea3552d28b57aa98 on apache:master**. ---
[GitHub] commons-lang issue #334: Code refactoring and cleaning
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/334 I'm fine either way (I believe even some classes in the JDK have some [unchecked exceptions](http://hg.openjdk.java.net/jdk7/jdk7/jdk/file/9b8c96f96a0f/src/share/classes/java/util/LinkedList.java) declared?) But I suspect this change is not backward compatible. Can't locate that documentation from Oracle explaining what's a backward change or not, but quite sure this one is. ---
[GitHub] commons-lang issue #334: Code refactoring and cleaning
Github user ingvarc commented on the issue: https://github.com/apache/commons-lang/pull/334 @kinow Since the pull request aims to refactor and to clean the code I think it makes sense. Speaking of unchecked exceptions in 'throws' clause they are backward compatible since the developers don't need either catch or declare them. I may have missed something in terms of backward compatibility and if you don't you mind pointing it out to me I would appreciate it. ---
[jira] [Created] (DBCP-508) Prepared statement keys should take a Connection's schema into account
Gary Gregory created DBCP-508: - Summary: Prepared statement keys should take a Connection's schema into account Key: DBCP-508 URL: https://issues.apache.org/jira/browse/DBCP-508 Project: Commons DBCP Issue Type: Improvement Reporter: Gary Gregory Prepared statement keys should take a Connection's schema into account. This allows prepared statements to be uniquely identified. This affects the class {{PStmtKey}} used to manage pools of prepared statement. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DBCP-508) Prepared statement keys should take a Connection's schema into account
[ https://issues.apache.org/jira/browse/DBCP-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated DBCP-508: -- Assignee: Gary Gregory > Prepared statement keys should take a Connection's schema into account > -- > > Key: DBCP-508 > URL: https://issues.apache.org/jira/browse/DBCP-508 > Project: Commons DBCP > Issue Type: Improvement >Reporter: Gary Gregory >Assignee: Gary Gregory >Priority: Major > > Prepared statement keys should take a Connection's schema into account. This > allows prepared statements to be uniquely identified. > This affects the class {{PStmtKey}} used to manage pools of prepared > statement. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (DBCP-508) Prepared statement keys should take a Connection's schema into account
[ https://issues.apache.org/jira/browse/DBCP-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed DBCP-508. - Resolution: Fixed Fix Version/s: 2.5.0 In git master. > Prepared statement keys should take a Connection's schema into account > -- > > Key: DBCP-508 > URL: https://issues.apache.org/jira/browse/DBCP-508 > Project: Commons DBCP > Issue Type: Improvement >Reporter: Gary Gregory >Assignee: Gary Gregory >Priority: Major > Fix For: 2.5.0 > > > Prepared statement keys should take a Connection's schema into account. This > allows prepared statements to be uniquely identified. > This affects the class {{PStmtKey}} used to manage pools of prepared > statement. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (COLLECTIONS-687) Moved tests from JUnit 3 to JUnit 4 nomenclature
Stephan Fuhrmann created COLLECTIONS-687: Summary: Moved tests from JUnit 3 to JUnit 4 nomenclature Key: COLLECTIONS-687 URL: https://issues.apache.org/jira/browse/COLLECTIONS-687 Project: Commons Collections Issue Type: Improvement Reporter: Stephan Fuhrmann This pull request moves many JUnit 3 tests to JUnit 4 nomenclature. Actually this was the easy part without base class usage of {{src/test/java/org/apache/commons/collections4/BulkTest.java}}. *Verified?* I verified that the tests in master branch and this PR are the same: {{[INFO] Tests run: 24589, Failures: 0, Errors: 0, Skipped: 0}} *Numbers* Here are some numbers to show the reduction. master branch: {{$ grep "extends TestCase" * -R|grep java:|wc -l 8 }} JUnit4 branch: {{$ grep "extends TestCase" * -R|grep java:|wc -l 1}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COLLECTIONS-687) Moved tests from JUnit 3 to JUnit 4 nomenclature
[ https://issues.apache.org/jira/browse/COLLECTIONS-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518502#comment-16518502 ] ASF GitHub Bot commented on COLLECTIONS-687: Github user coveralls commented on the issue: https://github.com/apache/commons-collections/pull/44 [![Coverage Status](https://coveralls.io/builds/17597721/badge)](https://coveralls.io/builds/17597721) Coverage decreased (-0.007%) to 87.386% when pulling **4702e747323690ecba6bb3a80940b4a2c1aebce1 on sfuhrm:JUnit4** into **11eca16f4a8b2e22c7271cae1fe9f23608bfb98e on apache:master**. > Moved tests from JUnit 3 to JUnit 4 nomenclature > > > Key: COLLECTIONS-687 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-687 > Project: Commons Collections > Issue Type: Improvement >Reporter: Stephan Fuhrmann >Priority: Major > > This pull request moves many JUnit 3 tests to JUnit 4 nomenclature. > Actually this was the easy part without base class usage of > {{src/test/java/org/apache/commons/collections4/BulkTest.java}}. > *Verified?* > I verified that the tests in master branch and this PR are the same: > {{[INFO] Tests run: 24589, Failures: 0, Errors: 0, Skipped: 0}} > *Numbers* > Here are some numbers to show the reduction. > master branch: > {{$ grep "extends TestCase" * -R|grep java:|wc -l 8 }} > JUnit4 branch: > {{$ grep "extends TestCase" * -R|grep java:|wc -l 1}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COLLECTIONS-687) Moved tests from JUnit 3 to JUnit 4 nomenclature
[ https://issues.apache.org/jira/browse/COLLECTIONS-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518584#comment-16518584 ] ASF GitHub Bot commented on COLLECTIONS-687: Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/44 > Moved tests from JUnit 3 to JUnit 4 nomenclature > > > Key: COLLECTIONS-687 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-687 > Project: Commons Collections > Issue Type: Improvement >Reporter: Stephan Fuhrmann >Priority: Major > > This pull request moves many JUnit 3 tests to JUnit 4 nomenclature. > Actually this was the easy part without base class usage of > {{src/test/java/org/apache/commons/collections4/BulkTest.java}}. > *Verified?* > I verified that the tests in master branch and this PR are the same: > {{[INFO] Tests run: 24589, Failures: 0, Errors: 0, Skipped: 0}} > *Numbers* > Here are some numbers to show the reduction. > master branch: > {{$ grep "extends TestCase" * -R|grep java:|wc -l 8 }} > JUnit4 branch: > {{$ grep "extends TestCase" * -R|grep java:|wc -l 1}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COLLECTIONS-687) Moved tests from JUnit 3 to JUnit 4 nomenclature
[ https://issues.apache.org/jira/browse/COLLECTIONS-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518585#comment-16518585 ] ASF GitHub Bot commented on COLLECTIONS-687: Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/44 > Moved tests from JUnit 3 to JUnit 4 nomenclature > > > Key: COLLECTIONS-687 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-687 > Project: Commons Collections > Issue Type: Improvement >Reporter: Stephan Fuhrmann >Priority: Major > > This pull request moves many JUnit 3 tests to JUnit 4 nomenclature. > Actually this was the easy part without base class usage of > {{src/test/java/org/apache/commons/collections4/BulkTest.java}}. > *Verified?* > I verified that the tests in master branch and this PR are the same: > {{[INFO] Tests run: 24589, Failures: 0, Errors: 0, Skipped: 0}} > *Numbers* > Here are some numbers to show the reduction. > master branch: > {{$ grep "extends TestCase" * -R|grep java:|wc -l 8 }} > JUnit4 branch: > {{$ grep "extends TestCase" * -R|grep java:|wc -l 1}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (COLLECTIONS-687) Moved tests from JUnit 3 to JUnit 4 nomenclature
[ https://issues.apache.org/jira/browse/COLLECTIONS-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Fuhrmann updated COLLECTIONS-687: - Description: This pull request moves many JUnit 3 tests to JUnit 4 nomenclature. Actually this was the easy part without base class usage of {{src/test/java/org/apache/commons/collections4/BulkTest.java}}. *Verified?* I verified that the tests in master branch and this PR are the same: {{[INFO] Tests run: 24589, Failures: 0, Errors: 0, Skipped: 0}} *Numbers* Here are some numbers to show the reduction. master branch: {{$ grep "extends TestCase" * -R|grep java:|wc -l}} {{8 }} JUnit4 branch: $ grep "extends TestCase" * -R|grep java:|wc -l 1 was: This pull request moves many JUnit 3 tests to JUnit 4 nomenclature. Actually this was the easy part without base class usage of {{src/test/java/org/apache/commons/collections4/BulkTest.java}}. *Verified?* I verified that the tests in master branch and this PR are the same: {{[INFO] Tests run: 24589, Failures: 0, Errors: 0, Skipped: 0}} *Numbers* Here are some numbers to show the reduction. master branch: {{$ grep "extends TestCase" * -R|grep java:|wc -l 8 }} JUnit4 branch: {{$ grep "extends TestCase" * -R|grep java:|wc -l 1}} > Moved tests from JUnit 3 to JUnit 4 nomenclature > > > Key: COLLECTIONS-687 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-687 > Project: Commons Collections > Issue Type: Improvement >Reporter: Stephan Fuhrmann >Priority: Major > > This pull request moves many JUnit 3 tests to JUnit 4 nomenclature. > Actually this was the easy part without base class usage of > {{src/test/java/org/apache/commons/collections4/BulkTest.java}}. > *Verified?* > I verified that the tests in master branch and this PR are the same: > {{[INFO] Tests run: 24589, Failures: 0, Errors: 0, Skipped: 0}} > *Numbers* > Here are some numbers to show the reduction. > master branch: > {{$ grep "extends TestCase" * -R|grep java:|wc -l}} > {{8 }} > JUnit4 branch: > $ grep "extends TestCase" * -R|grep java:|wc -l > 1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (COLLECTIONS-687) Moved tests from JUnit 3 to JUnit 4 nomenclature
[ https://issues.apache.org/jira/browse/COLLECTIONS-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518586#comment-16518586 ] Gary Gregory commented on COLLECTIONS-687: -- Patch applied, thank you. I am leaving this ticket open assuming there is more coming. > Moved tests from JUnit 3 to JUnit 4 nomenclature > > > Key: COLLECTIONS-687 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-687 > Project: Commons Collections > Issue Type: Improvement >Reporter: Stephan Fuhrmann >Priority: Major > > This pull request moves many JUnit 3 tests to JUnit 4 nomenclature. > Actually this was the easy part without base class usage of > {{src/test/java/org/apache/commons/collections4/BulkTest.java}}. > *Verified?* > I verified that the tests in master branch and this PR are the same: > {{[INFO] Tests run: 24589, Failures: 0, Errors: 0, Skipped: 0}} > *Numbers* > Here are some numbers to show the reduction. > master branch: > {{$ grep "extends TestCase" * -R|grep java:|wc -l 8 }} > JUnit4 branch: > {{$ grep "extends TestCase" * -R|grep java:|wc -l 1}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] commons-lang issue #334: Code refactoring and cleaning
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/334 @kinow Changes to throws declaration are binary compatible (see: https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html#jls-13.4.21). Removing checked exceptions from a throws declaration is source incompatible, but removing unchecked exceptions is source compatible. This confirmed by this pull request passing the clirr check (see: https://travis-ci.org/apache/commons-lang/jobs/394527557#L3097) ---
[jira] [Commented] (BEANUTILS-500) Upgrade from Apache Commons Collections 3 to 4
[ https://issues.apache.org/jira/browse/BEANUTILS-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518693#comment-16518693 ] Gary Gregory commented on BEANUTILS-500: Soon-ish. I'd like to push out Commons Pool and Commons Collections first. > Upgrade from Apache Commons Collections 3 to 4 > -- > > Key: BEANUTILS-500 > URL: https://issues.apache.org/jira/browse/BEANUTILS-500 > Project: Commons BeanUtils > Issue Type: Improvement > Components: Bean / Property Utils >Affects Versions: 2.0.0 >Reporter: Dave Brosius >Priority: Minor > Fix For: 2.0.0 > > Attachments: BEANUTILS-500.2.txt, BEANUTILS-500.3.txt, > BEANUTILS-500.txt > > > uptake commons-collections4. > The main difference is the removal of 'FastHashMap', and replacement with > ConcurrentHashMap. > There are a few breaking changes for deprecated methods that return a > FastHashMap, that are exposed. > I made them package private, and undeprecated them, thus 2.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)