[jira] [Work logged] (LANG-1617) Improve/clean math package
[ https://issues.apache.org/jira/browse/LANG-1617?focusedWorklogId=515103=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515103 ] ASF GitHub Bot logged work on LANG-1617: Author: ASF GitHub Bot Created on: 21/Nov/20 17:18 Start Date: 21/Nov/20 17:18 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #659: URL: https://github.com/apache/commons-lang/pull/659#issuecomment-731607699 [](https://coveralls.io/builds/35145871) Coverage decreased (-0.008%) to 94.98% when pulling **23b403885ba14d6a988d2d8ac513ca9d10e6994a on arturobernalg:feature/LANG-1617** into **764b9bba528487fb575b84766998086c24bb1f48 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 515103) Time Spent: 0.5h (was: 20m) > Improve/clean math package > --- > > Key: LANG-1617 > URL: https://issues.apache.org/jira/browse/LANG-1617 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Arturo Bernal >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Improve the class in the org.apache.commons.lang3.math opackage -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #659: LANG-1617 - Improve/clean math package
coveralls commented on pull request #659: URL: https://github.com/apache/commons-lang/pull/659#issuecomment-731607699 [](https://coveralls.io/builds/35145871) Coverage decreased (-0.008%) to 94.98% when pulling **23b403885ba14d6a988d2d8ac513ca9d10e6994a on arturobernalg:feature/LANG-1617** into **764b9bba528487fb575b84766998086c24bb1f48 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] garydgregory commented on pull request #8: Bump maven-scm-publish-plugin from 1.0-beta-2 to 3.0.0
garydgregory commented on pull request #8: URL: https://github.com/apache/commons-digester/pull/8#issuecomment-731607513 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] garydgregory commented on pull request #9: Bump cglib from 3.2.5 to 3.3.0
garydgregory commented on pull request #9: URL: https://github.com/apache/commons-digester/pull/9#issuecomment-731607495 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] garydgregory commented on pull request #11: Bump exec-maven-plugin from 1.1 to 3.0.0
garydgregory commented on pull request #11: URL: https://github.com/apache/commons-digester/pull/11#issuecomment-731607440 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] garydgregory commented on pull request #10: Bump maven-javadoc-plugin from 2.8 to 3.2.0
garydgregory commented on pull request #10: URL: https://github.com/apache/commons-digester/pull/10#issuecomment-731607451 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] garydgregory commented on pull request #12: Bump maven-deploy-plugin from 2.7 to 2.8.2
garydgregory commented on pull request #12: URL: https://github.com/apache/commons-digester/pull/12#issuecomment-731607405 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1617) Improve/clean math package
[
https://issues.apache.org/jira/browse/LANG-1617?focusedWorklogId=515102=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515102
]
ASF GitHub Bot logged work on LANG-1617:
Author: ASF GitHub Bot
Created on: 21/Nov/20 17:11
Start Date: 21/Nov/20 17:11
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #659:
URL: https://github.com/apache/commons-lang/pull/659#discussion_r528219181
##
File path: src/main/java/org/apache/commons/lang3/math/NumberUtils.java
##
@@ -32,43 +32,43 @@
public class NumberUtils {
/** Reusable Long constant for zero. */
-public static final Long LONG_ZERO = Long.valueOf(0L);
+public static final Long LONG_ZERO = 0L;
/** Reusable Long constant for one. */
-public static final Long LONG_ONE = Long.valueOf(1L);
+public static final Long LONG_ONE = 1L;
/** Reusable Long constant for minus one. */
-public static final Long LONG_MINUS_ONE = Long.valueOf(-1L);
+public static final Long LONG_MINUS_ONE = -1L;
/** Reusable Integer constant for zero. */
-public static final Integer INTEGER_ZERO = Integer.valueOf(0);
+public static final Integer INTEGER_ZERO = 0;
/** Reusable Integer constant for one. */
-public static final Integer INTEGER_ONE = Integer.valueOf(1);
+public static final Integer INTEGER_ONE = 1;
/** Reusable Integer constant for two */
-public static final Integer INTEGER_TWO = Integer.valueOf(2);
+public static final Integer INTEGER_TWO = 2;
/** Reusable Integer constant for minus one. */
-public static final Integer INTEGER_MINUS_ONE = Integer.valueOf(-1);
+public static final Integer INTEGER_MINUS_ONE = -1;
/** Reusable Short constant for zero. */
-public static final Short SHORT_ZERO = Short.valueOf((short) 0);
+public static final Short SHORT_ZERO = (short) 0;
/** Reusable Short constant for one. */
-public static final Short SHORT_ONE = Short.valueOf((short) 1);
+public static final Short SHORT_ONE = (short) 1;
/** Reusable Short constant for minus one. */
-public static final Short SHORT_MINUS_ONE = Short.valueOf((short) -1);
+public static final Short SHORT_MINUS_ONE = (short) -1;
/** Reusable Byte constant for zero. */
-public static final Byte BYTE_ZERO = Byte.valueOf((byte) 0);
+public static final Byte BYTE_ZERO = (byte) 0;
/** Reusable Byte constant for one. */
-public static final Byte BYTE_ONE = Byte.valueOf((byte) 1);
+public static final Byte BYTE_ONE = (byte) 1;
/** Reusable Byte constant for minus one. */
-public static final Byte BYTE_MINUS_ONE = Byte.valueOf((byte) -1);
+public static final Byte BYTE_MINUS_ONE = (byte) -1;
/** Reusable Double constant for zero. */
-public static final Double DOUBLE_ZERO = Double.valueOf(0.0d);
+public static final Double DOUBLE_ZERO = 0.0d;
/** Reusable Double constant for one. */
-public static final Double DOUBLE_ONE = Double.valueOf(1.0d);
+public static final Double DOUBLE_ONE = 1.0d;
Review comment:
Hi @arturobernalg
Thank you for your PR.
-1: For low-level libraries like most Apache Commons libraries, I like to
keep boxing and unboxing explicit to make it easier to understand where objects
are created and unwrapped.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 515102)
Time Spent: 20m (was: 10m)
> Improve/clean math package
> ---
>
> Key: LANG-1617
> URL: https://issues.apache.org/jira/browse/LANG-1617
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.math.*
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Improve the class in the org.apache.commons.lang3.math opackage
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] garydgregory commented on a change in pull request #659: LANG-1617 - Improve/clean math package
garydgregory commented on a change in pull request #659:
URL: https://github.com/apache/commons-lang/pull/659#discussion_r528219181
##
File path: src/main/java/org/apache/commons/lang3/math/NumberUtils.java
##
@@ -32,43 +32,43 @@
public class NumberUtils {
/** Reusable Long constant for zero. */
-public static final Long LONG_ZERO = Long.valueOf(0L);
+public static final Long LONG_ZERO = 0L;
/** Reusable Long constant for one. */
-public static final Long LONG_ONE = Long.valueOf(1L);
+public static final Long LONG_ONE = 1L;
/** Reusable Long constant for minus one. */
-public static final Long LONG_MINUS_ONE = Long.valueOf(-1L);
+public static final Long LONG_MINUS_ONE = -1L;
/** Reusable Integer constant for zero. */
-public static final Integer INTEGER_ZERO = Integer.valueOf(0);
+public static final Integer INTEGER_ZERO = 0;
/** Reusable Integer constant for one. */
-public static final Integer INTEGER_ONE = Integer.valueOf(1);
+public static final Integer INTEGER_ONE = 1;
/** Reusable Integer constant for two */
-public static final Integer INTEGER_TWO = Integer.valueOf(2);
+public static final Integer INTEGER_TWO = 2;
/** Reusable Integer constant for minus one. */
-public static final Integer INTEGER_MINUS_ONE = Integer.valueOf(-1);
+public static final Integer INTEGER_MINUS_ONE = -1;
/** Reusable Short constant for zero. */
-public static final Short SHORT_ZERO = Short.valueOf((short) 0);
+public static final Short SHORT_ZERO = (short) 0;
/** Reusable Short constant for one. */
-public static final Short SHORT_ONE = Short.valueOf((short) 1);
+public static final Short SHORT_ONE = (short) 1;
/** Reusable Short constant for minus one. */
-public static final Short SHORT_MINUS_ONE = Short.valueOf((short) -1);
+public static final Short SHORT_MINUS_ONE = (short) -1;
/** Reusable Byte constant for zero. */
-public static final Byte BYTE_ZERO = Byte.valueOf((byte) 0);
+public static final Byte BYTE_ZERO = (byte) 0;
/** Reusable Byte constant for one. */
-public static final Byte BYTE_ONE = Byte.valueOf((byte) 1);
+public static final Byte BYTE_ONE = (byte) 1;
/** Reusable Byte constant for minus one. */
-public static final Byte BYTE_MINUS_ONE = Byte.valueOf((byte) -1);
+public static final Byte BYTE_MINUS_ONE = (byte) -1;
/** Reusable Double constant for zero. */
-public static final Double DOUBLE_ZERO = Double.valueOf(0.0d);
+public static final Double DOUBLE_ZERO = 0.0d;
/** Reusable Double constant for one. */
-public static final Double DOUBLE_ONE = Double.valueOf(1.0d);
+public static final Double DOUBLE_ONE = 1.0d;
Review comment:
Hi @arturobernalg
Thank you for your PR.
-1: For low-level libraries like most Apache Commons libraries, I like to
keep boxing and unboxing explicit to make it easier to understand where objects
are created and unwrapped.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (LANG-1617) Improve/clean math package
[ https://issues.apache.org/jira/browse/LANG-1617?focusedWorklogId=515101=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515101 ] ASF GitHub Bot logged work on LANG-1617: Author: ASF GitHub Bot Created on: 21/Nov/20 17:08 Start Date: 21/Nov/20 17:08 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #659: URL: https://github.com/apache/commons-lang/pull/659 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 515101) Remaining Estimate: 0h Time Spent: 10m > Improve/clean math package > --- > > Key: LANG-1617 > URL: https://issues.apache.org/jira/browse/LANG-1617 > Project: Commons Lang > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Improve the class in the org.apache.commons.lang3.math opackage -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1617) Improve/clean math package
[ https://issues.apache.org/jira/browse/LANG-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated LANG-1617: Component/s: lang.math.* > Improve/clean math package > --- > > Key: LANG-1617 > URL: https://issues.apache.org/jira/browse/LANG-1617 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* >Reporter: Arturo Bernal >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Improve the class in the org.apache.commons.lang3.math opackage -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] arturobernalg opened a new pull request #659: LANG-1617 - Improve/clean math package
arturobernalg opened a new pull request #659: URL: https://github.com/apache/commons-lang/pull/659 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] garydgregory commented on pull request #5: junit v4.13.1
garydgregory commented on pull request #5: URL: https://github.com/apache/commons-digester/pull/5#issuecomment-731606338 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] garydgregory commented on pull request #8: Bump maven-scm-publish-plugin from 1.0-beta-2 to 3.0.0
garydgregory commented on pull request #8: URL: https://github.com/apache/commons-digester/pull/8#issuecomment-731606309 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] garydgregory commented on pull request #9: Bump cglib from 3.2.5 to 3.3.0
garydgregory commented on pull request #9: URL: https://github.com/apache/commons-digester/pull/9#issuecomment-731606287 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] garydgregory commented on pull request #10: Bump maven-javadoc-plugin from 2.8 to 3.2.0
garydgregory commented on pull request #10: URL: https://github.com/apache/commons-digester/pull/10#issuecomment-731606270 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] garydgregory commented on pull request #11: Bump exec-maven-plugin from 1.1 to 3.0.0
garydgregory commented on pull request #11: URL: https://github.com/apache/commons-digester/pull/11#issuecomment-731606254 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] garydgregory commented on pull request #12: Bump maven-deploy-plugin from 2.7 to 2.8.2
garydgregory commented on pull request #12: URL: https://github.com/apache/commons-digester/pull/12#issuecomment-731606243 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (LANG-1617) Improve/clean math package
Arturo Bernal created LANG-1617: --- Summary: Improve/clean math package Key: LANG-1617 URL: https://issues.apache.org/jira/browse/LANG-1617 Project: Commons Lang Issue Type: Improvement Reporter: Arturo Bernal Improve the class in the org.apache.commons.lang3.math opackage -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (DIGESTER-194) Update Java requirement from version 6 to 7
[ https://issues.apache.org/jira/browse/DIGESTER-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved DIGESTER-194. -- Fix Version/s: 3.3 Resolution: Fixed > Update Java requirement from version 6 to 7 > --- > > Key: DIGESTER-194 > URL: https://issues.apache.org/jira/browse/DIGESTER-194 > Project: Commons Digester > Issue Type: Bug >Reporter: Gary D. Gregory >Assignee: Gary D. Gregory >Priority: Major > Fix For: 3.3 > > > Update Java requirement from version 6 to 7 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (DIGESTER-194) Update Java requirement from version 6 to 7
Gary D. Gregory created DIGESTER-194: Summary: Update Java requirement from version 6 to 7 Key: DIGESTER-194 URL: https://issues.apache.org/jira/browse/DIGESTER-194 Project: Commons Digester Issue Type: Bug Reporter: Gary D. Gregory Assignee: Gary D. Gregory Update Java requirement from version 6 to 7 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (LANG-1535) Add containsAnyIgnoreCase() function to StringUtils.
[ https://issues.apache.org/jira/browse/LANG-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236720#comment-17236720 ] Arturo Bernal edited comment on LANG-1535 at 11/21/20, 4:59 PM: [~ggregory] Already implemented. [https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/StringUtils.java#L1178] Can close the PR was (Author: arturobernalg): @garydgregory Already implemented. https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/StringUtils.java#L1178 Can close the PR > Add containsAnyIgnoreCase() function to StringUtils. > > > Key: LANG-1535 > URL: https://issues.apache.org/jira/browse/LANG-1535 > Project: Commons Lang > Issue Type: New Feature > Components: lang.* >Reporter: Isira Seneviratne >Priority: Major > Fix For: 3.12 > > Time Spent: 1h > Remaining Estimate: 0h > > Add a containsAnyIgnoreCase() static function to StringUtils that checks > whether the provided CharSequence contains one or more of the CharSequences > to be found, regardless of case. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-validator] garydgregory merged pull request #44: Bump junit from 4.13 to 4.13.1
garydgregory merged pull request #44: URL: https://github.com/apache/commons-validator/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-validator] garydgregory commented on pull request #44: Bump junit from 4.13 to 4.13.1
garydgregory commented on pull request #44: URL: https://github.com/apache/commons-validator/pull/44#issuecomment-731604835 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-validator] garydgregory commented on pull request #44: Bump junit from 4.13 to 4.13.1
garydgregory commented on pull request #44: URL: https://github.com/apache/commons-validator/pull/44#issuecomment-731604338 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-validator] garydgregory merged pull request #47: Bump actions/checkout from v2.3.2 to v2.3.4
garydgregory merged pull request #47: URL: https://github.com/apache/commons-validator/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (LANG-1535) Add containsAnyIgnoreCase() function to StringUtils.
[ https://issues.apache.org/jira/browse/LANG-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236720#comment-17236720 ] Arturo Bernal commented on LANG-1535: - @garydgregory Already implemented. https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/StringUtils.java#L1178 Can close the PR > Add containsAnyIgnoreCase() function to StringUtils. > > > Key: LANG-1535 > URL: https://issues.apache.org/jira/browse/LANG-1535 > Project: Commons Lang > Issue Type: New Feature > Components: lang.* >Reporter: Isira Seneviratne >Priority: Major > Fix For: 3.12 > > Time Spent: 1h > Remaining Estimate: 0h > > Add a containsAnyIgnoreCase() static function to StringUtils that checks > whether the provided CharSequence contains one or more of the CharSequences > to be found, regardless of case. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1535) Add containsAnyIgnoreCase() function to StringUtils.
[ https://issues.apache.org/jira/browse/LANG-1535?focusedWorklogId=515098=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515098 ] ASF GitHub Bot logged work on LANG-1535: Author: ASF GitHub Bot Created on: 21/Nov/20 16:44 Start Date: 21/Nov/20 16:44 Worklog Time Spent: 10m Work Description: arturobernalg commented on pull request #510: URL: https://github.com/apache/commons-lang/pull/510#issuecomment-731603366 @garydgregory Already implemented. https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/StringUtils.java#L1178 Can close the PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 515098) Time Spent: 1h (was: 50m) > Add containsAnyIgnoreCase() function to StringUtils. > > > Key: LANG-1535 > URL: https://issues.apache.org/jira/browse/LANG-1535 > Project: Commons Lang > Issue Type: New Feature > Components: lang.* >Reporter: Isira Seneviratne >Priority: Major > Fix For: 3.12 > > Time Spent: 1h > Remaining Estimate: 0h > > Add a containsAnyIgnoreCase() static function to StringUtils that checks > whether the provided CharSequence contains one or more of the CharSequences > to be found, regardless of case. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-validator] garydgregory merged pull request #42: Bump actions/setup-java from v1.4.0 to v1.4.3
garydgregory merged pull request #42: URL: https://github.com/apache/commons-validator/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] opened a new pull request #8: Bump maven-scm-publish-plugin from 1.0-beta-2 to 3.0.0
dependabot[bot] opened a new pull request #8: URL: https://github.com/apache/commons-digester/pull/8 Bumps [maven-scm-publish-plugin](https://github.com/apache/maven-scm-publish-plugin) from 1.0-beta-2 to 3.0.0. Commits See full diff in https://github.com/apache/maven-scm-publish-plugin/commits/maven-scm-publish-plugin-3.0.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] opened a new pull request #9: Bump cglib from 3.2.5 to 3.3.0
dependabot[bot] opened a new pull request #9: URL: https://github.com/apache/commons-digester/pull/9 Bumps [cglib](https://github.com/cglib/cglib) from 3.2.5 to 3.3.0. Release notes Sourced from https://github.com/cglib/cglib/releases;>cglib's releases. cglib 3.3.0 emits code compatible with java 1.8, so we can call static interface methods. cglib 3.2.9 Update ASM version to 7.0 cglib 3.2.8 Update ASM version to 6.2.1 Allow net.sf.cglib.experimental_asm7 system property to use experiment asm7 mode. Expose non-bridge methods more frequently. cglib 3.2.7 Update ASM version to 6.2. Drop support for Java6. (It may continue to work, but continuous integration tests will no longer validate it does.) cglib 3.2.6 Fix https://github-redirect.dependabot.com/cglib/cglib/issues/115;>#115: Release resources eagerly. Update ASM version to 6.0 Commits See full diff in https://github.com/cglib/cglib/commits;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] opened a new pull request #12: Bump maven-deploy-plugin from 2.7 to 2.8.2
dependabot[bot] opened a new pull request #12: URL: https://github.com/apache/commons-digester/pull/12 Bumps maven-deploy-plugin from 2.7 to 2.8.2. [](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] opened a new pull request #10: Bump maven-javadoc-plugin from 2.8 to 3.2.0
dependabot[bot] opened a new pull request #10: URL: https://github.com/apache/commons-digester/pull/10 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 2.8 to 3.2.0. Commits https://github.com/apache/maven-javadoc-plugin/commit/d3b77d6e1bbd079a0d5d0659a183871b3f638c53;>d3b77d6 [maven-release-plugin] prepare release maven-javadoc-plugin-3.2.0 https://github.com/apache/maven-javadoc-plugin/commit/41bc516c85cdd832a521f3acc64128533139e0af;>41bc516 back to 3.2.0-SNAPSHOT https://github.com/apache/maven-javadoc-plugin/commit/819cf1eb954952c3a194d3973e5d416b592db1bc;>819cf1e [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-javadoc-plugin/commit/45f4b3e6b501ac05d99e529fc1abdaa4edf32b1b;>45f4b3e [maven-release-plugin] prepare release maven-javadoc-plugin-3.2.0 https://github.com/apache/maven-javadoc-plugin/commit/d772fce836c44fb64bd67b103cb839c2de213bb4;>d772fce MJAVADOC-610 Add IT test for multirelease jar https://github.com/apache/maven-javadoc-plugin/commit/37d0ef59000410a0e33e0cd3fc48fe727ab76108;>37d0ef5 [MJAVADOC-638] upgrade Doxia Sitetools to 1.9.2 to remove dependency on Strut... https://github.com/apache/maven-javadoc-plugin/commit/528ce30dae9932c153f11b834f1e3450a06c14c6;>528ce30 [MJAVADOC-639] Switch to Oracle OpenJDK 11 compatible jar, see MJAVADOC-610 https://github.com/apache/maven-javadoc-plugin/commit/405b16dc1de312d31f8a4f31c1cf8a07db3220eb;>405b16d [MJAVADOC-639] include requires static from external dependencies for all mod... https://github.com/apache/maven-javadoc-plugin/commit/aaa200709beef93a57af399a7247410f027c6962;>aaa2007 [MJAVADOC-637] make build Reproducible https://github.com/apache/maven-javadoc-plugin/commit/7bfa76d3b9bdf61cb78152292420843a15b7bd76;>7bfa76d [MJAVADOC-636] exclude some modules from aggregated javadoc Additional commits viewable in https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-2.8...maven-javadoc-plugin-3.2.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] opened a new pull request #11: Bump exec-maven-plugin from 1.1 to 3.0.0
dependabot[bot] opened a new pull request #11:
URL: https://github.com/apache/commons-digester/pull/11
Bumps [exec-maven-plugin](https://github.com/mojohaus/exec-maven-plugin)
from 1.1 to 3.0.0.
Release notes
Sourced from https://github.com/mojohaus/exec-maven-plugin/releases;>exec-maven-plugin's
releases.
exec-maven-plugin-3.0.0
Bug Fixes
Resolving target dir via
${project.build.directory}, so to make s… https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/pull/124;>#124
Ensure mojo descriptors are extracted after compilation https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/pull/123;>#123
Argument file for modulepath is generated wrongly when paths contains
spaces https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/issues/115;>#115
java.lang.String cannot be cast to org.codehaus.mojo.exec.Modulepath https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/issues/75;>#75
⭐ Enhancement
Resolves https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/issues/152;>#152
- Adds option to redirect program output of exec:exec to the maven logger. https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/pull/153;>#153
Program output can be difficult to trace and may be jumbled with Maven
logs when running Maven with multiple threads https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/issues/152;>#152
Fix type in Property.java https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/pull/147;>#147
Correct spelling and remove redundant small https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/pull/142;>#142
Fix typo https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/pull/140;>#140
timeout configuration parameter https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/issues/128;>#128
Methodhandles https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/pull/119;>#119
Introduce Mock Repository Manager https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/pull/117;>#117
Improved docs about environmentVariables/ config of exec:exec
goal https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/pull/104;>#104
Add CodeTriage badge to mojohaus/exec-maven-plugin https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/pull/96;>#96
[Enhancement] Support for JPMS module path for exec:java https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/issues/90;>#90
:heart: Contributors
We'd like to thank all the contributors who worked on this release!
https://github.com/elharo;>@elharo
https://github.com/britter;>@britter
https://github.com/stokito;>@stokito
https://github.com/hankolerd;>@hankolerd
https://github.com/rfscholte;>@rfscholte
https://github.com/gaurav9822;>@gaurav9822
https://github.com/codetriage-readme-bot;>@codetriage-readme-bot
Commits
https://github.com/mojohaus/exec-maven-plugin/commit/9705839246711bd375bf7712df05c621b168fbb1;>9705839
[maven-release-plugin] prepare release exec-maven-plugin-3.0.0
https://github.com/mojohaus/exec-maven-plugin/commit/66563e6891ce812a189d649352f4a0ac95e57050;>66563e6
get this working with java11
https://github.com/mojohaus/exec-maven-plugin/commit/13d1369e039f0f75e2d565a903368dbd5b2c20af;>13d1369
Merge pull request https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/issues/153;>#153
from hankolerd/master
https://github.com/mojohaus/exec-maven-plugin/commit/7935062de951ab332cd50fbc05d8ab2070d2b205;>7935062
152 - Adds option to redirect program output of exec:exec to the maven
logger.
https://github.com/mojohaus/exec-maven-plugin/commit/dbe2c733dd3ae9728ac35f76ec05472444e7b13e;>dbe2c73
use mojo parent 50
https://github.com/mojohaus/exec-maven-plugin/commit/c7c3fe36232003f19d8e5d2109e4f7ab4f3c4546;>c7c3fe3
Merge pull request https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/issues/142;>#142
from elharo/patch-1
https://github.com/mojohaus/exec-maven-plugin/commit/1bb783822860c78e9daf8c7155f3ad2d1814a51d;>1bb7838
Merge pull request https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/issues/140;>#140
from britter/patch-1
https://github.com/mojohaus/exec-maven-plugin/commit/0a9b9cb33a0aa3062c258c695af4eed6fea72f22;>0a9b9cb
Merge pull request https://github-redirect.dependabot.com/mojohaus/exec-maven-plugin/issues/147;>#147
from gaurav9822/master
https://github.com/mojohaus/exec-maven-plugin/commit/581e6ed87b1e4ac3d9fa0abdab85275d60983626;>581e6ed
Added OpenJDK 14
https://github.com/mojohaus/exec-maven-plugin/commit/52d75dc2744669e76f568759df6ba34f6d308aaa;>52d75dc
Update Property.java
Additional commits viewable in https://github.com/mojohaus/exec-maven-plugin/compare/exec-maven-plugin-1.1...exec-maven-plugin-3.0.0;>compare
view
[![Dependabot
[GitHub] [commons-lang] arturobernalg commented on pull request #510: [LANG-1535] Add containsAnyIgnoreCase() method to StringUtils.
arturobernalg commented on pull request #510: URL: https://github.com/apache/commons-lang/pull/510#issuecomment-731603366 @garydgregory Already implemented. https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/StringUtils.java#L1178 Can close the PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] garydgregory merged pull request #46: Bump mockito-core from 3.4.6 to 3.6.0
garydgregory merged pull request #46: URL: https://github.com/apache/commons-dbutils/pull/46 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] garydgregory merged pull request #47: Bump checkstyle from 8.35 to 8.37
garydgregory merged pull request #47: URL: https://github.com/apache/commons-dbutils/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] garydgregory merged pull request #40: Bump actions/setup-java from v1.4.0 to v1.4.3
garydgregory merged pull request #40: URL: https://github.com/apache/commons-dbutils/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] garydgregory merged pull request #45: Bump spotbugs-maven-plugin from 4.0.4 to 4.1.4
garydgregory merged pull request #45: URL: https://github.com/apache/commons-dbutils/pull/45 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] garydgregory merged pull request #42: Bump junit from 4.13 to 4.13.1
garydgregory merged pull request #42: URL: https://github.com/apache/commons-dbutils/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] garydgregory merged pull request #48: Bump actions/checkout from v2.3.2 to v2.3.4
garydgregory merged pull request #48: URL: https://github.com/apache/commons-dbutils/pull/48 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-cli] garydgregory merged pull request #50: Bump actions/setup-java from v1.4.2 to v1.4.3
garydgregory merged pull request #50: URL: https://github.com/apache/commons-cli/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-cli] garydgregory merged pull request #52: Bump junit from 4.13 to 4.13.1
garydgregory merged pull request #52: URL: https://github.com/apache/commons-cli/pull/52 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-cli] garydgregory merged pull request #53: Bump actions/checkout from v2.3.2 to v2.3.4
garydgregory merged pull request #53: URL: https://github.com/apache/commons-cli/pull/53 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] garydgregory commented on pull request #5: Maven commons-parent 49
garydgregory commented on pull request #5: URL: https://github.com/apache/commons-exec/pull/5#issuecomment-731599892 Closing; commons-parent is currently set to 52. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] garydgregory closed pull request #5: Maven commons-parent 49
garydgregory closed pull request #5: URL: https://github.com/apache/commons-exec/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] garydgregory merged pull request #23: Bump junit from 4.13 to 4.13.1
garydgregory merged pull request #23: URL: https://github.com/apache/commons-exec/pull/23 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] garydgregory merged pull request #21: Bump actions/setup-java from v1.4.0 to v1.4.3
garydgregory merged pull request #21: URL: https://github.com/apache/commons-exec/pull/21 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] garydgregory merged pull request #24: Bump actions/checkout from v2.3.2 to v2.3.4
garydgregory merged pull request #24: URL: https://github.com/apache/commons-exec/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (GEOMETRY-102) Clirr failure
[ https://issues.apache.org/jira/browse/GEOMETRY-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236689#comment-17236689 ] Matt Juntunen commented on GEOMETRY-102: Disabled Clirr in commit c82e07f9ad3192a1822bc0bf09506db10d802d48. > Clirr failure > - > > Key: GEOMETRY-102 > URL: https://issues.apache.org/jira/browse/GEOMETRY-102 > Project: Apache Commons Geometry > Issue Type: Bug >Affects Versions: 1.0-beta2 >Reporter: Matt Juntunen >Priority: Major > > Commit 24549060f14521f322faa507fc157abd32061bc7 broke the Travis build by > reducing the visibility of some abstract class constructors, causing Clirr to > fail. We likely need to update the Clirr configuration to ignore these > changes, unless some other option is available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEOMETRY-102) Clirr failure
[ https://issues.apache.org/jira/browse/GEOMETRY-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Juntunen resolved GEOMETRY-102. Resolution: Fixed > Clirr failure > - > > Key: GEOMETRY-102 > URL: https://issues.apache.org/jira/browse/GEOMETRY-102 > Project: Apache Commons Geometry > Issue Type: Bug >Affects Versions: 1.0-beta2 >Reporter: Matt Juntunen >Priority: Major > > Commit 24549060f14521f322faa507fc157abd32061bc7 broke the Travis build by > reducing the visibility of some abstract class constructors, causing Clirr to > fail. We likely need to update the Clirr configuration to ignore these > changes, unless some other option is available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEOMETRY-102) Clirr failure
[ https://issues.apache.org/jira/browse/GEOMETRY-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Juntunen closed GEOMETRY-102. -- > Clirr failure > - > > Key: GEOMETRY-102 > URL: https://issues.apache.org/jira/browse/GEOMETRY-102 > Project: Apache Commons Geometry > Issue Type: Bug >Affects Versions: 1.0-beta2 >Reporter: Matt Juntunen >Priority: Major > > Commit 24549060f14521f322faa507fc157abd32061bc7 broke the Travis build by > reducing the visibility of some abstract class constructors, causing Clirr to > fail. We likely need to update the Clirr configuration to ignore these > changes, unless some other option is available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-geometry] asfgit merged pull request #103: GEOMETRY-102: Disable Clirr
asfgit merged pull request #103: URL: https://github.com/apache/commons-geometry/pull/103 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #51: NET-685: change default connect timeout
garydgregory commented on pull request #51: URL: https://github.com/apache/commons-net/pull/51#issuecomment-731584798 @simo385 I am not opposed to the idea but note that `SocketClient` is an abstract class with many subclasses. I am worried that there are some unintended functional side-effects that this change will cause. Any thoughts from others? I suppose your workaround is to call `org.apache.commons.net.SocketClient.setConnectTimeout(int)`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #51: NET-685: change default connect timeout
garydgregory commented on pull request #51: URL: https://github.com/apache/commons-net/pull/51#issuecomment-731583402 https://issues.apache.org/jira/browse/NET-685 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1616) Add lastIndexOfAnyChar
[ https://issues.apache.org/jira/browse/LANG-1616?focusedWorklogId=515052=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515052 ] ASF GitHub Bot logged work on LANG-1616: Author: ASF GitHub Bot Created on: 21/Nov/20 13:42 Start Date: 21/Nov/20 13:42 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #658: URL: https://github.com/apache/commons-lang/pull/658#issuecomment-731569784 [](https://coveralls.io/builds/35144363) Coverage decreased (-0.001%) to 94.987% when pulling **adef04aea2cf088bc417fd771915e4cb5f6bc934 on arturobernalg:feature/LANG-1616** into **764b9bba528487fb575b84766998086c24bb1f48 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 515052) Time Spent: 1h (was: 50m) > Add lastIndexOfAnyChar > -- > > Key: LANG-1616 > URL: https://issues.apache.org/jira/browse/LANG-1616 > Project: Commons Lang > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1616) Add lastIndexOfAnyChar
[ https://issues.apache.org/jira/browse/LANG-1616?focusedWorklogId=515051=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515051 ] ASF GitHub Bot logged work on LANG-1616: Author: ASF GitHub Bot Created on: 21/Nov/20 13:41 Start Date: 21/Nov/20 13:41 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #658: URL: https://github.com/apache/commons-lang/pull/658#issuecomment-731569784 [](https://coveralls.io/builds/35144360) Coverage increased (+0.005%) to 94.993% when pulling **adef04aea2cf088bc417fd771915e4cb5f6bc934 on arturobernalg:feature/LANG-1616** into **764b9bba528487fb575b84766998086c24bb1f48 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 515051) Time Spent: 50m (was: 40m) > Add lastIndexOfAnyChar > -- > > Key: LANG-1616 > URL: https://issues.apache.org/jira/browse/LANG-1616 > Project: Commons Lang > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #658: [LANG-1616] - Add lastIndexOfAnyChar
coveralls edited a comment on pull request #658: URL: https://github.com/apache/commons-lang/pull/658#issuecomment-731569784 [](https://coveralls.io/builds/35144363) Coverage decreased (-0.001%) to 94.987% when pulling **adef04aea2cf088bc417fd771915e4cb5f6bc934 on arturobernalg:feature/LANG-1616** into **764b9bba528487fb575b84766998086c24bb1f48 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (LANG-1524) TypeUtils.toString StackOverflowError for an inner class in the inner class parameterized enclosing class.
[
https://issues.apache.org/jira/browse/LANG-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236552#comment-17236552
]
Aakash Gupta edited comment on LANG-1524 at 11/21/20, 1:41 PM:
---
Hi [~arturobernalg] [~ggregory]
I've raised a PR: [https://github.com/apache/commons-lang/pull/657/]
Could you please review it?
was (Author: aakashgupta96):
Hi [~arturobernalg] [~ggregory]
I would I've raised a PR: [https://github.com/apache/commons-lang/pull/657/]
Could you please review it?
> TypeUtils.toString StackOverflowError for an inner class in the inner class
> parameterized enclosing class.
> --
>
> Key: LANG-1524
> URL: https://issues.apache.org/jira/browse/LANG-1524
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.reflect.*
>Affects Versions: 3.9
>Reporter: kijong.youn
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> StackOverflowError occurred on toString for an inner class in the inner class
> parameterized enclosing class.
>
> source:
> {code:java}
> public class Test {
> public static class Inner {
> }
> public static void main(final String[] args) {
> System.out.println(TypeUtils.toString(Inner.class));
> }
> } {code}
> result:
> {code:java}
> Exception in thread "main" java.lang.StackOverflowErrorException in thread
> "main" java.lang.StackOverflowError at
> java.lang.Class.getEnclosingMethodInfo(Class.java:1072) at
> java.lang.Class.getEnclosingClass(Class.java:1272) at
> org.apache.commons.lang3.reflect.TypeUtils.classToString(TypeUtils.java:1751)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1663)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1891)
> at
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1882)
> at
> org.apache.commons.lang3.reflect.TypeUtils.typeVariableToString(TypeUtils.java:1775)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1672)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1891)
> at
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1882)
> at
> org.apache.commons.lang3.reflect.TypeUtils.classToString(TypeUtils.java:1758)
> at
> org.apache.commons.lang3.reflect.TypeUtils.classToString(TypeUtils.java:1752)
> ...{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #658: [LANG-1616] - Add lastIndexOfAnyChar
coveralls edited a comment on pull request #658: URL: https://github.com/apache/commons-lang/pull/658#issuecomment-731569784 [](https://coveralls.io/builds/35144360) Coverage increased (+0.005%) to 94.993% when pulling **adef04aea2cf088bc417fd771915e4cb5f6bc934 on arturobernalg:feature/LANG-1616** into **764b9bba528487fb575b84766998086c24bb1f48 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (LANG-1437) Remove redundant if statements in StringUtils.join
[
https://issues.apache.org/jira/browse/LANG-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Filip Troie closed LANG-1437.
> Remove redundant if statements in StringUtils.join
> --
>
> Key: LANG-1437
> URL: https://issues.apache.org/jira/browse/LANG-1437
> Project: Commons Lang
> Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Andrei Filip Troie
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In the various {{join}} methods in {{StringUtils}}, the for-loop contains an
> {{if (i > startIndex)}} check (for an example see
> [here|https://github.com/apache/commons-lang/blob/eb5b11a25c9e61f9b25a540682816ebb103b735c/src/main/java/org/apache/commons/lang3/StringUtils.java#L4203],
> but it's present in all the {{join}} methods that take an array).
> That is unnecessary - for the first iteration, we know the condition is
> false, while for the other iterations, we know the condition is true. So
> instead, we can do this:
> * append the first element (at position {{startIndex}})
> * for every other element (starting at position {{startIndex + 1}}), append
> the separator, then the element.
> It's basically the same tactic used in the {{Iterable}} version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (LANG-1437) Remove redundant if statements in StringUtils.join
[
https://issues.apache.org/jira/browse/LANG-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Filip Troie resolved LANG-1437.
--
Resolution: Fixed
> Remove redundant if statements in StringUtils.join
> --
>
> Key: LANG-1437
> URL: https://issues.apache.org/jira/browse/LANG-1437
> Project: Commons Lang
> Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Andrei Filip Troie
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In the various {{join}} methods in {{StringUtils}}, the for-loop contains an
> {{if (i > startIndex)}} check (for an example see
> [here|https://github.com/apache/commons-lang/blob/eb5b11a25c9e61f9b25a540682816ebb103b735c/src/main/java/org/apache/commons/lang3/StringUtils.java#L4203],
> but it's present in all the {{join}} methods that take an array).
> That is unnecessary - for the first iteration, we know the condition is
> false, while for the other iterations, we know the condition is true. So
> instead, we can do this:
> * append the first element (at position {{startIndex}})
> * for every other element (starting at position {{startIndex + 1}}), append
> the separator, then the element.
> It's basically the same tactic used in the {{Iterable}} version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (LANG-1616) Add lastIndexOfAnyChar
[ https://issues.apache.org/jira/browse/LANG-1616?focusedWorklogId=515035=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515035 ] ASF GitHub Bot logged work on LANG-1616: Author: ASF GitHub Bot Created on: 21/Nov/20 12:06 Start Date: 21/Nov/20 12:06 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #658: URL: https://github.com/apache/commons-lang/pull/658#issuecomment-731569784 [](https://coveralls.io/builds/35143790) Coverage decreased (-0.001%) to 94.987% when pulling **9116084570c53385b7c4a295625ab13b3c0981b5 on arturobernalg:feature/LANG-1616** into **764b9bba528487fb575b84766998086c24bb1f48 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 515035) Time Spent: 40m (was: 0.5h) > Add lastIndexOfAnyChar > -- > > Key: LANG-1616 > URL: https://issues.apache.org/jira/browse/LANG-1616 > Project: Commons Lang > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1616) Add lastIndexOfAnyChar
[ https://issues.apache.org/jira/browse/LANG-1616?focusedWorklogId=515034=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515034 ] ASF GitHub Bot logged work on LANG-1616: Author: ASF GitHub Bot Created on: 21/Nov/20 12:06 Start Date: 21/Nov/20 12:06 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #658: URL: https://github.com/apache/commons-lang/pull/658#issuecomment-731569784 [](https://coveralls.io/builds/35143786) Coverage decreased (-0.01%) to 94.974% when pulling **9116084570c53385b7c4a295625ab13b3c0981b5 on arturobernalg:feature/LANG-1616** into **764b9bba528487fb575b84766998086c24bb1f48 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 515034) Time Spent: 0.5h (was: 20m) > Add lastIndexOfAnyChar > -- > > Key: LANG-1616 > URL: https://issues.apache.org/jira/browse/LANG-1616 > Project: Commons Lang > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #658: [LANG-1616] - Add lastIndexOfAnyChar
coveralls edited a comment on pull request #658: URL: https://github.com/apache/commons-lang/pull/658#issuecomment-731569784 [](https://coveralls.io/builds/35143790) Coverage decreased (-0.001%) to 94.987% when pulling **9116084570c53385b7c4a295625ab13b3c0981b5 on arturobernalg:feature/LANG-1616** into **764b9bba528487fb575b84766998086c24bb1f48 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #658: [LANG-1616] - Add lastIndexOfAnyChar
coveralls edited a comment on pull request #658: URL: https://github.com/apache/commons-lang/pull/658#issuecomment-731569784 [](https://coveralls.io/builds/35143786) Coverage decreased (-0.01%) to 94.974% when pulling **9116084570c53385b7c4a295625ab13b3c0981b5 on arturobernalg:feature/LANG-1616** into **764b9bba528487fb575b84766998086c24bb1f48 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1616) Add lastIndexOfAnyChar
[ https://issues.apache.org/jira/browse/LANG-1616?focusedWorklogId=515033=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515033 ] ASF GitHub Bot logged work on LANG-1616: Author: ASF GitHub Bot Created on: 21/Nov/20 12:03 Start Date: 21/Nov/20 12:03 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #658: URL: https://github.com/apache/commons-lang/pull/658#issuecomment-731569784 [](https://coveralls.io/builds/35143775) Coverage decreased (-0.001%) to 94.987% when pulling **9116084570c53385b7c4a295625ab13b3c0981b5 on arturobernalg:feature/LANG-1616** into **764b9bba528487fb575b84766998086c24bb1f48 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 515033) Time Spent: 20m (was: 10m) > Add lastIndexOfAnyChar > -- > > Key: LANG-1616 > URL: https://issues.apache.org/jira/browse/LANG-1616 > Project: Commons Lang > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #658: [LANG-1616] - Add lastIndexOfAnyChar
coveralls commented on pull request #658: URL: https://github.com/apache/commons-lang/pull/658#issuecomment-731569784 [](https://coveralls.io/builds/35143775) Coverage decreased (-0.001%) to 94.987% when pulling **9116084570c53385b7c4a295625ab13b3c0981b5 on arturobernalg:feature/LANG-1616** into **764b9bba528487fb575b84766998086c24bb1f48 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1616) Add lastIndexOfAnyChar
[ https://issues.apache.org/jira/browse/LANG-1616?focusedWorklogId=515031=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515031 ] ASF GitHub Bot logged work on LANG-1616: Author: ASF GitHub Bot Created on: 21/Nov/20 11:54 Start Date: 21/Nov/20 11:54 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #658: URL: https://github.com/apache/commons-lang/pull/658 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 515031) Remaining Estimate: 0h Time Spent: 10m > Add lastIndexOfAnyChar > -- > > Key: LANG-1616 > URL: https://issues.apache.org/jira/browse/LANG-1616 > Project: Commons Lang > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] arturobernalg opened a new pull request #658: [LANG-1616] - Add lastIndexOfAnyChar
arturobernalg opened a new pull request #658: URL: https://github.com/apache/commons-lang/pull/658 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (LANG-1616) Add lastIndexOfAnyChar
Arturo Bernal created LANG-1616: --- Summary: Add lastIndexOfAnyChar Key: LANG-1616 URL: https://issues.apache.org/jira/browse/LANG-1616 Project: Commons Lang Issue Type: Improvement Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1524) TypeUtils.toString StackOverflowError for an inner class in the inner class parameterized enclosing class.
[
https://issues.apache.org/jira/browse/LANG-1524?focusedWorklogId=515025=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515025
]
ASF GitHub Bot logged work on LANG-1524:
Author: ASF GitHub Bot
Created on: 21/Nov/20 11:11
Start Date: 21/Nov/20 11:11
Worklog Time Spent: 10m
Work Description: coveralls commented on pull request #657:
URL: https://github.com/apache/commons-lang/pull/657#issuecomment-731564365
[](https://coveralls.io/builds/35143529)
Coverage decreased (-0.003%) to 94.985% when pulling
**381903183518edb7254d7c93dcdae45db3fc03f3 on aakashgupta96:feature/LANG-1524**
into **764b9bba528487fb575b84766998086c24bb1f48 on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 515025)
Time Spent: 1h 40m (was: 1.5h)
> TypeUtils.toString StackOverflowError for an inner class in the inner class
> parameterized enclosing class.
> --
>
> Key: LANG-1524
> URL: https://issues.apache.org/jira/browse/LANG-1524
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.reflect.*
>Affects Versions: 3.9
>Reporter: kijong.youn
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> StackOverflowError occurred on toString for an inner class in the inner class
> parameterized enclosing class.
>
> source:
> {code:java}
> public class Test {
> public static class Inner {
> }
> public static void main(final String[] args) {
> System.out.println(TypeUtils.toString(Inner.class));
> }
> } {code}
> result:
> {code:java}
> Exception in thread "main" java.lang.StackOverflowErrorException in thread
> "main" java.lang.StackOverflowError at
> java.lang.Class.getEnclosingMethodInfo(Class.java:1072) at
> java.lang.Class.getEnclosingClass(Class.java:1272) at
> org.apache.commons.lang3.reflect.TypeUtils.classToString(TypeUtils.java:1751)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1663)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1891)
> at
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1882)
> at
> org.apache.commons.lang3.reflect.TypeUtils.typeVariableToString(TypeUtils.java:1775)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1672)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1891)
> at
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1882)
> at
> org.apache.commons.lang3.reflect.TypeUtils.classToString(TypeUtils.java:1758)
> at
> org.apache.commons.lang3.reflect.TypeUtils.classToString(TypeUtils.java:1752)
> ...{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #657: [LANG-1524] : Added cycle detection check in toString for classes
coveralls commented on pull request #657: URL: https://github.com/apache/commons-lang/pull/657#issuecomment-731564365 [](https://coveralls.io/builds/35143529) Coverage decreased (-0.003%) to 94.985% when pulling **381903183518edb7254d7c93dcdae45db3fc03f3 on aakashgupta96:feature/LANG-1524** into **764b9bba528487fb575b84766998086c24bb1f48 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1524) TypeUtils.toString StackOverflowError for an inner class in the inner class parameterized enclosing class.
[
https://issues.apache.org/jira/browse/LANG-1524?focusedWorklogId=515024=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515024
]
ASF GitHub Bot logged work on LANG-1524:
Author: ASF GitHub Bot
Created on: 21/Nov/20 11:08
Start Date: 21/Nov/20 11:08
Worklog Time Spent: 10m
Work Description: aakashgupta96 commented on pull request #657:
URL: https://github.com/apache/commons-lang/pull/657#issuecomment-731564002
@arturobernalg Done rebasing changes with master. Can you check now?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 515024)
Time Spent: 1.5h (was: 1h 20m)
> TypeUtils.toString StackOverflowError for an inner class in the inner class
> parameterized enclosing class.
> --
>
> Key: LANG-1524
> URL: https://issues.apache.org/jira/browse/LANG-1524
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.reflect.*
>Affects Versions: 3.9
>Reporter: kijong.youn
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> StackOverflowError occurred on toString for an inner class in the inner class
> parameterized enclosing class.
>
> source:
> {code:java}
> public class Test {
> public static class Inner {
> }
> public static void main(final String[] args) {
> System.out.println(TypeUtils.toString(Inner.class));
> }
> } {code}
> result:
> {code:java}
> Exception in thread "main" java.lang.StackOverflowErrorException in thread
> "main" java.lang.StackOverflowError at
> java.lang.Class.getEnclosingMethodInfo(Class.java:1072) at
> java.lang.Class.getEnclosingClass(Class.java:1272) at
> org.apache.commons.lang3.reflect.TypeUtils.classToString(TypeUtils.java:1751)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1663)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1891)
> at
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1882)
> at
> org.apache.commons.lang3.reflect.TypeUtils.typeVariableToString(TypeUtils.java:1775)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1672)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1891)
> at
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1882)
> at
> org.apache.commons.lang3.reflect.TypeUtils.classToString(TypeUtils.java:1758)
> at
> org.apache.commons.lang3.reflect.TypeUtils.classToString(TypeUtils.java:1752)
> ...{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] aakashgupta96 commented on pull request #657: [LANG-1524] : Added cycle detection check in toString for classes
aakashgupta96 commented on pull request #657: URL: https://github.com/apache/commons-lang/pull/657#issuecomment-731564002 @arturobernalg Done rebasing changes with master. Can you check now? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1524) TypeUtils.toString StackOverflowError for an inner class in the inner class parameterized enclosing class.
[
https://issues.apache.org/jira/browse/LANG-1524?focusedWorklogId=515021=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515021
]
ASF GitHub Bot logged work on LANG-1524:
Author: ASF GitHub Bot
Created on: 21/Nov/20 10:46
Start Date: 21/Nov/20 10:46
Worklog Time Spent: 10m
Work Description: arturobernalg commented on pull request #657:
URL: https://github.com/apache/commons-lang/pull/657#issuecomment-731561778
rebase from master to solve the conflict
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 515021)
Time Spent: 1h 20m (was: 1h 10m)
> TypeUtils.toString StackOverflowError for an inner class in the inner class
> parameterized enclosing class.
> --
>
> Key: LANG-1524
> URL: https://issues.apache.org/jira/browse/LANG-1524
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.reflect.*
>Affects Versions: 3.9
>Reporter: kijong.youn
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> StackOverflowError occurred on toString for an inner class in the inner class
> parameterized enclosing class.
>
> source:
> {code:java}
> public class Test {
> public static class Inner {
> }
> public static void main(final String[] args) {
> System.out.println(TypeUtils.toString(Inner.class));
> }
> } {code}
> result:
> {code:java}
> Exception in thread "main" java.lang.StackOverflowErrorException in thread
> "main" java.lang.StackOverflowError at
> java.lang.Class.getEnclosingMethodInfo(Class.java:1072) at
> java.lang.Class.getEnclosingClass(Class.java:1272) at
> org.apache.commons.lang3.reflect.TypeUtils.classToString(TypeUtils.java:1751)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1663)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1891)
> at
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1882)
> at
> org.apache.commons.lang3.reflect.TypeUtils.typeVariableToString(TypeUtils.java:1775)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1672)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1891)
> at
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1882)
> at
> org.apache.commons.lang3.reflect.TypeUtils.classToString(TypeUtils.java:1758)
> at
> org.apache.commons.lang3.reflect.TypeUtils.classToString(TypeUtils.java:1752)
> ...{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] arturobernalg commented on pull request #657: [LANG-1524] : Added cycle detection check in toString for classes
arturobernalg commented on pull request #657: URL: https://github.com/apache/commons-lang/pull/657#issuecomment-731561778 rebase from master to solve the conflict This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-772) Provide private constructor to the Utils Collections
[
https://issues.apache.org/jira/browse/COLLECTIONS-772?focusedWorklogId=515014=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515014
]
ASF GitHub Bot logged work on COLLECTIONS-772:
--
Author: ASF GitHub Bot
Created on: 21/Nov/20 09:52
Start Date: 21/Nov/20 09:52
Worklog Time Spent: 10m
Work Description: arturobernalg commented on a change in pull request
#195:
URL:
https://github.com/apache/commons-collections/pull/195#discussion_r528176002
##
File path: src/main/java/org/apache/commons/collections4/ArrayUtils.java
##
@@ -38,6 +38,12 @@
*/
class ArrayUtils {
+
+/**
+ * Don't allow instances.
+ */
+private ArrayUtils() {}
Review comment:
Thank you @kinow
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 515014)
Time Spent: 3h 10m (was: 3h)
> Provide private constructor to the Utils Collections
>
>
> Key: COLLECTIONS-772
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-772
> Project: Commons Collections
> Issue Type: Improvement
> Components: Collection
>Affects Versions: 4.4
>Reporter: Arturo Bernal
>Priority: Minor
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Utils classes have their constructor made private to prohibit instantiation.
>
> * IterableUtils
> * ArrayUtils
>
> {color:#ff}Keep in mind this improvement will break the binary. We need a
> mayor release{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-collections] arturobernalg commented on a change in pull request #195: [COLLECTIONS-772] - Provide private constructor to the Utils Collections
arturobernalg commented on a change in pull request #195:
URL:
https://github.com/apache/commons-collections/pull/195#discussion_r528176002
##
File path: src/main/java/org/apache/commons/collections4/ArrayUtils.java
##
@@ -38,6 +38,12 @@
*/
class ArrayUtils {
+
+/**
+ * Don't allow instances.
+ */
+private ArrayUtils() {}
Review comment:
Thank you @kinow
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (LANG-1524) TypeUtils.toString StackOverflowError for an inner class in the inner class parameterized enclosing class.
[
https://issues.apache.org/jira/browse/LANG-1524?focusedWorklogId=515008=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515008
]
ASF GitHub Bot logged work on LANG-1524:
Author: ASF GitHub Bot
Created on: 21/Nov/20 09:22
Start Date: 21/Nov/20 09:22
Worklog Time Spent: 10m
Work Description: aakashgupta96 edited a comment on pull request #657:
URL: https://github.com/apache/commons-lang/pull/657#issuecomment-731487813
@arturobernalg @garydgregory @HubertWo Could you please review this PR?
Since I'm new to open source, let me know in case I missed something or I
need to make any changes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 515008)
Time Spent: 1h 10m (was: 1h)
> TypeUtils.toString StackOverflowError for an inner class in the inner class
> parameterized enclosing class.
> --
>
> Key: LANG-1524
> URL: https://issues.apache.org/jira/browse/LANG-1524
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.reflect.*
>Affects Versions: 3.9
>Reporter: kijong.youn
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> StackOverflowError occurred on toString for an inner class in the inner class
> parameterized enclosing class.
>
> source:
> {code:java}
> public class Test {
> public static class Inner {
> }
> public static void main(final String[] args) {
> System.out.println(TypeUtils.toString(Inner.class));
> }
> } {code}
> result:
> {code:java}
> Exception in thread "main" java.lang.StackOverflowErrorException in thread
> "main" java.lang.StackOverflowError at
> java.lang.Class.getEnclosingMethodInfo(Class.java:1072) at
> java.lang.Class.getEnclosingClass(Class.java:1272) at
> org.apache.commons.lang3.reflect.TypeUtils.classToString(TypeUtils.java:1751)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1663)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1891)
> at
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1882)
> at
> org.apache.commons.lang3.reflect.TypeUtils.typeVariableToString(TypeUtils.java:1775)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1672)
> at org.apache.commons.lang3.reflect.TypeUtils.toString(TypeUtils.java:1891)
> at
> org.apache.commons.lang3.reflect.TypeUtils.appendAllTo(TypeUtils.java:1882)
> at
> org.apache.commons.lang3.reflect.TypeUtils.classToString(TypeUtils.java:1758)
> at
> org.apache.commons.lang3.reflect.TypeUtils.classToString(TypeUtils.java:1752)
> ...{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] aakashgupta96 edited a comment on pull request #657: [LANG-1524] : Added cycle detection check in toString for classes
aakashgupta96 edited a comment on pull request #657: URL: https://github.com/apache/commons-lang/pull/657#issuecomment-731487813 @arturobernalg @garydgregory @HubertWo Could you please review this PR? Since I'm new to open source, let me know in case I missed something or I need to make any changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (LANG-1437) Remove redundant if statements in StringUtils.join
[
https://issues.apache.org/jira/browse/LANG-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236618#comment-17236618
]
Arturo Bernal commented on LANG-1437:
-
PR merged.
[~aft90] [~ggregory]
we can close the issue.
> Remove redundant if statements in StringUtils.join
> --
>
> Key: LANG-1437
> URL: https://issues.apache.org/jira/browse/LANG-1437
> Project: Commons Lang
> Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Andrei Filip Troie
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In the various {{join}} methods in {{StringUtils}}, the for-loop contains an
> {{if (i > startIndex)}} check (for an example see
> [here|https://github.com/apache/commons-lang/blob/eb5b11a25c9e61f9b25a540682816ebb103b735c/src/main/java/org/apache/commons/lang3/StringUtils.java#L4203],
> but it's present in all the {{join}} methods that take an array).
> That is unnecessary - for the first iteration, we know the condition is
> false, while for the other iterations, we know the condition is true. So
> instead, we can do this:
> * append the first element (at position {{startIndex}})
> * for every other element (starting at position {{startIndex + 1}}), append
> the separator, then the element.
> It's basically the same tactic used in the {{Iterable}} version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (COLLECTIONS-772) Provide private constructor to the Utils Collections
[
https://issues.apache.org/jira/browse/COLLECTIONS-772?focusedWorklogId=515007=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515007
]
ASF GitHub Bot logged work on COLLECTIONS-772:
--
Author: ASF GitHub Bot
Created on: 21/Nov/20 09:17
Start Date: 21/Nov/20 09:17
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #195:
URL:
https://github.com/apache/commons-collections/pull/195#discussion_r528172602
##
File path: src/main/java/org/apache/commons/collections4/ArrayUtils.java
##
@@ -38,6 +38,12 @@
*/
class ArrayUtils {
+
+/**
+ * Don't allow instances.
+ */
+private ArrayUtils() {}
Review comment:
Ha! Thanks for your last comment @arturobernalg ! I did not see the
class was private. I checked with clirr, it looks good.
```
kinow@ranma:~/Development/java/apache/commons-collections$ git log -n 1
commit 0679fa25d199ef6f276a430c43fcdecb1aa7c1c1 (HEAD -> pr-195)
Author: Arturo Bernal
Date: Thu Nov 19 07:45:05 2020 +0100
COLLECTIONS-772 - Provide private constructor to the Utils Collections
kinow@ranma:~/Development/java/apache/commons-collections$ mvn clirr:check
...
[INFO] --- clirr-maven-plugin:2.8:check (default-cli) @ commons-collections4
---
[INFO] artifact org.apache.commons:commons-collections4: checking for
updates from repo.jenkins-ci.org
[INFO] artifact org.apache.commons:commons-collections4: checking for
updates from central
[INFO] Comparing to version: 4.4
[INFO] Succeeded with 0 errors; 0 warnings; and 49 other changes.
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 12.449 s
[INFO] Finished at: 2020-11-21T22:15:37+13:00
[INFO]
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 515007)
Time Spent: 3h (was: 2h 50m)
> Provide private constructor to the Utils Collections
>
>
> Key: COLLECTIONS-772
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-772
> Project: Commons Collections
> Issue Type: Improvement
> Components: Collection
>Affects Versions: 4.4
>Reporter: Arturo Bernal
>Priority: Minor
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Utils classes have their constructor made private to prohibit instantiation.
>
> * IterableUtils
> * ArrayUtils
>
> {color:#ff}Keep in mind this improvement will break the binary. We need a
> mayor release{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-collections] kinow commented on a change in pull request #195: [COLLECTIONS-772] - Provide private constructor to the Utils Collections
kinow commented on a change in pull request #195:
URL:
https://github.com/apache/commons-collections/pull/195#discussion_r528172602
##
File path: src/main/java/org/apache/commons/collections4/ArrayUtils.java
##
@@ -38,6 +38,12 @@
*/
class ArrayUtils {
+
+/**
+ * Don't allow instances.
+ */
+private ArrayUtils() {}
Review comment:
Ha! Thanks for your last comment @arturobernalg ! I did not see the
class was private. I checked with clirr, it looks good.
```
kinow@ranma:~/Development/java/apache/commons-collections$ git log -n 1
commit 0679fa25d199ef6f276a430c43fcdecb1aa7c1c1 (HEAD -> pr-195)
Author: Arturo Bernal
Date: Thu Nov 19 07:45:05 2020 +0100
COLLECTIONS-772 - Provide private constructor to the Utils Collections
kinow@ranma:~/Development/java/apache/commons-collections$ mvn clirr:check
...
[INFO] --- clirr-maven-plugin:2.8:check (default-cli) @ commons-collections4
---
[INFO] artifact org.apache.commons:commons-collections4: checking for
updates from repo.jenkins-ci.org
[INFO] artifact org.apache.commons:commons-collections4: checking for
updates from central
[INFO] Comparing to version: 4.4
[INFO] Succeeded with 0 errors; 0 warnings; and 49 other changes.
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 12.449 s
[INFO] Finished at: 2020-11-21T22:15:37+13:00
[INFO]
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (LANG-1533) RandomStringUtils.random() should not include \u0000
[
https://issues.apache.org/jira/browse/LANG-1533?focusedWorklogId=514998=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-514998
]
ASF GitHub Bot logged work on LANG-1533:
Author: ASF GitHub Bot
Created on: 21/Nov/20 08:52
Start Date: 21/Nov/20 08:52
Worklog Time Spent: 10m
Work Description: arturobernalg commented on pull request #654:
URL: https://github.com/apache/commons-lang/pull/654#issuecomment-731548423
HI @garydgregory
PR created for --> https://issues.apache.org/jira/browse/LANG-1533
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 514998)
Time Spent: 0.5h (was: 20m)
> RandomStringUtils.random() should not include \u
> -
>
> Key: LANG-1533
> URL: https://issues.apache.org/jira/browse/LANG-1533
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.*
>Affects Versions: 3.8.1
>Reporter: Daniel Vega
>Priority: Minor
> Attachments: 0001-xxx.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When generating random strings we should not include char 0x00 by default.
> This is problematic for many tools and libraries. For example, if we try to
> save this value in a PosgreSQL database we'll get:
>
> {quote}PSQLException: ERROR: invalid byte sequence for encoding "UTF8": 0x00
> {quote}
>
> Currently we are avoiding some code code-point ranges. We should also skip
> {{codePoint=0}}
> {code:none}
> --- a/src/main/java/org/apache/commons/lang3/RandomStringUtils.java
> +++ b/src/main/java/org/apache/commons/lang3/RandomStringUtils.java
> @@ -400,6 +400,12 @@ public static String random(int count, int start, int
> end, final boolean letters
> if (chars == null) {
> codePoint = random.nextInt(gap) + start;
>
> +// Skip codePoint \u because is problematic for some
> tools/libraries
> +if (codePoint==0) {
> +count++;
> +continue;
> +}
> +
> switch (Character.getType(codePoint)) {
> case Character.UNASSIGNED:
> case Character.PRIVATE_USE:
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] arturobernalg commented on pull request #654: [LANG-1533] - RandomStringUtils.random() should not include \u0000
arturobernalg commented on pull request #654: URL: https://github.com/apache/commons-lang/pull/654#issuecomment-731548423 HI @garydgregory PR created for --> https://issues.apache.org/jira/browse/LANG-1533 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-772) Provide private constructor to the Utils Collections
[
https://issues.apache.org/jira/browse/COLLECTIONS-772?focusedWorklogId=514995=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-514995
]
ASF GitHub Bot logged work on COLLECTIONS-772:
--
Author: ASF GitHub Bot
Created on: 21/Nov/20 08:45
Start Date: 21/Nov/20 08:45
Worklog Time Spent: 10m
Work Description: arturobernalg commented on pull request #195:
URL:
https://github.com/apache/commons-collections/pull/195#issuecomment-731540491
HI @kinow
But the class is a package private class and so that change does not break
binary compatibility
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 514995)
Time Spent: 2h 50m (was: 2h 40m)
> Provide private constructor to the Utils Collections
>
>
> Key: COLLECTIONS-772
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-772
> Project: Commons Collections
> Issue Type: Improvement
> Components: Collection
>Affects Versions: 4.4
>Reporter: Arturo Bernal
>Priority: Minor
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Utils classes have their constructor made private to prohibit instantiation.
>
> * IterableUtils
> * ArrayUtils
>
> {color:#ff}Keep in mind this improvement will break the binary. We need a
> mayor release{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-collections] arturobernalg commented on pull request #195: [COLLECTIONS-772] - Provide private constructor to the Utils Collections
arturobernalg commented on pull request #195: URL: https://github.com/apache/commons-collections/pull/195#issuecomment-731540491 HI @kinow But the class is a package private class and so that change does not break binary compatibility This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1614) Split fixed-length elements
[
https://issues.apache.org/jira/browse/LANG-1614?focusedWorklogId=514994=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-514994
]
ASF GitHub Bot logged work on LANG-1614:
Author: ASF GitHub Bot
Created on: 21/Nov/20 08:38
Start Date: 21/Nov/20 08:38
Worklog Time Spent: 10m
Work Description: arturobernalg commented on a change in pull request
#645:
URL: https://github.com/apache/commons-lang/pull/645#discussion_r528168674
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -7731,6 +7731,48 @@ public static String rotate(final String str, final int
shift) {
return substrings.toArray(ArrayUtils.EMPTY_STRING_ARRAY);
}
+/**
+ * Split a {@link String} into a {@code String []} of fixed-length
elements.
+ *
+ *
+ * StringUtils.splitEvery("test1",10) = ["test1"]
+ * StringUtils.splitEvery("test2", 4) = ["test","2"]
+ * StringUtils.splitEvery("testAbgTestsABG", -2) = ["testAbgTestsABG"]
+ * StringUtils.splitEvery("",10) = [""]
+ * StringUtils.splitEvery(null,4) = {@code null}
+ * StringUtils.splitEvery("testAbgTestsABG",2)=
["te","st","Ab","gT","es","ts","AB","G"]
+ *
+ *
+ * @param str {@link String} to split into fixed length elements.
+ * @param length length of the elements into which the String will be
divided.
+ * @return a {@code String []} of fixed-length elements.
+ */
+public static String[] splitEvery( final String str, final int length ) {
Review comment:
Hi
usually in the others method return null . An. example of that -->
` public static String abbreviateMiddle(final String str, final String
middle, final int length) {
if (isAnyEmpty(str, middle) || length >= str.length() || length <
middle.length()+2) {
return str;
}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 514994)
Time Spent: 50m (was: 40m)
> Split fixed-length elements
> ---
>
> Key: LANG-1614
> URL: https://issues.apache.org/jira/browse/LANG-1614
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.*
>Affects Versions: 3.11
>Reporter: Arturo Bernal
>Priority: Minor
> Labels: StringUtils, improvement, pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Create a new method that split a string into an array of fixed-length elements
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] arturobernalg commented on a change in pull request #645: [LANG-1614] - Split fixed-length elements
arturobernalg commented on a change in pull request #645:
URL: https://github.com/apache/commons-lang/pull/645#discussion_r528168674
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -7731,6 +7731,48 @@ public static String rotate(final String str, final int
shift) {
return substrings.toArray(ArrayUtils.EMPTY_STRING_ARRAY);
}
+/**
+ * Split a {@link String} into a {@code String []} of fixed-length
elements.
+ *
+ *
+ * StringUtils.splitEvery("test1",10) = ["test1"]
+ * StringUtils.splitEvery("test2", 4) = ["test","2"]
+ * StringUtils.splitEvery("testAbgTestsABG", -2) = ["testAbgTestsABG"]
+ * StringUtils.splitEvery("",10) = [""]
+ * StringUtils.splitEvery(null,4) = {@code null}
+ * StringUtils.splitEvery("testAbgTestsABG",2)=
["te","st","Ab","gT","es","ts","AB","G"]
+ *
+ *
+ * @param str {@link String} to split into fixed length elements.
+ * @param length length of the elements into which the String will be
divided.
+ * @return a {@code String []} of fixed-length elements.
+ */
+public static String[] splitEvery( final String str, final int length ) {
Review comment:
Hi
usually in the others method return null . An. example of that -->
` public static String abbreviateMiddle(final String str, final String
middle, final int length) {
if (isAnyEmpty(str, middle) || length >= str.length() || length <
middle.length()+2) {
return str;
}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-772) Provide private constructor to the Utils Collections
[
https://issues.apache.org/jira/browse/COLLECTIONS-772?focusedWorklogId=514992=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-514992
]
ASF GitHub Bot logged work on COLLECTIONS-772:
--
Author: ASF GitHub Bot
Created on: 21/Nov/20 08:32
Start Date: 21/Nov/20 08:32
Worklog Time Spent: 10m
Work Description: arturobernalg commented on a change in pull request
#195:
URL:
https://github.com/apache/commons-collections/pull/195#discussion_r528166207
##
File path: src/main/java/org/apache/commons/collections4/IterableUtils.java
##
@@ -50,6 +50,11 @@
*/
public class IterableUtils {
+/**
+ * {@code IterableUtils} should not normally be instantiated.
+ */
+private IterableUtils() {}
+
Review comment:
Thank you @kinow
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 514992)
Time Spent: 2h 40m (was: 2.5h)
> Provide private constructor to the Utils Collections
>
>
> Key: COLLECTIONS-772
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-772
> Project: Commons Collections
> Issue Type: Improvement
> Components: Collection
>Affects Versions: 4.4
>Reporter: Arturo Bernal
>Priority: Minor
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Utils classes have their constructor made private to prohibit instantiation.
>
> * IterableUtils
> * ArrayUtils
>
> {color:#ff}Keep in mind this improvement will break the binary. We need a
> mayor release{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-collections] arturobernalg commented on a change in pull request #195: [COLLECTIONS-772] - Provide private constructor to the Utils Collections
arturobernalg commented on a change in pull request #195:
URL:
https://github.com/apache/commons-collections/pull/195#discussion_r528166207
##
File path: src/main/java/org/apache/commons/collections4/IterableUtils.java
##
@@ -50,6 +50,11 @@
*/
public class IterableUtils {
+/**
+ * {@code IterableUtils} should not normally be instantiated.
+ */
+private IterableUtils() {}
+
Review comment:
Thank you @kinow
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
