[jira] [Updated] (EMAIL-205) Possible Dead Code in EmailUtils.encodeURL()?
[
https://issues.apache.org/jira/browse/EMAIL-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Emerson updated EMAIL-205:
---
Description:
Hello,
I was doing some testing on the library for a university project and came
across what may be some dead code in the {{EmailUtils.encodeURL()}} function.
The code in question is the if block at line 298:
{code:java}
for (final byte c : input.getBytes(US_ASCII))
{
int b = c;
if (b < 0)
{
b = 256 + b;
}
...{code}
I realize that the
{{b = 256 + b;}}
condition is there as an attempt to handle the fact that bytes are signed in
Java, however, when I look at the implementation of
{{{}input.getBytes(US_ASCII){}}},
I don't see any case that it can return a negative byte value.
{{getBytes(US_ASCII)}} returns a '?' character for any non-ascii character,
thus preventing an overflow that may result in a negative byte ('?' has a value
of 63). This would mean that the the contents of the if statement are
unreachable.
If anyone with more experience has the time to take a look at this I would
greatly appreciate it. For my own education, I would love to see a test case in
which a negative byte value would be returned here.
Thanks!
was:
Hello,
I was doing some testing on the library for a university project and came
across what may be some dead code in the {{EmailUtils.encodeURL()}} function.
The code in question is the if block at line 298:
{code:java}
for (final byte c : input.getBytes(US_ASCII))
{
int b = c;
if (b < 0)
{
b = 256 + b;
}
...{code}
I realize that the {{b = 256 + b; }}condition is there as an attempt to handle
the fact that bytes are signed in Java, however, when I look at the
implementation of{{{} input.getBytes(US_ASCII){}}}, I don't see any case that
it can return a negative byte value. {{getBytes(US_ASCII)}} returns a '?'
character for any non-ascii character, thus preventing an overflow that may
result in a negative byte ('?' has a value of 63). This would mean that the
the contents of the if statement are unreachable.
If anyone with more experience has the time to take a look at this I would
greatly appreciate it. For my own education, I would love to see a test case in
which a negative byte value would be returned here.
Thanks!
> Possible Dead Code in EmailUtils.encodeURL()?
> -
>
> Key: EMAIL-205
> URL: https://issues.apache.org/jira/browse/EMAIL-205
> Project: Commons Email
> Issue Type: Improvement
>Reporter: Adam Emerson
>Priority: Minor
>
> Hello,
> I was doing some testing on the library for a university project and came
> across what may be some dead code in the {{EmailUtils.encodeURL()}} function.
> The code in question is the if block at line 298:
> {code:java}
> for (final byte c : input.getBytes(US_ASCII))
> {
> int b = c;
> if (b < 0)
> {
> b = 256 + b;
> }
> ...{code}
> I realize that the
> {{b = 256 + b;}}
> condition is there as an attempt to handle the fact that bytes are signed in
> Java, however, when I look at the implementation of
> {{{}input.getBytes(US_ASCII){}}},
> I don't see any case that it can return a negative byte value.
> {{getBytes(US_ASCII)}} returns a '?' character for any non-ascii character,
> thus preventing an overflow that may result in a negative byte ('?' has a
> value of 63). This would mean that the the contents of the if statement are
> unreachable.
> If anyone with more experience has the time to take a look at this I would
> greatly appreciate it. For my own education, I would love to see a test case
> in which a negative byte value would be returned here.
> Thanks!
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (EMAIL-205) Possible Dead Code in EmailUtils.encodeURL()?
[
https://issues.apache.org/jira/browse/EMAIL-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Emerson updated EMAIL-205:
---
Description:
Hello,
I was doing some testing on the library for a university project and came
across what may be some dead code in the {{EmailUtils.encodeURL()}} function.
The code in question is the if block at line 298:
{code:java}
for (final byte c : input.getBytes(US_ASCII))
{
int b = c;
if (b < 0)
{
b = 256 + b;
}
...{code}
I realize that the {{b = 256 + b; }}condition is there as an attempt to handle
the fact that bytes are signed in Java, however, when I look at the
implementation of{{{} input.getBytes(US_ASCII){}}}, I don't see any case that
it can return a negative byte value. {{getBytes(US_ASCII)}} returns a '?'
character for any non-ascii character, thus preventing an overflow that may
result in a negative byte ('?' has a value of 63). This would mean that the
the contents of the if statement are unreachable.
If anyone with more experience has the time to take a look at this I would
greatly appreciate it. For my own education, I would love to see a test case in
which a negative byte value would be returned here.
Thanks!
was:
Hello,
I was doing some testing on the library for a university project and came
across what may be some dead code in the {{EmailUtils.encodeURL()}} function.
The code in question is the if block at line 298:
{code:java}
for (final byte c : input.getBytes(US_ASCII))
{
int b = c;
if (b < 0)
{
b = 256 + b;
}
...{code}
I realize that the {{b = 256 + b; }}condition is there as an attempt to handle
the fact that bytes are signed in Java, however, when I look at the
implementation of {{{}input.getBytes(US_ASCII){}}}, I don't see any case that
it can return a negative byte value. {{getBytes(US_ASCII)}} returns a '?'
character for any non-ascii character, thus preventing an overflow that may
result in a negative byte ('?' has a value of 63). This would mean that the
the contents of the {{if }}statement are unreachable.
If anyone with more experience has the time to take a look at this I would
greatly appreciate it. For my own education, I would love to see a test case in
which a negative byte value would be returned here.
Thanks!
> Possible Dead Code in EmailUtils.encodeURL()?
> -
>
> Key: EMAIL-205
> URL: https://issues.apache.org/jira/browse/EMAIL-205
> Project: Commons Email
> Issue Type: Improvement
>Reporter: Adam Emerson
>Priority: Minor
>
> Hello,
> I was doing some testing on the library for a university project and came
> across what may be some dead code in the {{EmailUtils.encodeURL()}} function.
> The code in question is the if block at line 298:
> {code:java}
> for (final byte c : input.getBytes(US_ASCII))
> {
> int b = c;
> if (b < 0)
> {
> b = 256 + b;
> }
> ...{code}
> I realize that the {{b = 256 + b; }}condition is there as an attempt to
> handle the fact that bytes are signed in Java, however, when I look at the
> implementation of{{{} input.getBytes(US_ASCII){}}}, I don't see any case that
> it can return a negative byte value. {{getBytes(US_ASCII)}} returns a '?'
> character for any non-ascii character, thus preventing an overflow that may
> result in a negative byte ('?' has a value of 63). This would mean that the
> the contents of the if statement are unreachable.
> If anyone with more experience has the time to take a look at this I would
> greatly appreciate it. For my own education, I would love to see a test case
> in which a negative byte value would be returned here.
> Thanks!
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-configuration] garydgregory merged pull request #233: Bump actions/upload-artifact from 3.1.0 to 3.1.1
garydgregory merged PR #233: URL: https://github.com/apache/commons-configuration/pull/233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-configuration] garydgregory merged pull request #235: Bump mockito-core from 4.8.0 to 4.8.1
garydgregory merged PR #235: URL: https://github.com/apache/commons-configuration/pull/235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #986: Bump easymock from 5.0.0 to 5.0.1
garydgregory merged PR #986: URL: https://github.com/apache/commons-lang/pull/986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #985: Bump actions/upload-artifact from 3.1.0 to 3.1.1
garydgregory merged PR #985: URL: https://github.com/apache/commons-lang/pull/985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-cli] garydgregory merged pull request #142: Bump actions/upload-artifact from 3.1.0 to 3.1.1
garydgregory merged PR #142: URL: https://github.com/apache/commons-cli/pull/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] garydgregory merged pull request #157: Bump actions/upload-artifact from 3.1.0 to 3.1.1
garydgregory merged PR #157: URL: https://github.com/apache/commons-codec/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on pull request #161: Typo in error message
garydgregory commented on PR #161: URL: https://github.com/apache/commons-bcel/pull/161#issuecomment-1296327262 I'll likely merge this in a couple of days after 6.6.1 is out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (JEXL-382) Simplify grammar and lexical state management
[ https://issues.apache.org/jira/browse/JEXL-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitri Blinov updated JEXL-382: --- Description: Here is the proposal to tidy up grammar and lexical state management rules. The jar size reduction is also a small bonus to code cleanup https://github.com/apache/commons-jexl/pull/134 was: Here is the proposal to tidy up grammar and lexical state management rules. https://github.com/apache/commons-jexl/pull/134 > Simplify grammar and lexical state management > - > > Key: JEXL-382 > URL: https://issues.apache.org/jira/browse/JEXL-382 > Project: Commons JEXL > Issue Type: Improvement >Reporter: Dmitri Blinov >Priority: Major > > Here is the proposal to tidy up grammar and lexical state management rules. > The jar size reduction is also a small bonus to code cleanup > https://github.com/apache/commons-jexl/pull/134 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JEXL-382) Simplify grammar and lexical state management
[ https://issues.apache.org/jira/browse/JEXL-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitri Blinov updated JEXL-382: --- Description: Here is the proposal to tidy up grammar and lexical state management rules. https://github.com/apache/commons-jexl/pull/134 was:https://github.com/apache/commons-jexl/pull/134 > Simplify grammar and lexical state management > - > > Key: JEXL-382 > URL: https://issues.apache.org/jira/browse/JEXL-382 > Project: Commons JEXL > Issue Type: Improvement >Reporter: Dmitri Blinov >Priority: Major > > Here is the proposal to tidy up grammar and lexical state management rules. > https://github.com/apache/commons-jexl/pull/134 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-collections] aherbert commented on pull request #335: [Collections-834][bloom filters] bit count producer operation is not clearly defined
aherbert commented on PR #335: URL: https://github.com/apache/commons-collections/pull/335#issuecomment-1296319411 Hi @Claudenw, consolidating all the behaviour flags is a good idea. It will avoid future tests failing to set them correctly. I'll wait until you have done that for a review. Note: I have reservations about the HasherCollection and the requirement for an `absoluteUniqueIndices` method. In summary: 1. I think it should be resolved after this PR 2. Since the HasherCollection violates the IndexProducer contract by outputting more than k indices, we may need to revise the contract and javadoc as being able to output up to a multiple of k indices for a Shape. This would be helped by a size-type method in the IndexProducer interface to state what count of k will be output. 3. The method `absoluteUniqueIndices` may be better served by a HasherSet, or some other naming variant, that ensures all indices output by the IndexProducer are unique. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (JEXL-382) Simplify grammar and lexical state management
Dmitri Blinov created JEXL-382: -- Summary: Simplify grammar and lexical state management Key: JEXL-382 URL: https://issues.apache.org/jira/browse/JEXL-382 Project: Commons JEXL Issue Type: Improvement Reporter: Dmitri Blinov https://github.com/apache/commons-jexl/pull/134 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NUMBERS-70) Userguide and reports
[ https://issues.apache.org/jira/browse/NUMBERS-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Herbert resolved NUMBERS-70. - Resolution: Implemented JHM benchmarking module and user guide are now in master > Userguide and reports > - > > Key: NUMBERS-70 > URL: https://issues.apache.org/jira/browse/NUMBERS-70 > Project: Commons Numbers > Issue Type: Wish >Affects Versions: 1.0 >Reporter: Gilles Sadowski >Priority: Minor > Labels: benchmark, documentation > Fix For: 1.1 > > Attachments: 0001-Angles-xdoc-is-added.patch, > 0001-Prime-xdoc-file-is-added.patch, 0001-Primes-xdoc-is-added.patch > > > Review contents of the component towards providing an up-to-date userguide > and write benchmarking code for generating performance reports > ([JMH|http://openjdk.java.net/projects/code-tools/jmh/]). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-dbutils] garydgregory merged pull request #143: Bump actions/checkout from 3.0.2 to 3.1.0
garydgregory merged PR #143: URL: https://github.com/apache/commons-dbutils/pull/143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] codecov-commenter commented on pull request #146: Bump spotbugs-maven-plugin from 4.4.2 to 4.7.2.1
codecov-commenter commented on PR #146: URL: https://github.com/apache/commons-dbutils/pull/146#issuecomment-1296299824 # [Codecov](https://codecov.io/gh/apache/commons-dbutils/pull/146?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#146](https://codecov.io/gh/apache/commons-dbutils/pull/146?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (06754b0) into [master](https://codecov.io/gh/apache/commons-dbutils/commit/6b4b322ed108a6940b43e3f9d72f9f45d56bfec8?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b4b322) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #146 +/- ## = Coverage 61.99% 61.99% Complexity 404 404 = Files39 39 Lines 1463 1463 Branches122 122 = Hits907 907 Misses 503 503 Partials 53 53 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] codecov-commenter commented on pull request #149: Bump spotbugs from 4.2.3 to 4.7.3
codecov-commenter commented on PR #149: URL: https://github.com/apache/commons-dbutils/pull/149#issuecomment-1296299363 # [Codecov](https://codecov.io/gh/apache/commons-dbutils/pull/149?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#149](https://codecov.io/gh/apache/commons-dbutils/pull/149?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (099b31a) into [master](https://codecov.io/gh/apache/commons-dbutils/commit/6b4b322ed108a6940b43e3f9d72f9f45d56bfec8?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b4b322) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #149 +/- ## = Coverage 61.99% 61.99% Complexity 404 404 = Files39 39 Lines 1463 1463 Branches122 122 = Hits907 907 Misses 503 503 Partials 53 53 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] dependabot[bot] commented on pull request #149: Bump spotbugs from 4.2.3 to 4.7.3
dependabot[bot] commented on PR #149: URL: https://github.com/apache/commons-dbutils/pull/149#issuecomment-1296299253 Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] dependabot[bot] commented on pull request #143: Bump actions/checkout from 3.0.2 to 3.1.0
dependabot[bot] commented on PR #143: URL: https://github.com/apache/commons-dbutils/pull/143#issuecomment-1296299205 Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] garydgregory commented on pull request #146: Bump spotbugs-maven-plugin from 4.4.2 to 4.7.2.1
garydgregory commented on PR #146: URL: https://github.com/apache/commons-dbutils/pull/146#issuecomment-1296295440 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] garydgregory commented on pull request #149: Bump spotbugs from 4.2.3 to 4.7.3
garydgregory commented on PR #149: URL: https://github.com/apache/commons-dbutils/pull/149#issuecomment-1296295421 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] garydgregory commented on pull request #143: Bump actions/checkout from 3.0.2 to 3.1.0
garydgregory commented on PR #143: URL: https://github.com/apache/commons-dbutils/pull/143#issuecomment-1296295391 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] garydgregory merged pull request #145: Bump actions/cache from 3.0.9 to 3.0.11
garydgregory merged PR #145: URL: https://github.com/apache/commons-dbutils/pull/145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] garydgregory merged pull request #148: Bump actions/setup-java from 3.5.1 to 3.6.0
garydgregory merged PR #148: URL: https://github.com/apache/commons-dbutils/pull/148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] garydgregory merged pull request #150: Bump actions/upload-artifact from 3.1.0 to 3.1.1
garydgregory merged PR #150: URL: https://github.com/apache/commons-dbutils/pull/150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] garydgregory commented on pull request #149: Bump spotbugs from 4.2.3 to 4.7.3
garydgregory commented on PR #149: URL: https://github.com/apache/commons-dbutils/pull/149#issuecomment-1296294766 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] garydgregory merged pull request #151: Bump mockito-core from 4.8.0 to 4.8.1
garydgregory merged PR #151: URL: https://github.com/apache/commons-dbutils/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] garydgregory merged pull request #232: Bump mockito-core from 4.8.0 to 4.8.1
garydgregory merged PR #232: URL: https://github.com/apache/commons-dbcp/pull/232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory merged pull request #328: Bump mockito-core from 4.8.0 to 4.8.1
garydgregory merged PR #328: URL: https://github.com/apache/commons-vfs/pull/328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory merged pull request #327: Bump actions/upload-artifact from 3.1.0 to 3.1.1
garydgregory merged PR #327: URL: https://github.com/apache/commons-vfs/pull/327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] codecov-commenter commented on pull request #151: Bump mockito-core from 4.8.0 to 4.8.1
codecov-commenter commented on PR #151: URL: https://github.com/apache/commons-dbutils/pull/151#issuecomment-1296293942 # [Codecov](https://codecov.io/gh/apache/commons-dbutils/pull/151?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#151](https://codecov.io/gh/apache/commons-dbutils/pull/151?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (fe52ac6) into [master](https://codecov.io/gh/apache/commons-dbutils/commit/8471c148799a0be5f4de22d15d5006023a96ec3c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8471c14) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #151 +/- ## = Coverage 61.99% 61.99% Complexity 404 404 = Files39 39 Lines 1463 1463 Branches122 122 = Hits907 907 Misses 503 503 Partials 53 53 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] garydgregory merged pull request #231: Bump actions/upload-artifact from 3.1.0 to 3.1.1
garydgregory merged PR #231: URL: https://github.com/apache/commons-dbcp/pull/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] codecov-commenter commented on pull request #161: Typo in error message
codecov-commenter commented on PR #161: URL: https://github.com/apache/commons-bcel/pull/161#issuecomment-1296290338 # [Codecov](https://codecov.io/gh/apache/commons-bcel/pull/161?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#161](https://codecov.io/gh/apache/commons-bcel/pull/161?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4e99d05) into [master](https://codecov.io/gh/apache/commons-bcel/commit/587c9869e2dd9abc5dae70457c44f1ddabd0ef00?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (587c986) will **not change** coverage. > The diff coverage is `0.00%`. ```diff @@Coverage Diff@@ ## master #161 +/- ## = Coverage 44.92% 44.92% Complexity 2516 2516 = Files 362 362 Lines 1556715567 Branches 1920 1920 = Hits 6994 6994 Misses 7891 7891 Partials682 682 ``` | [Impacted Files](https://codecov.io/gh/apache/commons-bcel/pull/161?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../org/apache/bcel/classfile/SimpleElementValue.java](https://codecov.io/gh/apache/commons-bcel/pull/161/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL1NpbXBsZUVsZW1lbnRWYWx1ZS5qYXZh) | `22.05% <0.00%> (ø)` | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] nbauma109 opened a new pull request, #161: Typo in error message
nbauma109 opened a new pull request, #161: URL: https://github.com/apache/commons-bcel/pull/161 It seems it was a wrong copy/paste -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #280: Bump actions/upload-artifact from 3.1.0 to 3.1.1
garydgregory merged PR #280: URL: https://github.com/apache/commons-csv/pull/280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
