[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1070928496
##
src/main/java/org/apache/commons/net/ftp/FTPSClient.java:
##
@@ -204,7 +204,7 @@ public FTPSClient(final String protocol, final boolean
isImplicit) {
/**
* Because there are so many connect() methods, the _connectAction_()
method is provided as a means of performing some action immediately after
establishing
- * a connection, rather than reimplementing all of the connect() methods.
+ * a connection, rather than reimplementing all the connect() methods.
*
* @throws IOException If it throw by _connectAction_.
Review Comment:
I've changed it according to the style found/used in `FTPSClient`.
To be found in next commit together with changes proposed by @sebbASF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1070914027 ## src/main/java/org/apache/commons/net/nntp/NNTPClient.java: ## @@ -268,9 +268,9 @@ public Iterable iterateArticleInfo(final long lowArticleNumber, final l } /** - * List all new articles added to the NNTP server since a particular date subject to the conditions of the specified query. If no new new news is found, no - * entries will be returned. This uses the "NEWNEWS" command. You must add at least one newsgroup to the query, else the command will fail. Each String - * which is returned is a unique message identifier including the enclosing and . + * List all new articles added to the NNTP server since a particular date subject to the conditions of the specified query. If no recent news is found, Review Comment: Convinced. I'll revert the three occurrences of that text fragment with the next commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FILEUPLOAD-309) Release version 2.0.0
[ https://issues.apache.org/jira/browse/FILEUPLOAD-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677188#comment-17677188 ] Martin Tzvetanov Grigorov commented on FILEUPLOAD-309: -- [~joc...@apache.org] We vote for a release that includes the jakarta improvements! The last release of commons-fileupload is 1.4 from 2018. > Release version 2.0.0 > - > > Key: FILEUPLOAD-309 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-309 > Project: Commons FileUpload > Issue Type: Wish >Reporter: Thiago Henrique Hupner >Priority: Major > > At Piranha, we've migrated to use the new Jakarta namespace. > One of our dependencies is the Commons File Upload, but the latest version > available is 1.4. > Looking around at the source code, I've found that the code is already > prepared for the new Jakarta namespace. > So, I want to know if there's a plan to release a new version soon. Or at > least a 2.0.0 milestone. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IMAGING-343) Apache Commons Imaging 0.97 - CVE-2018-17202
Nikhil created IMAGING-343:
--
Summary: Apache Commons Imaging 0.97 - CVE-2018-17202
Key: IMAGING-343
URL: https://issues.apache.org/jira/browse/IMAGING-343
Project: Commons Imaging
Issue Type: Bug
Affects Versions: 0.97
Reporter: Nikhil
Certain input files could make the code to enter into an infinite loop when
Apache Sanselan 0.97-incubator was used to parse them, which could be used in a
DoS attack. Note that Apache Sanselan (incubating) was renamed to Apache
Commons Imaging.
See [https://nvd.nist.gov/vuln/detail/CVE-2018-17202] for more details.
There is Apache Commons Imaging 1.0-{*}alpha3{*} version available.. but we are
trying to understand if a new *GA* will be made available and also to see if
this specific CVE is addressed in the latest versions ?
Please help
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-email] dependabot[bot] closed pull request #132: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
dependabot[bot] closed pull request #132: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1 URL: https://github.com/apache/commons-email/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] commented on pull request #132: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
dependabot[bot] commented on PR #132: URL: https://github.com/apache/commons-email/pull/132#issuecomment-1383348229 Looks like org.apache.maven.plugins:maven-checkstyle-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-339) Basic WebP support
[ https://issues.apache.org/jira/browse/IMAGING-339?focusedWorklogId=839286=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839286 ] ASF GitHub Bot logged work on IMAGING-339: -- Author: ASF GitHub Bot Created on: 16/Jan/23 01:09 Start Date: 16/Jan/23 01:09 Worklog Time Spent: 10m Work Description: Glavo commented on PR #254: URL: https://github.com/apache/commons-imaging/pull/254#issuecomment-1383319953 I updated this PR, added the `@since` tag and more detailed javadoc. Issue Time Tracking --- Worklog Id: (was: 839286) Time Spent: 1.5h (was: 1h 20m) > Basic WebP support > -- > > Key: IMAGING-339 > URL: https://issues.apache.org/jira/browse/IMAGING-339 > Project: Commons Imaging > Issue Type: Improvement > Components: Format: WebP >Affects Versions: 1.0-alpha2 >Reporter: Bruno P. Kinoshita >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 1.0-alpha3 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Placeholder for https://github.com/apache/commons-imaging/pull/254 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-imaging] Glavo commented on pull request #254: [IMAGING-339] Basic WebP Support
Glavo commented on PR #254: URL: https://github.com/apache/commons-imaging/pull/254#issuecomment-1383319953 I updated this PR, added the `@since` tag and more detailed javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] garydgregory merged pull request #132: Bump actions/cache from 3.2.2 to 3.2.3
garydgregory merged PR #132: URL: https://github.com/apache/commons-jcs/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-scxml] dependabot[bot] opened a new pull request, #104: Bump Saxon-HE from 11.4 to 12.0
dependabot[bot] opened a new pull request, #104: URL: https://github.com/apache/commons-scxml/pull/104 Bumps Saxon-HE from 11.4 to 12.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jexl] henrib merged pull request #158: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
henrib merged PR #158: URL: https://github.com/apache/commons-jexl/pull/158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-769) FileUtils.copyFileToDirectory can lead to not accessible file when preserving the file date
[ https://issues.apache.org/jira/browse/IO-769?focusedWorklogId=839274=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839274 ] ASF GitHub Bot logged work on IO-769: - Author: ASF GitHub Bot Created on: 15/Jan/23 15:03 Start Date: 15/Jan/23 15:03 Worklog Time Spent: 10m Work Description: menscikov commented on PR #377: URL: https://github.com/apache/commons-io/pull/377#issuecomment-1383174106 Hello, `FileUtils.copyInputStreamToFile()` has the same issue starting from **2.9** version. Please fix it also. Issue Time Tracking --- Worklog Id: (was: 839274) Time Spent: 1h 20m (was: 1h 10m) > FileUtils.copyFileToDirectory can lead to not accessible file when preserving > the file date > --- > > Key: IO-769 > URL: https://issues.apache.org/jira/browse/IO-769 > Project: Commons IO > Issue Type: Bug > Components: Utilities >Affects Versions: 2.11.0 >Reporter: Jérémy Carnus >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > Hi, > The current implementation for copyFileToDirectory by default preserve the > file. > There 2 issues regarding this: > * the javadoc mentions this is done by File.setLastModified by in fact this > is done by the COPY_ATTRIBUTES options > * Under Windows, the COPY_ATTRIBUTES also copies the security attributes > (SID and permissions) and can lead to a file not beeing readable after copy > (if for example, you copie from a mount under docker or a shared folder) > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-io] menscikov commented on pull request #377: IO-769: FileUtils copyDirectory() should not use COPY_ATTRIBUTES
menscikov commented on PR #377: URL: https://github.com/apache/commons-io/pull/377#issuecomment-1383174106 Hello, `FileUtils.copyInputStreamToFile()` has the same issue starting from **2.9** version. Please fix it also. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
garydgregory commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1070608034
##
src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java:
##
@@ -110,7 +110,7 @@ public class UnixFTPEntryParser extends
ConfigurableFTPFileEntryParserImpl {
/**
* The default constructor for a UnixFTPEntryParser object.
*
- * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. It it is seen, this is
a
+ * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. If it is seen, this is
a
Review Comment:
Hm, then if I was confused by what "it" refers to, can we replace the "it"
with the actual subject?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (IMAGING-340) Support PNG extension
[ https://issues.apache.org/jira/browse/IMAGING-340?focusedWorklogId=839271=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839271 ] ASF GitHub Bot logged work on IMAGING-340: -- Author: ASF GitHub Bot Created on: 15/Jan/23 13:39 Start Date: 15/Jan/23 13:39 Worklog Time Spent: 10m Work Description: Glavo commented on PR #269: URL: https://github.com/apache/commons-imaging/pull/269#issuecomment-1383153151 The javadoc has been updated to add the `@since` tag. Issue Time Tracking --- Worklog Id: (was: 839271) Time Spent: 40m (was: 0.5h) > Support PNG extension > - > > Key: IMAGING-340 > URL: https://issues.apache.org/jira/browse/IMAGING-340 > Project: Commons Imaging > Issue Type: Improvement > Components: Format: PNG >Reporter: Glavo >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > Support [Extensions to the PNG 1.2 Specification, Version > 1.5.0|http://ftp-osl.osuosl.org/pub/libpng/documents/pngext-1.5.0.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-imaging] Glavo commented on pull request #269: [IMAGING-340] Support PNG extension
Glavo commented on PR #269: URL: https://github.com/apache/commons-imaging/pull/269#issuecomment-1383153151 The javadoc has been updated to add the `@since` tag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-340) Support PNG extension
[
https://issues.apache.org/jira/browse/IMAGING-340?focusedWorklogId=839270=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839270
]
ASF GitHub Bot logged work on IMAGING-340:
--
Author: ASF GitHub Bot
Created on: 15/Jan/23 13:31
Start Date: 15/Jan/23 13:31
Worklog Time Spent: 10m
Work Description: kinow commented on code in PR #269:
URL: https://github.com/apache/commons-imaging/pull/269#discussion_r1070592972
##
src/main/java/org/apache/commons/imaging/formats/png/package-info.java:
##
@@ -16,7 +16,14 @@
*/
/**
- * The PNG image format.
+ * The PNG (Portable Network Graphics) image format.
+ *
+ * The implementation is based on the
+ * http://www.libpng.org/pub/png/spec/1.2/;>PNG specification version
1.2,
+ * and supports the following extensions:
+ *
+ * http://ftp-osl.osuosl.org/pub/libpng/documents/pngext-1.5.0.html;>Extensions
to the PNG 1.2 Specification, Version 1.5.0
+ *
Review Comment:
Thank you! :clap:
##
src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java:
##
@@ -282,21 +263,53 @@ public Dimension getImageSize(final ByteSource
byteSource, final PngImagingParam
@Override
public ImageMetadata getMetadata(final ByteSource byteSource, final
PngImagingParameters params)
throws ImageReadException, IOException {
-final List chunks = readChunks(byteSource, new ChunkType[] {
ChunkType.tEXt, ChunkType.zTXt, ChunkType.iTXt }, false);
+final ChunkType[] chunkTypes = { ChunkType.tEXt, ChunkType.zTXt,
ChunkType.iTXt, ChunkType.eXIf };
+final List chunks = readChunks(byteSource, chunkTypes,
false);
if (chunks.isEmpty()) {
return null;
}
-final GenericImageMetadata result = new GenericImageMetadata();
+final GenericImageMetadata textual = new GenericImageMetadata();
+TiffImageMetadata exif = null;
for (final PngChunk chunk : chunks) {
-final PngTextChunk textChunk = (PngTextChunk) chunk;
+if (chunk instanceof PngTextChunk) {
+final PngTextChunk textChunk = (PngTextChunk) chunk;
+textual.add(textChunk.getKeyword(), textChunk.getText());
+} else if (chunk.chunkType == ChunkType.eXIf.value) {
+if (exif != null) {
+throw new ImageReadException("Duplicate eXIf chunk");
+}
+exif = (TiffImageMetadata) new
TiffImageParser().getMetadata(chunk.getBytes());
+}
Review Comment:
I think we should either log and/or raise an error for any other type here.
##
src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java:
##
@@ -187,29 +190,7 @@ private List readChunks(final InputStream is,
final ChunkType[] chunkT
final int crc = read4Bytes("CRC", is, "Not a Valid PNG File",
getByteOrder());
if (keep) {
-if (chunkType == ChunkType.iCCP.value) {
-result.add(new PngChunkIccp(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.tEXt.value) {
-result.add(new PngChunkText(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.zTXt.value) {
-result.add(new PngChunkZtxt(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.IHDR.value) {
-result.add(new PngChunkIhdr(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.PLTE.value) {
-result.add(new PngChunkPlte(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.pHYs.value) {
-result.add(new PngChunkPhys(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.sCAL.value) {
-result.add(new PngChunkScal(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.IDAT.value) {
-result.add(new PngChunkIdat(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.gAMA.value) {
-result.add(new PngChunkGama(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.iTXt.value) {
-result.add(new PngChunkItxt(length, chunkType, crc,
bytes));
-} else {
-result.add(new PngChunk(length, chunkType, crc, bytes));
-}
+result.add(ChunkType.makeChunk(length, chunkType, crc, bytes));
Review Comment:
:ok_man: :clap: bravo, @Glavo
##
src/main/java/org/apache/commons/imaging/formats/png/PngImageMetadata.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[GitHub] [commons-imaging] kinow commented on a diff in pull request #269: [IMAGING-340] Support PNG extension
kinow commented on code in PR #269:
URL: https://github.com/apache/commons-imaging/pull/269#discussion_r1070592972
##
src/main/java/org/apache/commons/imaging/formats/png/package-info.java:
##
@@ -16,7 +16,14 @@
*/
/**
- * The PNG image format.
+ * The PNG (Portable Network Graphics) image format.
+ *
+ * The implementation is based on the
+ * http://www.libpng.org/pub/png/spec/1.2/;>PNG specification version
1.2,
+ * and supports the following extensions:
+ *
+ * http://ftp-osl.osuosl.org/pub/libpng/documents/pngext-1.5.0.html;>Extensions
to the PNG 1.2 Specification, Version 1.5.0
+ *
Review Comment:
Thank you! :clap:
##
src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java:
##
@@ -282,21 +263,53 @@ public Dimension getImageSize(final ByteSource
byteSource, final PngImagingParam
@Override
public ImageMetadata getMetadata(final ByteSource byteSource, final
PngImagingParameters params)
throws ImageReadException, IOException {
-final List chunks = readChunks(byteSource, new ChunkType[] {
ChunkType.tEXt, ChunkType.zTXt, ChunkType.iTXt }, false);
+final ChunkType[] chunkTypes = { ChunkType.tEXt, ChunkType.zTXt,
ChunkType.iTXt, ChunkType.eXIf };
+final List chunks = readChunks(byteSource, chunkTypes,
false);
if (chunks.isEmpty()) {
return null;
}
-final GenericImageMetadata result = new GenericImageMetadata();
+final GenericImageMetadata textual = new GenericImageMetadata();
+TiffImageMetadata exif = null;
for (final PngChunk chunk : chunks) {
-final PngTextChunk textChunk = (PngTextChunk) chunk;
+if (chunk instanceof PngTextChunk) {
+final PngTextChunk textChunk = (PngTextChunk) chunk;
+textual.add(textChunk.getKeyword(), textChunk.getText());
+} else if (chunk.chunkType == ChunkType.eXIf.value) {
+if (exif != null) {
+throw new ImageReadException("Duplicate eXIf chunk");
+}
+exif = (TiffImageMetadata) new
TiffImageParser().getMetadata(chunk.getBytes());
+}
Review Comment:
I think we should either log and/or raise an error for any other type here.
##
src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java:
##
@@ -187,29 +190,7 @@ private List readChunks(final InputStream is,
final ChunkType[] chunkT
final int crc = read4Bytes("CRC", is, "Not a Valid PNG File",
getByteOrder());
if (keep) {
-if (chunkType == ChunkType.iCCP.value) {
-result.add(new PngChunkIccp(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.tEXt.value) {
-result.add(new PngChunkText(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.zTXt.value) {
-result.add(new PngChunkZtxt(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.IHDR.value) {
-result.add(new PngChunkIhdr(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.PLTE.value) {
-result.add(new PngChunkPlte(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.pHYs.value) {
-result.add(new PngChunkPhys(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.sCAL.value) {
-result.add(new PngChunkScal(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.IDAT.value) {
-result.add(new PngChunkIdat(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.gAMA.value) {
-result.add(new PngChunkGama(length, chunkType, crc,
bytes));
-} else if (chunkType == ChunkType.iTXt.value) {
-result.add(new PngChunkItxt(length, chunkType, crc,
bytes));
-} else {
-result.add(new PngChunk(length, chunkType, crc, bytes));
-}
+result.add(ChunkType.makeChunk(length, chunkType, crc, bytes));
Review Comment:
:ok_man: :clap: bravo, @Glavo
##
src/main/java/org/apache/commons/imaging/formats/png/PngImageMetadata.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required
[GitHub] [commons-net] sebbASF commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
sebbASF commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1070583181
##
src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java:
##
@@ -110,7 +110,7 @@ public class UnixFTPEntryParser extends
ConfigurableFTPFileEntryParserImpl {
/**
* The default constructor for a UnixFTPEntryParser object.
*
- * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. It it is seen, this is
a
+ * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. If it is seen, this is
a
Review Comment:
Disagree on changing from seen to thrown, as that breaks the connection to
the previous sentence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] sebbASF commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
sebbASF commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1070574537
##
src/main/java/org/apache/commons/net/ftp/FTPSClient.java:
##
@@ -375,7 +375,7 @@ public int execADAT(final byte[] data) throws IOException {
/**
* AUTH command.
*
- * @throws SSLException If it server reply code not equal "234" and "334".
+ * @throws SSLException If the server reply code does not equal "234" and
"334".
Review Comment:
```Does not equal “234” and “334”``` will never be true.
This should be
```Does not equal either of “234” or “334”```
Or
```Does not equal “234” and does not equal “334”```
Or
```Is equal to neither “234” nor “334”```
##
src/main/java/org/apache/commons/net/nntp/NNTPClient.java:
##
@@ -416,7 +416,7 @@ public String listHelp() throws IOException {
}
/**
- * List all new articles added to the NNTP server since a particular date
subject to the conditions of the specified query. If no new new news is found, a
+ * List all new articles added to the NNTP server since a particular date
subject to the conditions of the specified query. If no recent news is found, a
Review Comment:
News that is new is not necessarily recent. That depends on the date
##
src/main/java/org/apache/commons/net/SocketClient.java:
##
@@ -632,7 +632,7 @@ public void setDefaultPort(final int port) {
/**
* Set the default timeout in milliseconds to use when opening a socket.
This value is only used previous to a call to {@link #connect connect()} and
should
- * not be confused with {@link #setSoTimeout setSoTimeout()} which
operates on an the currently opened socket. _timeout_ contains the new timeout
value.
+ * not be confused with {@link #setSoTimeout setSoTimeout()} which
operates on any of the currently opened socket. _timeout_ contains the new
timeout value.
Review Comment:
That is the wrong fix. Instead the word ‘an’ should just have been deleted.
##
src/main/java/org/apache/commons/net/telnet/Telnet.java:
##
@@ -666,7 +666,7 @@ boolean requestedWill(final int option) {
/**
* Looks for the state of the option.
*
- * @return returns true if a wont has been reuqested
+ * @return returns true if a won't has been requested
Review Comment:
The command is “wont”, not “won’t”. Though maybe the commands should be
listed as “WONT”
##
src/main/java/org/apache/commons/net/smtp/SimpleSMTPHeader.java:
##
@@ -90,8 +90,8 @@ public void addCC(final String address) {
}
/**
- * Adds an arbitrary header field with the given value to the article
header. These headers will be written before the From, To, Subject, and Cc
fields when
- * the SimpleSMTPHeader is convertered to a string. An example use would
be:
+ * Adds an arbitrary header field with the given value to the article
header. These headers will be written before the
+ * {@code From}, To, Subject, and Cc fields when the SimpleSMTPHeader is
converted to a string. An example use would be:
Review Comment:
Why only add code to From?
##
src/main/java/org/apache/commons/net/ftp/parser/MVSFTPEntryParser.java:
##
@@ -437,7 +437,7 @@ private FTPFile parseMemberList(final String entry) {
}
/**
- * preParse is called as part of the interface. Per definition is is
called before the parsing takes place. Three kind of lists is recognize:
z/OS-MVS File
+ * preParse is called as part of the interface. Per definition it is
called before the parsing takes place. Three kind of lists are recognize:
z/OS-MVS File
Review Comment:
Three kindS of list are recogniseD - caps show missing letters
##
src/main/java/org/apache/commons/net/examples/unix/rlogin.java:
##
@@ -25,14 +25,14 @@
/**
* This is an example program demonstrating how to use the RLoginClient class.
This program connects to an rlogin daemon and begins to interactively read input
* from stdin (this will be line buffered on most systems, so don't expect
character at a time interactivity), passing it to the remote login process and
- * writing the remote stdout and stderr to local stdout. If you don't have
.rhosts or hosts.equiv files set up, the rlogin daemon will prompt you for a
- * password.
+ * writing the remote stdout and stderr to local stdout. If you don't have
{@code .rhosts} or {@code hosts.equiv} files set up, the rlogin daemon will
prompt
+ * you for a password.
*
* On Unix systems you will not be able to use the rshell capability unless
the process runs as root since only root can bind port addresses lower than
1024.
*
* JVM's using green threads will likely have problems if the rlogin daemon
requests a password. This program is merely a demonstration and is not suitable
for
- * use as an application, especially given that it relies on line buffered
[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
garydgregory commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1070581110
##
src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java:
##
@@ -110,7 +110,7 @@ public class UnixFTPEntryParser extends
ConfigurableFTPFileEntryParserImpl {
/**
* The default constructor for a UnixFTPEntryParser object.
*
- * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. It it is seen, this is
a
+ * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. If it is seen, this is
a
Review Comment:
Up to you. When you are done with edits here, I will review the PR again
(hopefully for the last time).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
garydgregory commented on PR #141: URL: https://github.com/apache/commons-net/pull/141#issuecomment-1383139388 Up to you. When you are done with edits here, I will review the PR again (hopefully for the last time). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1070580668
##
src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java:
##
@@ -110,7 +110,7 @@ public class UnixFTPEntryParser extends
ConfigurableFTPFileEntryParserImpl {
/**
* The default constructor for a UnixFTPEntryParser object.
*
- * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. It it is seen, this is
a
+ * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. If it is seen, this is
a
Review Comment:
Would apply for many other occurrences as well. Could be a separate PR, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
garydgregory commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1070580429
##
src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java:
##
@@ -110,7 +110,7 @@ public class UnixFTPEntryParser extends
ConfigurableFTPFileEntryParserImpl {
/**
* The default constructor for a UnixFTPEntryParser object.
*
- * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. It it is seen, this is
a
+ * @throws IllegalArgumentException Thrown if the regular expression is
unparseable. Should not be seen under normal conditions. If it is seen, this is
a
Review Comment:
Might this be better: "If it is seen" -> "If it is thrown"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
