[GitHub] [commons-lang] garydgregory commented on pull request #669: Adding method to convert and format date
garydgregory commented on pull request #669: URL: https://github.com/apache/commons-lang/pull/669#issuecomment-782873413 No response in 2 months, closing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #669: Adding method to convert and format date
garydgregory commented on pull request #669: URL: https://github.com/apache/commons-lang/pull/669#issuecomment-749155069 Hi @iashok22 Thank you for your PR. This seems to duplicate `FastDateFormat.getInstance(pattern).format(long)` which uses a format cache. The new method is the same as `new SimpleDateFormat(format).format(long)` (which does not use a cache) so I do not see the value here. Am I missing something? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org