[jira] [Commented] (CB-7281) cordova plugin add issues nonsense EACCESS error
[ https://issues.apache.org/jira/browse/CB-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113561#comment-14113561 ] Asier Iturralde Sarasola commented on CB-7281: -- I have the same issue using cordova 3.5.0-0.2.7. I solved the problem setting my user as the owner of the folder /home/asier/tmp/, previously the owner was root. cordova plugin add issues nonsense EACCESS error -- Key: CB-7281 URL: https://issues.apache.org/jira/browse/CB-7281 Project: Apache Cordova Issue Type: Bug Components: Plugins Environment: ubuntu 14.04 Reporter: teo On a freshly created test application targeted at android, which works fine. I ran: $ cordova plugin add nl.sylvain.cordova.osc Fetching plugin nl.sylvain.cordova.osc via plugin registry Error: EACCES, mkdir '/home/teo/tmp/npm-20870-r97koGWy' That doesn't make sense, as /home/teo is my home directory (I was running the above command as teo). There's no reason why that mkdir command should get an access denied error (if that's what EACCESS means). This worked: $ sudo cordova plugin add nl.sylvain.cordova.osc however, there's no reason why sudo should be needed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7416) Windows+plugins. source-file is not correctly processed
[ https://issues.apache.org/jira/browse/CB-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113570#comment-14113570 ] ASF subversion and git services commented on CB-7416: - Commit 2ac042e94a1bfb989ceffe123d1e0ebab9ee6367 in cordova-lib's branch refs/heads/master from sgrebnov [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=2ac042e ] CB-7416 Fixes file path reference when adding new source file Windows+plugins. source-file is not correctly processed --- Key: CB-7416 URL: https://issues.apache.org/jira/browse/CB-7416 Project: Apache Cordova Issue Type: Bug Components: CordovaLib, Windows 8 Reporter: Sergey Grebnov Assignee: Jesse MacFadyen Labels: cordova-lib, windows, windows81 For backward compatibility and to avoid mass core plugins failures we re-use windows8 platform definitions for plugins for new windows platform. But looks like after some recent changes in cordova-lib some of the elements are not processed correct, I see the following logic added /src/plugman/install.js {code} var platformTag = pluginInfo._et.find('./platform[@name='+platform+']'); // CB-6976 Windows Universal Apps. For smooth transition and to prevent mass api failures // we allow using windows8 tag for new windows platform if (platform == 'windows' !platformTag) { platformTag = pluginInfo._et.find('platform[@name=' + 'windows8' + ']'); } if ( pluginInfo.hasPlatformSection(platform) ) { var sourceFiles = platformTag.findall('./source-file'), headerFiles = platformTag.findall('./header-file'), resourceFiles = platformTag.findall('./resource-file'), frameworkFiles = platformTag.findall('./framework'), libFiles = platformTag.findall('./lib-file'); {code} Looks like pluginInfo.hasPlatformSection(platform) prevents plugin definitions to be applied for windows if they are defined under windows8 if I replace {code} if ( pluginInfo.hasPlatformSection(platform) ) { {code} with {code} if ( platformTag) { {code} then source-file and other definitions are correctly applied, but I see that added references (at lest for source-file) are not removed from CordovaApp.projitems after plugin uninstall -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7281) cordova plugin add issues nonsense EACCESS error
[ https://issues.apache.org/jira/browse/CB-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113646#comment-14113646 ] Marcel Kinard commented on CB-7281: --- I suggest that cordova commands not be run via sudo. [~teo] can you recreate your project and add platforms/plugins without sudo and see if this problem still occurs? cordova plugin add issues nonsense EACCESS error -- Key: CB-7281 URL: https://issues.apache.org/jira/browse/CB-7281 Project: Apache Cordova Issue Type: Bug Components: Plugins Environment: ubuntu 14.04 Reporter: teo On a freshly created test application targeted at android, which works fine. I ran: $ cordova plugin add nl.sylvain.cordova.osc Fetching plugin nl.sylvain.cordova.osc via plugin registry Error: EACCES, mkdir '/home/teo/tmp/npm-20870-r97koGWy' That doesn't make sense, as /home/teo is my home directory (I was running the above command as teo). There's no reason why that mkdir command should get an access denied error (if that's what EACCESS means). This worked: $ sudo cordova plugin add nl.sylvain.cordova.osc however, there's no reason why sudo should be needed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7281) cordova plugin add issues nonsense EACCESS error
[ https://issues.apache.org/jira/browse/CB-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113650#comment-14113650 ] Luigi commented on CB-7281: --- Hi Marcel, of course using sudo when using Cordova is not advisable. Anyway the problem seems to be generated when INSTALLING cordova (or updating it). It seems the user tmp folder becomes owned by root cordova plugin add issues nonsense EACCESS error -- Key: CB-7281 URL: https://issues.apache.org/jira/browse/CB-7281 Project: Apache Cordova Issue Type: Bug Components: Plugins Environment: ubuntu 14.04 Reporter: teo On a freshly created test application targeted at android, which works fine. I ran: $ cordova plugin add nl.sylvain.cordova.osc Fetching plugin nl.sylvain.cordova.osc via plugin registry Error: EACCES, mkdir '/home/teo/tmp/npm-20870-r97koGWy' That doesn't make sense, as /home/teo is my home directory (I was running the above command as teo). There's no reason why that mkdir command should get an access denied error (if that's what EACCESS means). This worked: $ sudo cordova plugin add nl.sylvain.cordova.osc however, there's no reason why sudo should be needed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-7372) Prepare for FirefoxOS on Windows generates incorrect path
[ https://issues.apache.org/jira/browse/CB-7372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Zalewa closed CB-7372. Resolution: Fixed Fixed and merged to master Prepare for FirefoxOS on Windows generates incorrect path - Key: CB-7372 URL: https://issues.apache.org/jira/browse/CB-7372 Project: Apache Cordova Issue Type: Bug Components: CordovaLib, FirefoxOS Affects Versions: 3.5.0 Environment: Windows 8 64-bit Reporter: GearĂ³id Moroney Priority: Critical On Windows, the manifest.webapp file for Firefox OS has an invalid path. The file must be edited manually to get the app to work. To reproduce: - Install Cordova 3.5.0 - Create a new project: cordova create test - In the test folder, add FxOS: cordova platform add firefoxos - Package the app. For FxOS all that needs to be done is prepare: cordova prepare firefoxos - In Firefox (at least version 26), go to about:app-manager - Click Apps on the left, and then Add Packaged App on the bottom. Select test/platforms/firefoxos/www - On the right-hand side, notice the error: Launch path has to be an absolute path starting with '/': '\index.html' I have a fix ready for this and will submit a pull request on GitHub. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-7102) globalization
[ https://issues.apache.org/jira/browse/CB-7102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Zalewa closed CB-7102. Resolution: Fixed Globalization is currently working. Additional features will need a new issue. globalization - Key: CB-7102 URL: https://issues.apache.org/jira/browse/CB-7102 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Reporter: Piotr Zalewa Assignee: Piotr Zalewa Add globalization support for Firefox OS -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7420) Windows. Plugin resource-files are removed from platform during prepare
Sergey Grebnov created CB-7420: -- Summary: Windows. Plugin resource-files are removed from platform during prepare Key: CB-7420 URL: https://issues.apache.org/jira/browse/CB-7420 Project: Apache Cordova Issue Type: Bug Components: CordovaLib, Windows 8 Reporter: Sergey Grebnov Assignee: Sergey Grebnov As per current implementation plugins source-file are placed to www folder on Windows so removed during prepare step. Looks like we have not seen this issue before since core plugins don't use resource-file on Windows - on windows we mostly use js-module elements. The difference between js-module and source-file is that js-module content is supposed to be js code only and is wrapped in special way before placing to platform. Source-file could be anything which should be added as Content, for example Windows Store package resource file (.pri) - http://msdn.microsoft.com/en-us/library/windows/apps/hh694557.aspx -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-3204) initial implementation of cordova apis
[ https://issues.apache.org/jira/browse/CB-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Zalewa reassigned CB-3204: Assignee: Piotr Zalewa (was: James Long) initial implementation of cordova apis -- Key: CB-3204 URL: https://issues.apache.org/jira/browse/CB-3204 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Herm Wong Assignee: Piotr Zalewa -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7420) Windows. Plugin resource-files are removed from platform during prepare
[ https://issues.apache.org/jira/browse/CB-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113696#comment-14113696 ] Sergey Grebnov commented on CB-7420: I think we should just place those files to 'platform/plugins' folder instead of 'platform/*www*/plugins' like we do for custom frameworks Windows. Plugin resource-files are removed from platform during prepare - Key: CB-7420 URL: https://issues.apache.org/jira/browse/CB-7420 Project: Apache Cordova Issue Type: Bug Components: CordovaLib, Windows 8 Reporter: Sergey Grebnov Assignee: Sergey Grebnov Labels: cordova-lib, windows As per current implementation plugins source-file are placed to www folder on Windows so removed during prepare step. Looks like we have not seen this issue before since core plugins don't use resource-file on Windows - on windows we mostly use js-module elements. The difference between js-module and source-file is that js-module content is supposed to be js code only and is wrapped in special way before placing to platform. Source-file could be anything which should be added as Content, for example Windows Store package resource file (.pri) - http://msdn.microsoft.com/en-us/library/windows/apps/hh694557.aspx -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-7420) Windows. Plugin resource-files are removed from platform during prepare
[ https://issues.apache.org/jira/browse/CB-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Grebnov updated CB-7420: --- Description: As per current implementation plugins source-file are placed to www folder on Windows so removed during prepare step. Looks like we have not seen this issue before since core plugins don't use source-file on Windows - on windows we mostly use js-module elements. The difference between js-module and source-file is that js-module content is supposed to be js code only and is wrapped in special way before placing to platform. Source-file could be anything which should be added as Content, for example Windows Store package resource file (.pri) - http://msdn.microsoft.com/en-us/library/windows/apps/hh694557.aspx was: As per current implementation plugins source-file are placed to www folder on Windows so removed during prepare step. Looks like we have not seen this issue before since core plugins don't use resource-file on Windows - on windows we mostly use js-module elements. The difference between js-module and source-file is that js-module content is supposed to be js code only and is wrapped in special way before placing to platform. Source-file could be anything which should be added as Content, for example Windows Store package resource file (.pri) - http://msdn.microsoft.com/en-us/library/windows/apps/hh694557.aspx Windows. Plugin resource-files are removed from platform during prepare - Key: CB-7420 URL: https://issues.apache.org/jira/browse/CB-7420 Project: Apache Cordova Issue Type: Bug Components: CordovaLib, Windows 8 Reporter: Sergey Grebnov Assignee: Sergey Grebnov Labels: cordova-lib, windows As per current implementation plugins source-file are placed to www folder on Windows so removed during prepare step. Looks like we have not seen this issue before since core plugins don't use source-file on Windows - on windows we mostly use js-module elements. The difference between js-module and source-file is that js-module content is supposed to be js code only and is wrapped in special way before placing to platform. Source-file could be anything which should be added as Content, for example Windows Store package resource file (.pri) - http://msdn.microsoft.com/en-us/library/windows/apps/hh694557.aspx -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7420) Windows. Plugin resource-files are removed from platform during prepare
[ https://issues.apache.org/jira/browse/CB-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113699#comment-14113699 ] ASF GitHub Bot commented on CB-7420: GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/80 CB-7420 Windows. Plugin resource-files are removed from platform during prepare https://issues.apache.org/jira/browse/CB-7420 Changed source files location from platform\www\plugins to platform\plugins (similar to custom frameworks) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-7420 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/80.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #80 commit 6e532116589939664fb9f063a5b15977a6c4eb99 Author: sgrebnov v-seg...@microsoft.com Date: 2014-08-28T12:23:42Z CB-7420 Windows. Plugin resource-files are removed from platform during prepare Windows. Plugin resource-files are removed from platform during prepare - Key: CB-7420 URL: https://issues.apache.org/jira/browse/CB-7420 Project: Apache Cordova Issue Type: Bug Components: CordovaLib, Windows 8 Reporter: Sergey Grebnov Assignee: Sergey Grebnov Labels: cordova-lib, windows As per current implementation plugins source-file are placed to www folder on Windows so removed during prepare step. Looks like we have not seen this issue before since core plugins don't use source-file on Windows - on windows we mostly use js-module elements. The difference between js-module and source-file is that js-module content is supposed to be js code only and is wrapped in special way before placing to platform. Source-file could be anything which should be added as Content, for example Windows Store package resource file (.pri) - http://msdn.microsoft.com/en-us/library/windows/apps/hh694557.aspx -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Clelland updated CB-7375: - Assignee: (was: Ian Clelland) Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113729#comment-14113729 ] Ian Clelland commented on CB-7375: -- Okay, this is the smallest change that I can make that gets Android/iOS working again. Unfortunately, WP8 is completely opaque to me at the moment, so I need someone with WP experience to take on the rest of this issue. It might be as small as switching the order of the two terms: {{entry.filesystemName}} and {{(entry.filesystem entry.filesystem.name)}} in the conditions, but I don't want to continue dumping more code blindly into the repository to test it. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7281) cordova plugin add issues nonsense EACCESS error
[ https://issues.apache.org/jira/browse/CB-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113739#comment-14113739 ] Marcel Kinard commented on CB-7281: --- Did you use sudo when installing/updating cordova? cordova plugin add issues nonsense EACCESS error -- Key: CB-7281 URL: https://issues.apache.org/jira/browse/CB-7281 Project: Apache Cordova Issue Type: Bug Components: Plugins Environment: ubuntu 14.04 Reporter: teo On a freshly created test application targeted at android, which works fine. I ran: $ cordova plugin add nl.sylvain.cordova.osc Fetching plugin nl.sylvain.cordova.osc via plugin registry Error: EACCES, mkdir '/home/teo/tmp/npm-20870-r97koGWy' That doesn't make sense, as /home/teo is my home directory (I was running the above command as teo). There's no reason why that mkdir command should get an access denied error (if that's what EACCESS means). This worked: $ sudo cordova plugin add nl.sylvain.cordova.osc however, there's no reason why sudo should be needed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7281) cordova plugin add issues nonsense EACCESS error
[ https://issues.apache.org/jira/browse/CB-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113747#comment-14113747 ] Luigi commented on CB-7281: --- Yep cordova plugin add issues nonsense EACCESS error -- Key: CB-7281 URL: https://issues.apache.org/jira/browse/CB-7281 Project: Apache Cordova Issue Type: Bug Components: Plugins Environment: ubuntu 14.04 Reporter: teo On a freshly created test application targeted at android, which works fine. I ran: $ cordova plugin add nl.sylvain.cordova.osc Fetching plugin nl.sylvain.cordova.osc via plugin registry Error: EACCES, mkdir '/home/teo/tmp/npm-20870-r97koGWy' That doesn't make sense, as /home/teo is my home directory (I was running the above command as teo). There's no reason why that mkdir command should get an access denied error (if that's what EACCESS means). This worked: $ sudo cordova plugin add nl.sylvain.cordova.osc however, there's no reason why sudo should be needed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7267) Tools Release [Android 3.5.1] Aug 5 2014
[ https://issues.apache.org/jira/browse/CB-7267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113759#comment-14113759 ] ASF subversion and git services commented on CB-7267: - Commit eb8cf56e8e7ce0419dbe444fbedaa434bf4e4009 in cordova-android's branch refs/heads/master from [~cmarcelk] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=eb8cf56 ] CB-7267 update RELEASENOTES for 3.5.1 Tools Release [Android 3.5.1] Aug 5 2014 Key: CB-7267 URL: https://issues.apache.org/jira/browse/CB-7267 Project: Apache Cordova Issue Type: Task Components: CLI Reporter: Marcel Kinard Assignee: Marcel Kinard Priority: Minor The scope of this tools release is a minimal change to 3.5.0 so that when adding the Android platform, it will add Android 3.5.1 instead of Android 3.5.0. Nothing else is changed. Following steps at https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7267) Tools Release [Android 3.5.1] Aug 5 2014
[ https://issues.apache.org/jira/browse/CB-7267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113761#comment-14113761 ] ASF subversion and git services commented on CB-7267: - Commit 85bcbdc894aa06c1ae29097e10d8a1b5d2100c43 in cordova-android's branch refs/heads/3.5.x from [~cmarcelk] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=85bcbdc ] CB-7267 update RELEASENOTES for 3.5.1 (cherry picked from commit eb8cf56e8e7ce0419dbe444fbedaa434bf4e4009) Tools Release [Android 3.5.1] Aug 5 2014 Key: CB-7267 URL: https://issues.apache.org/jira/browse/CB-7267 Project: Apache Cordova Issue Type: Task Components: CLI Reporter: Marcel Kinard Assignee: Marcel Kinard Priority: Minor The scope of this tools release is a minimal change to 3.5.0 so that when adding the Android platform, it will add Android 3.5.1 instead of Android 3.5.0. Nothing else is changed. Following steps at https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113792#comment-14113792 ] Martin Gonzalez commented on CB-7375: - hey Ian, I'll work on this. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-3445) Move Cordova-Android Build Setup to Gradle
[ https://issues.apache.org/jira/browse/CB-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113854#comment-14113854 ] ASF subversion and git services commented on CB-3445: - Commit 233e51386073d02a9e9ee552e7f59e01c23ea508 in cordova-android's branch refs/heads/4.0.x from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=233e513 ] CB-3445: Ensure that JAR files in libs directory are included Move Cordova-Android Build Setup to Gradle -- Key: CB-3445 URL: https://issues.apache.org/jira/browse/CB-3445 Project: Apache Cordova Issue Type: Improvement Components: Android Reporter: Joe Bowser Assignee: Ian Clelland Priority: Minor Currently we're using ant for our setup, and our setup can break every time that the Android SDK updates and change its build.xml. However, the Android Team has created Gradle to be more robust such that it doesn't have the same problems as ant-based scripts. This also has the advantage of using Android Studio for development instead of Eclipse, and the ability for us to bundle resources, which is something we haven't been able to do before. Moving to Gradle has numerous advantages, but will break scripts, so this is to be moved in the post-3.0 timeframe. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113896#comment-14113896 ] Martin Gonzalez commented on CB-7375: - The problem is that WP always starts with a leading '/', and the line 43 on resolveLocalFileSystemURI, it sets the path as invalid, throwing a ENCODING_ERR: {quote} if(!uri || uri.split(:).length 2 || uri.indexOf('/') == 0) { {quote} Removing this statement, it would work without any problem: {quote} uri.indexOf('/') == 0 {quote} Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7421) Better Error Messages for missing Android sdk not build in PATH
Christian Kleineidam created CB-7421: Summary: Better Error Messages for missing Android sdk not build in PATH Key: CB-7421 URL: https://issues.apache.org/jira/browse/CB-7421 Project: Apache Cordova Issue Type: Improvement Components: Android Affects Versions: 3.5.0 Environment: Windows Reporter: Christian Kleineidam Priority: Minor When calling: cordova platform add android on a Windows machine where the Android SDK isn't in PATH Cordova aborts with an error. Currently the Error message is Error: An error occurred while listing Android targets. While that's better than giving no explanation at all it still doesn't tell the user what he has to fix. Error: Cordova can't find Android SDK in the build PATH would be more helpful for the user. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113920#comment-14113920 ] Martin Gonzalez commented on CB-7375: - Validated over Android, everything looks good. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113931#comment-14113931 ] ASF GitHub Bot commented on CB-7375: GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-file/pull/75 [CB-7375] Remove leading slash statement from condition Windows Phone file paths starts with a leading slash, if the path is an invalid one, the native side it will report a error callback with the respective error code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-plugin-file CB-7375 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/75.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #75 commit 36134d48c1864278eb99add9db5a7ca8a4445f74 Author: Martin Gonzalez martin.c.glez.g...@gmail.com Date: 2014-08-28T16:26:24Z [CB-7375] Remove leading slash statement from condition Windows Phone file paths starts with a leading slash, if the path is an invalid one, the native side it will report a error callback with the respective error code. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113980#comment-14113980 ] Ian Clelland commented on CB-7375: -- That was the change that was in 0ffb969, which was why I asked you if it was failing on that commit as well. I do see why that line is causing the failures now; I just don't know how WP8 was passing on commit 0ffb969 or 3086907. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-3445) Move Cordova-Android Build Setup to Gradle
[ https://issues.apache.org/jira/browse/CB-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113993#comment-14113993 ] ASF subversion and git services commented on CB-3445: - Commit 7a091824466cd86a22951c3b57fdd95204021dbb in cordova-android's branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=7a09182 ] CB-3445: Ensure that JAR files in libs directory are included Move Cordova-Android Build Setup to Gradle -- Key: CB-3445 URL: https://issues.apache.org/jira/browse/CB-3445 Project: Apache Cordova Issue Type: Improvement Components: Android Reporter: Joe Bowser Assignee: Ian Clelland Priority: Minor Currently we're using ant for our setup, and our setup can break every time that the Android SDK updates and change its build.xml. However, the Android Team has created Gradle to be more robust such that it doesn't have the same problems as ant-based scripts. This also has the advantage of using Android Studio for development instead of Eclipse, and the ability for us to bundle resources, which is something we haven't been able to do before. Moving to Gradle has numerous advantages, but will break scripts, so this is to be moved in the post-3.0 timeframe. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113996#comment-14113996 ] ASF GitHub Bot commented on CB-7375: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/75 Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113995#comment-14113995 ] ASF subversion and git services commented on CB-7375: - Commit 36134d48c1864278eb99add9db5a7ca8a4445f74 in cordova-plugin-file's branch refs/heads/master from [~martin.c.glez.glez] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=36134d4 ] [CB-7375] Remove leading slash statement from condition Windows Phone file paths starts with a leading slash, if the path is an invalid one, the native side it will report a error callback with the respective error code. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114016#comment-14114016 ] Martin Gonzalez commented on CB-7375: - Yeah and still does using 0ffb969, I have started over, double checking and it doesn't reach to that condition it's extremely weird and erratic Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114023#comment-14114023 ] Martin Gonzalez commented on CB-7375: - I'll debug again using that specific commit get the entries and compare the properties. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7216) Vibration - align with w3c spec WP8
[ https://issues.apache.org/jira/browse/CB-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114046#comment-14114046 ] ASF GitHub Bot commented on CB-7216: GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/21 CB-7216 API audit for vibration on wp8 Added support for: - cancelVibration (including vibration with pattern) - vibrateWithPattern - truncation of vibration when argument is 5seconds on wp (formerly exception was thrown) You can merge this pull request into a Git repository by running: $ git pull https://github.com/stacic/cordova-plugin-vibration CB-7216 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-vibration/pull/21.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21 commit faa3d626d8f941273b8edadeb48f7f30af198a53 Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-07-29T15:08:33Z CB-6914 added cancelVibration for wp8 commit 7dd0e6610be372b076daf6f6c80f4ec3aa5e0df4 Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-07-29T15:24:43Z CB-6916 added vibrateWithPattern for wp8 Also change to cancelVibration to allow for canceling a pattern commit 6899790d10a951a858dd1bb2df0df20d0e010d26 Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-07-29T15:36:48Z CB-7218 truncate vibration to 5 secs for WP8 wp8 throws an error if given timespan 5 secs for vibration. It should truncate the vibration instead. commit 463dbfa9c5f69dc2f1ec6c2b1a8c5b2664d051a1 Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-08-25T16:03:26Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cordova-plugin-vibration into CB-7216 commit 6612805e61dba39ea638c6801ff4e11163fa0d70 Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-08-28T17:42:06Z CB-7216 changed cancelWasCalled boolean - changed variable name - clear at the beginning of call to vibrateWithPattern Vibration - align with w3c spec WP8 --- Key: CB-7216 URL: https://issues.apache.org/jira/browse/CB-7216 Project: Apache Cordova Issue Type: Sub-task Components: Plugin Vibration, WP8 Reporter: Staci Cooper Assignee: Staci Cooper Priority: Minor -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6855) globalization.spec.37 fails on wp8
[ https://issues.apache.org/jira/browse/CB-6855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114068#comment-14114068 ] ASF GitHub Bot commented on CB-6855: GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/21 Mark tests for unimplemented features as pending For the getNumberPattern specs, the 'pattern' property isn't supported on wp8, causing the relevant specs to fail and potentially obfuscate problems with those properties which ARE implemented. I moved checks for this property into separate specs, marked 'pending' for wp8 to indicate failure due to lack of implementation. getCurrencyPattern is not implemented at all, so marked the entire spec pending for wp. CB-6855, -6856, -6857, -6858 You can merge this pull request into a Git repository by running: $ git pull https://github.com/stacic/cordova-plugin-globalization fixtests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-globalization/pull/21.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21 commit 20e53666c68e96cdd10b8c87592af65c671c00e7 Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-07-29T19:33:02Z CB-6855 Marked failing test as pending on wp8 pattern property not supported on WP8, so I removed the relevant checks into a separate test which is marked pending for WP. commit 0ed0cd7e27cafc818ad358a12599da36226e4b91 Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-07-29T19:38:56Z CB-6856 Marked failing test as pending on wp8 Made a test which fails on wp mark as pending instead, as test fails due to lack of implementation. commit 616bfc4589fac125e270335832724a81c2df4be8 Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-07-29T19:51:43Z CB-6857 Marked failing test as pending on wp8 spec.39 fails due to lack of implementation of one property. Moved property into own test and mark pending for wp8 commit e8dd4c7e955e4297c7bd9cb366074a9fd83b9d7c Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-07-29T19:54:15Z CB-6858 getCurrencyPattern test pending for wp getCurrencyPattern is unimplemented in wp, so marked test pending rather than failing. commit 18befa42b843a30868424acd2daded286528ebd1 Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-08-28T17:56:23Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cordova-plugin-globalization into fixtests globalization.spec.37 fails on wp8 -- Key: CB-6855 URL: https://issues.apache.org/jira/browse/CB-6855 Project: Apache Cordova Issue Type: Test Components: mobile-spec, WP8 Affects Versions: 3.5.0 Reporter: Staci Cooper Assignee: Staci Cooper Priority: Minor -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114091#comment-14114091 ] Edna Morales commented on CB-7375: -- It looks like this change is breaking 12 file plugin tests on iOS (on the first run, 55 fail if I do the run again). Everything works fine up to this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=dd51229d9bd1978e8e327396fb449a88b0f1b064 Changes after that commit begin to break things on iOS. The original 12 breakages are: spec 82 - error removing file specs 85 - 94 - error creating file spec 106 - error creating file all of the above with error code 1 Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114121#comment-14114121 ] Martin Gonzalez commented on CB-7375: - Starting on a new Windows 8 enviroment, I've got 8 failures over Windows Phone using 0ffb969 Specs: 9, 9.5, 15, 82, 110, 122, 123, 124. Some of the entries are getting leading slashes on fullPath properties, and at others no. I'm getting timeouts on the callbacks, I'll investigate on the native side. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114135#comment-14114135 ] Martin Gonzalez commented on CB-7375: - If moveTo copyTo are going to transfer a file to a parent path location, if the entry it doesn't retrieve or provide a filesytem, it would be logically assign the parent.filesystem information to that entry. that property it must be on the parent object, because always gonna be a DirectoryEntry. var fs = (entry.filesystem entry.filesystem.name) ? new FileSystem(entry.filesystem.name, { name: , fullPath: / }) : parent.filesystem; Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7385) [Release + 3.6.0] Branch Test Tag RC1 for Android
[ https://issues.apache.org/jira/browse/CB-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114170#comment-14114170 ] ASF subversion and git services commented on CB-7385: - Commit 64a01382f490724ddd45ed976ee9d8c129dfc63c in cordova-amazon-fireos's branch refs/heads/master from [~cmarcelk] [ https://git-wip-us.apache.org/repos/asf?p=cordova-amazon-fireos.git;h=64a0138 ] CB-7385 update cordova.js for testing prior to branch/tag [Release + 3.6.0] Branch Test Tag RC1 for Android - Key: CB-7385 URL: https://issues.apache.org/jira/browse/CB-7385 Project: Apache Cordova Issue Type: Sub-task Components: Android Reporter: Steve Gill Fix For: 3.6.0 Refer to Workflow here: http://wiki.apache.org/cordova/CuttingReleases -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-3445) Move Cordova-Android Build Setup to Gradle
[ https://issues.apache.org/jira/browse/CB-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114172#comment-14114172 ] ASF subversion and git services commented on CB-3445: - Commit e5e5c5e04dd3953bdd6bff0070871561b19d7cb0 in cordova-amazon-fireos's branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-amazon-fireos.git;h=e5e5c5e ] CB-3445: Ensure that JAR files in libs directory are included Move Cordova-Android Build Setup to Gradle -- Key: CB-3445 URL: https://issues.apache.org/jira/browse/CB-3445 Project: Apache Cordova Issue Type: Improvement Components: Android Reporter: Joe Bowser Assignee: Ian Clelland Priority: Minor Currently we're using ant for our setup, and our setup can break every time that the Android SDK updates and change its build.xml. However, the Android Team has created Gradle to be more robust such that it doesn't have the same problems as ant-based scripts. This also has the advantage of using Android Studio for development instead of Eclipse, and the ability for us to bundle resources, which is something we haven't been able to do before. Moving to Gradle has numerous advantages, but will break scripts, so this is to be moved in the post-3.0 timeframe. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7291) Externally-launchable applications should be configurable
[ https://issues.apache.org/jira/browse/CB-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114174#comment-14114174 ] ASF subversion and git services commented on CB-7291: - Commit bb2029db21e78bc307e9fefb4eb1e6761e3ba2b4 in cordova-amazon-fireos's branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-amazon-fireos.git;h=bb2029d ] CB-7291: Add external-launch-whitelist and use it for filtering intent launches Externally-launchable applications should be configurable - Key: CB-7291 URL: https://issues.apache.org/jira/browse/CB-7291 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Reporter: Ian Clelland Assignee: Ian Clelland Priority: Blocker Fix For: 3.6.0 Cordova Android versions up to 3.5.0 would launch any and all external applications by URL. Any URL not explicitly whitelisted was sent to the Android intent system for handling. This was the cause of the security vulnerabilities reported by IBM and disclosed in CVE-2014-3502. Cordova Android 3.5.1 was released to fix this, which it did by disabling explicit intents, and explaining how to use a plugin to block other URL schemes if desired. We want to have a better official solution than this, so that developers can easily configure which applications (sms, email, maps, etc) should be launchable from their Cordova app. *Proposal* The proposed solution is to maintain a second whitelist within the app, for URL patterns which may be used to launch external applications. Then, on URL loading, these tests will occur (in order): # URLs which are whitelisted internally (existing list) will cause internal navigation # URLs which are whitelisted externally (new list) will attempt to launch an intent to handle it # URLs which are not whitelisted at all (in neither list) will be blocked. *Configuration* URLs can be added to the new (external) whitelist through an extension to the {{config.xml}} whitelist syntax: {code} access origin=sms:* launch-external=yes / {code} (Any non-empty value for the {{launch-external}} attribute will be considered true when parsing the {{config.xml}} file) *Open questions* (one about forward-thinking security, the other about backwards-compatibility): # What should the default external whitelist be in the application template that we ship? This will be the case for new apps build with 3.6.0. # What should the default external whitelist be when there are no {{access launch-external=yes}} tags in {{config.xml}}? This will be the case for apps which are upgrading to 3.6.0. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7410) lots of breakages of the Android native tests
[ https://issues.apache.org/jira/browse/CB-7410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114171#comment-14114171 ] ASF subversion and git services commented on CB-7410: - Commit 58877a5440da33b1c04b01f84e0f8440f033b2fd in cordova-amazon-fireos's branch refs/heads/master from [~cmarcelk] [ https://git-wip-us.apache.org/repos/asf?p=cordova-amazon-fireos.git;h=58877a5 ] CB-7410 clarify the title lots of breakages of the Android native tests - Key: CB-7410 URL: https://issues.apache.org/jira/browse/CB-7410 Project: Apache Cordova Issue Type: Bug Components: Android Reporter: Marcel Kinard Some of these may be bugs in the tests, but it would be good to fix those and verify there aren't functional breakages or API changes. See cordova-android/test. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-3445) Move Cordova-Android Build Setup to Gradle
[ https://issues.apache.org/jira/browse/CB-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114276#comment-14114276 ] ASF subversion and git services commented on CB-3445: - Commit 34dde535068579b762dcda89ba92f8ab8adf8a97 in cordova-android's branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=34dde53 ] CB-3445: Add environment variable 'BUILD_MULTIPLE_APKS' for splitting APKs based on architecture Move Cordova-Android Build Setup to Gradle -- Key: CB-3445 URL: https://issues.apache.org/jira/browse/CB-3445 Project: Apache Cordova Issue Type: Improvement Components: Android Reporter: Joe Bowser Assignee: Ian Clelland Priority: Minor Currently we're using ant for our setup, and our setup can break every time that the Android SDK updates and change its build.xml. However, the Android Team has created Gradle to be more robust such that it doesn't have the same problems as ant-based scripts. This also has the advantage of using Android Studio for development instead of Eclipse, and the ability for us to bundle resources, which is something we haven't been able to do before. Moving to Gradle has numerous advantages, but will break scripts, so this is to be moved in the post-3.0 timeframe. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-3445) Move Cordova-Android Build Setup to Gradle
[ https://issues.apache.org/jira/browse/CB-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114280#comment-14114280 ] ASF subversion and git services commented on CB-3445: - Commit 623b2306ca0b2cf257734e7ca00acfc1538fa08e in cordova-android's branch refs/heads/4.0.x from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=623b230 ] CB-3445: Add environment variable 'BUILD_MULTIPLE_APKS' for splitting APKs based on architecture Move Cordova-Android Build Setup to Gradle -- Key: CB-3445 URL: https://issues.apache.org/jira/browse/CB-3445 Project: Apache Cordova Issue Type: Improvement Components: Android Reporter: Joe Bowser Assignee: Ian Clelland Priority: Minor Currently we're using ant for our setup, and our setup can break every time that the Android SDK updates and change its build.xml. However, the Android Team has created Gradle to be more robust such that it doesn't have the same problems as ant-based scripts. This also has the advantage of using Android Studio for development instead of Eclipse, and the ability for us to bundle resources, which is something we haven't been able to do before. Moving to Gradle has numerous advantages, but will break scripts, so this is to be moved in the post-3.0 timeframe. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114442#comment-14114442 ] ASF GitHub Bot commented on CB-7375: GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-file/pull/76 [CB-7375][Entry] set proper filesystem in Entry, when moveTo or copyTo When the native side it doesn't return any kind of value related directly related with the fileSystem, it has to be recreated after a copy, however, it makes perfect sense, that when the entry for the copied or moved file if there's no value in entry.fileSystem, it takes the filesystem property from the parent directory that it has been moved to or copied to. So instead of return a null object or take the previous filesystem(origin) from wherever location it was copied or moved from. It would be better take the parent filesystem name and recreate it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-plugin-file CB-7375 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/76.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #76 commit 84ea94a94e68c2f4ef5c28ec91338b5932f44610 Author: Martin Gonzalez martin.c.glez.g...@gmail.com Date: 2014-08-28T21:53:10Z [CB-7375][Entry] get proper filesystem in Entry When the native side it doesn't return any kind of value related directly with the fileSystem, it has to be recreated after a copy, however, it makes perfect sense that, when the entry for the copied or moved file if there's no value in entry.fileSystem, it takes the filesystem property from the parent directory that it has been moved to or copied to. So instead of return a null object or take the previous filesystem(origin) from whatever location it was copied from. It would be better take the parent filesystem name and recreate it. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7422) [File tests][126 128] use proper filesystem to compare with
Martin Gonzalez created CB-7422: --- Summary: [File tests][126 128] use proper filesystem to compare with Key: CB-7422 URL: https://issues.apache.org/jira/browse/CB-7422 Project: Apache Cordova Issue Type: Bug Components: mobile-spec, Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Martin Gonzalez Priority: Minor Fix For: 3.6.0 Specs 126 128, are trying to compare against a fullPath that it supposed to canonically match with the provided one, although the entry it has to be located over the {quote} TEMPORARY {quote} file system, but the fullPath variable to compare against the entry.fullVariable, it's created using the root or {quote} PERSISTENT {quote} fileSystem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-7422) [File tests][126 128] use proper filesystem to compare with
[ https://issues.apache.org/jira/browse/CB-7422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Gonzalez updated CB-7422: Description: Specs 126 128, are trying to compare against a fullPath that it supposed to canonically match with the provided one, although the entry it has to be located over the _emphasis_ TEMPORARY_emphasis_ file system, but the fullPath variable to compare against the entry.fullVariable, it's created using the root or _emphasis_ PERSISTENT _emphasis_ fileSystem. (was: Specs 126 128, are trying to compare against a fullPath that it supposed to canonically match with the provided one, although the entry it has to be located over the {quote} TEMPORARY {quote} file system, but the fullPath variable to compare against the entry.fullVariable, it's created using the root or {quote} PERSISTENT {quote} fileSystem.) [File tests][126 128] use proper filesystem to compare with - Key: CB-7422 URL: https://issues.apache.org/jira/browse/CB-7422 Project: Apache Cordova Issue Type: Bug Components: mobile-spec, Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Martin Gonzalez Priority: Minor Labels: mobilespec, plugin-file Fix For: 3.6.0 Specs 126 128, are trying to compare against a fullPath that it supposed to canonically match with the provided one, although the entry it has to be located over the _emphasis_ TEMPORARY_emphasis_ file system, but the fullPath variable to compare against the entry.fullVariable, it's created using the root or _emphasis_ PERSISTENT _emphasis_ fileSystem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-7422) [File tests][126 128] use proper filesystem to compare with
[ https://issues.apache.org/jira/browse/CB-7422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Gonzalez updated CB-7422: Description: Specs 126 128, are trying to compare against a fullPath that it supposed to canonically match with the provided one, although the entry it has to be located over the 'TEMPORARY' file system, but the fullPath variable to compare against the entry.fullVariable, it's created using the root or 'PERSISTENT' fileSystem. (was: Specs 126 128, are trying to compare against a fullPath that it supposed to canonically match with the provided one, although the entry it has to be located over the 'TEMPORARY' file system, but the fullPath variable to compare against the entry.fullVariable, it's created using the root or _emphasis_ PERSISTENT _emphasis_ fileSystem.) [File tests][126 128] use proper filesystem to compare with - Key: CB-7422 URL: https://issues.apache.org/jira/browse/CB-7422 Project: Apache Cordova Issue Type: Bug Components: mobile-spec, Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Martin Gonzalez Priority: Minor Labels: mobilespec, plugin-file Fix For: 3.6.0 Specs 126 128, are trying to compare against a fullPath that it supposed to canonically match with the provided one, although the entry it has to be located over the 'TEMPORARY' file system, but the fullPath variable to compare against the entry.fullVariable, it's created using the root or 'PERSISTENT' fileSystem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-7422) [File tests][126 128] use proper filesystem to compare with
[ https://issues.apache.org/jira/browse/CB-7422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Gonzalez updated CB-7422: Description: Specs 126 128, are trying to compare against a fullPath that it supposed to canonically match with the provided one, although the entry it has to be located over the 'TEMPORARY' file system, but the fullPath variable to compare against the entry.fullVariable, it's created using the root or _emphasis_ PERSISTENT _emphasis_ fileSystem. (was: Specs 126 128, are trying to compare against a fullPath that it supposed to canonically match with the provided one, although the entry it has to be located over the _emphasis_ TEMPORARY_emphasis_ file system, but the fullPath variable to compare against the entry.fullVariable, it's created using the root or _emphasis_ PERSISTENT _emphasis_ fileSystem.) [File tests][126 128] use proper filesystem to compare with - Key: CB-7422 URL: https://issues.apache.org/jira/browse/CB-7422 Project: Apache Cordova Issue Type: Bug Components: mobile-spec, Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Martin Gonzalez Priority: Minor Labels: mobilespec, plugin-file Fix For: 3.6.0 Specs 126 128, are trying to compare against a fullPath that it supposed to canonically match with the provided one, although the entry it has to be located over the 'TEMPORARY' file system, but the fullPath variable to compare against the entry.fullVariable, it's created using the root or _emphasis_ PERSISTENT _emphasis_ fileSystem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7422) [File tests][126 128] use proper filesystem to compare with
[ https://issues.apache.org/jira/browse/CB-7422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114500#comment-14114500 ] ASF GitHub Bot commented on CB-7422: GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-file/pull/77 [CB-7422][File Tests] Use proper fileSystem to create fullPath The filesystem uses root filesystem (PERSISTENT) to compare with a TEMPORARY filesystem. This is wrong, if TEMPORARY, var 'temp_root' should be used to assign value to fullPath. Tested over android WP8, everything OK. This wasn't caught before, because android : fullPath is: /file, and (root.fullPath + file) returns --- /file. although for Windows Phone: the fullPath provides the nativePath as /tmp//file, when it tries to compare with (root.fullPath + file) gives //file. But tmp_root.fullPath provides the right path: /tmp/ to compare with. Android it doesn't provide any different fullPath property if temporary or persistent, the right path it's contained over the Native or Internal path. You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-plugin-file CB-7422 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/77.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #77 commit 690cbdf3edf2daf273bd7d18ce51e0b9cc76b8c1 Author: Martin Gonzalez martin.c.glez.g...@gmail.com Date: 2014-08-28T22:18:34Z [CB-7422][File Tests] Use proper fileSystem to create fullPath The filesystem uses root filesystem (PERSISTENT) to compare with a TEMPORARY filesystem. This is wrong, if TEMPORARY, temp_root, should be used to assign value to fullPath. [File tests][126 128] use proper filesystem to compare with - Key: CB-7422 URL: https://issues.apache.org/jira/browse/CB-7422 Project: Apache Cordova Issue Type: Bug Components: mobile-spec, Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Martin Gonzalez Priority: Minor Labels: mobilespec, plugin-file Fix For: 3.6.0 Specs 126 128, are trying to compare against a fullPath that it supposed to canonically match with the provided one, although the entry it has to be located over the 'TEMPORARY' file system, but the fullPath variable to compare against the entry.fullVariable, it's created using the root or 'PERSISTENT' fileSystem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114518#comment-14114518 ] ASF GitHub Bot commented on CB-7375: Github user martincgg commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/76#issuecomment-53815245 I've tested this over Android and WP8, it looks great. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7422) [File tests][126 128] use proper filesystem to compare with
[ https://issues.apache.org/jira/browse/CB-7422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114519#comment-14114519 ] ASF GitHub Bot commented on CB-7422: Github user martincgg commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/77#issuecomment-53815400 Tested over Android and WP8, it works pretty good. [File tests][126 128] use proper filesystem to compare with - Key: CB-7422 URL: https://issues.apache.org/jira/browse/CB-7422 Project: Apache Cordova Issue Type: Bug Components: mobile-spec, Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Martin Gonzalez Priority: Minor Labels: mobilespec, plugin-file Fix For: 3.6.0 Specs 126 128, are trying to compare against a fullPath that it supposed to canonically match with the provided one, although the entry it has to be located over the 'TEMPORARY' file system, but the fullPath variable to compare against the entry.fullVariable, it's created using the root or 'PERSISTENT' fileSystem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7423) mobilespec test failures on iOS
Edna Morales created CB-7423: Summary: mobilespec test failures on iOS Key: CB-7423 URL: https://issues.apache.org/jira/browse/CB-7423 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 3.5.0 Reporter: Edna Morales Fix For: 3.6.0 Running the automated tests for each plugin individually (there are false failures when run all together in mobilespec) results in the following: File-transfer - 3 failures: -spec 8 should be able to download a file using https: error timeout - async callback was not invoked... -spec 28 should be able to download a file using local paths: reference error can't find variable lastProgressEvent in file:///... -spec 29 should be able to upload a file using local paths: reference error can't find variable lastProgressEvent in file:///... File - 2 failures (only after running a second time) -spec 57 copyTo file: Error copying file {code:12} -spec 60 copyTo directory to backup at same root directory: Error copying directory {code:12} It looks like the files aren't getting deleted after the first run, which is causing these errors the second time -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7423) mobilespec test failures on iOS
[ https://issues.apache.org/jira/browse/CB-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114579#comment-14114579 ] Shazron Abdullah commented on CB-7423: -- Changing the component to the specific plugins. iOS is usually for the core stuff. mobilespec test failures on iOS --- Key: CB-7423 URL: https://issues.apache.org/jira/browse/CB-7423 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 3.5.0 Reporter: Edna Morales Fix For: 3.6.0 Running the automated tests for each plugin individually (there are false failures when run all together in mobilespec) results in the following: File-transfer - 3 failures: -spec 8 should be able to download a file using https: error timeout - async callback was not invoked... -spec 28 should be able to download a file using local paths: reference error can't find variable lastProgressEvent in file:///... -spec 29 should be able to upload a file using local paths: reference error can't find variable lastProgressEvent in file:///... File - 2 failures (only after running a second time) -spec 57 copyTo file: Error copying file {code:12} -spec 60 copyTo directory to backup at same root directory: Error copying directory {code:12} It looks like the files aren't getting deleted after the first run, which is causing these errors the second time -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-7423) mobilespec test failures on iOS
[ https://issues.apache.org/jira/browse/CB-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-7423: - Component/s: (was: iOS) Plugin File Transfer Plugin File Environment: iOS mobilespec test failures on iOS --- Key: CB-7423 URL: https://issues.apache.org/jira/browse/CB-7423 Project: Apache Cordova Issue Type: Bug Components: Plugin File, Plugin File Transfer Affects Versions: 3.5.0 Environment: iOS Reporter: Edna Morales Fix For: 3.6.0 Running the automated tests for each plugin individually (there are false failures when run all together in mobilespec) results in the following: File-transfer - 3 failures: -spec 8 should be able to download a file using https: error timeout - async callback was not invoked... -spec 28 should be able to download a file using local paths: reference error can't find variable lastProgressEvent in file:///... -spec 29 should be able to upload a file using local paths: reference error can't find variable lastProgressEvent in file:///... File - 2 failures (only after running a second time) -spec 57 copyTo file: Error copying file {code:12} -spec 60 copyTo directory to backup at same root directory: Error copying directory {code:12} It looks like the files aren't getting deleted after the first run, which is causing these errors the second time -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7424) Wrong docs: anchor tags are not supported by the InAppBrowser
Shazron Abdullah created CB-7424: Summary: Wrong docs: anchor tags are not supported by the InAppBrowser Key: CB-7424 URL: https://issues.apache.org/jira/browse/CB-7424 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Reporter: Shazron Abdullah This plugin provides a web browser view that displays when calling window.open(), or when opening a link formed as a target=_blank. Not sure who added that last part, it was never in the original docs. See CB-6747 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7424) Wrong docs: anchor tags are not supported by the InAppBrowser
[ https://issues.apache.org/jira/browse/CB-7424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114644#comment-14114644 ] Shazron Abdullah commented on CB-7424: -- This doc was added between 3.0.0 and 3.1.0 release, not sure why it was put in, perhaps some platforms do support it. Put out a query in cordova-dev ML. Wrong docs: anchor tags are not supported by the InAppBrowser - Key: CB-7424 URL: https://issues.apache.org/jira/browse/CB-7424 Project: Apache Cordova Issue Type: Bug Components: Plugin InAppBrowser Reporter: Shazron Abdullah This plugin provides a web browser view that displays when calling window.open(), or when opening a link formed as a target=_blank. Not sure who added that last part, it was never in the original docs. See CB-6747 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7419) [plugin-file][WP8] Get directory metadata returns error callback [CODE 1]
[ https://issues.apache.org/jira/browse/CB-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114693#comment-14114693 ] ASF subversion and git services commented on CB-7419: - Commit 9618aa31be4b4b90a5b5d034a1ebeb5d7b70c611 in cordova-plugin-file's branch refs/heads/master from [~purplecabbage] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=9618aa3 ] Merge branch 'CB-7419' of https://github.com/martincgg/cordova-plugin-file [plugin-file][WP8] Get directory metadata returns error callback [CODE 1] - Key: CB-7419 URL: https://issues.apache.org/jira/browse/CB-7419 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Martin Gonzalez Labels: plugin-file Fix For: 3.6.0 on Windows Phone, get metadata from a directory is returns a error callback CODE 1, claiming that it couldn't find the directory, however the directory is present on the fileSystem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7419) [plugin-file][WP8] Get directory metadata returns error callback [CODE 1]
[ https://issues.apache.org/jira/browse/CB-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114692#comment-14114692 ] ASF subversion and git services commented on CB-7419: - Commit 1dd70b3fe92f2371dc2f8ab3666fc25c1ce488c8 in cordova-plugin-file's branch refs/heads/master from [~martin.c.glez.glez] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=1dd70b3 ] [CB-7419][WP8] Added support to get metada from dir The error CODE 1, in the callback it was about the a failed attempt to get the size of a directory using IsolatedStorageFileStream, get that information, throwing a SystemException 'DirectoryNotFoundException'. Instead IsolatedStorageFileStream to get that information from a directory, now uses Application.GetResourceStream, to that information from the provided path, only if directory. If other file it would use 'IsolatedStorageFileStream' [plugin-file][WP8] Get directory metadata returns error callback [CODE 1] - Key: CB-7419 URL: https://issues.apache.org/jira/browse/CB-7419 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Martin Gonzalez Labels: plugin-file Fix For: 3.6.0 on Windows Phone, get metadata from a directory is returns a error callback CODE 1, claiming that it couldn't find the directory, however the directory is present on the fileSystem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114704#comment-14114704 ] ASF GitHub Bot commented on CB-7375: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/76 Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114702#comment-14114702 ] ASF subversion and git services commented on CB-7375: - Commit 84ea94a94e68c2f4ef5c28ec91338b5932f44610 in cordova-plugin-file's branch refs/heads/master from [~martin.c.glez.glez] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=84ea94a ] [CB-7375][Entry] get proper filesystem in Entry When the native side it doesn't return any kind of value related directly with the fileSystem, it has to be recreated after a copy, however, it makes perfect sense that, when the entry for the copied or moved file if there's no value in entry.fileSystem, it takes the filesystem property from the parent directory that it has been moved to or copied to. So instead of return a null object or take the previous filesystem(origin) from whatever location it was copied from. It would be better take the parent filesystem name and recreate it. Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7422) [File tests][126 128] use proper filesystem to compare with
[ https://issues.apache.org/jira/browse/CB-7422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114706#comment-14114706 ] ASF subversion and git services commented on CB-7422: - Commit ba3243599afd00a6828011b156c30e5910cc6205 in cordova-plugin-file's branch refs/heads/master from [~purplecabbage] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=ba32435 ] Merge branch 'CB-7422' of https://github.com/martincgg/cordova-plugin-file [File tests][126 128] use proper filesystem to compare with - Key: CB-7422 URL: https://issues.apache.org/jira/browse/CB-7422 Project: Apache Cordova Issue Type: Bug Components: mobile-spec, Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Martin Gonzalez Priority: Minor Labels: mobilespec, plugin-file Fix For: 3.6.0 Specs 126 128, are trying to compare against a fullPath that it supposed to canonically match with the provided one, although the entry it has to be located over the 'TEMPORARY' file system, but the fullPath variable to compare against the entry.fullVariable, it's created using the root or 'PERSISTENT' fileSystem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7375) Investigate breaking changes at file plugin
[ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114703#comment-14114703 ] ASF subversion and git services commented on CB-7375: - Commit 0f200a5d9ee529df116b92575351a1447c62970f in cordova-plugin-file's branch refs/heads/master from [~purplecabbage] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=0f200a5 ] Merge branch 'CB-7375' of https://github.com/martincgg/cordova-plugin-file Investigate breaking changes at file plugin --- Key: CB-7375 URL: https://issues.apache.org/jira/browse/CB-7375 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Labels: file Fix For: 3.6.0 Attachments: Jasmine-Report-FileMediaPlugin-tests_149-30-1.txt Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c Are breaking changes to this plugin, affecting other platforms as android. Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7422) [File tests][126 128] use proper filesystem to compare with
[ https://issues.apache.org/jira/browse/CB-7422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114709#comment-14114709 ] ASF GitHub Bot commented on CB-7422: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/77 [File tests][126 128] use proper filesystem to compare with - Key: CB-7422 URL: https://issues.apache.org/jira/browse/CB-7422 Project: Apache Cordova Issue Type: Bug Components: mobile-spec, Plugin File Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Martin Gonzalez Priority: Minor Labels: mobilespec, plugin-file Fix For: 3.6.0 Specs 126 128, are trying to compare against a fullPath that it supposed to canonically match with the provided one, although the entry it has to be located over the 'TEMPORARY' file system, but the fullPath variable to compare against the entry.fullVariable, it's created using the root or 'PERSISTENT' fileSystem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7413) File plugin can't resolve native 'ms-appdata' URIs
[ https://issues.apache.org/jira/browse/CB-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114712#comment-14114712 ] ASF subversion and git services commented on CB-7413: - Commit df66c4c417643bb02a551c43e4d96142c5894c67 in cordova-plugin-file's branch refs/heads/master from [~purplecabbage] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=df66c4c ] Merge branch 'CB-7413' of https://github.com/MSOpenTech/cordova-plugin-file File plugin can't resolve native 'ms-appdata' URIs -- Key: CB-7413 URL: https://issues.apache.org/jira/browse/CB-7413 Project: Apache Cordova Issue Type: Bug Components: Plugin File Reporter: Vladimir Kotikov Labels: file, plugin-file, windows Windows 8/8.1 platform provides own {{ms-appdata://}} scheme for accessing files, stored in application data folder. Unfortunately File plugin can't resolve such URIs to native (by {{resolveLocalFileSystemURI}} method), and due to this can't be used, for example, with Camera plugin which returns such urls for captured files. Another, but related issue - broken {{file://}} support. Such URL are never resolved due to some logic at the start of {{resolveLocalFileSystemURI}} method. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7413) File plugin can't resolve native 'ms-appdata' URIs
[ https://issues.apache.org/jira/browse/CB-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114713#comment-14114713 ] ASF GitHub Bot commented on CB-7413: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/70 File plugin can't resolve native 'ms-appdata' URIs -- Key: CB-7413 URL: https://issues.apache.org/jira/browse/CB-7413 Project: Apache Cordova Issue Type: Bug Components: Plugin File Reporter: Vladimir Kotikov Labels: file, plugin-file, windows Windows 8/8.1 platform provides own {{ms-appdata://}} scheme for accessing files, stored in application data folder. Unfortunately File plugin can't resolve such URIs to native (by {{resolveLocalFileSystemURI}} method), and due to this can't be used, for example, with Camera plugin which returns such urls for captured files. Another, but related issue - broken {{file://}} support. Such URL are never resolved due to some logic at the start of {{resolveLocalFileSystemURI}} method. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7413) File plugin can't resolve native 'ms-appdata' URIs
[ https://issues.apache.org/jira/browse/CB-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114711#comment-14114711 ] ASF subversion and git services commented on CB-7413: - Commit 8ee7aa8264e190f7ff5e6fe2053b3a53bba1ea35 in cordova-plugin-file's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=8ee7aa8 ] CB-7413 Adds support of 'ms-appdata://' URIs File plugin can't resolve native 'ms-appdata' URIs -- Key: CB-7413 URL: https://issues.apache.org/jira/browse/CB-7413 Project: Apache Cordova Issue Type: Bug Components: Plugin File Reporter: Vladimir Kotikov Labels: file, plugin-file, windows Windows 8/8.1 platform provides own {{ms-appdata://}} scheme for accessing files, stored in application data folder. Unfortunately File plugin can't resolve such URIs to native (by {{resolveLocalFileSystemURI}} method), and due to this can't be used, for example, with Camera plugin which returns such urls for captured files. Another, but related issue - broken {{file://}} support. Such URL are never resolved due to some logic at the start of {{resolveLocalFileSystemURI}} method. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-7413) File plugin can't resolve native 'ms-appdata' URIs
[ https://issues.apache.org/jira/browse/CB-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesse MacFadyen resolved CB-7413. - Resolution: Fixed File plugin can't resolve native 'ms-appdata' URIs -- Key: CB-7413 URL: https://issues.apache.org/jira/browse/CB-7413 Project: Apache Cordova Issue Type: Bug Components: Plugin File Reporter: Vladimir Kotikov Labels: file, plugin-file, windows Windows 8/8.1 platform provides own {{ms-appdata://}} scheme for accessing files, stored in application data folder. Unfortunately File plugin can't resolve such URIs to native (by {{resolveLocalFileSystemURI}} method), and due to this can't be used, for example, with Camera plugin which returns such urls for captured files. Another, but related issue - broken {{file://}} support. Such URL are never resolved due to some logic at the start of {{resolveLocalFileSystemURI}} method. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7425) AJAX blocked when using cdvfile
165537 created CB-7425: -- Summary: AJAX blocked when using cdvfile Key: CB-7425 URL: https://issues.apache.org/jira/browse/CB-7425 Project: Apache Cordova Issue Type: Bug Affects Versions: 3.4.0 Environment: Android 4.2.2, Phonegap 3.4 (CORDOVA_JS_BUILD_LABEL = '3.4.0') Reporter: 165537 Doing AJAX from packaged files (eg location file:///android_asset/www/index.html) works well, but doing it from local files (eg cdvfile://localhost/persistent/TEST/index.html) does not. I guess it has to do with the same-origin policy. Is there anything that can be done to make it work? If I were reading files from the internet, I would set the web server to add some Access-Control-Allow-Origin headers, but here there's no web server. Using jsonp would work, but it'd mean changing the code in the server and in the app. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7426) Opening local page (cdvfile://path/index.html) does not work anymore
165537 created CB-7426: -- Summary: Opening local page (cdvfile://path/index.html) does not work anymore Key: CB-7426 URL: https://issues.apache.org/jira/browse/CB-7426 Project: Apache Cordova Issue Type: Bug Affects Versions: 3.5.0 Environment: Android 4.1.2, 4.4.2, Phonegap 3.5.0 (Cordova 3.5.1) Reporter: 165537 My app copies files locally using the FileAPI. This works well on both Phonegap 3.4.0 and 3.5.0. Then it opens an html file that was copied, by doing window.location = cdvfile://localhost/persistent/TEST/index.html; (the path is not hardcoded but retrieved by doing a myDirEntry.toURL()) This works perfectly well in Phonegap 3.4.0 but not in Phonegap 3.5.0. In 3.5.0 nothing happens: the app stays on the same page, no exception seem to be thrown. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7427) Cannot change location to local file eg cdvfile://path/index.html
165537 created CB-7427: -- Summary: Cannot change location to local file eg cdvfile://path/index.html Key: CB-7427 URL: https://issues.apache.org/jira/browse/CB-7427 Project: Apache Cordova Issue Type: Bug Affects Versions: 3.5.0 Environment: Android 4.1.2, 4.4.2, Phonegap 3.5.0 (Cordova 3.5.1) Reporter: 165537 My app copies files on the device using the FileAPI. This works well in 3.4.0 and 3.5.0. Then it opens an html file by doing window.location = cdvfile://localhost/persistent/TEST/index.html; Note that the path is not hard coded but uses something like myDirEntry.toURL(). This works well in 3.4.0 (tested on several versions of Android and iOS), but it does not work in 3.5.0 (tested only on Android 4.1.2 and 4.4.2 - FYI the computed path is the same in 3.4.0 and 3.5.0). When trying to load the file, nothing happens. The app stays in the current page, no exception seems to be thrown. In both cases I use the org.apache.cordova.file plugin version 1.0.1 (the one available on Phonegap Build). Has something changed in Phonegap 3.5.0? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-7426) Opening local page (cdvfile://path/index.html) does not work anymore
[ https://issues.apache.org/jira/browse/CB-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 165537 closed CB-7426. -- Resolution: Duplicate Opening local page (cdvfile://path/index.html) does not work anymore Key: CB-7426 URL: https://issues.apache.org/jira/browse/CB-7426 Project: Apache Cordova Issue Type: Bug Affects Versions: 3.5.0 Environment: Android 4.1.2, 4.4.2, Phonegap 3.5.0 (Cordova 3.5.1) Reporter: 165537 My app copies files locally using the FileAPI. This works well on both Phonegap 3.4.0 and 3.5.0. Then it opens an html file that was copied, by doing window.location = cdvfile://localhost/persistent/TEST/index.html; (the path is not hardcoded but retrieved by doing a myDirEntry.toURL()) This works perfectly well in Phonegap 3.4.0 but not in Phonegap 3.5.0. In 3.5.0 nothing happens: the app stays on the same page, no exception seem to be thrown. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7188) Optional flag to NOT call the native Image-Preview after call navigator.camera.getPicture(...)
[ https://issues.apache.org/jira/browse/CB-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114800#comment-14114800 ] 165537 commented on CB-7188: By looking at the Android code, I wonder if such a thing is possible as the image preview page may just come from the capture app, meaning it's not something added by the camera plugin. Optional flag to NOT call the native Image-Preview after call navigator.camera.getPicture(...) -- Key: CB-7188 URL: https://issues.apache.org/jira/browse/CB-7188 Project: Apache Cordova Issue Type: Improvement Components: Plugin Camera Affects Versions: 3.4.0 Environment: At least Android and WP8. Reporter: 165537 After calling navigator.camera.getPicture(...), it could be useful to NOT display the image preview that allows the user to cancel or continue (on Android it's usually an X icon and a check icon) if the developer wants to handle that inside the app. -- This message was sent by Atlassian JIRA (v6.2#6252)