[jira] [Commented] (CB-9445) executeScript callbacks not working for iOS

[Sergey Grebnov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013302#comment-15013302
 ] 

Sergey Grebnov commented on CB-9445:


That is interesting. During my experiments I was creating a new iframe for 
every call (for simplicity)

> executeScript callbacks not working for iOS
> ---
>
> Key: CB-9445
> URL: https://issues.apache.org/jira/browse/CB-9445
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 5.1.1
> Environment: Cordova 5.1.1 (CLI), ios 3.8.0, android 4.0.2, 
> cordova-plugin-inappbrowser 1.0.1 (NPM)
>Reporter: Scott Seitz
>Assignee: jcesarmobile
>  Labels: Triaged, iOS
>
> Can someone please check to see if they are encountering the same problem I 
> am in the environment I've listed? (latest released builds of everything I 
> think)
> I open an inappbrowser window and then run an executeScript command using 
> "code:" (not "file:").  Everything works fine on Android, but on iOS, it 
> simply will NOT fire the callback function after executing the injected code. 
>  Make the "code:" as simple as you like to test it and see if you can get a 
> callback to fire.  I've dumbed it down as much as possible and can't get one 
> to fire.  I know that all instances of code I've injected have run fine in 
> the iab by using the console (against the iab) to check for the variables I 
> was creating in the code.  I can't even get a callback to fire that doesn't 
> expect a parameter to be passed back...
> Many thanks,
> Scott



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9445) executeScript callbacks not working for iOS

[Sergey Grebnov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013304#comment-15013304
 ] 

Sergey Grebnov commented on CB-9445:


What if we add uniq id for the iframe and add some check that iframe really 
exists before execute script call?

> executeScript callbacks not working for iOS
> ---
>
> Key: CB-9445
> URL: https://issues.apache.org/jira/browse/CB-9445
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 5.1.1
> Environment: Cordova 5.1.1 (CLI), ios 3.8.0, android 4.0.2, 
> cordova-plugin-inappbrowser 1.0.1 (NPM)
>Reporter: Scott Seitz
>Assignee: jcesarmobile
>  Labels: Triaged, iOS
>
> Can someone please check to see if they are encountering the same problem I 
> am in the environment I've listed? (latest released builds of everything I 
> think)
> I open an inappbrowser window and then run an executeScript command using 
> "code:" (not "file:").  Everything works fine on Android, but on iOS, it 
> simply will NOT fire the callback function after executing the injected code. 
>  Make the "code:" as simple as you like to test it and see if you can get a 
> callback to fire.  I've dumbed it down as much as possible and can't get one 
> to fire.  I know that all instances of code I've injected have run fine in 
> the iab by using the console (against the iab) to check for the variables I 
> was creating in the code.  I can't even get a callback to fire that doesn't 
> expect a parameter to be passed back...
> Many thanks,
> Scott



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-10039) Problem add Contact photos from relative and absolute path for Android

[JIRA]

Thomy Stéphane created CB-10039:
---

 Summary: Problem add Contact photos from relative and absolute 
path for Android
 Key: CB-10039
 URL: https://issues.apache.org/jira/browse/CB-10039
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Contacts
 Environment: Android
Reporter: Thomy Stéphane
Priority: Minor
 Fix For: Master


problem add Contact photos from relative and absolute path for Android: Get 
input stream from relative and full path in ContactAccessorSdk.java

Solved, attempt to merge on Github.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10039) Problem add Contact photos from relative and absolute path for Android

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013321#comment-15013321
 ] 

ASF GitHub Bot commented on CB-10039:
-

Github user vincipop commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/77#issuecomment-158021220
  
Hi @vladimir-kotikov , 
Apache CLA signed
Issue filed on JRA : https://issues.apache.org/jira/browse/CB-10039
Thanks


> Problem add Contact photos from relative and absolute path for Android
> --
>
> Key: CB-10039
> URL: https://issues.apache.org/jira/browse/CB-10039
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: Android
>Reporter: vincipop
>Priority: Minor
>  Labels: github-import
> Fix For: Master
>
>
> problem add Contact photos from relative and absolute path for Android: Get 
> input stream from relative and full path in ContactAccessorSdk.java
> Solved, attempt to merge on Github.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9200) event progress with "cordova.InAppBrowser.open"

[Sergey Grebnov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013110#comment-15013110
 ] 

Sergey Grebnov commented on CB-9200:


Error:

2015-11-19 11:01:13.320 HelloCordova[1437:19675] Warning: Attempt to present 
 on  whose view 
is not in the window hierarchy!


> event progress with "cordova.InAppBrowser.open"
> ---
>
> Key: CB-9200
> URL: https://issues.apache.org/jira/browse/CB-9200
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
> Environment: cordova-plugin-inappbrowser 1.0.0 + 
> cordova-plugin-dialogs 1.1.0 + ios 8.3 (12F69)
>Reporter: Colin Bau
>  Labels: Triaged
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> according to this
> https://github.com/apache/cordova-plugin-inappbrowser
> let me demo for example "loadstart" (other enent have the same problem)
> {code}
> var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 
> 'location=yes');
> //this line will trigger
> ref.addEventListener('loadstart', function(event) { alert(event.url); });
> //this line will never trigger
> ref.addEventListener('loadstart', function(event) { 
> navigator.notification.alert("test", null, 'title', 'ok'); });
> {code}
> is the "inappbrowser" have some conflict with "dialogs"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-9396) phonegap app crashes on getting contacts

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-9396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-9396:
-
Description: 
We are using phonegap and angularjs on our mobile app.. We are currently 
getting phone contacts and it is crashing on iphone4/s only. It is working on 
android and iphone 6. I can't seem to find where the error is.

Here is the code..

{noformat}

module.controller('someControllerName', ['$scope', '$http', function ($scope, 
$http) {
// find all contacts with 'Bob' in any name field
var options = new ContactFindOptions();
options.filter = "";
options.multiple = true;
var fields = ["displayName", "name"];
navigator.contacts.find(fields, loadAllContacts, onError, options);
$scope.viewContact = function (contact) {
buxMainNav.pushPage("contact_details.html",
{ "animation": "slide", phone_contact: contact }
);
};
$scope.$watch('searchContacts', function (data) {
if (data != undefined) {
// find all contacts with 'Bob' in any name field
var options = new ContactFindOptions();
options.filter = data;
options.multiple = true;
var fields = ["displayName", "name"];
navigator.contacts.find(fields, loadAllContacts, onError, options);
$scope.viewContact = function (contact) {
buxMainNav.pushPage("contact_details.html",
{ "animation": "slide", phone_contact: contact }
);
};
}
});
}]);
function loadAllContacts(contacts) {
var cSort = function (a, b)
{ aName = a.name.givenName; bName = b.name.givenName; return aName < bName 
? -1 : (aName == bName ? 0 : 1); }
;
var scope = 
angular.element(document.getElementById("contacts-controller")).scope();
scope.nocontactsresults = "";
scope.$apply(function () {
contacts = contacts.sort(cSort);
scope.phoneContacts = contacts;
if (scope.phoneContacts.length < 1)
{ scope.nocontactsresults = "No Results"; }
else
{ scope.nocontactsresults = ""; }
});
};
function onError(contactError) {
ons.notification.alert(
{ message: "Unable to access phonebook contacts.", title: "Contacts" }
);
};
{noformat}

  was:
We are using phonegap and angularjs on our mobile app.. We are currently 
getting phone contacts and it is crashing on iphone4/s only. It is working on 
android and iphone 6. I can't seem to find where the error is.

Here is the code..

{noformat}

module.controller('someControllerName', ['$scope', '$http', function ($scope, 
$http) {
// find all contacts with 'Bob' in any name field
var options = new ContactFindOptions();
options.filter = "";
options.multiple = true;
var fields = ["displayName", "name"];
navigator.contacts.find(fields, loadAllContacts, onError, options);
$scope.viewContact = function (contact) {
buxMainNav.pushPage("contact_details.html",
{ "animation": "slide", phone_contact: contact }
);
};
$scope.$watch('searchContacts', function (data) {
if (data != undefined) {
// find all contacts with 'Bob' in any name field
var options = new ContactFindOptions();
options.filter = data;
options.multiple = true;
var fields = ["displayName", "name"];
navigator.contacts.find(fields, loadAllContacts, onError, options);
$scope.viewContact = function (contact) {
buxMainNav.pushPage("contact_details.html",
{ "animation": "slide", phone_contact: contact }
);
};
}
});
}]);
function loadAllContacts(contacts) {
var cSort = function (a, b)
{ aName = a.name.givenName; bName = b.name.givenName; return aName < bName 
? -1 : (aName == bName ? 0 : 1); }
;
var scope = 
angular.element(document.getElementById("contacts-controller")).scope();
scope.nocontactsresults = "";
scope.$apply(function () {
contacts = contacts.sort(cSort);
scope.phoneContacts = contacts;
if (scope.phoneContacts.length < 1)
{ scope.nocontactsresults = "No Results"; }
else
{ scope.nocontactsresults = ""; }
});
};
function onError(contactError) {
ons.notification.alert(
{ message: "Unable to access phonebook contacts.", title: "Contacts" }
);
};
{noformat}


> phonegap app crashes on getting contacts
> 
>
> Key: CB-9396
> URL: https://issues.apache.org/jira/browse/CB-9396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: iphone4/s iOS
>Reporter: Edd A
>  Labels: ios, triaged
>
> We are using phonegap 

[jira] [Comment Edited] (CB-9200) event progress with "cordova.InAppBrowser.open"

[Sergey Grebnov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013138#comment-15013138
 ] 

Sergey Grebnov edited comment on CB-9200 at 11/19/15 8:32 AM:
--

This has been fixed in cordova-plugin-dialogs master


was (Author: sgrebnov):
This has been fixed in master

> event progress with "cordova.InAppBrowser.open"
> ---
>
> Key: CB-9200
> URL: https://issues.apache.org/jira/browse/CB-9200
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
> Environment: cordova-plugin-inappbrowser 1.0.0 + 
> cordova-plugin-dialogs 1.1.0 + ios 8.3 (12F69)
>Reporter: Colin Bau
>  Labels: Triaged
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> according to this
> https://github.com/apache/cordova-plugin-inappbrowser
> let me demo for example "loadstart" (other enent have the same problem)
> {code}
> var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 
> 'location=yes');
> //this line will trigger
> ref.addEventListener('loadstart', function(event) { alert(event.url); });
> //this line will never trigger
> ref.addEventListener('loadstart', function(event) { 
> navigator.notification.alert("test", null, 'title', 'ok'); });
> {code}
> is the "inappbrowser" have some conflict with "dialogs"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-9200) event progress with "cordova.InAppBrowser.open"

[Sergey Grebnov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Grebnov updated CB-9200:
---
Component/s: Plugin Dialogs

> event progress with "cordova.InAppBrowser.open"
> ---
>
> Key: CB-9200
> URL: https://issues.apache.org/jira/browse/CB-9200
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Dialogs, Plugin InAppBrowser
> Environment: cordova-plugin-inappbrowser 1.0.0 + 
> cordova-plugin-dialogs 1.1.0 + ios 8.3 (12F69)
>Reporter: Colin Bau
>  Labels: Triaged
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> according to this
> https://github.com/apache/cordova-plugin-inappbrowser
> let me demo for example "loadstart" (other enent have the same problem)
> {code}
> var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 
> 'location=yes');
> //this line will trigger
> ref.addEventListener('loadstart', function(event) { alert(event.url); });
> //this line will never trigger
> ref.addEventListener('loadstart', function(event) { 
> navigator.notification.alert("test", null, 'title', 'ok'); });
> {code}
> is the "inappbrowser" have some conflict with "dialogs"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-9396) phonegap app crashes on getting contacts

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-9396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-9396:
-
Description: 
We are using phonegap and angularjs on our mobile app.. We are currently 
getting phone contacts and it is crashing on iphone4/s only. It is working on 
android and iphone 6. I can't seem to find where the error is.

Here is the code..

{noformat}

module.controller('someControllerName', ['$scope', '$http', function ($scope, 
$http) {
// find all contacts with 'Bob' in any name field
var options = new ContactFindOptions();
options.filter = "";
options.multiple = true;
var fields = ["displayName", "name"];
navigator.contacts.find(fields, loadAllContacts, onError, options);
$scope.viewContact = function (contact) {
buxMainNav.pushPage("contact_details.html",
{ "animation": "slide", phone_contact: contact }
);
};
$scope.$watch('searchContacts', function (data) {
if (data != undefined) {
// find all contacts with 'Bob' in any name field
var options = new ContactFindOptions();
options.filter = data;
options.multiple = true;
var fields = ["displayName", "name"];
navigator.contacts.find(fields, loadAllContacts, onError, options);
$scope.viewContact = function (contact) {
buxMainNav.pushPage("contact_details.html",
{ "animation": "slide", phone_contact: contact }
);
};
}
});
}]);
function loadAllContacts(contacts) {
var cSort = function (a, b)
{ aName = a.name.givenName; bName = b.name.givenName; return aName < bName 
? -1 : (aName == bName ? 0 : 1); }
;
var scope = 
angular.element(document.getElementById("contacts-controller")).scope();
scope.nocontactsresults = "";
scope.$apply(function () {
contacts = contacts.sort(cSort);
scope.phoneContacts = contacts;
if (scope.phoneContacts.length < 1)
{ scope.nocontactsresults = "No Results"; }
else
{ scope.nocontactsresults = ""; }
});
};
function onError(contactError) {
ons.notification.alert(
{ message: "Unable to access phonebook contacts.", title: "Contacts" }
);
};
{noformat}

  was:
We are using phonegap and angularjs on our mobile app.. We are currently 
getting phone contacts and it is crashing on iphone4/s only. It is working on 
android and iphone 6. I can't seem to find where the error is.

Here is the code..

module.controller('someControllerName', ['$scope', '$http',  function($scope, 
$http) {
// find all contacts with 'Bob' in any name field
var options  = new ContactFindOptions();
options.filter   = "";
options.multiple = true;
var fields = ["displayName", "name"];
navigator.contacts.find(fields, loadAllContacts, onError, options);

$scope.viewContact = function (contact) {
buxMainNav.pushPage("contact_details.html", {
"animation": "slide",
phone_contact: contact
});
};

$scope.$watch('searchContacts', function(data) {
if (data != undefined) {
// find all contacts with 'Bob' in any name field
var options  = new ContactFindOptions();
options.filter   = data;
options.multiple = true;
var fields = ["displayName", "name"];
navigator.contacts.find(fields, loadAllContacts, onError, options);

$scope.viewContact = function (contact) {
buxMainNav.pushPage("contact_details.html", {
"animation": "slide",
phone_contact: contact
});
};
}
});
}]);


function loadAllContacts(contacts) {
var cSort = function(a, b) {
aName = a.name.givenName;
bName = b.name.givenName;
return aName < bName ? -1 : (aName == bName ? 0 : 1);
};


var scope = 
angular.element(document.getElementById("contacts-controller")).scope();
scope.nocontactsresults = "";
scope.$apply(function(){
contacts = contacts.sort(cSort);
scope.phoneContacts = contacts;
if (scope.phoneContacts.length < 1) {
scope.nocontactsresults = "No Results";
} else {
scope.nocontactsresults = "";
}
})
};

function onError(contactError) {
ons.notification.alert({
message: "Unable to access phonebook contacts.",
title: "Contacts"
});
};


> phonegap app crashes on getting contacts
> 
>
> Key: CB-9396
> URL: https://issues.apache.org/jira/browse/CB-9396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: iphone4/s iOS
>Reporter: Edd A
>   

[jira] [Commented] (CB-9396) phonegap app crashes on getting contacts

[Vladimir Kotikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013128#comment-15013128
 ] 

Vladimir Kotikov commented on CB-9396:
--

[~eamoto], i can't reproduce this neither on simulator running iOS 9.1 nor on 
device with 8.1.1.
If the issue still exists, please add more details: plugin version, iOS 
version, any specific contact or set of contacts that causes app's crash. Crash 
logs also would be very useful.

> phonegap app crashes on getting contacts
> 
>
> Key: CB-9396
> URL: https://issues.apache.org/jira/browse/CB-9396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: iphone4/s iOS
>Reporter: Edd A
>  Labels: ios, triaged
>
> We are using phonegap and angularjs on our mobile app.. We are currently 
> getting phone contacts and it is crashing on iphone4/s only. It is working on 
> android and iphone 6. I can't seem to find where the error is.
> Here is the code..
> {noformat}
> module.controller('someControllerName', ['$scope', '$http', function ($scope, 
> $http) {
> // find all contacts with 'Bob' in any name field
> var options = new ContactFindOptions();
> options.filter = "";
> options.multiple = true;
> var fields = ["displayName", "name"];
> navigator.contacts.find(fields, loadAllContacts, onError, options);
> $scope.viewContact = function (contact) {
> buxMainNav.pushPage("contact_details.html",
> { "animation": "slide", phone_contact: contact }
> );
> };
> $scope.$watch('searchContacts', function (data) {
> if (data != undefined) {
> // find all contacts with 'Bob' in any name field
> var options = new ContactFindOptions();
> options.filter = data;
> options.multiple = true;
> var fields = ["displayName", "name"];
> navigator.contacts.find(fields, loadAllContacts, onError, 
> options);
> $scope.viewContact = function (contact) {
> buxMainNav.pushPage("contact_details.html",
> { "animation": "slide", phone_contact: contact }
> );
> };
> }
> });
> }]);
> function loadAllContacts(contacts) {
> var cSort = function (a, b) {
> aName = a.name.givenName; bName = b.name.givenName; return aName < 
> bName ? -1 : (aName == bName ? 0 : 1);
> };
> var scope = 
> angular.element(document.getElementById("contacts-controller")).scope();
> scope.nocontactsresults = "";
> scope.$apply(function () {
> contacts = contacts.sort(cSort);
> scope.phoneContacts = contacts;
> if (scope.phoneContacts.length < 1)
> { scope.nocontactsresults = "No Results"; }
> else
> { scope.nocontactsresults = ""; }
> });
> };
> function onError(contactError) {
> ons.notification.alert(
> { message: "Unable to access phonebook contacts.", title: "Contacts" }
> );
> };
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-9200) event progress with "cordova.InAppBrowser.open"

[Sergey Grebnov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Grebnov resolved CB-9200.

Resolution: Fixed

> event progress with "cordova.InAppBrowser.open"
> ---
>
> Key: CB-9200
> URL: https://issues.apache.org/jira/browse/CB-9200
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
> Environment: cordova-plugin-inappbrowser 1.0.0 + 
> cordova-plugin-dialogs 1.1.0 + ios 8.3 (12F69)
>Reporter: Colin Bau
>  Labels: Triaged
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> according to this
> https://github.com/apache/cordova-plugin-inappbrowser
> let me demo for example "loadstart" (other enent have the same problem)
> {code}
> var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 
> 'location=yes');
> //this line will trigger
> ref.addEventListener('loadstart', function(event) { alert(event.url); });
> //this line will never trigger
> ref.addEventListener('loadstart', function(event) { 
> navigator.notification.alert("test", null, 'title', 'ok'); });
> {code}
> is the "inappbrowser" have some conflict with "dialogs"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9708) Enabling ProGuard for cordova android project doesn't work

[feiyun0112 (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013163#comment-15013163
 ] 

feiyun0112 commented on CB-9708:


cordova use gradle to bulid android project, so you need to  modify 
"platforms\android\build.gradle"

add this part:

buildTypes {
release {
minifyEnabled true
proguardFile getDefaultProguardFile('proguard-android.txt')
}
}


more detail see 
http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Running-ProGuard

> Enabling ProGuard for cordova android project doesn't work
> --
>
> Key: CB-9708
> URL: https://issues.apache.org/jira/browse/CB-9708
> Project: Apache Cordova
>  Issue Type: Bug
>Affects Versions: 5.3.2
> Environment: Windows 10 Enterprise
> CLI 5.3.3
>Reporter: Diego Geffner
>
> I found a few sites on the internet like this: 
> http://stackoverflow.com/questions/27310268/how-to-use-proguard-in-cordova-android-app
>  that said that modifying the file: project.properties would enable proguard.
> I tried this, and then did a "cordova build android --release" but proguard 
> wasn't getting run.
> If this is not a feature that you actually support, it would be nice if you 
> added a way to run proguard on the cordova builds.
> This is the file I'm talking about:
> # This file is automatically generated by Android Tools.
> # Do not modify this file -- YOUR CHANGES WILL BE ERASED!
> #
> # This file must be checked in Version Control Systems.
> #
> # To customize properties used by the Ant build system edit
> # "ant.properties", and override values to adapt the script to your
> # project structure.
> #
> # To enable ProGuard to shrink and obfuscate your code, uncomment this 
> (available properties: sdk.dir, user.home):
> #proguard.config=${sdk.dir}/tools/proguard/proguard-android.txt:proguard-project.txt
> # Project target.
> target=android-22
> android.library.reference.1=CordovaLib



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-9396) phonegap app crashes on getting contacts

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-9396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov closed CB-9396.

Resolution: Cannot Reproduce

Closing this according to [triage 
process|https://github.com/apache/cordova-coho/blob/master/docs/jira-triage.md].
 [~eamoto], feel free to reopen if the issue still exits and there are 
additional details to help reproduce this.

> phonegap app crashes on getting contacts
> 
>
> Key: CB-9396
> URL: https://issues.apache.org/jira/browse/CB-9396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: iphone4/s iOS
>Reporter: Edd A
>  Labels: ios, triaged
>
> We are using phonegap and angularjs on our mobile app.. We are currently 
> getting phone contacts and it is crashing on iphone4/s only. It is working on 
> android and iphone 6. I can't seem to find where the error is.
> Here is the code..
> {noformat}
> module.controller('someControllerName', ['$scope', '$http', function ($scope, 
> $http) {
> // find all contacts with 'Bob' in any name field
> var options = new ContactFindOptions();
> options.filter = "";
> options.multiple = true;
> var fields = ["displayName", "name"];
> navigator.contacts.find(fields, loadAllContacts, onError, options);
> $scope.viewContact = function (contact) {
> buxMainNav.pushPage("contact_details.html",
> { "animation": "slide", phone_contact: contact }
> );
> };
> $scope.$watch('searchContacts', function (data) {
> if (data != undefined) {
> // find all contacts with 'Bob' in any name field
> var options = new ContactFindOptions();
> options.filter = data;
> options.multiple = true;
> var fields = ["displayName", "name"];
> navigator.contacts.find(fields, loadAllContacts, onError, 
> options);
> $scope.viewContact = function (contact) {
> buxMainNav.pushPage("contact_details.html",
> { "animation": "slide", phone_contact: contact }
> );
> };
> }
> });
> }]);
> function loadAllContacts(contacts) {
> var cSort = function (a, b) {
> aName = a.name.givenName; bName = b.name.givenName; return aName < 
> bName ? -1 : (aName == bName ? 0 : 1);
> };
> var scope = 
> angular.element(document.getElementById("contacts-controller")).scope();
> scope.nocontactsresults = "";
> scope.$apply(function () {
> contacts = contacts.sort(cSort);
> scope.phoneContacts = contacts;
> if (scope.phoneContacts.length < 1)
> { scope.nocontactsresults = "No Results"; }
> else
> { scope.nocontactsresults = ""; }
> });
> };
> function onError(contactError) {
> ons.notification.alert(
> { message: "Unable to access phonebook contacts.", title: "Contacts" }
> );
> };
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9200) event progress with "cordova.InAppBrowser.open"

[Sergey Grebnov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013138#comment-15013138
 ] 

Sergey Grebnov commented on CB-9200:


This has been fixed in master

> event progress with "cordova.InAppBrowser.open"
> ---
>
> Key: CB-9200
> URL: https://issues.apache.org/jira/browse/CB-9200
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
> Environment: cordova-plugin-inappbrowser 1.0.0 + 
> cordova-plugin-dialogs 1.1.0 + ios 8.3 (12F69)
>Reporter: Colin Bau
>  Labels: Triaged
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> according to this
> https://github.com/apache/cordova-plugin-inappbrowser
> let me demo for example "loadstart" (other enent have the same problem)
> {code}
> var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 
> 'location=yes');
> //this line will trigger
> ref.addEventListener('loadstart', function(event) { alert(event.url); });
> //this line will never trigger
> ref.addEventListener('loadstart', function(event) { 
> navigator.notification.alert("test", null, 'title', 'ok'); });
> {code}
> is the "inappbrowser" have some conflict with "dialogs"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-9708) Enabling ProGuard for cordova android project doesn't work

[feiyun0112 (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013163#comment-15013163
 ] 

feiyun0112 edited comment on CB-9708 at 11/19/15 8:48 AM:
--

cordova use gradle to bulid android project, so you need to  modify 
"platforms\android\build.gradle"

add this part:

buildTypes {
release {

minifyEnabled true

proguardFile getDefaultProguardFile('proguard-android.txt')

}
}


more detail see 
http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Running-ProGuard


was (Author: feiyun0112):
cordova use gradle to bulid android project, so you need to  modify 
"platforms\android\build.gradle"

add this part:

buildTypes {
release {
minifyEnabled true
proguardFile getDefaultProguardFile('proguard-android.txt')
}
}


more detail see 
http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Running-ProGuard

> Enabling ProGuard for cordova android project doesn't work
> --
>
> Key: CB-9708
> URL: https://issues.apache.org/jira/browse/CB-9708
> Project: Apache Cordova
>  Issue Type: Bug
>Affects Versions: 5.3.2
> Environment: Windows 10 Enterprise
> CLI 5.3.3
>Reporter: Diego Geffner
>
> I found a few sites on the internet like this: 
> http://stackoverflow.com/questions/27310268/how-to-use-proguard-in-cordova-android-app
>  that said that modifying the file: project.properties would enable proguard.
> I tried this, and then did a "cordova build android --release" but proguard 
> wasn't getting run.
> If this is not a feature that you actually support, it would be nice if you 
> added a way to run proguard on the cordova builds.
> This is the file I'm talking about:
> # This file is automatically generated by Android Tools.
> # Do not modify this file -- YOUR CHANGES WILL BE ERASED!
> #
> # This file must be checked in Version Control Systems.
> #
> # To customize properties used by the Ant build system edit
> # "ant.properties", and override values to adapt the script to your
> # project structure.
> #
> # To enable ProGuard to shrink and obfuscate your code, uncomment this 
> (available properties: sdk.dir, user.home):
> #proguard.config=${sdk.dir}/tools/proguard/proguard-android.txt:proguard-project.txt
> # Project target.
> target=android-22
> android.library.reference.1=CordovaLib



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-9396) phonegap app crashes on getting contacts

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-9396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-9396:
-
Description: 
We are using phonegap and angularjs on our mobile app.. We are currently 
getting phone contacts and it is crashing on iphone4/s only. It is working on 
android and iphone 6. I can't seem to find where the error is.

Here is the code..

{noformat}

module.controller('someControllerName', ['$scope', '$http', function ($scope, 
$http) {
// find all contacts with 'Bob' in any name field
var options = new ContactFindOptions();
options.filter = "";
options.multiple = true;
var fields = ["displayName", "name"];
navigator.contacts.find(fields, loadAllContacts, onError, options);
$scope.viewContact = function (contact) {
buxMainNav.pushPage("contact_details.html",
{ "animation": "slide", phone_contact: contact }
);
};
$scope.$watch('searchContacts', function (data) {
if (data != undefined) {
// find all contacts with 'Bob' in any name field
var options = new ContactFindOptions();
options.filter = data;
options.multiple = true;
var fields = ["displayName", "name"];
navigator.contacts.find(fields, loadAllContacts, onError, options);
$scope.viewContact = function (contact) {
buxMainNav.pushPage("contact_details.html",
{ "animation": "slide", phone_contact: contact }
);
};
}
});
}]);
function loadAllContacts(contacts) {
var cSort = function (a, b) {
aName = a.name.givenName; bName = b.name.givenName; return aName < 
bName ? -1 : (aName == bName ? 0 : 1);
};
var scope = 
angular.element(document.getElementById("contacts-controller")).scope();
scope.nocontactsresults = "";
scope.$apply(function () {
contacts = contacts.sort(cSort);
scope.phoneContacts = contacts;
if (scope.phoneContacts.length < 1)
{ scope.nocontactsresults = "No Results"; }
else
{ scope.nocontactsresults = ""; }
});
};
function onError(contactError) {
ons.notification.alert(
{ message: "Unable to access phonebook contacts.", title: "Contacts" }
);
};
{noformat}

  was:
We are using phonegap and angularjs on our mobile app.. We are currently 
getting phone contacts and it is crashing on iphone4/s only. It is working on 
android and iphone 6. I can't seem to find where the error is.

Here is the code..

{noformat}

module.controller('someControllerName', ['$scope', '$http', function ($scope, 
$http) {
// find all contacts with 'Bob' in any name field
var options = new ContactFindOptions();
options.filter = "";
options.multiple = true;
var fields = ["displayName", "name"];
navigator.contacts.find(fields, loadAllContacts, onError, options);
$scope.viewContact = function (contact) {
buxMainNav.pushPage("contact_details.html",
{ "animation": "slide", phone_contact: contact }
);
};
$scope.$watch('searchContacts', function (data) {
if (data != undefined) {
// find all contacts with 'Bob' in any name field
var options = new ContactFindOptions();
options.filter = data;
options.multiple = true;
var fields = ["displayName", "name"];
navigator.contacts.find(fields, loadAllContacts, onError, options);
$scope.viewContact = function (contact) {
buxMainNav.pushPage("contact_details.html",
{ "animation": "slide", phone_contact: contact }
);
};
}
});
}]);
function loadAllContacts(contacts) {
var cSort = function (a, b)
{ aName = a.name.givenName; bName = b.name.givenName; return aName < bName 
? -1 : (aName == bName ? 0 : 1); }
;
var scope = 
angular.element(document.getElementById("contacts-controller")).scope();
scope.nocontactsresults = "";
scope.$apply(function () {
contacts = contacts.sort(cSort);
scope.phoneContacts = contacts;
if (scope.phoneContacts.length < 1)
{ scope.nocontactsresults = "No Results"; }
else
{ scope.nocontactsresults = ""; }
});
};
function onError(contactError) {
ons.notification.alert(
{ message: "Unable to access phonebook contacts.", title: "Contacts" }
);
};
{noformat}


> phonegap app crashes on getting contacts
> 
>
> Key: CB-9396
> URL: https://issues.apache.org/jira/browse/CB-9396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: iphone4/s iOS
>Reporter: Edd A
>  Labels: ios, triaged
>
> We are using 

[jira] [Commented] (CB-10037) Add progress indicator to file-transfer manual tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013156#comment-15013156
 ] 

ASF GitHub Bot commented on CB-10037:
-

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/114

CB-10037 Add progress indicator to file-transfer manual tests

[Jira issue](https://issues.apache.org/jira/browse/CB-10037)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer 
CB-10037

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #114


commit 1eee18e129e1ba24823e8c32c3c9847bedfd8089
Author: daserge 
Date:   2015-11-19T08:31:56Z

CB-10037 Add progress indicator to file-transfer manual tests




> Add progress indicator to file-transfer manual tests
> 
>
> Key: CB-10037
> URL: https://issues.apache.org/jira/browse/CB-10037
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-9348) Unable to get linked contact's phone number, while using pickContact

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-9348:
-
Affects Version/s: 2.0.0

> Unable to get linked contact's phone number, while using pickContact
> 
>
> Key: CB-9348
> URL: https://issues.apache.org/jira/browse/CB-9348
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
>Affects Versions: 2.0.0
>Reporter: Dipanjan Chakraborty
>  Labels: android, linked-contacts, reproduced, triaged
>
> using cordova v5.1.1 and contacts plugin v1.1.0
> we are unable to fetch the mobile numbers from the phonebook especially if 
> there are contacts linked.
> example:
> the main contact is 
> Name: John Doe 
> mobile: 99
> the linked G+ contact is 
> Name J.Doe
> mobile: 88
> When fetching the contact using pickContact , it does not fetch either phone 
> numbers. however, the name of the secondary (J.Doe) is fetched .
> Appreciate any help on this issue.
> Thanks in advance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-9348) Unable to get linked contact's phone number, while using pickContact

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-9348:
-
Labels: android linked-contacts reproduced triaged  (was: android 
linked-contacts triaged)

> Unable to get linked contact's phone number, while using pickContact
> 
>
> Key: CB-9348
> URL: https://issues.apache.org/jira/browse/CB-9348
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
>Affects Versions: 2.0.0
>Reporter: Dipanjan Chakraborty
>  Labels: android, linked-contacts, reproduced, triaged
>
> using cordova v5.1.1 and contacts plugin v1.1.0
> we are unable to fetch the mobile numbers from the phonebook especially if 
> there are contacts linked.
> example:
> the main contact is 
> Name: John Doe 
> mobile: 99
> the linked G+ contact is 
> Name J.Doe
> mobile: 88
> When fetching the contact using pickContact , it does not fetch either phone 
> numbers. however, the name of the secondary (J.Doe) is fetched .
> Appreciate any help on this issue.
> Thanks in advance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-8847) Contacts test failures on iOS

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov closed CB-8847.

Resolution: Cannot Reproduce

Can't reproduce this using latest master on both 8.1.1 device and 9.1 emulator. 
Will reopen if the issue will appear on Buildbot again.

> Contacts test failures on iOS
> -
>
> Key: CB-8847
> URL: https://issues.apache.org/jira/browse/CB-8847
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
>Affects Versions: Master
> Environment: iOS
>Reporter: Dmitry Blotsky
>  Labels: found-by-ci, ios, plugin-contacts, test-fail
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Test failures here: 
> [http://ci.apache.org/builders/cordova-ios/builds/399/steps/running-tests/logs/stdio]
> {noformat}
> cordova-plugin-contacts-tests.tests >> Contacts (navigator.contacts) Round 
> trip Contact tests (creating + save + delete + find). contacts.spec.24 
> Creating, saving, finding a contact should work, removing it should work, 
> after which we should not be able to find it, and we should not be able to 
> delete it again.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9445) executeScript callbacks not working for iOS

[Sergey Grebnov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013206#comment-15013206
 ] 

Sergey Grebnov commented on CB-9445:


Confirm callbacks issue, from what I see 

_cdvIframeBridge.src is correctly set every time so code is invoked.

but the the shouldStartLoadWithRequest for gap-iab://InAppBrowser is called 
only once so no callbacks are called anymore

> executeScript callbacks not working for iOS
> ---
>
> Key: CB-9445
> URL: https://issues.apache.org/jira/browse/CB-9445
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 5.1.1
> Environment: Cordova 5.1.1 (CLI), ios 3.8.0, android 4.0.2, 
> cordova-plugin-inappbrowser 1.0.1 (NPM)
>Reporter: Scott Seitz
>Assignee: jcesarmobile
>  Labels: Triaged, iOS
>
> Can someone please check to see if they are encountering the same problem I 
> am in the environment I've listed? (latest released builds of everything I 
> think)
> I open an inappbrowser window and then run an executeScript command using 
> "code:" (not "file:").  Everything works fine on Android, but on iOS, it 
> simply will NOT fire the callback function after executing the injected code. 
>  Make the "code:" as simple as you like to test it and see if you can get a 
> callback to fire.  I've dumbed it down as much as possible and can't get one 
> to fire.  I know that all instances of code I've injected have run fine in 
> the iab by using the console (against the iab) to check for the variables I 
> was creating in the code.  I can't even get a callback to fire that doesn't 
> expect a parameter to be passed back...
> Many thanks,
> Scott



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-9445) executeScript callbacks not working for iOS

[Sergey Grebnov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013206#comment-15013206
 ] 

Sergey Grebnov edited comment on CB-9445 at 11/19/15 9:42 AM:
--

Confirm callbacks issue, from what I see 

_cdvIframeBridge.src is correctly set every time so code is invoked.

but the shouldStartLoadWithRequest for gap-iab://InAppBrowser is called 
only once so no callbacks are called anymore


was (Author: sgrebnov):
Confirm callbacks issue, from what I see 

_cdvIframeBridge.src is correctly set every time so code is invoked.

but the the shouldStartLoadWithRequest for gap-iab://InAppBrowser is called 
only once so no callbacks are called anymore

> executeScript callbacks not working for iOS
> ---
>
> Key: CB-9445
> URL: https://issues.apache.org/jira/browse/CB-9445
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 5.1.1
> Environment: Cordova 5.1.1 (CLI), ios 3.8.0, android 4.0.2, 
> cordova-plugin-inappbrowser 1.0.1 (NPM)
>Reporter: Scott Seitz
>Assignee: jcesarmobile
>  Labels: Triaged, iOS
>
> Can someone please check to see if they are encountering the same problem I 
> am in the environment I've listed? (latest released builds of everything I 
> think)
> I open an inappbrowser window and then run an executeScript command using 
> "code:" (not "file:").  Everything works fine on Android, but on iOS, it 
> simply will NOT fire the callback function after executing the injected code. 
>  Make the "code:" as simple as you like to test it and see if you can get a 
> callback to fire.  I've dumbed it down as much as possible and can't get one 
> to fire.  I know that all instances of code I've injected have run fine in 
> the iab by using the console (against the iab) to check for the variables I 
> was creating in the code.  I can't even get a callback to fire that doesn't 
> expect a parameter to be passed back...
> Many thanks,
> Scott



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9445) executeScript callbacks not working for iOS

[Sergey Grebnov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013235#comment-15013235
 ] 

Sergey Grebnov commented on CB-9445:


if modify code to re-create _cdvIframeBridge iframe for every injectScriptCode 
call then shouldStartLoadWithRequest is called every time and callbacks work.

> executeScript callbacks not working for iOS
> ---
>
> Key: CB-9445
> URL: https://issues.apache.org/jira/browse/CB-9445
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 5.1.1
> Environment: Cordova 5.1.1 (CLI), ios 3.8.0, android 4.0.2, 
> cordova-plugin-inappbrowser 1.0.1 (NPM)
>Reporter: Scott Seitz
>Assignee: jcesarmobile
>  Labels: Triaged, iOS
>
> Can someone please check to see if they are encountering the same problem I 
> am in the environment I've listed? (latest released builds of everything I 
> think)
> I open an inappbrowser window and then run an executeScript command using 
> "code:" (not "file:").  Everything works fine on Android, but on iOS, it 
> simply will NOT fire the callback function after executing the injected code. 
>  Make the "code:" as simple as you like to test it and see if you can get a 
> callback to fire.  I've dumbed it down as much as possible and can't get one 
> to fire.  I know that all instances of code I've injected have run fine in 
> the iab by using the console (against the iab) to check for the variables I 
> was creating in the code.  I can't even get a callback to fire that doesn't 
> expect a parameter to be passed back...
> Many thanks,
> Scott



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9445) executeScript callbacks not working for iOS

[jcesarmobile (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013251#comment-15013251
 ] 

jcesarmobile commented on CB-9445:
--

[~sgrebnov] in my tests, the problem was if you use the executeScript on 
loadstart, the cordova iframe is added to an empty page, but when the page is 
loaded the iframe disappears (as the page is loaded and the webview content is 
replaced)

So I kept the issue open to document that executeScript shouldn't be called on 
loadstart.

I've though on another option that might work, I saw this on the cordova.js 
(part of pokeNative funcion that creates the iframe)

// CB-5488 - Don't attempt to create iframe before document.body is available.
if (!document.body) {
setTimeout(pokeNative);
return;
}



> executeScript callbacks not working for iOS
> ---
>
> Key: CB-9445
> URL: https://issues.apache.org/jira/browse/CB-9445
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 5.1.1
> Environment: Cordova 5.1.1 (CLI), ios 3.8.0, android 4.0.2, 
> cordova-plugin-inappbrowser 1.0.1 (NPM)
>Reporter: Scott Seitz
>Assignee: jcesarmobile
>  Labels: Triaged, iOS
>
> Can someone please check to see if they are encountering the same problem I 
> am in the environment I've listed? (latest released builds of everything I 
> think)
> I open an inappbrowser window and then run an executeScript command using 
> "code:" (not "file:").  Everything works fine on Android, but on iOS, it 
> simply will NOT fire the callback function after executing the injected code. 
>  Make the "code:" as simple as you like to test it and see if you can get a 
> callback to fire.  I've dumbed it down as much as possible and can't get one 
> to fire.  I know that all instances of code I've injected have run fine in 
> the iab by using the console (against the iab) to check for the variables I 
> was creating in the code.  I can't even get a callback to fire that doesn't 
> expect a parameter to be passed back...
> Many thanks,
> Scott



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-9445) executeScript callbacks not working for iOS

[jcesarmobile (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013251#comment-15013251
 ] 

jcesarmobile edited comment on CB-9445 at 11/19/15 9:50 AM:


[~sgrebnov] in my tests, the problem was if you use the executeScript on 
loadstart, the cordova iframe is added to an empty page, but when the page is 
loaded the iframe disappears (as the page is loaded and the webview content is 
replaced)

So I kept the issue open to document that executeScript shouldn't be called on 
loadstart.

I've though on another option that might work, I saw this on the cordova.js 
(part of pokeNative funcion that creates the iframe)

// CB-5488 - Don't attempt to create iframe before document.body is available.
if (!document.body) {
setTimeout(pokeNative);
return;
}




was (Author: jcesarmobile):
[~sgrebnov] in my tests, the problem was if you use the executeScript on 
loadstart, the cordova iframe is added to an empty page, but when the page is 
loaded the iframe disappears (as the page is loaded and the webview content is 
replaced)

So I kept the issue open to document that executeScript shouldn't be called on 
loadstart.

I've though on another option that might work, I saw this on the cordova.js 
(part of pokeNative funcion that creates the iframe)

// CB-5488 - Don't attempt to create iframe before document.body is available.
if (!document.body) {
setTimeout(pokeNative);
return;
}



> executeScript callbacks not working for iOS
> ---
>
> Key: CB-9445
> URL: https://issues.apache.org/jira/browse/CB-9445
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 5.1.1
> Environment: Cordova 5.1.1 (CLI), ios 3.8.0, android 4.0.2, 
> cordova-plugin-inappbrowser 1.0.1 (NPM)
>Reporter: Scott Seitz
>Assignee: jcesarmobile
>  Labels: Triaged, iOS
>
> Can someone please check to see if they are encountering the same problem I 
> am in the environment I've listed? (latest released builds of everything I 
> think)
> I open an inappbrowser window and then run an executeScript command using 
> "code:" (not "file:").  Everything works fine on Android, but on iOS, it 
> simply will NOT fire the callback function after executing the injected code. 
>  Make the "code:" as simple as you like to test it and see if you can get a 
> callback to fire.  I've dumbed it down as much as possible and can't get one 
> to fire.  I know that all instances of code I've injected have run fine in 
> the iab by using the console (against the iab) to check for the variables I 
> was creating in the code.  I can't even get a callback to fire that doesn't 
> expect a parameter to be passed back...
> Many thanks,
> Scott



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-9445) executeScript callbacks not working for iOS

[jcesarmobile (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013251#comment-15013251
 ] 

jcesarmobile edited comment on CB-9445 at 11/19/15 9:51 AM:


[~sgrebnov] in my tests, the problem was if you use the executeScript on 
loadstart, the cordova iframe is added to an empty page, but when the page is 
loaded the iframe disappears (as the page is loaded and the webview content is 
replaced)

So I kept the issue open to document that executeScript shouldn't be called on 
loadstart.

I've though on another option that might work, I saw this on the cordova.js 
(part of pokeNative funcion that creates the iframe)
{code}
// CB-5488 - Don't attempt to create iframe before document.body is available.
if (!document.body) {
setTimeout(pokeNative);
return;
}
{code}



was (Author: jcesarmobile):
[~sgrebnov] in my tests, the problem was if you use the executeScript on 
loadstart, the cordova iframe is added to an empty page, but when the page is 
loaded the iframe disappears (as the page is loaded and the webview content is 
replaced)

So I kept the issue open to document that executeScript shouldn't be called on 
loadstart.

I've though on another option that might work, I saw this on the cordova.js 
(part of pokeNative funcion that creates the iframe)

// CB-5488 - Don't attempt to create iframe before document.body is available.
if (!document.body) {
setTimeout(pokeNative);
return;
}



> executeScript callbacks not working for iOS
> ---
>
> Key: CB-9445
> URL: https://issues.apache.org/jira/browse/CB-9445
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 5.1.1
> Environment: Cordova 5.1.1 (CLI), ios 3.8.0, android 4.0.2, 
> cordova-plugin-inappbrowser 1.0.1 (NPM)
>Reporter: Scott Seitz
>Assignee: jcesarmobile
>  Labels: Triaged, iOS
>
> Can someone please check to see if they are encountering the same problem I 
> am in the environment I've listed? (latest released builds of everything I 
> think)
> I open an inappbrowser window and then run an executeScript command using 
> "code:" (not "file:").  Everything works fine on Android, but on iOS, it 
> simply will NOT fire the callback function after executing the injected code. 
>  Make the "code:" as simple as you like to test it and see if you can get a 
> callback to fire.  I've dumbed it down as much as possible and can't get one 
> to fire.  I know that all instances of code I've injected have run fine in 
> the iab by using the console (against the iab) to check for the variables I 
> was creating in the code.  I can't even get a callback to fire that doesn't 
> expect a parameter to be passed back...
> Many thanks,
> Scott



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-9445) executeScript callbacks not working for iOS

[jcesarmobile (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013251#comment-15013251
 ] 

jcesarmobile edited comment on CB-9445 at 11/19/15 9:50 AM:


[~sgrebnov] in my tests, the problem was if you use the executeScript on 
loadstart, the cordova iframe is added to an empty page, but when the page is 
loaded the iframe disappears (as the page is loaded and the webview content is 
replaced)

So I kept the issue open to document that executeScript shouldn't be called on 
loadstart.

I've though on another option that might work, I saw this on the cordova.js 
(part of pokeNative funcion that creates the iframe)

// CB-5488 - Don't attempt to create iframe before document.body is available.
if (!document.body) {
setTimeout(pokeNative);
return;
}




was (Author: jcesarmobile):
[~sgrebnov] in my tests, the problem was if you use the executeScript on 
loadstart, the cordova iframe is added to an empty page, but when the page is 
loaded the iframe disappears (as the page is loaded and the webview content is 
replaced)

So I kept the issue open to document that executeScript shouldn't be called on 
loadstart.

I've though on another option that might work, I saw this on the cordova.js 
(part of pokeNative funcion that creates the iframe)

// CB-5488 - Don't attempt to create iframe before document.body is available.
if (!document.body) {
setTimeout(pokeNative);
return;
}



> executeScript callbacks not working for iOS
> ---
>
> Key: CB-9445
> URL: https://issues.apache.org/jira/browse/CB-9445
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 5.1.1
> Environment: Cordova 5.1.1 (CLI), ios 3.8.0, android 4.0.2, 
> cordova-plugin-inappbrowser 1.0.1 (NPM)
>Reporter: Scott Seitz
>Assignee: jcesarmobile
>  Labels: Triaged, iOS
>
> Can someone please check to see if they are encountering the same problem I 
> am in the environment I've listed? (latest released builds of everything I 
> think)
> I open an inappbrowser window and then run an executeScript command using 
> "code:" (not "file:").  Everything works fine on Android, but on iOS, it 
> simply will NOT fire the callback function after executing the injected code. 
>  Make the "code:" as simple as you like to test it and see if you can get a 
> callback to fire.  I've dumbed it down as much as possible and can't get one 
> to fire.  I know that all instances of code I've injected have run fine in 
> the iab by using the console (against the iab) to check for the variables I 
> was creating in the code.  I can't even get a callback to fire that doesn't 
> expect a parameter to be passed back...
> Many thanks,
> Scott



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-8156) [Contacts] Cancelling pickContact should call the error callback, but callback "nothing" for now

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-8156:
-
Labels: android contacts ios regression reproduced triaged  (was: android 
contacts ios triaged)

> [Contacts] Cancelling pickContact should call the error callback, but 
> callback "nothing" for now
> 
>
> Key: CB-8156
> URL: https://issues.apache.org/jira/browse/CB-8156
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: I using ipad mini 8.1.2 with phonegap 3.6.3 or 3.7.1 and 
> latest contact plugin
>Reporter: Colin Bau
>Assignee: Vladimir Kotikov
>  Labels: android, contacts, ios, regression, reproduced, triaged
>
> according to this
> https://issues.apache.org/jira/browse/CB-7772
> it have been solved
> Cancelling pickContact should call the error callback, but callback "nothing" 
> (no any response) for now



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-7743) Multiple calls to navigator.contacts.find crash iOS application

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-7743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-7743:
-
Labels: ios  (was: ios triaged)

> Multiple calls to navigator.contacts.find crash iOS application
> ---
>
> Key: CB-7743
> URL: https://issues.apache.org/jira/browse/CB-7743
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
>Affects Versions: 0.2.14
> Environment: Running on an iPhone 5 running iOS8 with about 200 
> contacts.
> Cordova@3.6.3
>Reporter: Jesse Hull
>  Labels: ios
>
> Compile the following http://codepen.io/anon/pen/vlEmL into an iPhone 
> application with cordova after installing the contacts plugin.
> Click on Load Contacts 5-10 times and the iPhone application will crash.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-8290) Cordova contacts plugin crashes if any one has a contact name with new line chars.

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-8290:
-
Affects Version/s: (was: 3.5.0)

> Cordova contacts plugin crashes if any one has a contact name with new line 
> chars. 
> ---
>
> Key: CB-8290
> URL: https://issues.apache.org/jira/browse/CB-8290
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: iPhone 4, 5, 6
>Reporter: Rameez Raja
>  Labels: iOS, triaged
>
> When i tried to search contacts using cordova contacts plugin, it crashes 
> when a contact has line break chars in its name (i.e. formatted, given, 
> family etc). For example i have a contact name in phone ABCDEF.
> Cordova plugin is returning this name as 
> ...
> name: {
>formatted: 'ABC\U2028DEF'
>...
> }
> ...
> which is causing issue. Because it is not a valid JSON object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9445) executeScript callbacks not working for iOS

[jcesarmobile (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013256#comment-15013256
 ] 

jcesarmobile commented on CB-9445:
--

Are you able to recreate always the same iframe? or do you end with a lot of 
iframes if you run executeScript multiple times?

> executeScript callbacks not working for iOS
> ---
>
> Key: CB-9445
> URL: https://issues.apache.org/jira/browse/CB-9445
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 5.1.1
> Environment: Cordova 5.1.1 (CLI), ios 3.8.0, android 4.0.2, 
> cordova-plugin-inappbrowser 1.0.1 (NPM)
>Reporter: Scott Seitz
>Assignee: jcesarmobile
>  Labels: Triaged, iOS
>
> Can someone please check to see if they are encountering the same problem I 
> am in the environment I've listed? (latest released builds of everything I 
> think)
> I open an inappbrowser window and then run an executeScript command using 
> "code:" (not "file:").  Everything works fine on Android, but on iOS, it 
> simply will NOT fire the callback function after executing the injected code. 
>  Make the "code:" as simple as you like to test it and see if you can get a 
> callback to fire.  I've dumbed it down as much as possible and can't get one 
> to fire.  I know that all instances of code I've injected have run fine in 
> the iab by using the console (against the iab) to check for the variables I 
> was creating in the code.  I can't even get a callback to fire that doesn't 
> expect a parameter to be passed back...
> Many thanks,
> Scott



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-8172) 0.2.16-dev: navigator.contacts.find doesn't execute neither success nor error callback.

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov closed CB-8172.

Resolution: Cannot Reproduce
  Assignee: Vladimir Kotikov

Can't reproduce this using latest plugin version on Android 6.0 emulator. 
[~meshkov] could you please confirm if you still see this problem. If so, feel 
free to reopen this bug.

Also it'd be great to have a bit more details here regarding cordova and 
android versions.

> 0.2.16-dev: navigator.contacts.find doesn't execute neither success nor error 
> callback.
> ---
>
> Key: CB-8172
> URL: https://issues.apache.org/jira/browse/CB-8172
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
>Affects Versions: 0.2.16
>Reporter: Meshkov Alex
>Assignee: Vladimir Kotikov
>  Labels: Android, triaged
>
> Hi! I have the following code:
> {code:javascript}
> var options = new ContactFindOptions();
> options.desiredFields = [navigator.contacts.fieldType.id, 
> navigator.contacts.fieldType.phoneNumbers];
> var fields = [
> navigator.contacts.fieldType.phoneNumbers
> ];
> options.multiple = true;
> navigator.contacts.find(fields, function (contacts) {
> alert('ok');
> }, function (error) {
> alert(error);
> }, options);
> {code}
> Neither success nor error callbacks are executed. 
> This happens only with 0.2.16-dev version of the plugin. The 0.2.15 version 
> is ok for me. I tested it on Android platform.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-10038) Support NSFileProtectionKey attribute on the file in iOS

[Venkata Kiran (JIRA)]

Venkata Kiran created CB-10038:
--

 Summary: Support NSFileProtectionKey attribute on the file in iOS
 Key: CB-10038
 URL: https://issues.apache.org/jira/browse/CB-10038
 Project: Apache Cordova
  Issue Type: Wish
  Components: iOS, Plugin File
 Environment: iOS 7+
Reporter: Venkata Kiran
Priority: Minor


NSFileProtectionKey attribute on a file seems to provide better security 
options on iOS. It would be good if there is an option to support this 
attribute from cordova.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-5479) Save original image to photoalbum when the image is taken from the Camera

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014238#comment-15014238
 ] 

ASF GitHub Bot commented on CB-5479:


Github user luofan189 commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-158174054
  
I have added options to that JIRA issue, @riknoll 


> Save original image to photoalbum when the image is taken from the Camera
> -
>
> Key: CB-5479
> URL: https://issues.apache.org/jira/browse/CB-5479
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Camera
>Affects Versions: 3.1.0
>Reporter: Stephan Wezel
>Assignee: Richard B Knoll
>Priority: Minor
>  Labels: Android, iOS, triaged
> Attachments: camera_plugin_save_original_image_to_photoalbum.patch
>
>
> Currently when the option saveToPhotoAlbum is active the modified image 
> (scaled, reduced image) is saved to the PhotoAlbum.
> At least when the image is taken from the Camera then the original image 
> should be saved instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-5479) Save original image to photoalbum when the image is taken from the Camera

[Richard B Knoll (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014240#comment-15014240
 ] 

Richard B Knoll commented on CB-5479:
-

[~luofan189] Thanks for the update! I'll take a look at this and get back to 
you.

> Save original image to photoalbum when the image is taken from the Camera
> -
>
> Key: CB-5479
> URL: https://issues.apache.org/jira/browse/CB-5479
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Camera
>Affects Versions: 3.1.0
>Reporter: Stephan Wezel
>Assignee: Richard B Knoll
>Priority: Minor
>  Labels: Android, iOS, triaged
> Attachments: camera_plugin_save_original_image_to_photoalbum.patch
>
>
> Currently when the option saveToPhotoAlbum is active the modified image 
> (scaled, reduced image) is saved to the PhotoAlbum.
> At least when the image is taken from the Camera then the original image 
> should be saved instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-5479) Save original image to photoalbum when the image is taken from the Camera

[Fan Luo (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014053#comment-15014053
 ] 

Fan Luo edited comment on CB-5479 at 11/19/15 6:10 PM:
---

This is [~luofan189]

I am using cordova camera 1.2.0, cordova ios 3.9.1 on iOS 9, here is the camera 
options:

sourceType: Camera.PictureSourceType.CAMERA
saveToPhotoAlbum = true;
quality: 75,
allowEdit: true,
targetWidth: 1024,
targetHeight: 1024,
destinationType: Camera.DestinationType.FILE_URI,
encodingType: Camera.EncodingType.JPEG

after taking the photo, only the resized image is saved rather than the full 
resolution image.


was (Author: luofan189):
This is [~luofan189]

I am using cordova camera 1.2.0 on iOS 9, here is the camera options:

sourceType: Camera.PictureSourceType.CAMERA
saveToPhotoAlbum = true;
quality: 75,
allowEdit: true,
targetWidth: 1024,
targetHeight: 1024,
destinationType: Camera.DestinationType.FILE_URI,
encodingType: Camera.EncodingType.JPEG

after taking the photo, only the resized image is saved rather than the full 
resolution image.

> Save original image to photoalbum when the image is taken from the Camera
> -
>
> Key: CB-5479
> URL: https://issues.apache.org/jira/browse/CB-5479
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Camera
>Affects Versions: 3.1.0
>Reporter: Stephan Wezel
>Assignee: Richard B Knoll
>Priority: Minor
>  Labels: Android, iOS, triaged
> Attachments: camera_plugin_save_original_image_to_photoalbum.patch
>
>
> Currently when the option saveToPhotoAlbum is active the modified image 
> (scaled, reduced image) is saved to the PhotoAlbum.
> At least when the image is taken from the Camera then the original image 
> should be saved instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-5479) Save original image to photoalbum when the image is taken from the Camera

[Fan Luo (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014053#comment-15014053
 ] 

Fan Luo commented on CB-5479:
-

This is [~luofan189]

I am using cordova camera 1.2.0 on iOS 9, here is the camera options:

sourceType: Camera.PictureSourceType.CAMERA
saveToPhotoAlbum = true;
quality: 75,
allowEdit: true,
targetWidth: 1024,
targetHeight: 1024,
destinationType: Camera.DestinationType.FILE_URI,
encodingType: Camera.EncodingType.JPEG

after taking the photo, only the resized image is saved rather than the full 
resolution image.

> Save original image to photoalbum when the image is taken from the Camera
> -
>
> Key: CB-5479
> URL: https://issues.apache.org/jira/browse/CB-5479
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Camera
>Affects Versions: 3.1.0
>Reporter: Stephan Wezel
>Assignee: Richard B Knoll
>Priority: Minor
>  Labels: Android, iOS, triaged
> Attachments: camera_plugin_save_original_image_to_photoalbum.patch
>
>
> Currently when the option saveToPhotoAlbum is active the modified image 
> (scaled, reduced image) is saved to the PhotoAlbum.
> At least when the image is taken from the Camera then the original image 
> should be saved instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-9720) CameraCaptureTask.Show() Always Returns Canceled on Windows 10 Mobile build 10536

[Richard B Knoll (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-9720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Richard B Knoll closed CB-9720.
---
Resolution: Not A Problem

Great! Thanks for checking in!

> CameraCaptureTask.Show() Always Returns Canceled on Windows 10 Mobile build 
> 10536
> -
>
> Key: CB-9720
> URL: https://issues.apache.org/jira/browse/CB-9720
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 3.5.0
> Environment: Windows 10 Mobile pre-release build 10536
>Reporter: Alan Neveu
>  Labels: windows
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I have been using Windows 10 Mobile and things were working great with 
> pre-release versions prior to 10536. But with build 10536 we find this bad 
> behavior. The issue definitely seems to be due to a bug in Microsoft's code, 
> not in PhoneGap/Cordova. Here is the repro:
> - Write some code that calls getPicture in javascript
> - Set a breakpoint in Camera.cs, line 247, in the public void onTaskCompleted 
> callback
> - Run the code while attached to a Windows 10 Mobile device running 10536
> - When the camera appears on the phone take a photo and tap on the checkmark 
> icon, which is supposed to mean "Use" or "accept" as opposed to "retake"
> - When the breakpoint hits, check out the value of e.TaskResult and notice 
> that it is set to Canceled. Also check out other properties such as 
> e.OriginalFileName and find that they are not set and are empty strings or 
> null values.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9591) Retain aspect ratio when resizing camera image

[Raghav (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014228#comment-15014228
 ] 

Raghav commented on CB-9591:


I have been testing this issue on windows phone 8.1 and I believe it works as 
expected. According to the documentation, image is never scaled up, so 
basically the resize is driven by the lower of the targetwidth/targetheight 
specified and the image is resized keeping the original aspect ratio constant.

I tested on a 480 * 640 image and gave the following values:
targetwidth targetheight  resultant-widthresultant-height
100   250100 133
200   800200 266
700   600450 600

[~riknoll] : Can you confirm this is the behavior on other platforms?


> Retain aspect ratio when resizing camera image
> --
>
> Key: CB-9591
> URL: https://issues.apache.org/jira/browse/CB-9591
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
> Environment: Windows
>Reporter: Murat Sutunc
>  Labels: Windows
>
> According to documentation and iOS/Android behavior, resized images should 
> retain ratio. Windows currently doesn't respect that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9971) Cordova outputs "Picked up _JAVA_OPTIONS" in stderr

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014186#comment-15014186
 ] 

ASF GitHub Bot commented on CB-9971:


Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/240#discussion_r45386261
  
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +209,46 @@ module.exports = GradleBuilder;
 function isAutoGenerated(file) {
 return fs.existsSync(file) && fs.readFileSync(file, 
'utf8').indexOf(MARKER) > 0;
 }
+
+/**
+ * A special superspawn-like implementation, required to workaround the 
issue
--- End diff --

This is not really a consideration anymore now that the redirection has to 
be more specialized to this particular case


> Cordova outputs "Picked up _JAVA_OPTIONS" in stderr
> ---
>
> Key: CB-9971
> URL: https://issues.apache.org/jira/browse/CB-9971
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.0.0
> Environment: Windows, Tools for Apache Cordova in Visual Studio
> Cordova 5.4.0
>Reporter: Michael Braude
>Assignee: Vladimir Kotikov
>Priority: Critical
>  Labels: easyfix, windows,
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Starting with version 5.4.0, Cordova now outputs "Picked up _JAVA_OPTIONS: 
> -Xmx512M" to stderr. This breaks clients such as Visual Studio because we 
> interpret messages in stderr to be errors, and this is not an error. So the 
> result is that we show deploy failures to the dev when there are no errors.
> See this for customer impact: 
> http://stackoverflow.com/questions/33603167/vs2015-build-with-cordova-cli5-4-0-shows-deployment-errors
> We can work around this in Visual Studio by using special casing, but Cordova 
> needs to output this in stdout like it did in previous versions



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10030) Cordova-Ubuntu Platform Release

[Steve Gill (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014216#comment-15014216
 ] 

Steve Gill commented on CB-10030:
-

I'll help you out [~dbarth]

> Cordova-Ubuntu Platform Release
> ---
>
> Key: CB-10030
> URL: https://issues.apache.org/jira/browse/CB-10030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: Ubuntu
>Reporter: David Barth
>Assignee: Maxim Ermilov
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-10040) Compile Error in InAppBrowser Plugin for iOS - No known instance method for selector 'URLIsWhitelisted:'

[Sergey Grebnov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Grebnov reassigned CB-10040:
---

Assignee: Sergey Grebnov

> Compile Error in InAppBrowser Plugin for iOS - No known instance method for 
> selector 'URLIsWhitelisted:'
> 
>
> Key: CB-10040
> URL: https://issues.apache.org/jira/browse/CB-10040
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 4.0.0
> Environment: OS X 10.11.1, Xcode 7.1.1, iOS 9.1
>Reporter: Inderpreet
>Assignee: Sergey Grebnov
>  Labels: Triaged, cordova-ios-4.0.x, cordova-plugin-inappbrowser, 
> ios
>
> While working with cordova-ios branch 
> (https://github.com/apache/cordova-ios.git#master) we are facing a compile 
> error in InAppBrowser 
> Plugin(https://github.com/apache/cordova-plugin-inappbrowser.git#master), it 
> can be due to the recent update to cordova-ios i.e. iOS whitelist removal 
> CB-9972 
> Error details : CDVInAppBrowser.m:231:31: No known instance method for 
> selector 'URLIsWhitelisted:'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9971) Cordova outputs "Picked up _JAVA_OPTIONS" in stderr

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014183#comment-15014183
 ] 

ASF GitHub Bot commented on CB-9971:


Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/240#discussion_r45385875
  
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +212,54 @@ module.exports = GradleBuilder;
 function isAutoGenerated(file) {
 return fs.existsSync(file) && fs.readFileSync(file, 
'utf8').indexOf(MARKER) > 0;
 }
+
+/**
+ * A special superspawn-like implementation, required to workaround the 
issue
+ *   with java printing some necessary information to stderr instead of 
stdout.
+ *   This function redirects all stderr messages to current process 
stdout. See
+ *   https://issues.apache.org/jira/browse/CB-9971 for explanation.
+ *
+ * @param   {String}cmd   A command to spawn
+ * @param   {String[]}  args  Command arguments. Note that on Windows 
arguments
+ *   will be concatenated into string and passed to 'cmd.exe' along with 
'/s'
+ *   and '/c' swithces for proper space-in-path handling
+ *
+ * @return  {Promise}A promise, rejected with error message, if
+ *   underlying command exits with nonzero exit code, fulfilled otherwise
+ */
+function spawnWithStderrRedirect(cmd, args) {
+var opts = { stdio: 'pipe' };
+
+if (process.platform === 'win32') {
+// Work around spawn not being able to find .bat files.
+var joinedArgs = [cmd]
+.concat(args)
+.map(function(a){
+// Add quotes to arguments which contains whitespaces
+if (/^[^"].* .*[^"]/.test(a)) return '"' + a + '"';
+return a;
+}).join(' ');
+
+args = ['/s', '/c'].concat('"' + joinedArgs + '"');
+cmd = 'cmd';
+opts.windowsVerbatimArguments = true;
+}
+
+return Q.Promise(function (resolve, reject) {
+var proc = child_process.spawn(cmd, args, opts);
+
+proc.stdout.on('data', process.stdout.write.bind(process.stdout));
+proc.stderr.on('data', function (data) {
+var isRedirectNeeded = data.toString().match(/^Picked up 
_JAVA_OPTIONS: /i);
--- End diff --

/regex/.test(str) is faster when all you need is a boolean result, not the 
detailed info that match() returns.


> Cordova outputs "Picked up _JAVA_OPTIONS" in stderr
> ---
>
> Key: CB-9971
> URL: https://issues.apache.org/jira/browse/CB-9971
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.0.0
> Environment: Windows, Tools for Apache Cordova in Visual Studio
> Cordova 5.4.0
>Reporter: Michael Braude
>Assignee: Vladimir Kotikov
>Priority: Critical
>  Labels: easyfix, windows,
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Starting with version 5.4.0, Cordova now outputs "Picked up _JAVA_OPTIONS: 
> -Xmx512M" to stderr. This breaks clients such as Visual Studio because we 
> interpret messages in stderr to be errors, and this is not an error. So the 
> result is that we show deploy failures to the dev when there are no errors.
> See this for customer impact: 
> http://stackoverflow.com/questions/33603167/vs2015-build-with-cordova-cli5-4-0-shows-deployment-errors
> We can work around this in Visual Studio by using special casing, but Cordova 
> needs to output this in stdout like it did in previous versions



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

[Marco Antonio Ortega Moulin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marco Antonio Ortega Moulin updated CB-10044:
-
Affects Version/s: 3.5.0
  Environment: Android and iOS

> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>  Labels: FileTransfer, Resumablejs
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10030) Cordova-Ubuntu Platform Release

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014837#comment-15014837
 ] 

ASF GitHub Bot commented on CB-10030:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ubuntu/pull/19


> Cordova-Ubuntu Platform Release
> ---
>
> Key: CB-10030
> URL: https://issues.apache.org/jira/browse/CB-10030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: Ubuntu
>Reporter: David Barth
>Assignee: Maxim Ermilov
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8940) [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI Elements (header / footer)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014902#comment-15014902
 ] 

ASF GitHub Bot commented on CB-8940:


Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-158245865
  
Agree with above. Otherwise, LGTM. Tested on an 8.1 device (and by tested I 
mean I took a picture, not really sure what else to do here). I don't really 
see how this can mess anything up.


> [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI 
> Elements (header / footer)
> -
>
> Key: CB-8940
> URL: https://issues.apache.org/jira/browse/CB-8940
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 4.1.0
> Environment: Windows Emulator / Nokia Lumia 920
>Reporter: david marshall
>Assignee: Raghav
>  Labels: windows
>
> Changing the values in CameraProxy.js to below works a treat
> // z-index style element for capturePreview and captureCancelButton elts
> // is necessary to avoid overriding by another page 
> elements, -1 sometimes is not enough
> capturePreview.style.cssText = "position: fixed; left: 0; 
> top: 0; width: 100%; height: 100%; z-index: ";
> // Create cancel button
> captureCancelButton = document.createElement("button");
> captureCancelButton.innerText = "Cancel";
> captureCancelButton.style.cssText = "position: fixed; 
> right: 0; bottom: 0; display: block; margin: 20px; z-index: 1";



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8940) [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI Elements (header / footer)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014996#comment-15014996
 ] 

ASF GitHub Bot commented on CB-8940:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/140


> [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI 
> Elements (header / footer)
> -
>
> Key: CB-8940
> URL: https://issues.apache.org/jira/browse/CB-8940
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 4.1.0
> Environment: Windows Emulator / Nokia Lumia 920
>Reporter: david marshall
>Assignee: Raghav
>  Labels: windows
>
> Changing the values in CameraProxy.js to below works a treat
> // z-index style element for capturePreview and captureCancelButton elts
> // is necessary to avoid overriding by another page 
> elements, -1 sometimes is not enough
> capturePreview.style.cssText = "position: fixed; left: 0; 
> top: 0; width: 100%; height: 100%; z-index: ";
> // Create cancel button
> captureCancelButton = document.createElement("button");
> captureCancelButton.innerText = "Cancel";
> captureCancelButton.style.cssText = "position: fixed; 
> right: 0; bottom: 0; display: block; margin: 20px; z-index: 1";



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8940) [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI Elements (header / footer)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014995#comment-15014995
 ] 

ASF subversion and git services commented on CB-8940:
-

Commit ef5484a2aa72e63c2ad95d5533db6f25ed53e5c7 in cordova-plugin-camera's 
branch refs/heads/master from [~rakatyal]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;h=ef5484a 
]

CB-8940 Setting z-index values to maximum for UI buttons. This closes #140.


> [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI 
> Elements (header / footer)
> -
>
> Key: CB-8940
> URL: https://issues.apache.org/jira/browse/CB-8940
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 4.1.0
> Environment: Windows Emulator / Nokia Lumia 920
>Reporter: david marshall
>Assignee: Raghav
>  Labels: windows
>
> Changing the values in CameraProxy.js to below works a treat
> // z-index style element for capturePreview and captureCancelButton elts
> // is necessary to avoid overriding by another page 
> elements, -1 sometimes is not enough
> capturePreview.style.cssText = "position: fixed; left: 0; 
> top: 0; width: 100%; height: 100%; z-index: ";
> // Create cancel button
> captureCancelButton = document.createElement("button");
> captureCancelButton.innerText = "Cancel";
> captureCancelButton.style.cssText = "position: fixed; 
> right: 0; bottom: 0; display: block; margin: 20px; z-index: 1";



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8940) [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI Elements (header / footer)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014853#comment-15014853
 ] 

ASF GitHub Bot commented on CB-8940:


Github user dblotsky commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-158243037
  
You could place the value into a constant named `HIGHEST_POSSIBLE_Z_INDEX`, 
and then it would be both documented and easier to maintain.


> [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI 
> Elements (header / footer)
> -
>
> Key: CB-8940
> URL: https://issues.apache.org/jira/browse/CB-8940
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 4.1.0
> Environment: Windows Emulator / Nokia Lumia 920
>Reporter: david marshall
>Assignee: Raghav
>  Labels: windows
>
> Changing the values in CameraProxy.js to below works a treat
> // z-index style element for capturePreview and captureCancelButton elts
> // is necessary to avoid overriding by another page 
> elements, -1 sometimes is not enough
> capturePreview.style.cssText = "position: fixed; left: 0; 
> top: 0; width: 100%; height: 100%; z-index: ";
> // Create cancel button
> captureCancelButton = document.createElement("button");
> captureCancelButton.innerText = "Cancel";
> captureCancelButton.style.cssText = "position: fixed; 
> right: 0; bottom: 0; display: block; margin: 20px; z-index: 1";



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9971) Cordova outputs "Picked up _JAVA_OPTIONS" in stderr

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014903#comment-15014903
 ] 

ASF GitHub Bot commented on CB-9971:


Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-android/pull/240#issuecomment-158246192
  
Can't we still use superspawn and just add something like the 
`stderr.on('data')` filter to catch and discard the undesired line? Superspawn 
can return a promise that receives the stdout and stderr of the spawned command.


> Cordova outputs "Picked up _JAVA_OPTIONS" in stderr
> ---
>
> Key: CB-9971
> URL: https://issues.apache.org/jira/browse/CB-9971
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.0.0
> Environment: Windows, Tools for Apache Cordova in Visual Studio
> Cordova 5.4.0
>Reporter: Michael Braude
>Assignee: Vladimir Kotikov
>Priority: Critical
>  Labels: easyfix, windows,
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Starting with version 5.4.0, Cordova now outputs "Picked up _JAVA_OPTIONS: 
> -Xmx512M" to stderr. This breaks clients such as Visual Studio because we 
> interpret messages in stderr to be errors, and this is not an error. So the 
> result is that we show deploy failures to the dev when there are no errors.
> See this for customer impact: 
> http://stackoverflow.com/questions/33603167/vs2015-build-with-cordova-cli5-4-0-shows-deployment-errors
> We can work around this in Visual Studio by using special casing, but Cordova 
> needs to output this in stdout like it did in previous versions



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9976) Updating to cordovaLib 5.4.0 breaks ios installed plugins

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014937#comment-15014937
 ] 

ASF subversion and git services commented on CB-9976:
-

Commit 874a44fec208abce3ec663c9b4175be5cdafeb2f in cordova-lib's branch 
refs/heads/5.4.x from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=874a44f ]

CB-9976 Reinstall plugins for platform if they were installed with 
cordova@<5.4.0. This closes #344


> Updating to cordovaLib 5.4.0 breaks ios installed plugins
> -
>
> Key: CB-9976
> URL: https://issues.apache.org/jira/browse/CB-9976
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Reporter: Steve Gill
>Assignee: Vladimir Kotikov
> Fix For: 5.4.1
>
>
> cordova_plugins.js doesn't get created for ios when updating from an older 
> cli to a newer cli. 
> Have to remove and add plugins manually to get plugins working again.
> Reproduce (need to use npm < 3):
> npm install -g cordova@5.3.3
> cordova create helloWorld
> cd helloWorld
> cordova platform add ios
> cordova plugin add cordova-plugin-device
> cordova prepare (helloWorld/platforms/ios/www/cordova_plugins.js is created)
> npm install -g cordova@5.4.0
> cordova prepare (helloWorld/platforms/ios/www/cordova_plugins.js doesn't 
> exist)
> `helloWorld/platforms/ios/ios.json` is also incorrect in the updated version. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10049) cordova-lib & cordova-cli release 5.4.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014938#comment-15014938
 ] 

ASF subversion and git services commented on CB-10049:
--

Commit 720270618cf20291898b5193e8041e9f86719fcf in cordova-lib's branch 
refs/heads/5.4.x from [~stevegill]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=7202706 ]

CB-10049 Updated version and RELEASENOTES.md for release 5.4.1


> cordova-lib & cordova-cli release 5.4.1
> ---
>
> Key: CB-10049
> URL: https://issues.apache.org/jira/browse/CB-10049
> Project: Apache Cordova
>  Issue Type: Task
>  Components: CLI
>Affects Versions: 5.4.0
>Reporter: Steve Gill
>Assignee: Steve Gill
> Fix For: 5.4.1
>
>
> "Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9981) plugin installation broken for node 0.10.x

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014935#comment-15014935
 ] 

ASF subversion and git services commented on CB-9981:
-

Commit 3fba809f23b9c18b41fc17c8b898f21ffc2804f6 in cordova-lib's branch 
refs/heads/5.4.x from ivan baktsheev
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=3fba809 ]

CB-9981 path.parse only available on node 0.12+.

This closes #340


> plugin installation broken for node 0.10.x
> --
>
> Key: CB-9981
> URL: https://issues.apache.org/jira/browse/CB-9981
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.0
>Reporter: Ivan Baktsheev
>
> In commit
> https://github.com/apla/cordova-lib/commit/07271a5c6162c0b2bee55e1ea23f91ebdfbbb34c
> added call for path.pase in file
> cordova-lib/src/plugman/platforms/common.js
> path.parse is only available for node 0.12 and later. 
> According to https://github.com/nodejs/LTS/, node 0.10 will be in maintenance 
> mode for one year since October 2015, so maintaining compatibility is 
> important. For example, Travis-CI still using nodejs 0.10 for Mac OS X 
> virtual machines.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10049) cordova-lib & cordova-cli release 5.4.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014966#comment-15014966
 ] 

ASF subversion and git services commented on CB-10049:
--

Commit e7467123d7b94f576d6958282eea0e879333453f in cordova-cli's branch 
refs/heads/5.4.x from [~stevegill]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=e746712 ]

CB-10049 updated version and RELEASENOTES.md for release 5.4.1


> cordova-lib & cordova-cli release 5.4.1
> ---
>
> Key: CB-10049
> URL: https://issues.apache.org/jira/browse/CB-10049
> Project: Apache Cordova
>  Issue Type: Task
>  Components: CLI
>Affects Versions: 5.4.0
>Reporter: Steve Gill
>Assignee: Steve Gill
> Fix For: 5.4.1
>
>
> "Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10049) cordova-lib & cordova-cli release 5.4.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014967#comment-15014967
 ] 

ASF subversion and git services commented on CB-10049:
--

Commit 87c4d549ad00821c450f7c1d9b4fd213c6778923 in cordova-cli's branch 
refs/heads/master from [~stevegill]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=87c4d54 ]

CB-10049 updated version and RELEASENOTES.md for release 5.4.1


> cordova-lib & cordova-cli release 5.4.1
> ---
>
> Key: CB-10049
> URL: https://issues.apache.org/jira/browse/CB-10049
> Project: Apache Cordova
>  Issue Type: Task
>  Components: CLI
>Affects Versions: 5.4.0
>Reporter: Steve Gill
>Assignee: Steve Gill
> Fix For: 5.4.1
>
>
> "Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-5942) targetWidth and targetHeight are not being interpreted consistently across platforms

[Richard B Knoll (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015013#comment-15015013
 ] 

Richard B Knoll commented on CB-5942:
-

As part of CB-9591, [~rakatyal] and I tested the behavior on Android, iOS, and 
Windows and found that the resizing now seems to be consistent across platforms 
(not sure where wp8 stands). Growing the image still happens on some platforms 
(definitely on iOS).

> targetWidth and targetHeight are not being interpreted consistently across 
> platforms
> 
>
> Key: CB-5942
> URL: https://issues.apache.org/jira/browse/CB-5942
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 3.0.0, 3.1.0, 3.2.0
> Environment: iOS, WP8
>Reporter: John M. Wargo
>
> A while back I posted a question regarding Camera targetWidth & targetHeight 
> properties and how they worked. After some discussion, the conclusion I 
> reached was that the documentation couldn't be correct about how it worked 
> since there was no way to determine the camera's resolution with the current 
> API but the docs said I had to provide both parameters.  I said I'd do some 
> testing and I have finally gotten around to completing it. Here's what I 
> discovered:
> I created an application that allowed me to pass in different values for 
> targetWidth & targetHeight when taking a picture. I tested at the following 
> image sizes: 640x480, 800x600, 1024x768 as well as setting only the 
> targetWidth to 1024 or only the targetHeight to 768.
> Here's the results:
> h2. Android
> ||Expected||Portrait||Landscape||
> |640x480|480x640|640x480|
> |800x600|600x800|800x600|
> |1024x768|768x1024|1024x768|
> |1024x?|768x1024|1024x768|
> |?x768|768x1024|1024x768|
> h2. iOS
> ||Expected||Portrait||Landscape||
> |640x480|360x480|640x480|
> |800x600|450x600|800x600|
> |1024x768|576x768|1024x768|
> |1024x?|2448x3264|3264x2448|
> |?x768|2448x3264|3264x2448|
> h2. Windows Phone 8
> ||Expected||Portrait||Landscape||
> |640x480|1836x3264|3264x1836|
> |800x600|1836x3264|3264x1836|
> |1024x768|1836x3264|3264x1836|
> |1024x?|1836x3264|3264x1836|
> |?x768|1836x3264|3264x1836|
> As you can see, Android properly implements the targetWidth & targetHeight 
> properties. On iOS, it supports setting both properties, but not instances 
> where only one is specified. Windows Phone 8 ignores the parameters 
> completely.  On iOS, when you turn the device on its side, the Camera API 
> applies the target width or height to the wrong axis (Android does this well 
> however).
> I'm trying to test this on a BlackBerry device, but my development 
> environment is giving me fits right now. I'll work on it in the morning and 
> publish my results when I get them.
> I would suggest that the android implementation is as expected and that the 
> other platforms need their implementations of targetWidth & targetHeight 
> adjusted so it works correctly. The documentation should be updated as well 
> as it's incorrect today specifying that both properties must be provided.
> If the group doesn't want to support only providing one of the properties, 
> then I would expect that the onError callback is called when only one is 
> provided rather than simply ignoring them as is the case with iOS and Windows 
> Phone.
> I posted my sample application and a spreadsheet with my results to 
> https://github.com/johnwargo/camera_res_test
> The concensus on the dev list is the following:
> The API should never grow the image
> The API should shrink the image while maintaining aspect ratio, such that 
> both dimensions of the resized image fit within targetWidth and targetHeight.
> I would propose as well that the API support only one of the parameters or 
> both - the API should understand enough about the image file to maintain 
> aspect ratio, the developer shouldn't have to tell it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8940) [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI Elements (header / footer)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014866#comment-15014866
 ] 

ASF GitHub Bot commented on CB-8940:


Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/140#issuecomment-158243766
  
Good suggestion. 


> [Windows] Camera image z-index is too low. It sits behind JQuery mobile UI 
> Elements (header / footer)
> -
>
> Key: CB-8940
> URL: https://issues.apache.org/jira/browse/CB-8940
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 4.1.0
> Environment: Windows Emulator / Nokia Lumia 920
>Reporter: david marshall
>Assignee: Raghav
>  Labels: windows
>
> Changing the values in CameraProxy.js to below works a treat
> // z-index style element for capturePreview and captureCancelButton elts
> // is necessary to avoid overriding by another page 
> elements, -1 sometimes is not enough
> capturePreview.style.cssText = "position: fixed; left: 0; 
> top: 0; width: 100%; height: 100%; z-index: ";
> // Create cancel button
> captureCancelButton = document.createElement("button");
> captureCancelButton.innerText = "Cancel";
> captureCancelButton.style.cssText = "position: fixed; 
> right: 0; bottom: 0; display: block; margin: 20px; z-index: 1";



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-9591) Retain aspect ratio when resizing camera image

[Richard B Knoll (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-9591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Richard B Knoll updated CB-9591:

Assignee: Raghav

> Retain aspect ratio when resizing camera image
> --
>
> Key: CB-9591
> URL: https://issues.apache.org/jira/browse/CB-9591
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
> Environment: Windows
>Reporter: Murat Sutunc
>Assignee: Raghav
>  Labels: Windows
>
> According to documentation and iOS/Android behavior, resized images should 
> retain ratio. Windows currently doesn't respect that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9591) Retain aspect ratio when resizing camera image

[Richard B Knoll (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014988#comment-15014988
 ] 

Richard B Knoll commented on CB-9591:
-

Tested on iOS and everything is consistent. [~rakatyal] close it up!

> Retain aspect ratio when resizing camera image
> --
>
> Key: CB-9591
> URL: https://issues.apache.org/jira/browse/CB-9591
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
> Environment: Windows
>Reporter: Murat Sutunc
>  Labels: Windows
>
> According to documentation and iOS/Android behavior, resized images should 
> retain ratio. Windows currently doesn't respect that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-10048) clobbering of tags to ATS directives

[Shazron Abdullah (JIRA)]

Shazron Abdullah created CB-10048:
-

 Summary: clobbering of  tags to ATS directives
 Key: CB-10048
 URL: https://issues.apache.org/jira/browse/CB-10048
 Project: Apache Cordova
  Issue Type: Bug
  Components: CordovaLib
Affects Versions: 5.3.3
Reporter: Shazron Abdullah
Assignee: Shazron Abdullah


Example:
{code}
http://*.apache.org />
https://*.apache.org />
{code}

In this case, we want the http exception, but it gets clobbered by the 
following tag with https.

The parser should do a once over sweep to consolidate the tags, and re-run the 
generator.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10014) Gradle variable applicationId is not set, creates issue with Google Play services 8.3.0

[Josh Kasten (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014843#comment-15014843
 ] 

Josh Kasten commented on CB-10014:
--

I created a workaround by reading the AndroidManifest.xml file.


h5. For App Developers

Create the following file under _/platforms/android_
{code:language=cppl|title=build-extras.gradle|borderStyle=solid}
def manifest = new XmlSlurper().parse(file("AndroidManifest.xml"))
android.defaultConfig.applicationId manife...@package.text()
{code}

\\

h5. For Plugin Developers
{code:language=xml|title=plugin.xml|borderStyle=solid}

{code}

{code:language=cppl|title=build-extras-PLUGIN_NAME_HERE.gradle|borderStyle=solid}
def manifest = new XmlSlurper().parse(file("AndroidManifest.xml"))
android.defaultConfig.applicationId manife...@package.text()
{code}

\\
Cordova team, let me know if there is a better work around.

> Gradle variable applicationId is not set, creates issue with Google Play 
> services 8.3.0
> ---
>
> Key: CB-10014
> URL: https://issues.apache.org/jira/browse/CB-10014
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.4.1
>Reporter: Josh Kasten
>  Labels: android, gradle
>
> applicationId is not set in build.gradle which creates an issue with 
> com.google.android.gms:play-services-measurement:8.3.0. This aar file has the 
> following line in AndroidManifest.xml
> {code:xml}
> android:authorities="${applicationId}.google_measurement_service"
>
> android:name="com.google.android.gms.measurement.AppMeasurementContentProvider"
>android:exported="false"/>
> {code}
> applicationId becomes `com.google.android.gms.measurement` when the manifest 
> entry is merged since applicationId is not set in the main project .gradle 
> file. This means that if another app also includes the Google Play services 
> library 8.3.0 it will fail to install on the device with an 
> INSTALL_FAILED_CONFLICTING_PROVIDER error because the name isn't unique.
> This is silent problem to developers as it only becomes an issue when the end 
> user installs 2 apps built this way. This should be addressed quickly to 
> prevent this error when developers release their APK or provide a work around 
> for plugin developers to add something to their plugin.xml to default in the 
> applicationId gradle variable.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8863) Fix potential problems with blocks usage in core plugins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014844#comment-15014844
 ] 

ASF GitHub Bot commented on CB-8863:


GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-plugin-media-capture/pull/49

CB-8863 Fix block usage of self



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-plugin-media-capture 
CB-8863

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media-capture/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #49


commit d19ce1a3fe5302a92a66c9d7d4e4c68f5c759534
Author: Jesse MacFadyen 
Date:   2015-11-20T00:22:30Z

CB-8863 Fix block usage of self




> Fix potential problems with blocks usage in core plugins
> 
>
> Key: CB-8863
> URL: https://issues.apache.org/jira/browse/CB-8863
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Jesse MacFadyen
>  Labels: cordova-ios-5.0.x
>
> Audit the core plugins to check for proper blocks usage.
> Problems that I see can be summed up in this (fixed) code:
> https://github.com/apache/cordova-plugin-splashscreen/blob/fa60f01adcba2d21583de7972a0facc4da1eb75e/src/ios/CDVSplashScreen.m#L292-L313
> 1. You need a weak reference to "self" in blocks to prevent retain cycle 
> problems.
> Fix: 
> https://github.com/apache/cordova-plugin-splashscreen/blob/fa60f01adcba2d21583de7972a0facc4da1eb75e/src/ios/CDVSplashScreen.m#L292
> 2. Anything that calls UIKit methods, which includes plugins that write 
> JavaScript back to the UIWebView (commandDelegate functions), must be called 
> in the main thread.
> Fix: 
> https://github.com/apache/cordova-plugin-splashscreen/blob/fa60f01adcba2d21583de7972a0facc4da1eb75e/src/ios/CDVSplashScreen.m#L308-L310
>  (UPDATE: we actually already handle this in evalJS)
> 3. Avoid creating private variables like this in the first place -- I would 
> create a class extension which will effectively have "private" properties 
> (nothing is truly private in objc). This is to avoid this situation in the 
> block where you have to cast the weak self into a strong self (and check it's 
> still around), just to access a private variable:
> https://github.com/apache/cordova-plugin-splashscreen/blob/fa60f01adcba2d21583de7972a0facc4da1eb75e/src/ios/CDVSplashScreen.m#L298-L304
> Of course since we are modifying UIKit items here, rule 2 above also applies.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-10049) cordova-lib & cordova-cli release 5.4.1

[Steve Gill (JIRA)]

Steve Gill created CB-10049:
---

 Summary: cordova-lib & cordova-cli release 5.4.1
 Key: CB-10049
 URL: https://issues.apache.org/jira/browse/CB-10049
 Project: Apache Cordova
  Issue Type: Task
  Components: CLI
Affects Versions: 5.4.0
Reporter: Steve Gill
Assignee: Steve Gill
 Fix For: 5.4.1


"Following steps at 
https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9987) cordova-lib compile arguments changed

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014934#comment-15014934
 ] 

ASF subversion and git services commented on CB-9987:
-

Commit 701151d295d4c8a17ea66d5bfa0a671ceeaf5c3c in cordova-lib's branch 
refs/heads/5.4.x from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=701151d ]

CB-9987 Fixing minor jshint issues to prevent test failure


> cordova-lib compile arguments changed
> -
>
> Key: CB-9987
> URL: https://issues.apache.org/jira/browse/CB-9987
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.0
>Reporter: Jimmy Thomson
>Assignee: Vladimir Kotikov
>Priority: Critical
> Fix For: 5.4.1
>
>
> Prior to cordova-lib 5.4.0 cordova.raw.compile accepted an object such as { 
> options: ["list", "of", "options"]}. As of 5.4.0 it seems to want { options: 
> {argv: ["list", "of", "options"]}} instead. This causes silent failures if 
> other packages attempt to use the older approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9975) No longer able to use "all" as orientation for ios

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014936#comment-15014936
 ] 

ASF subversion and git services commented on CB-9975:
-

Commit 4d5926af2249947af1a7625ba11182a93de8c198 in cordova-lib's branch 
refs/heads/5.4.x from [~shazron]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=4d5926a ]

CB-9975 - No longer able to use "all" as orientation for ios (android 
sensorLandscape tests and fix)


> No longer able to use "all" as orientation for ios
> --
>
> Key: CB-9975
> URL: https://issues.apache.org/jira/browse/CB-9975
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.0
>Reporter: Raymond Camden
>Assignee: Shazron Abdullah
>Priority: Trivial
> Fix For: 5.4.1
>
>
> Yesterday I blogged about iOS and orientation
> (http://www.raymondcamden.com/2015/11/09/cordova-ios-and-orientation-wondering-why-it-is-locked).
>  Today on Twitter someone noticed that when they set orientation now, they 
> get an error in the CLI. I updated my CLI to the latest, and can confirm it 
> is now broken. If you set ios orientation to all, you get:
> Unsupported global orientation: all
> Defaulting to value: default
> This is obviously wrong on two accounts - it wasn't a global orientation (it 
> was ios only) and all should be supported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10049) cordova-lib & cordova-cli release 5.4.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014939#comment-15014939
 ] 

ASF subversion and git services commented on CB-10049:
--

Commit 08e0c36da22426c16dfca552d8f8aea77bf168c3 in cordova-lib's branch 
refs/heads/master from [~stevegill]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=08e0c36 ]

CB-10049 Updated version and RELEASENOTES.md for release 5.4.1


> cordova-lib & cordova-cli release 5.4.1
> ---
>
> Key: CB-10049
> URL: https://issues.apache.org/jira/browse/CB-10049
> Project: Apache Cordova
>  Issue Type: Task
>  Components: CLI
>Affects Versions: 5.4.0
>Reporter: Steve Gill
>Assignee: Steve Gill
> Fix For: 5.4.1
>
>
> "Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-10050) Inconsistent saveToPhotoAlbum behavior on PHOTOLIBRARY images

[Richard B Knoll (JIRA)]

Richard B Knoll created CB-10050:


 Summary: Inconsistent saveToPhotoAlbum behavior on PHOTOLIBRARY 
images
 Key: CB-10050
 URL: https://issues.apache.org/jira/browse/CB-10050
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Camera
Reporter: Richard B Knoll
Priority: Minor


Another quirk: iOS will actually save images to the photo album if chosen from 
the {{PHOTOLIBRARY}} source. Android, I believe, only saves those from the 
{{CAMERA}} source. Not sure what the correct way to resolve this is. I do not 
see any reason that you would ever want to save the same photo twice, even if 
the user crops it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9591) Retain aspect ratio when resizing camera image

[Richard B Knoll (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014289#comment-15014289
 ] 

Richard B Knoll commented on CB-9591:
-

Confirmed on Android. I used a bigger photo, but it had the same aspect ratio 
so I got the same results for those width/heights. Will do iOS later.

> Retain aspect ratio when resizing camera image
> --
>
> Key: CB-9591
> URL: https://issues.apache.org/jira/browse/CB-9591
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
> Environment: Windows
>Reporter: Murat Sutunc
>  Labels: Windows
>
> According to documentation and iOS/Android behavior, resized images should 
> retain ratio. Windows currently doesn't respect that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10045) Extend bootstrap stylings to docs

[Richard B Knoll (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014309#comment-15014309
 ] 

Richard B Knoll commented on CB-10045:
--

At the very least, I think there is no harm in making tables extend the 
bootstrap styling. [~dblotsky] can you think of anything else? If any pages 
absolutely NEED to override the bootstrap CSS, they can always be written in 
HTML

> Extend bootstrap stylings to docs
> -
>
> Key: CB-10045
> URL: https://issues.apache.org/jira/browse/CB-10045
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Priority: Minor
>
> We don't control the HTML that is produced by Redcarpet in the docs 
> generation. That means that we can't apply CSS classes to them. Certain 
> elements (like tables) are probably better off having the bootstrap CSS 
> automatically applied.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10045) Extend bootstrap stylings to docs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014323#comment-15014323
 ] 

ASF GitHub Bot commented on CB-10045:
-

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-docs/pull/427

CB-10045: Made table elements in docs extend bootstrap table classes

I'm adding a docs page and need table styles. This affects the platform 
support table FYI. @dblotsky please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/riknoll/cordova-docs CB-10045

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/427.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #427


commit 604519009c02e7d13a1fa106984ad7c119799980
Author: riknoll 
Date:   2015-11-19T20:44:46Z

CB-10045: Made table elements in docs extend bootstrap table classes




> Extend bootstrap stylings to docs
> -
>
> Key: CB-10045
> URL: https://issues.apache.org/jira/browse/CB-10045
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Priority: Minor
>
> We don't control the HTML that is produced by Redcarpet in the docs 
> generation. That means that we can't apply CSS classes to them. Certain 
> elements (like tables) are probably better off having the bootstrap CSS 
> automatically applied.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

[Steve Gill (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill updated CB-10044:

Assignee: Marco Antonio Ortega Moulin

> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Assignee: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9717) UnauthorizedAccessException when cordova run windows

[Ryan Edge (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014429#comment-15014429
 ] 

Ryan Edge commented on CB-9717:
---

Yes, I have verified this is still an issue, even with the latest RC from 
Visual Studio 2015 and version of Cordova installed.



> UnauthorizedAccessException when cordova run windows
> 
>
> Key: CB-9717
> URL: https://issues.apache.org/jira/browse/CB-9717
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 5.3.2
> Environment: Windows 10
>Reporter: Ryan Edge
>
> When attempting to run cordova, I get an error installing the 
> *CordovaApp.Windows10_0.0.1.0_anycpu_debug.appx* file. This does not happen 
> in Visual Studio 2015.
> I have verified that my permissions for that file are the same regardless of 
> whether I'm using Visual Studio or the CLI, which leads me to believe VS2015 
> is doing some magic under the covers.
> The full error:
> {code}
> Get-AuthenticodeSignature : Access to the path 
> 'C:\Work\sandbox\cordova\hello\platforms\windows\AppPackages\CordovaApp.
> Windows10_0.0.1.0_anycpu_debug_Test\CordovaApp.Windows10_0.0.1.0_anycpu_debug.appx'
>  is denied.
> At 
> C:\Work\sandbox\cordova\hello\platforms\windows\AppPackages\CordovaApp.Windows10_0.0.1.0_anycpu_debug_Test\Add-AppDe
> vPackage.ps1:449 char:25
> + ...   $PackageSignature = Get-AuthenticodeSignature $DeveloperPackagePath
> +   ~~~
> + CategoryInfo  : NotSpecified: (:) [Get-AuthenticodeSignature], 
> UnauthorizedAccessException
> + FullyQualifiedErrorId : 
> System.UnauthorizedAccessException,Microsoft.PowerShell.Commands.GetAuthenticodeSignatur
>eCommand
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

[Marco Antonio Ortega Moulin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marco Antonio Ortega Moulin updated CB-10044:
-
Labels: Android iOS  (was: Android FileTransfer Resumablejs iOS)

> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

[Marco Antonio Ortega Moulin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marco Antonio Ortega Moulin updated CB-10044:
-
Labels: Android FileTransfer Resumablejs iOS  (was: FileTransfer 
Resumablejs)

> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014388#comment-15014388
 ] 

ASF GitHub Bot commented on CB-10044:
-

Github user stevengill commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-158201106
  
Could you add a test for this new usecase?


> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9971) Cordova outputs "Picked up _JAVA_OPTIONS" in stderr

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014181#comment-15014181
 ] 

ASF GitHub Bot commented on CB-9971:


Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/240#discussion_r45385577
  
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +212,54 @@ module.exports = GradleBuilder;
 function isAutoGenerated(file) {
 return fs.existsSync(file) && fs.readFileSync(file, 
'utf8').indexOf(MARKER) > 0;
 }
+
+/**
+ * A special superspawn-like implementation, required to workaround the 
issue
+ *   with java printing some necessary information to stderr instead of 
stdout.
+ *   This function redirects all stderr messages to current process 
stdout. See
--- End diff --

Update the comments based on the revised code that only redirects the one 
line.


> Cordova outputs "Picked up _JAVA_OPTIONS" in stderr
> ---
>
> Key: CB-9971
> URL: https://issues.apache.org/jira/browse/CB-9971
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.0.0
> Environment: Windows, Tools for Apache Cordova in Visual Studio
> Cordova 5.4.0
>Reporter: Michael Braude
>Assignee: Vladimir Kotikov
>Priority: Critical
>  Labels: easyfix, windows,
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Starting with version 5.4.0, Cordova now outputs "Picked up _JAVA_OPTIONS: 
> -Xmx512M" to stderr. This breaks clients such as Visual Studio because we 
> interpret messages in stderr to be errors, and this is not an error. So the 
> result is that we show deploy failures to the dev when there are no errors.
> See this for customer impact: 
> http://stackoverflow.com/questions/33603167/vs2015-build-with-cordova-cli5-4-0-shows-deployment-errors
> We can work around this in Visual Studio by using special casing, but Cordova 
> needs to output this in stdout like it did in previous versions



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9971) Cordova outputs "Picked up _JAVA_OPTIONS" in stderr

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014192#comment-15014192
 ] 

ASF GitHub Bot commented on CB-9971:


Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/240#discussion_r45386856
  
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +212,54 @@ module.exports = GradleBuilder;
 function isAutoGenerated(file) {
 return fs.existsSync(file) && fs.readFileSync(file, 
'utf8').indexOf(MARKER) > 0;
 }
+
+/**
+ * A special superspawn-like implementation, required to workaround the 
issue
+ *   with java printing some necessary information to stderr instead of 
stdout.
+ *   This function redirects all stderr messages to current process 
stdout. See
+ *   https://issues.apache.org/jira/browse/CB-9971 for explanation.
+ *
+ * @param   {String}cmd   A command to spawn
+ * @param   {String[]}  args  Command arguments. Note that on Windows 
arguments
+ *   will be concatenated into string and passed to 'cmd.exe' along with 
'/s'
+ *   and '/c' swithces for proper space-in-path handling
+ *
+ * @return  {Promise}A promise, rejected with error message, if
+ *   underlying command exits with nonzero exit code, fulfilled otherwise
+ */
+function spawnWithStderrRedirect(cmd, args) {
+var opts = { stdio: 'pipe' };
+
+if (process.platform === 'win32') {
+// Work around spawn not being able to find .bat files.
+var joinedArgs = [cmd]
+.concat(args)
+.map(function(a){
+// Add quotes to arguments which contains whitespaces
+if (/^[^"].* .*[^"]/.test(a)) return '"' + a + '"';
+return a;
+}).join(' ');
+
+args = ['/s', '/c'].concat('"' + joinedArgs + '"');
+cmd = 'cmd';
+opts.windowsVerbatimArguments = true;
+}
+
+return Q.Promise(function (resolve, reject) {
+var proc = child_process.spawn(cmd, args, opts);
+
+proc.stdout.on('data', process.stdout.write.bind(process.stdout));
+proc.stderr.on('data', function (data) {
+var isRedirectNeeded = data.toString().match(/^Picked up 
_JAVA_OPTIONS: /i);
+process[isRedirectNeeded ? 'stdout' : 'stderr'].write(data);
--- End diff --

Are we sure that putting that line on stdout will not cause different 
problems? Would it be better to completely suppress it? I don't think anyone 
actually cares to see it.


> Cordova outputs "Picked up _JAVA_OPTIONS" in stderr
> ---
>
> Key: CB-9971
> URL: https://issues.apache.org/jira/browse/CB-9971
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.0.0
> Environment: Windows, Tools for Apache Cordova in Visual Studio
> Cordova 5.4.0
>Reporter: Michael Braude
>Assignee: Vladimir Kotikov
>Priority: Critical
>  Labels: easyfix, windows,
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Starting with version 5.4.0, Cordova now outputs "Picked up _JAVA_OPTIONS: 
> -Xmx512M" to stderr. This breaks clients such as Visual Studio because we 
> interpret messages in stderr to be errors, and this is not an error. So the 
> result is that we show deploy failures to the dev when there are no errors.
> See this for customer impact: 
> http://stackoverflow.com/questions/33603167/vs2015-build-with-cordova-cli5-4-0-shows-deployment-errors
> We can work around this in Visual Studio by using special casing, but Cordova 
> needs to output this in stdout like it did in previous versions



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

[Marco Antonio Ortega Moulin (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014273#comment-15014273
 ] 

Marco Antonio Ortega Moulin commented on CB-10044:
--

I already have the fix for this, I want this feature assigned to me. Thank you.

> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10040) Compile Error in InAppBrowser Plugin for iOS - No known instance method for selector 'URLIsWhitelisted:'

[Shazron Abdullah (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-10040:
--
Attachment: CB-10040V1.patch
CB-10040V2.patch

[~martias0] sent me these two patches for review (two different approaches to 
fix it)

> Compile Error in InAppBrowser Plugin for iOS - No known instance method for 
> selector 'URLIsWhitelisted:'
> 
>
> Key: CB-10040
> URL: https://issues.apache.org/jira/browse/CB-10040
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 4.0.0
> Environment: OS X 10.11.1, Xcode 7.1.1, iOS 9.1
>Reporter: Inderpreet
>Assignee: Sergey Grebnov
>  Labels: Triaged, cordova-ios-4.0.x, cordova-plugin-inappbrowser, 
> ios
> Attachments: CB-10040V1.patch, CB-10040V2.patch
>
>
> While working with cordova-ios branch 
> (https://github.com/apache/cordova-ios.git#master) we are facing a compile 
> error in InAppBrowser 
> Plugin(https://github.com/apache/cordova-plugin-inappbrowser.git#master), it 
> can be due to the recent update to cordova-ios i.e. iOS whitelist removal 
> CB-9972 
> Error details : CDVInAppBrowser.m:231:31: No known instance method for 
> selector 'URLIsWhitelisted:'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014285#comment-15014285
 ] 

ASF GitHub Bot commented on CB-10044:
-

GitHub user maortega opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/116

CB-10044 FileTransfer plug in can upload parts of a file to implement 
resumablejs

By sending the startByte and endByte to the FileTransfer plugin we are able 
to upload parts of a file therefore we can integrate this with ResumableJS

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maortega/cordova-plugin-file-transfer master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #116


commit 2cf7acb9023bedc6d23e7ff765a78522b1677d5a
Author: MARCO ANTONIO ORTEGA 
Date:   2015-11-18T20:36:33Z

Optionally receive startByte and endByte

commit 824a5b223d02e12ab21430184486ed3d4b3ca7cc
Author: MARCO ANTONIO ORTEGA 
Date:   2015-11-19T16:37:05Z

Use byte range to send a portion of a file to be able to be compatible with 
resumablejs

commit 38cc769dc92b7f32e727021508b535f3ba42e402
Author: MARCO ANTONIO ORTEGA 
Date:   2015-11-19T16:47:19Z

Send byte range of file.

commit 8a642151a16c0aa275adf5b971b180c964e9bb8d
Author: MARCO ANTONIO ORTEGA 
Date:   2015-11-19T16:47:31Z

Merge branch 'feature/Accept_file_ranges' into develop

commit 33774fd8c8b1b493a92fd6dc5bcaf531ab7c6371
Author: MARCO ANTONIO ORTEGA 
Date:   2015-11-19T16:49:41Z

Merge branch 'release/1.1'




> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10044) Update FileTransfer plugin to upload a part of a file to be able to be used with ResumableJS

[Marco Antonio Ortega Moulin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marco Antonio Ortega Moulin updated CB-10044:
-
Priority: Minor  (was: Major)

> Update FileTransfer plugin to upload a part of a file to be able to be used 
> with ResumableJS
> 
>
> Key: CB-10044
> URL: https://issues.apache.org/jira/browse/CB-10044
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin File Transfer
>Affects Versions: 3.5.0
> Environment: Android and iOS
>Reporter: Marco Antonio Ortega Moulin
>Priority: Minor
>  Labels: Android, iOS
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When using Resumablejs we want to be able to use the FileTransfer plugin to 
> upload parts of a file. In order to do this we will be sending the startByte 
> and endByte parameters to the FileTransfer plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-10046) INSTALL_FAILED_CONFLICTING_PROVIDER error for apps using Google Play Services

[Simon MacDonald (JIRA)]

Simon MacDonald created CB-10046:


 Summary: INSTALL_FAILED_CONFLICTING_PROVIDER error for apps using 
Google Play Services
 Key: CB-10046
 URL: https://issues.apache.org/jira/browse/CB-10046
 Project: Apache Cordova
  Issue Type: Improvement
  Components: Android
Reporter: Simon MacDonald
Priority: Minor


If two applications are using Google Play Services you can get into a situation 
where the second app fails to install with a 
[INSTALL_FAILED_CONFLICTING_PROVIDER] error. The root cause of it is a bug in 
build tools. 

https://code.google.com/p/android/issues/detail?id=193567

The work around is pretty simple as you just need to add an “applicationId” to 
your build.gradle. Perhaps this should be added to our build.gradle file.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10040) Compile Error in InAppBrowser Plugin for iOS - No known instance method for selector 'URLIsWhitelisted:'

[Shazron Abdullah (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014278#comment-15014278
 ] 

Shazron Abdullah commented on CB-10040:
---

[~sgrebnov] mind if I take this one?

> Compile Error in InAppBrowser Plugin for iOS - No known instance method for 
> selector 'URLIsWhitelisted:'
> 
>
> Key: CB-10040
> URL: https://issues.apache.org/jira/browse/CB-10040
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 4.0.0
> Environment: OS X 10.11.1, Xcode 7.1.1, iOS 9.1
>Reporter: Inderpreet
>Assignee: Sergey Grebnov
>  Labels: Triaged, cordova-ios-4.0.x, cordova-plugin-inappbrowser, 
> ios
> Attachments: CB-10040V1.patch, CB-10040V2.patch
>
>
> While working with cordova-ios branch 
> (https://github.com/apache/cordova-ios.git#master) we are facing a compile 
> error in InAppBrowser 
> Plugin(https://github.com/apache/cordova-plugin-inappbrowser.git#master), it 
> can be due to the recent update to cordova-ios i.e. iOS whitelist removal 
> CB-9972 
> Error details : CDVInAppBrowser.m:231:31: No known instance method for 
> selector 'URLIsWhitelisted:'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-10045) Extend bootstrap stylings to docs

[Richard B Knoll (JIRA)]

Richard B Knoll created CB-10045:


 Summary: Extend bootstrap stylings to docs
 Key: CB-10045
 URL: https://issues.apache.org/jira/browse/CB-10045
 Project: Apache Cordova
  Issue Type: Improvement
  Components: Docs
Reporter: Richard B Knoll
Priority: Minor


We don't control the HTML that is produced by Redcarpet in the docs generation. 
That means that we can't apply CSS classes to them. Certain elements (like 
tables) are probably better off having the bootstrap CSS automatically applied.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10047) [StatusBar] Fix iOS8 Deprecation Warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014537#comment-15014537
 ] 

ASF GitHub Bot commented on CB-10047:
-

Github user jordancardwell commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158219287
  
Hey folks.. will this one get some love any time soon?

Just checking.. I updated to latest plugin version and thought it didn't 
actually update since I was still getting those deprecation warnings.

I also created a [JIRA 
issue](https://issues.apache.org/jira/browse/CB-10047) to maybe give some 
traction


> [StatusBar] Fix iOS8 Deprecation Warnings
> -
>
> Key: CB-10047
> URL: https://issues.apache.org/jira/browse/CB-10047
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
>Reporter: jordan cardwell
>Priority: Minor
>  Labels: deprecated, deprecation
>
> Issue has been around for a while
> [https://github.com/apache/cordova-plugin-statusbar/pull/26]
> After use Cordova build ios
> there are some warning about UIDeviceOrientation and UIInterfaceOrientation:
> Implicit conversion from enumeration type "UIDeviceOrientation"(aka "enum 
> UIDeviceOrientation") to different enumeration type "UIInterfaceOrientation" 
> (aka "enum UIInterfaceOrientation")
> Based on current ios api, UIViewControl.interfaceOrientation has been 
> deprecated.
> Fixed those warning using function: [[UIDevice currentDevice] orientation] 
> instead of self.viewController.interfaceOrientation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8917) Add api/way to get plugins results even when Cordova activity restarts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014662#comment-15014662
 ] 

ASF GitHub Bot commented on CB-8917:


Github user Bnaya commented on the pull request:

https://github.com/apache/cordova-android/pull/239#issuecomment-158226691
  
I will extend the scope of that issue.

This change can/should also help the apps developers to recover from 
situations that the app sent to the background not only by activity from the 
app, but also if the user hit the home button/notifications etc
And lets say the app had several IO ongoing operations by plugins. even 2 
operations by the same plugin.
The operating system can kill the activity also in such case, and then if 
the user navigates back to the app and the webview will be reloaded with resume 
event.


> Add api/way to get plugins results even when Cordova activity restarts  
> 
>
> Key: CB-8917
> URL: https://issues.apache.org/jira/browse/CB-8917
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Bnaya
>
> In android when you have a plugin that opens new activity the CordovaActivity 
> will be killed and you won't get the result from the plugin.
> The new activity will get the results but because the plugin objects are dead 
> and the webview reloaded you can get the data to the js callback.
> The most noticeable example is the camera plugin. (And maybe its the same 
> with even more platforms)
> possible solution for this is to add metadata to the device ready event with 
> incoming data from plugins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10040) Compile Error in InAppBrowser Plugin for iOS - No known instance method for selector 'URLIsWhitelisted:'

[Shazron Abdullah (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014747#comment-15014747
 ] 

Shazron Abdullah commented on CB-10040:
---

Sorry I just noticed that the patch went in without any attribution to you. My 
mistake, I would never claim attribution knowingly. [~martias0] do you want me 
to revert, and fix the attribution? Let me know.

> Compile Error in InAppBrowser Plugin for iOS - No known instance method for 
> selector 'URLIsWhitelisted:'
> 
>
> Key: CB-10040
> URL: https://issues.apache.org/jira/browse/CB-10040
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 4.0.0
> Environment: OS X 10.11.1, Xcode 7.1.1, iOS 9.1
>Reporter: Inderpreet
>Assignee: Shazron Abdullah
>  Labels: Triaged, cordova-ios-4.0.x, cordova-plugin-inappbrowser, 
> ios
> Attachments: CB-10040V1.patch, CB-10040V2.patch
>
>
> While working with cordova-ios branch 
> (https://github.com/apache/cordova-ios.git#master) we are facing a compile 
> error in InAppBrowser 
> Plugin(https://github.com/apache/cordova-plugin-inappbrowser.git#master), it 
> can be due to the recent update to cordova-ios i.e. iOS whitelist removal 
> CB-9972 
> Error details : CDVInAppBrowser.m:231:31: No known instance method for 
> selector 'URLIsWhitelisted:'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-10040) Compile Error in InAppBrowser Plugin for iOS - No known instance method for selector 'URLIsWhitelisted:'

[Shazron Abdullah (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah reassigned CB-10040:
-

Assignee: Shazron Abdullah  (was: Sergey Grebnov)

> Compile Error in InAppBrowser Plugin for iOS - No known instance method for 
> selector 'URLIsWhitelisted:'
> 
>
> Key: CB-10040
> URL: https://issues.apache.org/jira/browse/CB-10040
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 4.0.0
> Environment: OS X 10.11.1, Xcode 7.1.1, iOS 9.1
>Reporter: Inderpreet
>Assignee: Shazron Abdullah
>  Labels: Triaged, cordova-ios-4.0.x, cordova-plugin-inappbrowser, 
> ios
> Attachments: CB-10040V1.patch, CB-10040V2.patch
>
>
> While working with cordova-ios branch 
> (https://github.com/apache/cordova-ios.git#master) we are facing a compile 
> error in InAppBrowser 
> Plugin(https://github.com/apache/cordova-plugin-inappbrowser.git#master), it 
> can be due to the recent update to cordova-ios i.e. iOS whitelist removal 
> CB-9972 
> Error details : CDVInAppBrowser.m:231:31: No known instance method for 
> selector 'URLIsWhitelisted:'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8917) Add api/way to get plugins results even when Cordova activity restarts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014500#comment-15014500
 ] 

ASF GitHub Bot commented on CB-8917:


GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-docs/pull/428

CB-8917: adding docs for Android lifecycle considerations

***Don't Merge! Dependent on [CB-8917 
PR](https://github.com/apache/cordova-android/pull/239) in cordova-android!***

@infil00p @jasongin I'd appreciate if you could look this over to make sure 
it's accurate. It adds documentation for my proposed API change, but also gives 
a general guide for handling the Activity lifecycle in Cordova apps on Android. 
I think everything before the last section applies to cordova-android as it 
currently stands, and could be useful independent of CB-8917. Any feedback is 
appreciated.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/riknoll/cordova-docs CB-8917-docs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/428.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #428


commit 46e6127053e69bdf718e4726a0247f6362bd68c7
Author: riknoll 
Date:   2015-11-19T20:37:46Z

CB-8917: adding docs for Android lifecycle considerations




> Add api/way to get plugins results even when Cordova activity restarts  
> 
>
> Key: CB-8917
> URL: https://issues.apache.org/jira/browse/CB-8917
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Bnaya
>
> In android when you have a plugin that opens new activity the CordovaActivity 
> will be killed and you won't get the result from the plugin.
> The new activity will get the results but because the plugin objects are dead 
> and the webview reloaded you can get the data to the js callback.
> The most noticeable example is the camera plugin. (And maybe its the same 
> with even more platforms)
> possible solution for this is to add metadata to the device ready event with 
> incoming data from plugins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8917) Add api/way to get plugins results even when Cordova activity restarts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014514#comment-15014514
 ] 

ASF GitHub Bot commented on CB-8917:


Github user riknoll commented on the pull request:

https://github.com/apache/cordova-android/pull/239#issuecomment-158217175
  
Hey all, I've added a PR to the docs repo that documents the result 
callback part of this change as well as general Android lifecycle 
considerations: https://github.com/apache/cordova-docs/pull/428


> Add api/way to get plugins results even when Cordova activity restarts  
> 
>
> Key: CB-8917
> URL: https://issues.apache.org/jira/browse/CB-8917
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Bnaya
>
> In android when you have a plugin that opens new activity the CordovaActivity 
> will be killed and you won't get the result from the plugin.
> The new activity will get the results but because the plugin objects are dead 
> and the webview reloaded you can get the data to the js callback.
> The most noticeable example is the camera plugin. (And maybe its the same 
> with even more platforms)
> possible solution for this is to add metadata to the device ready event with 
> incoming data from plugins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8917) Add api/way to get plugins results even when Cordova activity restarts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014521#comment-15014521
 ] 

ASF GitHub Bot commented on CB-8917:


Github user infil00p commented on the pull request:

https://github.com/apache/cordova-android/pull/239#issuecomment-158217697
  
@Titoine Are you having problems after the patch or before? I'm not sure.


> Add api/way to get plugins results even when Cordova activity restarts  
> 
>
> Key: CB-8917
> URL: https://issues.apache.org/jira/browse/CB-8917
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Bnaya
>
> In android when you have a plugin that opens new activity the CordovaActivity 
> will be killed and you won't get the result from the plugin.
> The new activity will get the results but because the plugin objects are dead 
> and the webview reloaded you can get the data to the js callback.
> The most noticeable example is the camera plugin. (And maybe its the same 
> with even more platforms)
> possible solution for this is to add metadata to the device ready event with 
> incoming data from plugins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8917) Add api/way to get plugins results even when Cordova activity restarts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014541#comment-15014541
 ] 

ASF GitHub Bot commented on CB-8917:


Github user Titoine commented on the pull request:

https://github.com/apache/cordova-android/pull/239#issuecomment-158219586
  
@infil00p Before the patch.


> Add api/way to get plugins results even when Cordova activity restarts  
> 
>
> Key: CB-8917
> URL: https://issues.apache.org/jira/browse/CB-8917
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Bnaya
>
> In android when you have a plugin that opens new activity the CordovaActivity 
> will be killed and you won't get the result from the plugin.
> The new activity will get the results but because the plugin objects are dead 
> and the webview reloaded you can get the data to the js callback.
> The most noticeable example is the camera plugin. (And maybe its the same 
> with even more platforms)
> possible solution for this is to add metadata to the device ready event with 
> incoming data from plugins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-10047) [StatusBar] Fix iOS8 Deprecation Warnings

[jordan cardwell (JIRA)]

jordan cardwell created CB-10047:


 Summary: [StatusBar] Fix iOS8 Deprecation Warnings
 Key: CB-10047
 URL: https://issues.apache.org/jira/browse/CB-10047
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Statusbar
Reporter: jordan cardwell
Priority: Minor


Issue has been around for a while
[https://github.com/apache/cordova-plugin-statusbar/pull/26]

After use Cordova build ios
there are some warning about UIDeviceOrientation and UIInterfaceOrientation:
Implicit conversion from enumeration type "UIDeviceOrientation"(aka "enum 
UIDeviceOrientation") to different enumeration type "UIInterfaceOrientation" 
(aka "enum UIInterfaceOrientation")

Based on current ios api, UIViewControl.interfaceOrientation has been 
deprecated.

Fixed those warning using function: [[UIDevice currentDevice] orientation] 
instead of self.viewController.interfaceOrientation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-10040) Compile Error in InAppBrowser Plugin for iOS - No known instance method for selector 'URLIsWhitelisted:'

[Shazron Abdullah (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah resolved CB-10040.
---
Resolution: Fixed

patch-1 is correct.

> Compile Error in InAppBrowser Plugin for iOS - No known instance method for 
> selector 'URLIsWhitelisted:'
> 
>
> Key: CB-10040
> URL: https://issues.apache.org/jira/browse/CB-10040
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 4.0.0
> Environment: OS X 10.11.1, Xcode 7.1.1, iOS 9.1
>Reporter: Inderpreet
>Assignee: Shazron Abdullah
>  Labels: Triaged, cordova-ios-4.0.x, cordova-plugin-inappbrowser, 
> ios
> Attachments: CB-10040V1.patch, CB-10040V2.patch
>
>
> While working with cordova-ios branch 
> (https://github.com/apache/cordova-ios.git#master) we are facing a compile 
> error in InAppBrowser 
> Plugin(https://github.com/apache/cordova-plugin-inappbrowser.git#master), it 
> can be due to the recent update to cordova-ios i.e. iOS whitelist removal 
> CB-9972 
> Error details : CDVInAppBrowser.m:231:31: No known instance method for 
> selector 'URLIsWhitelisted:'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8863) Fix potential problems with blocks usage in core plugins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014752#comment-15014752
 ] 

ASF GitHub Bot commented on CB-8863:


GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/76

CB-8863 Fix block usage of self



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-plugin-media CB-8863

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #76


commit 8c74615113e9fc6c224b27445aee48659bcfc9ce
Author: Jesse MacFadyen 
Date:   2015-11-19T23:23:30Z

Fix block usage of self




> Fix potential problems with blocks usage in core plugins
> 
>
> Key: CB-8863
> URL: https://issues.apache.org/jira/browse/CB-8863
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Jesse MacFadyen
>  Labels: cordova-ios-5.0.x
>
> Audit the core plugins to check for proper blocks usage.
> Problems that I see can be summed up in this (fixed) code:
> https://github.com/apache/cordova-plugin-splashscreen/blob/fa60f01adcba2d21583de7972a0facc4da1eb75e/src/ios/CDVSplashScreen.m#L292-L313
> 1. You need a weak reference to "self" in blocks to prevent retain cycle 
> problems.
> Fix: 
> https://github.com/apache/cordova-plugin-splashscreen/blob/fa60f01adcba2d21583de7972a0facc4da1eb75e/src/ios/CDVSplashScreen.m#L292
> 2. Anything that calls UIKit methods, which includes plugins that write 
> JavaScript back to the UIWebView (commandDelegate functions), must be called 
> in the main thread.
> Fix: 
> https://github.com/apache/cordova-plugin-splashscreen/blob/fa60f01adcba2d21583de7972a0facc4da1eb75e/src/ios/CDVSplashScreen.m#L308-L310
>  (UPDATE: we actually already handle this in evalJS)
> 3. Avoid creating private variables like this in the first place -- I would 
> create a class extension which will effectively have "private" properties 
> (nothing is truly private in objc). This is to avoid this situation in the 
> block where you have to cast the weak self into a strong self (and check it's 
> still around), just to access a private variable:
> https://github.com/apache/cordova-plugin-splashscreen/blob/fa60f01adcba2d21583de7972a0facc4da1eb75e/src/ios/CDVSplashScreen.m#L298-L304
> Of course since we are modifying UIKit items here, rule 2 above also applies.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10040) Compile Error in InAppBrowser Plugin for iOS - No known instance method for selector 'URLIsWhitelisted:'

[Shazron Abdullah (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014753#comment-15014753
 ] 

Shazron Abdullah commented on CB-10040:
---

I'm asking because its a trivial fix, if it was a more complicated patch I 
would have reverted and fixed it.

> Compile Error in InAppBrowser Plugin for iOS - No known instance method for 
> selector 'URLIsWhitelisted:'
> 
>
> Key: CB-10040
> URL: https://issues.apache.org/jira/browse/CB-10040
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 4.0.0
> Environment: OS X 10.11.1, Xcode 7.1.1, iOS 9.1
>Reporter: Inderpreet
>Assignee: Shazron Abdullah
>  Labels: Triaged, cordova-ios-4.0.x, cordova-plugin-inappbrowser, 
> ios
> Attachments: CB-10040V1.patch, CB-10040V2.patch
>
>
> While working with cordova-ios branch 
> (https://github.com/apache/cordova-ios.git#master) we are facing a compile 
> error in InAppBrowser 
> Plugin(https://github.com/apache/cordova-plugin-inappbrowser.git#master), it 
> can be due to the recent update to cordova-ios i.e. iOS whitelist removal 
> CB-9972 
> Error details : CDVInAppBrowser.m:231:31: No known instance method for 
> selector 'URLIsWhitelisted:'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-8050) Photo quality is very low when target width and height is above 640px

[Raghav (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raghav updated CB-8050:
---
Priority: Minor  (was: Major)

> Photo quality is very low when target width and height is above 640px 
> --
>
> Key: CB-8050
> URL: https://issues.apache.org/jira/browse/CB-8050
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Affects Versions: 3.5.0
> Environment: iOS Cordova 3.5 iPhone 5
>Reporter: Michael M
>Priority: Minor
>  Labels: iOS
>
> I use Cordova 3.5.0 and the latests version of the Camera plugin. I figured 
> out that the image quality drops when I set the targetWidth and targetHeight 
> above 640. Here is the configuration I use:
> {code:javascript}
> navigator.camera.getPicture(onSuccess, onFail, 
>   { quality : 100,
>   destinationType : Camera.DestinationType.FILE_URI,
>   sourceType : Camera.PictureSourceType.CAMERA,
>   allowEdit : true,
>   encodingType: Camera.EncodingType.JPEG,
>   targetWidth: 640,
>   targetHeight: 640,
>   saveToPhotoAlbum: true 
> });
> {code}
> I did several tests capturing photos with the phonegap camera and compared 
> the images that were automatically saved to album.
> How can I make PhoneGap Camera images with target width and height bigger 
> than 640px of high quality?
> I posted my sample results on stackoverflow: 
> http://stackoverflow.com/questions/27043534/how-can-i-make-phonegap-camera-images-with-target-width-and-height-bigger-than-6



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8917) Add api/way to get plugins results even when Cordova activity restarts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014643#comment-15014643
 ] 

ASF GitHub Bot commented on CB-8917:


Github user riknoll commented on the pull request:

https://github.com/apache/cordova-android/pull/239#issuecomment-158225021
  
Also, I don't think you can get into a situation where you have two 
Activity results pending (correct me if I'm wrong on that one).


> Add api/way to get plugins results even when Cordova activity restarts  
> 
>
> Key: CB-8917
> URL: https://issues.apache.org/jira/browse/CB-8917
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Bnaya
>
> In android when you have a plugin that opens new activity the CordovaActivity 
> will be killed and you won't get the result from the plugin.
> The new activity will get the results but because the plugin objects are dead 
> and the webview reloaded you can get the data to the js callback.
> The most noticeable example is the camera plugin. (And maybe its the same 
> with even more platforms)
> possible solution for this is to add metadata to the device ready event with 
> incoming data from plugins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-10014) Gradle variable applicationId is not set, creates issue with Google Play services 8.3.0

[Josh Kasten (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Kasten updated CB-10014:
-
Description: 
applicationId is not set in build.gradle which creates an issue with 
com.google.android.gms:play-services-measurement:8.3.0. This aar file has the 
following line in AndroidManifest.xml
{code:xml}

{code}

applicationId becomes `com.google.android.gms.measurement` when the manifest 
entry is merged since applicationId is not set in the main project .gradle 
file. This means that if another app also includes the Google Play services 
library 8.3.0 it will fail to install on the device with an 
INSTALL_FAILED_CONFLICTING_PROVIDER error because the name isn't unique.

This is silent problem to developers as it only becomes an issue when the end 
user installs 2 apps built this way. This should be addressed quickly to 
prevent this error when developers release their APK or provide a work around 
for plugin developers to add something to their plugin.xml to default in the 
applicationId gradle variable.

Thanks.

  was:
applicationId is not set in build.gradle which creates an issue with 
com.google.android.gms:play-services-measurement:8.3.0. This aar file has the 
following line in AndroidManifest.xml
{code:xml}
   
{code}

applicationId becomes `com.google.android.gms.measurement` when the manifest 
entry is merged since applicationId is not set in the main project .gradle 
file. This means that if another apps also includes the Google Play services 
library 8.3.0 it will fail to install on the device with an 
INSTALL_FAILED_CONFLICTING_PROVIDER error because the name will be the same.

This is silent issue to the developer as it only becomes an issue when the end 
user installs 2 apps built this way. This issue should be addressed quickly to 
prevent issues when developers release their APK or provide a work for plugin 
developers to add something to their plugin.xml to default in a applicationId.

Thanks.


> Gradle variable applicationId is not set, creates issue with Google Play 
> services 8.3.0
> ---
>
> Key: CB-10014
> URL: https://issues.apache.org/jira/browse/CB-10014
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 5.4.1
>Reporter: Josh Kasten
>  Labels: android, gradle
>
> applicationId is not set in build.gradle which creates an issue with 
> com.google.android.gms:play-services-measurement:8.3.0. This aar file has the 
> following line in AndroidManifest.xml
> {code:xml}
> android:authorities="${applicationId}.google_measurement_service"
>
> android:name="com.google.android.gms.measurement.AppMeasurementContentProvider"
>android:exported="false"/>
> {code}
> applicationId becomes `com.google.android.gms.measurement` when the manifest 
> entry is merged since applicationId is not set in the main project .gradle 
> file. This means that if another app also includes the Google Play services 
> library 8.3.0 it will fail to install on the device with an 
> INSTALL_FAILED_CONFLICTING_PROVIDER error because the name isn't unique.
> This is silent problem to developers as it only becomes an issue when the end 
> user installs 2 apps built this way. This should be addressed quickly to 
> prevent this error when developers release their APK or provide a work around 
> for plugin developers to add something to their plugin.xml to default in the 
> applicationId gradle variable.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8917) Add api/way to get plugins results even when Cordova activity restarts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014549#comment-15014549
 ] 

ASF GitHub Bot commented on CB-8917:


Github user Bnaya commented on the pull request:

https://github.com/apache/cordova-android/pull/239#issuecomment-158220594
  
@riknoll, after going over the docs (which looks great btw) its seems it 
supports only single plugin result
What if you wait for two or more plugins responses? like file system 
operation and camera plugin result?


> Add api/way to get plugins results even when Cordova activity restarts  
> 
>
> Key: CB-8917
> URL: https://issues.apache.org/jira/browse/CB-8917
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Bnaya
>
> In android when you have a plugin that opens new activity the CordovaActivity 
> will be killed and you won't get the result from the plugin.
> The new activity will get the results but because the plugin objects are dead 
> and the webview reloaded you can get the data to the js callback.
> The most noticeable example is the camera plugin. (And maybe its the same 
> with even more platforms)
> possible solution for this is to add metadata to the device ready event with 
> incoming data from plugins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org