[jira] [Commented] (CB-12743) Phonegapped Angular app on iOS 10.3 freezes after login
[ https://issues.apache.org/jira/browse/CB-12743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035763#comment-16035763 ] Shazron Abdullah commented on CB-12743: --- If you can provide a sample project for us to repro, that would be great. > Phonegapped Angular app on iOS 10.3 freezes after login > --- > > Key: CB-12743 > URL: https://issues.apache.org/jira/browse/CB-12743 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Rishi > > I was stuck with a very strange issue, if you can provide any pointers that > would be of great help. > > I have an angular app which is phone gapped with latest cordova on android > and ios. The app working great on Android and iOS 9.3.5. The versions i used > to phone gap are > cordova - 6.5.0 > cordova-ios 4.3.1 > cordovan-android - 6.1.2 > Using CDVUIWebViewEngine > The problem is I was able to login into angular app which requires oAuth, > after logging in I can't able to click on any of the menu's, buttons i.e. > can't tap / touch any on the page. I can able to click the buttons > programmatically from the debug console. Verified the z-index is not the > issue. Splash screen is fine. The elements are binding, thinking is there any > layer above the page (or race condition) which is preventing to interact with > the page. Strange thing is the same app works sometimes (5% of time). This > problem happens only on iOS 10.x and i don't see any exceptions or errors on > the debug console. > Any help is greatly appreciated. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12745) Add suppport for data: URIs which are not Base64 encoded
[ https://issues.apache.org/jira/browse/CB-12745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12745: -- Environment: iOS, Windows Component/s: (was: cordova-windows) (was: cordova-ios) > Add suppport for data: URIs which are not Base64 encoded > > > Key: CB-12745 > URL: https://issues.apache.org/jira/browse/CB-12745 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-file-transfer > Environment: iOS, Windows >Reporter: Wolfgang Koller >Assignee: Wolfgang Koller > > Currently the FileUpload implementation on iOS expects the data URI content > to be Base64 encoded. In order to be more compatible to the Android > implementation, it should be possible to also use non Base64 encoded content. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12668) support arbitrary creation of resources in the Asset Catalog
[ https://issues.apache.org/jira/browse/CB-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12668: -- Fix Version/s: cordova-ios@4.4.1 > support arbitrary creation of resources in the Asset Catalog > > > Key: CB-12668 > URL: https://issues.apache.org/jira/browse/CB-12668 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-ios >Affects Versions: 3.6.4 >Reporter: Josh Sharpe >Priority: Critical > Labels: cordova-ios > Fix For: cordova-ios@4.4.1 > > > A handful of plugins* recommend the use of an image/asset out of the Asset > Catalog. It would be great if we could create those just by setting tags in > config.xml, similar to and that then generate the resource in > Xcode. > My specific use case is to add a "back" image to be used by > 'cordova-plugin-themeablebrowser'. I can do this manually by: > - opening xCode > - Click on Project -> Resources -> Image.xcassets > - Click '+' in the bottom task bar -> New Image Set > - Rename the new Set 'back' > - Manually drag and drop 3 images into xcode > To be clear - I'm not asking that cordova produce different sized images as I > believe that's out of scope. I just need it to build the new resource in > xcode referencing certain files on disk with tags like: > {code} > > > > > > {code} > * Example plugins: > https://github.com/arnesson/cordova-plugin-firebase > https://github.codifferent m/phonegap/phonegap-plugin-push > https://github.com/initialxy/cordova-plugin-themeablebrowser > **Bonus!** > It'd be extra great, since I'm sure some folks want this, if cordova could > add sound files to be used by firebase/push plugins that can leverage those > if they exist, but I'm not sure how those get set up in xcode such that > phonegap-plugin-push can use them. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12668) support arbitrary creation of resources in the Asset Catalog
[ https://issues.apache.org/jira/browse/CB-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035760#comment-16035760 ] Shazron Abdullah commented on CB-12668: --- Setting fix-version for triage purposes > support arbitrary creation of resources in the Asset Catalog > > > Key: CB-12668 > URL: https://issues.apache.org/jira/browse/CB-12668 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-ios >Affects Versions: 3.6.4 >Reporter: Josh Sharpe >Priority: Critical > Labels: cordova-ios > Fix For: cordova-ios@4.4.1 > > > A handful of plugins* recommend the use of an image/asset out of the Asset > Catalog. It would be great if we could create those just by setting tags in > config.xml, similar to and that then generate the resource in > Xcode. > My specific use case is to add a "back" image to be used by > 'cordova-plugin-themeablebrowser'. I can do this manually by: > - opening xCode > - Click on Project -> Resources -> Image.xcassets > - Click '+' in the bottom task bar -> New Image Set > - Rename the new Set 'back' > - Manually drag and drop 3 images into xcode > To be clear - I'm not asking that cordova produce different sized images as I > believe that's out of scope. I just need it to build the new resource in > xcode referencing certain files on disk with tags like: > {code} > > > > > > {code} > * Example plugins: > https://github.com/arnesson/cordova-plugin-firebase > https://github.codifferent m/phonegap/phonegap-plugin-push > https://github.com/initialxy/cordova-plugin-themeablebrowser > **Bonus!** > It'd be extra great, since I'm sure some folks want this, if cordova could > add sound files to be used by firebase/push plugins that can leverage those > if they exist, but I'm not sure how those get set up in xcode such that > phonegap-plugin-push can use them. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12668) support arbitrary creation of resources in the Asset Catalog
[ https://issues.apache.org/jira/browse/CB-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12668: -- Description: A handful of plugins* recommend the use of an image/asset out of the Asset Catalog. It would be great if we could create those just by setting tags in config.xml, similar to and that then generate the resource in Xcode. My specific use case is to add a "back" image to be used by 'cordova-plugin-themeablebrowser'. I can do this manually by: - opening xCode - Click on Project -> Resources -> Image.xcassets - Click '+' in the bottom task bar -> New Image Set - Rename the new Set 'back' - Manually drag and drop 3 images into xcode To be clear - I'm not asking that cordova produce different sized images as I believe that's out of scope. I just need it to build the new resource in xcode referencing certain files on disk with tags like: {code} {code} * Example plugins: https://github.com/arnesson/cordova-plugin-firebase https://github.codifferent m/phonegap/phonegap-plugin-push https://github.com/initialxy/cordova-plugin-themeablebrowser **Bonus!** It'd be extra great, since I'm sure some folks want this, if cordova could add sound files to be used by firebase/push plugins that can leverage those if they exist, but I'm not sure how those get set up in xcode such that phonegap-plugin-push can use them. was: A handful of plugins* recommend the use of an image/asset out of the Asset Catalog. It would be great if we could create those just by setting tags in config.xml, similar to and that then generate the resource in Xcode. My specific use case is to add a "back" image to be used by 'cordova-plugin-themeablebrowser'. I can do this manually by: - opening xCode - Click on Project -> Resources -> Image.xcassets - Click '+' in the bottom task bar -> New Image Set - Rename the new Set 'back' - Manually drag and drop 3 images into xcode To be clear - I'm not asking that cordova produce different sized images as I believe that's out of scope. I just need it to build the new resource in xcode referencing certain files on disk with tags like: https://github.com/arnesson/cordova-plugin-firebase https://github.codifferent m/phonegap/phonegap-plugin-push https://github.com/initialxy/cordova-plugin-themeablebrowser **Bonus!** It'd be extra great, since I'm sure some folks want this, if cordova could add sound files to be used by firebase/push plugins that can leverage those if they exist, but I'm not sure how those get set up in xcode such that phonegap-plugin-push can use them. > support arbitrary creation of resources in the Asset Catalog > > > Key: CB-12668 > URL: https://issues.apache.org/jira/browse/CB-12668 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-ios >Affects Versions: 3.6.4 >Reporter: Josh Sharpe >Priority: Critical > Labels: cordova-ios > > A handful of plugins* recommend the use of an image/asset out of the Asset > Catalog. It would be great if we could create those just by setting tags in > config.xml, similar to and that then generate the resource in > Xcode. > My specific use case is to add a "back" image to be used by > 'cordova-plugin-themeablebrowser'. I can do this manually by: > - opening xCode > - Click on Project -> Resources -> Image.xcassets > - Click '+' in the bottom task bar -> New Image Set > - Rename the new Set 'back' > - Manually drag and drop 3 images into xcode > To be clear - I'm not asking that cordova produce different sized images as I > believe that's out of scope. I just need it to build the new resource in > xcode referencing certain files on disk with tags like: > {code} > > > > > > {code} > * Example plugins: > https://github.com/arnesson/cordova-plugin-firebase > https://github.codifferent m/phonegap/phonegap-plugin-push > https://github.com/initialxy/cordova-plugin-themeablebrowser > **Bonus!** > It'd be extra great, since I'm sure some folks want this, if cordova could > add sound files to be used by firebase/push plugins that can leverage those > if they exist, but I'm not sure how those get set up in xcode such that > phonegap-plugin-push can use them. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12821) [SDK DEV] can't copy *.framework to project
[ https://issues.apache.org/jira/browse/CB-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12821: -- Summary: [SDK DEV] can't copy *.framework to project (was: [SDK DEV] cann't copy *.framework to project) > [SDK DEV] can't copy *.framework to project > --- > > Key: CB-12821 > URL: https://issues.apache.org/jira/browse/CB-12821 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: 7.0.2 > Environment: mac 10.11.6 >Reporter: sanbo > Fix For: cordova-ios@4.4.1 > > > copy *.framework to project by plugin.xml . -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12821) [SDK DEV] cann't copy *.framework to project
[ https://issues.apache.org/jira/browse/CB-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035756#comment-16035756 ] Shazron Abdullah commented on CB-12821: --- We need to clarify docs for this, and test it out: {code} {code} > [SDK DEV] cann't copy *.framework to project > > > Key: CB-12821 > URL: https://issues.apache.org/jira/browse/CB-12821 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: 7.0.2 > Environment: mac 10.11.6 >Reporter: sanbo > Fix For: cordova-ios@4.4.1 > > > copy *.framework to project by plugin.xml . -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12821) [SDK DEV] cann't copy *.framework to project
[ https://issues.apache.org/jira/browse/CB-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12821: -- Fix Version/s: cordova-ios@4.4.1 > [SDK DEV] cann't copy *.framework to project > > > Key: CB-12821 > URL: https://issues.apache.org/jira/browse/CB-12821 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: 7.0.2 > Environment: mac 10.11.6 >Reporter: sanbo > Fix For: cordova-ios@4.4.1 > > > copy *.framework to project by plugin.xml . -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12821) [SDK DEV] cann't copy *.framework to project
[ https://issues.apache.org/jira/browse/CB-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035755#comment-16035755 ] Shazron Abdullah commented on CB-12821: --- Try using the tag, "custom" attribute: https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#framework > [SDK DEV] cann't copy *.framework to project > > > Key: CB-12821 > URL: https://issues.apache.org/jira/browse/CB-12821 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: 7.0.2 > Environment: mac 10.11.6 >Reporter: sanbo > > copy *.framework to project by plugin.xml . -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-12821) [SDK DEV] cann't copy *.framework to project
[ https://issues.apache.org/jira/browse/CB-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011884#comment-16011884 ] Shazron Abdullah edited comment on CB-12821 at 6/3/17 1:49 AM: --- hello: the problem is ,can copy *.framework to project , but the framework file is invalid. my plugin.xml: {code} http://apache.org/cordova/ns/plugins/1.0"; xmlns:android="http://schemas.android.com/apk/res/android"; id="Umeng" version="3.0.0"> Umeng {code} was (Author: sanbo): hello: the problem is ,can copy *.framework to project , but the framework file is invalid. my plugin.xml: http://apache.org/cordova/ns/plugins/1.0"; xmlns:android="http://schemas.android.com/apk/res/android"; id="Umeng" version="3.0.0"> Umeng > [SDK DEV] cann't copy *.framework to project > > > Key: CB-12821 > URL: https://issues.apache.org/jira/browse/CB-12821 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: 7.0.2 > Environment: mac 10.11.6 >Reporter: sanbo > > copy *.framework to project by plugin.xml . -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12821) [SDK DEV] cann't copy *.framework to project
[ https://issues.apache.org/jira/browse/CB-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12821: -- Priority: Major (was: Blocker) > [SDK DEV] cann't copy *.framework to project > > > Key: CB-12821 > URL: https://issues.apache.org/jira/browse/CB-12821 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: 7.0.2 > Environment: mac 10.11.6 >Reporter: sanbo > > copy *.framework to project by plugin.xml . -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12821) [SDK DEV] cann't copy *.framework to project
[ https://issues.apache.org/jira/browse/CB-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12821: -- Security: (was: Non-Public) > [SDK DEV] cann't copy *.framework to project > > > Key: CB-12821 > URL: https://issues.apache.org/jira/browse/CB-12821 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: 7.0.2 > Environment: mac 10.11.6 >Reporter: sanbo >Priority: Blocker > > copy *.framework to project by plugin.xml . -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-12830) cordova emulate ios with --target throws undefined error
[ https://issues.apache.org/jira/browse/CB-12830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035751#comment-16035751 ] Shazron Abdullah edited comment on CB-12830 at 6/3/17 1:42 AM: --- I repro'ed your issue and error. Here's what the empty lines show: {code} No scripts found for hook "before_emulate". No scripts found for hook "before_prepare". Checking config.xml and package.json for saved platforms that haven't been added to the project Config.xml and package.json platforms are the same. No pkg.json modification. Package.json and config.xml platforms are different. Updating config.xml with most current list of platforms. PlatformApi successfully found for platform ios Checking config.xml for saved plugins that haven't been added to the project Checking for any plugins added to the project that have not been installed in ios platform No differences found between plugins added to project and installed in ios platform. Continuing... Generating platform-specific config.xml from defaults for iOS at /Users/shazron/Desktop/foo/platforms/ios/HelloCordova/config.xml Merging project's config.xml into platform-specific iOS config.xml Merging and updating files from [www, platforms/ios/platform_www] to platforms/ios/www Current launch storyboard undefined Not changing launch storyboard setting in info plist. Wrote out iOS Bundle Identifier "io.cordova.hellocordova" and iOS Bundle Version "1.0.0" to /Users/shazron/Desktop/foo/platforms/ios/HelloCordova/HelloCordova-Info.plist No need to update build settings for launch storyboard support. iOS Product Name has not changed (still "HelloCordova") This app does not have icons defined This app does not have splash screens defined Updating launch storyboard images at platforms/ios/HelloCordova/Images.xcassets/LaunchStoryboard.imageset/ Updating Storyboard image set contents.json This app does not have additional resource files defined Prepared iOS project successfully No scripts found for hook "after_prepare". {code} was (Author: shazron): I repro'ed your issue. Here's what the empty lines show: {code} No scripts found for hook "before_emulate". No scripts found for hook "before_prepare". Checking config.xml and package.json for saved platforms that haven't been added to the project Config.xml and package.json platforms are the same. No pkg.json modification. Package.json and config.xml platforms are different. Updating config.xml with most current list of platforms. PlatformApi successfully found for platform ios Checking config.xml for saved plugins that haven't been added to the project Checking for any plugins added to the project that have not been installed in ios platform No differences found between plugins added to project and installed in ios platform. Continuing... Generating platform-specific config.xml from defaults for iOS at /Users/shazron/Desktop/foo/platforms/ios/HelloCordova/config.xml Merging project's config.xml into platform-specific iOS config.xml Merging and updating files from [www, platforms/ios/platform_www] to platforms/ios/www Current launch storyboard undefined Not changing launch storyboard setting in info plist. Wrote out iOS Bundle Identifier "io.cordova.hellocordova" and iOS Bundle Version "1.0.0" to /Users/shazron/Desktop/foo/platforms/ios/HelloCordova/HelloCordova-Info.plist No need to update build settings for launch storyboard support. iOS Product Name has not changed (still "HelloCordova") This app does not have icons defined This app does not have splash screens defined Updating launch storyboard images at platforms/ios/HelloCordova/Images.xcassets/LaunchStoryboard.imageset/ Updating Storyboard image set contents.json This app does not have additional resource files defined Prepared iOS project successfully No scripts found for hook "after_prepare". {code} > cordova emulate ios with --target throws undefined error > > > Key: CB-12830 > URL: https://issues.apache.org/jira/browse/CB-12830 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: 7.0.0 > Environment: MacBook Pro (Retina, 15-inch, Mid 2015) > macOS 10.12.5 > nodejs version v7.9.0 > cordova version 7.0.1 > Installed platforms: > android 6.2.3 > ios 4.4.0 > Available platforms: > blackberry10 ~3.8.0 (deprecated) > browser ~4.1.0 > osx ~4.0.1 > webos ~3.7.0 >Reporter: Michal Cwienczek >Priority: Minor > Labels: ios > Fix For: cordova-ios@4.4.1 > > > This image best describes what happens: > https://pasteboard.co/7GV5viPww.png > {code} > $ cordova emulate ios --target="iPhone-6s-Plus, 9.3" --verbose > [bunch of empty lines that are probably the same as the background color] > Error: Cannot read property 'name' of undefine
[jira] [Updated] (CB-12830) cordova emulate ios with --target throws undefined error
[ https://issues.apache.org/jira/browse/CB-12830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12830: -- Fix Version/s: cordova-ios@4.4.1 > cordova emulate ios with --target throws undefined error > > > Key: CB-12830 > URL: https://issues.apache.org/jira/browse/CB-12830 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: 7.0.0 > Environment: MacBook Pro (Retina, 15-inch, Mid 2015) > macOS 10.12.5 > nodejs version v7.9.0 > cordova version 7.0.1 > Installed platforms: > android 6.2.3 > ios 4.4.0 > Available platforms: > blackberry10 ~3.8.0 (deprecated) > browser ~4.1.0 > osx ~4.0.1 > webos ~3.7.0 >Reporter: Michal Cwienczek >Priority: Minor > Labels: ios > Fix For: cordova-ios@4.4.1 > > > This image best describes what happens: > https://pasteboard.co/7GV5viPww.png > {code} > $ cordova emulate ios --target="iPhone-6s-Plus, 9.3" --verbose > [bunch of empty lines that are probably the same as the background color] > Error: Cannot read property 'name' of undefined > {code} > So there are 2 issues: > 1. Verbose output is empty > 2. at the end cordova throws undefined error > MacBook Pro (Retina, 15-inch, Mid 2015) > macOS 10.12.5 > nodejs version v7.9.0 > cordova version 7.0.1 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12830) cordova emulate ios with --target throws undefined error
[ https://issues.apache.org/jira/browse/CB-12830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035751#comment-16035751 ] Shazron Abdullah commented on CB-12830: --- I repro'ed your issue. Here's what the empty lines show: {code} No scripts found for hook "before_emulate". No scripts found for hook "before_prepare". Checking config.xml and package.json for saved platforms that haven't been added to the project Config.xml and package.json platforms are the same. No pkg.json modification. Package.json and config.xml platforms are different. Updating config.xml with most current list of platforms. PlatformApi successfully found for platform ios Checking config.xml for saved plugins that haven't been added to the project Checking for any plugins added to the project that have not been installed in ios platform No differences found between plugins added to project and installed in ios platform. Continuing... Generating platform-specific config.xml from defaults for iOS at /Users/shazron/Desktop/foo/platforms/ios/HelloCordova/config.xml Merging project's config.xml into platform-specific iOS config.xml Merging and updating files from [www, platforms/ios/platform_www] to platforms/ios/www Current launch storyboard undefined Not changing launch storyboard setting in info plist. Wrote out iOS Bundle Identifier "io.cordova.hellocordova" and iOS Bundle Version "1.0.0" to /Users/shazron/Desktop/foo/platforms/ios/HelloCordova/HelloCordova-Info.plist No need to update build settings for launch storyboard support. iOS Product Name has not changed (still "HelloCordova") This app does not have icons defined This app does not have splash screens defined Updating launch storyboard images at platforms/ios/HelloCordova/Images.xcassets/LaunchStoryboard.imageset/ Updating Storyboard image set contents.json This app does not have additional resource files defined Prepared iOS project successfully No scripts found for hook "after_prepare". {code} > cordova emulate ios with --target throws undefined error > > > Key: CB-12830 > URL: https://issues.apache.org/jira/browse/CB-12830 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: 7.0.0 > Environment: MacBook Pro (Retina, 15-inch, Mid 2015) > macOS 10.12.5 > nodejs version v7.9.0 > cordova version 7.0.1 > Installed platforms: > android 6.2.3 > ios 4.4.0 > Available platforms: > blackberry10 ~3.8.0 (deprecated) > browser ~4.1.0 > osx ~4.0.1 > webos ~3.7.0 >Reporter: Michal Cwienczek >Priority: Minor > Labels: ios > > This image best describes what happens: > https://pasteboard.co/7GV5viPww.png > {code} > $ cordova emulate ios --target="iPhone-6s-Plus, 9.3" --verbose > [bunch of empty lines that are probably the same as the background color] > Error: Cannot read property 'name' of undefined > {code} > So there are 2 issues: > 1. Verbose output is empty > 2. at the end cordova throws undefined error > MacBook Pro (Retina, 15-inch, Mid 2015) > macOS 10.12.5 > nodejs version v7.9.0 > cordova version 7.0.1 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12830) cordova emulate ios with --target throws undefined error
[ https://issues.apache.org/jira/browse/CB-12830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035749#comment-16035749 ] Shazron Abdullah commented on CB-12830: --- The verbose lines are probably there, but the same color as your terminal background (I know cos it has happened to me). > cordova emulate ios with --target throws undefined error > > > Key: CB-12830 > URL: https://issues.apache.org/jira/browse/CB-12830 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: 7.0.0 > Environment: MacBook Pro (Retina, 15-inch, Mid 2015) > macOS 10.12.5 > nodejs version v7.9.0 > cordova version 7.0.1 > Installed platforms: > android 6.2.3 > ios 4.4.0 > Available platforms: > blackberry10 ~3.8.0 (deprecated) > browser ~4.1.0 > osx ~4.0.1 > webos ~3.7.0 >Reporter: Michal Cwienczek >Priority: Minor > Labels: ios > > This image best describes what happens: > https://pasteboard.co/7GV5viPww.png > {code} > $ cordova emulate ios --target="iPhone-6s-Plus, 9.3" --verbose > [bunch of empty lines that are probably the same as the background color] > Error: Cannot read property 'name' of undefined > {code} > So there are 2 issues: > 1. Verbose output is empty > 2. at the end cordova throws undefined error > MacBook Pro (Retina, 15-inch, Mid 2015) > macOS 10.12.5 > nodejs version v7.9.0 > cordova version 7.0.1 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12830) cordova emulate ios with --target throws undefined error
[ https://issues.apache.org/jira/browse/CB-12830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12830: -- Description: This image best describes what happens: https://pasteboard.co/7GV5viPww.png {code} $ cordova emulate ios --target="iPhone-6s-Plus, 9.3" --verbose [bunch of empty lines that are probably the same as the background color] Error: Cannot read property 'name' of undefined {code} So there are 2 issues: 1. Verbose output is empty 2. at the end cordova throws undefined error MacBook Pro (Retina, 15-inch, Mid 2015) macOS 10.12.5 nodejs version v7.9.0 cordova version 7.0.1 was: This image best describes what happens: https://pasteboard.co/7GV5viPww.png So there are 2 issues: 1. Verbose output is empty 2. at the end cordova throws undefined error MacBook Pro (Retina, 15-inch, Mid 2015) macOS 10.12.5 nodejs version v7.9.0 cordova version 7.0.1 > cordova emulate ios with --target throws undefined error > > > Key: CB-12830 > URL: https://issues.apache.org/jira/browse/CB-12830 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: 7.0.0 > Environment: MacBook Pro (Retina, 15-inch, Mid 2015) > macOS 10.12.5 > nodejs version v7.9.0 > cordova version 7.0.1 > Installed platforms: > android 6.2.3 > ios 4.4.0 > Available platforms: > blackberry10 ~3.8.0 (deprecated) > browser ~4.1.0 > osx ~4.0.1 > webos ~3.7.0 >Reporter: Michal Cwienczek >Priority: Minor > Labels: ios > > This image best describes what happens: > https://pasteboard.co/7GV5viPww.png > {code} > $ cordova emulate ios --target="iPhone-6s-Plus, 9.3" --verbose > [bunch of empty lines that are probably the same as the background color] > Error: Cannot read property 'name' of undefined > {code} > So there are 2 issues: > 1. Verbose output is empty > 2. at the end cordova throws undefined error > MacBook Pro (Retina, 15-inch, Mid 2015) > macOS 10.12.5 > nodejs version v7.9.0 > cordova version 7.0.1 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12703) Push Notification not working via cordova cli
[ https://issues.apache.org/jira/browse/CB-12703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12703: -- Fix Version/s: cordova-ios@4.4.1 > Push Notification not working via cordova cli > - > > Key: CB-12703 > URL: https://issues.apache.org/jira/browse/CB-12703 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-ios >Affects Versions: 6.5.0 > Environment: iPhone >Reporter: Hiren >Priority: Minor > Fix For: cordova-ios@4.4.1 > > > Facing an issue when creating an iOS build with the below command. > {noformat} > cordova build ios --release --device --buildConfig > {noformat} > When generating the build with the above command the ipa gets created > successfully and user is also able to install and use the app. But we do not > get any push notifications. We are using Firebase to manage our push > notification and sending it from firebase console. Here i can see that the > app generates a devices token but sending a notification on this token does > not trigger any message on the mobile. > But notification works when we create a build using Xcode. We generate the > build by first running, > {noformat} > cordova prepare ios > {noformat} > Then using the Archive option from Product menu in Xcode. > I believe that the APN entitle file is not getting set to production. We are > creating an app using enterprise certificate. > This is creating an issue when running Jenkins CI. My build gets created but > I loose the push notification functionality. Hence i have to release ios > builds manually from my system. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12822) Bug when create an virtual table with fts3 option in the Websql database on UiWebview
[ https://issues.apache.org/jira/browse/CB-12822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12822: -- Priority: Major (was: Blocker) Component/s: (was: cordova-js) > Bug when create an virtual table with fts3 option in the Websql database on > UiWebview > -- > > Key: CB-12822 > URL: https://issues.apache.org/jira/browse/CB-12822 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.3.1 > Environment: UIWebview Websql database >Reporter: David Saillard > Labels: performance > > Hello, > I develop software with cordova, since 6 years, and actually use the > UiWebview with the Websql database because he WkWebview don't use this. > When I execute an transaction for create a virtual table with the option > fts3. The query return an error and the table is not create. > When I dont' use the option fts3 for create an normal table, it's OK. I have > success operation. > This Problem doesn't exist on iOS 10.3.1 and before. > Steps to Reproduce: > CREATE VIRTUAL TABLE IF NOT EXISTS param USING fts3 ( soc_code VARCHAR(5), > prm_table VARCHAR(50), prm_coderec VARCHAR(50), prm_lbl VARCHAR(70), > prm_comment VARCHAR(200), prm_actif VARCHAR(1), prm_value VARCHAR(50), > prm_order INTEGER, INDEX_PAGINATION INTEGER ) "; > Version: > iOS 10.3.2 beta5 > Notes: > I can use in my application Virtual table previously create before upgrade on > iOS 10.3.2 beta5. That mean that it's supported, only the creat doesn't run. > Configuration: > ipad air2 64go -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12822) Bug when create an virtual table with fts3 option in the Websql database on UiWebview
[ https://issues.apache.org/jira/browse/CB-12822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035747#comment-16035747 ] Shazron Abdullah commented on CB-12822: --- This is a Webkit2 issue and should be filed with bugs.webkit.org, not Cordova. We don't control the internals of WebSQL. > Bug when create an virtual table with fts3 option in the Websql database on > UiWebview > -- > > Key: CB-12822 > URL: https://issues.apache.org/jira/browse/CB-12822 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.3.1 > Environment: UIWebview Websql database >Reporter: David Saillard > Labels: performance > > Hello, > I develop software with cordova, since 6 years, and actually use the > UiWebview with the Websql database because he WkWebview don't use this. > When I execute an transaction for create a virtual table with the option > fts3. The query return an error and the table is not create. > When I dont' use the option fts3 for create an normal table, it's OK. I have > success operation. > This Problem doesn't exist on iOS 10.3.1 and before. > Steps to Reproduce: > CREATE VIRTUAL TABLE IF NOT EXISTS param USING fts3 ( soc_code VARCHAR(5), > prm_table VARCHAR(50), prm_coderec VARCHAR(50), prm_lbl VARCHAR(70), > prm_comment VARCHAR(200), prm_actif VARCHAR(1), prm_value VARCHAR(50), > prm_order INTEGER, INDEX_PAGINATION INTEGER ) "; > Version: > iOS 10.3.2 beta5 > Notes: > I can use in my application Virtual table previously create before upgrade on > iOS 10.3.2 beta5. That mean that it's supported, only the creat doesn't run. > Configuration: > ipad air2 64go -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-12822) Bug when create an virtual table with fts3 option in the Websql database on UiWebview
[ https://issues.apache.org/jira/browse/CB-12822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015797#comment-16015797 ] Shazron Abdullah edited comment on CB-12822 at 6/3/17 1:35 AM: --- Find here an simple source code I use Jquerymobile 1.4.5 et jquery for develop mobile Webapp {code} var db; var deviceReadyDeferred = $.Deferred(); var useConsoleLog = true; $(document).ready(function() { document.addEventListener("deviceready", function() { deviceReadyDeferred.resolve(); }, false); }); $.when(deviceReadyDeferred ).then(function () { var dbshortName = 'NegosApp'; var dbversion = '1.0'; var dbdisplayName = 'Base Negos App'; var dbmaxSize = 5000; // in bytes try { if (!window.openDatabase) { alert('windows open Database non supported'); } else { db = window.openDatabase(dbshortName, dbversion, dbdisplayName, dbmaxSize); } } catch(e) { // Error handling code goes here. if (e == 2) { alert("Invalid database version."); } else if (e == 4) { alert("Limite de Stockage dépassée "+e+"."); } else { alert("Erreur inconnue "+e+"."); } } createLocalTables(); }); //Création des tables locales function createLocalTables() { db.transaction(function(tx) { //parametre tx.executeSql("CREATE TABLE IF NOT EXISTS parametre( CODE_SOCIETE VARCHAR(4), ETABLISSEMENT VARCHAR(4), SITE VARCHAR(4), NOM_SOCIETE VARCHAR(30), CODE_VRP VARCHAR(4), NUMERO_TEL_TRANSMISSION VARCHAR(30), POSSIBLE_PRIX_SAISIE VARCHAR(1), POSSIBLE_CHANGE_CODE_TARIF VARCHAR(1), POSSIBLE_PRIX_GRATUIT VARCHAR(1), POSSIBLE_SAISIE_UNITE VARCHAR(1), TARIF_UNITE VARCHAR(1), QTE_UNITE VARCHAR(1), NUMERO_VEHICULE VARCHAR(20), NIVEAU_STAT_EQUIPE VARCHAR(3), NIVEAU_STAT_REGION VARCHAR(3), NIVEAU_STAT_NATIONALE VARCHAR(3), CALCUL_MARGE VARCHAR(1), PALLIER_MARGE VARCHAR(5), COEFF_MODIF_MARGE VARCHAR(5), POSSIBLE_REMISE_ENTETE VARCHAR(1), POSSIBLE_REMISE_LIGNE VARCHAR(1), TYPE_CODE_CLIENT VARCHAR(1), TYPE_CODE_ARTICLE VARCHAR(1), LONG_CODE_CLIENT VARCHAR(2), LONG_CODE_ARTICLE VARCHAR(2), MAXI_QTE_ALERTE VARCHAR(5), MINI_COMMANDE VARCHAR(5), LIBRE1 VARCHAR(10), LIBRE2 VARCHAR(10), LIBRE3 VARCHAR(10))", [], function(tx, result) {if ( useConsoleLog ) console.log(result);}, function(tx, error) {if ( useConsoleLog ) console.log(error);}); //Référencement tx.executeSql("CREATE VIRTUAL TABLE IF NOT EXISTS referencement USING fts3 ( soc_code, Class_Subclass, Enseigne, Typo, Code_interne, Designation , Code_en_magasin, INDEX_PAGINATION)", [], function(tx, result) {if ( useConsoleLog ) console.log(result);}, function(tx, error) {if ( useConsoleLog ) console.log(error.message);}); }); } {code} was (Author: dsaillard): Find here an simple source code I use Jquerymobile 1.4.5 et jquery for develop mobile Webapp var db; var deviceReadyDeferred = $.Deferred(); var useConsoleLog = true; $(document).ready(function() { document.addEventListener("deviceready", function() { deviceReadyDeferred.resolve(); }, false); }); $.when(deviceReadyDeferred ).then(function () { var dbshortName = 'NegosApp'; var dbversion = '1.0'; var dbdisplayName = 'Base Negos App'; var dbmaxSize = 5000; // in bytes try { if (!window.openDatabase) { alert('windows open Database non supported'); } else { db = window.openDatabase(dbshortName, dbversion, dbdisplayName, dbmaxSize); } } catch(e) { // Error handling code goes here. if (e == 2) { alert("Invalid database version."); } else if (e == 4) { alert("Limite de Stockage dépassée "+e+"."); } else { alert("Erreur inconnue "+e+"."); } } createLocalTables(); }); //Création des tables locales function createLocalTables() { db.transaction(functio
[jira] [Updated] (CB-12824) cordova-plugin-media - Pausing and playing streaming audio plays incorrect audio.
[ https://issues.apache.org/jira/browse/CB-12824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12824: -- Environment: iOS Labels: (was: cordova-plugin-media) Priority: Major (was: Blocker) Component/s: (was: cordova-ios) cordova-plugin-media > cordova-plugin-media - Pausing and playing streaming audio plays incorrect > audio. > - > > Key: CB-12824 > URL: https://issues.apache.org/jira/browse/CB-12824 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Affects Versions: 6.3.1 > Environment: iOS >Reporter: Justin de Leon > > Let's say I have two instances of Medias - a & b. > (Media object instances are created on press of play) > I pressed play on track a. Track a plays. I press pause on track a. > I pressed play on track b. Track b plays. I press pause on track b. > When I press play on track a again, track b resumes. I checked the media > object of track A, and its duration and position is the one from track b. > I did not have this issue when using the cordova-media-plugin version 1.0.1. > I suppose that the bug appeared after adding support for background > threading. Note that this only happens for streamed audio. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12456) run ios --emulator does not copy keychain sharing ios / capabilities / entitlements
[ https://issues.apache.org/jira/browse/CB-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12456: -- Fix Version/s: cordova-ios@4.4.1 > run ios --emulator does not copy keychain sharing ios / capabilities / > entitlements > --- > > Key: CB-12456 > URL: https://issues.apache.org/jira/browse/CB-12456 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-ios >Affects Versions: 6.5.0 > Environment: Mac OS X. xcode 8.2.1. Cordova IOS 4.3.1 >Reporter: Erlend Ellingsen > Labels: build > Fix For: cordova-ios@4.4.1 > > > When setting up capabilities in xcode, the capabilites works on both devices > and emulators/simulators when running from xcode. > When running "cordova run ios --emulator" from the cordova cli, the "keychain > sharing" capability is not working on the emulator, however it does on device. > When running from xcode it both works on the device and the emulator. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-12846) WebView JS execution continues when app executes in background
[ https://issues.apache.org/jira/browse/CB-12846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035745#comment-16035745 ] Shazron Abdullah edited comment on CB-12846 at 6/3/17 1:32 AM: --- The core itself does not continue executing endlessly (there is no event polling) - it is triggered to pull in commands by JavaScript sending a gap:// url when a command is sent back. There is one timer here that gets cleared: https://github.com/apache/cordova-ios/blob/master/CordovaLib/cordova.js#L1016-L1031 I couldn't possibly repro this exactly - You could try profiling your app in Safari Web Inspector to see what's going on. was (Author: shazron): The core itself does not continue executing endlessly (there is no event polling) - it is triggered to pull in commands by JavaScript sending a gap:// url. There is one timer here that gets cleared: https://github.com/apache/cordova-ios/blob/master/CordovaLib/cordova.js#L1016-L1031 I couldn't possibly repro this exactly - You could try profiling your app in Safari Web Inspector to see what's going on. > WebView JS execution continues when app executes in background > -- > > Key: CB-12846 > URL: https://issues.apache.org/jira/browse/CB-12846 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.3.1 >Reporter: Grant Patterson > > I'm using a [Cordova > plugin|https://github.com/happydenn/cordova-plugin-gimbal2] that integrates > [a third-party SDK|https://docs.gimbal.com/iosdocs/v2/devguide.html] to > listen for bluetooth beacon sighting events. As expected, my app is allowed > to run for 10 seconds in the background with the [bluetooth-central > UIBackgroundMode|https://developer.apple.com/library/content/documentation/iPhone/Conceptual/iPhoneOSProgrammingGuide/BackgroundExecution/BackgroundExecution.html]. > Once the necessary processing is completed, the JS event loop runs until the > 10-second window closes. Because beacon sightings happen as frequently as > several per second, the app runs in the background constantly, killing the > user's battery. I can setInterval() in JS with a 1000ms interval and it runs > successfully every time; my Angular app runs $digest cycles in the background > which are unnecessary and quite expensive. > I think I need a way for the native plugin code to relinquish execution and > return the app to the background. > StackOverflow: > [https://stackoverflow.com/questions/44145031/stopping-background-javascript-activity-on-location-triggered-bluetooth-central] -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12846) WebView JS execution continues when app executes in background
[ https://issues.apache.org/jira/browse/CB-12846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035745#comment-16035745 ] Shazron Abdullah commented on CB-12846: --- The core itself does not continue executing endlessly (there is no event polling) - it is triggered to pull in commands by JavaScript sending a gap:// url. There is one timer here that gets cleared: https://github.com/apache/cordova-ios/blob/master/CordovaLib/cordova.js#L1016-L1031 I couldn't possibly repro this exactly - You could try profiling your app in Safari Web Inspector to see what's going on. > WebView JS execution continues when app executes in background > -- > > Key: CB-12846 > URL: https://issues.apache.org/jira/browse/CB-12846 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.3.1 >Reporter: Grant Patterson > > I'm using a [Cordova > plugin|https://github.com/happydenn/cordova-plugin-gimbal2] that integrates > [a third-party SDK|https://docs.gimbal.com/iosdocs/v2/devguide.html] to > listen for bluetooth beacon sighting events. As expected, my app is allowed > to run for 10 seconds in the background with the [bluetooth-central > UIBackgroundMode|https://developer.apple.com/library/content/documentation/iPhone/Conceptual/iPhoneOSProgrammingGuide/BackgroundExecution/BackgroundExecution.html]. > Once the necessary processing is completed, the JS event loop runs until the > 10-second window closes. Because beacon sightings happen as frequently as > several per second, the app runs in the background constantly, killing the > user's battery. I can setInterval() in JS with a 1000ms interval and it runs > successfully every time; my Angular app runs $digest cycles in the background > which are unnecessary and quite expensive. > I think I need a way for the native plugin code to relinquish execution and > return the app to the background. > StackOverflow: > [https://stackoverflow.com/questions/44145031/stopping-background-javascript-activity-on-location-triggered-bluetooth-central] -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12122) Incompatible plugin should make the build fail, not be skipped silently
[ https://issues.apache.org/jira/browse/CB-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035721#comment-16035721 ] Shazron Abdullah commented on CB-12122: --- https://github.com/shazron/incompatible-cordova-plugin.git plugin should be used for testing. So far the consensus on the dev@ list is to make the build fail on an incompatible plugin. > Incompatible plugin should make the build fail, not be skipped silently > --- > > Key: CB-12122 > URL: https://issues.apache.org/jira/browse/CB-12122 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-plugman >Affects Versions: 6.3.0 >Reporter: 165537 > Labels: cordova-8.0.0 > > When compiling (on Phonegap Build) a project containing a plugin which > Cordova's version is incompatible, the plugin is silently skipped and the > build is successful. Of course the functionalities of the plugin won't work > in the app. Eg, here's what I got when compiling phonegap-plugin-push with > Cordova 6.3.0: > Fetching plugin "phonegap-plugin-push@1.9.0" via npm > Installing "phonegap-plugin-push" at "1.9.0" for android > Plugin doesn't support this project's cordova version. cordova: 6.3.2, failed > version requirement: >=6.4.0 > Skipping 'phonegap-plugin-push' for android -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12250) config-file plist entries not removed on plugin rm
[ https://issues.apache.org/jira/browse/CB-12250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035700#comment-16035700 ] ASF subversion and git services commented on CB-12250: -- Commit 64c1d61f4b6b68151ced1630b20fe0831c1c3c3c in cordova-lib's branch refs/heads/master from [~Nikita Matrosov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=64c1d61 ] CB-12250 CB-12409 iOS: Fix bug with escaping properties from plist file This closes #533 > config-file plist entries not removed on plugin rm > -- > > Key: CB-12250 > URL: https://issues.apache.org/jira/browse/CB-12250 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Sergey Shakhnazarov >Assignee: Nikita Matrosov > Labels: ios, triaged > > 1. {{cordova plugin add cordova-plugin-ms-adal@0.8.1}} > 2. {{cat platforms/ios/HelloCordova/HelloCordova-Info.plist}} > -> > {noformat} > ... > CFBundleURLTypes > > > CFBundleTypeRole > Editor > CFBundleURLName > $(CFBundleIdentifier) > CFBundleURLSchemes > > x-msauth-$(CFBundleIdentifier:rfc1034identifier) > > > {noformat} > 3. {{cordova plugin rm ms-adal}} > {{cat platforms/ios/HelloCordova/HelloCordova-Info.plist}} > -> CFBundleURLTypes not removed > 4. The array will be populated with another duplicating entry on next plugin > install. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12250) config-file plist entries not removed on plugin rm
[ https://issues.apache.org/jira/browse/CB-12250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035702#comment-16035702 ] ASF GitHub Bot commented on CB-12250: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/533 > config-file plist entries not removed on plugin rm > -- > > Key: CB-12250 > URL: https://issues.apache.org/jira/browse/CB-12250 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Sergey Shakhnazarov >Assignee: Nikita Matrosov > Labels: ios, triaged > > 1. {{cordova plugin add cordova-plugin-ms-adal@0.8.1}} > 2. {{cat platforms/ios/HelloCordova/HelloCordova-Info.plist}} > -> > {noformat} > ... > CFBundleURLTypes > > > CFBundleTypeRole > Editor > CFBundleURLName > $(CFBundleIdentifier) > CFBundleURLSchemes > > x-msauth-$(CFBundleIdentifier:rfc1034identifier) > > > {noformat} > 3. {{cordova plugin rm ms-adal}} > {{cat platforms/ios/HelloCordova/HelloCordova-Info.plist}} > -> CFBundleURLTypes not removed > 4. The array will be populated with another duplicating entry on next plugin > install. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12409) Plugman is unable to uninstall a plugin with a config preferences containing '*'
[ https://issues.apache.org/jira/browse/CB-12409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035701#comment-16035701 ] ASF subversion and git services commented on CB-12409: -- Commit 64c1d61f4b6b68151ced1630b20fe0831c1c3c3c in cordova-lib's branch refs/heads/master from [~Nikita Matrosov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=64c1d61 ] CB-12250 CB-12409 iOS: Fix bug with escaping properties from plist file This closes #533 > Plugman is unable to uninstall a plugin with a config preferences containing > '*' > > > Key: CB-12409 > URL: https://issues.apache.org/jira/browse/CB-12409 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugman >Affects Versions: 1.4.1 > Environment: OS: MacOS > $ plugman -version => 1.4.1 > $ cordova -version => 6.5.0 >Reporter: Kris Vandermast >Assignee: Nikita Matrosov >Priority: Minor > > A Cordova plugin we wrote uses a "group filter" which is injected into the > iOS app's plist file. The group filter can contain a "*" value, which is > default in the Plugin.xml > {code:title=Plugin.xml|borderStyle=solid} > > > ... > > > > > GroupFilters > $GROUP_FILTERS > > > {code} > The installation behaves as expected, and the group filter can actually be > found in the plist file. > {code} > $ plugman install --platform ios --project ./platforms/ios/ --plugin > --variable GROUP_FILTERS="*" > Installing "" for ios > {code} > It is only when you try to uninstall the plugin, that an error occurs. > {code} > $ uninstall --platform ios --plugin --project ./platforms/ios/ > Uninstalling from ios > Invalid regular expression: /^*$/: Nothing to repeat > {code} > Work-around: manually delete all the references from the Cordova project and > reinstall the plugin. > Escaping the variable when passing it as parameter seems to work. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12786) Improve logic for searching plugin id in case of module already exists in node_modules
[ https://issues.apache.org/jira/browse/CB-12786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035650#comment-16035650 ] ASF GitHub Bot commented on CB-12786: - Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/555#discussion_r119971709 --- Diff: cordova-fetch/index.js --- @@ -148,9 +148,15 @@ function trimID(target) { target = parts[1]; } -//If local path exists, set target to final directory +// If local path exists, try to get plugin id from package.json or set target to final directory if (fs.existsSync(target)) { -target = path.basename(target); +var pluginId, pkgJsonPath = path.join(target, 'package.json'); + +if (fs.existsSync(pkgJsonPath)) { +pluginId = JSON.parse(fs.readFileSync(pkgJsonPath)).cordova.id; --- End diff -- I think it was due to packageJson.name potentially being different then plugin.xml id field. But I don't know of any plugins with this and I'm not sure it makes sense to have that distinction anymore. > Improve logic for searching plugin id in case of module already exists in > node_modules > -- > > Key: CB-12786 > URL: https://issues.apache.org/jira/browse/CB-12786 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: 1.1.0 > Environment: cordova-7.0.2-dev >Reporter: Nikita Matrosov >Assignee: Nikita Matrosov > Labels: cordova-next > > Steps to reproduce > There is the issue with searching plugin id if the module already exists in > node_modules. > cordova create sample > cordova platform add android > cordova plugin add cordova-plugin-ms-adal > cordova plugin add ../azure-activedirectory-library-for-cordova (use local > folder) > Get error message: > Error: Failed to get absolute path to installed module > This error occurs since folder name in node_modules (cordova-plugin-ms-adal) > differs from base name of installation folder > (azure-activedirectory-library-for-cordova). > PR: https://github.com/apache/cordova-lib/pull/555 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3232) "cordova platform add blackberry" fails on 2.7.1-rc.1
[ https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035621#comment-16035621 ] ASF GitHub Bot commented on CB-3232: GitHub user rafael-chavez opened a pull request: https://github.com/apache/cordova-ios/pull/317 Add logging for malformed data ### Platforms affected iOS ### What does this PR do? Prints the malformed data created by the process for further debugging. ### What testing has been done on this change? Hard to reproduce, but sometimes the evaulateJavascript method on WKWebView creates a malformed JSON string. ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rafael-chavez/cordova-ios master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/317.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #317 commit e0a5c0e0bb71f582be8f30e08e23a06b09d00b08 Author: rafael-chavez Date: 2017-06-02T23:28:01Z Add logging for malformed data > "cordova platform add blackberry" fails on 2.7.1-rc.1 > - > > Key: CB-3232 > URL: https://issues.apache.org/jira/browse/CB-3232 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-blackberry (DEPRECATED), cordova-cli >Affects Versions: 2.7.0 >Reporter: Michael Brooks >Assignee: Michael Brooks > Fix For: 2.7.0 > > > The following error is thrown when running {{$ cordova platform add > blackberry}}: > {code} > [Error: An error occured during creation of blackberry sub-project. Creating > BlackBerry project... > Updating config.xml ... > sed: > /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml: > No such file or directory > Cleaning up ... > Remember to update the project.properties file inside your application > directory! > ] > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12762) Point package.json repo items to github mirrors
[ https://issues.apache.org/jira/browse/CB-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035584#comment-16035584 ] ASF GitHub Bot commented on CB-12762: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/560 > Point package.json repo items to github mirrors > --- > > Key: CB-12762 > URL: https://issues.apache.org/jira/browse/CB-12762 > Project: Apache Cordova > Issue Type: Bug > Components: AllComponents >Reporter: Jesse MacFadyen > > Proposal is here: > https://github.com/cordova/cordova-discuss/issues/67 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12762) Point package.json repo items to github mirrors
[ https://issues.apache.org/jira/browse/CB-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035583#comment-16035583 ] ASF subversion and git services commented on CB-12762: -- Commit 1b1e7400c2b4dfd27a6f0e8de52215bd59b85f06 in cordova-lib's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=1b1e740 ] CB-12762 : updated common, fetch, and serve pkgJson to point pkgJson repo items to github mirrors This closes #560 > Point package.json repo items to github mirrors > --- > > Key: CB-12762 > URL: https://issues.apache.org/jira/browse/CB-12762 > Project: Apache Cordova > Issue Type: Bug > Components: AllComponents >Reporter: Jesse MacFadyen > > Proposal is here: > https://github.com/cordova/cordova-discuss/issues/67 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12762) Point package.json repo items to github mirrors
[ https://issues.apache.org/jira/browse/CB-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035582#comment-16035582 ] ASF subversion and git services commented on CB-12762: -- Commit a74cc2b658e22fa08ec19ebf2399b1559971deb5 in cordova-lib's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=a74cc2b ] CB-12762 : point package.json repo items to github mirrors instead of apache repos site > Point package.json repo items to github mirrors > --- > > Key: CB-12762 > URL: https://issues.apache.org/jira/browse/CB-12762 > Project: Apache Cordova > Issue Type: Bug > Components: AllComponents >Reporter: Jesse MacFadyen > > Proposal is here: > https://github.com/cordova/cordova-discuss/issues/67 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12777) Remove unneeded fixtures from cordova-lib
[ https://issues.apache.org/jira/browse/CB-12777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035565#comment-16035565 ] ASF GitHub Bot commented on CB-12777: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/556 > Remove unneeded fixtures from cordova-lib > - > > Key: CB-12777 > URL: https://issues.apache.org/jira/browse/CB-12777 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > Labels: cordova-lib, cordova-next > Fix For: cordova7 > > > Remove unneeded fixtures from cordova-lib -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12777) Remove unneeded fixtures from cordova-lib
[ https://issues.apache.org/jira/browse/CB-12777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-12777. - Resolution: Fixed > Remove unneeded fixtures from cordova-lib > - > > Key: CB-12777 > URL: https://issues.apache.org/jira/browse/CB-12777 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > Labels: cordova-lib, cordova-next > Fix For: cordova7 > > > Remove unneeded fixtures from cordova-lib -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12777) Remove unneeded fixtures from cordova-lib
[ https://issues.apache.org/jira/browse/CB-12777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-12777: Labels: cordova-lib cordova-next (was: cordova-lib cordova7) > Remove unneeded fixtures from cordova-lib > - > > Key: CB-12777 > URL: https://issues.apache.org/jira/browse/CB-12777 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > Labels: cordova-lib, cordova-next > Fix For: cordova7 > > > Remove unneeded fixtures from cordova-lib -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12777) Remove unneeded fixtures from cordova-lib
[ https://issues.apache.org/jira/browse/CB-12777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035568#comment-16035568 ] ASF subversion and git services commented on CB-12777: -- Commit b9f091ca6bd4371cf57d4720633979c20eaa92ba in cordova-lib's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=b9f091c ] CB-12777 : removed android, ios, and windows projects fixtures This closes #556 > Remove unneeded fixtures from cordova-lib > - > > Key: CB-12777 > URL: https://issues.apache.org/jira/browse/CB-12777 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > Labels: cordova-lib, cordova-next > Fix For: cordova7 > > > Remove unneeded fixtures from cordova-lib -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12777) Remove unneeded fixtures from cordova-lib
[ https://issues.apache.org/jira/browse/CB-12777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035566#comment-16035566 ] ASF subversion and git services commented on CB-12777: -- Commit e069503c0ffd0746dd0c79e2742c1b70bac36715 in cordova-lib's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=e069503 ] CB-12777 : removed android-lib > Remove unneeded fixtures from cordova-lib > - > > Key: CB-12777 > URL: https://issues.apache.org/jira/browse/CB-12777 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > Labels: cordova-lib, cordova-next > Fix For: cordova7 > > > Remove unneeded fixtures from cordova-lib -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12777) Remove unneeded fixtures from cordova-lib
[ https://issues.apache.org/jira/browse/CB-12777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035563#comment-16035563 ] ASF subversion and git services commented on CB-12777: -- Commit c79dd238425f89a33ddf11f2c32642a6d9921437 in cordova-lib's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=c79dd23 ] CB-12777 : removed android one and android two and no perms fixtures > Remove unneeded fixtures from cordova-lib > - > > Key: CB-12777 > URL: https://issues.apache.org/jira/browse/CB-12777 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > Labels: cordova-lib, cordova-next > Fix For: cordova7 > > > Remove unneeded fixtures from cordova-lib -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12777) Remove unneeded fixtures from cordova-lib
[ https://issues.apache.org/jira/browse/CB-12777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035560#comment-16035560 ] ASF subversion and git services commented on CB-12777: -- Commit 3c69f3b580887fbe2eb6c15d54a2d6f9996c4492 in cordova-lib's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=3c69f3b ] CB-12777 : removed android_uninstall fixtures > Remove unneeded fixtures from cordova-lib > - > > Key: CB-12777 > URL: https://issues.apache.org/jira/browse/CB-12777 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > Labels: cordova-lib, cordova7 > Fix For: cordova7 > > > Remove unneeded fixtures from cordova-lib -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12777) Remove unneeded fixtures from cordova-lib
[ https://issues.apache.org/jira/browse/CB-12777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035561#comment-16035561 ] ASF subversion and git services commented on CB-12777: -- Commit 75e5e048ed2056b61cf6a02200fbd50557a2b4b8 in cordova-lib's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=75e5e04 ] CB-12777 : removed android_install fixtures > Remove unneeded fixtures from cordova-lib > - > > Key: CB-12777 > URL: https://issues.apache.org/jira/browse/CB-12777 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > Labels: cordova-lib, cordova7 > Fix For: cordova7 > > > Remove unneeded fixtures from cordova-lib -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12762) Point package.json repo items to github mirrors
[ https://issues.apache.org/jira/browse/CB-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035536#comment-16035536 ] ASF GitHub Bot commented on CB-12762: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/560 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/560?src=pr&el=h1) Report > Merging [#560](https://codecov.io/gh/apache/cordova-lib/pull/560?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/546612060bdab16ea88ed3a6e3ee8c1f29ffab3d?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/560/graphs/tree.svg?width=650&src=pr&token=KwBjKMXLqA&height=150)](https://codecov.io/gh/apache/cordova-lib/pull/560?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #560 +/- ## === Coverage 80.13% 80.13% === Files 57 57 Lines3956 3956 Branches 831 831 === Hits 3170 3170 Misses786 786 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/560?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/560?src=pr&el=footer). Last update [5466120...6428dd3](https://codecov.io/gh/apache/cordova-lib/pull/560?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > Point package.json repo items to github mirrors > --- > > Key: CB-12762 > URL: https://issues.apache.org/jira/browse/CB-12762 > Project: Apache Cordova > Issue Type: Bug > Components: AllComponents >Reporter: Jesse MacFadyen > > Proposal is here: > https://github.com/cordova/cordova-discuss/issues/67 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3232) "cordova platform add blackberry" fails on 2.7.1-rc.1
[ https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035513#comment-16035513 ] ASF GitHub Bot commented on CB-3232: Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/559 > "cordova platform add blackberry" fails on 2.7.1-rc.1 > - > > Key: CB-3232 > URL: https://issues.apache.org/jira/browse/CB-3232 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-blackberry (DEPRECATED), cordova-cli >Affects Versions: 2.7.0 >Reporter: Michael Brooks >Assignee: Michael Brooks > Fix For: 2.7.0 > > > The following error is thrown when running {{$ cordova platform add > blackberry}}: > {code} > [Error: An error occured during creation of blackberry sub-project. Creating > BlackBerry project... > Updating config.xml ... > sed: > /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml: > No such file or directory > Cleaning up ... > Remember to update the project.properties file inside your application > directory! > ] > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12839) Cordova FileTansfer fails with error code 2 when uploading on Windows 10
[ https://issues.apache.org/jira/browse/CB-12839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035497#comment-16035497 ] Brian Watts commented on CB-12839: -- Nikita I'm not sure what you mean by adding device capability -- We are talking about Windows 10 -- correct? The OS asks you for permission when you try to use the mic -- not sure exactly what you are referring to. And I also was able to record audio without any permissions issues on both Windows 8.1 and 10 -- with the resulting audio file being created. Anyway -- that is not the problem I am facing. When I upload *any* file on Windows 8.1, I have no problem. When I use the exact same code and solution to try to upload on a Windows 10 OS, I get error code 2. Yes -- I definitely do not get any information in the error callback. >Does this error reproduce if you run application w/o VS2015? I'm not sure what you mean by this -- as far as I know, I don't have an alternative way of building Windows 10 applications... Cordova command line does not have the needed Windows 10 options. Maybe I'm missing something. > Cordova FileTansfer fails with error code 2 when uploading on Windows 10 > > > Key: CB-12839 > URL: https://issues.apache.org/jira/browse/CB-12839 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file-transfer >Affects Versions: cordova@7.0.0 > Environment: Windows 10 with Visual Studio 2015 >Reporter: Brian Watts >Priority: Blocker > Labels: windows > Attachments: test2.zip > > > I've been stuck on this for days. I am pretty sure that it is a bug as I > have tried every possible combination of options in the upload call. > Furthermore, the same code works for iOS, Android, Windows Phone 8.1, Windows > Phone 10 and Windows Desktop 8.1. Windows Desktop 10 always fails with error > code 2 (syntax error). I have also made tests with a minimal application > that just tests the upload function (plus a small portion that creates the > file to upload). > {code} > function upload_file() { > var options = new FileUploadOptions(); > options.fileKey = "upfile"; > options.mimeType = 'm4a'; > var src = "ms-appdata:///temp/myalert.m4a"; > var ft = new FileTransfer(); > options.fileName = "myalert.m4a"; > options.chunkedMode = false; > var server_name = "http://hp3.xpub.io";; > ft.upload(src,server_name + "/alerts/upfile.php", upload_success, > upload_fail, options); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12762) Point package.json repo items to github mirrors
[ https://issues.apache.org/jira/browse/CB-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035472#comment-16035472 ] ASF GitHub Bot commented on CB-12762: - Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/560 @audreyso can you update the package.json in cordova-fetch, cordova-common and cordova-serve as well for this pr? > Point package.json repo items to github mirrors > --- > > Key: CB-12762 > URL: https://issues.apache.org/jira/browse/CB-12762 > Project: Apache Cordova > Issue Type: Bug > Components: AllComponents >Reporter: Jesse MacFadyen > > Proposal is here: > https://github.com/cordova/cordova-discuss/issues/67 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12787) cordova@7 plugin add --link is broken
[ https://issues.apache.org/jira/browse/CB-12787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-12787. - Resolution: Fixed > cordova@7 plugin add --link is broken > - > > Key: CB-12787 > URL: https://issues.apache.org/jira/browse/CB-12787 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch, cordova-lib >Affects Versions: 7.0.0 >Reporter: Steve Gill >Assignee: Nikita Matrosov > Labels: cordova-next > > with the change to cordova-fetch for local paths, cordova plugin add > SOMELOCALPATH --link doesn't work anymore. > The plugin first gets `npm installed` into your cordova project (so it now > lives in node_modules), and then it gets copied into your plugins directory. > During the copy to your plugins directory step, that is when the symlink gets > created. So the symlink points to your node_modules/PLUGINDIR and not the > local path to your plugin. > I believe the solution to fixing this would be to `npm link` the plugin > instead of `npm install` when adding it with `--link` flag. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12787) cordova@7 plugin add --link is broken
[ https://issues.apache.org/jira/browse/CB-12787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-12787: Labels: cordova-next (was: cordova-8.0.0) > cordova@7 plugin add --link is broken > - > > Key: CB-12787 > URL: https://issues.apache.org/jira/browse/CB-12787 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch, cordova-lib >Affects Versions: 7.0.0 >Reporter: Steve Gill >Assignee: Nikita Matrosov > Labels: cordova-next > > with the change to cordova-fetch for local paths, cordova plugin add > SOMELOCALPATH --link doesn't work anymore. > The plugin first gets `npm installed` into your cordova project (so it now > lives in node_modules), and then it gets copied into your plugins directory. > During the copy to your plugins directory step, that is when the symlink gets > created. So the symlink points to your node_modules/PLUGINDIR and not the > local path to your plugin. > I believe the solution to fixing this would be to `npm link` the plugin > instead of `npm install` when adding it with `--link` flag. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12787) cordova@7 plugin add --link is broken
[ https://issues.apache.org/jira/browse/CB-12787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035469#comment-16035469 ] ASF GitHub Bot commented on CB-12787: - Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/557 merged > cordova@7 plugin add --link is broken > - > > Key: CB-12787 > URL: https://issues.apache.org/jira/browse/CB-12787 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch, cordova-lib >Affects Versions: 7.0.0 >Reporter: Steve Gill >Assignee: Nikita Matrosov > Labels: cordova-next > > with the change to cordova-fetch for local paths, cordova plugin add > SOMELOCALPATH --link doesn't work anymore. > The plugin first gets `npm installed` into your cordova project (so it now > lives in node_modules), and then it gets copied into your plugins directory. > During the copy to your plugins directory step, that is when the symlink gets > created. So the symlink points to your node_modules/PLUGINDIR and not the > local path to your plugin. > I believe the solution to fixing this would be to `npm link` the plugin > instead of `npm install` when adding it with `--link` flag. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12787) cordova@7 plugin add --link is broken
[ https://issues.apache.org/jira/browse/CB-12787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035463#comment-16035463 ] ASF subversion and git services commented on CB-12787: -- Commit 546612060bdab16ea88ed3a6e3ee8c1f29ffab3d in cordova-lib's branch refs/heads/master from [~Nikita Matrosov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=5466120 ] CB-12787: Fix plugin installation with --link option This closes #557 > cordova@7 plugin add --link is broken > - > > Key: CB-12787 > URL: https://issues.apache.org/jira/browse/CB-12787 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch, cordova-lib >Affects Versions: 7.0.0 >Reporter: Steve Gill >Assignee: Nikita Matrosov > Labels: cordova-8.0.0 > > with the change to cordova-fetch for local paths, cordova plugin add > SOMELOCALPATH --link doesn't work anymore. > The plugin first gets `npm installed` into your cordova project (so it now > lives in node_modules), and then it gets copied into your plugins directory. > During the copy to your plugins directory step, that is when the symlink gets > created. So the symlink points to your node_modules/PLUGINDIR and not the > local path to your plugin. > I believe the solution to fixing this would be to `npm link` the plugin > instead of `npm install` when adding it with `--link` flag. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12787) cordova@7 plugin add --link is broken
[ https://issues.apache.org/jira/browse/CB-12787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035464#comment-16035464 ] ASF GitHub Bot commented on CB-12787: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/557 > cordova@7 plugin add --link is broken > - > > Key: CB-12787 > URL: https://issues.apache.org/jira/browse/CB-12787 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch, cordova-lib >Affects Versions: 7.0.0 >Reporter: Steve Gill >Assignee: Nikita Matrosov > Labels: cordova-8.0.0 > > with the change to cordova-fetch for local paths, cordova plugin add > SOMELOCALPATH --link doesn't work anymore. > The plugin first gets `npm installed` into your cordova project (so it now > lives in node_modules), and then it gets copied into your plugins directory. > During the copy to your plugins directory step, that is when the symlink gets > created. So the symlink points to your node_modules/PLUGINDIR and not the > local path to your plugin. > I believe the solution to fixing this would be to `npm link` the plugin > instead of `npm install` when adding it with `--link` flag. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11784) Memory leak on iOS when opening and closing camera
[ https://issues.apache.org/jira/browse/CB-11784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035425#comment-16035425 ] Armando Ruiz commented on CB-11784: --- I have the profiler logs, if you need it, please let me know. Regards! > Memory leak on iOS when opening and closing camera > -- > > Key: CB-11784 > URL: https://issues.apache.org/jira/browse/CB-11784 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: 2.2.0 > Environment: Cordova CLI version 6.3.0 > cordova-plugin-camera 2.2.0 > cordova-ios 4.2.0 > iOS 9.3.5 > iPad Mini 1 >Reporter: Christopher McCabe > > When opening and closing the camera plugin without taking an image, the > memory allocated under 'Other Resources' grows without ever being cleaned up. > Testing on an iPad mini 1, when I open and close the camera plugin without > taking a picture I can crash the app. This usually takes about 130-150 times > opening and closing the camera to cause a crash. The leak is present on newer > devices but the app is harder to crash due to the much larger device memory. > Steps to reproduce: > 1. create an app with the camera plugin > 2. run the app on an iPad mini 1 > 3. open the camera plugin to take a picture, not from the gallery > 4. click cancel > 5. repeat 3 + 4 until the app crashes > It appears that Jetsam kills the app for not being a good memory citizen. > EDIT: I've tested this further and it appears on my iPad mini 3 as well > although it's harder to trigger. I've included a sample app that can be used > to view the problem > https://github.com/modohash/cordova-camera-leak > By clicking the 'trigger camera' button and then clicking cancel and > repeating the process you can see that while the app memory usage stays > steady, the other processes accumulate memory. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12786) Improve logic for searching plugin id in case of module already exists in node_modules
[ https://issues.apache.org/jira/browse/CB-12786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035414#comment-16035414 ] ASF GitHub Bot commented on CB-12786: - Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/555#discussion_r119950730 --- Diff: cordova-fetch/index.js --- @@ -148,9 +148,15 @@ function trimID(target) { target = parts[1]; } -//If local path exists, set target to final directory +// If local path exists, try to get plugin id from package.json or set target to final directory if (fs.existsSync(target)) { -target = path.basename(target); +var pluginId, pkgJsonPath = path.join(target, 'package.json'); + +if (fs.existsSync(pkgJsonPath)) { +pluginId = JSON.parse(fs.readFileSync(pkgJsonPath)).cordova.id; --- End diff -- why use `pkgJsonPath.cordova.id` instead of `pkgJsonPath.cordova.name` ? I don't even remember why we have `cordova.id` anymore haha. > Improve logic for searching plugin id in case of module already exists in > node_modules > -- > > Key: CB-12786 > URL: https://issues.apache.org/jira/browse/CB-12786 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: 1.1.0 > Environment: cordova-7.0.2-dev >Reporter: Nikita Matrosov >Assignee: Nikita Matrosov > Labels: cordova-next > > Steps to reproduce > There is the issue with searching plugin id if the module already exists in > node_modules. > cordova create sample > cordova platform add android > cordova plugin add cordova-plugin-ms-adal > cordova plugin add ../azure-activedirectory-library-for-cordova (use local > folder) > Get error message: > Error: Failed to get absolute path to installed module > This error occurs since folder name in node_modules (cordova-plugin-ms-adal) > differs from base name of installation folder > (azure-activedirectory-library-for-cordova). > PR: https://github.com/apache/cordova-lib/pull/555 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12786) Improve logic for searching plugin id in case of module already exists in node_modules
[ https://issues.apache.org/jira/browse/CB-12786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-12786: Labels: cordova-next (was: ) > Improve logic for searching plugin id in case of module already exists in > node_modules > -- > > Key: CB-12786 > URL: https://issues.apache.org/jira/browse/CB-12786 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: 1.1.0 > Environment: cordova-7.0.2-dev >Reporter: Nikita Matrosov >Assignee: Nikita Matrosov > Labels: cordova-next > > Steps to reproduce > There is the issue with searching plugin id if the module already exists in > node_modules. > cordova create sample > cordova platform add android > cordova plugin add cordova-plugin-ms-adal > cordova plugin add ../azure-activedirectory-library-for-cordova (use local > folder) > Get error message: > Error: Failed to get absolute path to installed module > This error occurs since folder name in node_modules (cordova-plugin-ms-adal) > differs from base name of installation folder > (azure-activedirectory-library-for-cordova). > PR: https://github.com/apache/cordova-lib/pull/555 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12738) cordova ignores plugin dependency version
[ https://issues.apache.org/jira/browse/CB-12738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-12738: Labels: cordova-next (was: ) > cordova ignores plugin dependency version > - > > Key: CB-12738 > URL: https://issues.apache.org/jira/browse/CB-12738 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib >Reporter: Marcus Pridham >Assignee: Nikita Matrosov > Labels: cordova-next > > You can see this with the cordova-plugin-file-transfer. When you install > this plugin and it installs the cordova-plugin-file plugin dependency the CLI > writes > Fetching plugin "cordova-plugin-file" via npm > The first problem is in the PluginInfo _parseDependency function > https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-common/src/PluginInfo/PluginInfo.js;h=48174707b0dbf6f60eb65faeb14c51e4b3868b1b;hb=HEAD#l108 > It does not parse out the dependency version. This part: > {code} > var dep = > { id : tag.attrib.id > , url : tag.attrib.url || '' > , subdir : tag.attrib.subdir || '' > , commit : tag.attrib.commit > }; > {code} > Should be: > {code} > var dep = > { id : tag.attrib.id > , url : tag.attrib.url || '' > , subdir : tag.attrib.subdir || '' > , commit : tag.attrib.commit > , version : tag.attrib.version > }; > {code} > The second problem is in the plugman installDependency method > https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-lib/src/plugman/install.js;h=fca77c688d2b8f19ce63cb176f50ecd44c9a9032;hb=HEAD#l603 > The dep_src is only constructed using the plugin id. > This: > {code} > var dep_src = dep.url.length ? dep.url : dep.id; > {code} > Should look something like: > {code} > var dep_src; > if (dep.url.length) { > dep_src = dep.url; > } > else if (dep.version) { > dep_src = dep.id + '@' + dep.version; > } else { > dep_src = dep.id; > } > {code} > With these changes the Cordova CLI correctly reports: > Fetching plugin "cordova-plugin-file@^4.0.0" via npm -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12738) cordova ignores plugin dependency version
[ https://issues.apache.org/jira/browse/CB-12738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-12738. - Resolution: Fixed > cordova ignores plugin dependency version > - > > Key: CB-12738 > URL: https://issues.apache.org/jira/browse/CB-12738 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib >Reporter: Marcus Pridham >Assignee: Nikita Matrosov > Labels: cordova-next > > You can see this with the cordova-plugin-file-transfer. When you install > this plugin and it installs the cordova-plugin-file plugin dependency the CLI > writes > Fetching plugin "cordova-plugin-file" via npm > The first problem is in the PluginInfo _parseDependency function > https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-common/src/PluginInfo/PluginInfo.js;h=48174707b0dbf6f60eb65faeb14c51e4b3868b1b;hb=HEAD#l108 > It does not parse out the dependency version. This part: > {code} > var dep = > { id : tag.attrib.id > , url : tag.attrib.url || '' > , subdir : tag.attrib.subdir || '' > , commit : tag.attrib.commit > }; > {code} > Should be: > {code} > var dep = > { id : tag.attrib.id > , url : tag.attrib.url || '' > , subdir : tag.attrib.subdir || '' > , commit : tag.attrib.commit > , version : tag.attrib.version > }; > {code} > The second problem is in the plugman installDependency method > https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-lib/src/plugman/install.js;h=fca77c688d2b8f19ce63cb176f50ecd44c9a9032;hb=HEAD#l603 > The dep_src is only constructed using the plugin id. > This: > {code} > var dep_src = dep.url.length ? dep.url : dep.id; > {code} > Should look something like: > {code} > var dep_src; > if (dep.url.length) { > dep_src = dep.url; > } > else if (dep.version) { > dep_src = dep.id + '@' + dep.version; > } else { > dep_src = dep.id; > } > {code} > With these changes the Cordova CLI correctly reports: > Fetching plugin "cordova-plugin-file@^4.0.0" via npm -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-12738) cordova ignores plugin dependency version
[ https://issues.apache.org/jira/browse/CB-12738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill reassigned CB-12738: --- Assignee: Nikita Matrosov > cordova ignores plugin dependency version > - > > Key: CB-12738 > URL: https://issues.apache.org/jira/browse/CB-12738 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib >Reporter: Marcus Pridham >Assignee: Nikita Matrosov > Labels: cordova-next > > You can see this with the cordova-plugin-file-transfer. When you install > this plugin and it installs the cordova-plugin-file plugin dependency the CLI > writes > Fetching plugin "cordova-plugin-file" via npm > The first problem is in the PluginInfo _parseDependency function > https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-common/src/PluginInfo/PluginInfo.js;h=48174707b0dbf6f60eb65faeb14c51e4b3868b1b;hb=HEAD#l108 > It does not parse out the dependency version. This part: > {code} > var dep = > { id : tag.attrib.id > , url : tag.attrib.url || '' > , subdir : tag.attrib.subdir || '' > , commit : tag.attrib.commit > }; > {code} > Should be: > {code} > var dep = > { id : tag.attrib.id > , url : tag.attrib.url || '' > , subdir : tag.attrib.subdir || '' > , commit : tag.attrib.commit > , version : tag.attrib.version > }; > {code} > The second problem is in the plugman installDependency method > https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-lib/src/plugman/install.js;h=fca77c688d2b8f19ce63cb176f50ecd44c9a9032;hb=HEAD#l603 > The dep_src is only constructed using the plugin id. > This: > {code} > var dep_src = dep.url.length ? dep.url : dep.id; > {code} > Should look something like: > {code} > var dep_src; > if (dep.url.length) { > dep_src = dep.url; > } > else if (dep.version) { > dep_src = dep.id + '@' + dep.version; > } else { > dep_src = dep.id; > } > {code} > With these changes the Cordova CLI correctly reports: > Fetching plugin "cordova-plugin-file@^4.0.0" via npm -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12738) cordova ignores plugin dependency version
[ https://issues.apache.org/jira/browse/CB-12738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035390#comment-16035390 ] ASF GitHub Bot commented on CB-12738: - Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/554 merged > cordova ignores plugin dependency version > - > > Key: CB-12738 > URL: https://issues.apache.org/jira/browse/CB-12738 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib >Reporter: Marcus Pridham > > You can see this with the cordova-plugin-file-transfer. When you install > this plugin and it installs the cordova-plugin-file plugin dependency the CLI > writes > Fetching plugin "cordova-plugin-file" via npm > The first problem is in the PluginInfo _parseDependency function > https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-common/src/PluginInfo/PluginInfo.js;h=48174707b0dbf6f60eb65faeb14c51e4b3868b1b;hb=HEAD#l108 > It does not parse out the dependency version. This part: > {code} > var dep = > { id : tag.attrib.id > , url : tag.attrib.url || '' > , subdir : tag.attrib.subdir || '' > , commit : tag.attrib.commit > }; > {code} > Should be: > {code} > var dep = > { id : tag.attrib.id > , url : tag.attrib.url || '' > , subdir : tag.attrib.subdir || '' > , commit : tag.attrib.commit > , version : tag.attrib.version > }; > {code} > The second problem is in the plugman installDependency method > https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-lib/src/plugman/install.js;h=fca77c688d2b8f19ce63cb176f50ecd44c9a9032;hb=HEAD#l603 > The dep_src is only constructed using the plugin id. > This: > {code} > var dep_src = dep.url.length ? dep.url : dep.id; > {code} > Should look something like: > {code} > var dep_src; > if (dep.url.length) { > dep_src = dep.url; > } > else if (dep.version) { > dep_src = dep.id + '@' + dep.version; > } else { > dep_src = dep.id; > } > {code} > With these changes the Cordova CLI correctly reports: > Fetching plugin "cordova-plugin-file@^4.0.0" via npm -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12738) cordova ignores plugin dependency version
[ https://issues.apache.org/jira/browse/CB-12738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035382#comment-16035382 ] ASF subversion and git services commented on CB-12738: -- Commit a7b5433f47f09546a8024948d0d8935281e944de in cordova-lib's branch refs/heads/master from [~Nikita Matrosov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=a7b5433 ] CB-12738: Cordova ignores plugin dependency version on windows platform This closes #554 > cordova ignores plugin dependency version > - > > Key: CB-12738 > URL: https://issues.apache.org/jira/browse/CB-12738 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib >Reporter: Marcus Pridham > > You can see this with the cordova-plugin-file-transfer. When you install > this plugin and it installs the cordova-plugin-file plugin dependency the CLI > writes > Fetching plugin "cordova-plugin-file" via npm > The first problem is in the PluginInfo _parseDependency function > https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-common/src/PluginInfo/PluginInfo.js;h=48174707b0dbf6f60eb65faeb14c51e4b3868b1b;hb=HEAD#l108 > It does not parse out the dependency version. This part: > {code} > var dep = > { id : tag.attrib.id > , url : tag.attrib.url || '' > , subdir : tag.attrib.subdir || '' > , commit : tag.attrib.commit > }; > {code} > Should be: > {code} > var dep = > { id : tag.attrib.id > , url : tag.attrib.url || '' > , subdir : tag.attrib.subdir || '' > , commit : tag.attrib.commit > , version : tag.attrib.version > }; > {code} > The second problem is in the plugman installDependency method > https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-lib/src/plugman/install.js;h=fca77c688d2b8f19ce63cb176f50ecd44c9a9032;hb=HEAD#l603 > The dep_src is only constructed using the plugin id. > This: > {code} > var dep_src = dep.url.length ? dep.url : dep.id; > {code} > Should look something like: > {code} > var dep_src; > if (dep.url.length) { > dep_src = dep.url; > } > else if (dep.version) { > dep_src = dep.id + '@' + dep.version; > } else { > dep_src = dep.id; > } > {code} > With these changes the Cordova CLI correctly reports: > Fetching plugin "cordova-plugin-file@^4.0.0" via npm -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12738) cordova ignores plugin dependency version
[ https://issues.apache.org/jira/browse/CB-12738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035384#comment-16035384 ] ASF GitHub Bot commented on CB-12738: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/554 > cordova ignores plugin dependency version > - > > Key: CB-12738 > URL: https://issues.apache.org/jira/browse/CB-12738 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib >Reporter: Marcus Pridham > > You can see this with the cordova-plugin-file-transfer. When you install > this plugin and it installs the cordova-plugin-file plugin dependency the CLI > writes > Fetching plugin "cordova-plugin-file" via npm > The first problem is in the PluginInfo _parseDependency function > https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-common/src/PluginInfo/PluginInfo.js;h=48174707b0dbf6f60eb65faeb14c51e4b3868b1b;hb=HEAD#l108 > It does not parse out the dependency version. This part: > {code} > var dep = > { id : tag.attrib.id > , url : tag.attrib.url || '' > , subdir : tag.attrib.subdir || '' > , commit : tag.attrib.commit > }; > {code} > Should be: > {code} > var dep = > { id : tag.attrib.id > , url : tag.attrib.url || '' > , subdir : tag.attrib.subdir || '' > , commit : tag.attrib.commit > , version : tag.attrib.version > }; > {code} > The second problem is in the plugman installDependency method > https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-lib/src/plugman/install.js;h=fca77c688d2b8f19ce63cb176f50ecd44c9a9032;hb=HEAD#l603 > The dep_src is only constructed using the plugin id. > This: > {code} > var dep_src = dep.url.length ? dep.url : dep.id; > {code} > Should look something like: > {code} > var dep_src; > if (dep.url.length) { > dep_src = dep.url; > } > else if (dep.version) { > dep_src = dep.id + '@' + dep.version; > } else { > dep_src = dep.id; > } > {code} > With these changes the Cordova CLI correctly reports: > Fetching plugin "cordova-plugin-file@^4.0.0" via npm -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035322#comment-16035322 ] Thom Eijken edited comment on CB-12875 at 6/2/17 7:58 PM: -- Just attached the screenshots in my test app. I've tested this on iOS 9.3.5 (iphone 5S) and iOS 10.2 (iphone 7). InAppBrowser plugin version is 1.7.1. was (Author: thomeijken): Just attached the screenshots in my test app. I've tested this on iOS 9.3.5 (iphone 5S) and iOS 10.2 (iphone 7). InAppBrowser plug version is 1.7.1. > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035322#comment-16035322 ] Thom Eijken commented on CB-12875: -- Just attached the screenshots in my test app. I've tested this on iOS 9.3.5 (iphone 5S) and iOS 10.2 (iphone 7). InAppBrowser plug version is 1.7.1. > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11784) Memory leak on iOS when opening and closing camera
[ https://issues.apache.org/jira/browse/CB-11784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035321#comment-16035321 ] Cody Becker commented on CB-11784: -- issue happens reliably on iPhone 6 (non-s model), I believe the high resolution photo and relatively low ram makes it so reproducible. Between 40-50 pictures it will crash, usually around 44 for me. Cody > Memory leak on iOS when opening and closing camera > -- > > Key: CB-11784 > URL: https://issues.apache.org/jira/browse/CB-11784 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: 2.2.0 > Environment: Cordova CLI version 6.3.0 > cordova-plugin-camera 2.2.0 > cordova-ios 4.2.0 > iOS 9.3.5 > iPad Mini 1 >Reporter: Christopher McCabe > > When opening and closing the camera plugin without taking an image, the > memory allocated under 'Other Resources' grows without ever being cleaned up. > Testing on an iPad mini 1, when I open and close the camera plugin without > taking a picture I can crash the app. This usually takes about 130-150 times > opening and closing the camera to cause a crash. The leak is present on newer > devices but the app is harder to crash due to the much larger device memory. > Steps to reproduce: > 1. create an app with the camera plugin > 2. run the app on an iPad mini 1 > 3. open the camera plugin to take a picture, not from the gallery > 4. click cancel > 5. repeat 3 + 4 until the app crashes > It appears that Jetsam kills the app for not being a good memory citizen. > EDIT: I've tested this further and it appears on my iPad mini 3 as well > although it's harder to trigger. I've included a sample app that can be used > to view the problem > https://github.com/modohash/cordova-camera-leak > By clicking the 'trigger camera' button and then clicking cancel and > repeating the process you can see that while the app memory usage stays > steady, the other processes accumulate memory. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035307#comment-16035307 ] Kerri Shotts commented on CB-12875: --- Also -- what version of the inappbrowser plugin are you using? > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thom Eijken updated CB-12875: - Attachment: IMG_5792.jpg IMG_5791.jpg > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035266#comment-16035266 ] Kerri Shotts commented on CB-12875: --- Please add a screenshot so we aren't guessing at what we're supposed to see. Also indicate which version(s) of iOS and device(s) you've tried on. > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-12876) Memory Leak
[ https://issues.apache.org/jira/browse/CB-12876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kerri Shotts closed CB-12876. - Resolution: Duplicate Thanks for the report; closing as duplicate for now (see duplicate issue #s). If you feel this isn't a duplicate, let me know and we can reopen. > Memory Leak > > > Key: CB-12876 > URL: https://issues.apache.org/jira/browse/CB-12876 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: Master > Environment: iOS >Reporter: Cody Becker >Priority: Critical > > Memory Leak & Crash, especially prevalent on iPhone 6 (non-s model), due to > the high resolution of the camera. > To reproduce create an app which takes a photo and displays the image to a > box on the screen, take 40-45 successive photos and the app should > crash. > Issue not present in alternative implementations such as: > https://github.com/LoganWright/SimpleCam -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-12361: Labels: cordova-next (was: cordova-8.0.0) > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12766) Cordova CLI changes package.json indentation
[ https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-12766: Labels: cordova-next easy-fix (was: easy-fix) > Cordova CLI changes package.json indentation > > > Key: CB-12766 > URL: https://issues.apache.org/jira/browse/CB-12766 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib >Affects Versions: 7.0.0 >Reporter: Remco Haszing >Assignee: Kerri Shotts >Priority: Minor > Labels: cordova-next, easy-fix > > While Cordova is busy adding platforms / plugins, it writes to package.json > several times. In this process the indentation of package.json alternates > between 2 and 4 spaces. The final result is an indentation of 4 spaces, which > conflicts with the indentation of 2 spaces that npm uses. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12766) Cordova CLI changes package.json indentation
[ https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-12766. - Resolution: Fixed > Cordova CLI changes package.json indentation > > > Key: CB-12766 > URL: https://issues.apache.org/jira/browse/CB-12766 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib >Affects Versions: 7.0.0 >Reporter: Remco Haszing >Assignee: Kerri Shotts >Priority: Minor > Labels: cordova-next, easy-fix > > While Cordova is busy adding platforms / plugins, it writes to package.json > several times. In this process the indentation of package.json alternates > between 2 and 4 spaces. The final result is an indentation of 4 spaces, which > conflicts with the indentation of 2 spaces that npm uses. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12810) keep existing formatting in package.json
[ https://issues.apache.org/jira/browse/CB-12810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-12810: Labels: cordova-8.0.0 cordova-next (was: cordova-8.0.0) > keep existing formatting in package.json > > > Key: CB-12810 > URL: https://issues.apache.org/jira/browse/CB-12810 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: 7.0.0 >Reporter: Steve Gill >Priority: Minor > Labels: cordova-8.0.0, cordova-next > > We will write our own indentation in package.json. For commands that shell > out to cordova-fetch and therefore npm, we have no control over it (cordova > platform/plugin add/rm). > We could theoretically keep indentaiton for commands where we write to > package.json (also platform/plugin add/rm to cordova key & during restore > when we sync config.xml & package.json). > This issue is probably not worth implementing. > npm@5 seems like it will respect existing formatting. > Previous issue with npm formatting: https://github.com/npm/npm/issues/5694 > npm5 respecting indentation: https://github.com/npm/npm/issues/16244 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation
[ https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035213#comment-16035213 ] ASF GitHub Bot commented on CB-12766: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/558 > Cordova CLI changes package.json indentation > > > Key: CB-12766 > URL: https://issues.apache.org/jira/browse/CB-12766 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib >Affects Versions: 7.0.0 >Reporter: Remco Haszing >Assignee: Kerri Shotts >Priority: Minor > Labels: easy-fix > > While Cordova is busy adding platforms / plugins, it writes to package.json > several times. In this process the indentation of package.json alternates > between 2 and 4 spaces. The final result is an indentation of 4 spaces, which > conflicts with the indentation of 2 spaces that npm uses. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation
[ https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035212#comment-16035212 ] ASF subversion and git services commented on CB-12766: -- Commit d244cf8442004f2780775cb16f0ac5454b056996 in cordova-lib's branch refs/heads/master from [~remcohaszing] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=d244cf8 ] CB-12766 Consistently write JSON with 2 spaces indentation JSON was written with 4 spaces indentation and even a tab at some point. Most NodeJS tools write their JSON configuration with an indentation of 2 spaces. Most notably npm does this, which writes to package.json, as does Cordova. This caused unnecessary changes in package.json. This closes #558 > Cordova CLI changes package.json indentation > > > Key: CB-12766 > URL: https://issues.apache.org/jira/browse/CB-12766 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib >Affects Versions: 7.0.0 >Reporter: Remco Haszing >Assignee: Kerri Shotts >Priority: Minor > Labels: easy-fix > > While Cordova is busy adding platforms / plugins, it writes to package.json > several times. In this process the indentation of package.json alternates > between 2 and 4 spaces. The final result is an indentation of 4 spaces, which > conflicts with the indentation of 2 spaces that npm uses. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation
[ https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035214#comment-16035214 ] ASF GitHub Bot commented on CB-12766: - Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/558 merged > Cordova CLI changes package.json indentation > > > Key: CB-12766 > URL: https://issues.apache.org/jira/browse/CB-12766 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-lib >Affects Versions: 7.0.0 >Reporter: Remco Haszing >Assignee: Kerri Shotts >Priority: Minor > Labels: easy-fix > > While Cordova is busy adding platforms / plugins, it writes to package.json > several times. In this process the indentation of package.json alternates > between 2 and 4 spaces. The final result is an indentation of 4 spaces, which > conflicts with the indentation of 2 spaces that npm uses. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12852) [iOS] App crash after taking 30+ photos (possible memory leak)
[ https://issues.apache.org/jira/browse/CB-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035190#comment-16035190 ] Jeremy B commented on CB-12852: --- Are there any suggestions for work arounds? We're having the same issue. On an iPad 3rd gen, version 10.3.1, we can take about 42 pictures and crash the app every time. > [iOS] App crash after taking 30+ photos (possible memory leak) > -- > > Key: CB-12852 > URL: https://issues.apache.org/jira/browse/CB-12852 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: 2.4.1 > Environment: Devices tested: > iPhone 6+ (A1522) - iOS 10.3.1 > iPad 3rd Gen (A1430) - iOS 9.3.5 > Apple iPad Air 2 (A1566) - iOS 10.3.1 > Versions: > Xcode: 7.3.1 & 8.3.2 > cordova: 6.5.0 > cordova-ios: 4.1.1 & 4.4.0 > cordova-camera-plugin: 2.1.0 & 2.4.1 >Reporter: Quentin Gangler > Labels: crash, ios, memory-leak > > To get that out of the way, I know there is already an issue for this bug > (CB-11784), but since the author found a workaround using his own plugin (and > the issue is on an older version of the plugin), I thought I would recreate > it here and give more details on my situation. > Taking photos is a really important part of our app and our clients usually > need to take 100+ photos in one session. Unfortunately, the app seems to > crash after 20-50 photos taken. Looking at the memory usage, I can clearly > see the usage of "other processes" grow like [~modohash] noticed before (even > on the latest version of the plugin). > My team doesn't really want to use his custom plugin because it's not an > official one and neither can we develop our own plugin since we are not > Objective-C developers. > h3. Recreate the issue > *0.* _(Optional)_ Modify [~modohash] [camera leak demo > app|https://github.com/modohash/cordova-camera-leak] to open the camera again > after a successful photo (cancel a photo to get out of the loop) > {code:javascript|title=index.js (onDeviceReady)|borderStyle=solid} > var button = document.getElementById('trigger-camera'); > button.addEventListener('click', function () { > takePicture(); > }, false); > function takePicture() { > navigator.camera.getPicture(function () { > navigator.camea.cleanup(); > takePicture(); > }, function () { > console.log('failure'); > } > } > {code} > *1.* Build the app with the latest cordova-ios and camera-plugin > *2.* Click on *Trigger Camera* > *3.* Take photo (+ use photo) > *4.* Go to *2.* if *0.* is not implemented and wait for the crash (around 30 > photos in on iPhone 6) > h3. Questions > Is there any workaround on this issue using the official plugin or do we > *have* to use another plugin custom to fix it? > Is this really an Apple related issue like [~modohash] suggests? > Thanks in advance for your anwsers -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12762) Point package.json repo items to github mirrors
[ https://issues.apache.org/jira/browse/CB-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035166#comment-16035166 ] ASF GitHub Bot commented on CB-12762: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/37 > Point package.json repo items to github mirrors > --- > > Key: CB-12762 > URL: https://issues.apache.org/jira/browse/CB-12762 > Project: Apache Cordova > Issue Type: Bug > Components: AllComponents >Reporter: Jesse MacFadyen > > Proposal is here: > https://github.com/cordova/cordova-discuss/issues/67 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12762) Point package.json repo items to github mirrors
[ https://issues.apache.org/jira/browse/CB-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035165#comment-16035165 ] ASF subversion and git services commented on CB-12762: -- Commit e6e382a29f6f51c9c8d9e0a6c15bd7dd111c4f08 in cordova-osx's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-osx.git;h=e6e382a ] CB-12762 : point package.json repo items to github mirrors instead of apache repos site This closes #37 > Point package.json repo items to github mirrors > --- > > Key: CB-12762 > URL: https://issues.apache.org/jira/browse/CB-12762 > Project: Apache Cordova > Issue Type: Bug > Components: AllComponents >Reporter: Jesse MacFadyen > > Proposal is here: > https://github.com/cordova/cordova-discuss/issues/67 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12762) Point package.json repo items to github mirrors
[ https://issues.apache.org/jira/browse/CB-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035162#comment-16035162 ] ASF GitHub Bot commented on CB-12762: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/36 > Point package.json repo items to github mirrors > --- > > Key: CB-12762 > URL: https://issues.apache.org/jira/browse/CB-12762 > Project: Apache Cordova > Issue Type: Bug > Components: AllComponents >Reporter: Jesse MacFadyen > > Proposal is here: > https://github.com/cordova/cordova-discuss/issues/67 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12762) Point package.json repo items to github mirrors
[ https://issues.apache.org/jira/browse/CB-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035161#comment-16035161 ] ASF subversion and git services commented on CB-12762: -- Commit 5a97cc4cb32cb0d858e248cf9759f075e8132a0d in cordova-plugin-wkwebview-engine's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-wkwebview-engine.git;h=5a97cc4 ] CB-12762 : point package.json repo items to github mirrors instead of apache repos site This closes #36 > Point package.json repo items to github mirrors > --- > > Key: CB-12762 > URL: https://issues.apache.org/jira/browse/CB-12762 > Project: Apache Cordova > Issue Type: Bug > Components: AllComponents >Reporter: Jesse MacFadyen > > Proposal is here: > https://github.com/cordova/cordova-discuss/issues/67 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12122) Incompatible plugin should make the build fail, not be skipped silently
[ https://issues.apache.org/jira/browse/CB-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12122: -- Labels: cordova-8.0.0 (was: cordova@7) > Incompatible plugin should make the build fail, not be skipped silently > --- > > Key: CB-12122 > URL: https://issues.apache.org/jira/browse/CB-12122 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-plugman >Affects Versions: 6.3.0 >Reporter: 165537 > Labels: cordova-8.0.0 > > When compiling (on Phonegap Build) a project containing a plugin which > Cordova's version is incompatible, the plugin is silently skipped and the > build is successful. Of course the functionalities of the plugin won't work > in the app. Eg, here's what I got when compiling phonegap-plugin-push with > Cordova 6.3.0: > Fetching plugin "phonegap-plugin-push@1.9.0" via npm > Installing "phonegap-plugin-push" at "1.9.0" for android > Plugin doesn't support this project's cordova version. cordova: 6.3.2, failed > version requirement: >=6.4.0 > Skipping 'phonegap-plugin-push' for android -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12122) Incompatible plugin should make the build fail, not be skipped silently
[ https://issues.apache.org/jira/browse/CB-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12122: -- Fix Version/s: (was: cordova@7) > Incompatible plugin should make the build fail, not be skipped silently > --- > > Key: CB-12122 > URL: https://issues.apache.org/jira/browse/CB-12122 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-plugman >Affects Versions: 6.3.0 >Reporter: 165537 > Labels: cordova@7 > > When compiling (on Phonegap Build) a project containing a plugin which > Cordova's version is incompatible, the plugin is silently skipped and the > build is successful. Of course the functionalities of the plugin won't work > in the app. Eg, here's what I got when compiling phonegap-plugin-push with > Cordova 6.3.0: > Fetching plugin "phonegap-plugin-push@1.9.0" via npm > Installing "phonegap-plugin-push" at "1.9.0" for android > Plugin doesn't support this project's cordova version. cordova: 6.3.2, failed > version requirement: >=6.4.0 > Skipping 'phonegap-plugin-push' for android -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12122) Incompatible plugin should make the build fail, not be skipped silently
[ https://issues.apache.org/jira/browse/CB-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12122: -- Labels: cordova@7 (was: ) > Incompatible plugin should make the build fail, not be skipped silently > --- > > Key: CB-12122 > URL: https://issues.apache.org/jira/browse/CB-12122 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-plugman >Affects Versions: 6.3.0 >Reporter: 165537 > Labels: cordova@7 > > When compiling (on Phonegap Build) a project containing a plugin which > Cordova's version is incompatible, the plugin is silently skipped and the > build is successful. Of course the functionalities of the plugin won't work > in the app. Eg, here's what I got when compiling phonegap-plugin-push with > Cordova 6.3.0: > Fetching plugin "phonegap-plugin-push@1.9.0" via npm > Installing "phonegap-plugin-push" at "1.9.0" for android > Plugin doesn't support this project's cordova version. cordova: 6.3.2, failed > version requirement: >=6.4.0 > Skipping 'phonegap-plugin-push' for android -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12122) Incompatible plugin should make the build fail, not be skipped silently
[ https://issues.apache.org/jira/browse/CB-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-12122: -- Fix Version/s: cordova@7 > Incompatible plugin should make the build fail, not be skipped silently > --- > > Key: CB-12122 > URL: https://issues.apache.org/jira/browse/CB-12122 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-plugman >Affects Versions: 6.3.0 >Reporter: 165537 > Fix For: cordova@7 > > > When compiling (on Phonegap Build) a project containing a plugin which > Cordova's version is incompatible, the plugin is silently skipped and the > build is successful. Of course the functionalities of the plugin won't work > in the app. Eg, here's what I got when compiling phonegap-plugin-push with > Cordova 6.3.0: > Fetching plugin "phonegap-plugin-push@1.9.0" via npm > Installing "phonegap-plugin-push" at "1.9.0" for android > Plugin doesn't support this project's cordova version. cordova: 6.3.2, failed > version requirement: >=6.4.0 > Skipping 'phonegap-plugin-push' for android -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12122) Incompatible plugin should make the build fail, not be skipped silently
[ https://issues.apache.org/jira/browse/CB-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035124#comment-16035124 ] Shazron Abdullah commented on CB-12122: --- {code} $ cordova --version 7.0.1 $ cordova create foo Creating a new cordova project. $ cd foo $ cordova platform add ios Using cordova-fetch for cordova-ios@~4.4.0 Adding ios project... Creating Cordova project for the iOS platform: Path: platforms/ios Package: io.cordova.hellocordova Name: HelloCordova iOS project created with cordova-ios@4.4.0 Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the project Installing "cordova-plugin-whitelist" for ios Adding cordova-plugin-whitelist to package.json Saved plugin info for "cordova-plugin-whitelist" to config.xml --save flag or autosave detected Saving ios@~4.4.0 into config.xml file ... $ cordova plugin add https://github.com/shazron/incompatible-cordova-plugin.git Installing "incompatible-cordova-plugin" for ios Plugin doesn't support this project's cordova version. cordova: 7.0.1, failed version requirement: <0.0.1 Skipping 'incompatible-cordova-plugin' for ios Adding incompatible-cordova-plugin to package.json Saved plugin info for "incompatible-cordova-plugin" to config.xml {code} > Incompatible plugin should make the build fail, not be skipped silently > --- > > Key: CB-12122 > URL: https://issues.apache.org/jira/browse/CB-12122 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-plugman >Affects Versions: 6.3.0 >Reporter: 165537 > > When compiling (on Phonegap Build) a project containing a plugin which > Cordova's version is incompatible, the plugin is silently skipped and the > build is successful. Of course the functionalities of the plugin won't work > in the app. Eg, here's what I got when compiling phonegap-plugin-push with > Cordova 6.3.0: > Fetching plugin "phonegap-plugin-push@1.9.0" via npm > Installing "phonegap-plugin-push" at "1.9.0" for android > Plugin doesn't support this project's cordova version. cordova: 6.3.2, failed > version requirement: >=6.4.0 > Skipping 'phonegap-plugin-push' for android -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12762) Point package.json repo items to github mirrors
[ https://issues.apache.org/jira/browse/CB-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035073#comment-16035073 ] ASF GitHub Bot commented on CB-12762: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/36 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/36/commits/4b803231f9c274eac14f4906e8bbde5ff938781d) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-wkwebview-engine-pr/19/) 2 tests run, 0 skipped, 0 failed. > Point package.json repo items to github mirrors > --- > > Key: CB-12762 > URL: https://issues.apache.org/jira/browse/CB-12762 > Project: Apache Cordova > Issue Type: Bug > Components: AllComponents >Reporter: Jesse MacFadyen > > Proposal is here: > https://github.com/cordova/cordova-discuss/issues/67 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12122) Incompatible plugin should make the build fail, not be skipped silently
[ https://issues.apache.org/jira/browse/CB-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035069#comment-16035069 ] Shazron Abdullah commented on CB-12122: --- Sorry about this. Revived the thread: https://s.apache.org/ofqR > Incompatible plugin should make the build fail, not be skipped silently > --- > > Key: CB-12122 > URL: https://issues.apache.org/jira/browse/CB-12122 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-plugman >Affects Versions: 6.3.0 >Reporter: 165537 > > When compiling (on Phonegap Build) a project containing a plugin which > Cordova's version is incompatible, the plugin is silently skipped and the > build is successful. Of course the functionalities of the plugin won't work > in the app. Eg, here's what I got when compiling phonegap-plugin-push with > Cordova 6.3.0: > Fetching plugin "phonegap-plugin-push@1.9.0" via npm > Installing "phonegap-plugin-push" at "1.9.0" for android > Plugin doesn't support this project's cordova version. cordova: 6.3.2, failed > version requirement: >=6.4.0 > Skipping 'phonegap-plugin-push' for android -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12168) NSLog behavior changed in iOS10
[ https://issues.apache.org/jira/browse/CB-12168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035054#comment-16035054 ] ASF GitHub Bot commented on CB-12168: - Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-console/pull/22 Also, please change the title to have a prefix of "CB-12168" so it can be auto-tracked in JIRA. This was already covered in the Github Pull Request template that you erased when a pull request was started. e.g. "CB-12168 - my issue description here" > NSLog behavior changed in iOS10 > --- > > Key: CB-12168 > URL: https://issues.apache.org/jira/browse/CB-12168 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-console >Reporter: Mathias Latournerie > > Hello, > Since iOS10, NSLog changed in two ways : > - It now truncates its output to 1024 characters > - It isn't logged anymore for deployed apps > iOS10 introduced a new logger : os_log > This plugin should reflect on this change and use os_log when available. > Currently, you can't read console.log on iOS10 if you do not run your project > directly from xcode in debug mode. > See this link for more informations : http://stackoverflow.com/a/40451002 > Regards. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12762) Point package.json repo items to github mirrors
[ https://issues.apache.org/jira/browse/CB-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035047#comment-16035047 ] ASF GitHub Bot commented on CB-12762: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/36 CB-12762 : point package.json repo items to github mirrors instead of… … apache repos site ### Platforms affected ### What does this PR do? Point package.json repo items to github mirrors instead of apache repos site. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-wkwebview-engine CB-12762 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 commit 4b803231f9c274eac14f4906e8bbde5ff938781d Author: Audrey So Date: 2017-06-02T16:59:05Z CB-12762 : point package.json repo items to github mirrors instead of apache repos site > Point package.json repo items to github mirrors > --- > > Key: CB-12762 > URL: https://issues.apache.org/jira/browse/CB-12762 > Project: Apache Cordova > Issue Type: Bug > Components: AllComponents >Reporter: Jesse MacFadyen > > Proposal is here: > https://github.com/cordova/cordova-discuss/issues/67 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12876) Memory Leak
Cody Becker created CB-12876: Summary: Memory Leak Key: CB-12876 URL: https://issues.apache.org/jira/browse/CB-12876 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-camera Affects Versions: Master Environment: iOS Reporter: Cody Becker Priority: Critical Memory Leak & Crash, especially prevalent on iPhone 6 (non-s model), due to the high resolution of the camera. To reproduce create an app which takes a photo and displays the image to a box on the screen, take 40-45 successive photos and the app should crash. Issue not present in alternative implementations such as: https://github.com/LoganWright/SimpleCam -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-12868) Improve telemetry.cordova.io
[ https://issues.apache.org/jira/browse/CB-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034855#comment-16034855 ] Jan Piotrowski edited comment on CB-12868 at 6/2/17 3:48 PM: - Had to change the layout of the "old" report a bit as well, so the "header" is shared between all reports. No functionality change, just visual. The "Map" view was sometimes broken this morning, I am not sure if this is because of a change of mine or something else. Observing. There are now multiple pages, one each for every data type. was (Author: sujan12): Had to change the layout of the "old" report a bit as well, so the "header" is shared between all reports. No functionality change, just visual. The "Map" view was sometimes broken this morning, I am not sure if this is because of a change of mine or something else. Observing. There are not multiple pages, one each for every data type. > Improve telemetry.cordova.io > > > Key: CB-12868 > URL: https://issues.apache.org/jira/browse/CB-12868 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Reporter: Jan Piotrowski >Assignee: Jan Piotrowski > > The data on telemetry.cordova.io is very interesting. But I think the report > could be improved quite a bit: > - Show more data "over time" (as "Users" and "Cordova Versions" does already) > - Give different things a bit more space and padding > - Show more data tables (like "Node Version <-> Users") > I could actually work on this, just need an invite for the report. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12764) Adapt Camera Appium tests to be able to run on Android 7
[ https://issues.apache.org/jira/browse/CB-12764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034896#comment-16034896 ] ASF GitHub Bot commented on CB-12764: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/269 > Adapt Camera Appium tests to be able to run on Android 7 > > > Key: CB-12764 > URL: https://issues.apache.org/jira/browse/CB-12764 > Project: Apache Cordova > Issue Type: Test > Components: Appium, cordova-plugin-camera >Reporter: Alexander Sorokin >Assignee: Alexander Sorokin > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12764) Adapt Camera Appium tests to be able to run on Android 7
[ https://issues.apache.org/jira/browse/CB-12764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034895#comment-16034895 ] ASF subversion and git services commented on CB-12764: -- Commit 1b218cd8a0e155dff2ee03a04a45a84977cb2fdc in cordova-plugin-camera's branch refs/heads/master from [~alsorokin] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;h=1b218cd ] CB-12764: (android) Adapt Appium tests for Android 7 > Adapt Camera Appium tests to be able to run on Android 7 > > > Key: CB-12764 > URL: https://issues.apache.org/jira/browse/CB-12764 > Project: Apache Cordova > Issue Type: Test > Components: Appium, cordova-plugin-camera >Reporter: Alexander Sorokin >Assignee: Alexander Sorokin > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12868) Improve telemetry.cordova.io
[ https://issues.apache.org/jira/browse/CB-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034882#comment-16034882 ] Jan Piotrowski commented on CB-12868: - And with the removal of the "All in One" page the height is back to 2000px. > Improve telemetry.cordova.io > > > Key: CB-12868 > URL: https://issues.apache.org/jira/browse/CB-12868 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Reporter: Jan Piotrowski >Assignee: Jan Piotrowski > > The data on telemetry.cordova.io is very interesting. But I think the report > could be improved quite a bit: > - Show more data "over time" (as "Users" and "Cordova Versions" does already) > - Give different things a bit more space and padding > - Show more data tables (like "Node Version <-> Users") > I could actually work on this, just need an invite for the report. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-12868) Improve telemetry.cordova.io
[ https://issues.apache.org/jira/browse/CB-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034855#comment-16034855 ] Jan Piotrowski edited comment on CB-12868 at 6/2/17 3:23 PM: - Had to change the layout of the "old" report a bit as well, so the "header" is shared between all reports. No functionality change, just visual. The "Map" view was sometimes broken this morning, I am not sure if this is because of a change of mine or something else. Observing. There are not multiple pages, one each for every data type. was (Author: sujan12): Had to change the layout of the "old" report a bit as well, so the "header" is shared between all reports. No functionality change, just visual. The "Map" view was broken this morning, I am not sure if this is because of a change of mine or something else. There are not multiple pages, one each for every data type. > Improve telemetry.cordova.io > > > Key: CB-12868 > URL: https://issues.apache.org/jira/browse/CB-12868 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Reporter: Jan Piotrowski >Assignee: Jan Piotrowski > > The data on telemetry.cordova.io is very interesting. But I think the report > could be improved quite a bit: > - Show more data "over time" (as "Users" and "Cordova Versions" does already) > - Give different things a bit more space and padding > - Show more data tables (like "Node Version <-> Users") > I could actually work on this, just need an invite for the report. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12868) Improve telemetry.cordova.io
[ https://issues.apache.org/jira/browse/CB-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034855#comment-16034855 ] Jan Piotrowski commented on CB-12868: - Had to change the layout of the "old" report a bit as well, so the "header" is shared between all reports. No functionality change, just visual. The "Map" view was broken this morning, I am not sure if this is because of a change of mine or something else. There are not multiple pages, one each for every data type. > Improve telemetry.cordova.io > > > Key: CB-12868 > URL: https://issues.apache.org/jira/browse/CB-12868 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Reporter: Jan Piotrowski >Assignee: Jan Piotrowski > > The data on telemetry.cordova.io is very interesting. But I think the report > could be improved quite a bit: > - Show more data "over time" (as "Users" and "Cordova Versions" does already) > - Give different things a bit more space and padding > - Show more data tables (like "Node Version <-> Users") > I could actually work on this, just need an invite for the report. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12168) NSLog behavior changed in iOS10
[ https://issues.apache.org/jira/browse/CB-12168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034847#comment-16034847 ] ASF GitHub Bot commented on CB-12168: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-console/pull/22 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-console/pull/22/commits/a24fa611cf8b0d9929695726ede12605fd5ee218) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console-pr/122/) 8 tests run, 0 skipped, 0 failed. > NSLog behavior changed in iOS10 > --- > > Key: CB-12168 > URL: https://issues.apache.org/jira/browse/CB-12168 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-console >Reporter: Mathias Latournerie > > Hello, > Since iOS10, NSLog changed in two ways : > - It now truncates its output to 1024 characters > - It isn't logged anymore for deployed apps > iOS10 introduced a new logger : os_log > This plugin should reflect on this change and use os_log when available. > Currently, you can't read console.log on iOS10 if you do not run your project > directly from xcode in debug mode. > See this link for more informations : http://stackoverflow.com/a/40451002 > Regards. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12168) NSLog behavior changed in iOS10
[ https://issues.apache.org/jira/browse/CB-12168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034809#comment-16034809 ] ASF GitHub Bot commented on CB-12168: - GitHub user sruthakeerthikotla opened a pull request: https://github.com/apache/cordova-plugin-console/pull/22 Fix for : https://issues.apache.org/jira/browse/CB-12168 CB-12168: (ios) Fix to update to ios's new logging function. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sruthakeerthikotla/cordova-plugin-console master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-console/pull/22.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22 commit a24fa611cf8b0d9929695726ede12605fd5ee218 Author: sruthakeerthikotla Date: 2017-06-02T14:51:14Z CB-12168(ios):"Fix to upgrade to ios 10+ logging" > NSLog behavior changed in iOS10 > --- > > Key: CB-12168 > URL: https://issues.apache.org/jira/browse/CB-12168 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-console >Reporter: Mathias Latournerie > > Hello, > Since iOS10, NSLog changed in two ways : > - It now truncates its output to 1024 characters > - It isn't logged anymore for deployed apps > iOS10 introduced a new logger : os_log > This plugin should reflect on this change and use os_log when available. > Currently, you can't read console.log on iOS10 if you do not run your project > directly from xcode in debug mode. > See this link for more informations : http://stackoverflow.com/a/40451002 > Regards. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
Thom Eijken created CB-12875: Summary: iOS Magnifying glass is showing wrong content in iFrame Key: CB-12875 URL: https://issues.apache.org/jira/browse/CB-12875 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-inappbrowser Affects Versions: cordova@7.0.0 Reporter: Thom Eijken Our app is opening certain third party web pages using the inAppbrowser and some of those pages (unfortunately) contain content in iFrames. The issue occurs on iOS when you push and hold the screen to select text or use the magnifying glass to set the cursor in an input/textarea field. What happens is that the magnifying glass doesn't actually show the content within the iFrame, but it shows the content underneath the in-appbrowser (the page that launched the in-appbrowser). I've created a very simple example to reproduce this. Just load test.html in the in-appbrowser and use the magnifying glass inside the iframe. File: test.html File: iframe.html vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob jrwio biorw b vhreiuvhuierf hviu ehv oueh vo qv o -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12764) Adapt Camera Appium tests to be able to run on Android 7
[ https://issues.apache.org/jira/browse/CB-12764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034684#comment-16034684 ] ASF GitHub Bot commented on CB-12764: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/269 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/269/commits/1b218cd8a0e155dff2ee03a04a45a84977cb2fdc) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/173/) 316 tests run, 34 skipped, 0 failed. > Adapt Camera Appium tests to be able to run on Android 7 > > > Key: CB-12764 > URL: https://issues.apache.org/jira/browse/CB-12764 > Project: Apache Cordova > Issue Type: Test > Components: Appium, cordova-plugin-camera >Reporter: Alexander Sorokin >Assignee: Alexander Sorokin > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12764) Adapt Camera Appium tests to be able to run on Android 7
[ https://issues.apache.org/jira/browse/CB-12764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034588#comment-16034588 ] ASF GitHub Bot commented on CB-12764: - GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/269 CB-12764: (android) Adapt Appium tests for Android 7 ### Platforms affected Android ### What does this PR do? https://issues.apache.org/jira/browse/CB-12764 Adapts Appium tests to run on Android 7 emulator on Sauce Labs ### What testing has been done on this change? countless runs on Sauce Labs (i guess these tests currently don't work locally) ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alsorokin/cordova-plugin-camera master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/269.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #269 commit 1b218cd8a0e155dff2ee03a04a45a84977cb2fdc Author: Alexander Sorokin Date: 2017-06-02T12:02:01Z CB-12764: (android) Adapt Appium tests for Android 7 > Adapt Camera Appium tests to be able to run on Android 7 > > > Key: CB-12764 > URL: https://issues.apache.org/jira/browse/CB-12764 > Project: Apache Cordova > Issue Type: Test > Components: Appium, cordova-plugin-camera >Reporter: Alexander Sorokin >Assignee: Alexander Sorokin > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org