[jira] [Commented] (CB-12266) InappBrowser: Browser: loadstop event.url is not a string

2017-04-13 Thread Pieter-Jan Dewitte (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968205#comment-15968205
 ] 

Pieter-Jan Dewitte commented on CB-12266:
-

Thanks for the interest in this issue.

I'm surprised with the proposed resolution in the pull request (changing the 
documentation): this creates a difference between the browser platform and the 
other platforms. I would think that differences between platforms are best 
avoided. 

Is there a reason why it would be desirable to have the Location object rather 
than the url string on the browser platform, knowing it's not available on the 
other platforms?

> InappBrowser: Browser: loadstop event.url is not a string
> -
>
> Key: CB-12266
> URL: https://issues.apache.org/jira/browse/CB-12266
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Browser, Plugin InAppBrowser
>Affects Versions: 3.5.0
> Environment: All browsers (Chrome, Firefox and IE tested)
>Reporter: Pieter-Jan Dewitte
>Priority: Minor
>
> In the browser, the url attribute of the loadstop event (InAppBrowserEvent) 
> is not a string as documented, but a Location object. The url is stored in 
> event.href.
> Steps to reproduce:
> {quote}
> $ cordova create eventstop_url
> $ cd eventstop_url
> $ cordova plugin add cordova-plugin-inappbrowser
> {quote}
> Run the following code after device ready:
> {code:javascript}
> // https://ssl.gstatic.com as an example because it is allowed by the default 
> CSP
> var ref = cordova.InAppBrowser.open('https://ssl.gstatic.com', '_blank');
> ref.addEventListener('loadstop', function (event) {
> console.log("loadstop event:", event);
> });
> {code}
> {quote}
> $ cordova serve
> {quote}
> The console output is:
> {quote}
> loadstop event: Object \{type: "loadstop", url: Location\}
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-12266) InappBrowser: Browser: loadstop event.url is not a string

2016-12-18 Thread Pieter-Jan Dewitte (JIRA)
Pieter-Jan Dewitte created CB-12266:
---

 Summary: InappBrowser: Browser: loadstop event.url is not a string
 Key: CB-12266
 URL: https://issues.apache.org/jira/browse/CB-12266
 Project: Apache Cordova
  Issue Type: Bug
  Components: Browser, Plugin InAppBrowser
Affects Versions: 3.5.0
 Environment: All browsers (Chrome, Firefox and IE tested)
Reporter: Pieter-Jan Dewitte
Priority: Minor


In the browser, the url attribute of the loadstop event (InAppBrowserEvent) is 
not a string as documented, but a Location object. The url is stored in 
event.href.

Steps to reproduce:
{quote}
$ cordova create eventstop_url
$ cd eventstop_url
$ cordova plugin add cordova-plugin-inappbrowser
{quote}

Run the following code after device ready:
{code:javascript}
// https://ssl.gstatic.com as an example because it is allowed by the default 
CSP
var ref = cordova.InAppBrowser.open('https://ssl.gstatic.com', '_blank');
ref.addEventListener('loadstop', function (event) {
console.log("loadstop event:", event);
});
{code}

{quote}
$ cordova serve
{quote}

The console output is:

{quote}
loadstop event: Object \{type: "loadstop", url: Location\}
{quote}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org