[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436630#comment-16436630 ] ASF subversion and git services commented on CB-10645: -- Commit c2a526e673a793f07a5a5341bcc1b03c0121f476 in cordova-plugin-battery-status's branch refs/heads/2.0.x from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=c2a526e ] Merge pull request #31 from Geotab/CB-10645cordova-plugin-battery-status CB-10645 The battery status handler doesn't reinitialize on Android after window.location.reload() > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-battery-status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436629#comment-16436629 ] ASF subversion and git services commented on CB-10645: -- Commit c2a526e673a793f07a5a5341bcc1b03c0121f476 in cordova-plugin-battery-status's branch refs/heads/2.0.x from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=c2a526e ] Merge pull request #31 from Geotab/CB-10645cordova-plugin-battery-status CB-10645 The battery status handler doesn't reinitialize on Android after window.location.reload() > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-battery-status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436625#comment-16436625 ] ASF subversion and git services commented on CB-10645: -- Commit 7d04d6dbaa0b67686facd460458f42a991b66ffb in cordova-plugin-battery-status's branch refs/heads/2.0.x from [~aaront] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=7d04d6d ] CB-10645 The battery status handler doesn't reinitialize on Android after window.location.reload(). Instead of throwing an error, rather remove the status handler and re-initialize. > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-battery-status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372891#comment-16372891 ] ASF subversion and git services commented on CB-10645: -- Commit c2a526e673a793f07a5a5341bcc1b03c0121f476 in cordova-plugin-battery-status's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=c2a526e ] Merge pull request #31 from Geotab/CB-10645cordova-plugin-battery-status CB-10645 The battery status handler doesn't reinitialize on Android after window.location.reload() > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-battery-status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372889#comment-16372889 ] ASF subversion and git services commented on CB-10645: -- Commit 7d04d6dbaa0b67686facd460458f42a991b66ffb in cordova-plugin-battery-status's branch refs/heads/master from [~aaront] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=7d04d6d ] CB-10645 The battery status handler doesn't reinitialize on Android after window.location.reload(). Instead of throwing an error, rather remove the status handler and re-initialize. > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-battery-status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372890#comment-16372890 ] ASF subversion and git services commented on CB-10645: -- Commit c2a526e673a793f07a5a5341bcc1b03c0121f476 in cordova-plugin-battery-status's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=c2a526e ] Merge pull request #31 from Geotab/CB-10645cordova-plugin-battery-status CB-10645 The battery status handler doesn't reinitialize on Android after window.location.reload() > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-battery-status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372888#comment-16372888 ] ASF GitHub Bot commented on CB-10645: - jcesarmobile closed pull request #31: CB-10645 The battery status handler doesn't reinitialize on Android after window.location.reload() URL: https://github.com/apache/cordova-plugin-battery-status/pull/31 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/src/android/BatteryListener.java b/src/android/BatteryListener.java index 740a92e..8814d9e 100755 --- a/src/android/BatteryListener.java +++ b/src/android/BatteryListener.java @@ -57,8 +57,7 @@ public BatteryListener() { public boolean execute(String action, JSONArray args, CallbackContext callbackContext) { if (action.equals("start")) { if (this.batteryCallbackContext != null) { -callbackContext.error( "Battery listener already running."); -return true; +removeBatteryListener(); } this.batteryCallbackContext = callbackContext; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-battery-status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15679602#comment-15679602 ] ASF GitHub Bot commented on CB-10645: - Github user colonelchlorine commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/31 Who manages @asfgit and accepts these pull requests? > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Battery Status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581827#comment-15581827 ] ASF GitHub Bot commented on CB-10645: - Github user SystemParadox commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/31 Any chance this could be merged soon? > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Battery Status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412495#comment-15412495 ] ASF GitHub Bot commented on CB-10645: - Github user colonelchlorine commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/31 What's the status on this? > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Battery Status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339575#comment-15339575 ] ASF GitHub Bot commented on CB-10645: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/31 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-battery-status/pull/31/commits/7d04d6dbaa0b67686facd460458f42a991b66ffb) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/24//PLATFORM=android/artifact/) | > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Battery Status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287575#comment-15287575 ] ASF GitHub Bot commented on CB-10645: - Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/31#issuecomment-219856145 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-battery-status/pull/31/commits/ff9fd62adf28686906ec009bf8604ab3be8fd9e2) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=windows-slave,platformName=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=windows-slave,platformName=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=windows-slave,platformName=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=windows-slave,platformName=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=windows-slave,platformName=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=windows-slave,platformName=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=windows-slave,platformName=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=windows-slave,platformName=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=windows-slave,platformName=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=windows-slave,platformName=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=windows-slave,platformName=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=windows-slave,platformName=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=mac-slave,platformName=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=mac-slave,platformName=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=mac-slave,platformName=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=mac-slave,platformName=ios/artifact/) | | [Android Mac]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=mac-slave,platformName=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=mac-slave,platformName=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=mac-slave,platformName=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/6//label=mac-slave,platformName=android/artifact/) | > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Battery Status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287552#comment-15287552 ] ASF GitHub Bot commented on CB-10645: - Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/31#issuecomment-219853851 Let there be tests > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Battery Status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285229#comment-15285229 ] ASF GitHub Bot commented on CB-10645: - Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/31#issuecomment-219537703 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-battery-status/pull/31/commits/ff9fd62adf28686906ec009bf8604ab3be8fd9e2) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=windows-slave,platformName=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=windows-slave,platformName=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=windows-slave,platformName=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=windows-slave,platformName=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=windows-slave,platformName=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=windows-slave,platformName=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=windows-slave,platformName=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=windows-slave,platformName=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=windows-slave,platformName=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=windows-slave,platformName=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=windows-slave,platformName=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=windows-slave,platformName=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=mac-slave,platformName=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=mac-slave,platformName=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=mac-slave,platformName=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=mac-slave,platformName=ios/artifact/) | | [Android Mac]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=mac-slave,platformName=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=mac-slave,platformName=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=mac-slave,platformName=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=mac-slave,platformName=android/artifact/) | | [Android Windows]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=windows-slave,platformName=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=windows-slave,platformName=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=windows-slave,platformName=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status/2//label=windows-slave,platformName=android/artifact/) | > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Battery Status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152464#comment-15152464 ] ASF GitHub Bot commented on CB-10645: - Github user aaront commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/31#issuecomment-185781196 JIRA link: https://issues.apache.org/jira/browse/CB-10645 > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Battery Status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152447#comment-15152447 ] ASF GitHub Bot commented on CB-10645: - GitHub user aaront opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/31 CB-10645 The battery status handler doesn't reinitialize on Android after window.location.reload() Instead of throwing an error, rather remove the status handler and re-initialize. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Geotab/cordova-plugin-battery-status CB-10645cordova-plugin-battery-status Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-battery-status/pull/31.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #31 commit cddf8daefc07471a13405e4ff2b8fed4e1b378f8 Author: Aaron Toth Date: 2016-02-18T15:23:47Z The battery status handler doesn't reinitialize on Android after window.reload(). Instead of throwing an error, rather remove the status handler and re-initialize. > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Battery Status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org