[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2018-03-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408032#comment-16408032
 ] 

ASF GitHub Bot commented on CB-12766:
-

Simpler1 commented on issue #558: CB-12766 Consistently write JSON with 2 
spaces indentation
URL: https://github.com/apache/cordova-lib/pull/558#issuecomment-374963815
 
 
   @remcohaszing Perfect.  Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2018-03-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407995#comment-16407995
 ] 

ASF GitHub Bot commented on CB-12766:
-

remcohaszing commented on issue #558: CB-12766 Consistently write JSON with 2 
spaces indentation
URL: https://github.com/apache/cordova-lib/pull/558#issuecomment-374957671
 
 
   I think it has been cherry-picked manually. Anyway, it got into master. See 
https://github.com/apache/cordova-lib/commit/d244cf8442004f2780775cb16f0ac5454b056996


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2018-03-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407988#comment-16407988
 ] 

ASF GitHub Bot commented on CB-12766:
-

Simpler1 commented on issue #558: CB-12766 Consistently write JSON with 2 
spaces indentation
URL: https://github.com/apache/cordova-lib/pull/558#issuecomment-374955587
 
 
   Why was this pull request closed and not merged?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-10-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189204#comment-16189204
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user alexreg commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
Surely the whitespace settings should simply be maintained, like NPM/Yarn 
does? i.e. if it's already using tabs, keep tabs, and keep the number of spaces 
being used.


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-09-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179441#comment-16179441
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
There is also https://issues.apache.org/jira/browse/CB-13009, they are 
similar, not sure if duplicated


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-09-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179415#comment-16179415
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
here is an existing issue https://issues.apache.org/jira/browse/CB-12810


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-09-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179391#comment-16179391
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user janpio commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
@funkyvisions You might want to create a new issue for that instead of 
commenting on old ones.


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-09-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179098#comment-16179098
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user funkyvisions commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
I don't like that my original package.json and config.xml get overwritten.  
I manage them myself and have lots of comments in them to detail intricacies.  
I also group things together so that they make logical sense for me.  How can I 
get cordova to not touch these files?  I tried --nosave on prepare and "cordova 
config set autosave false".  Let me know if there is a better place we can have 
this discussion.  This is the only thread I found regarding the overwriting of 
the configuration files.


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-07-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090485#comment-16090485
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
Hey @G-Rath 

CB-12810 is very much still open :). 
https://issues.apache.org/jira/browse/CB-12810

Thanks for your comment. This is something we will hopefully get to soon.


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-07-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089132#comment-16089132
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user G-Rath commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
@stevengill I really agree with @uloco - Not only for the reason of 
consistent, but because the constant removal of the last line is picked up by 
VCSs, which can be really annoying. 

While you've attached uloco's comment to CB-12810, I've noticed that it's 
been marked as fixed. 

Because of the way the new line removal effects VCSs, I'd consider this a 
bug (even if a minor one).

While I'm happy to (and normally would just) file a bug report, since 
you've already commented on it, and there is technically an issue already for 
it, can I leave it in your hands to make sure this gets considered?

Thanks :)


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-06-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044028#comment-16044028
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user uloco commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
You should also keep the last line if it's empty in both, `package.json` 
and `config.xml`.
The [POSIX 
standard](http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206)
 defines a line like this:

> 3.206 Line
> A sequence of zero or more non-  characters plus a terminating 
 character.

A lot of us are developing on UNIX systems and are following this practice. 
It would be nice, if you could help us keeping it consistent.


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-06-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044008#comment-16044008
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user uloco commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
@stevengill Go for it. I don't have an account there...


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-06-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16043423#comment-16043423
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
@uloco want to add your comment to this issue: 
https://issues.apache.org/jira/browse/CB-12810


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-06-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042565#comment-16042565
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user uloco commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
When adding platforms or plugins, you also perform a config.xml rewrite. 
Will this merge affect config.xml indentation rewrites, too? I do use 2 space 
indentation everywhere. It would be nice if you could just get the default 
indentation for the file and use the present one. Is this possible or worked on 
anywhere else?


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-06-05 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038180#comment-16038180
 ] 

ASF subversion and git services commented on CB-12766:
--

Commit c3f6c9df1046e6609db0ff730a9be6f302d5 in cordova-common's branch 
refs/heads/master from [~remcohaszing]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=c3f6c9d ]

CB-12766 Consistently write JSON with 2 spaces indentation

JSON was written with 4 spaces indentation and even a tab at some
point. Most NodeJS tools write their JSON configuration with an
indentation of 2 spaces. Most notably npm does this, which writes to
package.json, as does Cordova. This caused unnecessary changes in
package.json.

 This closes #558


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: cordova-next, easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-06-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035213#comment-16035213
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/558


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-06-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035212#comment-16035212
 ] 

ASF subversion and git services commented on CB-12766:
--

Commit d244cf8442004f2780775cb16f0ac5454b056996 in cordova-lib's branch 
refs/heads/master from [~remcohaszing]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=d244cf8 ]

CB-12766 Consistently write JSON with 2 spaces indentation

JSON was written with 4 spaces indentation and even a tab at some
point. Most NodeJS tools write their JSON configuration with an
indentation of 2 spaces. Most notably npm does this, which writes to
package.json, as does Cordova. This caused unnecessary changes in
package.json.

 This closes #558


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-06-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035214#comment-16035214
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
merged


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-06-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033892#comment-16033892
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
+1, let's merge this.


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-05-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018955#comment-16018955
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user mraerino commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
Is this going to be merged?
The current behavior really messes up my workflow.


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-05-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012797#comment-16012797
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user remcohaszing commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
@piotrowski I did a regex replace to replace all occurrences of 
`JSON.stringify`, so basically this affects all JSON files that are modified by 
Cordova.

I think this is a pretty complete list of the files affected:

- *.cordova/config.json*
- *plugins/fetch.json*
- *plugins/[platform].json*
- *package.json*


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-05-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012720#comment-16012720
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user piotrowski commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
Which files will this affect?


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-05-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012662#comment-16012662
 ] 

ASF GitHub Bot commented on CB-12766:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/558
  
really good point. We should switch to two like npm. 


> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-05-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011948#comment-16011948
 ] 

ASF GitHub Bot commented on CB-12766:
-

GitHub user remcohaszing opened a pull request:

https://github.com/apache/cordova-lib/pull/558

CB-12766 Consistently write JSON with 2 spaces indentation

### Platforms affected
None really.

### What does this PR do?
JSON was written with 4 spaces indentation and even a tab at some
point. Most NodeJS tools write their JSON configuration with an
indentation of 2 spaces. Most notably npm does this, which writes to
package.json, as does Cordova. This caused unnecessary changes in
package.json.

### What testing has been done on this change?
None, this is mostly stylistic.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remcohaszing/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/558.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #558


commit 7431e36fee775f0383ad3c3dae396a2a95c4bc05
Author: Remco Haszing 
Date:   2017-05-16T07:58:54Z

CB-12766 Consistently write JSON with 2 spaces indentation

JSON was written with 4 spaces indentation and even a tab at some
point. Most NodeJS tools write their JSON configuration with an
indentation of 2 spaces. Most notably npm does this, which writes to
package.json, as does Cordova. This caused unnecessary changes in
package.json.




> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>Assignee: Kerri Shotts
>Priority: Minor
>  Labels: easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12766) Cordova CLI changes package.json indentation

2017-05-08 Thread Kerri Shotts (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000742#comment-16000742
 ] 

Kerri Shotts commented on CB-12766:
---

A quick search 
(https://github.com/apache/cordova-lib/search?utf8=✓=fs.writeFileSync+stringify=)
 reveals that there are several places where package.json is written out with 
four spaces instead of two. NPM itself doesn't respect spacing and always 
writes out two spaces, so we may as well follow.

> Cordova CLI changes package.json indentation
> 
>
> Key: CB-12766
> URL: https://issues.apache.org/jira/browse/CB-12766
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli, cordova-lib
>Affects Versions: 7.0.0
>Reporter: Remco Haszing
>  Labels: easy-fix
>
> While Cordova is busy adding platforms / plugins, it writes to package.json 
> several times. In this process the indentation of package.json alternates 
> between 2 and 4 spaces. The final result is an indentation of 4 spaces, which 
> conflicts with the indentation of 2 spaces that npm uses.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org