[jira] [Commented] (CB-8875) Splash screen no longer fades when FadeSplashScreen=true
[ https://issues.apache.org/jira/browse/CB-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944310#comment-14944310 ] ASF GitHub Bot commented on CB-8875: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/62 > Splash screen no longer fades when FadeSplashScreen=true > > > Key: CB-8875 > URL: https://issues.apache.org/jira/browse/CB-8875 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen >Reporter: Chris Karcher >Assignee: Jesse MacFadyen > > After upgrading to the latest version of the plugin with the fix for > [CB-8836], the splash screen in my iOS app no longer fades even though > FadeSplashScreen=true. > This is the commit that addresses CB-8836: > [https://github.com/apache/cordova-plugin-splashscreen/commit/559b300d29ba6eb2f951eb19b9bbf7ba9238a862] > I've found that wrapping the entire call to [UIView transitionWithView] with > a dispatch_async (rather than the individual animation and completion blocks) > fixes the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8875) Splash screen no longer fades when FadeSplashScreen=true
[ https://issues.apache.org/jira/browse/CB-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944308#comment-14944308 ] ASF subversion and git services commented on CB-8875: - Commit fb0764c528444a665dc611535935d784135ae808 in cordova-plugin-splashscreen's branch refs/heads/master from [~purplecabbage] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=fb0764c ] CB-8875 FadeSplashScreen was not fading > Splash screen no longer fades when FadeSplashScreen=true > > > Key: CB-8875 > URL: https://issues.apache.org/jira/browse/CB-8875 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen >Reporter: Chris Karcher >Assignee: Jesse MacFadyen > > After upgrading to the latest version of the plugin with the fix for > [CB-8836], the splash screen in my iOS app no longer fades even though > FadeSplashScreen=true. > This is the commit that addresses CB-8836: > [https://github.com/apache/cordova-plugin-splashscreen/commit/559b300d29ba6eb2f951eb19b9bbf7ba9238a862] > I've found that wrapping the entire call to [UIView transitionWithView] with > a dispatch_async (rather than the individual animation and completion blocks) > fixes the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8875) Splash screen no longer fades when FadeSplashScreen=true
[ https://issues.apache.org/jira/browse/CB-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944309#comment-14944309 ] ASF GitHub Bot commented on CB-8875: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/44 > Splash screen no longer fades when FadeSplashScreen=true > > > Key: CB-8875 > URL: https://issues.apache.org/jira/browse/CB-8875 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen >Reporter: Chris Karcher >Assignee: Jesse MacFadyen > > After upgrading to the latest version of the plugin with the fix for > [CB-8836], the splash screen in my iOS app no longer fades even though > FadeSplashScreen=true. > This is the commit that addresses CB-8836: > [https://github.com/apache/cordova-plugin-splashscreen/commit/559b300d29ba6eb2f951eb19b9bbf7ba9238a862] > I've found that wrapping the entire call to [UIView transitionWithView] with > a dispatch_async (rather than the individual animation and completion blocks) > fixes the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8875) Splash screen no longer fades when FadeSplashScreen=true
[ https://issues.apache.org/jira/browse/CB-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944255#comment-14944255 ] ASF GitHub Bot commented on CB-8875: GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/62 CB-8875 FadeSplashScreen was not fading fixes some weak/strong self identity + confidence issues You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-splashscreen CB-8875 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit fb0764c528444a665dc611535935d784135ae808 Author: Jesse MacFadyen Date: 2015-10-05T23:34:49Z CB-8875 FadeSplashScreen was not fading > Splash screen no longer fades when FadeSplashScreen=true > > > Key: CB-8875 > URL: https://issues.apache.org/jira/browse/CB-8875 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen >Reporter: Chris Karcher >Assignee: Jesse MacFadyen > > After upgrading to the latest version of the plugin with the fix for > [CB-8836], the splash screen in my iOS app no longer fades even though > FadeSplashScreen=true. > This is the commit that addresses CB-8836: > [https://github.com/apache/cordova-plugin-splashscreen/commit/559b300d29ba6eb2f951eb19b9bbf7ba9238a862] > I've found that wrapping the entire call to [UIView transitionWithView] with > a dispatch_async (rather than the individual animation and completion blocks) > fixes the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8875) Splash screen no longer fades when FadeSplashScreen=true
[ https://issues.apache.org/jira/browse/CB-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14700152#comment-14700152 ] ASF GitHub Bot commented on CB-8875: Github user idpaterson commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/44#issuecomment-131947531 Should the `createViews` and `destroyViews` calls (the entire if/else structure) be dispatched to the main thread as well? It seems that calling those off of the main thread could lead to unexpected behavior since they interact with views. > Splash screen no longer fades when FadeSplashScreen=true > > > Key: CB-8875 > URL: https://issues.apache.org/jira/browse/CB-8875 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen >Reporter: Chris Karcher > > After upgrading to the latest version of the plugin with the fix for > [CB-8836], the splash screen in my iOS app no longer fades even though > FadeSplashScreen=true. > This is the commit that addresses CB-8836: > [https://github.com/apache/cordova-plugin-splashscreen/commit/559b300d29ba6eb2f951eb19b9bbf7ba9238a862] > I've found that wrapping the entire call to [UIView transitionWithView] with > a dispatch_async (rather than the individual animation and completion blocks) > fixes the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8875) Splash screen no longer fades when FadeSplashScreen=true
[ https://issues.apache.org/jira/browse/CB-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645907#comment-14645907 ] Filipe commented on CB-8875: I will try it. Thanks Chris. > Splash screen no longer fades when FadeSplashScreen=true > > > Key: CB-8875 > URL: https://issues.apache.org/jira/browse/CB-8875 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen >Reporter: Chris Karcher > > After upgrading to the latest version of the plugin with the fix for > [CB-8836], the splash screen in my iOS app no longer fades even though > FadeSplashScreen=true. > This is the commit that addresses CB-8836: > [https://github.com/apache/cordova-plugin-splashscreen/commit/559b300d29ba6eb2f951eb19b9bbf7ba9238a862] > I've found that wrapping the entire call to [UIView transitionWithView] with > a dispatch_async (rather than the individual animation and completion blocks) > fixes the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8875) Splash screen no longer fades when FadeSplashScreen=true
[ https://issues.apache.org/jira/browse/CB-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643103#comment-14643103 ] Chris Karcher commented on CB-8875: --- No, my pull request hasn't been merged. I integrated the fix into my app by creating a public repo on github.com where the PR has been merged into master, and then doing a 'cordova plugin add http://path/to/repo.git' to source the plugin directly from the repo. If you want to clone my repo with the fix, it's available at: https://github.com/chrskrchr/cordova-plugin-splashscreen/commits/master > Splash screen no longer fades when FadeSplashScreen=true > > > Key: CB-8875 > URL: https://issues.apache.org/jira/browse/CB-8875 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen >Reporter: Chris Karcher > > After upgrading to the latest version of the plugin with the fix for > [CB-8836], the splash screen in my iOS app no longer fades even though > FadeSplashScreen=true. > This is the commit that addresses CB-8836: > [https://github.com/apache/cordova-plugin-splashscreen/commit/559b300d29ba6eb2f951eb19b9bbf7ba9238a862] > I've found that wrapping the entire call to [UIView transitionWithView] with > a dispatch_async (rather than the individual animation and completion blocks) > fixes the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8875) Splash screen no longer fades when FadeSplashScreen=true
[ https://issues.apache.org/jira/browse/CB-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643076#comment-14643076 ] Filipe commented on CB-8875: Hi I'm having the same problem. How can I use this fix? Is it merged? thanks > Splash screen no longer fades when FadeSplashScreen=true > > > Key: CB-8875 > URL: https://issues.apache.org/jira/browse/CB-8875 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen >Reporter: Chris Karcher > > After upgrading to the latest version of the plugin with the fix for > [CB-8836], the splash screen in my iOS app no longer fades even though > FadeSplashScreen=true. > This is the commit that addresses CB-8836: > [https://github.com/apache/cordova-plugin-splashscreen/commit/559b300d29ba6eb2f951eb19b9bbf7ba9238a862] > I've found that wrapping the entire call to [UIView transitionWithView] with > a dispatch_async (rather than the individual animation and completion blocks) > fixes the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8875) Splash screen no longer fades when FadeSplashScreen=true
[ https://issues.apache.org/jira/browse/CB-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502767#comment-14502767 ] Chris Karcher commented on CB-8875: --- Pull request submitted here: [https://github.com/apache/cordova-plugin-splashscreen/pull/44] > Splash screen no longer fades when FadeSplashScreen=true > > > Key: CB-8875 > URL: https://issues.apache.org/jira/browse/CB-8875 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen >Reporter: Chris Karcher > > After upgrading to the latest version of the plugin with the fix for > [CB-8836], the splash screen in my iOS app no longer fades even though > FadeSplashScreen=true. > This is the commit that addresses CB-8836: > [https://github.com/apache/cordova-plugin-splashscreen/commit/559b300d29ba6eb2f951eb19b9bbf7ba9238a862] > I've found that wrapping the entire call to [UIView transitionWithView] with > a dispatch_async (rather than the individual animation and completion blocks) > fixes the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8875) Splash screen no longer fades when FadeSplashScreen=true
[ https://issues.apache.org/jira/browse/CB-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502766#comment-14502766 ] ASF GitHub Bot commented on CB-8875: GitHub user chrskrchr opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/44 CB-8875 execute entire call to [UIView transitionWithView] on the main t... ...hread so that view fades as expected You can merge this pull request into a Git repository by running: $ git pull https://github.com/chrskrchr/cordova-plugin-splashscreen master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/44.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #44 commit e9cafeddce7d3d2f9312196894a8942e382b0773 Author: Chris Karcher Date: 2015-04-20T13:07:31Z CB-8875 execute entire call to [UIView transitionWithView] on the main thread so that view fades as expected > Splash screen no longer fades when FadeSplashScreen=true > > > Key: CB-8875 > URL: https://issues.apache.org/jira/browse/CB-8875 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin SplashScreen >Reporter: Chris Karcher > > After upgrading to the latest version of the plugin with the fix for > [CB-8836], the splash screen in my iOS app no longer fades even though > FadeSplashScreen=true. > This is the commit that addresses CB-8836: > [https://github.com/apache/cordova-plugin-splashscreen/commit/559b300d29ba6eb2f951eb19b9bbf7ba9238a862] > I've found that wrapping the entire call to [UIView transitionWithView] with > a dispatch_async (rather than the individual animation and completion blocks) > fixes the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
