[jira] [Commented] (CB-6010) CDVAssetLibraryFilesystem does not have URLforFilesystemPath

2014-02-11 Thread Ian Clelland (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13897967#comment-13897967
 ] 

Ian Clelland commented on CB-6010:
--

Thanks for tracking that down; I'm making some changes to 
CDVAssetLibraryFilesystem right now, and I'm definitely going to fix that.

I don't believe that the AssetLibrary assets can be simply mapped to a 
device-filesystem-path, so returning nil is probably the right thing to do.

I'll add that method to the protocol definition so that it will be very obvious 
if it isn't implemented in future filesystems as well.

 CDVAssetLibraryFilesystem does not have URLforFilesystemPath
 

 Key: CB-6010
 URL: https://issues.apache.org/jira/browse/CB-6010
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin File, Plugin File Transfer
Affects Versions: 3.3.0
 Environment: ios
Reporter: Claudius Coenen
Assignee: Ian Clelland

 when i try to {{FileTransfer.download(...)}} a file (code itself used to work 
 in 2.7) my app now crashes.
 Step-Debugging revealed, that in {{CDVFile#fileSystemURLforLocalPath}} _(Line 
 267)_ all available filesystems are tested. One of those appears to be a 
 {{CDVAssetLibraryFilesystem}} - which does not implement 
 {{URLforFilesystemPath}}
 I added a dummy {{URLforFilesystemPath}} wich just returns {{nil}}. This got 
 me around the crash, but now i'm stuck with a {{FILE_NOT_FOUND_ERR}}, which 
 is probably my own responsibility. But the aforementioned crash took me a 
 while to find.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (CB-6010) CDVAssetLibraryFilesystem does not have URLforFilesystemPath

2014-02-11 Thread Ian Clelland (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13897974#comment-13897974
 ] 

Ian Clelland commented on CB-6010:
--

Checking again; it's an optional method already; the error is in failing to 
check whether a particular filesystem object responds to it before sending it 
the message. I'll update that in CDVFile.m

 CDVAssetLibraryFilesystem does not have URLforFilesystemPath
 

 Key: CB-6010
 URL: https://issues.apache.org/jira/browse/CB-6010
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin File, Plugin File Transfer
Affects Versions: 3.3.0
 Environment: ios
Reporter: Claudius Coenen
Assignee: Ian Clelland

 when i try to {{FileTransfer.download(...)}} a file (code itself used to work 
 in 2.7) my app now crashes.
 Step-Debugging revealed, that in {{CDVFile#fileSystemURLforLocalPath}} _(Line 
 267)_ all available filesystems are tested. One of those appears to be a 
 {{CDVAssetLibraryFilesystem}} - which does not implement 
 {{URLforFilesystemPath}}
 I added a dummy {{URLforFilesystemPath}} wich just returns {{nil}}. This got 
 me around the crash, but now i'm stuck with a {{FILE_NOT_FOUND_ERR}}, which 
 is probably my own responsibility. But the aforementioned crash took me a 
 while to find.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (CB-6010) CDVAssetLibraryFilesystem does not have URLforFilesystemPath

2014-02-11 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898161#comment-13898161
 ] 

ASF subversion and git services commented on CB-6010:
-

Commit f24abdd94df624c51dfaf1a9cc73c44a8bde0eb3 in branch refs/heads/dev from 
[~iclelland]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=f24abdd ]

CB-6010: ios: Test filesystem plugins for presence of optional 
URLforFilesystemPath before calling


 CDVAssetLibraryFilesystem does not have URLforFilesystemPath
 

 Key: CB-6010
 URL: https://issues.apache.org/jira/browse/CB-6010
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin File, Plugin File Transfer
Affects Versions: 3.3.0
 Environment: ios
Reporter: Claudius Coenen
Assignee: Ian Clelland

 when i try to {{FileTransfer.download(...)}} a file (code itself used to work 
 in 2.7) my app now crashes.
 Step-Debugging revealed, that in {{CDVFile#fileSystemURLforLocalPath}} _(Line 
 267)_ all available filesystems are tested. One of those appears to be a 
 {{CDVAssetLibraryFilesystem}} - which does not implement 
 {{URLforFilesystemPath}}
 I added a dummy {{URLforFilesystemPath}} wich just returns {{nil}}. This got 
 me around the crash, but now i'm stuck with a {{FILE_NOT_FOUND_ERR}}, which 
 is probably my own responsibility. But the aforementioned crash took me a 
 while to find.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)