[jira] [Commented] (DRILL-5324) Provide simplified column reader/writer for use in tests
[
https://issues.apache.org/jira/browse/DRILL-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970693#comment-15970693
]
ASF GitHub Bot commented on DRILL-5324:
---
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/783
Done. Also rebased on master.
> Provide simplified column reader/writer for use in tests
>
>
> Key: DRILL-5324
> URL: https://issues.apache.org/jira/browse/DRILL-5324
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Tools, Build & Test
>Affects Versions: 1.11.0
>Reporter: Paul Rogers
>Assignee: Paul Rogers
> Labels: ready-to-commit
> Fix For: 1.11.0
>
>
> In support of DRILL-5323, we wish to provide a very easy way to work with row
> sets. See the comment section for examples of the target API.
> Drill provides over 100 different value vectors, any of which may be required
> to perform a specific unit test. Creating these vectors, populating them, and
> retrieving values, is very tedious. The work is so complex that it acts to
> discourage developers from writing such tests.
> To simplify the task, we wish to provide a simplified row set reader and
> writer. To do that, we need to generate the corresponding column reader and
> writer for each value vector. This ticket focuses on the column-level readers
> and writers, and the required code generation.
> Drill already provides vector readers and writers derived from
> {{FieldReader}}. However, these readers do not provide a uniform get/set
> interface that is type independent on the application side. Instead,
> application code must be aware of the type of the vector, something we seek
> to avoid for test code.
> The reader and writer classes are designed to be used in many contexts, not
> just for testing. As a result, their implementation makes no assumptions
> about the broader row reader and writer, other than that a row index and the
> required value vector are both available.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DRILL-5324) Provide simplified column reader/writer for use in tests
[
https://issues.apache.org/jira/browse/DRILL-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970692#comment-15970692
]
ASF GitHub Bot commented on DRILL-5324:
---
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/783
@paul-rogers can you squash the commits for merging ?
> Provide simplified column reader/writer for use in tests
>
>
> Key: DRILL-5324
> URL: https://issues.apache.org/jira/browse/DRILL-5324
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Tools, Build & Test
>Affects Versions: 1.11.0
>Reporter: Paul Rogers
>Assignee: Paul Rogers
> Labels: ready-to-commit
> Fix For: 1.11.0
>
>
> In support of DRILL-5323, we wish to provide a very easy way to work with row
> sets. See the comment section for examples of the target API.
> Drill provides over 100 different value vectors, any of which may be required
> to perform a specific unit test. Creating these vectors, populating them, and
> retrieving values, is very tedious. The work is so complex that it acts to
> discourage developers from writing such tests.
> To simplify the task, we wish to provide a simplified row set reader and
> writer. To do that, we need to generate the corresponding column reader and
> writer for each value vector. This ticket focuses on the column-level readers
> and writers, and the required code generation.
> Drill already provides vector readers and writers derived from
> {{FieldReader}}. However, these readers do not provide a uniform get/set
> interface that is type independent on the application side. Instead,
> application code must be aware of the type of the vector, something we seek
> to avoid for test code.
> The reader and writer classes are designed to be used in many contexts, not
> just for testing. As a result, their implementation makes no assumptions
> about the broader row reader and writer, other than that a row index and the
> required value vector are both available.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DRILL-5424) Fix IOBE for reverse function
[
https://issues.apache.org/jira/browse/DRILL-5424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970690#comment-15970690
]
ASF GitHub Bot commented on DRILL-5424:
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/815
> Fix IOBE for reverse function
> -
>
> Key: DRILL-5424
> URL: https://issues.apache.org/jira/browse/DRILL-5424
> Project: Apache Drill
> Issue Type: Bug
> Components: Functions - Drill
>Affects Versions: 1.9.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Volodymyr Vysotskyi
>Priority: Minor
> Labels: ready-to-commit
> Fix For: 1.11.0
>
>
> Query with reverse function fails:
> {code:sql}
> 0: jdbc:drill:zk=local> select reverse(a) from dfs.`/tmp/test.json`;
> Error: SYSTEM ERROR: IndexOutOfBoundsException: index: 259, length: 1
> (expected: range(0, 256))
> {code}
> for table with several long varchars.
> {noformat}
> cat /tmp/test.json
> {"a": "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz"}
> {"a": "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz"}
> {"a": "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz"}
> {"a": "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz"}
> {"a": "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz"}
> {noformat}
> The same query works for the table with less row number:
> {code:sql}
> 0: jdbc:drill:zk=local> select reverse(a) from dfs.`/tmp/test2.json`;
> +---+
> |EXPR$0 |
> +---+
> | zyxwvutsrqponmlkjihgfedcbazyxwvutsrqponmlkjihgfedcba |
> | zyxwvutsrqponmlkjihgfedcbazyxwvutsrqponmlkjihgfedcba |
> | zyxwvutsrqponmlkjihgfedcbazyxwvutsrqponmlkjihgfedcba |
> | zyxwvutsrqponmlkjihgfedcbazyxwvutsrqponmlkjihgfedcba |
> +---+
> {code}
> {noformat}
> cat /tmp/test2.json
> {"a": "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz"}
> {"a": "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz"}
> {"a": "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz"}
> {"a": "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz"}
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (DRILL-5415) Improve Fixture Builder to configure client properties and keep collection type properties for server
[ https://issues.apache.org/jira/browse/DRILL-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970689#comment-15970689 ] ASF GitHub Bot commented on DRILL-5415: --- Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/807 > Improve Fixture Builder to configure client properties and keep collection > type properties for server > - > > Key: DRILL-5415 > URL: https://issues.apache.org/jira/browse/DRILL-5415 > Project: Apache Drill > Issue Type: Improvement > Components: Tools, Build & Test >Affects Versions: 1.11.0 >Reporter: Sorabh Hamirwasia >Assignee: Sorabh Hamirwasia >Priority: Minor > Labels: ready-to-commit > Fix For: 1.11.0 > > > There are 2 improvements which are made as part of this pull request. > 1) The Fixture Builder framework converts all the config properties for > Drillbit into string type. But there are certain configurations for > authentication (like auth.mechanism) which are expected to be list type. Thus > there will be failure during type check. Change to keep collections type > config value as is and insert those config value after string types are > inserted. > 2) The Fixture Builder framework when builds it tries to apply any system > options / session options (if set) for which it creates a default client. > Hence with cluster enabled for authentication this default client will not > provide any connection parameters for authentication and will fail to > connect. Allow Fixture Builder to accept client related properties as well so > that can be used while creating default client to connect to cluster. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5409) Update MapR version to 5.2.1-mapr
[ https://issues.apache.org/jira/browse/DRILL-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970688#comment-15970688 ] ASF GitHub Bot commented on DRILL-5409: --- Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/813 > Update MapR version to 5.2.1-mapr > - > > Key: DRILL-5409 > URL: https://issues.apache.org/jira/browse/DRILL-5409 > Project: Apache Drill > Issue Type: Bug > Components: Tools, Build & Test >Affects Versions: 1.11.0 >Reporter: Abhishek Girish >Assignee: Patrick Wong > Labels: ready-to-commit > Fix For: 1.11.0 > > > This if for the "mapr" profile. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5213) Prepared statement for actual query is missing the query text
[ https://issues.apache.org/jira/browse/DRILL-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970687#comment-15970687 ] ASF GitHub Bot commented on DRILL-5213: --- Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/812 > Prepared statement for actual query is missing the query text > - > > Key: DRILL-5213 > URL: https://issues.apache.org/jira/browse/DRILL-5213 > Project: Apache Drill > Issue Type: Bug > Components: Metadata >Affects Versions: 1.10.0 >Reporter: Krystal >Assignee: Vitalii Diravka > Labels: ready-to-commit > Fix For: 1.11.0 > > Attachments: fix.png, issue.png, sorting_issue.png > > > Prepared statement for actual query is missing the query text in the query's > profile. As a result, there is no link for the query profile from the UI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5409) Update MapR version to 5.2.1-mapr
[ https://issues.apache.org/jira/browse/DRILL-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970685#comment-15970685 ] ASF GitHub Bot commented on DRILL-5409: --- Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/813 +1 > Update MapR version to 5.2.1-mapr > - > > Key: DRILL-5409 > URL: https://issues.apache.org/jira/browse/DRILL-5409 > Project: Apache Drill > Issue Type: Bug > Components: Tools, Build & Test >Affects Versions: 1.11.0 >Reporter: Abhishek Girish >Assignee: Patrick Wong > Labels: ready-to-commit > Fix For: 1.11.0 > > > This if for the "mapr" profile. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DRILL-5415) Improve Fixture Builder to configure client properties and keep collection type properties for server
[ https://issues.apache.org/jira/browse/DRILL-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970684#comment-15970684 ] ASF GitHub Bot commented on DRILL-5415: --- Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/807 +1 > Improve Fixture Builder to configure client properties and keep collection > type properties for server > - > > Key: DRILL-5415 > URL: https://issues.apache.org/jira/browse/DRILL-5415 > Project: Apache Drill > Issue Type: Improvement > Components: Tools, Build & Test >Affects Versions: 1.11.0 >Reporter: Sorabh Hamirwasia >Assignee: Sorabh Hamirwasia >Priority: Minor > Labels: ready-to-commit > Fix For: 1.11.0 > > > There are 2 improvements which are made as part of this pull request. > 1) The Fixture Builder framework converts all the config properties for > Drillbit into string type. But there are certain configurations for > authentication (like auth.mechanism) which are expected to be list type. Thus > there will be failure during type check. Change to keep collections type > config value as is and insert those config value after string types are > inserted. > 2) The Fixture Builder framework when builds it tries to apply any system > options / session options (if set) for which it creates a default client. > Hence with cluster enabled for authentication this default client will not > provide any connection parameters for authentication and will fail to > connect. Allow Fixture Builder to accept client related properties as well so > that can be used while creating default client to connect to cluster. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
