[jira] [Commented] (DRILL-5213) Prepared statement for actual query is missing the query text

2017-04-18 Thread Vitalii Diravka (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972471#comment-15972471
 ] 

Vitalii Diravka commented on DRILL-5213:


Fixed in commit dfb5f4bb.

> Prepared statement for actual query is missing the query text
> -
>
> Key: DRILL-5213
> URL: https://issues.apache.org/jira/browse/DRILL-5213
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Metadata
>Affects Versions: 1.10.0
>Reporter: Krystal
>Assignee: Vitalii Diravka
>  Labels: ready-to-commit
> Fix For: 1.11.0
>
> Attachments: fix.png, issue.png, sorting_issue.png
>
>
> Prepared statement for actual query is missing the query text in the query's 
> profile.  As a result, there is no link for the query profile from the UI.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (DRILL-5213) Prepared statement for actual query is missing the query text

2017-04-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970687#comment-15970687
 ] 

ASF GitHub Bot commented on DRILL-5213:
---

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/812


> Prepared statement for actual query is missing the query text
> -
>
> Key: DRILL-5213
> URL: https://issues.apache.org/jira/browse/DRILL-5213
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Metadata
>Affects Versions: 1.10.0
>Reporter: Krystal
>Assignee: Vitalii Diravka
>  Labels: ready-to-commit
> Fix For: 1.11.0
>
> Attachments: fix.png, issue.png, sorting_issue.png
>
>
> Prepared statement for actual query is missing the query text in the query's 
> profile.  As a result, there is no link for the query profile from the UI.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (DRILL-5213) Prepared statement for actual query is missing the query text

2017-04-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964333#comment-15964333
 ] 

ASF GitHub Bot commented on DRILL-5213:
---

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/812
  
+1


> Prepared statement for actual query is missing the query text
> -
>
> Key: DRILL-5213
> URL: https://issues.apache.org/jira/browse/DRILL-5213
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Metadata
>Affects Versions: 1.10.0
>Reporter: Krystal
>Assignee: Vitalii Diravka
>  Labels: ready-to-commit
> Fix For: 1.11.0
>
> Attachments: fix.png, issue.png, sorting_issue.png
>
>
> Prepared statement for actual query is missing the query text in the query's 
> profile.  As a result, there is no link for the query profile from the UI.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (DRILL-5213) Prepared statement for actual query is missing the query text

2017-04-11 Thread Vitalii Diravka (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964281#comment-15964281
 ] 

Vitalii Diravka commented on DRILL-5213:


In the process of solving this task the issue of sorting finished queries in 
profiles was found. You can see it in the "sorting_issue.png" from the 
attachments. 
Fixed in context of this issue.



> Prepared statement for actual query is missing the query text
> -
>
> Key: DRILL-5213
> URL: https://issues.apache.org/jira/browse/DRILL-5213
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Metadata
>Affects Versions: 1.10.0
>Reporter: Krystal
>Assignee: Vitalii Diravka
> Attachments: fix.png, issue.png, sorting_issue.png
>
>
> Prepared statement for actual query is missing the query text in the query's 
> profile.  As a result, there is no link for the query profile from the UI.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (DRILL-5213) Prepared statement for actual query is missing the query text

2017-04-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964272#comment-15964272
 ] 

ASF GitHub Bot commented on DRILL-5213:
---

Github user vdiravka commented on a diff in the pull request:

https://github.com/apache/drill/pull/812#discussion_r110883871
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -540,6 +539,9 @@ private void runPreparedStatement(final 
PreparedStatementHandle preparedStatemen
 final String sql = serverState.getSqlQuery();
 logger.info("Prepared statement query for QueryId {} : {}", queryId, 
sql);
 runSQL(sql);
+
+// keep a query text of the preparedStatement for the queryManager
+queryText = sql;
--- End diff --

Deleted


> Prepared statement for actual query is missing the query text
> -
>
> Key: DRILL-5213
> URL: https://issues.apache.org/jira/browse/DRILL-5213
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Metadata
>Affects Versions: 1.10.0
>Reporter: Krystal
>Assignee: Vitalii Diravka
> Attachments: fix.png, issue.png, sorting_issue.png
>
>
> Prepared statement for actual query is missing the query text in the query's 
> profile.  As a result, there is no link for the query profile from the UI.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (DRILL-5213) Prepared statement for actual query is missing the query text

2017-04-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964273#comment-15964273
 ] 

ASF GitHub Bot commented on DRILL-5213:
---

Github user vdiravka commented on a diff in the pull request:

https://github.com/apache/drill/pull/812#discussion_r110881446
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java
 ---
@@ -1,4 +1,4 @@
-/**
+/*
--- End diff --

It is still used in one place


> Prepared statement for actual query is missing the query text
> -
>
> Key: DRILL-5213
> URL: https://issues.apache.org/jira/browse/DRILL-5213
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Metadata
>Affects Versions: 1.10.0
>Reporter: Krystal
>Assignee: Vitalii Diravka
> Attachments: fix.png, issue.png, sorting_issue.png
>
>
> Prepared statement for actual query is missing the query text in the query's 
> profile.  As a result, there is no link for the query profile from the UI.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (DRILL-5213) Prepared statement for actual query is missing the query text

2017-04-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964127#comment-15964127
 ] 

ASF GitHub Bot commented on DRILL-5213:
---

Github user arina-ielchiieva commented on a diff in the pull request:

https://github.com/apache/drill/pull/812#discussion_r110861166
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -540,6 +539,9 @@ private void runPreparedStatement(final 
PreparedStatementHandle preparedStatemen
 final String sql = serverState.getSqlQuery();
 logger.info("Prepared statement query for QueryId {} : {}", queryId, 
sql);
 runSQL(sql);
+
+// keep a query text of the preparedStatement for the queryManager
+queryText = sql;
--- End diff --

Temporary variable can be removed.


> Prepared statement for actual query is missing the query text
> -
>
> Key: DRILL-5213
> URL: https://issues.apache.org/jira/browse/DRILL-5213
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Metadata
>Affects Versions: 1.10.0
>Reporter: Krystal
>Assignee: Vitalii Diravka
>
> Prepared statement for actual query is missing the query text in the query's 
> profile.  As a result, there is no link for the query profile from the UI.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (DRILL-5213) Prepared statement for actual query is missing the query text

2017-04-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964125#comment-15964125
 ] 

ASF GitHub Bot commented on DRILL-5213:
---

Github user arina-ielchiieva commented on a diff in the pull request:

https://github.com/apache/drill/pull/812#discussion_r110861650
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java
 ---
@@ -1,4 +1,4 @@
-/**
+/*
--- End diff --

As far as I  understood, `final RunQuery runQuery` now is not used in 
`QueryManager`, it can be removed from class.


> Prepared statement for actual query is missing the query text
> -
>
> Key: DRILL-5213
> URL: https://issues.apache.org/jira/browse/DRILL-5213
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Metadata
>Affects Versions: 1.10.0
>Reporter: Krystal
>Assignee: Vitalii Diravka
>
> Prepared statement for actual query is missing the query text in the query's 
> profile.  As a result, there is no link for the query profile from the UI.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (DRILL-5213) Prepared statement for actual query is missing the query text

2017-04-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964126#comment-15964126
 ] 

ASF GitHub Bot commented on DRILL-5213:
---

Github user arina-ielchiieva commented on a diff in the pull request:

https://github.com/apache/drill/pull/812#discussion_r110863272
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -149,7 +148,7 @@
   private final boolean queuingEnabled;
 
 
-  private String queryText;
+  private String queryText = "";
--- End diff --

May be it's better to check queryText nullability in QueryManager.java then 
setting empty string as default?


> Prepared statement for actual query is missing the query text
> -
>
> Key: DRILL-5213
> URL: https://issues.apache.org/jira/browse/DRILL-5213
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Metadata
>Affects Versions: 1.10.0
>Reporter: Krystal
>Assignee: Vitalii Diravka
>
> Prepared statement for actual query is missing the query text in the query's 
> profile.  As a result, there is no link for the query profile from the UI.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (DRILL-5213) Prepared statement for actual query is missing the query text

2017-04-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963397#comment-15963397
 ] 

ASF GitHub Bot commented on DRILL-5213:
---

GitHub user vdiravka opened a pull request:

https://github.com/apache/drill/pull/812

DRILL-5213: Prepared statement for actual query is missing the query text



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vdiravka/drill DRILL-5213

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/812.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #812


commit adc9dad014961063b56644fca8ec8a040895b020
Author: Vitalii Diravka 
Date:   2017-04-10T18:54:21Z

DRILL-5213: Prepared statement for actual query is missing the query text




> Prepared statement for actual query is missing the query text
> -
>
> Key: DRILL-5213
> URL: https://issues.apache.org/jira/browse/DRILL-5213
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Metadata
>Affects Versions: 1.10.0
>Reporter: Krystal
>
> Prepared statement for actual query is missing the query text in the query's 
> profile.  As a result, there is no link for the query profile from the UI.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)