[GitHub] [flink] klion26 closed pull request #10902: [FLINK-13632][tests] Port ValueSerialzier upgrade tests to TypeSerializerUpgradeTestBaseUpdate
klion26 closed pull request #10902: [FLINK-13632][tests] Port ValueSerialzier upgrade tests to TypeSerializerUpgradeTestBaseUpdate URL: https://github.com/apache/flink/pull/10902 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] klion26 closed pull request #10905: run e2e test for pr 15637
klion26 closed pull request #10905: run e2e test for pr 15637 URL: https://github.com/apache/flink/pull/10905 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10970: [FLINK-15789][kubernetes] Do not wrap the InterruptedException and throw a different one in ActionWatcher.await
flinkbot edited a comment on issue #10970: [FLINK-15789][kubernetes] Do not wrap the InterruptedException and throw a different one in ActionWatcher.await URL: https://github.com/apache/flink/pull/10970#issuecomment-580116823 ## CI report: * d3bc38e0e541eba36972ff7ad63ed8c73137aafc Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146711098) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4667) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
flinkbot edited a comment on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900 ## CI report: * f769194571216372e83fdff8d9898fd693079498 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146711109) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4668) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-15339) Correct the terminology of "Time-windowed Join" to "Interval Join" in Table API & SQL
[ https://issues.apache.org/jira/browse/FLINK-15339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026482#comment-17026482 ] Timo Walther commented on FLINK-15339: -- Actually, the interval joins in DataStream API came after Table API but could not named like Table API because of legacy reasons. I don't have a strong opinion here. But we can do it for consistency. > Correct the terminology of "Time-windowed Join" to "Interval Join" in Table > API & SQL > - > > Key: FLINK-15339 > URL: https://issues.apache.org/jira/browse/FLINK-15339 > Project: Flink > Issue Type: Sub-task > Components: Documentation >Reporter: Jark Wu >Priority: Major > Fix For: 1.10.0 > > > Currently, in the docuementation, we call the joins with time conditions as > "Time-windowed Join". However, it is called "Interval Join" in DataStream. We > should align the terminology in Flink project. > From my point of view, "Interval Join" is more suitable, because it joins a > time interval range of right stream[1]. And "Windowed Join" should be joins > data in the same window, this is also described in DataStream API. > For Table API & SQL, the "Time-windowed Join" is the "Interval Join" in > DataStream. And we miss the new feature "Windowed Join" in Table API & SQL. > I propose to correct the terminology in docs before 1.10 is release. > [1]: > https://ci.apache.org/projects/flink/flink-docs-master/dev/stream/operators/joining.html#interval-join > [2]: > https://ci.apache.org/projects/flink/flink-docs-master/dev/stream/operators/joining.html#window-join -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot commented on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
flinkbot commented on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient URL: https://github.com/apache/flink/pull/10971#issuecomment-580116900 ## CI report: * f769194571216372e83fdff8d9898fd693079498 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10970: [FLINK-15789][kubernetes] Do not wrap the InterruptedException and throw a different one in ActionWatcher.await
flinkbot commented on issue #10970: [FLINK-15789][kubernetes] Do not wrap the InterruptedException and throw a different one in ActionWatcher.await URL: https://github.com/apache/flink/pull/10970#issuecomment-580116823 ## CI report: * d3bc38e0e541eba36972ff7ad63ed8c73137aafc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-15791) Don't use ForkJoinPool#commonPool() for executing asynchronous operations in Fabric8FlinkKubeClient
[
https://issues.apache.org/jira/browse/FLINK-15791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026474#comment-17026474
]
Yang Wang commented on FLINK-15791:
---
I think your concern is on point. I will fix it.
> Don't use ForkJoinPool#commonPool() for executing asynchronous operations in
> Fabric8FlinkKubeClient
> ---
>
> Key: FLINK-15791
> URL: https://issues.apache.org/jira/browse/FLINK-15791
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0, 1.10.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We should not use the {{ForkJoinPool#commonPool()}} in order to run
> asynchronous operations in the {{Fabric8FlinkKubeClient}} as it is done
> [here|https://github.com/apache/flink/blob/master/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java#L315].
> Since we don't know which other component is using this pool, it can be
> quite dangerous to use it as there might be congestion.
> Instead, I propose to provide an explicit I/O {{Executor}} which is used for
> running asynchronous operations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot commented on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
flinkbot commented on issue #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient URL: https://github.com/apache/flink/pull/10971#issuecomment-580111624 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit f769194571216372e83fdff8d9898fd693079498 (Thu Jan 30 07:02:03 UTC 2020) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15791).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-15791) Don't use ForkJoinPool#commonPool() for executing asynchronous operations in Fabric8FlinkKubeClient
[
https://issues.apache.org/jira/browse/FLINK-15791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-15791:
---
Labels: pull-request-available (was: )
> Don't use ForkJoinPool#commonPool() for executing asynchronous operations in
> Fabric8FlinkKubeClient
> ---
>
> Key: FLINK-15791
> URL: https://issues.apache.org/jira/browse/FLINK-15791
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0, 1.10.1
>
>
> We should not use the {{ForkJoinPool#commonPool()}} in order to run
> asynchronous operations in the {{Fabric8FlinkKubeClient}} as it is done
> [here|https://github.com/apache/flink/blob/master/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java#L315].
> Since we don't know which other component is using this pool, it can be
> quite dangerous to use it as there might be congestion.
> Instead, I propose to provide an explicit I/O {{Executor}} which is used for
> running asynchronous operations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] wangyang0918 opened a new pull request #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient
wangyang0918 opened a new pull request #10971: [FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient URL: https://github.com/apache/flink/pull/10971 ## What is the purpose of the change We should not use the ForkJoinPool#commonPool() in order to run asynchronous operations in the Fabric8FlinkKubeClient as it is done here. Since we don't know which other component is using this pool, it can be quite dangerous to use it as there might be congestion. Instead, I propose to provide an explicit I/O Executor which is used for running asynchronous operations. ## Brief change log * Use explicit I/O Executor for asynchronous operations in Fabric8FlinkKubeClient ## Verifying this change * All the tests should work well * Manually starting a Flink cluster on K8s ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (yes / no / don't know) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink-statefun] tzulitai closed pull request #4: Code of Conduct
tzulitai closed pull request #4: Code of Conduct URL: https://github.com/apache/flink-statefun/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on issue #4: Code of Conduct
tzulitai commented on issue #4: Code of Conduct URL: https://github.com/apache/flink-statefun/pull/4#issuecomment-580110259 Manually merged via 87788bd900fd9ff01e2a3767520bdec83c6f64cb. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-15789) ActionWatcher.await should throw InterruptedException
[
https://issues.apache.org/jira/browse/FLINK-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026467#comment-17026467
]
Yang Wang commented on FLINK-15789:
---
[~trohrmann] Thanks for reporting this issue. It makes sense to me. I will
attach a PR to fix it.
> ActionWatcher.await should throw InterruptedException
> -
>
> Key: FLINK-15789
> URL: https://issues.apache.org/jira/browse/FLINK-15789
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0, 1.10.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The {{ActionWatcher.await}} method should declare that it throws an
> {{InterruptedException}} instead of catching it, not resetting the
> interrupted flag and then throwing a different exception.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot commented on issue #10970: [FLINK-15789][kubernetes] Do not wrap the InterruptedException and throw a different one in ActionWatcher.await
flinkbot commented on issue #10970: [FLINK-15789][kubernetes] Do not wrap the InterruptedException and throw a different one in ActionWatcher.await URL: https://github.com/apache/flink/pull/10970#issuecomment-580107256 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit d3bc38e0e541eba36972ff7ad63ed8c73137aafc (Thu Jan 30 06:45:30 UTC 2020) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15789).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-15789) ActionWatcher.await should throw InterruptedException
[
https://issues.apache.org/jira/browse/FLINK-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-15789:
---
Labels: pull-request-available (was: )
> ActionWatcher.await should throw InterruptedException
> -
>
> Key: FLINK-15789
> URL: https://issues.apache.org/jira/browse/FLINK-15789
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0, 1.10.1
>
>
> The {{ActionWatcher.await}} method should declare that it throws an
> {{InterruptedException}} instead of catching it, not resetting the
> interrupted flag and then throwing a different exception.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] wangyang0918 opened a new pull request #10970: [FLINK-15789][kubernetes] Do not wrap the InterruptedException and throw a different one in ActionWatcher.await
wangyang0918 opened a new pull request #10970: [FLINK-15789][kubernetes] Do not wrap the InterruptedException and throw a different one in ActionWatcher.await URL: https://github.com/apache/flink/pull/10970 ## What is the purpose of the change The ActionWatcher.await method should declare that it throws an InterruptedException instead of catching it, not resetting the interrupted flag and then throwing a different exception. ## Brief change log * Throw InterruptedException in `ActionWatcher.await` ## Verifying this change * All the tests should work well * Manually starting a Flink cluster on K8s ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-8093) flink job fail because of kafka producer create fail of "javax.management.InstanceAlreadyExistsException"
[ https://issues.apache.org/jira/browse/FLINK-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026461#comment-17026461 ] Bastien DINE commented on FLINK-8093: - [~NicoK] I can handle it if you assign me this Jira I do agree with the client id based on operator, also maybe we could let the user overwrite it somehow Does it need to be backported on lower version ? > flink job fail because of kafka producer create fail of > "javax.management.InstanceAlreadyExistsException" > - > > Key: FLINK-8093 > URL: https://issues.apache.org/jira/browse/FLINK-8093 > Project: Flink > Issue Type: Bug > Components: Connectors / Kafka >Affects Versions: 1.3.2 > Environment: flink 1.3.2, kafka 0.9.1 >Reporter: dongtingting >Priority: Critical > > one taskmanager has multiple taskslot, one task fail because of create > kafkaProducer fail，the reason for create kafkaProducer fail is > “javax.management.InstanceAlreadyExistsException: > kafka.producer:type=producer-metrics,client-id=producer-3”。 the detail trace > is ： > 2017-11-04 19:41:23,281 INFO org.apache.flink.runtime.taskmanager.Task > - Source: Custom Source -> Filter -> Map -> Filter -> Sink: > dp_client_**_log (7/80) (99551f3f892232d7df5eb9060fa9940c) switched from > RUNNING to FAILED. > org.apache.kafka.common.KafkaException: Failed to construct kafka producer > at > org.apache.kafka.clients.producer.KafkaProducer.(KafkaProducer.java:321) > at > org.apache.kafka.clients.producer.KafkaProducer.(KafkaProducer.java:181) > at > org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducerBase.getKafkaProducer(FlinkKafkaProducerBase.java:202) > at > org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducerBase.open(FlinkKafkaProducerBase.java:212) > at > org.apache.flink.api.common.functions.util.FunctionUtils.openFunction(FunctionUtils.java:36) > at > org.apache.flink.streaming.api.operators.AbstractUdfStreamOperator.open(AbstractUdfStreamOperator.java:111) > at > org.apache.flink.streaming.runtime.tasks.StreamTask.openAllOperators(StreamTask.java:375) > at > org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:252) > at org.apache.flink.runtime.taskmanager.Task.run(Task.java:702) > at java.lang.Thread.run(Thread.java:745) > Caused by: org.apache.kafka.common.KafkaException: Error registering mbean > kafka.producer:type=producer-metrics,client-id=producer-3 > at > org.apache.kafka.common.metrics.JmxReporter.reregister(JmxReporter.java:159) > at > org.apache.kafka.common.metrics.JmxReporter.metricChange(JmxReporter.java:77) > at > org.apache.kafka.common.metrics.Metrics.registerMetric(Metrics.java:288) > at org.apache.kafka.common.metrics.Metrics.addMetric(Metrics.java:255) > at org.apache.kafka.common.metrics.Metrics.addMetric(Metrics.java:239) > at > org.apache.kafka.clients.producer.internals.RecordAccumulator.registerMetrics(RecordAccumulator.java:137) > at > org.apache.kafka.clients.producer.internals.RecordAccumulator.(RecordAccumulator.java:111) > at > org.apache.kafka.clients.producer.KafkaProducer.(KafkaProducer.java:261) > ... 9 more > Caused by: javax.management.InstanceAlreadyExistsException: > kafka.producer:type=producer-metrics,client-id=producer-3 > at com.sun.jmx.mbeanserver.Repository.addMBean(Repository.java:437) > at > com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerWithRepository(DefaultMBeanServerInterceptor.java:1898) > at > com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(DefaultMBeanServerInterceptor.java:966) > at > com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerObject(DefaultMBeanServerInterceptor.java:900) > at > com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:324) > at > com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522) > at > org.apache.kafka.common.metrics.JmxReporter.reregister(JmxReporter.java:157) > ... 16 more > I doubt that task in different taskslot of one taskmanager use different > classloader， and taskid may be the same in one process。 So this lead to > create kafkaProducer fail in one taskManager。 > Does anybody encountered the same problem？ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-13632) Port serializer upgrade tests to TypeSerializerUpgradeTestBase
[
https://issues.apache.org/jira/browse/FLINK-13632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026454#comment-17026454
]
Congxian Qiu(klion26) commented on FLINK-13632:
---
I'm on {{BaseTypeSerializerSnapshotMigrationTest}}.
> Port serializer upgrade tests to TypeSerializerUpgradeTestBase
> --
>
> Key: FLINK-13632
> URL: https://issues.apache.org/jira/browse/FLINK-13632
> Project: Flink
> Issue Type: Test
> Components: API / Type Serialization System, Tests
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Assignee: Aljoscha Krettek
>Priority: Critical
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> FLINK-11767 introduced a new test base ({{TypeSerializerUpgradeTestBase}})
> for writing serializer upgrade tests. Now we need to migrate all existing
> tests from {{TypeSerializerSnapshotMigrationTestBase}} to use the new test
> base and update them to restore from Flink 1.8 onward.
> It seems these are the subclasses:
> * TtlSerializerStateMigrationTest (org.apache.flink.runtime.state.ttl)
> * ValueSerializerMigrationTest (org.apache.flink.api.java.typeutils.runtime)
> * PrimitiveArraySerializerSnapshotMigrationTest
> (org.apache.flink.api.common.typeutils.base.array)
> * AvroSerializerMigrationTest (org.apache.flink.formats.avro.typeutils)
> * TupleSerializerMigrationTest (org.apache.flink.api.java.typeutils.runtime)
> * BufferEntrySerializerMigrationTest
> (org.apache.flink.streaming.api.operators.co)
> * TimerSerializerSnapshotMigrationTest
> (org.apache.flink.streaming.api.operators)
> * StreamElementSerializerMigrationTest
> (org.apache.flink.streaming.runtime.streamrecord)
> * KryoSnapshotMigrationTest (org.apache.flink.api.java.typeutils.runtime.kryo)
> * BaseTypeSerializerSnapshotMigrationTest
> (org.apache.flink.api.common.typeutils.base)
> * NullableSerializerMigrationTest
> (org.apache.flink.api.java.typeutils.runtime)
> * VoidNamespacieSerializerSnapshotMigrationTest
> (org.apache.flink.runtime.state)
> * ScalaOptionSerializerSnapshotMigrationTest
> (org.apache.flink.api.scala.typeutils)
> * ScalaTrySerializerSnapshotMigrationTest
> (org.apache.flink.api.scala.typeutils)
> * JavaSerializerSnapshotMigrationTest (org.apache.flink.runtime.state)
> * LockableTypeSerializerSnapshotMigrationTest
> (org.apache.flink.cep.nfa.sharedbuffer)
> * NFASerializerSnapshotsMigrationTest (org.apache.flink.cep)
> * WindowSerializerSnapshotsMigrationTest
> (org.apache.flink.streaming.runtime.operators.windowing)
> * UnionSerializerMigrationTest (org.apache.flink.streaming.api.datastream)
> * TwoPhaseCommitSinkStateSerializerMigrationTest
> (org.apache.flink.streaming.api.functions.sink)
> * KafkaSerializerSnapshotsMigrationTest
> (org.apache.flink.streaming.connectors.kafka)
> * KafkaSerializerSnapshotsMigrationTest
> (org.apache.flink.streaming.connectors.kafka)
> * RowSerializerMigrationTest (org.apache.flink.api.java.typeutils.runtime)
> * ValueArraySerializerSnapshotMigrationTest
> (org.apache.flink.graph.types.valuearray)
> * MapSerializerSnapshotMigrationTest
> (org.apache.flink.api.common.typeutils.base)
> * CompositeTypeSerializerSnapshotMigrationTest
> (org.apache.flink.api.common.typeutils)
> * ListSerializerSnapshotMigrationTest
> (org.apache.flink.api.common.typeutils.base)
> * EnumSerializerSnapshotMigrationTest
> (org.apache.flink.api.common.typeutils.base)
> * PojoSerializerSnapshotMigrationTest
> (org.apache.flink.api.java.typeutils.runtime)
> * ArrayListSerializerMigrationTest (org.apache.flink.runtime.state)
> * CopyableSerializerMigrationTest
> (org.apache.flink.api.java.typeutils.runtime)
> * WritableSerializerMigrationTest
> (org.apache.flink.api.java.typeutils.runtime)
> * ListViewSerializerSnapshotMigrationTest (org.apache.flink.table.dataview)
> * MapViewSerializerSnapshotMigrationTest (org.apache.flink.table.dataview)
> * ScalaEitherSerializerSnapshotMigrationTest
> (org.apache.flink.api.scala.typeutils)
> * LongValueWithProperHashCodeSerializerSnapshotMigrationTest
> (org.apache.flink.graph.drivers.transform)
> * ScalaCaseClassSerializerSnapshotMigrationTest
> (org.apache.flink.api.scala.typeutils)
> * TraversableSerializerSnapshotMigrationTest
> (org.apache.flink.api.scala.typeutils)
> * EnumValueSerializerSnapshotMigrationTest
> (org.apache.flink.api.scala.typeutils)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10969: [FLINK-15627] Correct the wrong naming of compareMaps in NFATestUtili…
flinkbot edited a comment on issue #10969: [FLINK-15627] Correct the wrong naming of compareMaps in NFATestUtili… URL: https://github.com/apache/flink/pull/10969#issuecomment-580074663 ## CI report: * 10ba831e9b773cc75cf4c254f53540b22129ff11 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146699535) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4666) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10969: [FLINK-15627] Correct the wrong naming of compareMaps in NFATestUtili…
flinkbot edited a comment on issue #10969: [FLINK-15627] Correct the wrong naming of compareMaps in NFATestUtili… URL: https://github.com/apache/flink/pull/10969#issuecomment-580074663 ## CI report: * 10ba831e9b773cc75cf4c254f53540b22129ff11 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146699535) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4666) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-15769) Allow configuring offset startup positions for Stateful Functions Kafka Ingress
[
https://issues.apache.org/jira/browse/FLINK-15769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-15769:
---
Labels: pull-request-available (was: )
> Allow configuring offset startup positions for Stateful Functions Kafka
> Ingress
> ---
>
> Key: FLINK-15769
> URL: https://issues.apache.org/jira/browse/FLINK-15769
> Project: Flink
> Issue Type: New Feature
> Components: Stateful Functions
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Tzu-Li (Gordon) Tai
>Priority: Major
> Labels: pull-request-available
>
> It is quite typical that a user is capable of setting where to start
> consuming a Kafka topic.
> Since the Stateful Functions Kafka ingress sits on top of Flink's Kafka
> consumer, there is already various options to start with:
> * {{GROUP_OFFSETS}} (default): start with whatever offsets were committed to
> Kafka for given {{group.id}}
> * {{LATEST}}: start from latest record in topic
> * {{EARLIEST}}: start from earliest record in topic
> * {{SPECIFIC_OFFSETS}}: provide a map of topic partition -> offset. This is
> particularly important for bootstrapped state scenarios, where the user would
> want to start from a specific position consistent with the state bootstrapped
> in their functions.
> * {{TIMESTAMP}}: start from offsets written starting from the given timestamp.
> The proposed API looks like so:
> {code}
> KafkaIngressBuilder builder = KafkaIngressBuilder.forIdentifier(...)
> .withTopic(...)
> .withDeserializer(...)
>
> .withDefaultStartPosition(KafkaIngressStartPosition.fromEarliest()/fromLatest())
>
> .withSpecificStartOffsets(KafkaIngressStartOffsets.fromMap(Map)/fromTimestamp(Long))
> {code}
> The {{withDefaultStartPosition}} method is straightforward.
> The reason to separate this from another {{withSpecificStartOffsets}} method
> is that there would be cases where some partition does not contain the
> offsets specified by {{withSpecificStartOffsets}}.
> In this case, the ingress would need to fallback to some default
> configuration; this would be the {{withDefaultStartPosition}} configuration.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink-statefun] tzulitai opened a new pull request #5: [FLINK-15769] [kafka-io] Add configuring startup position for Kafka ingress
tzulitai opened a new pull request #5: [FLINK-15769] [kafka-io] Add configuring startup position for Kafka ingress URL: https://github.com/apache/flink-statefun/pull/5 With this PR, the following options are now supported: * from committed consumer group offsets in Kafka * from earliest offset * from latest offset * from specific offsets * from offsets with ingestion timestamp >= specified date The changes simply expose configuration. Actual functionality is already implemented by the `FlinkKafkaConsumer`. The exposed configuration API is the following: ``` KafkaIngressBuilder builder = KafkaIngressBuilder.forIdentifier(...) .withStartupPosition(KafkaIngressStartupPosition.fromGroupOffsets()) .withStartupPosition(KafkaIngressStartupPosition.fromEarliest()) .withStartupPosition(KafkaIngressStartupPosition.fromLatest()) .withStartupPosition(KafkaIngressStartupPosition.fromSpecificOffsets(Map)) .withStartupPosition(KafkaIngressStartupPosition.fromDate(java.util.Date)) ``` --- Apart from the main changes, there are 3 additional preliminary changes: 7e8e522 Add named method for setting consumer group id `withConsumerGroupId(String)` to builder 8d09c39 Add named method for setting auto offset reset position 0982eec Move Kafka properties resolution from `KafkaSourceProvider` to builder The additional named methods makes sense, since they have an interplay with the startup position configs. For example, for `KafkaIngressStartupPosition.fromGroupOffsets()`, a consumer group id must be set. This is not provided as part of the `fromGroupOffsets` signature because consumer group ids have functionality beyond startup position (e.g., we may later introduce offset committing back to Kafka which also relies on a consumer group id being set). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10969: [FLINK-15627] Correct the wrong naming of compareMaps in NFATestUtili…
flinkbot edited a comment on issue #10969: [FLINK-15627] Correct the wrong naming of compareMaps in NFATestUtili… URL: https://github.com/apache/flink/pull/10969#issuecomment-580074663 ## CI report: * 10ba831e9b773cc75cf4c254f53540b22129ff11 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146699535) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4666) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-15809) component stack page needs to be updated for blink planner
[ https://issues.apache.org/jira/browse/FLINK-15809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026426#comment-17026426 ] Bowen Li commented on FLINK-15809: -- [~sjwiesman] Why dropping it? I think the page has been super useful, as least for me. Kurt and his team have had many talks on this topic, and have the update-to-date picture already, just need to update it. > component stack page needs to be updated for blink planner > -- > > Key: FLINK-15809 > URL: https://issues.apache.org/jira/browse/FLINK-15809 > Project: Flink > Issue Type: Bug > Components: Documentation >Reporter: Bowen Li >Assignee: Jingsong Lee >Priority: Critical > Fix For: 1.10.0 > > > [https://ci.apache.org/projects/flink/flink-docs-master/internals/components.html] > needs to be updated to reflect latest stack components > > cc [~ykt836] [~jark] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot commented on issue #10969: [FLINK-15627] Correct the wrong naming of compareMaps in NFATestUtili…
flinkbot commented on issue #10969: [FLINK-15627] Correct the wrong naming of compareMaps in NFATestUtili… URL: https://github.com/apache/flink/pull/10969#issuecomment-580074663 ## CI report: * 10ba831e9b773cc75cf4c254f53540b22129ff11 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10969: [FLINK-15627] Correct the wrong naming of compareMaps in NFATestUtili…
flinkbot commented on issue #10969: [FLINK-15627] Correct the wrong naming of compareMaps in NFATestUtili… URL: https://github.com/apache/flink/pull/10969#issuecomment-580071414 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 10ba831e9b773cc75cf4c254f53540b22129ff11 (Thu Jan 30 03:51:43 UTC 2020) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15627).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-15627) Correct the wrong naming of compareMaps in NFATestUtilities
[ https://issues.apache.org/jira/browse/FLINK-15627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026418#comment-17026418 ] Ayush Saxena commented on FLINK-15627: -- Thanx [~tiemsn] for putting this up. Raised PR, Please help review!!! > Correct the wrong naming of compareMaps in NFATestUtilities > --- > > Key: FLINK-15627 > URL: https://issues.apache.org/jira/browse/FLINK-15627 > Project: Flink > Issue Type: Bug > Components: Library / CEP >Affects Versions: 1.9.1 >Reporter: shuai.xu >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The compareMaps in NFATestUtilities compare two lists in fact, so rename it > to compareLists may be better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-15627) Correct the wrong naming of compareMaps in NFATestUtilities
[ https://issues.apache.org/jira/browse/FLINK-15627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-15627: --- Labels: pull-request-available (was: ) > Correct the wrong naming of compareMaps in NFATestUtilities > --- > > Key: FLINK-15627 > URL: https://issues.apache.org/jira/browse/FLINK-15627 > Project: Flink > Issue Type: Bug > Components: Library / CEP >Affects Versions: 1.9.1 >Reporter: shuai.xu >Priority: Minor > Labels: pull-request-available > > The compareMaps in NFATestUtilities compare two lists in fact, so rename it > to compareLists may be better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] ayushtkn opened a new pull request #10969: [FLINK-15627] Correct the wrong naming of compareMaps in NFATestUtili…
ayushtkn opened a new pull request #10969: [FLINK-15627] Correct the wrong naming of compareMaps in NFATestUtili… URL: https://github.com/apache/flink/pull/10969 …ties ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)* ## Brief change log *(for example:)* - *The TaskInfo is stored in the blob store on job creation time as a persistent artifact* - *Deployments RPC transmits only the blob storage reference* - *TaskManagers retrieve the TaskInfo from the blob cache* ## Verifying this change *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (100MB)* - *Extended integration test for recovery after master (JobManager) failure* - *Added test that validates that TaskInfo is transferred only once across recoveries* - *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) - The serializers: (yes / no / don't know) - The runtime per-record code paths (performance sensitive): (yes / no / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know) - The S3 file system connector: (yes / no / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-15647) Support to set annotations for JM/TM Pods
[ https://issues.apache.org/jira/browse/FLINK-15647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Canbin Zheng updated FLINK-15647: - Fix Version/s: 1.11.0 > Support to set annotations for JM/TM Pods > - > > Key: FLINK-15647 > URL: https://issues.apache.org/jira/browse/FLINK-15647 > Project: Flink > Issue Type: Sub-task > Components: Deployment / Kubernetes >Reporter: Canbin Zheng >Priority: Major > Fix For: 1.11.0 > > > One can use either labels or annotations to attach metadata to Kubernetes > objects. Labels can be used to select objects and to find collections of > objects that satisfy certain conditions. In contrast, annotations are not > used to identify and select objects. The metadata in an annotation can be > small or large, structured or unstructured, and can include characters not > permitted by labels. > > [Kubernetes > Annotation|https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-15652) Support for imagePullSecrets k8s option
[ https://issues.apache.org/jira/browse/FLINK-15652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Canbin Zheng updated FLINK-15652: - Fix Version/s: 1.11.0 > Support for imagePullSecrets k8s option > --- > > Key: FLINK-15652 > URL: https://issues.apache.org/jira/browse/FLINK-15652 > Project: Flink > Issue Type: Sub-task > Components: Deployment / Kubernetes >Reporter: Canbin Zheng >Priority: Major > Labels: pull-request-available > Fix For: 1.11.0 > > Time Spent: 10m > Remaining Estimate: 0h > > It's likely that one would pull images from the private image registry, > credentials can be passed with the Pod specification through the > `imagePullSecrets` parameter, > which refers to the k8s secret by name. Implementation wise we expose a new > configuration option to the users and then pass it along to the K8S. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] zhengcanbin commented on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.
zhengcanbin commented on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option. URL: https://github.com/apache/flink/pull/10963#issuecomment-580066293 cc @wangyang0918 @TisonKun This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #10956: [FLINK-15646][client]Configurable K8s context support.
zhengcanbin commented on issue #10956: [FLINK-15646][client]Configurable K8s context support. URL: https://github.com/apache/flink/pull/10956#issuecomment-580066018 cc @wangyang0918 @TisonKun This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10968: [FLINK-9272][metrics][datadog] Rename counter type to count
flinkbot edited a comment on issue #10968: [FLINK-9272][metrics][datadog] Rename counter type to count URL: https://github.com/apache/flink/pull/10968#issuecomment-580036824 ## CI report: * 356838b1531c9111518f0dfd953785e02c50fc1f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146688450) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4665) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-15666) GPU scheduling support in Kubernetes mode
[ https://issues.apache.org/jira/browse/FLINK-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026407#comment-17026407 ] Canbin Zheng commented on FLINK-15666: -- Tkx [~karmagyz] . We do not have an internal implementation yet, does the 1.11 planning contain this exciting feature? > GPU scheduling support in Kubernetes mode > - > > Key: FLINK-15666 > URL: https://issues.apache.org/jira/browse/FLINK-15666 > Project: Flink > Issue Type: New Feature > Components: Deployment / Kubernetes >Reporter: Canbin Zheng >Priority: Major > > This is an umbrella ticket for work on GPU scheduling in Kubernetes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10968: [FLINK-9272][metrics][datadog] Rename counter type to count
flinkbot edited a comment on issue #10968: [FLINK-9272][metrics][datadog] Rename counter type to count URL: https://github.com/apache/flink/pull/10968#issuecomment-580036824 ## CI report: * 356838b1531c9111518f0dfd953785e02c50fc1f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146688450) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4665) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-15648) Support to configure request or limit for CPU requirement
[
https://issues.apache.org/jira/browse/FLINK-15648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026402#comment-17026402
]
Canbin Zheng commented on FLINK-15648:
--
Tkx [~ptmagic]. It seems that the CPU limit is a more advanced configuration
option than the CPU request, how about adding a new parameter
"kubernetes.jobmanager.cpu.limit" instead of
"kubernetes.jobmanager.pod.cpu.requests"? {color:#6a8759}
{color}
WDYT [~yangwang166]
> Support to configure request or limit for CPU requirement
> -
>
> Key: FLINK-15648
> URL: https://issues.apache.org/jira/browse/FLINK-15648
> Project: Flink
> Issue Type: New Feature
> Components: Deployment / Kubernetes
>Reporter: Canbin Zheng
>Priority: Major
>
> The current branch use kubernetes.xx.cpu to configure request and limit
> resource requirement for a Container, it's an important improvement to
> separate these two configurations, we can use kubernetes.xx.request.cpu and
> kubernetes.xx.limit.cpu to specify request and limit resource
> requirements.{color:#6a8759}
> {color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10968: [FLINK-9272][metrics][datadog] Rename counter type to count
flinkbot edited a comment on issue #10968: [FLINK-9272][metrics][datadog] Rename counter type to count URL: https://github.com/apache/flink/pull/10968#issuecomment-580036824 ## CI report: * 356838b1531c9111518f0dfd953785e02c50fc1f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146688450) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4665) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-15646) Configurable K8s context support
[
https://issues.apache.org/jira/browse/FLINK-15646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Canbin Zheng updated FLINK-15646:
-
Parent: FLINK-15788
Issue Type: Sub-task (was: New Feature)
> Configurable K8s context support
>
>
> Key: FLINK-15646
> URL: https://issues.apache.org/jira/browse/FLINK-15646
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Canbin Zheng
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0, 1.10.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> One would be forced to first {{kubectl config use-context }} to
> switch to the desired context if working with multiple K8S clusters or having
> multiple K8S "users" for interacting with the specified cluster, so it is an
> important improvement to add an option(kubernetes.context) for configuring
> arbitrary contexts when deploying a Flink cluster. If that option is not
> specified, then the current context in the config file would be used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-15646) Configurable K8s context support
[
https://issues.apache.org/jira/browse/FLINK-15646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Canbin Zheng updated FLINK-15646:
-
Fix Version/s: 1.10.1
1.11.0
> Configurable K8s context support
>
>
> Key: FLINK-15646
> URL: https://issues.apache.org/jira/browse/FLINK-15646
> Project: Flink
> Issue Type: New Feature
> Components: Deployment / Kubernetes
>Reporter: Canbin Zheng
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0, 1.10.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> One would be forced to first {{kubectl config use-context }} to
> switch to the desired context if working with multiple K8S clusters or having
> multiple K8S "users" for interacting with the specified cluster, so it is an
> important improvement to add an option(kubernetes.context) for configuring
> arbitrary contexts when deploying a Flink cluster. If that option is not
> specified, then the current context in the config file would be used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-15646) Configurable K8s context support
[
https://issues.apache.org/jira/browse/FLINK-15646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Canbin Zheng updated FLINK-15646:
-
Affects Version/s: 1.10.0
> Configurable K8s context support
>
>
> Key: FLINK-15646
> URL: https://issues.apache.org/jira/browse/FLINK-15646
> Project: Flink
> Issue Type: New Feature
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Canbin Zheng
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0, 1.10.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> One would be forced to first {{kubectl config use-context }} to
> switch to the desired context if working with multiple K8S clusters or having
> multiple K8S "users" for interacting with the specified cluster, so it is an
> important improvement to add an option(kubernetes.context) for configuring
> arbitrary contexts when deploying a Flink cluster. If that option is not
> specified, then the current context in the config file would be used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-15809) component stack page needs to be updated for blink planner
[ https://issues.apache.org/jira/browse/FLINK-15809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026362#comment-17026362 ] Seth Wiesman commented on FLINK-15809: -- I’d rather just drop the page all together > component stack page needs to be updated for blink planner > -- > > Key: FLINK-15809 > URL: https://issues.apache.org/jira/browse/FLINK-15809 > Project: Flink > Issue Type: Bug > Components: Documentation >Reporter: Bowen Li >Assignee: Jingsong Lee >Priority: Critical > Fix For: 1.10.0 > > > [https://ci.apache.org/projects/flink/flink-docs-master/internals/components.html] > needs to be updated to reflect latest stack components > > cc [~ykt836] [~jark] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot commented on issue #10968: [FLINK-9272][metrics][datadog] Rename counter type to count
flinkbot commented on issue #10968: [FLINK-9272][metrics][datadog] Rename counter type to count URL: https://github.com/apache/flink/pull/10968#issuecomment-580036824 ## CI report: * 356838b1531c9111518f0dfd953785e02c50fc1f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-13619) Update FlinkKafkaProducerMigrationOperatorTest to restore from 1.9 savepoint
[
https://issues.apache.org/jira/browse/FLINK-13619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026346#comment-17026346
]
vinoyang commented on FLINK-13619:
--
[~aljoscha] Thanks, filed an issue FLINK-15810 to track this work.
> Update FlinkKafkaProducerMigrationOperatorTest to restore from 1.9 savepoint
>
>
> Key: FLINK-13619
> URL: https://issues.apache.org/jira/browse/FLINK-13619
> Project: Flink
> Issue Type: Sub-task
> Components: Connectors / Kafka, Tests
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Assignee: vinoyang
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Update {{FlinkKafkaProducerMigrationOperatorTest}} to restore from 1.9
> savepoint.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (FLINK-15810) Add more description for FlinkKafkaProducerMigrationOperatorTest
vinoyang created FLINK-15810:
Summary: Add more description for
FlinkKafkaProducerMigrationOperatorTest
Key: FLINK-15810
URL: https://issues.apache.org/jira/browse/FLINK-15810
Project: Flink
Issue Type: Improvement
Components: Tests
Reporter: vinoyang
Currently, {{FlinkKafkaProducerMigrationOperatorTest}} is not friendly to the
developers who help to do the migration test. We can move this comment to the
doc of the {{FlinkKafkaProducerMigrationOperatorTest}} class.
Additionally, we can add more details about renaming the generated binary file
to the format {{kafka-0.11-migration-kafka-producer-flink-" + version +
"-snapshot}} that {{getOperatorSnapshotPath}} returned.
This will make it more friendly to developers.
More discussion please see
[here|https://issues.apache.org/jira/browse/FLINK-13619?focusedCommentId=17025811=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17025811].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot commented on issue #10968: [FLINK-9272][metrics][datadog] Rename counter type to count
flinkbot commented on issue #10968: [FLINK-9272][metrics][datadog] Rename counter type to count URL: https://github.com/apache/flink/pull/10968#issuecomment-580028848 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 356838b1531c9111518f0dfd953785e02c50fc1f (Thu Jan 30 00:30:55 UTC 2020) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-9272) DataDog API "counter" metric type is deprecated
[ https://issues.apache.org/jira/browse/FLINK-9272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9272: -- Labels: pull-request-available (was: ) > DataDog API "counter" metric type is deprecated > > > Key: FLINK-9272 > URL: https://issues.apache.org/jira/browse/FLINK-9272 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics >Affects Versions: 1.4.2 >Reporter: Elias Levy >Assignee: Jörn Kottmann >Priority: Major > Labels: pull-request-available > > It appears to have been replaced by the "count" metric type. > https://docs.datadoghq.com/developers/metrics/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] kottmann opened a new pull request #10968: [FLINK-9272][metrics][datadog] Rename counter type to count
kottmann opened a new pull request #10968: [FLINK-9272][metrics][datadog] Rename counter type to count URL: https://github.com/apache/flink/pull/10968 ## What is the purpose of the change The Datadog metric "counter" was renamed to "count". The "counter" type still works, but support for it might be removed one day by Datadog. To align the implementation with their latest documentation the type is renamed. ## Brief change log - Renamed metric type counter to count in Datadog metrics component ## Verifying this change - This change is already covered by existing tests in the Datadog metrics component. - Tested the change with Flink 1.9.1 by hand with one of my pipelines and Datadog (count is reported as before without the rename) ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FLINK-15809) component stack page needs to be updated for blink planner
Bowen Li created FLINK-15809: Summary: component stack page needs to be updated for blink planner Key: FLINK-15809 URL: https://issues.apache.org/jira/browse/FLINK-15809 Project: Flink Issue Type: Bug Components: Documentation Reporter: Bowen Li Assignee: Jingsong Lee Fix For: 1.10.0 [https://ci.apache.org/projects/flink/flink-docs-master/internals/components.html] needs to be updated to reflect latest stack components cc [~ykt836] [~jark] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10967: [FLINK-15694][docs] Remove HDFS Section of Configuration Page
flinkbot edited a comment on issue #10967: [FLINK-15694][docs] Remove HDFS Section of Configuration Page URL: https://github.com/apache/flink/pull/10967#issuecomment-579979248 ## CI report: * 1eed2715455232d75496fa345e4e9bc3079fface Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146668629) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4664) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10967: [FLINK-15694][docs] Remove HDFS Section of Configuration Page
flinkbot edited a comment on issue #10967: [FLINK-15694][docs] Remove HDFS Section of Configuration Page URL: https://github.com/apache/flink/pull/10967#issuecomment-579979248 ## CI report: * 1eed2715455232d75496fa345e4e9bc3079fface Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146668629) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4664) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10967: [FLINK-15694][docs] Remove HDFS Section of Configuration Page
flinkbot commented on issue #10967: [FLINK-15694][docs] Remove HDFS Section of Configuration Page URL: https://github.com/apache/flink/pull/10967#issuecomment-579979248 ## CI report: * 1eed2715455232d75496fa345e4e9bc3079fface UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10967: [FLINK-15694][docs] Remove HDFS Section of Configuration Page
flinkbot commented on issue #10967: [FLINK-15694][docs] Remove HDFS Section of Configuration Page URL: https://github.com/apache/flink/pull/10967#issuecomment-579968538 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 1eed2715455232d75496fa345e4e9bc3079fface (Wed Jan 29 21:29:40 UTC 2020) ✅no warnings Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-15694) Remove HDFS Section of Configuration Page
[ https://issues.apache.org/jira/browse/FLINK-15694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-15694: --- Labels: pull-request-available (was: ) > Remove HDFS Section of Configuration Page > - > > Key: FLINK-15694 > URL: https://issues.apache.org/jira/browse/FLINK-15694 > Project: Flink > Issue Type: Sub-task > Components: Documentation >Reporter: Stephan Ewen >Assignee: Bastien DINE >Priority: Major > Labels: pull-request-available > > The section "HDFS" is outdated (and flagged as such). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] bdine opened a new pull request #10967: [FLINK-15694][docs] Remove HDFS Section of Configuration Page
bdine opened a new pull request #10967: [FLINK-15694][docs] Remove HDFS Section of Configuration Page URL: https://github.com/apache/flink/pull/10967 ## What is the purpose of the change This pull request removes the deprecated HDFS Section in the ops/configuration page ## Brief change log HDFS Section was deprecated and needs to be removed ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] ayushtkn commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft().
ayushtkn commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft(). URL: https://github.com/apache/flink/pull/10966#issuecomment-579958721 @zentol I checked the descroption, if I eliminate the use of hasTimeLeft() and switch to timeLeftIfAny() in bunch of cases it would lead to unnecessary evaluations. And If I use hasTimeLeft() so what time to wait instead timeLeftIfAny()? To counter this only I used both together, I thought intent is to prevent negative value from being passed, seems the intent is something else? *Apologies for checkstyles, I thought all Apache projects have same rules, so assumed it would go same here, which wasn't the case. :( This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zentol closed pull request #10966: FLINK-15740. Remove Deadline#timeLeft().
zentol closed pull request #10966: FLINK-15740. Remove Deadline#timeLeft(). URL: https://github.com/apache/flink/pull/10966 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zentol commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft().
zentol commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft(). URL: https://github.com/apache/flink/pull/10966#issuecomment-579951423 CI is failing due to checkstyle violations, and _literally_ every single line was modified incorrectly. The JIRA description was very specific on how existing usages should be changed. Please read the description again, try to understand the underlying problem, and have another go at it. (hint: if you use `timeleftIfAny()`, you shouldn't use `hasTimeLeft()` in a surrounding condition) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10966: FLINK-15740. Remove Deadline#timeLeft().
flinkbot edited a comment on issue #10966: FLINK-15740. Remove Deadline#timeLeft(). URL: https://github.com/apache/flink/pull/10966#issuecomment-579929854 ## CI report: * af6ca7d14c5fe80360b195ef0c8df6a0f7eb2678 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146652328) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4663) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft().
flinkbot commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft(). URL: https://github.com/apache/flink/pull/10966#issuecomment-579929854 ## CI report: * af6ca7d14c5fe80360b195ef0c8df6a0f7eb2678 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-13369) Recursive closure cleaner ends up with stackOverflow in case of circular dependency
[
https://issues.apache.org/jira/browse/FLINK-13369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026144#comment-17026144
]
Andrew Roberts commented on FLINK-13369:
{code:scala}
import org.apache.flink.api.common.typeinfo.TypeInformation
import org.apache.flink.api.scala._
import org.apache.flink.streaming.api.functions.sink.SinkFunction
import org.apache.flink.streaming.api.functions.source.SourceFunction
import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
import scala.annotation.tailrec
object TestJob {
val jobName = "TestJob"
def input(n: Int) = {
@tailrec def inner(current: Int, acc: List[String]): List[String] = {
if (current > n) acc.reverse
else inner(current + 1, current.toString :: acc)
}
inner(0, Nil)
}
def main(args: Array[String]): Unit = {
val env = StreamExecutionEnvironment.getExecutionEnvironment
job(env, input(1))
env.execute(jobName)
}
def job[Record: TypeInformation](
env: StreamExecutionEnvironment,
input: List[Record]
) = {
val source = env.addSource(new Src(input))
source.addSink(new Sink[Record])
}
class Sink[Record] extends SinkFunction[Record] {
override def invoke(value: Record, context: SinkFunction.Context[_]) = ()
}
class Src[Record](in: List[Record]) extends SourceFunction[Record] {
def run(ctx: SourceFunction.SourceContext[Record]) =
in.foreach(ctx.collect)
def cancel() = ()
}
}
{code}
> Recursive closure cleaner ends up with stackOverflow in case of circular
> dependency
> ---
>
> Key: FLINK-13369
> URL: https://issues.apache.org/jira/browse/FLINK-13369
> Project: Flink
> Issue Type: Bug
>Affects Versions: 1.8.1, 1.9.0
>Reporter: David Morávek
>Assignee: David Morávek
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.2, 1.9.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft().
flinkbot commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft(). URL: https://github.com/apache/flink/pull/10966#issuecomment-579910536 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit af6ca7d14c5fe80360b195ef0c8df6a0f7eb2678 (Wed Jan 29 19:06:34 UTC 2020) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15740).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10847: [FLINK-15578][connectors/jdbc] implement exactly once JDBC sink
flinkbot edited a comment on issue #10847: [FLINK-15578][connectors/jdbc] implement exactly once JDBC sink URL: https://github.com/apache/flink/pull/10847#issuecomment-573933799 ## CI report: * 1f19ab63df12c2a0cbc75644a34bcab26c08d7f6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144244028) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4308) * 3e136166db3c3a2325a4014719ca011b4d162a4d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144279590) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4318) * 3c3f7e4329383accb9b940c950321e0c65bdc0b9 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144472473) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4358) * c3cffe7d4d81d49b62327a0fca7fc12bb412403c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145366488) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4538) * 21f8b53a2b914b3cfc5f2b284682e168522fedb7 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145779646) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4580) * 2a7d5e55530eb275ffb276cead3516f3da9623a8 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145886771) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4591) * f98852fdb3b64d694e4dcfd9510b6b65294f9ea6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145957582) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4605) * 62eee77afbff0cdabceffeab6e737633af15a4fc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146008560) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4615) * b2d552291f80b750912f037fc2a64698aa1dc34f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146599962) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4655) * 63956a5e617a61fe592dc6c5bb62e615392f9535 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146635456) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4661) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-15740) Remove Deadline#timeLeft()
[
https://issues.apache.org/jira/browse/FLINK-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026126#comment-17026126
]
Ayush Saxena commented on FLINK-15740:
--
Thanx [~chesnay] for the putting this up.
Have raised PR. [https://github.com/apache/flink/pull/10966]
Please help review!!!
> Remove Deadline#timeLeft()
> --
>
> Key: FLINK-15740
> URL: https://issues.apache.org/jira/browse/FLINK-15740
> Project: Flink
> Issue Type: Improvement
> Components: API / DataStream, Tests
>Reporter: Chesnay Schepler
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As shown in FLINK-13662, {{Deadline#timeLeft()}} is conceptually broken since
> there is no reliable way to call said method while ensuring that
> a) the value is non-negative (desired since most time-based APIs reject
> negative values)
> b) the value sign (+,-) corresponds to preceding calls to {{#hasTimeLeft()}}
>
> As a result any usage of the following form is unreliable and obfuscating
> error messages.
> {code:java}
> while (deadline.hasTimeLeft()) {
> doSomething(deadline.timeLeft());
> } {code}
>
> All existing usage should be migrate to either
> {code:java}
> while (deadline.hasTimeLeft()) {
> doSomething();
> } {code}
> or
> {code:java}
> while (true) {
> doSomething(deadline.timeLeftIfAny());
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-15740) Remove Deadline#timeLeft()
[
https://issues.apache.org/jira/browse/FLINK-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-15740:
---
Labels: pull-request-available (was: )
> Remove Deadline#timeLeft()
> --
>
> Key: FLINK-15740
> URL: https://issues.apache.org/jira/browse/FLINK-15740
> Project: Flink
> Issue Type: Improvement
> Components: API / DataStream, Tests
>Reporter: Chesnay Schepler
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
>
> As shown in FLINK-13662, {{Deadline#timeLeft()}} is conceptually broken since
> there is no reliable way to call said method while ensuring that
> a) the value is non-negative (desired since most time-based APIs reject
> negative values)
> b) the value sign (+,-) corresponds to preceding calls to {{#hasTimeLeft()}}
>
> As a result any usage of the following form is unreliable and obfuscating
> error messages.
> {code:java}
> while (deadline.hasTimeLeft()) {
> doSomething(deadline.timeLeft());
> } {code}
>
> All existing usage should be migrate to either
> {code:java}
> while (deadline.hasTimeLeft()) {
> doSomething();
> } {code}
> or
> {code:java}
> while (true) {
> doSomething(deadline.timeLeftIfAny());
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] ayushtkn opened a new pull request #10966: FLINK-15740. Remove Deadline#timeLeft().
ayushtkn opened a new pull request #10966: FLINK-15740. Remove Deadline#timeLeft(). URL: https://github.com/apache/flink/pull/10966 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
flinkbot edited a comment on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient URL: https://github.com/apache/flink/pull/10965#issuecomment-579875760 ## CI report: * b9cfbe9a770e773103b2ff37e4c23731dc54b208 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146635492) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4662) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10847: [FLINK-15578][connectors/jdbc] implement exactly once JDBC sink
flinkbot edited a comment on issue #10847: [FLINK-15578][connectors/jdbc] implement exactly once JDBC sink URL: https://github.com/apache/flink/pull/10847#issuecomment-573933799 ## CI report: * 1f19ab63df12c2a0cbc75644a34bcab26c08d7f6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144244028) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4308) * 3e136166db3c3a2325a4014719ca011b4d162a4d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144279590) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4318) * 3c3f7e4329383accb9b940c950321e0c65bdc0b9 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144472473) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4358) * c3cffe7d4d81d49b62327a0fca7fc12bb412403c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145366488) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4538) * 21f8b53a2b914b3cfc5f2b284682e168522fedb7 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145779646) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4580) * 2a7d5e55530eb275ffb276cead3516f3da9623a8 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145886771) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4591) * f98852fdb3b64d694e4dcfd9510b6b65294f9ea6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145957582) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4605) * 62eee77afbff0cdabceffeab6e737633af15a4fc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146008560) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4615) * b2d552291f80b750912f037fc2a64698aa1dc34f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146599962) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4655) * 63956a5e617a61fe592dc6c5bb62e615392f9535 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146635456) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4661) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
flinkbot edited a comment on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient URL: https://github.com/apache/flink/pull/10965#issuecomment-579875760 ## CI report: * b9cfbe9a770e773103b2ff37e4c23731dc54b208 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146635492) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4662) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster
flinkbot edited a comment on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster URL: https://github.com/apache/flink/pull/10964#issuecomment-579861664 ## CI report: * ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146630418) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4660) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10847: [FLINK-15578][connectors/jdbc] implement exactly once JDBC sink
flinkbot edited a comment on issue #10847: [FLINK-15578][connectors/jdbc] implement exactly once JDBC sink URL: https://github.com/apache/flink/pull/10847#issuecomment-573933799 ## CI report: * 1f19ab63df12c2a0cbc75644a34bcab26c08d7f6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144244028) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4308) * 3e136166db3c3a2325a4014719ca011b4d162a4d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144279590) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4318) * 3c3f7e4329383accb9b940c950321e0c65bdc0b9 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144472473) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4358) * c3cffe7d4d81d49b62327a0fca7fc12bb412403c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145366488) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4538) * 21f8b53a2b914b3cfc5f2b284682e168522fedb7 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145779646) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4580) * 2a7d5e55530eb275ffb276cead3516f3da9623a8 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145886771) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4591) * f98852fdb3b64d694e4dcfd9510b6b65294f9ea6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145957582) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4605) * 62eee77afbff0cdabceffeab6e737633af15a4fc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146008560) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4615) * b2d552291f80b750912f037fc2a64698aa1dc34f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146599962) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4655) * 63956a5e617a61fe592dc6c5bb62e615392f9535 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146635456) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4661) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10962: [hotfix][docs] Remove legacy mode from config options docs
flinkbot edited a comment on issue #10962: [hotfix][docs] Remove legacy mode from config options docs URL: https://github.com/apache/flink/pull/10962#issuecomment-579814450 ## CI report: * c7e7c03225b1e6cf99e310b8a77e0ac428c1e51e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146612031) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4657) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
flinkbot commented on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient URL: https://github.com/apache/flink/pull/10965#issuecomment-579875760 ## CI report: * b9cfbe9a770e773103b2ff37e4c23731dc54b208 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster
flinkbot edited a comment on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster URL: https://github.com/apache/flink/pull/10964#issuecomment-579861664 ## CI report: * ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146630418) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4660) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10435: [FLINK-13955][runtime] migrate ContinuousFileReaderOperator to the mailbox execution model
flinkbot edited a comment on issue #10435: [FLINK-13955][runtime] migrate ContinuousFileReaderOperator to the mailbox execution model URL: https://github.com/apache/flink/pull/10435#issuecomment-562048103 ## CI report: * d07737bd54c586aa87204c6ac298309f432cc06c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/139496045) * 1e3e2ff9f65ba15c64fa275fc8567b352eb21c5e Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/139712355) * 58350d6bdc50078b6b15ca70b9d832d3b35aded3 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/139795244) * 287209ff3f521e5fd03df1800ca6425ff6b5a191 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/140374178) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3398) * 53161ebd8667e4b01df1e31cf61e38f667c74a32 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/14060) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3479) * b7985f7c1d209fda5c9c05ab1ba16c9ef9e8c5fb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/140864128) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3539) * 8eff8ec051009be299234ffc8f2afcb6764a1186 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146473490) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4643) * 37198e4d40054bf076b8e53f2ffc24027ee2cc0c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146551712) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4646) * 28f9eef96938e13005b5106aa89e0a1afdfb4722 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146558623) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4648) * 80bddbc69d17ebb7a202bb12c6d7b4f6124bd59f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146580700) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4652) * b67aa24b28b0fdf3053def2bebaad56d3b27f64f UNKNOWN * 497f2a70e1c8ff056f8c398167da5cc6b5760c77 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146624350) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4659) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #10957: [FLINK-15697][docs] Move python options from general configuration page to table config options page
StephanEwen commented on issue #10957: [FLINK-15697][docs] Move python options from general configuration page to table config options page URL: https://github.com/apache/flink/pull/10957#issuecomment-579873416 Looks good, +1 Will merge this as part of the docs rework. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10847: [FLINK-15578][connectors/jdbc] implement exactly once JDBC sink
flinkbot edited a comment on issue #10847: [FLINK-15578][connectors/jdbc] implement exactly once JDBC sink URL: https://github.com/apache/flink/pull/10847#issuecomment-573933799 ## CI report: * 1f19ab63df12c2a0cbc75644a34bcab26c08d7f6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144244028) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4308) * 3e136166db3c3a2325a4014719ca011b4d162a4d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144279590) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4318) * 3c3f7e4329383accb9b940c950321e0c65bdc0b9 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144472473) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4358) * c3cffe7d4d81d49b62327a0fca7fc12bb412403c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145366488) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4538) * 21f8b53a2b914b3cfc5f2b284682e168522fedb7 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145779646) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4580) * 2a7d5e55530eb275ffb276cead3516f3da9623a8 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145886771) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4591) * f98852fdb3b64d694e4dcfd9510b6b65294f9ea6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145957582) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4605) * 62eee77afbff0cdabceffeab6e737633af15a4fc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146008560) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4615) * b2d552291f80b750912f037fc2a64698aa1dc34f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146599962) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4655) * 63956a5e617a61fe592dc6c5bb62e615392f9535 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-15808) Upgrade Parquet to version 1.11.0
[ https://issues.apache.org/jira/browse/FLINK-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026054#comment-17026054 ] Ismaël Mejía commented on FLINK-15808: -- Since this Parquet release depends on Avro 1.9.x maybe FLINK-12532 is a prerrequisite for user friendliness. > Upgrade Parquet to version 1.11.0 > - > > Key: FLINK-15808 > URL: https://issues.apache.org/jira/browse/FLINK-15808 > Project: Flink > Issue Type: Improvement > Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile) >Reporter: Ismaël Mejía >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FLINK-15808) Upgrade Parquet to version 1.11.0
Ismaël Mejía created FLINK-15808: Summary: Upgrade Parquet to version 1.11.0 Key: FLINK-15808 URL: https://issues.apache.org/jira/browse/FLINK-15808 Project: Flink Issue Type: Improvement Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile) Reporter: Ismaël Mejía -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FLINK-15737) Support Java 12
[ https://issues.apache.org/jira/browse/FLINK-15737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-15737. Fix Version/s: 1.11.0 Resolution: Fixed > Support Java 12 > --- > > Key: FLINK-15737 > URL: https://issues.apache.org/jira/browse/FLINK-15737 > Project: Flink > Issue Type: Sub-task > Components: Build System >Reporter: Chesnay Schepler >Assignee: Chesnay Schepler >Priority: Major > Fix For: 1.11.0 > > > Resolve issues occurring when using Flink with Java 12 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FLINK-15738) Bump powermock to 2.0.4
[
https://issues.apache.org/jira/browse/FLINK-15738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-15738.
Resolution: Fixed
master: 8699e03a3f7668b87893bc9f50236b197a0385b3
> Bump powermock to 2.0.4
> ---
>
> Key: FLINK-15738
> URL: https://issues.apache.org/jira/browse/FLINK-15738
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Kinesis, Tests
>Affects Versions: 1.11.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Kinesis tests are failing with a NullPointerException due to their
> {{Whitebox}} usages.
> We have to bump powermock from 2.0.2 to at least 2.0.4.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] zentol merged pull request #10958: [FLINK-15738][build] Bump powermock to 2.0.4
zentol merged pull request #10958: [FLINK-15738][build] Bump powermock to 2.0.4 URL: https://github.com/apache/flink/pull/10958 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10886: [FLINK-15623][checkstyle] Exclude target directory
zentol commented on a change in pull request #10886: [FLINK-15623][checkstyle] Exclude target directory URL: https://github.com/apache/flink/pull/10886#discussion_r372517329 ## File path: tools/maven/suppressions.xml ## @@ -32,13 +32,6 @@ under the License. - - - Review comment: those are part of the python streaming api we removed a long time ago. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10886: [FLINK-15623][checkstyle] Exclude target directory
zentol commented on a change in pull request #10886: [FLINK-15623][checkstyle] Exclude target directory URL: https://github.com/apache/flink/pull/10886#discussion_r372517329 ## File path: tools/maven/suppressions.xml ## @@ -32,13 +32,6 @@ under the License. - - - Review comment: those are for the python streaming api we removed a long time ago. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option.
flinkbot edited a comment on issue #10963: [FLINK-15652][Kubernetes] Support for imagePullSecrets k8s option. URL: https://github.com/apache/flink/pull/10963#issuecomment-579814507 ## CI report: * b687d5e1835912c7866547f19fe4aec7c1399433 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146612052) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4658) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10962: [hotfix][docs] Remove legacy mode from config options docs
flinkbot edited a comment on issue #10962: [hotfix][docs] Remove legacy mode from config options docs URL: https://github.com/apache/flink/pull/10962#issuecomment-579814450 ## CI report: * c7e7c03225b1e6cf99e310b8a77e0ac428c1e51e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146612031) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4657) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster
flinkbot commented on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster URL: https://github.com/apache/flink/pull/10964#issuecomment-579861664 ## CI report: * ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FLINK-15807) Document Java 11 support
Chesnay Schepler created FLINK-15807: Summary: Document Java 11 support Key: FLINK-15807 URL: https://issues.apache.org/jira/browse/FLINK-15807 Project: Flink Issue Type: Sub-task Components: Documentation, Project Website Reporter: Chesnay Schepler Assignee: Chesnay Schepler Fix For: 1.10.0 At several places we list Java 8 as the only supported Java version; we should Java 11 to the list. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10435: [FLINK-13955][runtime] migrate ContinuousFileReaderOperator to the mailbox execution model
flinkbot edited a comment on issue #10435: [FLINK-13955][runtime] migrate ContinuousFileReaderOperator to the mailbox execution model URL: https://github.com/apache/flink/pull/10435#issuecomment-562048103 ## CI report: * d07737bd54c586aa87204c6ac298309f432cc06c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/139496045) * 1e3e2ff9f65ba15c64fa275fc8567b352eb21c5e Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/139712355) * 58350d6bdc50078b6b15ca70b9d832d3b35aded3 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/139795244) * 287209ff3f521e5fd03df1800ca6425ff6b5a191 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/140374178) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3398) * 53161ebd8667e4b01df1e31cf61e38f667c74a32 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/14060) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3479) * b7985f7c1d209fda5c9c05ab1ba16c9ef9e8c5fb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/140864128) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3539) * 8eff8ec051009be299234ffc8f2afcb6764a1186 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146473490) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4643) * 37198e4d40054bf076b8e53f2ffc24027ee2cc0c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146551712) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4646) * 28f9eef96938e13005b5106aa89e0a1afdfb4722 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146558623) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4648) * 80bddbc69d17ebb7a202bb12c6d7b4f6124bd59f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146580700) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4652) * b67aa24b28b0fdf3053def2bebaad56d3b27f64f UNKNOWN * 497f2a70e1c8ff056f8c398167da5cc6b5760c77 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10886: [FLINK-15623][checkstyle] Exclude target directory
tillrohrmann commented on a change in pull request #10886: [FLINK-15623][checkstyle] Exclude target directory URL: https://github.com/apache/flink/pull/10886#discussion_r372513419 ## File path: tools/maven/suppressions.xml ## @@ -32,13 +32,6 @@ under the License. - - - Review comment: Is it because these files are only in the `target` directory? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10886: [FLINK-15623][checkstyle] Exclude target directory
tillrohrmann commented on a change in pull request #10886: [FLINK-15623][checkstyle] Exclude target directory URL: https://github.com/apache/flink/pull/10886#discussion_r372513221 ## File path: tools/maven/suppressions.xml ## @@ -32,13 +32,6 @@ under the License. - - - Review comment: Why can we remove these suppressions? According to the comment, the Java Python files follow python naming conventions? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
flinkbot commented on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient URL: https://github.com/apache/flink/pull/10965#issuecomment-579858757 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit b9cfbe9a770e773103b2ff37e4c23731dc54b208 (Wed Jan 29 17:05:19 UTC 2020) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
tillrohrmann commented on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient URL: https://github.com/apache/flink/pull/10965#issuecomment-579858306 cc @wangyang0918 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] tillrohrmann opened a new pull request #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
tillrohrmann opened a new pull request #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient URL: https://github.com/apache/flink/pull/10965 ## What is the purpose of the change This commit reduces the log noise of the Fabric8FlinkKubeClient by changing the log level from info to debug. ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-15797) Reduce logging noise of Fabric8FlinkKubeClient
[
https://issues.apache.org/jira/browse/FLINK-15797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-15797:
---
Labels: pull-request-available usability (was: usability)
> Reduce logging noise of Fabric8FlinkKubeClient
> --
>
> Key: FLINK-15797
> URL: https://issues.apache.org/jira/browse/FLINK-15797
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
> Labels: pull-request-available, usability
> Fix For: 1.11.0, 1.10.1
>
>
> The {{Fabric8FlinkKubeClient}} logs a lot of information on log level
> {{INFO}}. I think some of the information is quite specific and is not needed
> by most users. In order to reduce the log noise for our users, I would
> suggest to only log the K8s resource specs on log level {{DEBUG}}. Also the
> handling of {{Watcher}} events does not need to be logged on {{INFO}} level.
> One could for example log that one creates a service with a given name on
> {{INFO}} and only include the specs if the log level is {{DEBUG}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FLINK-15695) Remove outdated section of Configuration Page
[ https://issues.apache.org/jira/browse/FLINK-15695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen reassigned FLINK-15695: Assignee: Stephan Ewen > Remove outdated section of Configuration Page > - > > Key: FLINK-15695 > URL: https://issues.apache.org/jira/browse/FLINK-15695 > Project: Flink > Issue Type: Sub-task > Components: Documentation >Reporter: Stephan Ewen >Assignee: Stephan Ewen >Priority: Major > Labels: usability > Fix For: 1.11.0 > > > Various sections contain outdated and redundant information. > As part of the cleanup, we would remove the following sections > - Remove outdated explanation above memory options (describes this as > referring mainly to managed memory and batch jobs) > - Remove section "Configuring TaskManager processing slots" and link to > Concepts Section instead. > - Remove section about "Configuring the Network Buffers" (subsumed by > memory configuration) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot commented on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster
flinkbot commented on issue #10964: [FLINK-15806][yarn] Log recommended way how to stop a detached Yarn session cluster URL: https://github.com/apache/flink/pull/10964#issuecomment-579855268 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit ca1a1bd8f2a853008dc6dbbeb088090f535b9e14 (Wed Jan 29 16:57:46 UTC 2020) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-15806) Update recommended way to shut down detached Yarn session cluster
[
https://issues.apache.org/jira/browse/FLINK-15806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-15806:
---
Labels: pull-request-available usability (was: usability)
> Update recommended way to shut down detached Yarn session cluster
> -
>
> Key: FLINK-15806
> URL: https://issues.apache.org/jira/browse/FLINK-15806
> Project: Flink
> Issue Type: Improvement
> Components: Deployment / YARN
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
> Labels: pull-request-available, usability
> Fix For: 1.11.0, 1.10.1
>
>
> When starting a Yarn session cluster in detached mode, then it is printed
> that one should shut down the cluster via {{yarn application -kill}}. The
> problem of this approach is, however, that temporary files won't be cleaned
> up which remain on HDFS. Hence, I think a better way would be to reconnect
> via the {{yarn-session.sh}} tool and then to stop the cluster gracefully.
> This won't leave orphaned files behind.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-15797) Reduce logging noise of Fabric8FlinkKubeClient
[
https://issues.apache.org/jira/browse/FLINK-15797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-15797:
--
Labels: usability (was: )
> Reduce logging noise of Fabric8FlinkKubeClient
> --
>
> Key: FLINK-15797
> URL: https://issues.apache.org/jira/browse/FLINK-15797
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
> Labels: usability
> Fix For: 1.11.0, 1.10.1
>
>
> The {{Fabric8FlinkKubeClient}} logs a lot of information on log level
> {{INFO}}. I think some of the information is quite specific and is not needed
> by most users. In order to reduce the log noise for our users, I would
> suggest to only log the K8s resource specs on log level {{DEBUG}}. Also the
> handling of {{Watcher}} events does not need to be logged on {{INFO}} level.
> One could for example log that one creates a service with a given name on
> {{INFO}} and only include the specs if the log level is {{DEBUG}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
