[jira] [Comment Edited] (FLINK-2099) Add a SQL API
[ https://issues.apache.org/jira/browse/FLINK-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098675#comment-15098675 ] chenliang613 edited comment on FLINK-2099 at 1/14/16 7:23 PM: -- Ya, TPC-DS has been widely used benchmark for SQL on Hadoop solutions. As my experience, supports the SQL syntax would be not big problem, but the performance would be the major challenges, please consider it more. Thanks Liang was (Author: chenliang613): Ya, TPC-DS should be widely used benchmark for SQL on Hadoop solutions. As my experience, supports the SQL syntax would be not big problem, but the performance would be the major challenges, please consider it more. Thanks Liang > Add a SQL API > - > > Key: FLINK-2099 > URL: https://issues.apache.org/jira/browse/FLINK-2099 > Project: Flink > Issue Type: New Feature > Components: Table API >Reporter: Timo Walther >Assignee: Timo Walther > Labels: requires-design-doc > > From the mailing list: > Fabian: Flink's Table API is pretty close to what SQL provides. IMO, the best > approach would be to leverage that and build a SQL parser (maybe together > with a logical optimizer) on top of the Table API. Parser (and optimizer) > could be built using Apache Calcite which is providing exactly this. > Since the Table API is still a fairly new component and not very feature > rich, it might make sense to extend and strengthen it before putting > something major on top. > Ted: It would also be relatively simple (I think) to retarget drill to Flink > if > Flink doesn't provide enough typing meta-data to do traditional SQL. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2099) Add a SQL API
[ https://issues.apache.org/jira/browse/FLINK-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098675#comment-15098675 ] chenliang613 commented on FLINK-2099: - Ya, TPC-DS should be widely used benchmark for SQL on Hadoop solutions. As my experience, supports the SQL syntax would be not big problem, but the performance would be the major challenges, please consider it more. Thanks Liang > Add a SQL API > - > > Key: FLINK-2099 > URL: https://issues.apache.org/jira/browse/FLINK-2099 > Project: Flink > Issue Type: New Feature > Components: Table API >Reporter: Timo Walther >Assignee: Timo Walther > Labels: requires-design-doc > > From the mailing list: > Fabian: Flink's Table API is pretty close to what SQL provides. IMO, the best > approach would be to leverage that and build a SQL parser (maybe together > with a logical optimizer) on top of the Table API. Parser (and optimizer) > could be built using Apache Calcite which is providing exactly this. > Since the Table API is still a fairly new component and not very feature > rich, it might make sense to extend and strengthen it before putting > something major on top. > Ted: It would also be relatively simple (I think) to retarget drill to Flink > if > Flink doesn't provide enough typing meta-data to do traditional SQL. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FLINK-2777) The description of programming_guide.html has some issues
chenliang613 created FLINK-2777: --- Summary: The description of programming_guide.html has some issues Key: FLINK-2777 URL: https://issues.apache.org/jira/browse/FLINK-2777 Project: Flink Issue Type: Bug Reporter: chenliang613 Assignee: chenliang613 Priority: Minor def createLocalEnvironment(parallelism: Int = Runtime.getRuntime.availableProcessors())) //issue1: In the end, there is a extra ")" def createRemoteEnvironment(host: String, port: String, jarFiles: String*) def createRemoteEnvironment(host: String, port: String, parallelism: Int, jarFiles: String*) //issue2: the parameter of port should be "Int", not "String" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FLINK-2777) The description of programming_guide.html has some issues
[ https://issues.apache.org/jira/browse/FLINK-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenliang613 updated FLINK-2777: Labels: (was: documentation) > The description of programming_guide.html has some issues > - > > Key: FLINK-2777 > URL: https://issues.apache.org/jira/browse/FLINK-2777 > Project: Flink > Issue Type: Bug > Components: Documentation > Reporter: chenliang613 >Assignee: chenliang613 >Priority: Minor > Fix For: 0.10 > > > def createLocalEnvironment(parallelism: Int = > Runtime.getRuntime.availableProcessors())) > //issue1: In the end, there is a extra ")" > def createRemoteEnvironment(host: String, port: String, jarFiles: String*) > def createRemoteEnvironment(host: String, port: String, parallelism: Int, > jarFiles: String*) > //issue2: the parameter of port should be "Int", not "String" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (FLINK-2537) Add scala examples.jar to build-target/examples
[ https://issues.apache.org/jira/browse/FLINK-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenliang613 closed FLINK-2537. --- Resolution: Not A Problem > Add scala examples.jar to build-target/examples > --- > > Key: FLINK-2537 > URL: https://issues.apache.org/jira/browse/FLINK-2537 > Project: Flink > Issue Type: Improvement > Components: Examples >Affects Versions: 0.10 >Reporter: chenliang613 > Assignee: chenliang613 >Priority: Minor > Labels: maven > Fix For: 0.10 > > > Currently Scala as functional programming language has been acknowledged by > more and more developers, some starters may want to modify scala examples' > code for further understanding flink mechanism. After changing scala > code,they may select this method to check result: > 1.go to "build-target/bin" start server > 2.use web UI to upload scala examples' jar > 3.this time they would get confusion, why changes would be not updated. > Because build-target/examples only copy java examples, suggest adding scala > examples also. > The new directory would like this : > build-target/examples/java > build-target/examples/scala -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FLINK-2777) The description of programming_guide.html has some issues
[ https://issues.apache.org/jira/browse/FLINK-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenliang613 updated FLINK-2777: Component/s: Documentation > The description of programming_guide.html has some issues > - > > Key: FLINK-2777 > URL: https://issues.apache.org/jira/browse/FLINK-2777 > Project: Flink > Issue Type: Bug > Components: Documentation > Reporter: chenliang613 >Assignee: chenliang613 >Priority: Minor > Labels: documentation > Fix For: 0.10 > > > def createLocalEnvironment(parallelism: Int = > Runtime.getRuntime.availableProcessors())) > //issue1: In the end, there is a extra ")" > def createRemoteEnvironment(host: String, port: String, jarFiles: String*) > def createRemoteEnvironment(host: String, port: String, parallelism: Int, > jarFiles: String*) > //issue2: the parameter of port should be "Int", not "String" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FLINK-2777) The description of programming_guide.html has some issues
[ https://issues.apache.org/jira/browse/FLINK-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenliang613 updated FLINK-2777: Fix Version/s: 0.10 > The description of programming_guide.html has some issues > - > > Key: FLINK-2777 > URL: https://issues.apache.org/jira/browse/FLINK-2777 > Project: Flink > Issue Type: Bug > Components: Documentation > Reporter: chenliang613 >Assignee: chenliang613 >Priority: Minor > Labels: documentation > Fix For: 0.10 > > > def createLocalEnvironment(parallelism: Int = > Runtime.getRuntime.availableProcessors())) > //issue1: In the end, there is a extra ")" > def createRemoteEnvironment(host: String, port: String, jarFiles: String*) > def createRemoteEnvironment(host: String, port: String, parallelism: Int, > jarFiles: String*) > //issue2: the parameter of port should be "Int", not "String" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FLINK-2777) The description of programming_guide.html has some issues
[ https://issues.apache.org/jira/browse/FLINK-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenliang613 updated FLINK-2777: Labels: documentation (was: ) > The description of programming_guide.html has some issues > - > > Key: FLINK-2777 > URL: https://issues.apache.org/jira/browse/FLINK-2777 > Project: Flink > Issue Type: Bug > Reporter: chenliang613 > Assignee: chenliang613 >Priority: Minor > Labels: documentation > > def createLocalEnvironment(parallelism: Int = > Runtime.getRuntime.availableProcessors())) > //issue1: In the end, there is a extra ")" > def createRemoteEnvironment(host: String, port: String, jarFiles: String*) > def createRemoteEnvironment(host: String, port: String, parallelism: Int, > jarFiles: String*) > //issue2: the parameter of port should be "Int", not "String" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink pull request: [FLINK-2777] The description of programming_gu...
GitHub user chenliang613 opened a pull request: https://github.com/apache/flink/pull/1193 [FLINK-2777] The description of programming_guide.html has some issues def createLocalEnvironment(parallelism: Int = Runtime.getRuntime.availableProcessors())) //issue1: In the end, there is a extra ")" def createRemoteEnvironment(host: String, port: String, jarFiles: String*) def createRemoteEnvironment(host: String, port: String, parallelism: Int, jarFiles: String*) //issue2: the parameter of port should be "Int", not "String" You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/flink patch-3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1193 commit fa28ab0c8484e97e269d4e4aef26937277d52552 Author: Liang Chen <chenliang...@huawei.com> Date: 2015-09-29T15:53:02Z [FLINK-2777] The description of programming_guide.html has some issues def createLocalEnvironment(parallelism: Int = Runtime.getRuntime.availableProcessors())) //issue1: In the end, there is a extra ")" def createRemoteEnvironment(host: String, port: String, jarFiles: String*) def createRemoteEnvironment(host: String, port: String, parallelism: Int, jarFiles: String*) //issue2: the parameter of port should be "Int", not "String" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2537] Add scala examples.jar to build-t...
Github user chenliang613 closed the pull request at: https://github.com/apache/flink/pull/1123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2537] Add scala examples.jar to build-t...
Github user chenliang613 commented on the pull request: https://github.com/apache/flink/pull/1123#issuecomment-141116565 ok,fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Comment Edited] (FLINK-2646) Rich functions should provide a method "closeAfterFailure()"
[
https://issues.apache.org/jira/browse/FLINK-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742379#comment-14742379
]
chenliang613 edited comment on FLINK-2646 at 9/13/15 8:02 AM:
--
@Stephan Ewen
1.Can you help me to quickly understand "The runtime is the changed to call
close() as part of the regular execution and closeAfterFailure() in case of an
irregular exit.".
2.Just i checked source code, the ChainedAllReduceDriver.java(one of runtime
Driver) already have cancelTask() method for irregular exit.
(ChainedFlatMapDriver,ChainedMapDriver etc. are same)
@Override
public void closeTask() throws Exception {
RegularPactTask.closeUserCode(this.reducer);
}
//chenliang613 remark: "RegularPactTask.closeUserCode(this.reducer)" also will
invoke "FunctionUtils.closeFunction(this.reducer)"
@Override
public void cancelTask() {
try {
FunctionUtils.closeFunction(this.reducer);
} catch (Throwable t) {
}
}
was (Author: chenliang613):
@Stephan Ewen
1.Can you help me to quickly understand "The runtime is the changed to call
close() as part of the regular execution and closeAfterFailure() in case of an
irregular exit.".
2.Just i checked source code, the ChainedAllReduceDriver(one of runtime Driver)
already have cancelTask() method for irregular exit.
@Override
public void closeTask() throws Exception {
RegularPactTask.closeUserCode(this.reducer);
}
//chenliang613 remark: "RegularPactTask.closeUserCode(this.reducer)" also will
invoke "FunctionUtils.closeFunction(this.reducer)"
@Override
public void cancelTask() {
try {
FunctionUtils.closeFunction(this.reducer);
} catch (Throwable t) {
}
}
> Rich functions should provide a method "closeAfterFailure()"
>
>
> Key: FLINK-2646
> URL: https://issues.apache.org/jira/browse/FLINK-2646
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.10
>Reporter: Stephan Ewen
>Assignee: chenliang613
> Fix For: 0.10
>
>
> Right now, the {{close()}} method of rich functions is invoked in case of
> proper completion, and in case of canceling in case of error (to allow for
> cleanup).
> In certain cases, the user function needs to know why it is closed, whether
> the task completed in a regular fashion, or was canceled/failed.
> I suggest to add a method {{closeAfterFailure()}} to the {{RichFunction}}. By
> default, this method calls {{close()}}. The runtime is the changed to call
> {{close()}} as part of the regular execution and {{closeAfterFailure()}} in
> case of an irregular exit.
> Because by default all cases call {{close()}} the change would not be API
> breaking.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] flink pull request: [FLINK-2537] Add scala examples.jar to build-t...
GitHub user chenliang613 opened a pull request: https://github.com/apache/flink/pull/1123 [FLINK-2537] Add scala examples.jar to build-target/examples Currently Scala as functional programming language has been acknowledged by more and more developers, some starters may want to modify scala examples' code for further understanding flink mechanism. After changing scala code,they may select the below steps to check result: 1.go to "build-target/bin" start server 2.use web UI to upload scala examples' jar 3.this time they would get confusion, why changes would be not updated. Because build-target/examples only copy java examples, suggest adding scala examples also. The new directory would like this : build-target/examples/java build-target/examples/scala You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/flink FLINK-2537 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1123.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1123 commit 5a6735ce8cdf1555714377dc94f6ad90c41673c3 Author: chenliang613 <chenliang...@huawei.com> Date: 2015-09-12T15:18:10Z FLINK-2537 Add scala examples.jar to build-target/examples --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
Github user chenliang613 commented on the pull request:
https://github.com/apache/flink/pull/1094#issuecomment-138276703
Just as maillist the last message mentioned:
http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/jira-FLINK-2493-Simplify-names-of-example-program-JARs-td7495.html.
After use the tag of "finalName" to replace classifier,
flink-scala-examples/flink-streaming-examples/flink-storm-compatibility-example"
can't correctly unpack "flink-java-examples-0.10-SNAPSHOT.jar", have the
below error:
[ERROR]
/Users/chenliang/flink/flink-examples/flink-scala-examples/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala:148:
error: not found: value KMeansData
[ERROR] val points = KMeansData.POINTS map {
[ERROR]^
[WARNING]
/Users/chenliang/flink/flink-examples/flink-scala-examples/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala:161:
warning: Type org.apache.flink.examples.scala.clustering.KMeans.Centroid is no
POJO, has immutable fields: value y, value x.
[WARNING] .map { x => new Centroid(x._1, x._2, x._3)}
[WARNING] ^
[ERROR]
/Users/chenliang/flink/flink-examples/flink-scala-examples/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala:164:
error: not found: value KMeansData
[ERROR] val centroids = KMeansData.CENTROIDS map {
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
Github user chenliang613 commented on the pull request: https://github.com/apache/flink/pull/1087#issuecomment-137744893 The CI failure be reported from flink-yarn-tests .but in my local machine, i did many times checking with "mvn clean verify" in flink-yarn-tests, all are successful. Tests run: 12, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 146.192 sec - in org.apache.flink.yarn.YARNSessionFIFOITCase Results : Tests run: 14, Failures: 0, Errors: 0, Skipped: 2 [INFO] [INFO] --- maven-failsafe-plugin:2.17:verify (default) @ flink-yarn-tests --- [INFO] Failsafe report directory: /Users/chenliang/flink/flink-yarn-tests/target/failsafe-reports [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 04:08 min [INFO] Finished at: 2015-09-04T21:52:47+08:00 [INFO] Final Memory: 36M/758M [INFO] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
GitHub user chenliang613 opened a pull request: https://github.com/apache/flink/pull/1094 [FLINK-2493] Simplify names of example program JARs The names of the example JARs under build-target/examples have some confusion, the version number might stop users from submitting examples to incompatible versions of Flink Propose to name the file examples/ConnectedComponents.jar rather than examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar. The result as below: build-target examples ConnectedComponents.jar EnumTrianglesBasic.jar EnumTrianglesOpt.jar .. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/flink FLINK-2493 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1094.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1094 commit edd1a1da2b81413e04de007f1655159cb709960a Author: chenliang613 <chenliang@chenliangdemacbook-pro.local> Date: 2015-09-05T01:16:53Z FLINK-2493 Simplify names of example program JARs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
Github user chenliang613 commented on the pull request: https://github.com/apache/flink/pull/1094#issuecomment-137896176 The implementation method may not the best solution. Actually i tried a couple of solutions(for example:use finalName tag to replace classifier),but because there having many dependency with java examples internally, "rename depended Jars" would generate too much influence for other programs, so selecting such change has least influence on the system :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
Github user chenliang613 closed the pull request at: https://github.com/apache/flink/pull/1087 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Flink 2493] Simplify names of example program...
Github user chenliang613 closed the pull request at: https://github.com/apache/flink/pull/1086 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
GitHub user chenliang613 opened a pull request: https://github.com/apache/flink/pull/1087 [FLINK-2493] Simplify names of example program JARs The names of the example JARs under build-target/examples have some confusion, the version number might stop users from submitting examples to incompatible versions of Flink Propose to name the file examples/ConnectedComponents.jar rather than examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/flink FLINK-2493 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1087.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1087 commit 20bb7420b9fad61b11a8bc9bc6423ac458235ec0 Author: CHEN LIANG <chenliang...@huawei.com> Date: 2015-09-02T19:24:56Z FLINK-2493 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Flink 2493] Simplify names of example program...
GitHub user chenliang613 opened a pull request: https://github.com/apache/flink/pull/1086 [Flink 2493] Simplify names of example program JARs The names of the example JARs under build-target/examples have some confusion, the version number might stop users from submitting examples to incompatible versions of Flink Propose to name the file examples/ConnectedComponents.jar rather than examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/flink FLINK-2493-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1086.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1086 commit 2ce1fff6a63b1243900b70bf80d22a9434956270 Author: chenliang613 <chenliang@chenliangdemacbook-pro.local> Date: 2015-09-02T17:24:24Z FLINK-2493 Simplify names of example program JARs commit 76fcd60d66dc7072b2d10ca9bac576961756ba6e Author: chenliang613 <chenliang@chenliangdemacbook-pro.local> Date: 2015-09-02T18:59:04Z FLINK-2493 commit aae20b93fbb337a21a716a02ceb188b31322dc66 Author: chenliang613 <chenliang@chenliangdemacbook-pro.local> Date: 2015-09-02T19:05:13Z FLINK-2493 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Flink 2493] Simplify names of example program...
GitHub user chenliang613 reopened a pull request: https://github.com/apache/flink/pull/1086 [Flink 2493] Simplify names of example program JARs The names of the example JARs under build-target/examples have some confusion, the version number might stop users from submitting examples to incompatible versions of Flink Propose to name the file examples/ConnectedComponents.jar rather than examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/flink FLINK-2493-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1086.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1086 commit 2ce1fff6a63b1243900b70bf80d22a9434956270 Author: chenliang613 <chenliang@chenliangdemacbook-pro.local> Date: 2015-09-02T17:24:24Z FLINK-2493 Simplify names of example program JARs commit 76fcd60d66dc7072b2d10ca9bac576961756ba6e Author: chenliang613 <chenliang@chenliangdemacbook-pro.local> Date: 2015-09-02T18:59:04Z FLINK-2493 commit aae20b93fbb337a21a716a02ceb188b31322dc66 Author: chenliang613 <chenliang@chenliangdemacbook-pro.local> Date: 2015-09-02T19:05:13Z FLINK-2493 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Flink 2493] Simplify names of example program...
Github user chenliang613 closed the pull request at: https://github.com/apache/flink/pull/1086 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
Github user chenliang613 closed the pull request at: https://github.com/apache/flink/pull/1068 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
Github user chenliang613 commented on the pull request: https://github.com/apache/flink/pull/1068#issuecomment-137098642 @StephanEwen yes. may use another solution :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
Github user chenliang613 commented on the pull request: https://github.com/apache/flink/pull/1068#issuecomment-135580675 @mbalassi OK, i will make changes for flink-streaming-examples and flink-storm-compatibility-example modules too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
GitHub user chenliang613 opened a pull request: https://github.com/apache/flink/pull/1068 [FLINK-2493] Simplify names of example program JARs The names of example JARs have a bit annoying, propose to replace examples/flinnk-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar with examples/ConnectedComponents.jar 1. Changing java and scala examples' pom.xml, set finalName to replace default name artifactId+version+classifer. 2.update quickstart doc which referring to examples You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/flink FLINK-2493 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1068.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1068 commit 741c846584936a8caca25269cf22cee4f0e3fa6e Author: unknown c00246...@szxy1c002460671.china.huawei.com Date: 2015-08-27T10:02:51Z [FLINK-2493] Simplify names of example program JARs commit 658ffad9e20a511c9c377fbf438c54521291ea50 Author: unknown c00246...@szxy1c002460671.china.huawei.com Date: 2015-08-27T10:12:15Z [FLINK-2493] Simplify names of example program JARs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...
Github user chenliang613 commented on the pull request: https://github.com/apache/flink/pull/1068#issuecomment-135591554 @StephanEwen sure! actually i did the verify operation at local machine. At my local machine's log msg showing: got reference jar(as below)from central repository of Maven,so it could build successfully. Downloading: http://repository.apache.org/snapshots/org/apache/flink/flink-java-examples/0.10-SNAPSHOT/flink-java-examples-0.10-20150827.224410-137.jar --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Some updates for programming_guide.md
Github user chenliang613 commented on the pull request: https://github.com/apache/flink/pull/1019#issuecomment-131911333 ok, done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Some updates for programming_guide.md
Github user chenliang613 closed the pull request at: https://github.com/apache/flink/pull/1019 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Some updates for programming_guide.md
GitHub user chenliang613 opened a pull request: https://github.com/apache/flink/pull/1019 Some updates for programming_guide.md Some updates for the section Program Skeleton of programming_guide.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/flink patch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1019.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1019 commit a0b17ead729511a856609a6ac80033d30f1dce71 Author: CHEN LIANG chenliang...@sina.cn Date: 2015-08-15T07:04:08Z Some updates for programming_guide.md Some updates for the section Program Skeleton of programming_guide.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Some updates for programming_guide.md
Github user chenliang613 commented on the pull request: https://github.com/apache/flink/pull/1019#issuecomment-131405427 ok, update the sockets part. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2314]
Github user chenliang613 commented on the pull request: https://github.com/apache/flink/pull/997#issuecomment-128926651 Thanks for your contribution. Suggestions: Please give a valid PR name. It would be useful if you could give more description about the PR, it could help to solve what issues? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
