[GitHub] [flink] huwh commented on a diff in pull request #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.
huwh commented on code in PR #22028: URL: https://github.com/apache/flink/pull/22028#discussion_r1160704473 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -1265,11 +1266,9 @@ private ApplicationReport startAppMaster( if (appState != lastAppState) { LOG.info("Deploying cluster, current state " + appState); } -if (System.currentTimeMillis() - lastLogTime > 6) { -lastLogTime = System.currentTimeMillis(); +if (System.currentTimeMillis() - startTime > 6) { LOG.info( -"Deployment took more than {} seconds. Please check if the requested resources are available in the YARN cluster", -(lastLogTime - startTime) / 1000); +"Deployment took more than 60 seconds. Please check if the requested resources are available in the YARN cluster"); Review Comment: @slfan1989 Never mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] huwh commented on a diff in pull request #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.
huwh commented on code in PR #22028: URL: https://github.com/apache/flink/pull/22028#discussion_r1147075029 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -1265,11 +1266,9 @@ private ApplicationReport startAppMaster( if (appState != lastAppState) { LOG.info("Deploying cluster, current state " + appState); } -if (System.currentTimeMillis() - lastLogTime > 6) { -lastLogTime = System.currentTimeMillis(); +if (System.currentTimeMillis() - startTime > 6) { LOG.info( -"Deployment took more than {} seconds. Please check if the requested resources are available in the YARN cluster", -(lastLogTime - startTime) / 1000); +"Deployment took more than 60 seconds. Please check if the requested resources are available in the YARN cluster"); Review Comment: @1996fanrui Thanks for your attention. This will print log in every loop(250 milliseconds) if JobManager not started in 60 seconds. We reduced the frequency of printing logs in https://issues.apache.org/jira/browse/FLINK-30517 If these changes are not expected, Should I submit a pr to fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] huwh commented on a diff in pull request #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.
huwh commented on code in PR #22028: URL: https://github.com/apache/flink/pull/22028#discussion_r1146026138 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -1265,11 +1266,9 @@ private ApplicationReport startAppMaster( if (appState != lastAppState) { LOG.info("Deploying cluster, current state " + appState); } -if (System.currentTimeMillis() - lastLogTime > 6) { -lastLogTime = System.currentTimeMillis(); +if (System.currentTimeMillis() - startTime > 6) { LOG.info( -"Deployment took more than {} seconds. Please check if the requested resources are available in the YARN cluster", -(lastLogTime - startTime) / 1000); +"Deployment took more than 60 seconds. Please check if the requested resources are available in the YARN cluster"); Review Comment: can i ask why do we need change this log report? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org