[GitHub] [flink-kubernetes-operator] gauravmiglanid11 commented on pull request #360: [FLINK-29165][docs] update docs to create and delete deployment via code
gauravmiglanid11 commented on PR #360: URL: https://github.com/apache/flink-kubernetes-operator/pull/360#issuecomment-1253296621 hi @morhidi , all checks passed, can you please merge it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-kubernetes-operator] gauravmiglanid11 commented on pull request #360: [FLINK-29165][docs] update docs to create and delete deployment via code
gauravmiglanid11 commented on PR #360: URL: https://github.com/apache/flink-kubernetes-operator/pull/360#issuecomment-1251287060 Hi @morhidi , changes done, please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-kubernetes-operator] gauravmiglanid11 commented on pull request #360: [FLINK-29165][docs] update docs to create and delete deployment via code
gauravmiglanid11 commented on PR #360: URL: https://github.com/apache/flink-kubernetes-operator/pull/360#issuecomment-1250380177 Hi @morhidi , changes done, please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-kubernetes-operator] gauravmiglanid11 commented on pull request #360: [FLINK-29165][docs] update docs to create and delete deployment via code
gauravmiglanid11 commented on PR #360: URL: https://github.com/apache/flink-kubernetes-operator/pull/360#issuecomment-1245460358 cool, @morhidi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-kubernetes-operator] gauravmiglanid11 commented on pull request #360: [FLINK-29165][docs] update docs to create and delete deployment via code
gauravmiglanid11 commented on PR #360: URL: https://github.com/apache/flink-kubernetes-operator/pull/360#issuecomment-1245086315 @morhidi code is done, please review and merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-kubernetes-operator] gauravmiglanid11 commented on pull request #360: [FLINK-29165][docs] update docs to create and delete deployment via code
gauravmiglanid11 commented on PR #360: URL: https://github.com/apache/flink-kubernetes-operator/pull/360#issuecomment-1243649208 Hi @morhidi, should i create another module in examples folder or write code example in flink-sql-runner-example, if yes, can you suggest me the name of module -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-kubernetes-operator] gauravmiglanid11 commented on pull request #360: [FLINK-29165][docs] update docs to create and delete deployment via code
gauravmiglanid11 commented on PR #360: URL: https://github.com/apache/flink-kubernetes-operator/pull/360#issuecomment-1242925511 that's a good idea, doing it thanks @morhidi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-kubernetes-operator] gauravmiglanid11 commented on pull request #360: [FLINK-29165][docs] update docs to create and delete deployment via code
gauravmiglanid11 commented on PR #360: URL: https://github.com/apache/flink-kubernetes-operator/pull/360#issuecomment-1242917191 hi @mbalassi , i didn't got your point, there is only one variable in my changes, i.e. flink version, do you want me to put it in config.toml file, and why `FlinkDeployment` version bumped is needed in the code example: are you talking about `flink.apache.org/v1beta1`. Please help me so that I can fix my PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
