[GitHub] flink pull request: [Flink-Gelly] [example] added missing assumpti...
Github user samk3211 commented on the pull request: https://github.com/apache/flink/pull/883#issuecomment-130632285 closed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Flink-Gelly] [example] added missing assumpti...
Github user samk3211 closed the pull request at: https://github.com/apache/flink/pull/883 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Flink-Gelly] [example] added missing assumpti...
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/883#issuecomment-130623223 I've actually included this in #1000. Could you close this PR @samk3211? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Flink-Gelly] [example] added missing assumpti...
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/883#issuecomment-130003492 I guess the only request that was not fulfilled for this PR was to squash the commits. Then it should be fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Flink-Gelly] [example] added missing assumpti...
Github user samk3211 closed the pull request at: https://github.com/apache/flink/pull/883 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Flink-Gelly] [example] added missing assumpti...
GitHub user samk3211 reopened a pull request: https://github.com/apache/flink/pull/883 [Flink-Gelly] [example] added missing assumption to the pageRank example: this is a simplified version of the algorithm so pages must have at least one incoming and one outgoing link You can merge this pull request into a Git repository by running: $ git pull https://github.com/samk3211/flink rank_doc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/883.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #883 commit f60ca610d5e9b1c2176a1592c4c769205dea7489 Author: Samia samia Date: 2015-07-02T11:40:16Z [Flink-Gelly] added missing assumption to the pageRank example: this is a simplified version of the algorithm so pages must have at least one incoming and one outgoing link commit 1b8f7b4ac9c0f4db5e40ef312cd0848d73b518bd Author: Samia samia Date: 2015-07-02T11:50:41Z [Flink-Gelly] added missing assumption to the pageRank example: this is a simplified version of the algorithm so pages must have at least one incoming and one outgoing link --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Flink-Gelly] [example] added missing assumpti...
GitHub user samk3211 opened a pull request: https://github.com/apache/flink/pull/883 [Flink-Gelly] [example] added missing assumption to the pageRank example: this is a simplified version of the algorithm so pages must have at least one incoming and one outgoing link You can merge this pull request into a Git repository by running: $ git pull https://github.com/samk3211/flink rank_doc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/883.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #883 commit f60ca610d5e9b1c2176a1592c4c769205dea7489 Author: Samia samia Date: 2015-07-02T11:40:16Z [Flink-Gelly] added missing assumption to the pageRank example: this is a simplified version of the algorithm so pages must have at least one incoming and one outgoing link commit 1b8f7b4ac9c0f4db5e40ef312cd0848d73b518bd Author: Samia samia Date: 2015-07-02T11:50:41Z [Flink-Gelly] added missing assumption to the pageRank example: this is a simplified version of the algorithm so pages must have at least one incoming and one outgoing link --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Flink-Gelly] [example] added missing assumpti...
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/883#issuecomment-118181248 Hi @samk3211! Thank you for spotting this :) Can you please (1) close #881, (2) add this comment also to GSAPageRank as @andralungu (3) squash your commits to a single one? Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---