[GitHub] flink pull request: [github] change tab size to 4 spaces
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1404 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [github] change tab size to 4 spaces
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1404#issuecomment-159652327 @rmetzger I was also wondering why and turns out we do ignore dot files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [github] change tab size to 4 spaces
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1404#issuecomment-159637898 +1 I wonder why the rat plugin accepts the file without apache license header. Are we ignoring dot files? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [github] change tab size to 4 spaces
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1404#issuecomment-159637645 Yes +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [github] change tab size to 4 spaces
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1404#issuecomment-159564917 Yes, please! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [github] change tab size to 4 spaces
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1404#issuecomment-159564852 This is very nice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [github] change tab size to 4 spaces
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1404 [github] change tab size to 4 spaces The default tab size on GitHub is 8 spaces. This change decreases the tab size to 4. I think this will make reviewing of code on GitHub easier. Left: tab size 4 Right: tab size 8 (status quo) https://cloud.githubusercontent.com/assets/837221/11393917/c4d651d6-9362-11e5-8ab6-c31cc47c927d.png";> You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink github-tabs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1404.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1404 commit 9a73b67dfa9d8d3b2d1122d33e722fc2cf44c436 Author: Maximilian Michels Date: 2015-11-25T09:36:03Z [github] change tab size to 4 spaces The default tab size on GitHub is 8 spaces. This change decreases the tab size to 4. I think this will make reviewing of code on GitHub much easier. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---