[jira] [Commented] (FLINK-8401) Allow subclass to override write-failure behavior in CassandraOutputFormat
[ https://issues.apache.org/jira/browse/FLINK-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365525#comment-16365525 ] ASF GitHub Bot commented on FLINK-8401: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5274 > Allow subclass to override write-failure behavior in CassandraOutputFormat > --- > > Key: FLINK-8401 > URL: https://issues.apache.org/jira/browse/FLINK-8401 > Project: Flink > Issue Type: Improvement > Components: Cassandra Connector >Reporter: Shuyi Chen >Assignee: Shuyi Chen >Priority: Major > > Currently it will throw an exception and fail the entire job, we would like > to keep the current default behavior, but refactor the code to allow subclass > to override and customize the failure handling. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8401) Allow subclass to override write-failure behavior in CassandraOutputFormat
[ https://issues.apache.org/jira/browse/FLINK-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365308#comment-16365308 ] ASF GitHub Bot commented on FLINK-8401: --- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5274 Looks good to me. Will merge this. > Allow subclass to override write-failure behavior in CassandraOutputFormat > --- > > Key: FLINK-8401 > URL: https://issues.apache.org/jira/browse/FLINK-8401 > Project: Flink > Issue Type: Improvement > Components: Cassandra Connector >Reporter: Shuyi Chen >Assignee: Shuyi Chen >Priority: Major > > Currently it will throw an exception and fail the entire job, we would like > to keep the current default behavior, but refactor the code to allow subclass > to override and customize the failure handling. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8401) Allow subclass to override write-failure behavior in CassandraOutputFormat
[ https://issues.apache.org/jira/browse/FLINK-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363087#comment-16363087 ] ASF GitHub Bot commented on FLINK-8401: --- Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/5274 @tillrohrmann , can you help take another look? > Allow subclass to override write-failure behavior in CassandraOutputFormat > --- > > Key: FLINK-8401 > URL: https://issues.apache.org/jira/browse/FLINK-8401 > Project: Flink > Issue Type: Improvement > Components: Cassandra Connector >Reporter: Shuyi Chen >Assignee: Shuyi Chen >Priority: Major > > Currently it will throw an exception and fail the entire job, we would like > to keep the current default behavior, but refactor the code to allow subclass > to override and customize the failure handling. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8401) Allow subclass to override write-failure behavior in CassandraOutputFormat
[ https://issues.apache.org/jira/browse/FLINK-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326818#comment-16326818 ] ASF GitHub Bot commented on FLINK-8401: --- Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/5274 Thanks a lot, @tillrohrmann . Added javadoc. Please take another look. > Allow subclass to override write-failure behavior in CassandraOutputFormat > --- > > Key: FLINK-8401 > URL: https://issues.apache.org/jira/browse/FLINK-8401 > Project: Flink > Issue Type: Improvement > Components: Cassandra Connector >Reporter: Shuyi Chen >Assignee: Shuyi Chen >Priority: Major > > Currently it will throw an exception and fail the entire job, we would like > to keep the current default behavior, but refactor the code to allow subclass > to override and customize the failure handling. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8401) Allow subclass to override write-failure behavior in CassandraOutputFormat
[ https://issues.apache.org/jira/browse/FLINK-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326815#comment-16326815 ] ASF GitHub Bot commented on FLINK-8401: --- Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/5274#discussion_r161672687 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java --- @@ -66,6 +66,13 @@ public void configure(Configuration parameters) { this.cluster = builder.getCluster(); } + protected void onWriteSuccess(ResultSet ignored) { --- End diff -- JavaDoc added. > Allow subclass to override write-failure behavior in CassandraOutputFormat > --- > > Key: FLINK-8401 > URL: https://issues.apache.org/jira/browse/FLINK-8401 > Project: Flink > Issue Type: Improvement > Components: Cassandra Connector >Reporter: Shuyi Chen >Assignee: Shuyi Chen >Priority: Major > > Currently it will throw an exception and fail the entire job, we would like > to keep the current default behavior, but refactor the code to allow subclass > to override and customize the failure handling. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8401) Allow subclass to override write-failure behavior in CassandraOutputFormat
[ https://issues.apache.org/jira/browse/FLINK-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326817#comment-16326817 ] ASF GitHub Bot commented on FLINK-8401: --- Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/5274#discussion_r161672700 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java --- @@ -66,6 +66,13 @@ public void configure(Configuration parameters) { this.cluster = builder.getCluster(); } + protected void onWriteSuccess(ResultSet ignored) { + } + + protected void onWriteFailure(Throwable t) { --- End diff -- JavaDoc added. > Allow subclass to override write-failure behavior in CassandraOutputFormat > --- > > Key: FLINK-8401 > URL: https://issues.apache.org/jira/browse/FLINK-8401 > Project: Flink > Issue Type: Improvement > Components: Cassandra Connector >Reporter: Shuyi Chen >Assignee: Shuyi Chen >Priority: Major > > Currently it will throw an exception and fail the entire job, we would like > to keep the current default behavior, but refactor the code to allow subclass > to override and customize the failure handling. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8401) Allow subclass to override write-failure behavior in CassandraOutputFormat
[ https://issues.apache.org/jira/browse/FLINK-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326137#comment-16326137 ] ASF GitHub Bot commented on FLINK-8401: --- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5274#discussion_r161489425 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java --- @@ -66,6 +66,13 @@ public void configure(Configuration parameters) { this.cluster = builder.getCluster(); } + protected void onWriteSuccess(ResultSet ignored) { + } + + protected void onWriteFailure(Throwable t) { --- End diff -- JavaDocs missing > Allow subclass to override write-failure behavior in CassandraOutputFormat > --- > > Key: FLINK-8401 > URL: https://issues.apache.org/jira/browse/FLINK-8401 > Project: Flink > Issue Type: Improvement > Components: Cassandra Connector >Reporter: Shuyi Chen >Assignee: Shuyi Chen >Priority: Major > > Currently it will throw an exception and fail the entire job, we would like > to keep the current default behavior, but refactor the code to allow subclass > to override and customize the failure handling. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8401) Allow subclass to override write-failure behavior in CassandraOutputFormat
[ https://issues.apache.org/jira/browse/FLINK-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326136#comment-16326136 ] ASF GitHub Bot commented on FLINK-8401: --- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5274#discussion_r161489395 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java --- @@ -66,6 +66,13 @@ public void configure(Configuration parameters) { this.cluster = builder.getCluster(); } + protected void onWriteSuccess(ResultSet ignored) { --- End diff -- JavaDocs missing > Allow subclass to override write-failure behavior in CassandraOutputFormat > --- > > Key: FLINK-8401 > URL: https://issues.apache.org/jira/browse/FLINK-8401 > Project: Flink > Issue Type: Improvement > Components: Cassandra Connector >Reporter: Shuyi Chen >Assignee: Shuyi Chen >Priority: Major > > Currently it will throw an exception and fail the entire job, we would like > to keep the current default behavior, but refactor the code to allow subclass > to override and customize the failure handling. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8401) Allow subclass to override write-failure behavior in CassandraOutputFormat
[ https://issues.apache.org/jira/browse/FLINK-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319947#comment-16319947 ] ASF GitHub Bot commented on FLINK-8401: --- GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/5274 [FLINK-8401][Cassandra Connector]Refactor CassandraOutputFormat to allow subclass to customize the faiā¦ ## What is the purpose of the change Refactor CassandraOutputFormat to allow subclass to customize the failure handling logic. ## Brief change log - Added to protected methods for handling cassandra write result, these allow subclass to override them to customize. ## Verifying this change This change is already covered by existing tests. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/suez1224/flink flink-8401 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5274.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5274 commit 8f6ae5636e549d7fe2f0788591acc8880c01af45 Author: Shuyi Chen Date: 2018-01-10T09:17:55Z Refactor CassandraOutputFormat to allow subclass to customize the failure handling logic > Allow subclass to override write-failure behavior in CassandraOutputFormat > --- > > Key: FLINK-8401 > URL: https://issues.apache.org/jira/browse/FLINK-8401 > Project: Flink > Issue Type: Improvement > Components: Cassandra Connector >Reporter: Shuyi Chen >Assignee: Shuyi Chen > > Currently it will throw an exception and fail the entire job, we would like > to keep the current default behavior, but refactor the code to allow subclass > to override and customize the failure handling. -- This message was sent by Atlassian JIRA (v6.4.14#64029)