[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443684#comment-16443684
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5852
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442591#comment-16442591
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5852
merging.
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440279#comment-16440279
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
@zhangminglei ,can you cc
[FLINK-9187](https://issues.apache.org/jira/browse/FLINK-9187)
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440265#comment-16440265
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
ok
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440264#comment-16440264
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5857
Yes. Apache hadoop is also different from apache flink. we should obey the
rules.
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440266#comment-16440266
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user lamber-ken closed the pull request at:
https://github.com/apache/flink/pull/5857
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440261#comment-16440261
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
ok, I see, thanks a lot.
I contributed to [ClickHouse](https://github.com/yandex/ClickHouse) before,
the submission process is different.
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440260#comment-16440260
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5857
Yes. You should create the JIRA first. Then, push a PR to the corresponding
jira number.
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440257#comment-16440257
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
ok, I see. I'll close the PR.
by the way, need to create jira first, and then PR?
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440256#comment-16440256
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5857
Not ok. 9189 seems does not exist since you can not access that. You can
check it.
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440254#comment-16440254
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
ok, I see. I'll close the PR.
use `FLINK-9189`, ok?
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440249#comment-16440249
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5857
@lamber-ken You push your code to the incorrect jira number, flink-9180.
But it is not relevant to your issue. you can check this out :
https://issues.apache.org/jira/browse/FLINK-9180.
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440248#comment-16440248
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
wrong place? can you point it out, I don't know. thank you
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440230#comment-16440230
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5857
And I will delete the incorrect link from the flink-9180 jira. Let you know.
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440229#comment-16440229
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5857
Hi, You push to the wrong place.
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439468#comment-16439468
]
ASF GitHub Bot commented on FLINK-9180:
---
GitHub user lamber-ken opened a pull request:
https://github.com/apache/flink/pull/5857
[FLINK-9180][METRICS] add prometheus pushgateway reporter
## What is the purpose of the change
This pull request makes flink system can send metrics to prometheus via
pushgateway. when using `yarn-cluster` model, it's useful.
## Brief change log
- Add prometheus pushgateway repoter
- Restructure the code of the promethues reporter part
## Verifying this change
This change is already covered by existing tests. [prometheus
test](https://github.com/apache/flink/tree/master/flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus)
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (JavaDocs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lamber-ken/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5857.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5857
commit a3503a5d08e4d02d6cf38d656e2697d3b1197cf1
Author: lamber-ken
Date: 2018-04-16T13:49:56Z
add prometheus pushgateway reporter
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439406#comment-16439406
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5852
Let us wait the CI ending.
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439375#comment-16439375
]
ASF GitHub Bot commented on FLINK-9180:
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5852
Sorry. @zentol . I misunderstand. Will update.
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9180) Remove REST_ prefix from rest options
[
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439262#comment-16439262
]
ASF GitHub Bot commented on FLINK-9180:
---
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/5852
[FLINK-9180] [conf] Remove REST_ prefix from rest options
## What is the purpose of the change
Remove REST_ prefix from rest options
## Brief change log
Update ```RestOptions.java``` for removing prefix rest_
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-9180
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5852.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5852
commit 711474f663f41025b42e4abb4c35315b426aff57
Author: zhangminglei
Date: 2018-04-16T10:36:30Z
[FLINK-9180] [conf] Remove REST_ prefix from rest options
> Remove REST_ prefix from rest options
> -
>
> Key: FLINK-9180
> URL: https://issues.apache.org/jira/browse/FLINK-9180
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Critical
> Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far
> we went with the convention that we do not have such prefixes if it already
> contained in the class name, hence we should remove it from the field names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
